Migrate window-bounds persistence off the electron-window-state library into a WindowManager built-in `rememberBounds` capability, backed by the main-process persist cache (`window.bounds` key — its first real consumer). - New `windowBoundsTracker` free-function module: validates the stored record (including displayBounds), restores onto the display the window was last on (clamping into its work area, never resetting to primary), and snapshots at teardown via getNormalBounds + isMaximized. - Singleton-only gate (dev warning for non-singleton types). Runtime toggle `wm.setRememberBounds` (orthogonal to the registry flag; OFF drops only that type's slot) plus `wm.peekWindowBounds`. - Persist at three teardown exits: native close (singletons), before window.destroy() in destroyWindow (programmatic destroys), and a new onStop so shutdown writes land before CacheService flushes its persist map. - Wire Main + QuickAssistant. Main re-applies maximize consumer-side on its own show schedule (tray-on-launch defers to first show); remove electron-window-state and its orphaned keepers/constants/comments. Fullscreen is not persisted and old *-state.json is not migrated (one-time reset, loseable). Adds tracker/integration/persist tests, extends the main CacheService mock with persist methods, and documents the capability plus a breaking-change note.
8.4 KiB
WindowManager Overview
Architecture, lifecycle modes, and event timing contract for WindowManager.
WindowManager is an @Injectable() service (Phase.WhenReady, priority 5) registered in the lifecycle system. Window configurations live in windowRegistry.ts; WindowManager consumes them at runtime.
Core Type Relationships
WindowType (enum)
└─ WindowTypeMetadata (discriminated union on `lifecycle`)
├─ { lifecycle: 'default' }
├─ { lifecycle: 'singleton', singletonConfig?: SingletonConfig }
└─ { lifecycle: 'pooled', poolConfig: PoolConfig }
WindowManager
├─ windows: Map<windowId, ManagedWindow> ── all tracked windows
├─ windowsByType: Map<WindowType, Set<windowId>> ── type index
├─ warmupStates: Map<WindowType, WarmupState> ── per-type warmup state (pool + singleton)
└─ initDataStore: Map<windowId, unknown> ── one-shot init data
Three Lifecycle Modes
┌────────── open() ──────────┐
│ │
│ ┌─────────────────────┐ │
│ │ lifecycle check │ │
│ └────────┬────────────┘ │
│ ┌────┼────┐ │
│ ▼ ▼ ▼ │
│ default singleton pooled│
│ │ │ │ │
│ │ existing? idle? │
│ │ ┌──┴──┐ ┌──┴──┐ │
│ │ Y N Y N │
│ │ │ │ │ │ │
│ │ show() │ recycle │ │
│ │ focus() │ │ │ │
│ │ │ ▼ │ ▼ │
│ └─────┼─ create() ──┘ │
│ │ │ │
│ ▼ ▼ │
│ return windowId │
└─────────────────────────────┘
default — Create on Open, Destroy on Close
Multi-instance mode. Every open() call creates a fresh window. close() destroys it permanently.
Use for: windows that appear many times simultaneously (e.g., sub windows).
// windowRegistry.ts
WINDOW_TYPE_REGISTRY[WindowType.SubWindow] = {
type: WindowType.SubWindow,
lifecycle: 'default',
htmlPath: 'sub-window.html',
windowOptions: { ...DEFAULT_WINDOW_CONFIG },
}
// Usage — each call creates a new window
const tab1 = wm.open(WindowType.SubWindow)
const tab2 = wm.open(WindowType.SubWindow)
wm.close(tab1) // destroyed
singleton — At Most One Instance, Reuse on Open
Only one instance can exist at a time. open() shows and focuses the existing window if present; creates one if absent. create() throws if one already exists.
Use for: windows that should never have duplicates (e.g., main window, settings).
WINDOW_TYPE_REGISTRY[WindowType.Main] = {
type: WindowType.Main,
lifecycle: 'singleton',
htmlPath: 'index.html',
windowOptions: { ...DEFAULT_WINDOW_CONFIG, minWidth: 350, minHeight: 400 },
}
// First call creates; second call shows + focuses the existing window
const id1 = wm.open(WindowType.Main) // creates
const id2 = wm.open(WindowType.Main) // shows + focuses, id2 === id1
Optional singletonConfig: enable eager pre-warm and/or close→hide with delayed destroy. See Warmup Mechanics → Singleton Variant.
pooled — Two-Axis Pool with Active Standby + Passive Recycle
Windows are reused rather than destroyed. The pool has two orthogonal axes:
- Producer axis (
standbySize): Pre-warmed spares are always maintained in the idle queue, actively replenished on everyopen()viasetImmediate. Guarantees zero-wait for the next caller regardless of concurrent usage. - Consumer axis (
recycleMinSize/recycleMaxSize): Onclose(), windows are pushed back to the idle queue (bounded byrecycleMaxSize) for reuse.recycleMinSizeis a passive decay floor.
Both axes are independently enabled via config. open() pops an idle window (firing WindowManager_Reused IPC when initData is provided) or creates fresh if empty. close() either recycles or destroys depending on the recycle config.
Use for: frequently opened windows where creation cost is high (selection actions, screenshot overlays).
// Example: SelectionAction — hybrid (standby + recycle).
WINDOW_TYPE_REGISTRY[WindowType.SelectionAction] = {
type: WindowType.SelectionAction,
lifecycle: 'pooled',
htmlPath: 'selectionAction.html',
poolConfig: {
standbySize: 1, // always keep 1 pre-warmed spare
recycleMaxSize: 3, // recycle up to 3 windows for burst handling
decayInterval: 60, // decay one excess idle per minute
inactivityTimeout: 300, // after 5min idle, trim back to standbySize
warmup: 'eager'
},
windowOptions: { ...DEFAULT_WINDOW_CONFIG, width: 400, height: 300 },
}
See Warmup Mechanics for the full pool configuration matrix, GC timer behavior, warmup strategies, and suspend/resume semantics. Note that the inactivity timer resets on both open() and close() (via lastActivityAt), so a long-held-then-closed window does not immediately trigger a trim.
Key Features
| Feature | Description |
|---|---|
| Lifecycle modes | default, singleton, pooled — covers all window patterns |
Window lifecycle hooks (onWindowCreated / onWindowDestroyed, plus type-filtered onWindowCreatedByType / onWindowDestroyedByType) |
Domain services inject behavior at creation and clean up on destruction via typed Emitter<ManagedWindow> events |
broadcast() / broadcastToType() |
IPC fan-out to all or type-filtered windows |
open({ initData }) / create({ initData }) / setInitData() / getInitData() |
Init payload passed atomically on open/create; automatically pushed to renderer via WindowManager_Reused on reuse paths |
suspendPool() / resumePool() |
Pause pool tracking without destroying in-use windows |
| macOS Dock visibility management | Existence-based: Dock is visible while any window with behavior.macShowInDock !== false is alive (not destroyed). Services express tray-mode intent via wm.behavior.setMacShowInDockByType(type, value) to temporarily opt a type out of Dock contribution. Matches native macOS semantics where Cmd+W does not remove the app from the Dock. |
setTitleBarOverlay() |
Batch update overlay on all applicable windows |
Bounds persistence (rememberBounds) |
Singleton-only opt-in to persist & restore a window's position/size across launches (onto its last display), backed by the main persist cache. Runtime-toggleable via wm.setRememberBounds. See README → Bounds Persistence. |
Event Timing Contract
The createWindow() method follows a strict 5-step execution order:
1. new BrowserWindow(config) ── native window exists
2. setupWindowListeners() ── close/closed/show/hide handlers attached
3. windows.set() / windowsByType ── window is queryable
4. _onWindowCreated.fire() ── domain services inject behavior (sync)
5. loadWindowContent() ── HTML loads, ready-to-show may fire
Why This Order Matters
- Step 2 before 4: Internal lifecycle handlers (pool interception, Dock tracking) are in place before any domain code runs.
- Step 3 before 4: Domain services can call
getWindow(),getWindowInfo(), etc. inside theonWindowCreatedcallback. - Step 4 before 5: Domain services can attach
ready-to-show,did-finish-load, and other content-dependent listeners with the guarantee that content has not started loading yet.
Guarantees
onWindowCreatedfires exactly once per window, synchronously.- Content loading (step 5) is skipped when
metadata.htmlPathis empty — the domain service is responsible for loading content. - For pooled windows,
onWindowCreatedfires only on fresh creation — recycled opens do NOT re-fire, because the BrowserWindow is already created and tracked. Per-instance listeners (e.g.resized, per-windowclosedcleanup) must therefore be attached insideonWindowCreated, not at theopen()call site — otherwise a recycled window would either miss the listener on first reuse or accumulate duplicates across successive opens.