diff --git a/plan-design-review/SKILL.md b/plan-design-review/SKILL.md index 539175b4a..ca3ea58f8 100644 --- a/plan-design-review/SKILL.md +++ b/plan-design-review/SKILL.md @@ -803,6 +803,21 @@ to find missing design decisions and ADD THEM TO THE PLAN before implementation. The output of this skill is a better plan, not a document about the plan. +## Scope gate (FIRST — overrides everything below). This is a hard STOP. + +Before ANYTHING else in this skill — before the designer/mockup guidance, the Design Principles, the Priority Hierarchy, the pre-review system audit, and any `git` / `Read` / `Grep` / `Glob` / `Bash` call or mockup generation — your VERY FIRST tool call MUST be AskUserQuestion, to confirm the review target. The "generate mockups by default", "don't ask permission", and "never skip the audit/mockups" instructions below apply ONLY AFTER the user has answered this gate. + +1. First tool call = AskUserQuestion (tool_use). Confirm what to review. +2. Do NOT run any tool, generate any mockup, or begin the audit before the user answers. +3. If AskUserQuestion is disallowed (`--disallowedTools`), render the options as plain prose — each on its own line starting with the letter and paren at column 0 (no blockquote, no leading `>`) — then STOP and wait. Use exactly this shape: + +What should I review? +A) The current branch diff — the work in progress on this branch. +B) A plan or design doc I'll paste or point you to. +C) A specific page, file, or path. + +Recommendation: A when a branch diff exists, otherwise B. Reply with A, B, or C. STOP and wait for the answer — only after the user picks do you run the pre-review audit, generate mockups, and work Step 0 against that target. + ## Design Philosophy You are not here to rubber-stamp this plan's UI. You are here to ensure that when @@ -960,6 +975,8 @@ Never skip Step 0 or mockup generation (when the designer is available). Mockups ## PRE-REVIEW SYSTEM AUDIT (before Step 0) +> Reminder: the **Scope gate** at the top of this skill is a hard STOP. Do not run this audit until the user has answered it. + Before reviewing the plan, gather context: ```bash diff --git a/plan-design-review/SKILL.md.tmpl b/plan-design-review/SKILL.md.tmpl index e1d1c67f5..7178c991e 100644 --- a/plan-design-review/SKILL.md.tmpl +++ b/plan-design-review/SKILL.md.tmpl @@ -35,6 +35,21 @@ to find missing design decisions and ADD THEM TO THE PLAN before implementation. The output of this skill is a better plan, not a document about the plan. +## Scope gate (FIRST — overrides everything below). This is a hard STOP. + +Before ANYTHING else in this skill — before the designer/mockup guidance, the Design Principles, the Priority Hierarchy, the pre-review system audit, and any `git` / `Read` / `Grep` / `Glob` / `Bash` call or mockup generation — your VERY FIRST tool call MUST be AskUserQuestion, to confirm the review target. The "generate mockups by default", "don't ask permission", and "never skip the audit/mockups" instructions below apply ONLY AFTER the user has answered this gate. + +1. First tool call = AskUserQuestion (tool_use). Confirm what to review. +2. Do NOT run any tool, generate any mockup, or begin the audit before the user answers. +3. If AskUserQuestion is disallowed (`--disallowedTools`), render the options as plain prose — each on its own line starting with the letter and paren at column 0 (no blockquote, no leading `>`) — then STOP and wait. Use exactly this shape: + +What should I review? +A) The current branch diff — the work in progress on this branch. +B) A plan or design doc I'll paste or point you to. +C) A specific page, file, or path. + +Recommendation: A when a branch diff exists, otherwise B. Reply with A, B, or C. STOP and wait for the answer — only after the user picks do you run the pre-review audit, generate mockups, and work Step 0 against that target. + ## Design Philosophy You are not here to rubber-stamp this plan's UI. You are here to ensure that when @@ -109,6 +124,8 @@ Never skip Step 0 or mockup generation (when the designer is available). Mockups ## PRE-REVIEW SYSTEM AUDIT (before Step 0) +> Reminder: the **Scope gate** at the top of this skill is a hard STOP. Do not run this audit until the user has answered it. + Before reviewing the plan, gather context: ```bash diff --git a/plan-eng-review/SKILL.md b/plan-eng-review/SKILL.md index 58c5cc9c4..6859e428f 100644 --- a/plan-eng-review/SKILL.md +++ b/plan-eng-review/SKILL.md @@ -767,6 +767,21 @@ Skills that run plan reviews (`/plan-*-review`, `/codex review`) include the EXI Review this plan thoroughly before making any code changes. For every issue or recommendation, explain the concrete tradeoffs, give me an opinionated recommendation, and ask for my input before assuming a direction. +## Scope gate (FIRST — overrides everything below). This is a hard STOP. + +Before ANYTHING else in this skill — before the Design Doc Check, the office-hours prerequisite offer, Step 0, and any `git` / `Read` / `Grep` / `Glob` / `Bash` call — your VERY FIRST tool call MUST be AskUserQuestion, to confirm the review target. Do not run the Design Doc Check bash or explore the repo before the user answers. + +1. First tool call = AskUserQuestion (tool_use). Confirm what to review. +2. Do NOT call `git log` / `git diff` / `grep` / `Read` / `Glob` / `Bash`, begin any review section, or write any plan, before the user answers. +3. If AskUserQuestion is disallowed (`--disallowedTools`), render the options as plain prose — each on its own line starting with the letter and paren at column 0 (no blockquote, no leading `>`) — then STOP and wait. Use exactly this shape: + +What should I review? +A) The current branch diff — the work in progress on this branch. +B) A plan or design doc I'll paste or point you to. +C) A specific file, directory, or path. + +Recommendation: A when a branch diff exists, otherwise B. Reply with A, B, or C. STOP and wait for the answer — only after the user picks do you run the Design Doc Check and Step 0 against that target. + ## Priority hierarchy If the user asks you to compress or the system triggers context compaction: Step 0 > Test diagram > Opinionated recommendations > Everything else. Never skip Step 0 or the test diagram. Do not preemptively warn about context limits -- the system handles compaction automatically. @@ -920,6 +935,9 @@ If a design doc is now found, read it and continue the review. If none was produced (user may have cancelled), proceed with standard review. ### Step 0: Scope Challenge + +> Reminder: the **Scope gate** at the top of this skill is a hard STOP. Do not run Step 0 until the user has answered it, and run it against the target they chose. + Before reviewing anything, answer these questions: 1. **What existing code already partially or fully solves each sub-problem?** Can we capture outputs from existing flows rather than building parallel ones? 2. **What is the minimum set of changes that achieves the stated goal?** Flag any work that could be deferred without blocking the core objective. Be ruthless about scope creep. diff --git a/plan-eng-review/SKILL.md.tmpl b/plan-eng-review/SKILL.md.tmpl index 89fc5eee5..1d5be0e6f 100644 --- a/plan-eng-review/SKILL.md.tmpl +++ b/plan-eng-review/SKILL.md.tmpl @@ -37,6 +37,21 @@ triggers: Review this plan thoroughly before making any code changes. For every issue or recommendation, explain the concrete tradeoffs, give me an opinionated recommendation, and ask for my input before assuming a direction. +## Scope gate (FIRST — overrides everything below). This is a hard STOP. + +Before ANYTHING else in this skill — before the Design Doc Check, the office-hours prerequisite offer, Step 0, and any `git` / `Read` / `Grep` / `Glob` / `Bash` call — your VERY FIRST tool call MUST be AskUserQuestion, to confirm the review target. Do not run the Design Doc Check bash or explore the repo before the user answers. + +1. First tool call = AskUserQuestion (tool_use). Confirm what to review. +2. Do NOT call `git log` / `git diff` / `grep` / `Read` / `Glob` / `Bash`, begin any review section, or write any plan, before the user answers. +3. If AskUserQuestion is disallowed (`--disallowedTools`), render the options as plain prose — each on its own line starting with the letter and paren at column 0 (no blockquote, no leading `>`) — then STOP and wait. Use exactly this shape: + +What should I review? +A) The current branch diff — the work in progress on this branch. +B) A plan or design doc I'll paste or point you to. +C) A specific file, directory, or path. + +Recommendation: A when a branch diff exists, otherwise B. Reply with A, B, or C. STOP and wait for the answer — only after the user picks do you run the Design Doc Check and Step 0 against that target. + ## Priority hierarchy If the user asks you to compress or the system triggers context compaction: Step 0 > Test diagram > Opinionated recommendations > Everything else. Never skip Step 0 or the test diagram. Do not preemptively warn about context limits -- the system handles compaction automatically. @@ -98,6 +113,9 @@ If a design doc exists, read it. Use it as the source of truth for the problem s {{BENEFITS_FROM}} ### Step 0: Scope Challenge + +> Reminder: the **Scope gate** at the top of this skill is a hard STOP. Do not run Step 0 until the user has answered it, and run it against the target they chose. + Before reviewing anything, answer these questions: 1. **What existing code already partially or fully solves each sub-problem?** Can we capture outputs from existing flows rather than building parallel ones? 2. **What is the minimum set of changes that achieves the stated goal?** Flag any work that could be deferred without blocking the core objective. Be ruthless about scope creep.