mirror of
https://github.com/github/spec-kit.git
synced 2026-08-03 06:26:30 +08:00
fix(workflows): guard non-mapping 'inputs:' block in engine._resolve_inputs (#3696)
execute()/resume() run UNVALIDATED definitions (load_workflow does not
validate). WorkflowDefinition stores `inputs` raw, so a non-mapping
`inputs:` block (bare `inputs:` -> None, or `inputs: []`) crashed
_resolve_inputs at `for name, input_def in definition.inputs.items()` with
AttributeError, aborting the whole run.
Return {} when inputs is not a mapping, mirroring validate_workflow's own
`isinstance(definition.inputs, dict)` check. Protects both call sites
(execute and resume); normal dict resolution is unchanged.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -3612,6 +3612,23 @@ class TestWorkflowDefinition:
|
||||
assert definition.id == "test-workflow"
|
||||
assert len(definition.inputs) == 2
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"block",
|
||||
[
|
||||
"workflow:\n id: w\n name: W\nsteps: []\ninputs: []\n", # list
|
||||
"workflow:\n id: w\n name: W\nsteps: []\ninputs:\n", # null
|
||||
],
|
||||
)
|
||||
def test_resolve_inputs_tolerates_non_mapping_inputs(self, block):
|
||||
# execute()/resume() run UNVALIDATED definitions; a non-mapping `inputs:`
|
||||
# block (list/null) is stored raw and would crash _resolve_inputs at
|
||||
# `.items()`. It must be treated as "no inputs" instead.
|
||||
from specify_cli.workflows.engine import WorkflowDefinition, WorkflowEngine
|
||||
|
||||
definition = WorkflowDefinition.from_string(block)
|
||||
resolved = WorkflowEngine()._resolve_inputs(definition, {}) # must not raise
|
||||
assert resolved == {}
|
||||
|
||||
def test_from_string_invalid(self):
|
||||
from specify_cli.workflows.engine import WorkflowDefinition
|
||||
|
||||
|
||||
Reference in New Issue
Block a user