2 Commits

Author	SHA1	Message	Date
darion-yaphet	826e193cee	refactor: move extension command handlers to extensions/_commands.py (PR-7/8) (#3014) ... * refactor: move extension command handlers to extensions/_commands.py (PR-7/8) Convert the flat extensions.py module into an extensions/ package and extract all extension_app and catalog_app command handlers plus their private helpers (_resolve_installed_extension, _resolve_catalog_extension, _print_extension_info) out of __init__.py into the new extensions/_commands.py, mirroring the domain-dir layout used for presets/_commands.py (PR-6) and integrations/_commands.py (PR-5). - extensions.py -> extensions/__init__.py (pure rename, 99%); intra-module relative imports bumped from `.x` to `..x` since they reference root siblings. - Root helpers (_require_specify_project, _locate_bundled_extension, load_init_options, _display_project_path) are reached through thin shims that re-fetch from the parent package at call time, so test monkeypatching of specify_cli.<helper> keeps working unchanged. - __init__.py drops ~1444 lines (3511 -> 2067); CLI surface preserved via register(app). No behavior change. Full suite failure set is identical before/after (82 pre-existing env failures, 0 new). * fix(extensions): preserve per-command path in update backup for skills agents Skills agents (extension == "/SKILL.md") name every command file SKILL.md, each in its own per-command subdir (e.g. speckit-plan/SKILL.md). The update backup keyed the backup path on cmd_file.name alone, so all of an agent's skill files collided onto a single backup path — each shutil.copy2 overwrote the previous one, and rollback restored one skill's content over all the others, corrupting or losing the rest. Mirror the real on-disk layout by using cmd_file.relative_to(commands_dir), keeping each backup path unique. This also makes backed_up_command_files values unique so restore copies the correct content back to each command. Add a regression test asserting two distinct skill files survive a backup -> failed-update -> rollback cycle with their own content. * style(extensions): use yaml.safe_dump when writing catalog config The catalog add/remove handlers wrote the integration catalog config with yaml.dump. Switch to yaml.safe_dump to align with the SafeDumper used by the presets commands and to refuse emitting !!python/object tags if a non-basic value ever reaches the config dict. Output is unchanged for the current basic-type payload (str/int/bool/dict/ list) — this is a defensive/consistency change, not a behavioral fix. * fix(extensions): correct _print_cli_warning import path in skill registration register_enabled_extensions_for_agent imported _print_cli_warning from `.` (the extensions package), but the helper lives in the parent specify_cli package. The wrong level raised ImportError inside the error handlers, aborting extension/skill registration on the first failure instead of warning and continuing. Use `..` to match the other parent-package imports. * fix(extensions): escape untrusted values in Rich markup output User-provided arguments and extension/catalog metadata (names, descriptions, versions, IDs, paths) were interpolated into Rich markup strings without escaping. Values containing markup sequences (e.g. [red]...) would be parsed as markup, allowing output injection that could corrupt or mislead CLI messages. Wrap all such interpolations with rich.markup.escape across the extension/catalog command handlers: list, search, info (_print_extension_info), add (including --dev paths), remove, enable, disable, set-priority, update, and the ambiguous-match resolvers (error strings and Table rows). Reuse the already-computed safe_extension where available. Escaping is a no-op for benign strings, so normal output is unchanged. * Prevent Rich markup injection in extension CLI output User-controlled catalog URLs and extension IDs are rendered through Rich-enabled console paths, so every remaining output-only interpolation now escapes markup while leaving stored values and filesystem behavior unchanged. Regression tests cover catalog add, install hints, remove hints, and state command messages with bracketed markup-like values. * Prevent markup injection from exception text Rich markup remains enabled for styled CLI messages, so exception text and config path labels must be escaped before rendering. YAML parser errors, URL validation failures, download errors, and extension validation errors can include user-controlled catalog or manifest values. Constraint: Preserve existing exception handling and user-facing error paths Rejected: Disable Rich markup for these messages | existing output intentionally uses markup for labels and styling Confidence: high Scope-risk: narrow Directive: Escape user-controlled exception text before interpolating into Rich-rendered strings Tested: .venv/bin/python -m pytest tests/test_extensions.py -q Co-authored-by: OmX <omx@oh-my-codex.dev> * Prevent path and manifest review regressions Catalog path labels are rendered through Rich markup and downloaded update manifests are trusted long enough to validate extension IDs. Escape displayed project paths before rendering, and reject non-mapping extension.yml payloads before ID validation so bad archives fail with a clear rollback reason. --------- Co-authored-by: OmX <omx@oh-my-codex.dev>	2026-06-22 13:40:57 -05:00
Dyan Galih	59fdca5997	fix(cli): harden extension registration and discovery workflows (#2499) ... * chore: update community catalog with latest extension versions - Update memory-md from 0.7.9 to 0.8.0 - Update architecture-guard from 1.6.7 to 1.8.0 * fix(cli): harden extension registration with project-level tracking in extensions.yml * test(cli): add comprehensive unit tests for extension registration logic * chore: remove out-of-scope catalog changes * refactor: address PR feedback for extension registration hardening * fix: harden extension registration defensive logic and add comprehensive unregister_hooks tests - Add dict guard to register_hooks() to handle corrupted extensions.yml (non-dict root) - Add 5 comprehensive tests for unregister_hooks() workflow: * Full workflow with hooks + installed list removal * Resilience when config has no 'hooks' key * Corrupted YAML handling * Multiple extension scenarios * All 11 tests passing * fix: sanitize installed to strings, guard unregister_hooks dict, handle null hook values - register_extension(): filter non-string entries from installed before sort - register_hooks(): normalize hooks to {} when missing or not a dict - unregister_hooks(): add isinstance(config, dict) guard before key checks - unregister_hooks(): coerce null/scalar hook lists to [] before iteration - tests: add 3 regression tests for no-hooks manifest, mixed-type installed, null hook values - All 14 tests passing * fix(cli): persist sanitization results and harden hook registration * Harden extension registration to always persist sanitization results * Hardening extension registration: support mapping entries, improve persistence, and fix update rollback * fix(cli): harden extension update and unregistration workflows * fix(cli): move update sentinels outside try block to prevent NameError on rollback * fix(cli): sanitize hook event lists in register_hooks to prevent crashes * fix(cli): deduplicate hook entries and harden rollback hooks-restore guards * test(cli): add regression tests for extension update and rollback hardening * fix(cli): deduplicate installed list by id in register_extension * fix(cli): consolidate and harden extension update rollback logic * fix(cli): initialize backup_registry_entry before try block to prevent UnboundLocalError on rollback * fix(tests): return Path from download_extension mock and add Path import * fix(cli): normalize get_project_config() return to dict; deduplicate in unregister_extension() * fix(cli): normalize hooks/installed/settings in get_project_config(); use tmp_path-scoped zip in tests * fix(cli): set modified=True on hook coercion in rollback; sanitize hook event values in get_project_config(); harden test assertions * fix(cli): filter non-dict hook entries in get_project_config(); remove dead MISSING sentinel * fix(cli): gate extensions.yml rollback on backup_hooks is not None; update stale comment * fix(cli): move _AgentReg import outside try block; assert result.exception is None in tests * fix(extensions): consistent key order in default config; deep-copy backup_installed * test: fix misleading comment; assert exit_code==1 in rollback test * test: clean up duplicate imports in hardening tests * refactor(extensions): extract _sanitize_installed_list helper; strengthen hook unregister assertion * fix(extensions): validate extension IDs in _sanitize_installed_list; clarify test comment	2026-05-13 12:02:01 -05:00