mirror of
https://github.com/github/spec-kit.git
synced 2026-08-03 06:26:30 +08:00
* feat(workflows): expose workflow source directory to steps (#3467) Propagate WorkflowDefinition.source_path to steps via {{ context.workflow_dir }} in template expressions and SPECKIT_WORKFLOW_DIR env var for shell steps. The original source directory is persisted in state.json so resume restores the correct value instead of the run-directory copy path. Closes #3467 Assisted-By: 🤖 Claude Code * fix: apply bot review suggestions (#2) Applied fixes from bot review comments: - Comment #3563319058: prevent stale SPECKIT_WORKFLOW_DIR leak from parent env - Comment #3563319094: use cross-platform Python one-liner instead of printenv - Comment #3563319103: add monkeypatch.delenv for deterministic env var test - Comment #3563319116: same env leak fix as #3563319058 Assisted-By: 🤖 Claude Code * fix: use YAML single-quotes and forward-slash paths for Windows CI (#2) sys.executable on Windows returns backslash paths (D:\a\...) which YAML double-quoted strings interpret as escape sequences. Switch to single-quoted YAML strings and normalize paths with replace("\\", "/"). Assisted-By: 🤖 Claude Code * fix: resolve workflow_dir to absolute path and add installed-by-ID test (#3469) Applied fixes from bot review comments: - Comment #3563382853: resolve source_path before taking parent to ensure absolute paths - Comment #3563382864: add test for installed-by-ID workflow_dir semantics Assisted-By: 🤖 Claude Code * docs: document context.workflow_dir and SPECKIT_WORKFLOW_DIR Add reference documentation for the new workflow_dir runtime value in both workflows/README.md and docs/reference/workflows.md so workflow authors can discover the feature and its semantics. Assisted-By: 🤖 Claude Code * fix: clarify installed workflow_dir is an absolute path (#3469) The documentation for context.workflow_dir described the installed-by-ID case as ".specify/workflows/<id>/" which appears relative, contradicting the "resolved absolute path" semantics. Clarified that it is the absolute path to the installation directory. Assisted-By: 🤖 Claude Code * fix: apply bot review suggestions (#3469) Applied fixes from bot review comments: - Comment #3580005128: Quote sys.executable in shell step env var test - Comment #3580005174: Quote sys.executable in no-env-var test Assisted-By: 🤖 Claude Code * fix: apply bot review suggestions (#3469) Applied fixes from bot review comments: - Comment #3587146944: Quote interpolated workflow_dir path in example Assisted-By: 🤖 Claude Code
144 lines
4.2 KiB
Python
144 lines
4.2 KiB
Python
"""Base classes for workflow step types.
|
|
|
|
Provides:
|
|
- ``StepBase`` — abstract base every step type must implement.
|
|
- ``StepContext`` — execution context passed to each step.
|
|
- ``StepResult`` — return value from step execution.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from abc import ABC, abstractmethod
|
|
from dataclasses import dataclass, field
|
|
from enum import Enum
|
|
from typing import Any
|
|
|
|
|
|
class StepStatus(str, Enum):
|
|
"""Status of a step execution."""
|
|
|
|
PENDING = "pending"
|
|
RUNNING = "running"
|
|
COMPLETED = "completed"
|
|
FAILED = "failed"
|
|
SKIPPED = "skipped"
|
|
PAUSED = "paused"
|
|
|
|
|
|
class RunStatus(str, Enum):
|
|
"""Status of a workflow run."""
|
|
|
|
CREATED = "created"
|
|
RUNNING = "running"
|
|
PAUSED = "paused"
|
|
COMPLETED = "completed"
|
|
FAILED = "failed"
|
|
ABORTED = "aborted"
|
|
|
|
|
|
@dataclass
|
|
class StepContext:
|
|
"""Execution context passed to each step.
|
|
|
|
Contains everything the step needs to resolve expressions, dispatch
|
|
commands, and record results.
|
|
"""
|
|
|
|
#: Resolved workflow inputs (from user prompts / defaults).
|
|
inputs: dict[str, Any] = field(default_factory=dict)
|
|
|
|
#: Accumulated step results keyed by step ID. Each entry is the dict the
|
|
#: engine persists per step:
|
|
#: ``{"type": ..., "integration": ..., "model": ..., "options": ...,
|
|
#: "input": ..., "output": ..., "status": ...}``.
|
|
steps: dict[str, dict[str, Any]] = field(default_factory=dict)
|
|
|
|
#: Current fan-out item (set only inside fan-out iterations).
|
|
item: Any = None
|
|
|
|
#: Fan-in aggregated results (set only for fan-in steps).
|
|
fan_in: dict[str, Any] = field(default_factory=dict)
|
|
|
|
#: Workflow-level default integration key.
|
|
default_integration: str | None = None
|
|
|
|
#: Workflow-level default model.
|
|
default_model: str | None = None
|
|
|
|
#: Workflow-level default options.
|
|
default_options: dict[str, Any] = field(default_factory=dict)
|
|
|
|
#: Project root path.
|
|
project_root: str | None = None
|
|
|
|
#: Current run ID.
|
|
run_id: str | None = None
|
|
|
|
#: Source directory of the workflow definition file.
|
|
workflow_dir: str | None = None
|
|
|
|
|
|
@dataclass
|
|
class StepResult:
|
|
"""Return value from a step execution."""
|
|
|
|
#: Step status.
|
|
status: StepStatus = StepStatus.COMPLETED
|
|
|
|
#: Output data (stored as ``steps.<id>.output``).
|
|
output: dict[str, Any] = field(default_factory=dict)
|
|
|
|
#: Nested steps to execute (for control-flow steps like if/then).
|
|
next_steps: list[dict[str, Any]] = field(default_factory=list)
|
|
|
|
#: Error message if step failed.
|
|
error: str | None = None
|
|
|
|
|
|
class StepBase(ABC):
|
|
"""Abstract base class for workflow step types.
|
|
|
|
Every step type — built-in or extension-provided — implements this
|
|
interface and registers in ``STEP_REGISTRY``.
|
|
|
|
Thread-safety: ``STEP_REGISTRY`` holds a single shared instance per type, so
|
|
a concurrent ``fan-out`` (``max_concurrency > 1``) can invoke ``execute`` on
|
|
the same instance from several threads at once. Implementations must be
|
|
stateless / thread-safe — derive all per-run state from the ``config`` and
|
|
``context`` arguments and never mutate ``self`` in ``execute``. The built-in
|
|
steps follow this rule.
|
|
"""
|
|
|
|
#: Matches the ``type:`` value in workflow YAML.
|
|
type_key: str = ""
|
|
|
|
@abstractmethod
|
|
def execute(self, config: dict[str, Any], context: StepContext) -> StepResult:
|
|
"""Execute the step with the given config and context.
|
|
|
|
Parameters
|
|
----------
|
|
config:
|
|
The step configuration from workflow YAML.
|
|
context:
|
|
The execution context with inputs, accumulated step results, etc.
|
|
|
|
Returns
|
|
-------
|
|
StepResult with status, output data, and optional nested steps.
|
|
"""
|
|
|
|
def validate(self, config: dict[str, Any]) -> list[str]:
|
|
"""Validate step configuration and return a list of error messages.
|
|
|
|
An empty list means the configuration is valid.
|
|
"""
|
|
errors: list[str] = []
|
|
if "id" not in config:
|
|
errors.append("Step is missing required 'id' field.")
|
|
return errors
|
|
|
|
def can_resume(self, state: dict[str, Any]) -> bool:
|
|
"""Return whether this step can be resumed from the given state."""
|
|
return True
|