mirror of
https://github.com/github/spec-kit.git
synced 2026-07-06 14:01:01 +08:00
* docs: add Spec Kit spec for agent-context full opt-in Use Spec Kit's own specify workflow to author the spec that makes the agent-context extension a full opt-in, removing all agent-context configuration/support from the Python codebase and removing the deprecation message. Force-added despite specs/ being gitignored; the generated artifact will be purged prior to merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: add Spec Kit plan artifacts for agent-context full opt-in Phase 0/1 of the SDD plan workflow: plan.md, research.md, data-model.md, quickstart.md, and contracts/cli-behavior.md. Constitution Check is a documented no-op (repo has no ratified constitution). Force-added despite specs/ being gitignored; generated artifacts will be purged prior to merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: correct Constitution Check against ratified v1.0.0 Earlier draft wrongly treated the gate as a no-op; the fork's main is 16 commits behind upstream/main, which carries .specify/memory/constitution.md. Re-evaluate the feature against Principles I-V (all PASS) and note that Principle I mandates keeping context_file as a declared class attribute, validating the R1 metadata decision. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: refresh plan artifacts against synced upstream/main After syncing fork main to upstream and rebasing, re-scan the current agent-context surface. Upstream generalized the single context_file into a plural context_files concept with new resolver helpers (_resolve_context_files, _resolve_context_file_values, _format_context_file_values) and upsert/remove now loop over multiple files. Update research.md, data-model.md, contracts, quickstart grep guards, and the plan summary to cover the expanded removal scope. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: add Spec Kit tasks for agent-context full opt-in Phase 2 of SDD: dependency-ordered tasks.md (30 tasks) organized by the three user stories, with mandatory test tasks (Constitution Principle II) and a foundational phase decoupling __CONTEXT_FILE__ resolution from the extension config. Includes the extension self-seeding task (T015) and a static guard test (T002) enforcing zero agent-context references in the CLI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat!: remove agent-context lifecycle from the Specify CLI Make the agent-context extension a full opt-in. The CLI no longer installs the extension during init, writes agent-context-config.yml, or creates/updates/removes the managed Spec Kit section in agent context files. Context-section upsert/remove, marker resolution, extension-enabled gating, the config helpers, and the obsolete inline deprecation warning are all removed. Integration context_file stays as inert metadata; __CONTEXT_FILE__ now resolves from registry metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat(agent-context): self-seed context file from the active integration When agent-context-config.yml has no context_file/context_files, the bundled bash and PowerShell update scripts now resolve the context file from the active integration in .specify/init-options.json via the integration registry, so the extension no longer depends on the CLI writing its config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test+docs: update suite and docs for agent-context opt-in Update integration/extension tests to expect no agent-context install, config, or context-section writes during init. Add a static guard test (test_agent_context_cli_free.py) asserting the CLI source is free of agent-context lifecycle symbols, plus backward-compatibility tests for legacy projects. Refresh AGENTS.md, the extension README, and add a CHANGELOG entry describing the opt-in behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(agent-context): warn on self-seed failure, correct docs, speed up guard test Address PR review feedback: - Self-seed scripts (bash + PowerShell) now emit an actionable warning when an active integration is configured but specify_cli cannot be imported by the chosen Python (e.g. pipx installs), or when the integration declares no context file, instead of silently falling through to 'nothing to do'. - Correct the extension README disable note: command rendering never reads the extension config; __CONTEXT_FILE__ is always substituted from integration metadata, so a stale context_files value cannot affect rendering. - Cache CLI source reads in the static guard test via a module-scoped fixture so the directory walk happens once instead of once per forbidden symbol. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat(agent-context): ship self-owned per-agent context-file defaults The extension now bundles agent-context-defaults.json (key→context_file map) and self-seeds from it, dropping any dependency on the Specify CLI registry. Both the bash and PowerShell update scripts read the bundled JSON map keyed by the active integration from init-options.json. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat!: remove all agent-context state from the Specify CLI Strip every context_file reference from the CLI: the field on all 35 integration classes, the IntegrationBase plumbing (process_template param/step, _context_file_display, docstrings), the __CONTEXT_FILE__ resolution in agents.py, the legacy context_file/context_markers popping in _helpers.py, and the context_file template in integration_scaffold.py. Also drop the Agent context update step and __CONTEXT_FILE__ placeholder from templates/commands/plan.md. The agent-context extension now solely owns all context-file knowledge, including the per-agent default mapping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: drop context_file coverage and guard against CLI reintroduction Remove CONTEXT_FILE attrs and context_file assertions across the base mixins, all 35 per-integration test files, shared integration tests, and conftest stubs. Rewrite the base-mixin context tests to assert no managed section is written and no __CONTEXT_FILE__ placeholder survives. Extend the CLI-free static guard to forbid context_file, __CONTEXT_FILE__, and _context_file_display in src/specify_cli, and have the extension tests copy the bundled defaults JSON so self-seed runs without the CLI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: reflect full removal of agent-context state from the CLI Update AGENTS.md (integration examples, required-fields table, context behavior section, pitfalls), CHANGELOG, and the SDD spec artifacts (FR-007, SC-002, data-model) to state that the CLI carries no context_file and the extension fully owns the per-agent default mapping via agent-context-defaults.json. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: align SDD artifacts with full context_file removal Update research.md (R1, R2, R4, summary table), contracts/cli-behavior.md (C3, C5), tasks.md (Phase 2, T026, notes), plan.md (Principle I, source map), and checklists/requirements.md so the spec artifacts reflect the implemented decision: the CLI carries no context_file attribute or __CONTEXT_FILE__ resolution, and the per-agent defaults map lives in the extension. Resolves PR review #4548130110. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: scrub stale context-file mentions from CLI docstrings Update the multi_install_safe docstring (drop the removed "context file" invariant), the RovoDev setup docstring (no longer upserts a context section), the Copilot module docstring (drop the context-file line), and tighten the _update_init_options_for_integration note. Pure docstring changes — no behavioral impact. Resolves PR review #4548237085. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test+docs: harden agent-context test helper and fix stale docs - base.py: document multi_install_safe as an optional subclass attribute in the IntegrationBase docstring. - test_cli.py: clarify the init-options assertion is guarding against leftover legacy agent-context keys, not relocation. - test_extension_agent_context.py: _install_agent_context_config now asserts the bundled agent-context-defaults.json exists and always copies it, so self-seeding tests fail loudly instead of silently skipping when the map is missing. - test_integration_cursor_agent.py: drop Path/IntegrationManifest imports left unused after removing the context-section frontmatter tests. Resolves PR review #4548293116. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: remove gitignored SDD artifacts from specs/ The specs/001-agent-context-full-optin/ artifacts were force-added for dogfooding visibility, but specs/ is gitignored and these were always intended to be purged before merge. Remove them so merging does not add an intentionally-untracked directory to repo history. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: keep CHANGELOG.md identical to upstream CHANGELOG.md is auto-generated at release time, so the branch should not carry a manual entry. Restore it to match upstream/main exactly. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: preserve Cursor .mdc frontmatter in agent-context updater scripts The bundled agent-context updater scripts wrote the managed section as plain text. For Cursor-style `.mdc` targets this dropped the required `---\nalwaysApply: true\n---` frontmatter, reintroducing the rule-loading bug originally fixed in #1699. Port the `_ensure_mdc_frontmatter` logic into both the bash and PowerShell updaters: prepend frontmatter when missing, repair `alwaysApply` when set to the wrong value, and leave non-`.mdc` targets untouched. Add regression tests covering both shells. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: scope CLI-free guard to agent-context-specific symbols Drop the bare "context_file" substring from FORBIDDEN_SYMBOLS so the guard no longer fails on unrelated future CLI fields named context_file. The list still covers agent-context-specific identifiers (__CONTEXT_FILE__, _context_file_display, _resolve_context_files, _resolve_context_file_values). Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: harden agent-context bash self-seed against malformed init JSON Two robustness fixes in the embedded Python self-seed logic: - Coerce the integration value from init-options.json to a string only when it is actually a string; otherwise treat it as unset so a corrupted dict/list value degrades to the existing nothing-to-do behavior instead of breaking the agents-map lookup. - Normalize agent-context-defaults.json: only use 'agents' when both the JSON root and the 'agents' value are dicts, so a wrong-shaped (but valid) JSON falls back to the warning path instead of raising on .get. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: correct PowerShell hyphenated key lookup and regex replace count - Self-seed now reads the defaults mapping via $defaults.agents.PSObject.Properties[$integrationKey].Value instead of member access ($defaults.agents.$integrationKey), which parsed hyphenated keys like 'cursor-agent'/'kiro-cli' as subtraction and failed to resolve. - Replace the static [regex]::Replace(..., 1) call, whose trailing 1 was interpreted as RegexOptions.IgnoreCase rather than a replacement count, with an instance Regex whose Replace(input, replacement, 1) limits to the first match as intended. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: make bash .mdc frontmatter guard case-insensitive The bash updater only injected Cursor .mdc frontmatter when ctx_path ended in lowercase '.mdc', so a mixed/upper-case extension (e.g. specify-rules.MDC) was skipped and Cursor would not auto-load the rule file. Compare against the casefolded path. The PowerShell variant already uses -match, which is case-insensitive by default, so no change is needed there. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: document separator-agnostic agent-context update invocation The README hard-coded the dot-notation slash command (/speckit.agent-context.update), which hyphen-separator agents like Forge and Cline do not recognize. Document the canonical command ID plus both slash invocations so users copy the form their agent accepts. Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
282 lines
8.7 KiB
Python
282 lines
8.7 KiB
Python
"""Developer helpers for scaffolding built-in integrations."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from dataclasses import dataclass
|
|
from pathlib import Path
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class IntegrationScaffoldResult:
|
|
"""Files and next steps produced by an integration scaffold run."""
|
|
|
|
key: str
|
|
package_name: str
|
|
class_name: str
|
|
integration_file: Path
|
|
test_file: Path
|
|
next_steps: tuple[str, ...]
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class _IntegrationTemplate:
|
|
base_class: str
|
|
commands_subdir: str
|
|
registrar_format: str
|
|
args: str
|
|
extension: str
|
|
|
|
|
|
_KEY_RE = re.compile(r"^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$")
|
|
_TEMPLATES = {
|
|
"markdown": _IntegrationTemplate(
|
|
base_class="MarkdownIntegration",
|
|
commands_subdir="commands",
|
|
registrar_format="markdown",
|
|
args="$ARGUMENTS",
|
|
extension=".md",
|
|
),
|
|
"toml": _IntegrationTemplate(
|
|
base_class="TomlIntegration",
|
|
commands_subdir="commands",
|
|
registrar_format="toml",
|
|
args="{{args}}",
|
|
extension=".toml",
|
|
),
|
|
"yaml": _IntegrationTemplate(
|
|
base_class="YamlIntegration",
|
|
commands_subdir="recipes",
|
|
registrar_format="yaml",
|
|
args="{{args}}",
|
|
extension=".yaml",
|
|
),
|
|
"skills": _IntegrationTemplate(
|
|
base_class="SkillsIntegration",
|
|
commands_subdir="skills",
|
|
registrar_format="markdown",
|
|
args="$ARGUMENTS",
|
|
extension="/SKILL.md",
|
|
),
|
|
}
|
|
|
|
|
|
def supported_integration_scaffold_types() -> tuple[str, ...]:
|
|
"""Return supported scaffold template names."""
|
|
return tuple(sorted(_TEMPLATES))
|
|
|
|
|
|
def _clean_key(key: str) -> str:
|
|
clean = key.strip()
|
|
if not _KEY_RE.fullmatch(clean):
|
|
raise ValueError(
|
|
"Integration key must be lowercase kebab-case, for example 'my-agent'."
|
|
)
|
|
return clean
|
|
|
|
|
|
def _package_name(key: str) -> str:
|
|
return key.replace("-", "_")
|
|
|
|
|
|
def _class_name(key: str) -> str:
|
|
return "".join(part.capitalize() for part in key.split("-")) + "Integration"
|
|
|
|
|
|
def _display_name(key: str) -> str:
|
|
return " ".join(part.capitalize() for part in key.split("-"))
|
|
|
|
|
|
def _integration_content(
|
|
*,
|
|
key: str,
|
|
class_name: str,
|
|
integration_type: str,
|
|
) -> str:
|
|
template = _TEMPLATES[integration_type]
|
|
display_name = _display_name(key)
|
|
folder = f".{key}/"
|
|
commands_dir = f"{folder}{template.commands_subdir}"
|
|
return f'''"""{display_name} integration."""
|
|
|
|
from ..base import {template.base_class}
|
|
|
|
|
|
class {class_name}({template.base_class}):
|
|
key = "{key}"
|
|
config = {{
|
|
"name": "{display_name}",
|
|
"folder": "{folder}",
|
|
"commands_subdir": "{template.commands_subdir}",
|
|
"install_url": None,
|
|
"requires_cli": False,
|
|
}}
|
|
registrar_config = {{
|
|
"dir": "{commands_dir}",
|
|
"format": "{template.registrar_format}",
|
|
"args": "{template.args}",
|
|
"extension": "{template.extension}",
|
|
}}
|
|
multi_install_safe = False
|
|
'''
|
|
|
|
|
|
def _test_content(
|
|
*,
|
|
key: str,
|
|
class_name: str,
|
|
integration_type: str,
|
|
) -> str:
|
|
template = _TEMPLATES[integration_type]
|
|
display_name = _display_name(key)
|
|
package_name = _package_name(key)
|
|
commands_dir = f".{key}/{template.commands_subdir}"
|
|
return f'''"""Tests for the {key} integration."""
|
|
|
|
from specify_cli.integrations.{package_name} import {class_name}
|
|
from specify_cli.integrations.base import {template.base_class}
|
|
|
|
|
|
def test_metadata():
|
|
integration = {class_name}()
|
|
|
|
assert isinstance(integration, {template.base_class})
|
|
assert integration.key == "{key}"
|
|
assert integration.config["name"] == "{display_name}"
|
|
assert integration.config["folder"] == ".{key}/"
|
|
assert integration.config["commands_subdir"] == "{template.commands_subdir}"
|
|
assert integration.config["requires_cli"] is False
|
|
assert integration.registrar_config["dir"] == "{commands_dir}"
|
|
assert integration.registrar_config["format"] == "{template.registrar_format}"
|
|
assert integration.registrar_config["args"] == "{template.args}"
|
|
assert integration.registrar_config["extension"] == "{template.extension}"
|
|
assert integration.multi_install_safe is False
|
|
'''
|
|
|
|
|
|
def _is_spec_kit_repo_root(project_root: Path) -> bool:
|
|
"""Return True when `project_root` looks like the Spec Kit repository root."""
|
|
return all(
|
|
(
|
|
(project_root / "pyproject.toml").is_file(),
|
|
(project_root / "src" / "specify_cli" / "__init__.py").is_file(),
|
|
(project_root / "src" / "specify_cli" / "integrations").is_dir(),
|
|
(
|
|
project_root / "src" / "specify_cli" / "integrations" / "__init__.py"
|
|
).is_file(),
|
|
(project_root / "tests" / "integrations").is_dir(),
|
|
)
|
|
)
|
|
|
|
|
|
def _assert_safe_scaffold_target(project_root: Path, target: Path) -> None:
|
|
"""Refuse to scaffold through a symlinked path that could escape the repo.
|
|
|
|
Walks each component of *target* under *project_root* and rejects any
|
|
existing symlinked directory (or symlinked target), then confirms the
|
|
write destination still resolves inside the repository root. Mirrors the
|
|
symlink-aware guarding used for integration manifests.
|
|
"""
|
|
try:
|
|
rel = target.relative_to(project_root)
|
|
except ValueError:
|
|
raise ValueError(
|
|
f"Refusing to scaffold outside the repository root: {target}"
|
|
) from None
|
|
|
|
current = project_root
|
|
for part in rel.parts:
|
|
current = current / part
|
|
if current.is_symlink():
|
|
label = current.relative_to(project_root).as_posix()
|
|
raise ValueError(f"Refusing to scaffold through symlinked path: {label}")
|
|
|
|
root_resolved = project_root.resolve()
|
|
try:
|
|
target.parent.resolve().relative_to(root_resolved)
|
|
except (OSError, ValueError):
|
|
raise ValueError(
|
|
f"Refusing to scaffold outside the repository root: {target}"
|
|
) from None
|
|
|
|
|
|
def scaffold_integration(
|
|
project_root: Path,
|
|
key: str,
|
|
integration_type: str,
|
|
) -> IntegrationScaffoldResult:
|
|
"""Create a minimal built-in integration package and test skeleton."""
|
|
clean_key = _clean_key(key)
|
|
normalized_type = integration_type.strip().lower()
|
|
if normalized_type not in _TEMPLATES:
|
|
supported = ", ".join(supported_integration_scaffold_types())
|
|
raise ValueError(
|
|
f"Unsupported integration type '{normalized_type}'. Use one of: {supported}."
|
|
)
|
|
|
|
integrations_root = project_root / "src" / "specify_cli" / "integrations"
|
|
tests_root = project_root / "tests" / "integrations"
|
|
if not _is_spec_kit_repo_root(project_root):
|
|
raise ValueError("Run this command from the Spec Kit repository root.")
|
|
|
|
package_name = _package_name(clean_key)
|
|
class_name = _class_name(clean_key)
|
|
integration_dir = integrations_root / package_name
|
|
integration_file = integration_dir / "__init__.py"
|
|
test_file = tests_root / f"test_integration_{package_name}.py"
|
|
|
|
for target in (integration_file, test_file):
|
|
_assert_safe_scaffold_target(project_root, target)
|
|
|
|
existing = [path for path in (integration_file, test_file) if path.exists()]
|
|
if existing:
|
|
labels = ", ".join(path.relative_to(project_root).as_posix() for path in existing)
|
|
raise FileExistsError(f"Refusing to overwrite existing scaffold file(s): {labels}")
|
|
|
|
created_integration_dir = not integration_dir.exists()
|
|
try:
|
|
integration_dir.mkdir(exist_ok=True)
|
|
integration_file.write_text(
|
|
_integration_content(
|
|
key=clean_key,
|
|
class_name=class_name,
|
|
integration_type=normalized_type,
|
|
),
|
|
encoding="utf-8",
|
|
)
|
|
test_file.write_text(
|
|
_test_content(
|
|
key=clean_key,
|
|
class_name=class_name,
|
|
integration_type=normalized_type,
|
|
),
|
|
encoding="utf-8",
|
|
)
|
|
except OSError:
|
|
for path in (test_file, integration_file):
|
|
try:
|
|
if path.is_file() or path.is_symlink():
|
|
path.unlink()
|
|
except OSError:
|
|
pass
|
|
if created_integration_dir:
|
|
try:
|
|
integration_dir.rmdir()
|
|
except OSError:
|
|
pass
|
|
raise
|
|
|
|
next_steps = (
|
|
f"Register {class_name} in src/specify_cli/integrations/__init__.py.",
|
|
"Review config metadata, install_url, requires_cli, and multi_install_safe.",
|
|
f"Run pytest tests/integrations/test_integration_{package_name}.py -v.",
|
|
)
|
|
return IntegrationScaffoldResult(
|
|
key=clean_key,
|
|
package_name=package_name,
|
|
class_name=class_name,
|
|
integration_file=integration_file,
|
|
test_file=test_file,
|
|
next_steps=next_steps,
|
|
)
|