github-spec-kit

mirror of https://github.com/github/spec-kit.git synced 2026-08-03 06:26:30 +08:00

Files

Andrew Chen 0d780162f9 fix(bundle): surface a clean BundlerError on a malformed bundle download URL (#3586 )

`_download_manifest` and its `_require_https` helper parsed the catalog
entry's `download_url` with an unguarded `urlparse(url)`. A malformed
authority — e.g. an unclosed IPv6 bracket like `https://[::1` — makes
`urlparse` (or `.hostname` on older Pythons) raise a raw `ValueError`. The
three `bundle` CLI commands (`info`, `install`, `update`) only catch
`BundlerError`, so that `ValueError` escaped as an uncaught traceback.

Wrap both parse sites in the same `try/except ValueError -> BundlerError`
guard already used by the sibling `_validate_remote_url` (and established by
the merged catalog-URL fix #3576), so a bad `download_url` reports a clean,
actionable error in every mode.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-17 09:52:35 -05:00

test_bundle_download_url.py

fix(bundle): surface a clean BundlerError on a malformed bundle download URL (#3586 )

2026-07-17 09:52:35 -05:00

test_bundler_adapters.py

fix(bundler): raise BundlerError, not raw ValueError, on a malformed catalog URL (#3433 )

2026-07-10 11:57:53 -05:00

test_bundler_catalog_config.py

fix(bundler): validate catalog URLs in catalog add (HTTPS-only, require host) (#3367 )

2026-07-07 11:01:46 -05:00

test_bundler_conflict.py

feat: add specify bundle command (#3070 )