mirror of
https://github.com/github/spec-kit.git
synced 2026-07-03 12:28:06 +08:00
* Initial plan * feat!: remove legacy --ai, --ai-commands-dir, and --ai-skills flags at 0.10.0 * refactor(tests): rename stale test_ai_help_* methods to test_agent_config_* * fix: address review — derive agent folder for generic integration and remove redundant test - Security notice now falls back to integration_parsed_options['commands_dir'] when AGENT_CONFIG folder is None (generic integration). - Remove test_agent_config_includes_kiro_cli which duplicates the assertion in test_runtime_config_uses_kiro_cli_and_removes_q. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: scrub all remaining --ai flag references from source and tests - Remove dead AI_ASSISTANT_ALIASES, AI_ASSISTANT_HELP, and _build_ai_assistant_help() from _agent_config.py - Update comments/docstrings in extensions.py, presets.py, and integration subpackages to reference 'skills mode' or '--integration' instead of the removed flags - Fix catalog.json generic integration description - Update test docstrings/comments in test_extension_skills.py, test_extensions.py, and test_presets.py Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: remove legacy --ai flag rejection tests The flags are fully removed from the CLI; typer handles unknown options generically. No custom rejection logic exists to test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * revert: remove manual CHANGELOG.md entry CHANGELOG is generated automatically; manual edits should not be made. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: make generic catalog description self-explanatory Include the required --commands-dir sub-option in the description so readers don't need to look up integration docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tests): rename duplicate test classes to avoid shadowing The rename from Test*AutoPromote to Test*Integration collided with the existing Test*Integration(SkillsIntegrationTests) base classes, causing the shared test suites to be silently overwritten. Rename the CLI init flow classes to Test*InitFlow instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Manfred Riem <mnriem@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
150 lines
5.2 KiB
Python
150 lines
5.2 KiB
Python
"""Tests for KimiIntegration — skills integration with legacy migration."""
|
|
|
|
from specify_cli.integrations import get_integration
|
|
from specify_cli.integrations.kimi import _migrate_legacy_kimi_dotted_skills
|
|
from specify_cli.integrations.manifest import IntegrationManifest
|
|
|
|
from .test_integration_base_skills import SkillsIntegrationTests
|
|
|
|
|
|
class TestKimiIntegration(SkillsIntegrationTests):
|
|
KEY = "kimi"
|
|
FOLDER = ".kimi/"
|
|
COMMANDS_SUBDIR = "skills"
|
|
REGISTRAR_DIR = ".kimi/skills"
|
|
CONTEXT_FILE = "KIMI.md"
|
|
|
|
|
|
class TestKimiOptions:
|
|
"""Kimi declares --skills and --migrate-legacy options."""
|
|
|
|
def test_migrate_legacy_option(self):
|
|
i = get_integration("kimi")
|
|
opts = i.options()
|
|
migrate_opts = [o for o in opts if o.name == "--migrate-legacy"]
|
|
assert len(migrate_opts) == 1
|
|
assert migrate_opts[0].is_flag is True
|
|
assert migrate_opts[0].default is False
|
|
|
|
|
|
class TestKimiLegacyMigration:
|
|
"""Test Kimi dotted → hyphenated skill directory migration."""
|
|
|
|
def test_migrate_dotted_to_hyphenated(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text("# Plan Skill\n")
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 1
|
|
assert removed == 0
|
|
assert not legacy.exists()
|
|
assert (skills_dir / "speckit-plan" / "SKILL.md").exists()
|
|
|
|
def test_skip_when_target_exists_different_content(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text("# Old\n")
|
|
|
|
target = skills_dir / "speckit-plan"
|
|
target.mkdir(parents=True)
|
|
(target / "SKILL.md").write_text("# New (different)\n")
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 0
|
|
assert removed == 0
|
|
assert legacy.exists()
|
|
assert target.exists()
|
|
|
|
def test_remove_when_target_exists_same_content(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
content = "# Identical\n"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text(content)
|
|
|
|
target = skills_dir / "speckit-plan"
|
|
target.mkdir(parents=True)
|
|
(target / "SKILL.md").write_text(content)
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 0
|
|
assert removed == 1
|
|
assert not legacy.exists()
|
|
assert target.exists()
|
|
|
|
def test_preserve_legacy_with_extra_files(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
content = "# Same\n"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text(content)
|
|
(legacy / "extra.md").write_text("user file")
|
|
|
|
target = skills_dir / "speckit-plan"
|
|
target.mkdir(parents=True)
|
|
(target / "SKILL.md").write_text(content)
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 0
|
|
assert removed == 0
|
|
assert legacy.exists()
|
|
|
|
def test_nonexistent_dir_returns_zeros(self, tmp_path):
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(
|
|
tmp_path / ".kimi" / "skills"
|
|
)
|
|
assert migrated == 0
|
|
assert removed == 0
|
|
|
|
def test_setup_with_migrate_legacy_option(self, tmp_path):
|
|
"""KimiIntegration.setup() with --migrate-legacy migrates dotted dirs."""
|
|
i = get_integration("kimi")
|
|
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
legacy = skills_dir / "speckit.oldcmd"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text("# Legacy\n")
|
|
|
|
m = IntegrationManifest("kimi", tmp_path)
|
|
i.setup(tmp_path, m, parsed_options={"migrate_legacy": True})
|
|
|
|
assert not legacy.exists()
|
|
assert (skills_dir / "speckit-oldcmd" / "SKILL.md").exists()
|
|
# New skills from templates should also exist
|
|
assert (skills_dir / "speckit-specify" / "SKILL.md").exists()
|
|
|
|
|
|
class TestKimiNextSteps:
|
|
"""CLI output tests for kimi next-steps display."""
|
|
|
|
def test_next_steps_show_skill_invocation(self, tmp_path):
|
|
"""Kimi next-steps guidance should display /skill:speckit-* usage."""
|
|
import os
|
|
from typer.testing import CliRunner
|
|
from specify_cli import app
|
|
|
|
project = tmp_path / "kimi-next-steps"
|
|
project.mkdir()
|
|
old_cwd = os.getcwd()
|
|
try:
|
|
os.chdir(project)
|
|
runner = CliRunner()
|
|
result = runner.invoke(app, [
|
|
"init", "--here", "--integration", "kimi", "--no-git",
|
|
"--ignore-agent-tools", "--script", "sh",
|
|
], catch_exceptions=False)
|
|
finally:
|
|
os.chdir(old_cwd)
|
|
|
|
assert result.exit_code == 0
|
|
assert "/skill:speckit-constitution" in result.output
|
|
assert "/speckit.constitution" not in result.output
|
|
assert "Optional skills that you can use for your specs" in result.output
|