mirror of
https://github.com/github/spec-kit.git
synced 2026-07-03 12:28:06 +08:00
* feat(init)!: make git extension opt-in and remove --no-git at v0.10.0 - Remove --no-git parameter from specify init command - Remove git extension auto-installation from init flow - Git repository initialization (git init) still runs when git is available - Remove --no-git from all test invocations across the test suite - Update docs to reflect opt-in git extension behavior - Replace TestGitExtensionAutoInstall with TestGitExtensionOptIn tests BREAKING CHANGE: specify init no longer auto-installs the git extension. Use `specify extension add git` to install it explicitly. The --no-git flag has been removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(scripts): remove git operations from core scripts Git functionality is now entirely managed by the git extension. Core scripts only handle directory-based feature creation and numbering. - Remove has_git(), check_feature_branch(), git branch creation from core - Simplify number detection to use only spec directory scanning - Remove HAS_GIT output from get_feature_paths() - Remove git remote fetching and branch querying - Keep BRANCH_NAME output key for backward compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor: remove all git operations from core - Remove is_git_repo() and init_git_repo() dead code from _utils.py - Remove --branch-numbering from init command - Remove git from 'specify check' (now extension-only) - Update docs: git is optional prerequisite, check command description - Fix tests to reflect no-git-in-core reality (fallback to main) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(scripts): remove directory scanning and branch fallback from core Core scripts now resolve feature context exclusively from: 1. SPECIFY_FEATURE env var (set by git extension) 2. .specify/feature.json (persisted by specify command) Removed find_feature_dir_by_prefix() and directory scanning heuristics — these are the git extension's responsibility. Scripts error clearly when no feature context is available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: introduce feature_numbering, deprecate branch_numbering in init-options - specify command template now reads feature_numbering (preferred) with fallback to branch_numbering (deprecated) from init-options.json - Git extension reads git-config.yml > feature_numbering > branch_numbering - init now writes feature_numbering: sequential to init-options.json - Deprecation warning emitted when branch_numbering is used as fallback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove trailing whitespace in common.ps1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat(scripts): persist SPECIFY_FEATURE_DIRECTORY env var to feature.json When SPECIFY_FEATURE_DIRECTORY is set, get_feature_paths() now writes the value to .specify/feature.json so future sessions without the env var can still resolve the feature directory. The write is idempotent — it skips when the file already contains the same value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address review feedback — error messages and docs - Update error messages in common.sh and common.ps1 to reference SPECIFY_FEATURE_DIRECTORY instead of SPECIFY_FEATURE (which no longer resolves feature directories) - Fix get_current_branch comment (returns empty string, not error) - Update upgrade.md to reference SPECIFY_FEATURE_DIRECTORY with correct example paths - Update local-development.md troubleshooting: replace stale 'Git step skipped' row with actionable git extension guidance Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): harden feature.json persistence - Use json_escape in printf fallback when jq is unavailable (common.sh) - Replace utf8NoBOM encoding with UTF8Encoding($false) for PowerShell 5.1 compatibility (common.ps1) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(scripts): remove dead feature_json_matches_feature_dir functions These guards are no longer needed since the branch-name validation they protected against has been removed from check-prerequisites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(git-ext): rename create-new-feature to create-new-feature-branch The git extension's script only creates the git branch — rename it to reflect that responsibility. The core create-new-feature.sh/.ps1 handles feature directory creation and feature.json persistence. Also includes fixes from review feedback: - common.sh: _persist_feature_json uses json_escape fallback - common.ps1: Save-FeatureJson uses UTF8Encoding for PS 5.1 compat - common.ps1: case-sensitive path stripping on non-Windows - create-new-feature.sh/ps1: output both SPECIFY_FEATURE and SPECIFY_FEATURE_DIRECTORY - setup-tasks.sh: fix stale 'Validate branch' comment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tests): update references to renamed git extension scripts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tests): remove duplicate EXT_CREATE_FEATURE assignments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Manfred Riem <mnriem@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
150 lines
5.2 KiB
Python
150 lines
5.2 KiB
Python
"""Tests for KimiIntegration — skills integration with legacy migration."""
|
|
|
|
from specify_cli.integrations import get_integration
|
|
from specify_cli.integrations.kimi import _migrate_legacy_kimi_dotted_skills
|
|
from specify_cli.integrations.manifest import IntegrationManifest
|
|
|
|
from .test_integration_base_skills import SkillsIntegrationTests
|
|
|
|
|
|
class TestKimiIntegration(SkillsIntegrationTests):
|
|
KEY = "kimi"
|
|
FOLDER = ".kimi/"
|
|
COMMANDS_SUBDIR = "skills"
|
|
REGISTRAR_DIR = ".kimi/skills"
|
|
CONTEXT_FILE = "KIMI.md"
|
|
|
|
|
|
class TestKimiOptions:
|
|
"""Kimi declares --skills and --migrate-legacy options."""
|
|
|
|
def test_migrate_legacy_option(self):
|
|
i = get_integration("kimi")
|
|
opts = i.options()
|
|
migrate_opts = [o for o in opts if o.name == "--migrate-legacy"]
|
|
assert len(migrate_opts) == 1
|
|
assert migrate_opts[0].is_flag is True
|
|
assert migrate_opts[0].default is False
|
|
|
|
|
|
class TestKimiLegacyMigration:
|
|
"""Test Kimi dotted → hyphenated skill directory migration."""
|
|
|
|
def test_migrate_dotted_to_hyphenated(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text("# Plan Skill\n")
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 1
|
|
assert removed == 0
|
|
assert not legacy.exists()
|
|
assert (skills_dir / "speckit-plan" / "SKILL.md").exists()
|
|
|
|
def test_skip_when_target_exists_different_content(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text("# Old\n")
|
|
|
|
target = skills_dir / "speckit-plan"
|
|
target.mkdir(parents=True)
|
|
(target / "SKILL.md").write_text("# New (different)\n")
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 0
|
|
assert removed == 0
|
|
assert legacy.exists()
|
|
assert target.exists()
|
|
|
|
def test_remove_when_target_exists_same_content(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
content = "# Identical\n"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text(content)
|
|
|
|
target = skills_dir / "speckit-plan"
|
|
target.mkdir(parents=True)
|
|
(target / "SKILL.md").write_text(content)
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 0
|
|
assert removed == 1
|
|
assert not legacy.exists()
|
|
assert target.exists()
|
|
|
|
def test_preserve_legacy_with_extra_files(self, tmp_path):
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
content = "# Same\n"
|
|
legacy = skills_dir / "speckit.plan"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text(content)
|
|
(legacy / "extra.md").write_text("user file")
|
|
|
|
target = skills_dir / "speckit-plan"
|
|
target.mkdir(parents=True)
|
|
(target / "SKILL.md").write_text(content)
|
|
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(skills_dir)
|
|
|
|
assert migrated == 0
|
|
assert removed == 0
|
|
assert legacy.exists()
|
|
|
|
def test_nonexistent_dir_returns_zeros(self, tmp_path):
|
|
migrated, removed = _migrate_legacy_kimi_dotted_skills(
|
|
tmp_path / ".kimi" / "skills"
|
|
)
|
|
assert migrated == 0
|
|
assert removed == 0
|
|
|
|
def test_setup_with_migrate_legacy_option(self, tmp_path):
|
|
"""KimiIntegration.setup() with --migrate-legacy migrates dotted dirs."""
|
|
i = get_integration("kimi")
|
|
|
|
skills_dir = tmp_path / ".kimi" / "skills"
|
|
legacy = skills_dir / "speckit.oldcmd"
|
|
legacy.mkdir(parents=True)
|
|
(legacy / "SKILL.md").write_text("# Legacy\n")
|
|
|
|
m = IntegrationManifest("kimi", tmp_path)
|
|
i.setup(tmp_path, m, parsed_options={"migrate_legacy": True})
|
|
|
|
assert not legacy.exists()
|
|
assert (skills_dir / "speckit-oldcmd" / "SKILL.md").exists()
|
|
# New skills from templates should also exist
|
|
assert (skills_dir / "speckit-specify" / "SKILL.md").exists()
|
|
|
|
|
|
class TestKimiNextSteps:
|
|
"""CLI output tests for kimi next-steps display."""
|
|
|
|
def test_next_steps_show_skill_invocation(self, tmp_path):
|
|
"""Kimi next-steps guidance should display /skill:speckit-* usage."""
|
|
import os
|
|
from typer.testing import CliRunner
|
|
from specify_cli import app
|
|
|
|
project = tmp_path / "kimi-next-steps"
|
|
project.mkdir()
|
|
old_cwd = os.getcwd()
|
|
try:
|
|
os.chdir(project)
|
|
runner = CliRunner()
|
|
result = runner.invoke(app, [
|
|
"init", "--here", "--integration", "kimi",
|
|
"--ignore-agent-tools", "--script", "sh",
|
|
], catch_exceptions=False)
|
|
finally:
|
|
os.chdir(old_cwd)
|
|
|
|
assert result.exit_code == 0
|
|
assert "/skill:speckit-constitution" in result.output
|
|
assert "/speckit.constitution" not in result.output
|
|
assert "Optional skills that you can use for your specs" in result.output
|