mirror of
https://github.com/github/spec-kit.git
synced 2026-07-03 20:36:23 +08:00
* feat(init)!: make git extension opt-in and remove --no-git at v0.10.0 - Remove --no-git parameter from specify init command - Remove git extension auto-installation from init flow - Git repository initialization (git init) still runs when git is available - Remove --no-git from all test invocations across the test suite - Update docs to reflect opt-in git extension behavior - Replace TestGitExtensionAutoInstall with TestGitExtensionOptIn tests BREAKING CHANGE: specify init no longer auto-installs the git extension. Use `specify extension add git` to install it explicitly. The --no-git flag has been removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(scripts): remove git operations from core scripts Git functionality is now entirely managed by the git extension. Core scripts only handle directory-based feature creation and numbering. - Remove has_git(), check_feature_branch(), git branch creation from core - Simplify number detection to use only spec directory scanning - Remove HAS_GIT output from get_feature_paths() - Remove git remote fetching and branch querying - Keep BRANCH_NAME output key for backward compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor: remove all git operations from core - Remove is_git_repo() and init_git_repo() dead code from _utils.py - Remove --branch-numbering from init command - Remove git from 'specify check' (now extension-only) - Update docs: git is optional prerequisite, check command description - Fix tests to reflect no-git-in-core reality (fallback to main) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(scripts): remove directory scanning and branch fallback from core Core scripts now resolve feature context exclusively from: 1. SPECIFY_FEATURE env var (set by git extension) 2. .specify/feature.json (persisted by specify command) Removed find_feature_dir_by_prefix() and directory scanning heuristics — these are the git extension's responsibility. Scripts error clearly when no feature context is available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: introduce feature_numbering, deprecate branch_numbering in init-options - specify command template now reads feature_numbering (preferred) with fallback to branch_numbering (deprecated) from init-options.json - Git extension reads git-config.yml > feature_numbering > branch_numbering - init now writes feature_numbering: sequential to init-options.json - Deprecation warning emitted when branch_numbering is used as fallback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove trailing whitespace in common.ps1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat(scripts): persist SPECIFY_FEATURE_DIRECTORY env var to feature.json When SPECIFY_FEATURE_DIRECTORY is set, get_feature_paths() now writes the value to .specify/feature.json so future sessions without the env var can still resolve the feature directory. The write is idempotent — it skips when the file already contains the same value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address review feedback — error messages and docs - Update error messages in common.sh and common.ps1 to reference SPECIFY_FEATURE_DIRECTORY instead of SPECIFY_FEATURE (which no longer resolves feature directories) - Fix get_current_branch comment (returns empty string, not error) - Update upgrade.md to reference SPECIFY_FEATURE_DIRECTORY with correct example paths - Update local-development.md troubleshooting: replace stale 'Git step skipped' row with actionable git extension guidance Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): harden feature.json persistence - Use json_escape in printf fallback when jq is unavailable (common.sh) - Replace utf8NoBOM encoding with UTF8Encoding($false) for PowerShell 5.1 compatibility (common.ps1) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(scripts): remove dead feature_json_matches_feature_dir functions These guards are no longer needed since the branch-name validation they protected against has been removed from check-prerequisites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(git-ext): rename create-new-feature to create-new-feature-branch The git extension's script only creates the git branch — rename it to reflect that responsibility. The core create-new-feature.sh/.ps1 handles feature directory creation and feature.json persistence. Also includes fixes from review feedback: - common.sh: _persist_feature_json uses json_escape fallback - common.ps1: Save-FeatureJson uses UTF8Encoding for PS 5.1 compat - common.ps1: case-sensitive path stripping on non-Windows - create-new-feature.sh/ps1: output both SPECIFY_FEATURE and SPECIFY_FEATURE_DIRECTORY - setup-tasks.sh: fix stale 'Validate branch' comment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tests): update references to renamed git extension scripts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tests): remove duplicate EXT_CREATE_FEATURE assignments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Manfred Riem <mnriem@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
136 lines
5.7 KiB
Python
136 lines
5.7 KiB
Python
"""Tests for AgyIntegration (Antigravity)."""
|
|
|
|
from specify_cli.integrations import get_integration
|
|
|
|
from .test_integration_base_skills import SkillsIntegrationTests
|
|
|
|
|
|
class TestAgyIntegration(SkillsIntegrationTests):
|
|
KEY = "agy"
|
|
FOLDER = ".agents/"
|
|
COMMANDS_SUBDIR = "skills"
|
|
REGISTRAR_DIR = ".agents/skills"
|
|
CONTEXT_FILE = "AGENTS.md"
|
|
|
|
def test_options_include_skills_flag(self):
|
|
"""Override inherited test: AgyIntegration should not expose a --skills flag because .agents/ is its only layout."""
|
|
i = get_integration(self.KEY)
|
|
skills_opts = [o for o in i.options() if o.name == "--skills"]
|
|
assert len(skills_opts) == 0
|
|
|
|
def test_requires_cli_is_true(self):
|
|
"""agy is a CLI tool; requires_cli must be True."""
|
|
i = get_integration(self.KEY)
|
|
assert i.config["requires_cli"] is True
|
|
|
|
def test_install_url_is_set(self):
|
|
"""install_url must point to the official installation page."""
|
|
i = get_integration(self.KEY)
|
|
assert i.config["install_url"] == "https://antigravity.google/"
|
|
|
|
|
|
class TestAgyInitFlow:
|
|
"""--integration agy creates expected files."""
|
|
|
|
def test_integration_agy_creates_skills(self, tmp_path):
|
|
"""--integration agy should create skills directory."""
|
|
from typer.testing import CliRunner
|
|
from specify_cli import app
|
|
|
|
runner = CliRunner()
|
|
target = tmp_path / "test-proj"
|
|
result = runner.invoke(app, ["init", str(target), "--integration", "agy", "--script", "sh", "--ignore-agent-tools"])
|
|
|
|
assert result.exit_code == 0, f"init --integration agy failed: {result.output}"
|
|
assert (target / ".agents" / "skills" / "speckit-plan" / "SKILL.md").exists()
|
|
|
|
def test_agy_setup_warning(self, tmp_path):
|
|
"""Agy integration should print a warning about v1.20.5 requirement during setup."""
|
|
from typer.testing import CliRunner
|
|
from specify_cli import app
|
|
|
|
# Click >= 8.2 separates stdout and stderr natively
|
|
runner = CliRunner()
|
|
target = tmp_path / "test-proj2"
|
|
result = runner.invoke(app, ["init", str(target), "--integration", "agy", "--script", "sh", "--ignore-agent-tools"])
|
|
|
|
assert result.exit_code == 0
|
|
assert "Warning: The .agents/ layout requires Antigravity v1.20.5 or newer" in result.stderr
|
|
|
|
|
|
class TestAgyBuildExecArgs:
|
|
"""agy non-interactive execution argument building."""
|
|
|
|
def test_build_exec_args_returns_print_command(self):
|
|
"""build_exec_args should return ['agy', '--print', prompt]."""
|
|
from specify_cli.integrations import get_integration
|
|
i = get_integration("agy")
|
|
result = i.build_exec_args("describe my feature")
|
|
assert result == ["agy", "--print", "describe my feature"]
|
|
|
|
def test_build_exec_args_ignores_model(self):
|
|
"""agy does not support --model; model param must be ignored."""
|
|
from specify_cli.integrations import get_integration
|
|
i = get_integration("agy")
|
|
result = i.build_exec_args("my prompt", model="gemini-pro")
|
|
assert result == ["agy", "--print", "my prompt"]
|
|
|
|
def test_build_exec_args_ignores_output_json(self):
|
|
"""agy does not support JSON output; output_json param must be ignored."""
|
|
from specify_cli.integrations import get_integration
|
|
i = get_integration("agy")
|
|
result = i.build_exec_args("my prompt", output_json=False)
|
|
assert result == ["agy", "--print", "my prompt"]
|
|
|
|
|
|
class TestAgyHookCommandNote:
|
|
"""Verify dot-to-hyphen normalization note is injected into hook sections."""
|
|
|
|
def test_hook_note_injected_in_skills_with_hooks(self, tmp_path):
|
|
"""Skills with hook sections should contain the normalization note."""
|
|
from specify_cli.integrations import get_integration
|
|
from specify_cli.integrations.manifest import IntegrationManifest
|
|
|
|
i = get_integration("agy")
|
|
m = IntegrationManifest("agy", tmp_path)
|
|
i.setup(tmp_path, m, script_type="sh")
|
|
specify_skill = tmp_path / ".agents/skills/speckit-specify/SKILL.md"
|
|
assert specify_skill.exists()
|
|
content = specify_skill.read_text(encoding="utf-8")
|
|
assert "replace dots" in content, (
|
|
"speckit-specify should have dot-to-hyphen hook note"
|
|
)
|
|
|
|
def test_hook_note_not_in_skills_without_hooks(self):
|
|
"""Skills without hook sections should not get the note."""
|
|
from specify_cli.integrations.agy import AgyIntegration
|
|
|
|
content = "---\nname: test\ndescription: test\n---\n\nNo hooks here.\n"
|
|
result = AgyIntegration._inject_hook_command_note(content)
|
|
assert "replace dots" not in result
|
|
|
|
def test_hook_note_idempotent(self):
|
|
"""Injecting the note twice must not duplicate it."""
|
|
from specify_cli.integrations.agy import AgyIntegration
|
|
|
|
content = (
|
|
"---\nname: test\n---\n\n"
|
|
"- For each executable hook, output the following based on its flag:\n"
|
|
)
|
|
once = AgyIntegration._inject_hook_command_note(content)
|
|
twice = AgyIntegration._inject_hook_command_note(once)
|
|
assert once == twice, "Hook note injection should be idempotent"
|
|
|
|
def test_hook_note_preserves_indentation(self):
|
|
"""The injected note must match the indentation of the target line."""
|
|
from specify_cli.integrations.agy import AgyIntegration
|
|
|
|
content = (
|
|
"---\nname: test\n---\n\n"
|
|
" - For each executable hook, output the following\n"
|
|
)
|
|
result = AgyIntegration._inject_hook_command_note(content)
|
|
lines = result.splitlines()
|
|
note_line = [ln for ln in lines if "replace dots" in ln][0]
|
|
assert note_line.startswith(" "), "Note should preserve indentation"
|