Manfred Riem 089feca75f fix: move URL install confirmation prompt before spinner (#2783) (#2784) ...

* fix: move URL install confirmation prompt before spinner (#2783)

The typer.confirm() prompt inside console.status() was overwritten by
Rich's spinner animation, making extension add --from <url> appear hung.

Move URL validation and the default-deny confirmation prompt before the
spinner block so the user can see and respond to the [y/N] prompt.

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: guard prompt with not dev, escape from_url in Rich markup

Address PR review feedback:
- Gate URL confirmation prompt on 'not dev' so --dev + --from does not
  show a confusing prompt for a URL path that will be ignored.
- Escape from_url with rich.markup.escape() in both the warning panel
  and the download message to prevent markup injection via crafted URLs.

* fix: remove unused import, reuse safe_url, add regression tests

Address second round of PR review:
- Remove unused urllib.request import from URL install path
- Remove redundant re-import of rich.markup.escape; reuse safe_url
  computed before the spinner for download and error messages
- Add test_add_from_url_prompts_before_spinner: asserts typer.confirm
  fires before console.status spinner to prevent #2783 regression
- Add test_add_from_url_cancel_exits_cleanly: asserts declining the
  prompt exits with code 0 and prints Cancelled

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

2026-06-01 07:50:03 -05:00

..

extensions

Extract agent context updates into bundled agent-context extension (#2546)

2026-05-30 06:37:18 -05:00

hooks

fix: wire after_tasks and after_implement hook events into command templates (#1702)

2026-03-04 08:16:31 -06:00

integrations

Extract agent context updates into bundled agent-context extension (#2546)

2026-05-30 06:37:18 -05:00

__init__.py

Add modular extension system (#1551)

2026-02-10 14:27:20 -06:00

auth_helpers.py

feat: Config-driven opt-in authentication registry with multi-platform support (#2393)

2026-05-07 12:51:20 -05:00

conftest.py

feat: Config-driven opt-in authentication registry with multi-platform support (#2393)

2026-05-07 12:51:20 -05:00

test_agent_config_consistency.py

fix(forge): use hyphen notation for command refs in Forge integration (#2462)

2026-05-06 12:19:10 -05:00

test_authentication.py

refactor: extract _version.py from __init__.py (PR-3/8) (#2550)

2026-05-15 13:12:24 -05:00

test_branch_numbering.py

Stage 6: Complete migration — remove legacy scaffold path (#1924) (#2063)

2026-04-02 12:34:34 -05:00

test_check_prerequisites_paths_only.py

fix: paths-only skips branch validation, setup-plan preserves existing plan (#2672)

2026-05-27 07:17:34 -05:00

test_check_tool.py

feat: add self-check tip to check output (#2574)

2026-05-20 21:21:11 -05:00

test_cli_version.py

feat: add version feature reporting (#2548)

2026-05-14 12:52:14 -05:00

test_commands_package.py

refactor: create commands/ package and move init handler (PR-4/8) (#2615)

2026-05-26 08:06:35 -05:00

test_console_imports.py

refactor: extract _console.py from __init__.py (PR-1/8) (#2474)

2026-05-13 08:57:15 -05:00

test_extension_registration.py

fix(cli): harden extension registration and discovery workflows (#2499)

2026-05-13 12:02:01 -05:00

test_extension_skills.py

Fix --dev extension agent symlinks (#2554)

2026-05-28 09:29:17 -05:00

test_extension_update_hardening.py

fix(cli): harden extension registration and discovery workflows (#2499)

2026-05-13 12:02:01 -05:00

test_extensions.py

fix: move URL install confirmation prompt before spinner (#2783) (#2784)

2026-06-01 07:50:03 -05:00

test_github_http.py

fix: validate URL scheme in build_github_request (#2449)

2026-05-05 13:28:29 -05:00

test_merge.py

feat(cli): polite deep merge for settings.json and support JSONC (#1874)

2026-03-17 09:51:13 -05:00

test_presets.py

fix: resolve __SPECKIT_COMMAND_*__ refs in preset skill rendering (#2717) (#2718)

2026-05-27 12:49:54 -05:00

test_ps1_encoding.py

fix: PS 5.1 compat — replace non-ASCII chars in shipped PowerShell scripts (#2709)

2026-05-26 13:18:34 -05:00

test_registrar_path_traversal.py

fix(agents): block directory traversal in command write paths (#2229) (#2296)

2026-04-21 12:06:09 -05:00

test_setup_plan_feature_json.py

fix(plan): use .specify/feature.json to allow /speckit.plan on custom git branches (#2305) (#2349)

2026-04-24 12:38:13 -05:00

test_setup_plan_no_overwrite.py

fix: paths-only skips branch validation, setup-plan preserves existing plan (#2672)

2026-05-27 07:17:34 -05:00

test_setup_tasks.py

fix: honor template overrides for tasks-template (#2278) (#2292)

2026-05-01 16:18:19 -05:00

test_timestamp_branches.py

fix(powershell): ensure UTF-8 templates are written without BOM (#2280)

2026-05-15 07:39:17 -05:00

test_upgrade.py

refactor: extract _version.py from __init__.py (PR-3/8) (#2550)

2026-05-15 13:12:24 -05:00

test_utils_assets_imports.py

refactor: extract _assets.py and _utils.py from __init__.py (PR-2/8) (#2543)

2026-05-13 11:20:36 -05:00

test_version_imports.py

refactor: extract _version.py from __init__.py (PR-3/8) (#2550)

2026-05-15 13:12:24 -05:00

test_workflows.py

Add support for SPECKIT_WORKFLOW_RUN_ID override (#2742)

2026-05-29 10:50:00 -05:00