mirror of
https://github.com/github/spec-kit.git
synced 2026-07-03 20:36:23 +08:00
* fix: paths-only skips branch validation, setup-plan preserves existing plan (#2653) - check-prerequisites.sh/ps1: move branch validation after --paths-only early exit so --paths-only returns paths without requiring a spec branch - setup-plan.sh/ps1: skip template copy when plan.md already exists to prevent overwriting user-authored plans on reruns - setup-plan.sh: send status messages to stderr in --json mode so stdout remains parseable JSON - Add tests for both fixes (bash + PowerShell) * fix: remove trailing whitespace in PowerShell scripts * fix: route PS skip message to stderr in -Json mode, add PS JSON assertions Address review: setup-plan.ps1 Write-Output polluted stdout in -Json mode when plan.md already existed. Use [Console]::Error.WriteLine() when -Json is set. Add json.loads + stderr assertions to the PS rerun test to catch regressions. * fix: use Test-Path -PathType Leaf for plan existence check Bare Test-Path matches directories too, which would silently skip plan creation if a directory existed at the plan.md path.
74 lines
2.5 KiB
PowerShell
74 lines
2.5 KiB
PowerShell
#!/usr/bin/env pwsh
|
|
# Setup implementation plan for a feature
|
|
|
|
[CmdletBinding()]
|
|
param(
|
|
[switch]$Json,
|
|
[switch]$Help
|
|
)
|
|
|
|
$ErrorActionPreference = 'Stop'
|
|
|
|
# Show help if requested
|
|
if ($Help) {
|
|
Write-Output "Usage: ./setup-plan.ps1 [-Json] [-Help]"
|
|
Write-Output " -Json Output results in JSON format"
|
|
Write-Output " -Help Show this help message"
|
|
exit 0
|
|
}
|
|
|
|
# Load common functions
|
|
. "$PSScriptRoot/common.ps1"
|
|
|
|
# Get all paths and variables from common functions
|
|
$paths = Get-FeaturePathsEnv
|
|
|
|
# If feature.json pins an existing feature directory, branch naming is not required.
|
|
if (-not (Test-FeatureJsonMatchesFeatureDir -RepoRoot $paths.REPO_ROOT -ActiveFeatureDir $paths.FEATURE_DIR)) {
|
|
if (-not (Test-FeatureBranch -Branch $paths.CURRENT_BRANCH -HasGit $paths.HAS_GIT)) {
|
|
exit 1
|
|
}
|
|
}
|
|
|
|
# Ensure the feature directory exists
|
|
New-Item -ItemType Directory -Path $paths.FEATURE_DIR -Force | Out-Null
|
|
|
|
# Copy plan template if plan doesn't already exist
|
|
if (Test-Path $paths.IMPL_PLAN -PathType Leaf) {
|
|
if ($Json) {
|
|
[Console]::Error.WriteLine("Plan already exists at $($paths.IMPL_PLAN), skipping template copy")
|
|
} else {
|
|
Write-Output "Plan already exists at $($paths.IMPL_PLAN), skipping template copy"
|
|
}
|
|
} else {
|
|
$template = Resolve-Template -TemplateName 'plan-template' -RepoRoot $paths.REPO_ROOT
|
|
if ($template -and (Test-Path $template)) {
|
|
# Read the template content and write it to the implementation plan file with UTF-8 encoding without BOM
|
|
$content = [System.IO.File]::ReadAllText($template)
|
|
$utf8NoBom = New-Object System.Text.UTF8Encoding($false)
|
|
[System.IO.File]::WriteAllText($paths.IMPL_PLAN, $content, $utf8NoBom)
|
|
} else {
|
|
Write-Warning "Plan template not found"
|
|
# Create a basic plan file if template doesn't exist
|
|
New-Item -ItemType File -Path $paths.IMPL_PLAN -Force | Out-Null
|
|
}
|
|
}
|
|
|
|
# Output results
|
|
if ($Json) {
|
|
$result = [PSCustomObject]@{
|
|
FEATURE_SPEC = $paths.FEATURE_SPEC
|
|
IMPL_PLAN = $paths.IMPL_PLAN
|
|
SPECS_DIR = $paths.FEATURE_DIR
|
|
BRANCH = $paths.CURRENT_BRANCH
|
|
HAS_GIT = $paths.HAS_GIT
|
|
}
|
|
$result | ConvertTo-Json -Compress
|
|
} else {
|
|
Write-Output "FEATURE_SPEC: $($paths.FEATURE_SPEC)"
|
|
Write-Output "IMPL_PLAN: $($paths.IMPL_PLAN)"
|
|
Write-Output "SPECS_DIR: $($paths.FEATURE_DIR)"
|
|
Write-Output "BRANCH: $($paths.CURRENT_BRANCH)"
|
|
Write-Output "HAS_GIT: $($paths.HAS_GIT)"
|
|
}
|