mirror of
https://github.com/github/spec-kit.git
synced 2026-07-04 04:45:43 +08:00
* fix: stop check-prerequisites --paths-only from writing feature.json (#3025) check-prerequisites --paths-only / -PathsOnly is documented as pure, read-only path resolution, but when SPECIFY_FEATURE_DIRECTORY was set it called the persist routine and rewrote .specify/feature.json. That dirtied the working tree and overwrote a pinned feature directory during what should be a no-op. Add an explicit opt-out at the resolver boundary instead of a global env back-channel: - bash: get_feature_paths accepts a leading --no-persist flag that skips _persist_feature_json; check-prerequisites.sh passes it in --paths-only mode. - PowerShell: Get-FeaturePathsEnv gains a -NoPersist switch that skips Save-FeatureJson; check-prerequisites.ps1 passes it in -PathsOnly mode. Normal (non-paths-only) invocations are unchanged and still persist the override, so future sessions without the env var keep working. Add regression tests asserting --paths-only/-PathsOnly leaves a pinned feature.json untouched even when the env override differs, plus a guard that normal mode still persists. * fix: use ASCII hyphen in common.ps1 comment for PS 5.1 compatibility The em-dash in the persist comment introduced non-ASCII bytes, failing test_ps1_file_is_ascii_only which enforces ASCII-only PowerShell sources for Windows PowerShell 5.1 compatibility. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: add PowerShell normal-mode persistence guard (#3025) Addresses Copilot review feedback on #3190: the bash side had a `test_normal_mode_still_persists_feature_json` guard, but there was no symmetric PowerShell test asserting that running check-prerequisites.ps1 *without* -PathsOnly still persists the SPECIFY_FEATURE_DIRECTORY override into .specify/feature.json. Add test_ps_normal_mode_still_persists_feature_json, which guards against accidentally passing -NoPersist unconditionally (or flipping the default) in a future refactor. Verified it fails when -NoPersist is passed in the non -PathsOnly branch and passes with the current conditional. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
196 lines
6.3 KiB
Bash
196 lines
6.3 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# Consolidated prerequisite checking script
|
|
#
|
|
# This script provides unified prerequisite checking for Spec-Driven Development workflow.
|
|
# It replaces the functionality previously spread across multiple scripts.
|
|
#
|
|
# Usage: ./check-prerequisites.sh [OPTIONS]
|
|
#
|
|
# OPTIONS:
|
|
# --json Output in JSON format
|
|
# --require-tasks Require tasks.md to exist (for implementation phase)
|
|
# --include-tasks Include tasks.md in AVAILABLE_DOCS list
|
|
# --paths-only Only output path variables (no validation)
|
|
# --help, -h Show help message
|
|
#
|
|
# OUTPUTS:
|
|
# JSON mode: {"FEATURE_DIR":"...", "AVAILABLE_DOCS":["..."]}
|
|
# Text mode: FEATURE_DIR:... \n AVAILABLE_DOCS: \n ✓/✗ file.md
|
|
# Paths only: REPO_ROOT: ... \n BRANCH: ... \n FEATURE_DIR: ... etc.
|
|
|
|
set -e
|
|
|
|
# Parse command line arguments
|
|
JSON_MODE=false
|
|
REQUIRE_TASKS=false
|
|
INCLUDE_TASKS=false
|
|
PATHS_ONLY=false
|
|
|
|
for arg in "$@"; do
|
|
case "$arg" in
|
|
--json)
|
|
JSON_MODE=true
|
|
;;
|
|
--require-tasks)
|
|
REQUIRE_TASKS=true
|
|
;;
|
|
--include-tasks)
|
|
INCLUDE_TASKS=true
|
|
;;
|
|
--paths-only)
|
|
PATHS_ONLY=true
|
|
;;
|
|
--help|-h)
|
|
cat << 'EOF'
|
|
Usage: check-prerequisites.sh [OPTIONS]
|
|
|
|
Consolidated prerequisite checking for Spec-Driven Development workflow.
|
|
|
|
OPTIONS:
|
|
--json Output in JSON format
|
|
--require-tasks Require tasks.md to exist (for implementation phase)
|
|
--include-tasks Include tasks.md in AVAILABLE_DOCS list
|
|
--paths-only Only output path variables (no prerequisite validation)
|
|
--help, -h Show this help message
|
|
|
|
EXAMPLES:
|
|
# Check task prerequisites (plan.md required)
|
|
./check-prerequisites.sh --json
|
|
|
|
# Check implementation prerequisites (plan.md + tasks.md required)
|
|
./check-prerequisites.sh --json --require-tasks --include-tasks
|
|
|
|
# Get feature paths only (no validation)
|
|
./check-prerequisites.sh --paths-only
|
|
|
|
EOF
|
|
exit 0
|
|
;;
|
|
*)
|
|
echo "ERROR: Unknown option '$arg'. Use --help for usage information." >&2
|
|
exit 1
|
|
;;
|
|
esac
|
|
done
|
|
|
|
# Source common functions
|
|
SCRIPT_DIR="$(CDPATH="" cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "$SCRIPT_DIR/common.sh"
|
|
|
|
# Get feature paths.
|
|
# In --paths-only mode this is pure resolution, so pass --no-persist to opt out
|
|
# of the feature.json write side effect (issue #3025).
|
|
if $PATHS_ONLY; then
|
|
_paths_output=$(get_feature_paths --no-persist) || { echo "ERROR: Failed to resolve feature paths" >&2; exit 1; }
|
|
else
|
|
_paths_output=$(get_feature_paths) || { echo "ERROR: Failed to resolve feature paths" >&2; exit 1; }
|
|
fi
|
|
eval "$_paths_output"
|
|
unset _paths_output
|
|
|
|
# If paths-only mode, output paths and exit (no validation)
|
|
if $PATHS_ONLY; then
|
|
if $JSON_MODE; then
|
|
# Minimal JSON paths payload (no validation performed)
|
|
if has_jq; then
|
|
jq -cn \
|
|
--arg repo_root "$REPO_ROOT" \
|
|
--arg branch "$CURRENT_BRANCH" \
|
|
--arg feature_dir "$FEATURE_DIR" \
|
|
--arg feature_spec "$FEATURE_SPEC" \
|
|
--arg impl_plan "$IMPL_PLAN" \
|
|
--arg tasks "$TASKS" \
|
|
'{REPO_ROOT:$repo_root,BRANCH:$branch,FEATURE_DIR:$feature_dir,FEATURE_SPEC:$feature_spec,IMPL_PLAN:$impl_plan,TASKS:$tasks}'
|
|
else
|
|
printf '{"REPO_ROOT":"%s","BRANCH":"%s","FEATURE_DIR":"%s","FEATURE_SPEC":"%s","IMPL_PLAN":"%s","TASKS":"%s"}\n' \
|
|
"$(json_escape "$REPO_ROOT")" "$(json_escape "$CURRENT_BRANCH")" "$(json_escape "$FEATURE_DIR")" "$(json_escape "$FEATURE_SPEC")" "$(json_escape "$IMPL_PLAN")" "$(json_escape "$TASKS")"
|
|
fi
|
|
else
|
|
echo "REPO_ROOT: $REPO_ROOT"
|
|
echo "BRANCH: $CURRENT_BRANCH"
|
|
echo "FEATURE_DIR: $FEATURE_DIR"
|
|
echo "FEATURE_SPEC: $FEATURE_SPEC"
|
|
echo "IMPL_PLAN: $IMPL_PLAN"
|
|
echo "TASKS: $TASKS"
|
|
fi
|
|
exit 0
|
|
fi
|
|
|
|
# Validate required directories and files
|
|
if [[ ! -d "$FEATURE_DIR" ]]; then
|
|
echo "ERROR: Feature directory not found: $FEATURE_DIR" >&2
|
|
echo "Run $(format_speckit_command specify "$REPO_ROOT") first to create the feature structure." >&2
|
|
exit 1
|
|
fi
|
|
|
|
if [[ ! -f "$IMPL_PLAN" ]]; then
|
|
echo "ERROR: plan.md not found in $FEATURE_DIR" >&2
|
|
echo "Run $(format_speckit_command plan "$REPO_ROOT") first to create the implementation plan." >&2
|
|
exit 1
|
|
fi
|
|
|
|
# Check for tasks.md if required
|
|
if $REQUIRE_TASKS && [[ ! -f "$TASKS" ]]; then
|
|
echo "ERROR: tasks.md not found in $FEATURE_DIR" >&2
|
|
echo "Run $(format_speckit_command tasks "$REPO_ROOT") first to create the task list." >&2
|
|
exit 1
|
|
fi
|
|
|
|
# Build list of available documents
|
|
docs=()
|
|
|
|
# Always check these optional docs
|
|
[[ -f "$RESEARCH" ]] && docs+=("research.md")
|
|
[[ -f "$DATA_MODEL" ]] && docs+=("data-model.md")
|
|
|
|
# Check contracts directory (only if it exists and has files)
|
|
if [[ -d "$CONTRACTS_DIR" ]] && [[ -n "$(ls -A "$CONTRACTS_DIR" 2>/dev/null)" ]]; then
|
|
docs+=("contracts/")
|
|
fi
|
|
|
|
[[ -f "$QUICKSTART" ]] && docs+=("quickstart.md")
|
|
|
|
# Include tasks.md if requested and it exists
|
|
if $INCLUDE_TASKS && [[ -f "$TASKS" ]]; then
|
|
docs+=("tasks.md")
|
|
fi
|
|
|
|
# Output results
|
|
if $JSON_MODE; then
|
|
# Build JSON array of documents
|
|
if has_jq; then
|
|
if [[ ${#docs[@]} -eq 0 ]]; then
|
|
json_docs="[]"
|
|
else
|
|
json_docs=$(printf '%s\n' "${docs[@]}" | jq -R . | jq -s .)
|
|
fi
|
|
jq -cn \
|
|
--arg feature_dir "$FEATURE_DIR" \
|
|
--argjson docs "$json_docs" \
|
|
'{FEATURE_DIR:$feature_dir,AVAILABLE_DOCS:$docs}'
|
|
else
|
|
if [[ ${#docs[@]} -eq 0 ]]; then
|
|
json_docs="[]"
|
|
else
|
|
json_docs=$(for d in "${docs[@]}"; do printf '"%s",' "$(json_escape "$d")"; done)
|
|
json_docs="[${json_docs%,}]"
|
|
fi
|
|
printf '{"FEATURE_DIR":"%s","AVAILABLE_DOCS":%s}\n' "$(json_escape "$FEATURE_DIR")" "$json_docs"
|
|
fi
|
|
else
|
|
# Text output
|
|
echo "FEATURE_DIR:$FEATURE_DIR"
|
|
echo "AVAILABLE_DOCS:"
|
|
|
|
# Show status of each potential document
|
|
check_file "$RESEARCH" "research.md"
|
|
check_file "$DATA_MODEL" "data-model.md"
|
|
check_dir "$CONTRACTS_DIR" "contracts/"
|
|
check_file "$QUICKSTART" "quickstart.md"
|
|
|
|
if $INCLUDE_TASKS; then
|
|
check_file "$TASKS" "tasks.md"
|
|
fi
|
|
fi
|