diff --git a/kittens/choose_fonts/faces.go b/kittens/choose_fonts/faces.go index 9f33e8015..5b51245b5 100644 --- a/kittens/choose_fonts/faces.go +++ b/kittens/choose_fonts/faces.go @@ -52,6 +52,9 @@ func (self *faces) draw_screen() (err error) { previews, found := self.preview_cache[key] if !found { self.preview_cache[key] = make(map[string]RenderedSampleTransmit) + if self.handler.text_style.Foreground == "" || self.handler.text_style.Background == "" { + return + } go func() { var r map[string]RenderedSampleTransmit s := key.settings diff --git a/kittens/choose_fonts/list.go b/kittens/choose_fonts/list.go index ecff98d88..8150a399a 100644 --- a/kittens/choose_fonts/list.go +++ b/kittens/choose_fonts/list.go @@ -122,7 +122,7 @@ func (self *FontList) draw_family_summary(start_x int, sz loop.ScreenSize) (err lp.QueueWriteString(line) y++ } - if self.handler.text_style.Background != "" { + if self.handler.text_style.Foreground != "" && self.handler.text_style.Background != "" { return self.draw_preview(start_x, y, sz) } return diff --git a/kittens/choose_fonts/ui.go b/kittens/choose_fonts/ui.go index 11d16fe8d..78ad5e15a 100644 --- a/kittens/choose_fonts/ui.go +++ b/kittens/choose_fonts/ui.go @@ -139,9 +139,14 @@ func (h *handler) on_query_response(key, val string, valid bool) error { } case "foreground": h.text_style.Foreground = val + if h.text_style.Background != "" { + return h.draw_screen() + } case "background": h.text_style.Background = val - return h.draw_screen() + if h.text_style.Foreground != "" { + return h.draw_screen() + } } return nil }