Kovid Goyal
6d4371f596
Properly pass source actions to drop events
...
Implemented for Wayland. Needs implementation for X11 and macOS
2026-05-14 11:07:52 +05:30
copilot-swe-agent[bot]
66dca3cde1
Fix dnd kitten: restrict drop to boxes matching drag source allowed operations
...
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/41b8254d-fc79-4f41-9775-67d1ddfceb5b
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-05-14 02:49:17 +00:00
Kovid Goyal
8b17088b58
dnd fix remote drag source premature removal of remote file data
...
Instead the remote data is removed from the cache on:
1) new drag start
2) window destruction
3) application exit
2026-05-13 12:35:10 +05:30
Kovid Goyal
a0da884c6a
Add optional error descriptions to drop errors as well
2026-05-09 12:24:43 +05:30
Kovid Goyal
ff1ce8fa76
Add detection for dnd protocol
2026-05-06 08:48:26 +05:30
copilot-swe-agent[bot]
89ab2946ff
Implement text drag thumbnail support using draw_window_title with nerd font fallback
...
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/6be6bfeb-64f8-466f-bf80-62915fabb5b4
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-05-04 04:46:53 +00:00
Kovid Goyal
d3114ec948
More work on the dnd kitten
2026-05-02 15:18:11 +05:30
Kovid Goyal
b915e3317e
Drop protocol: have the final drop operation be reported at the end. This is needed for when there are errors in the client processing the dropped data.
2026-04-28 17:30:18 +05:30
Kovid Goyal
5558dfa953
Move dnd escape code encoding into dnd.c
2026-04-19 13:48:35 +05:30
copilot-swe-agent[bot]
efb4eeab50
move DnD testing infrastructure from glfw.c to dnd.c, add init_dnd()
...
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/78192f4b-c0b7-4c34-9073-4ea717b531da
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-04-14 02:12:18 +00:00
copilot-swe-agent[bot]
2018f8b134
Fix 4 bugs in t=k implementation and add test infrastructure
...
Bug 1: remote_items allocation used ds.num_mimes instead of mi.num_uris
Bug 2: Off-by-one in uri_item_idx > mi.num_uris (should be >=)
Bug 3: Off-by-one in entry_num > parent->children_sz (should be >=)
Bug 4: DRAG_SOURCE_DROPPED state never set in drag_notify
Also add dnd_test_force_drag_dropped() helper and make
notify_drag_data_ready() succeed in test mode.
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/9da0bff7-6a1a-490f-a4c5-8cb328e056ce
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-04-13 15:21:20 +00:00
Kovid Goyal
6bd41c94a2
Make the data transfer limits mutable for use in testing
2026-04-13 20:20:25 +05:30
Kovid Goyal
864ef70484
Have the client send machine id to terminal rather than vice versa
...
The terminal is the trusted by user party here.
2026-04-12 11:00:23 +05:30
Kovid Goyal
9ebe692bf7
Allow drop clients to use machine id as well
2026-04-12 09:27:16 +05:30
Kovid Goyal
df20d4aa7c
Add machine id and stub for t=k transfers
2026-04-11 17:20:53 +05:30
Kovid Goyal
9196cc51dd
Remove unused function
2026-04-09 21:40:29 +05:30
copilot-swe-agent[bot]
c42d8baaad
Implement DnD protocol refactoring: remove request_id, merge t=s/t=d into t=r, use x/y/Y for disambiguation
...
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/cdeecb3c-8589-4622-8f6b-21b724e4d5fd
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-04-09 15:26:36 +00:00
copilot-swe-agent[bot]
f42d07e7ac
Add request queue for drop data requests with FIFO ordering and request_id support
...
Implements a queue of up to 128 in-flight data requests in dnd.c.
All response headers include r=request_id when non-zero.
Queue overflow returns EMFILE and ends the drop.
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/3a4975c2-8691-486b-8ff9-f8a2146b8756
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-04-09 03:14:33 +00:00
Kovid Goyal
702f9905d2
More work on the DnD protocol
2026-04-08 19:19:20 +05:30
Kovid Goyal
348151c457
More work on DnD protocol
2026-04-08 19:07:15 +05:30
Kovid Goyal
2e15c0117e
Use correct client id when responding to drag escape codes
2026-04-08 11:25:39 +05:30
Kovid Goyal
ce041fab84
More work on DnD protocol implementation
2026-04-04 13:32:18 +05:30
Kovid Goyal
0fcbd265b6
Accumulate DnD image data
2026-04-03 23:18:07 +05:30
Kovid Goyal
0619c7e435
More work on DnD protocol
2026-04-03 19:58:59 +05:30
copilot-swe-agent[bot]
0f4b673d02
Implement TODO in drag_add_mimes: populate ds.mimes from ds.mimes_buf
...
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/b92ba12a-26f2-4a01-8ad9-665bbd90b98a
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-04-03 06:23:58 +00:00
Kovid Goyal
0584cbfadc
Implement sending drag start message to client
2026-04-03 09:42:57 +05:30
copilot-swe-agent[bot]
51fe3dc274
Implement DnD protocol: t=s URI file transfer and t=d directory listing with tests
...
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/a5aee38b-1746-4699-9dcc-2138f43cabe8
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-04-01 08:55:55 +00:00
copilot-swe-agent[bot]
02aec3fa3e
Add DnD protocol test framework and tests
...
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/faa69cb9-991d-49f4-802b-263f4bb28ee9
Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com >
2026-04-01 07:22:47 +00:00
Kovid Goyal
4f7855aede
More work on the DnD protocol
2026-04-01 12:01:04 +05:30
Kovid Goyal
17e941a180
Implement finishing of drops
2026-03-21 08:41:47 +05:30
Kovid Goyal
5ad55ec936
Implement drop data transmission
2026-03-21 08:41:47 +05:30
Kovid Goyal
4f404f8c85
Send dropped message
2026-03-21 08:41:47 +05:30
Kovid Goyal
3a30c47942
Get drop status updates working
2026-03-21 08:41:47 +05:30
Kovid Goyal
111b35b6a7
Implement drop leaving window
2026-03-21 08:41:47 +05:30
Kovid Goyal
b0e57b4dce
Send drop move events to child
2026-03-21 08:41:46 +05:30
