mirror of
https://github.com/larksuite/cli.git
synced 2026-07-06 00:06:28 +08:00
Introduce a typed error contract framework for lark-cli so in-process
Go callers can branch via errors.As(&errs.XxxError{}) and shell scripts,
AI agents, and protocol adapters can branch on stable JSON type/subtype
fields instead of regex-parsing free-form messages.
Adds:
- Canonical taxonomy under errs/ (9 categories + typed Error structs
embedding a shared Problem, RFC 7807-aligned)
- Centralized Lark code metadata + identity-aware BuildAPIError dispatch
- Typed JSON envelope writer alongside the legacy envelope writer
- MCP / OAuth (RFC 6750 Bearer) projection adapters
- Five CI lint guards preventing ad-hoc taxonomy drift
Backward compatibility: legacy *output.ExitError producers (ErrAPI,
ErrWithHint, Errorf, ErrBare) and business shortcuts that use them
continue to render the legacy envelope unchanged. SecurityPolicyError
wire format and exit code are preserved via a carve-out; taxonomy
migration is deferred to PR 2. Domain-specific business migration is
staged across PR 3+.
Framework-direct paths now return typed *errs.*Error: ErrAuth /
ErrValidation / ErrNetwork emit category literals on the wire
(authentication / validation / network), *core.ConfigError is promoted
at the cmd/root boundary with exit code aligned from 2 to 3, and Lark
API permission denials classified by BuildAPIError exit 3.
At the SDK boundary, WrapDoAPIError preserves any already-classified
error (legacy *output.ExitError or typed *errs.*) so output.ErrAuth
from missing credentials surfaces with the auth category and exit 3
intact instead of being downgraded to a network error. Policy responses
classified by BuildAPIError (codes 21000 / 21001) extract challenge_url
and the canonical hint from the response body, matching what the
auth transport already surfaces at the HTTP layer; non-https
challenge URLs are dropped.
First PR in the feat/error-contract-* series.
299 lines
9.3 KiB
Go
299 lines
9.3 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package core
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"path/filepath"
|
|
"strings"
|
|
"unicode/utf8"
|
|
|
|
"github.com/larksuite/cli/internal/keychain"
|
|
"github.com/larksuite/cli/internal/output"
|
|
"github.com/larksuite/cli/internal/validate"
|
|
"github.com/larksuite/cli/internal/vfs"
|
|
)
|
|
|
|
// Identity represents the caller identity for API requests.
|
|
type Identity string
|
|
|
|
const (
|
|
AsUser Identity = "user"
|
|
AsBot Identity = "bot"
|
|
AsAuto Identity = "auto"
|
|
)
|
|
|
|
// IsBot returns true if the identity is bot.
|
|
func (id Identity) IsBot() bool { return id == AsBot }
|
|
|
|
// AppUser is a logged-in user record stored in config.
|
|
type AppUser struct {
|
|
UserOpenId string `json:"userOpenId"`
|
|
UserName string `json:"userName"`
|
|
}
|
|
|
|
// AppConfig is a per-app configuration entry (stored format — secrets may be unresolved).
|
|
type AppConfig struct {
|
|
Name string `json:"name,omitempty"`
|
|
AppId string `json:"appId"`
|
|
AppSecret SecretInput `json:"appSecret"`
|
|
Brand LarkBrand `json:"brand"`
|
|
Lang string `json:"lang,omitempty"`
|
|
DefaultAs Identity `json:"defaultAs,omitempty"` // AsUser | AsBot | AsAuto
|
|
StrictMode *StrictMode `json:"strictMode,omitempty"`
|
|
Users []AppUser `json:"users"`
|
|
}
|
|
|
|
// ProfileName returns the display name for this app config.
|
|
// If Name is set, returns Name; otherwise falls back to AppId.
|
|
func (a *AppConfig) ProfileName() string {
|
|
if a.Name != "" {
|
|
return a.Name
|
|
}
|
|
return a.AppId
|
|
}
|
|
|
|
// MultiAppConfig is the multi-app config file format.
|
|
type MultiAppConfig struct {
|
|
StrictMode StrictMode `json:"strictMode,omitempty"`
|
|
CurrentApp string `json:"currentApp,omitempty"`
|
|
PreviousApp string `json:"previousApp,omitempty"`
|
|
Apps []AppConfig `json:"apps"`
|
|
}
|
|
|
|
// CurrentAppConfig returns the currently active app config.
|
|
// Resolution priority: profileOverride > CurrentApp field > Apps[0].
|
|
func (m *MultiAppConfig) CurrentAppConfig(profileOverride string) *AppConfig {
|
|
if profileOverride != "" {
|
|
if app := m.FindApp(profileOverride); app != nil {
|
|
return app
|
|
}
|
|
return nil
|
|
}
|
|
if m.CurrentApp != "" {
|
|
if app := m.FindApp(m.CurrentApp); app != nil {
|
|
return app
|
|
}
|
|
return nil // explicit currentApp not found; don't silently fallback
|
|
}
|
|
if len(m.Apps) > 0 {
|
|
return &m.Apps[0]
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// FindApp looks up an app by name, then by appId. Returns nil if not found.
|
|
// Name match takes priority: if profile A has Name "X" and profile B has AppId "X",
|
|
// FindApp("X") returns profile A.
|
|
func (m *MultiAppConfig) FindApp(name string) *AppConfig {
|
|
// First pass: match by Name
|
|
for i := range m.Apps {
|
|
if m.Apps[i].Name != "" && m.Apps[i].Name == name {
|
|
return &m.Apps[i]
|
|
}
|
|
}
|
|
// Second pass: match by AppId
|
|
for i := range m.Apps {
|
|
if m.Apps[i].AppId == name {
|
|
return &m.Apps[i]
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// FindAppIndex looks up an app index by name, then by appId. Returns -1 if not found.
|
|
func (m *MultiAppConfig) FindAppIndex(name string) int {
|
|
for i := range m.Apps {
|
|
if m.Apps[i].Name != "" && m.Apps[i].Name == name {
|
|
return i
|
|
}
|
|
}
|
|
for i := range m.Apps {
|
|
if m.Apps[i].AppId == name {
|
|
return i
|
|
}
|
|
}
|
|
return -1
|
|
}
|
|
|
|
// ProfileNames returns all profile names (Name if set, otherwise AppId).
|
|
func (m *MultiAppConfig) ProfileNames() []string {
|
|
names := make([]string, len(m.Apps))
|
|
for i := range m.Apps {
|
|
names[i] = m.Apps[i].ProfileName()
|
|
}
|
|
return names
|
|
}
|
|
|
|
// ValidateProfileName checks that a profile name is valid.
|
|
// Rejects empty names, whitespace, control characters, and shell-problematic characters,
|
|
// but allows Unicode letters (e.g. Chinese, Japanese) for localized profile names.
|
|
func ValidateProfileName(name string) error {
|
|
if name == "" {
|
|
return fmt.Errorf("profile name cannot be empty")
|
|
}
|
|
if utf8.RuneCountInString(name) > 64 {
|
|
return fmt.Errorf("profile name %q is too long (max 64 characters)", name)
|
|
}
|
|
for _, r := range name {
|
|
if r <= 0x1F || r == 0x7F { // control characters
|
|
return fmt.Errorf("invalid profile name %q: contains control characters", name)
|
|
}
|
|
switch r {
|
|
case ' ', '\t', '/', '\\', '"', '\'', '`', '$', '#', '!', '&', '|', ';', '(', ')', '{', '}', '[', ']', '<', '>', '?', '*', '~':
|
|
return fmt.Errorf("invalid profile name %q: contains invalid character %q", name, r)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// CliConfig is the resolved single-app config used by downstream code.
|
|
type CliConfig struct {
|
|
ProfileName string
|
|
AppID string
|
|
AppSecret string
|
|
Brand LarkBrand
|
|
DefaultAs Identity // AsUser | AsBot | AsAuto | "" (from config file)
|
|
UserOpenId string
|
|
UserName string
|
|
SupportedIdentities uint8 `json:"-"` // bitflag: 1=user, 2=bot; set by credential provider
|
|
}
|
|
|
|
// identityBotBit is the bit flag for bot identity in SupportedIdentities.
|
|
// Must match extension/credential.SupportsBot.
|
|
const identityBotBit uint8 = 1 << 1
|
|
|
|
// CanBot reports whether the current credential context supports bot identity.
|
|
// Returns true when SupportedIdentities is unset (0, unknown) or includes the bot bit.
|
|
func (c *CliConfig) CanBot() bool {
|
|
return c.SupportedIdentities == 0 || c.SupportedIdentities&identityBotBit != 0
|
|
}
|
|
|
|
// GetConfigDir returns the config directory path for the current workspace.
|
|
// When workspace is local (default), this returns the same path as before
|
|
// (LARKSUITE_CLI_CONFIG_DIR or ~/.lark-cli) — fully backward-compatible.
|
|
// When workspace is openclaw/hermes, returns base/openclaw or base/hermes.
|
|
func GetConfigDir() string {
|
|
return GetRuntimeDir()
|
|
}
|
|
|
|
// GetConfigPath returns the config file path for the current workspace.
|
|
func GetConfigPath() string {
|
|
return filepath.Join(GetConfigDir(), "config.json")
|
|
}
|
|
|
|
// LoadMultiAppConfig loads multi-app config from disk.
|
|
func LoadMultiAppConfig() (*MultiAppConfig, error) {
|
|
data, err := vfs.ReadFile(GetConfigPath())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var multi MultiAppConfig
|
|
if err := json.Unmarshal(data, &multi); err != nil {
|
|
return nil, fmt.Errorf("invalid config format: %w", err)
|
|
}
|
|
if len(multi.Apps) == 0 {
|
|
return nil, fmt.Errorf("invalid config format: no apps")
|
|
}
|
|
return &multi, nil
|
|
}
|
|
|
|
// SaveMultiAppConfig saves config to disk.
|
|
func SaveMultiAppConfig(config *MultiAppConfig) error {
|
|
dir := GetConfigDir()
|
|
if err := vfs.MkdirAll(dir, 0700); err != nil {
|
|
return err
|
|
}
|
|
data, err := json.MarshalIndent(config, "", " ")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return validate.AtomicWrite(GetConfigPath(), append(data, '\n'), 0600)
|
|
}
|
|
|
|
// RequireConfig loads the single-app config using the default profile resolution.
|
|
func RequireConfig(kc keychain.KeychainAccess) (*CliConfig, error) {
|
|
return RequireConfigForProfile(kc, "")
|
|
}
|
|
|
|
// RequireConfigForProfile loads the single-app config for a specific profile.
|
|
// Resolution priority: profileOverride > config.CurrentApp > Apps[0].
|
|
func RequireConfigForProfile(kc keychain.KeychainAccess, profileOverride string) (*CliConfig, error) {
|
|
raw, err := LoadMultiAppConfig()
|
|
if err != nil || raw == nil || len(raw.Apps) == 0 {
|
|
return nil, NotConfiguredError()
|
|
}
|
|
return ResolveConfigFromMulti(raw, kc, profileOverride)
|
|
}
|
|
|
|
// ResolveConfigFromMulti resolves a single-app config from an already-loaded MultiAppConfig.
|
|
// This avoids re-reading the config file when the caller has already loaded it.
|
|
func ResolveConfigFromMulti(raw *MultiAppConfig, kc keychain.KeychainAccess, profileOverride string) (*CliConfig, error) {
|
|
app := raw.CurrentAppConfig(profileOverride)
|
|
if app == nil {
|
|
return nil, &ConfigError{
|
|
Code: 3,
|
|
Type: "config",
|
|
Message: fmt.Sprintf("profile %q not found", profileOverride),
|
|
Hint: fmt.Sprintf("available profiles: %s", formatProfileNames(raw.ProfileNames())),
|
|
}
|
|
}
|
|
|
|
if err := ValidateSecretKeyMatch(app.AppId, app.AppSecret); err != nil {
|
|
return nil, &ConfigError{Code: 3, Type: "config",
|
|
Message: "appId and appSecret keychain key are out of sync",
|
|
Hint: err.Error()}
|
|
}
|
|
|
|
secret, err := ResolveSecretInput(app.AppSecret, kc)
|
|
if err != nil {
|
|
// Deprecated: legacy *output.ExitError passthrough; removed after typed migration.
|
|
var exitErr *output.ExitError
|
|
if errors.As(err, &exitErr) {
|
|
return nil, exitErr
|
|
}
|
|
return nil, &ConfigError{Code: 3, Type: "config", Message: err.Error()}
|
|
}
|
|
cfg := &CliConfig{
|
|
ProfileName: app.ProfileName(),
|
|
AppID: app.AppId,
|
|
AppSecret: secret,
|
|
Brand: app.Brand,
|
|
DefaultAs: app.DefaultAs,
|
|
}
|
|
if len(app.Users) > 0 {
|
|
cfg.UserOpenId = app.Users[0].UserOpenId
|
|
cfg.UserName = app.Users[0].UserName
|
|
}
|
|
return cfg, nil
|
|
}
|
|
|
|
// RequireAuth loads config and ensures a user is logged in.
|
|
func RequireAuth(kc keychain.KeychainAccess) (*CliConfig, error) {
|
|
return RequireAuthForProfile(kc, "")
|
|
}
|
|
|
|
// RequireAuthForProfile loads config for a profile and ensures a user is logged in.
|
|
func RequireAuthForProfile(kc keychain.KeychainAccess, profileOverride string) (*CliConfig, error) {
|
|
cfg, err := RequireConfigForProfile(kc, profileOverride)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if cfg.UserOpenId == "" {
|
|
return nil, &ConfigError{Code: 3, Type: "auth", Message: "not logged in", Hint: "run `lark-cli auth login` in the background. It blocks and outputs a verification URL — retrieve the URL and open it in a browser to complete login."}
|
|
}
|
|
return cfg, nil
|
|
}
|
|
|
|
// formatProfileNames joins profile names for display.
|
|
func formatProfileNames(names []string) string {
|
|
if len(names) == 0 {
|
|
return "(none)"
|
|
}
|
|
return strings.Join(names, ", ")
|
|
}
|