mirror of
https://github.com/larksuite/cli.git
synced 2026-07-06 08:12:36 +08:00
Replace every command-facing error path in the event domain — the consume/schema command layer, the +subscribe shortcut, EventKey definitions, and the consume orchestration — with typed errs.* envelopes, so consumers get stable type, subtype, param, hint, and missing_scopes metadata for classification and recovery instead of free-form message text. - Input validation (--jq, --param, --output-dir, --filter, --route, unknown EventKey, EventKey params) reports validation / invalid_argument with the offending flag in param and an actionable hint. - Scope preflight reports authorization / missing_scope with the machine-readable missing_scopes list; console-subscription and single-bus preconditions report failed_precondition with recovery hints. - The consume API boundary passes already-typed errors through and classifies transport, non-JSON HTTP, and unparsable responses; the vc note-detail retry now matches the not-found code on typed errors (it silently never fired against the legacy envelope shape). - Previously-bare failures exited 1 with a plain-text "Error:" line and now exit with their category code (validation 2, auth 3, network 4, internal 5) alongside the typed stderr envelope. - forbidigo and errscontract guards now cover the event paths so regressions fail lint; AGENTS.md and the lark-event skill document the typed contract for agent consumers. Validation: make unit-test (race) green; event unit and e2e suites assert category/subtype/param/hint and cause preservation against the real binary; errscontract and golangci lint clean.
177 lines
5.8 KiB
Go
177 lines
5.8 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package event
|
|
|
|
import (
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/larksuite/cli/errs"
|
|
"github.com/larksuite/cli/internal/appmeta"
|
|
"github.com/larksuite/cli/internal/core"
|
|
eventlib "github.com/larksuite/cli/internal/event"
|
|
)
|
|
|
|
func newPreflightCtx(appID string, brand core.LarkBrand, identity core.Identity, keyDef *eventlib.KeyDefinition, appVer *appmeta.AppVersion) *preflightCtx {
|
|
key := ""
|
|
if keyDef != nil {
|
|
key = keyDef.Key
|
|
}
|
|
return &preflightCtx{
|
|
appID: appID,
|
|
brand: brand,
|
|
eventKey: key,
|
|
identity: identity,
|
|
keyDef: keyDef,
|
|
appVer: appVer,
|
|
}
|
|
}
|
|
|
|
func TestPreflightEventTypes_NilAppVer_SkipsCheck(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{
|
|
Key: "im.message.text",
|
|
EventType: "im.message.receive_v1",
|
|
RequiredConsoleEvents: []string{"im.message.receive_v1"},
|
|
}
|
|
if err := preflightEventTypes(newPreflightCtx("cli_x", "feishu", "", def, nil)); err != nil {
|
|
t.Fatalf("nil appVer must be a weak-dependency skip, got err: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestPreflightEventTypes_EmptyRequired_SkipsEvenIfEventTypeSet(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{
|
|
Key: "im.message.message_read_v1",
|
|
EventType: "im.message.message_read_v1",
|
|
}
|
|
appVer := &appmeta.AppVersion{EventTypes: []string{"im.message.receive_v1"}}
|
|
if err := preflightEventTypes(newPreflightCtx("cli_x", "feishu", "", def, appVer)); err != nil {
|
|
t.Fatalf("empty RequiredConsoleEvents must skip, got: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestPreflightEventTypes_AllSubscribed_Passes(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{
|
|
Key: "im.reaction",
|
|
EventType: "im.message.reaction.created_v1",
|
|
RequiredConsoleEvents: []string{
|
|
"im.message.reaction.created_v1",
|
|
"im.message.reaction.deleted_v1",
|
|
},
|
|
}
|
|
appVer := &appmeta.AppVersion{EventTypes: []string{
|
|
"im.message.reaction.created_v1",
|
|
"im.message.reaction.deleted_v1",
|
|
"im.message.receive_v1",
|
|
}}
|
|
if err := preflightEventTypes(newPreflightCtx("cli_x", "feishu", "", def, appVer)); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestPreflightEventTypes_MissingBlocks(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{
|
|
Key: "mail.receive",
|
|
EventType: "mail.user_mailbox.event.message_received_v1",
|
|
RequiredConsoleEvents: []string{
|
|
"mail.user_mailbox.event.message_received_v1",
|
|
"mail.user_mailbox.event.message_read_v1",
|
|
},
|
|
}
|
|
appVer := &appmeta.AppVersion{EventTypes: []string{
|
|
"mail.user_mailbox.event.message_received_v1",
|
|
}}
|
|
err := preflightEventTypes(newPreflightCtx("cli_XXXXXXXXXXXXXXXX", "feishu", "", def, appVer))
|
|
if err == nil {
|
|
t.Fatal("expected error for missing subscription")
|
|
}
|
|
if !strings.Contains(err.Error(), "mail.user_mailbox.event.message_read_v1") {
|
|
t.Errorf("error should name the missing event type, got: %v", err)
|
|
}
|
|
p, ok := errs.ProblemOf(err)
|
|
if !ok {
|
|
t.Fatalf("expected typed errs error, got %T: %v", err, err)
|
|
}
|
|
if p.Category != errs.CategoryValidation || p.Subtype != errs.SubtypeFailedPrecondition {
|
|
t.Errorf("problem = %s/%s, want %s/%s", p.Category, p.Subtype,
|
|
errs.CategoryValidation, errs.SubtypeFailedPrecondition)
|
|
}
|
|
wantURL := "https://open.feishu.cn/app/cli_XXXXXXXXXXXXXXXX/event"
|
|
if !strings.Contains(p.Hint, wantURL) {
|
|
t.Errorf("hint missing subscription URL %q\ngot: %s", wantURL, p.Hint)
|
|
}
|
|
}
|
|
|
|
func TestPreflightScopes_Bot_NoAppVer_SkipsCheck(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{
|
|
Key: "im.message.text",
|
|
Scopes: []string{"im:message", "im:message.group_at_msg"},
|
|
}
|
|
err := preflightScopes(nil, newPreflightCtx("cli_x", "feishu", core.AsBot, def, nil))
|
|
if err != nil {
|
|
t.Fatalf("bot + nil appVer should skip, got: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestPreflightScopes_Bot_AllGranted_Passes(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{
|
|
Key: "im.message.text",
|
|
Scopes: []string{"im:message", "im:message.group_at_msg"},
|
|
}
|
|
appVer := &appmeta.AppVersion{TenantScopes: []string{
|
|
"im:message",
|
|
"im:message.group_at_msg",
|
|
"contact:user:readonly",
|
|
}}
|
|
err := preflightScopes(nil, newPreflightCtx("cli_x", "feishu", core.AsBot, def, appVer))
|
|
if err != nil {
|
|
t.Fatalf("all scopes granted, unexpected error: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestPreflightScopes_Bot_MissingBlocks(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{
|
|
Key: "im.message.text",
|
|
Scopes: []string{"im:message", "im:message.group_at_msg"},
|
|
}
|
|
appVer := &appmeta.AppVersion{TenantScopes: []string{"im:message"}}
|
|
err := preflightScopes(nil, newPreflightCtx("cli_x", "feishu", core.AsBot, def, appVer))
|
|
if err == nil {
|
|
t.Fatal("expected error for missing scope")
|
|
}
|
|
if !strings.Contains(err.Error(), "im:message.group_at_msg") {
|
|
t.Errorf("error should name missing scope, got: %v", err)
|
|
}
|
|
var permErr *errs.PermissionError
|
|
if !errors.As(err, &permErr) {
|
|
t.Fatalf("expected *errs.PermissionError, got %T: %v", err, err)
|
|
}
|
|
if permErr.Category != errs.CategoryAuthorization || permErr.Subtype != errs.SubtypeMissingScope {
|
|
t.Errorf("problem = %s/%s, want %s/%s", permErr.Category, permErr.Subtype,
|
|
errs.CategoryAuthorization, errs.SubtypeMissingScope)
|
|
}
|
|
wantMissing := []string{"im:message.group_at_msg"}
|
|
if len(permErr.MissingScopes) != 1 || permErr.MissingScopes[0] != wantMissing[0] {
|
|
t.Errorf("MissingScopes = %v, want %v", permErr.MissingScopes, wantMissing)
|
|
}
|
|
hint := permErr.Hint
|
|
wantSubstrings := []string{
|
|
"https://open.feishu.cn/app/cli_x/auth?q=",
|
|
"im:message.group_at_msg",
|
|
"token_type=tenant",
|
|
}
|
|
for _, want := range wantSubstrings {
|
|
if !strings.Contains(hint, want) {
|
|
t.Errorf("hint missing %q\ngot: %s", want, hint)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestPreflightScopes_NoRequiredScopes_SkipsCheck(t *testing.T) {
|
|
def := &eventlib.KeyDefinition{Key: "x"}
|
|
if err := preflightScopes(nil, newPreflightCtx("cli_x", "feishu", core.AsBot, def, nil)); err != nil {
|
|
t.Fatalf("no required scopes means nothing to verify, got: %v", err)
|
|
}
|
|
}
|