mirror of
https://github.com/larksuite/cli.git
synced 2026-07-03 14:02:43 +08:00
c5b5aece33
* refactor: retire legacy error envelopes and enforce typed contract
Consolidate all command error reporting onto the typed errs.* contract, remove
the legacy error surface that predated it, and tighten the lint guards so the
contract holds across the whole repository going forward.
Every failure now reaches stderr as one envelope shape: a category, an
optional subtype, a human- and agent-readable message, and a recovery hint,
with invalid parameters listed under `params`. The legacy ExitError envelope,
its constructors, and the boundary bridge that promoted untyped config and
authorization errors are deleted, leaving a single path from error to wire.
Predicate commands keep their silent-exit behavior through a dedicated signal
that carries only an exit code.
Infrastructure paths that still emitted ad-hoc envelopes — flag parsing,
unknown commands and subcommands, plugin and policy guards, confirmation
prompts, and auth/config failures — now classify into the same taxonomy.
Business, API, auth, and config exit codes are preserved; the one behavioral
change is that Cobra usage failures (missing required flag, unknown command,
bad arguments) now emit the typed validation envelope and exit 2, matching the
explicit flag and subcommand guards, instead of Cobra's plain-text exit 1.
Enforcement is repo-wide rather than per-path:
- The errscontract guards run by default everywhere instead of through a
migration allowlist, so legacy envelopes cannot be reintroduced anywhere.
- errorlint runs across the whole repository: every error wrap must use %w and
every comparison must use errors.Is/errors.As, so interior wraps stay legal
but can no longer break the chain the typed boundary relies on.
- The errs-no-bare-wrap guard is keyed by structural prefix instead of an
explicit per-domain allowlist, so new shortcut domains are covered without
editing a list. It runs where forbidigo is enabled (the shortcut domains and
the auth/config/service command groups); repo-wide chain integrity for the
remaining command paths is carried by errorlint above.
* test: align cli_e2e success assertions to the ok envelope
The api and service success path now emits the {"ok":true} envelope, so the
cli_e2e workflow assertions that still expected the old {"code":0} shape via
AssertStdoutStatus(t, 0) fail once they run with live credentials. Switch those
workflow assertions to AssertStdoutStatus(t, true); the fake-payload helper test
in core_test.go keeps its code-shape assertion.
97 lines
2.8 KiB
Go
97 lines
2.8 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package errs_test
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/larksuite/cli/errs"
|
|
)
|
|
|
|
func TestMarkRawNilReturnsNil(t *testing.T) {
|
|
if got := errs.MarkRaw(nil); got != nil {
|
|
t.Fatalf("MarkRaw(nil) = %v, want nil", got)
|
|
}
|
|
}
|
|
|
|
func TestIsRaw(t *testing.T) {
|
|
base := fmt.Errorf("boom")
|
|
|
|
if !errs.IsRaw(errs.MarkRaw(base)) {
|
|
t.Errorf("IsRaw(MarkRaw(err)) = false, want true")
|
|
}
|
|
if errs.IsRaw(base) {
|
|
t.Errorf("IsRaw(bare err) = true, want false")
|
|
}
|
|
if errs.IsRaw(nil) {
|
|
t.Errorf("IsRaw(nil) = true, want false")
|
|
}
|
|
|
|
// Raw marking survives further wrapping above it in the chain.
|
|
wrapped := fmt.Errorf("outer: %w", errs.MarkRaw(base))
|
|
if !errs.IsRaw(wrapped) {
|
|
t.Errorf("IsRaw(wrap(MarkRaw(err))) = false, want true")
|
|
}
|
|
}
|
|
|
|
func TestMarkRawPreservesErrorMessage(t *testing.T) {
|
|
base := fmt.Errorf("boom")
|
|
if got := errs.MarkRaw(base).Error(); got != "boom" {
|
|
t.Fatalf("MarkRaw(err).Error() = %q, want %q", got, "boom")
|
|
}
|
|
}
|
|
|
|
func TestMarkRawPreservesErrorsIsChain(t *testing.T) {
|
|
sentinel := errors.New("sentinel")
|
|
wrapped := fmt.Errorf("ctx: %w", sentinel)
|
|
|
|
if !errors.Is(errs.MarkRaw(wrapped), sentinel) {
|
|
t.Fatalf("errors.Is(MarkRaw(err), sentinel) = false, want true")
|
|
}
|
|
}
|
|
|
|
func TestProblemOfPunchesThroughMarkRaw(t *testing.T) {
|
|
typed := errs.NewValidationError(errs.SubtypeInvalidArgument, "bad flag")
|
|
raw := errs.MarkRaw(typed)
|
|
|
|
p, ok := errs.ProblemOf(raw)
|
|
if !ok {
|
|
t.Fatalf("ProblemOf(MarkRaw(typed)) ok = false, want true")
|
|
}
|
|
if p.Category != errs.CategoryValidation {
|
|
t.Errorf("ProblemOf(MarkRaw(typed)).Category = %v, want %v", p.Category, errs.CategoryValidation)
|
|
}
|
|
|
|
// errors.As still finds the concrete typed error through the raw wrapper.
|
|
var ve *errs.ValidationError
|
|
if !errors.As(raw, &ve) {
|
|
t.Errorf("errors.As(MarkRaw(typed), *ValidationError) = false, want true")
|
|
}
|
|
}
|
|
|
|
// TestMarkRawUnwrapsToInnerTypedError pins the envelope-serialization
|
|
// contract: UnwrapTypedError must return the inner concrete typed error,
|
|
// not the rawPassthrough wrapper. The wrapper has no exported fields, so if it
|
|
// were returned the JSON envelope would marshal to an empty "{}" error.
|
|
func TestMarkRawUnwrapsToInnerTypedError(t *testing.T) {
|
|
base := errs.NewValidationError(errs.SubtypeInvalidArgument, "bad flag")
|
|
typed, ok := errs.UnwrapTypedError(errs.MarkRaw(base))
|
|
if !ok {
|
|
t.Fatal("UnwrapTypedError(MarkRaw(typed)) must find a typed error")
|
|
}
|
|
out, err := json.Marshal(typed)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if string(out) == "{}" {
|
|
t.Fatalf("UnwrapTypedError returned the opaque rawPassthrough wrapper; envelope would be empty: %s", out)
|
|
}
|
|
if got := errs.CategoryOf(typed); got != errs.CategoryValidation {
|
|
t.Fatalf("unwrapped category = %q, want validation", got)
|
|
}
|
|
}
|