mirror of
https://github.com/larksuite/cli.git
synced 2026-07-06 16:18:05 +08:00
5e6a3eb857
* feat(mail): return typed error envelopes across the mail domain Replace every produced error path in shortcuts/mail with typed errs.* envelopes, so consumers get stable category, subtype, param/params, hint, retryable, and log_id metadata for classification and recovery instead of free-form message text. - Locally constructed mail errors move from output.Err* / output.Errorf / final fmt.Errorf / common legacy helpers to errs.* builders, with structured params on multi-flag validation and failed-precondition states kept non-retryable. - API-call failures move from runtime.CallAPI / DoAPIJSON legacy boundaries to runtime.CallAPITyped or runtime.ClassifyAPIResponse, and mail-specific enrichers read errs.ProblemOf so typed code, subtype, hint, and log_id metadata are preserved. - Batch draft-send partial failures now use runtime.OutPartialFailure so successful and failed draft sends stay in stdout while the command exits through a typed multi-status signal. - Add mail-domain typed helpers, mail API code metadata, and guard wiring to keep shortcuts/mail from reintroducing legacy envelopes or legacy API calls. - Keep genuine intermediate fmt.Errorf wraps in parser/builder layers annotated with nolint comments; command-facing paths wrap them into typed validation, API, network, or internal errors. * fix(mail): report aborted draft-send batches as a single failure result When an account-level failure interrupts a batch send after some drafts already went out, the command previously produced two machine-readable failure results: the partial-failure ledger on stdout and a second error envelope on stderr. Consumers could not tell which one to recover from. The batch ledger is now the only failure result for that case: it gains aborted and abort_error fields carrying the typed cause, so callers can see which drafts were sent, which failed, why the batch stopped, and how to recover — all from stdout. A --stop-on-error stop keeps these fields unset because stopping early there is the caller's own choice.
66 lines
2.2 KiB
Go
66 lines
2.2 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
//nolint:forbidigo // intermediate draft attachment limit errors; mail command layer wraps into typed ValidationError.
|
|
package draft
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/larksuite/cli/shortcuts/mail/filecheck"
|
|
)
|
|
|
|
// Attachment limits mirrored from the parent mail package so that the draft
|
|
// sub-package can enforce the same constraints without a circular import.
|
|
const (
|
|
maxAttachmentCount = 250
|
|
maxAttachmentBytes = 25 * 1024 * 1024 // 25 MB
|
|
)
|
|
|
|
// checkBlockedExtension delegates to the shared filecheck package.
|
|
var checkBlockedExtension = filecheck.CheckBlockedExtension
|
|
|
|
// isAttachmentOrInline returns true if the part is an attachment or inline
|
|
// image (as opposed to a body text/plain or text/html part).
|
|
func isAttachmentOrInline(p *Part) bool {
|
|
disp := strings.ToLower(p.ContentDisposition)
|
|
return disp == "attachment" || disp == "inline" || p.ContentID != ""
|
|
}
|
|
|
|
// checkSnapshotAttachmentLimit verifies that adding a file of newFileSize bytes
|
|
// would not push the snapshot past the attachment count or total-size limits.
|
|
// replacedPart, if non-nil, is the part being replaced — its count and size
|
|
// are deducted so that a replace does not double-count.
|
|
//
|
|
// Callers must validate the file path via validate.SafeInputPath and stat the
|
|
// file themselves before calling this function.
|
|
func checkSnapshotAttachmentLimit(snapshot *DraftSnapshot, newFileSize int64, replacedPart *Part) error {
|
|
var existingCount int
|
|
var existingBytes int64
|
|
for _, p := range flattenParts(snapshot.Body) {
|
|
if p.IsMultipart() || !isAttachmentOrInline(p) {
|
|
continue
|
|
}
|
|
existingCount++
|
|
existingBytes += int64(len(p.Body))
|
|
}
|
|
|
|
totalCount := existingCount
|
|
totalBytes := existingBytes + newFileSize
|
|
if replacedPart != nil {
|
|
totalBytes -= int64(len(replacedPart.Body))
|
|
} else {
|
|
totalCount++
|
|
}
|
|
|
|
if totalCount > maxAttachmentCount {
|
|
return fmt.Errorf("attachment count %d exceeds the limit of %d", totalCount, maxAttachmentCount)
|
|
}
|
|
if totalBytes > maxAttachmentBytes {
|
|
return fmt.Errorf("total attachment size %.1f MB exceeds the 25 MB limit",
|
|
float64(totalBytes)/1024/1024)
|
|
}
|
|
return nil
|
|
}
|