mirror of
https://github.com/larksuite/cli.git
synced 2026-07-03 14:02:43 +08:00
57ba4fae61
* feat: unconditionally inject --format flag for all shortcuts Removes three HasFormat guards in runner.go so every shortcut gets --format regardless of the Shortcut.HasFormat field value. Shortcuts that already define a custom 'format' flag in Flags[] are skipped to avoid redefinition panics (e.g. mail +triage, +watch). HasFormat is retained in the struct but marked deprecated. Change-Id: I5e8fe07e839d5aed4cefaf7d753dabbaee68fb6e * test: isolate config dir in format-universal test Change-Id: I3a59942aa8a6753cd949ca42f2a19a72f032ff55 * test: revert unnecessary config-dir isolation (mount-only test) Change-Id: I0146e5a2f57f5419863bdeeaa1a662fd8f70bddf
40 lines
1.1 KiB
Go
40 lines
1.1 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package common
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/larksuite/cli/internal/cmdutil"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
// TestShortcutMount_FormatFlagAlwaysRegistered verifies that --format is
|
|
// injected for every shortcut regardless of the HasFormat field value.
|
|
func TestShortcutMount_FormatFlagAlwaysRegistered(t *testing.T) {
|
|
f, _, _, _ := cmdutil.TestFactory(t, nil)
|
|
parent := &cobra.Command{Use: "root"}
|
|
shortcut := Shortcut{
|
|
Service: "im",
|
|
Command: "+message-send",
|
|
Description: "send message",
|
|
HasFormat: false, // explicitly false — format must still be registered
|
|
Execute: func(context.Context, *RuntimeContext) error { return nil },
|
|
}
|
|
shortcut.Mount(parent, f)
|
|
|
|
cmd, _, err := parent.Find([]string{"+message-send"})
|
|
if err != nil {
|
|
t.Fatalf("Find() error = %v", err)
|
|
}
|
|
flag := cmd.Flags().Lookup("format")
|
|
if flag == nil {
|
|
t.Fatal("--format flag not registered; expected it to be injected even when HasFormat is false")
|
|
}
|
|
if flag.DefValue != "json" {
|
|
t.Errorf("--format default = %q, want %q", flag.DefValue, "json")
|
|
}
|
|
}
|