mirror of
https://github.com/larksuite/cli.git
synced 2026-07-08 10:08:02 +08:00
8f410ab140
Users who install or upgrade lark-cli via make install, go install, or
direct binary download end up with a binary but no AI agent skills,
degrading agent UX. This PR adds a startup-time skills version drift
notice (injected into JSON envelope _notice.skills, mirroring the
existing _notice.update pattern) and unifies lark-cli update's skills
sync across all three branches (npm / manual / already-latest) with
stamp-based dedup, so any explicit update invocation keeps skills in
sync regardless of how the binary was installed.
Changes:
- new internal/skillscheck package: notice (StaleNotice + atomic
pending), stamp (~/.lark-cli/skills.stamp), skip (CI / DEV /
non-release / LARKSUITE_CLI_NO_SKILLS_NOTIFIER opt-out), check
(synchronous Init)
- cmd/root.go: rename setupUpdateNotice -> setupNotices, compose
output.PendingNotice returning {update?, skills?}; capture
build.Version locally before spawning the async update goroutine
- cmd/update/update.go: add runSkillsAndStamp helper with stamp-based
dedup; rewire the three branches through shared applySkillsResult /
emitSkillsTextHints helpers; add skills_status block to --check JSON
output as a pure report (no side effects)
- internal/update: export IsRelease(version) bool / IsCIEnv() bool
for cross-package reuse; refresh UpdateInfo.Message to append
', run: lark-cli update' so both notices recommend the same fix
- AGENTS.md: add Notification Opt-Outs section documenting
LARKSUITE_CLI_NO_UPDATE_NOTIFIER and LARKSUITE_CLI_NO_SKILLS_NOTIFIER
- internal/binding/types.go: bump default exec-provider timeout from
5s to 10s (out-of-scope flake fix for TestResolveExecRef_JSONResponse
under heavy parallel test load)
114 lines
3.2 KiB
Go
114 lines
3.2 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package skillscheck
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestReadStamp_Missing(t *testing.T) {
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", t.TempDir())
|
|
got, err := ReadStamp()
|
|
if err != nil {
|
|
t.Fatalf("ReadStamp() err = %v, want nil for ENOENT", err)
|
|
}
|
|
if got != "" {
|
|
t.Errorf("ReadStamp() = %q, want \"\" for missing file", got)
|
|
}
|
|
}
|
|
|
|
func TestReadStamp_Normal(t *testing.T) {
|
|
dir := t.TempDir()
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", dir)
|
|
if err := os.WriteFile(filepath.Join(dir, "skills.stamp"), []byte("1.0.21"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, err := ReadStamp()
|
|
if err != nil || got != "1.0.21" {
|
|
t.Errorf("ReadStamp() = (%q, %v), want (\"1.0.21\", nil)", got, err)
|
|
}
|
|
}
|
|
|
|
func TestReadStamp_TrailingNewlineTolerated(t *testing.T) {
|
|
dir := t.TempDir()
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", dir)
|
|
if err := os.WriteFile(filepath.Join(dir, "skills.stamp"), []byte("1.0.21\n"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, _ := ReadStamp()
|
|
if got != "1.0.21" {
|
|
t.Errorf("ReadStamp() = %q, want \"1.0.21\" (newline trimmed)", got)
|
|
}
|
|
}
|
|
|
|
func TestReadStamp_EmptyFile(t *testing.T) {
|
|
dir := t.TempDir()
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", dir)
|
|
if err := os.WriteFile(filepath.Join(dir, "skills.stamp"), []byte(""), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, err := ReadStamp()
|
|
if err != nil || got != "" {
|
|
t.Errorf("ReadStamp() = (%q, %v), want (\"\", nil)", got, err)
|
|
}
|
|
}
|
|
|
|
func TestWriteStamp_CreatesDir(t *testing.T) {
|
|
dir := filepath.Join(t.TempDir(), "nested")
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", dir)
|
|
if err := WriteStamp("1.0.21"); err != nil {
|
|
t.Fatalf("WriteStamp() = %v, want nil", err)
|
|
}
|
|
got, _ := os.ReadFile(filepath.Join(dir, "skills.stamp"))
|
|
if string(got) != "1.0.21" {
|
|
t.Errorf("file content = %q, want \"1.0.21\"", string(got))
|
|
}
|
|
}
|
|
|
|
func TestWriteStamp_OverwritesExisting(t *testing.T) {
|
|
dir := t.TempDir()
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", dir)
|
|
if err := WriteStamp("1.0.20"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := WriteStamp("1.0.21"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, _ := ReadStamp()
|
|
if got != "1.0.21" {
|
|
t.Errorf("ReadStamp() after overwrite = %q, want \"1.0.21\"", got)
|
|
}
|
|
}
|
|
|
|
func TestWriteStamp_NoTrailingNewline(t *testing.T) {
|
|
dir := t.TempDir()
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", dir)
|
|
if err := WriteStamp("1.0.21"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
raw, _ := os.ReadFile(filepath.Join(dir, "skills.stamp"))
|
|
if string(raw) != "1.0.21" {
|
|
t.Errorf("raw file = %q, want exactly \"1.0.21\" (no newline)", string(raw))
|
|
}
|
|
}
|
|
|
|
// TestWriteStamp_MkdirAllFailure verifies WriteStamp returns the mkdir error
|
|
// when the base config dir cannot be created (parent path is a regular file).
|
|
func TestWriteStamp_MkdirAllFailure(t *testing.T) {
|
|
tmp := t.TempDir()
|
|
blocker := filepath.Join(tmp, "blocker")
|
|
// Create a regular file where MkdirAll wants to create a directory.
|
|
if err := os.WriteFile(blocker, []byte("not-a-dir"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Point the config dir at a path UNDER the regular file — MkdirAll must fail.
|
|
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", filepath.Join(blocker, "child"))
|
|
|
|
if err := WriteStamp("1.0.21"); err == nil {
|
|
t.Fatal("WriteStamp() = nil, want non-nil error from MkdirAll failure")
|
|
}
|
|
}
|