mirror of
https://github.com/larksuite/cli.git
synced 2026-07-07 09:11:44 +08:00
* feat(sidecar): add sidecar proxy for sandbox credential isolation
Keep real secrets (app_secret, access_token) out of sandbox environments.
CLI instances inside sandboxes connect to a trusted sidecar process via
HTTP; the sidecar verifies HMAC-signed requests and injects real tokens
before forwarding to the Lark API.
Key components:
- `auth proxy` subcommand to start the sidecar server (build tag: authsidecar)
- Noop credential provider returns sentinel tokens in sidecar mode
- Transport interceptor rewrites requests to sidecar with HMAC signature
- Env provider yields to sidecar provider when AUTH_PROXY is set
- Supports both feishu and lark brand endpoints
* feat(sidecar): implement priority ordering for credential providers
* feat(sidecar): strip client-supplied auth headers and improve shutdown logging
* feat(sidecar): buffer request body to prevent HMAC mismatches on read errors
* feat(sidecar): fix CI
* refactor(sidecar): publish protocol package and move server to reference demo
The sidecar server is no longer shipped as a `lark-cli auth proxy`
subcommand. Instead, the CLI provides only the standard sidecar *client*
(via `-tags authsidecar`), while the wire-protocol utilities are exposed
as a public package for integrators to implement their own server.
Changes:
- Move `internal/sidecar/` → `sidecar/` so external integrators can
import HMAC signing, headers, sentinels and address validators.
- Remove `cmd/auth/proxy.go`, `proxy_stub.go`, `proxy_test.go` and the
conditional registration in `cmd/auth/auth.go`.
- Add `sidecar/server-demo/` — a reference server implementation behind
the `authsidecar_demo` build tag. It reuses the lark-cli credential
pipeline for local development; production integrators are expected
to replace the credential layer with their own secrets source.
- Update all internal imports from `internal/sidecar` to `sidecar`.
Rationale:
- Each integrator has different secrets management / HA / multi-tenant
requirements, so a one-size-fits-all server doesn't belong in the
shipped CLI.
- Keeping the client in-tree guarantees all sandbox-side code stays
protocol-compatible without a second repo to sync.
- The public `sidecar/` package pins the wire protocol as a stable
contract third-party servers must conform to.
Build matrix after this change:
- `go build` → standard CLI, no sidecar code
- `go build -tags authsidecar` → CLI + sidecar client
- `go build -tags authsidecar_demo \
./sidecar/server-demo/` → reference server binary
No production users are affected today because the server was not yet
released; existing sidecar-client users are unchanged.
* feat(sidecar): close 5 pre-release security gaps
- Server: enforce https-only target (no path/query/userinfo), pin
forwardURL to https:// — blocks cleartext token leak
- Protocol v1: canonical now covers version/identity/auth-header,
blocks identity-flip replay within drift window
- Client: ValidateProxyAddr requires loopback or same-host alias,
rejects userinfo and https (interceptor is http-only); cross-machine
is out of scope
- Build: non-authsidecar builds exit(2) when AUTH_PROXY is set,
preventing silent fallback to env credentials
- Demo: whitelist auth-header to Authorization / X-Lark-MCP-{UAT,TAT},
blocks token injection into Cookie / UA / X-Forwarded-For exfil paths
132 lines
3.9 KiB
Go
132 lines
3.9 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
//go:build authsidecar
|
|
|
|
// Package sidecar provides a noop credential provider for the auth sidecar
|
|
// proxy mode. When LARKSUITE_CLI_AUTH_PROXY is set, this provider supplies
|
|
// placeholder credentials so the CLI's auth pipeline can proceed normally.
|
|
// Real tokens are never present in the sandbox; the sidecar transport
|
|
// interceptor routes requests to the trusted sidecar process instead.
|
|
package sidecar
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/larksuite/cli/extension/credential"
|
|
"github.com/larksuite/cli/internal/envvars"
|
|
"github.com/larksuite/cli/sidecar"
|
|
)
|
|
|
|
// Provider is the noop credential provider for sidecar mode.
|
|
type Provider struct{}
|
|
|
|
func (p *Provider) Name() string { return "sidecar" }
|
|
func (p *Provider) Priority() int { return 0 }
|
|
|
|
// ResolveAccount returns a minimal Account when sidecar mode is active.
|
|
// The account contains AppID and Brand from environment variables, a
|
|
// placeholder secret, and SupportedIdentities derived from STRICT_MODE.
|
|
// Returns nil, nil when sidecar mode is not active (AUTH_PROXY not set).
|
|
func (p *Provider) ResolveAccount(ctx context.Context) (*credential.Account, error) {
|
|
proxyAddr := os.Getenv(envvars.CliAuthProxy)
|
|
if proxyAddr == "" {
|
|
return nil, nil // not in sidecar mode, skip
|
|
}
|
|
|
|
if err := sidecar.ValidateProxyAddr(proxyAddr); err != nil {
|
|
return nil, &credential.BlockError{
|
|
Provider: "sidecar",
|
|
Reason: fmt.Sprintf("invalid %s %q: %v", envvars.CliAuthProxy, proxyAddr, err),
|
|
}
|
|
}
|
|
|
|
appID := os.Getenv(envvars.CliAppID)
|
|
if appID == "" {
|
|
return nil, &credential.BlockError{
|
|
Provider: "sidecar",
|
|
Reason: envvars.CliAuthProxy + " is set but " + envvars.CliAppID + " is missing",
|
|
}
|
|
}
|
|
|
|
if os.Getenv(envvars.CliProxyKey) == "" {
|
|
return nil, &credential.BlockError{
|
|
Provider: "sidecar",
|
|
Reason: envvars.CliAuthProxy + " is set but " + envvars.CliProxyKey + " is missing",
|
|
}
|
|
}
|
|
|
|
brand := credential.Brand(os.Getenv(envvars.CliBrand))
|
|
if brand == "" {
|
|
brand = credential.BrandFeishu
|
|
}
|
|
|
|
acct := &credential.Account{
|
|
AppID: appID,
|
|
AppSecret: credential.NoAppSecret,
|
|
Brand: brand,
|
|
}
|
|
|
|
// Parse DefaultAs
|
|
switch id := credential.Identity(os.Getenv(envvars.CliDefaultAs)); id {
|
|
case "", credential.IdentityAuto:
|
|
acct.DefaultAs = id
|
|
case credential.IdentityUser, credential.IdentityBot:
|
|
acct.DefaultAs = id
|
|
default:
|
|
return nil, &credential.BlockError{
|
|
Provider: "sidecar",
|
|
Reason: fmt.Sprintf("invalid %s %q (want user, bot, or auto)", envvars.CliDefaultAs, id),
|
|
}
|
|
}
|
|
|
|
// Parse SupportedIdentities from STRICT_MODE, default to SupportsAll.
|
|
switch strictMode := os.Getenv(envvars.CliStrictMode); strictMode {
|
|
case "bot":
|
|
acct.SupportedIdentities = credential.SupportsBot
|
|
case "user":
|
|
acct.SupportedIdentities = credential.SupportsUser
|
|
case "off", "":
|
|
acct.SupportedIdentities = credential.SupportsAll
|
|
default:
|
|
return nil, &credential.BlockError{
|
|
Provider: "sidecar",
|
|
Reason: fmt.Sprintf("invalid %s %q (want bot, user, or off)", envvars.CliStrictMode, strictMode),
|
|
}
|
|
}
|
|
|
|
return acct, nil
|
|
}
|
|
|
|
// ResolveToken returns a sentinel token whose value encodes the token type.
|
|
// The transport interceptor reads this sentinel to determine the identity
|
|
// (user vs bot), strips it, and the sidecar injects the real token.
|
|
// Returns nil, nil when sidecar mode is not active.
|
|
func (p *Provider) ResolveToken(ctx context.Context, req credential.TokenSpec) (*credential.Token, error) {
|
|
if os.Getenv(envvars.CliAuthProxy) == "" {
|
|
return nil, nil
|
|
}
|
|
|
|
var sentinel string
|
|
switch req.Type {
|
|
case credential.TokenTypeUAT:
|
|
sentinel = sidecar.SentinelUAT
|
|
case credential.TokenTypeTAT:
|
|
sentinel = sidecar.SentinelTAT
|
|
default:
|
|
return nil, nil
|
|
}
|
|
|
|
return &credential.Token{
|
|
Value: sentinel,
|
|
Scopes: "", // empty → scope pre-check is skipped
|
|
Source: "sidecar",
|
|
}, nil
|
|
}
|
|
|
|
func init() {
|
|
credential.Register(&Provider{})
|
|
}
|