mirror of
https://github.com/larksuite/cli.git
synced 2026-07-07 17:45:15 +08:00
50b3f0a2af
* feat(platform): support multiple policy rules per plugin
Extend the command policy framework from single-Rule to multi-Rule
semantics. A plugin (or policy.yml) may now contribute several scoped
Rules; the engine combines them with OR -- a command is allowed when it
satisfies every axis of at least one rule. This lets one integration
apply different risk ceilings and identity restrictions to different
command groups.
The cross-plugin fail-closed boundary is preserved: two distinct plugins
both calling Restrict still aborts startup (multiple_restrict_plugins).
Single-Rule behaviour is fully backward compatible -- the rejection
reason_code / rule_name / envelope shape are byte-for-byte unchanged;
multi-rule rejection surfaces the aggregate reason_code no_matching_rule.
- engine: New keeps single-rule compat, add NewSet for OR over rules
- resolver: dedupe by owner (one plugin may contribute many rules),
return []*Rule; yaml gains a top-level rules: list
- registrar/builder/staging: Restrict may be called more than once;
retire the double_restrict error
- config policy show / config plugins show: emit a rules array
- inventory: PluginEntry.Rules is now a slice (fixes last-rule-wins
overwrite when a plugin contributes multiple rules)
* fix(platform): clone rules in Builder.Restrict and inventory snapshot
Address review feedback. Builder.Restrict stored the caller's *Rule
directly, so reusing and mutating one Rule object across multiple
Restrict calls collapsed entries to the last mutation; clone the rule and
its slices on append, mirroring the staging registrar.
BuildInventory likewise reused the source Allow/Deny/Identities slices;
copy them when building the RuleView snapshot instead of relying on
cloneInventory downstream.
Add a regression test: reusing and mutating one Rule across two Restrict
calls now yields two independent rules.
* fix(platform): skip yaml when a plugin owns policy; reject empty rules list
Two policy-config robustness fixes from review:
- A malformed ~/.lark-cli/policy.yml could abort a plugin-governed
binary. applyUserPolicyPruning read yaml before resolving, and
build.go fail-closes on any policy error when a plugin is present.
Plugin rules shadow yaml anyway, so skip reading yaml entirely when a
plugin contributed rules -- an unrelated broken file on the user's
machine can no longer lock the CLI.
- A present-but-empty "rules: []" collapsed to a single all-zero Rule
that allows every annotated command ("looks like policy, enforces
almost nothing"). yaml.Parse now distinguishes absent from
present-but-empty (Rules is a pointer) and rejects the empty list.
Add regression tests for both.
39 lines
1.6 KiB
Go
39 lines
1.6 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package platform
|
|
|
|
// Registrar is the imperative API a plugin uses inside its Install
|
|
// method to wire up hooks and rules. The framework provides a staging
|
|
// implementation that buffers calls and commits them atomically when
|
|
// Install returns nil; failure rolls everything back.
|
|
//
|
|
// hookName must match the grammar ^[a-z0-9][a-z0-9-]*$ (no dots). The
|
|
// framework prepends the plugin's Name() with a dot so the global hook
|
|
// identifier is "{plugin}.{hook}". A plugin cannot register two hooks
|
|
// with the same name in the same Install call.
|
|
//
|
|
// Restrict may be called multiple times per plugin; each call adds one
|
|
// scoped Rule (OR-combined by the engine). Two or more DISTINCT plugins
|
|
// contributing Restrict() is a configuration error (the resolver aborts
|
|
// startup).
|
|
type Registrar interface {
|
|
// Observe registers a side-effect-only command hook at the given
|
|
// When stage. The selector decides which commands it fires on.
|
|
Observe(when When, hookName string, sel Selector, fn Observer)
|
|
|
|
// Wrap registers a middleware-style command hook. The Wrap chain
|
|
// composes left-to-right in registration order; the outermost
|
|
// Wrapper runs first.
|
|
Wrap(hookName string, sel Selector, w Wrapper)
|
|
|
|
// On registers a lifecycle handler for the given event.
|
|
On(event LifecycleEvent, hookName string, fn LifecycleHandler)
|
|
|
|
// Restrict contributes a pruning Rule. May be called more than once
|
|
// to declare several scoped grants (OR-combined by the engine).
|
|
// Plugin rules take precedence over the yaml source; two distinct
|
|
// plugins both calling Restrict abort startup.
|
|
Restrict(r *Rule)
|
|
}
|