mirror of
https://github.com/larksuite/cli.git
synced 2026-07-06 00:06:28 +08:00
* feat(mail): add large attachment support via medias/upload API When attachments would cause the EML to exceed the 25MB limit, they are automatically uploaded to the mail attachment storage (medias/upload_all with parent_type="email") and a download-link card is injected into the HTML body, matching the desktop client's exportLargeFileArea style. Key changes: - Add classifyAttachments: EML-size-based splitting of normal vs oversized - Add uploadLargeAttachments: upload via medias API with email MountPoint - Add buildLargeAttachmentHTML: desktop-aligned card with CDN icons - Add processLargeAttachments: unified entry point for all compose shortcuts - Add LargeAttachmentHTML to emlbuilder.Builder for HTML block injection - Fix 7bit line folding: use RFC 5322 limit (998) instead of incorrect 76 - Integrate into +draft-create, +forward, +reply, +reply-all Known limitation: recipient access to large attachment links requires backend support to register tokens with the draft (see progress doc). Change-Id: If8d5938015cac8bc82de3ea3ff41022950f2571e Co-Authored-By: AI * refactor(mail): remove legacy size check, add 3GB limit, integrate +send - Remove checkAttachmentSizeLimit (replaced by processLargeAttachments) - Remove 25MB pre-check from validateComposeInlineAndAttachments so that large files reach Execute where they are uploaded as large attachments - Integrate processLargeAttachments into +send shortcut - Add 3GB single file limit aligned with desktop client - Clean up unused imports from helpers.go and helpers_test.go Change-Id: Ie590ad2b58263c075f48b338959b8f5b3f912f85 Co-Authored-By: AI * feat(mail): quote-aware HTML insertion, +draft-edit support, cleanup emlbuilder - Add insertBeforeQuoteOrAppend: insert large attachment HTML before the quote block (lark-mail-quote) instead of appending to body end, matching desktop's exportLargeFileArea placement logic - Add preprocessLargeAttachmentsForDraftEdit: intercept add_attachment patch ops before draft.Apply, upload oversized files, inject HTML into snapshot's HTML body Part directly. No changes to draft sub-package. - Remove LargeAttachmentHTML field/setter/logic from emlbuilder — it was business logic (quote-aware insertion) that doesn't belong in a generic EML builder. processLargeAttachments now sets the full HTML body via bld.HTMLBody() after merging the large attachment card at the right position. - All compose shortcuts pass htmlBody to processLargeAttachments for quote-aware insertion (composedHTMLBody for reply/forward, body for others). Change-Id: If6e7ed7e77989ab9a8a41a93758f686d72ccf497 Co-Authored-By: AI * fix(mail): align large attachment HTML IDs with desktop client - Container ID: lark-mail-large-file-container → large-file-area (matching desktop's MAIL_LARGE_FILE_CONTAINER constant) - Item ID: lark-mail-large-file-item → large-file-item (matching desktop's MAIL_LARGE_FILE_ITEM constant) - Timestamp: truncate to 9 digits (matching TIMESTAMP_CUT_OUT_ID = 9) - Refactor HTML generation to use template constants for readability These IDs are used by the desktop client's BigAttachmentPlugin ([id^=large-file-area]) and the server's LargeFileRule to identify and remove the HTML block when rendering the attachment card UI. Change-Id: Ib5a77a1a3d60eeb3a05c585f2af0a5ddaacf887b Co-Authored-By: AI * docs(mail): document large attachment behavior in skill references Update --attach parameter descriptions across all compose shortcuts (+send, +reply, +reply-all, +forward, +draft-create, +draft-edit) to describe automatic large attachment handling when EML exceeds 25 MB. Change-Id: I8c30e390c127ea1119cb8c4b83ec636e41fbaf66 Co-Authored-By: AI * fix(mail): pass signature-injected HTML to processLargeAttachments When both --signature-id and large attachments are used, the htmlBody passed to processLargeAttachments must include the already-injected signature. Previously mail_send and mail_draft_create passed the original body, causing processLargeAttachments to overwrite the signature-injected HTML body when inserting the large attachment card. Use composedHTMLBody variable (same pattern as reply/forward) to capture the full processed HTML including signature. Change-Id: I6be330776abca704b10cc3b8bfd5e20838e6e538 Co-Authored-By: AI * fix(mail): skip draft.Apply when all ops consumed by large attachment preprocessing When all patch ops are add_attachment targeting oversized files, preprocessLargeAttachmentsForDraftEdit uploads them and removes the ops from the patch. The resulting empty patch caused draft.Apply to fail with "patch ops is required". Now skip Apply when no ops remain. Change-Id: I8067a54b5f849fa519e8344a7eb10c48f58e54b8 Co-Authored-By: AI * fix(mail): add X-Lms-Large-Attachment-Ids header in draft-edit large attachment flow draft-edit's preprocessLargeAttachmentsForDraftEdit uploaded oversized files and injected HTML cards but never wrote the X-Lms-Large-Attachment-Ids header into the snapshot, so the mail server could not associate the attachments with the draft. Merge new token IDs with any existing ones already in the snapshot. Also extract the duplicated largeAttID struct and header name string into package-level declarations. Change-Id: Id256d948ec07e86296157436feefa3c2052af721 Co-Authored-By: AI * fix(mail): i18n large attachment HTML text aligned with desktop client Parameterize title and download text in large attachment HTML templates. Chinese lang uses "来自Lark邮箱的超大附件"/"下载", others use "Large file from Lark Mail"/"Download", matching desktop's i18n keys Mail_Attachment_AttachmentFromFeishuMail and Mail_Attachment_Download. Change-Id: I2aada8d52af41ae77dd7001d24d14e333f12066e Co-Authored-By: AI * fix(mail): insert large attachment card before quote wrapper, not inside nested quote insertBeforeQuoteOrAppend matched id="lark-mail-quote" which can appear deeply nested inside quoted content from previous replies in a thread. This caused the card to be placed inside the quote area instead of before it. Switch to matching the "history-quote-wrapper" class which is the outermost quote container generated by the CLI. Change-Id: I720b6d62d719613b411b7ed4b7820a1535bf14bd Co-Authored-By: AI * feat(mail): unify large attachment handling in +draft-edit with normal attachments Extend +draft-edit so that large attachments behave like normal attachments from the user's perspective: survive body edits, are listed in inspect output, and are removed via the same remove_attachment op. Code-wise: - remove_attachment target now accepts token (for large attachments) in addition to part_id / cid; priority part_id > cid > token. - setBody / setReplyBody auto-preserve the large attachment card in the HTML body, mirroring how normal attachments (MIME parts) survive body edits. Detection checks only the user-authored region of the value so cards inside an appended quote block (from the original quoted message) are not mistaken for user-supplied cards. - --inspect returns large_attachments_summary (token, filename, size) by parsing the X-Lms-Large-Attachment-Ids header and the HTML card DOM. - Well-known Lark HTML/header constants (LargeAttachmentIDsHeader, LargeFileContainerIDPrefix, LargeFileItemID, LargeAttachmentTokenAttr) moved to the draft package alongside QuoteWrapperClass; the mail package consumes them. - Shared helpers FindHTMLBodyPart and InsertBeforeQuoteOrAppend exported from the draft package; mail package switched to consume them, removing local duplicates. Skill reference (lark-mail-draft-edit.md) updated: three locator fields by attachment type, unified remove_attachment examples, set_body behavior. Change-Id: Ic064d1a8df0edf1cef6069cd44ec2a7534cd2182 Co-Authored-By: AI * fix(mail): place signature before large attachment card consistently When inserting a signature into a draft that already has a large attachment card, the signature was placed after the card, diverging from the compose-time layout where the order is [user][sig][card][quote]. Root cause: insertSignatureOp split only at the quote block, so the "user region" side inadvertently included the card. Centralize signature placement in draft.PlaceSignatureBeforeSystemTail, which splits at the earliest system-managed element (card or quote, whichever comes first). Both edit-time insertSignatureOp and compose-time injectSignatureIntoBody now share this single source of truth, removing the duplicated HTML splicing logic. Change-Id: I234bfebaaa31a32731ebbaa78c6596a72618b7c5 Co-Authored-By: AI * fix(mail): auto-preserve signature in set_body and set_reply_body Previously set_body / set_reply_body replaced the entire HTML body, silently dropping the signature block. The "replace whole body" semantic treated signature as user-authored content, which is inconsistent with how attachments (normal + large) and quote blocks survive body edits — signature is a system-managed element managed via insert_signature / remove_signature ops. Unify the mental model: body-edit ops replace user-authored content only; signature, large attachment card, normal attachments, and (for set_reply_body) quote block are all auto-preserved. Users can override by including equivalents in value, or explicitly delete via dedicated ops (remove_signature, remove_attachment). - Add ExtractSignatureBlock helper (symmetric to RemoveSignatureHTML). - Rename autoPreserveLargeAttachmentCard to autoPreserveSystemManagedRegions; extract and inject both sig and card from old body, respecting user-supplied equivalents in value's user-authored region. - Update skill doc and patch template notes to reflect the new semantics consistently. Change-Id: I96660d2ff06a6c9cdf1b86793c2d89cf9cb09ffe Co-Authored-By: AI * fix(mail): use brand-aware display name in large attachment card title The title "Large file from Lark Mail" / "来自Lark邮箱的超大附件" hard-coded "Lark" regardless of brand. The desktop client switches between "Feishu"/"飞书" and "Lark" based on the APP_DISPLAY_NAME i18n substitution. Add brandDisplayName(brand, lang) helper: - BrandLark → "Lark" - BrandFeishu → "飞书" (zh) / "Feishu" (en) Applied to title in buildLargeAttachmentHTML, aligning with the icon CDN and download URL, which already branch on brand. Change-Id: I06258b9982b6280a2230193d90a6a88884e10aa3 Co-Authored-By: AI * style(mail): apply gofmt CI fast-gate check flagged gofmt-unformatted files. Run gofmt -w on touched mail files only. Change-Id: Iec690dc63adfaa54b8f7c85ab5b3ca035476ddbd * fix(mail): address review feedback on large attachment PR - Strip <html><head><body> wrapper from xhtml.Render output in removeLargeFileItemFromHTML to avoid polluting the HTML body - Reject plain-text messages with oversized attachments instead of silently losing the body content - Fix attachment count limit in skill doc (100 → 250) - Remove unused fio/attachFlag params from validateComposeInlineAndAttachments - Add token escaping test for large attachment HTML builder Change-Id: Ie589a1f1d204b0aeebc4486b16bb435041793ceb Co-Authored-By: AI * fix(mail): recognize server-format X-Lark-Large-Attachment header in draft-edit When a draft with large attachments is created by the desktop client, the server returns X-Lark-Large-Attachment (with file_key/file_name/ file_size fields) instead of the CLI-written X-Lms-Large-Attachment-Ids. Previously CLI only recognized its own header, causing existing large attachments to be silently dropped when the draft was edited. - Parse both header formats via IsLargeAttachmentHeader and unified largeAttHeaderEntry struct - Convert server-format entries to CLI-format on save so the server can process the update - Fix inline attachment classification: require non-empty CID to classify as inline image (large attachments may have is_inline=true but no CID) Change-Id: Ie7def4fc5923d2cf3446eedfbca4fd8cae44bfac Co-Authored-By: AI * fix(mail): skip large attachments in forward URL validation Large attachments do not have download URLs since they are referenced by token, not embedded in the EML. Validate only normal attachments to avoid false "missing download URL" errors when forwarding messages that contain expired or token-based large attachments. Change-Id: Ibe3f45390cd3b3cbe6ddd15961dcda4f17aefe4f Co-Authored-By: AI * fix(mail): classify forwarded original attachments for large attachment upload Previously, all original attachments were unconditionally embedded in the EML before user attachments were processed for large attachment upload. When original + user attachments together exceeded the 25 MB EML limit, the build would fail. Now all attachments (original + user-added) are classified together via classifyAttachments. Original attachments that push the EML over the limit are re-uploaded as large attachments with download cards, matching the compose/reply flow behavior. Also refactors uploadLargeAttachmentBytes to reuse the shared common.UploadDriveMediaAll utility (via new Reader field on the config struct) instead of duplicating the upload logic, and replaces bare fmt.Errorf with output.ErrValidation for user input errors. Change-Id: I98d4ad8960cd68e38765b05c94f7786d6a8444c8 Co-Authored-By: AI * fix(mail): normalize large attachment header on draft edit to prevent loss Server returns X-Lark-Large-Attachment header on draft readback, but only recognizes X-Lms-Large-Attachment-Ids on write. Without normalization, editing a draft with existing large attachments (e.g. adding a small attachment) would send back the server-format header unchanged, causing the server to drop the large attachment association. Add normalizeLargeAttachmentHeader() at the entry of preprocessLargeAttachmentsForDraftEdit to convert server-format headers to CLI format before any processing or early return. Change-Id: Id99a46f29015a32921bfb72a003f766c397787e1 Co-Authored-By: AI * fix(mail): extract large attachment card from quote on forward When forwarding a message that contains large attachments, the original message's download card (large-file-area div) was left inside the forward quote block. Extract it and place it in the main body area (after signature, before quote), matching the desktop client behavior. Change-Id: Iebede35cdf4ed0f65b72bce28ffb18af21ddf668 Co-Authored-By: AI * fix(mail): use octet-stream for re-embedded attachments and file-based large upload on forward - Use application/octet-stream instead of original content type when re-embedding downloaded attachments in forward EML. Prevents the mail server from treating image/* attachments as inline parts. - Replace in-memory uploadLargeAttachmentBytes with temp-file-based uploadLargeAttachments for oversized original attachments. This enables multipart upload for files >20MB which the single-part API does not support. Change-Id: Ib02add5710e8b052e47b513ed3d9a688e0f98212 Co-Authored-By: AI * fix(mail): address PR review — blocked extension bypass, index-based op filtering, plain-text draft guard 1. Move CheckBlockedExtension into statAttachmentFiles so oversized attachments are validated before classification, covering compose, draft-edit, and forward paths. 2. Replace path-based oversized op filtering with SourceIndex-based filtering in preprocessLargeAttachmentsForDraftEdit to avoid incorrectly removing duplicate-path normal ops. 3. Add HTML body preflight in preprocessLargeAttachmentsForDraftEdit before uploading, so plain-text-only drafts fail early instead of silently producing a draft with tokens but no download card. Change-Id: Ib8771812f50a18f00a40e50149b028b8aaa101fe Co-Authored-By: AI * fix(mail): preserve original content type for normal forwarded attachments The octet-stream override was only needed for the large attachment upload path (to prevent image/* from being treated as inline by the drive API). Normal attachments embedded in the EML should retain their original MIME type so recipients can preview/open them correctly. Change-Id: Ie40b7c362524a3b82255b58e9bcfd770eacfe911 Co-Authored-By: AI * fix(mail): reconstruct missing large attachment HTML cards on draft edit The server strips HTML download cards from the EML body when storing drafts, so every draft read-back (regardless of creator) lacks them. Add ensureLargeAttachmentCards which runs before header normalization, compares server-format header tokens against existing HTML cards via data-mail-token, and rebuilds only the missing ones. This ensures external recipients see download links after draft-edit → send. Also exports ParseLargeAttachmentSummariesFromHeader and ParseLargeAttachmentItemsFromHTML from the draft package for cross-package use. Change-Id: I9cb0f47a9f4582909de24984d9a9f6e366521e62 Co-Authored-By: AI * feat(mail): support large attachments in plain-text emails Previously large attachments required an HTML body for the download card. Now plain-text emails (--plain-text or text/plain-only drafts) get download info appended as structured text (title + filename + size + URL), with i18n and brand awareness matching the HTML card. Changes: - Add buildLargeAttachmentPlainText and injectLargeAttachmentTextIntoSnapshot - Add FindTextBodyPart in draft/projection.go - Update processLargeAttachments to accept textBody parameter - Update ensureLargeAttachmentCards to handle text/plain body reconstruction - Update preprocessLargeAttachmentsForDraftEdit to allow text/plain drafts - Update all callers (send, draft-create, reply, reply-all, forward) Change-Id: I3b375e2ff34697eeb73a3768ace6d577d1bead3e Co-Authored-By: AI * fix(mail): FindBodyPart skips attachment-disposition parts; update skill docs FindHTMLBodyPart and FindTextBodyPart now skip parts with Content-Disposition: attachment, preventing .txt/.html file attachments from being mistakenly treated as the email body. Also update all lark-mail skill reference docs to reflect that large attachments now work in both HTML (download card) and plain-text (download link text) modes. Change-Id: I1e6da4fd614217dff61304212304b5fd80c8246c Co-Authored-By: AI * fix(mail): fix origIdx mismatch, predictable temp files, and attachment count on forward - Use SourceIndex instead of linear origIdx counter so classifyAttachments reordering does not cause content mismatch between normal/oversized loops - Use os.CreateTemp for temp files instead of predictable names in CWD - Include original large attachment count in totalCount limit check Change-Id: Ide5dce14b1efc672687800d77c3853f15dfc191b Co-Authored-By: AI * fix(mail): use composed body size and source inline bytes in EML size estimation estimateEMLBaseSize was using len(body) (raw --body flag) instead of the actual composed body (which includes quotes, signatures, forward headers). Source inline images downloaded from the original message were also not counted. This could cause borderline attachments to be misclassified. - Use len(composedHTMLBody) + len(composedTextBody) for body size - Return total downloaded bytes from addInlineImagesToBuilder and pass as extraBytes to estimateEMLBaseSize - Fix applied to all compose shortcuts: send, draft-create, reply, reply-all, forward Change-Id: Ibe6c44e22d40ac51f0a4652d279e66bd92330723 Co-Authored-By: AI * fix(mail): merge large attachment items into single container on draft edit When draft-edit had both set_body and add_attachment (oversized), the ensureLargeAttachmentCards and preprocessLargeAttachmentsForDraftEdit each created independent large-file-area containers. The subsequent set_body's autoPreserveSystemManagedRegions only captured the first container via SplitAtLargeAttachment, discarding the second one. Fix: injectLargeAttachmentHTMLIntoSnapshot now detects an existing large-file-area container and appends new items inside it instead of creating a new container, matching the desktop client's single-container behavior. Change-Id: I3d701683053842f1d7bdad34fc4b2ef26ede784e Co-Authored-By: AI * fix(mail): strip large attachment card from reply/reply-all quote Reply and reply-all should not carry over the original email's large attachment HTML card into the quoted block. Extract the shared stripLargeAttachmentCard helper (also used by forward) that removes the card from orig.bodyRaw before quote construction. - Reply/reply-all: card is discarded (not re-inserted) - Forward: card is moved to body area before the quote (unchanged) Change-Id: I5399bb901c120206c7c045bed107f7d68be23bb1 Co-Authored-By: AI * fix(mail): skip invalid attachments on forward instead of blocking When forwarding a message with deleted/expired attachments, the forward flow now automatically removes them instead of either blocking (normal attachments) or silently including dead references (large attachments). - Propagate failed_ids from fetchAttachmentURLs into composeSourceMessage - Skip failed attachments in the forward download loop with a warning - Remove corresponding large attachment HTML card items from the body - Extend itemContainsToken to match server-generated href?token= format Change-Id: I9c0096dcbe96f1d61caa0f6f0b2f8b738fdfa66b Co-Authored-By: AI * fix(mail): restore dry-run file preflight and reserve card overhead in classifier 1. Restore file existence and blocked-extension checks in validateComposeInlineAndAttachments so --dry-run surfaces local path errors before Execute. 2. Reserve 3KB per oversized file in classifyAttachments to account for the HTML card / plain-text block injected after classification. Change-Id: Ib48a75f86a50298413c1f9ab8226e583c0161a8c Co-Authored-By: AI * fix(mail): revert classifier overhead reserve for simplicity The 3KB-per-oversized-file reserve in classifyAttachments addressed a boundary case that is practically impossible to trigger (requires Normal attachments to fill to within a few KB of 25MB). Remove it to keep the classifier simple. Change-Id: I5148f14ecca1a0dee677a1a2c60ec4efab160ea8 Co-Authored-By: AI * style(mail): fix gofmt indentation in draft create tests Change-Id: Ib41aa22f94144f2d47b12675d444aa43cb333a88 Co-Authored-By: AI * fix(mail): remove temp files in forward, use in-memory upload instead Replace os.CreateTemp/os.WriteFile/os.Remove with in-memory Data field on attachmentFile, conforming to the project's forbidigo rule against temp files in shortcuts. Also remove dead uploadLargeAttachmentBytes. Change-Id: Ic26e4025eebfa1bac3948438ef185ff3e2f15abb Co-Authored-By: AI * test(mail): add tests for validateComposeInlineAndAttachments and fileTypeIcon Covers all branches: inline+plain-text conflict, inline+non-HTML body, missing file, blocked extension, valid pass-through, and all file type icon mappings. Change-Id: I8b81c1b34010a9ecb7153462a5524e3d7b171de2 Co-Authored-By: AI * test(mail): improve coverage for large attachment and draft edit functions Add tests for snapshotEMLBaseSize, flattenSnapshotParts, estimateEMLBaseSize, normalizeLargeAttachmentHeader, processLargeAttachments error paths, preprocessLargeAttachmentsForDraftEdit early-return paths, inject edge cases, buildLargeAttachmentItems, statAttachmentFiles edge cases, and prettyDraftAddresses. Change-Id: Ie661e6ebea63512864d97e20135dd89cb9e9304e Co-Authored-By: AI
315 lines
9.3 KiB
Go
315 lines
9.3 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package draft
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestParseLargeAttachmentTokens(t *testing.T) {
|
|
encode := func(ids ...string) string {
|
|
type item struct {
|
|
ID string `json:"id"`
|
|
}
|
|
items := make([]item, len(ids))
|
|
for i, id := range ids {
|
|
items[i] = item{ID: id}
|
|
}
|
|
b, _ := json.Marshal(items)
|
|
return base64.StdEncoding.EncodeToString(b)
|
|
}
|
|
|
|
cases := []struct {
|
|
name string
|
|
headers []Header
|
|
want []string
|
|
}{
|
|
{
|
|
name: "empty headers",
|
|
headers: nil,
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "header present with one token",
|
|
headers: []Header{{Name: LargeAttachmentIDsHeader, Value: encode("tokA")}},
|
|
want: []string{"tokA"},
|
|
},
|
|
{
|
|
name: "header present with multiple tokens in order",
|
|
headers: []Header{{Name: LargeAttachmentIDsHeader, Value: encode("tokA", "tokB", "tokC")}},
|
|
want: []string{"tokA", "tokB", "tokC"},
|
|
},
|
|
{
|
|
name: "case-insensitive header name match",
|
|
headers: []Header{{Name: "x-lms-large-attachment-ids", Value: encode("tokA")}},
|
|
want: []string{"tokA"},
|
|
},
|
|
{
|
|
name: "malformed base64 → nil",
|
|
headers: []Header{{Name: LargeAttachmentIDsHeader, Value: "not!!base64"}},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "malformed JSON → nil",
|
|
headers: []Header{{Name: LargeAttachmentIDsHeader, Value: base64.StdEncoding.EncodeToString([]byte("not json"))}},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "empty string IDs filtered out",
|
|
headers: []Header{{Name: LargeAttachmentIDsHeader, Value: encode("tokA", "", "tokB")}},
|
|
want: []string{"tokA", "tokB"},
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
got := parseLargeAttachmentTokens(tc.headers)
|
|
if !equalStrings(got, tc.want) {
|
|
t.Errorf("got %v, want %v", got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func equalStrings(a, b []string) bool {
|
|
if len(a) != len(b) {
|
|
return false
|
|
}
|
|
for i := range a {
|
|
if a[i] != b[i] {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
func TestParseSizeDisplay(t *testing.T) {
|
|
cases := []struct {
|
|
in string
|
|
want int64
|
|
}{
|
|
{"25.0 MB", 26214400},
|
|
{"1 GB", 1024 * 1024 * 1024},
|
|
{"500 KB", 500 * 1024},
|
|
{"42 B", 42},
|
|
{" 25.0 MB ", 26214400}, // whitespace tolerated
|
|
{"25.0 mb", 26214400}, // case-insensitive
|
|
{"garbage", 0},
|
|
{"", 0},
|
|
{"25", 0}, // no unit
|
|
{"25 XB", 0}, // invalid unit
|
|
}
|
|
for _, tc := range cases {
|
|
if got := parseSizeDisplay(tc.in); got != tc.want {
|
|
t.Errorf("parseSizeDisplay(%q) = %d, want %d", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseLargeAttachmentItemsFromHTML(t *testing.T) {
|
|
// Minimal HTML mirroring the structure generated by mail/large_attachment.go
|
|
item := func(token, filename, size string) string {
|
|
return `<div id="large-file-item">` +
|
|
`<div><img src="x.png"/></div>` +
|
|
`<div>` +
|
|
`<div>` + filename + `</div>` +
|
|
`<div><span>` + size + `</span></div>` +
|
|
`</div>` +
|
|
`<a href="x" data-mail-token="` + token + `">Download</a>` +
|
|
`</div>`
|
|
}
|
|
|
|
html := `<div id="large-file-area-123">` +
|
|
`<div>Title</div>` +
|
|
item("tokA", "a.pdf", "25.0 MB") +
|
|
item("tokB", "b.mov", "300 MB") +
|
|
`</div>`
|
|
|
|
got := ParseLargeAttachmentItemsFromHTML(html)
|
|
if len(got) != 2 {
|
|
t.Fatalf("expected 2 items, got %d: %+v", len(got), got)
|
|
}
|
|
if got["tokA"].FileName != "a.pdf" {
|
|
t.Errorf("tokA filename: got %q, want %q", got["tokA"].FileName, "a.pdf")
|
|
}
|
|
if got["tokA"].SizeBytes != 26214400 {
|
|
t.Errorf("tokA size: got %d, want 26214400", got["tokA"].SizeBytes)
|
|
}
|
|
if got["tokB"].FileName != "b.mov" {
|
|
t.Errorf("tokB filename: got %q, want %q", got["tokB"].FileName, "b.mov")
|
|
}
|
|
if got["tokB"].SizeBytes != 300*1024*1024 {
|
|
t.Errorf("tokB size: got %d, want %d", got["tokB"].SizeBytes, 300*1024*1024)
|
|
}
|
|
}
|
|
|
|
func TestProjectLargeAttachments_MergesHeaderAndHTML(t *testing.T) {
|
|
type idItem struct {
|
|
ID string `json:"id"`
|
|
}
|
|
idsJSON, _ := json.Marshal([]idItem{{ID: "tokA"}, {ID: "tokB"}})
|
|
headers := []Header{{Name: LargeAttachmentIDsHeader, Value: base64.StdEncoding.EncodeToString(idsJSON)}}
|
|
|
|
html := `<div id="large-file-area-1">` +
|
|
`<div>Title</div>` +
|
|
`<div id="large-file-item"><div>a.pdf</div><div><span>25.0 MB</span></div><a data-mail-token="tokA">D</a></div>` +
|
|
`<div id="large-file-item"><div>b.mov</div><div><span>300 MB</span></div><a data-mail-token="tokB">D</a></div>` +
|
|
`</div>`
|
|
|
|
got := projectLargeAttachments(headers, html)
|
|
if len(got) != 2 {
|
|
t.Fatalf("expected 2, got %d: %+v", len(got), got)
|
|
}
|
|
if got[0].Token != "tokA" || got[0].FileName != "a.pdf" || got[0].SizeBytes != 26214400 {
|
|
t.Errorf("index 0: %+v", got[0])
|
|
}
|
|
if got[1].Token != "tokB" || got[1].FileName != "b.mov" {
|
|
t.Errorf("index 1: %+v", got[1])
|
|
}
|
|
}
|
|
|
|
func TestProjectLargeAttachments_HeaderWithoutHTML(t *testing.T) {
|
|
// Token present in header but HTML missing the card entry (malformed draft).
|
|
// We still report the token with empty meta.
|
|
type idItem struct {
|
|
ID string `json:"id"`
|
|
}
|
|
idsJSON, _ := json.Marshal([]idItem{{ID: "orphanToken"}})
|
|
headers := []Header{{Name: LargeAttachmentIDsHeader, Value: base64.StdEncoding.EncodeToString(idsJSON)}}
|
|
|
|
got := projectLargeAttachments(headers, "")
|
|
if len(got) != 1 {
|
|
t.Fatalf("expected 1, got %d", len(got))
|
|
}
|
|
if got[0].Token != "orphanToken" {
|
|
t.Errorf("got token %q", got[0].Token)
|
|
}
|
|
if got[0].FileName != "" || got[0].SizeBytes != 0 {
|
|
t.Errorf("expected empty meta, got %+v", got[0])
|
|
}
|
|
}
|
|
|
|
func TestProjectLargeAttachments_NoHeader(t *testing.T) {
|
|
got := projectLargeAttachments(nil, `<div id="large-file-area-1">...</div>`)
|
|
if got != nil {
|
|
t.Errorf("expected nil, got %v", got)
|
|
}
|
|
}
|
|
|
|
func TestRemoveLargeAttachment_RemovesOneOfTwo(t *testing.T) {
|
|
type idItem struct {
|
|
ID string `json:"id"`
|
|
}
|
|
idsJSON, _ := json.Marshal([]idItem{{ID: "tokA"}, {ID: "tokB"}})
|
|
headerValue := base64.StdEncoding.EncodeToString(idsJSON)
|
|
html := `<html><body><p>hi</p><div id="large-file-area-1">` +
|
|
`<div>Title</div>` +
|
|
`<div id="large-file-item"><div>a.pdf</div><div><span>25.0 MB</span></div><a data-mail-token="tokA">D</a></div>` +
|
|
`<div id="large-file-item"><div>b.mov</div><div><span>300 MB</span></div><a data-mail-token="tokB">D</a></div>` +
|
|
`</div></body></html>`
|
|
|
|
snapshot := &DraftSnapshot{
|
|
Headers: []Header{{Name: LargeAttachmentIDsHeader, Value: headerValue}},
|
|
Body: &Part{
|
|
MediaType: "text/html",
|
|
Body: []byte(html),
|
|
},
|
|
}
|
|
|
|
if err := removeLargeAttachment(snapshot, "tokA"); err != nil {
|
|
t.Fatalf("removeLargeAttachment: %v", err)
|
|
}
|
|
|
|
// Header should contain only tokB
|
|
tokens := parseLargeAttachmentTokens(snapshot.Headers)
|
|
if !equalStrings(tokens, []string{"tokB"}) {
|
|
t.Errorf("tokens after removal: got %v, want [tokB]", tokens)
|
|
}
|
|
|
|
// HTML should not contain data-mail-token="tokA" anymore, but still contain tokB and the container
|
|
newHTML := string(snapshot.Body.Body)
|
|
if strings.Contains(newHTML, `data-mail-token="tokA"`) {
|
|
t.Errorf("HTML still contains tokA item:\n%s", newHTML)
|
|
}
|
|
if !strings.Contains(newHTML, `data-mail-token="tokB"`) {
|
|
t.Errorf("HTML missing tokB item:\n%s", newHTML)
|
|
}
|
|
if !strings.Contains(newHTML, `id="large-file-area-1"`) {
|
|
t.Errorf("HTML missing container (should still exist with tokB):\n%s", newHTML)
|
|
}
|
|
}
|
|
|
|
func TestRemoveLargeAttachment_RemovesLastOneClearsContainer(t *testing.T) {
|
|
type idItem struct {
|
|
ID string `json:"id"`
|
|
}
|
|
idsJSON, _ := json.Marshal([]idItem{{ID: "tokOnly"}})
|
|
headerValue := base64.StdEncoding.EncodeToString(idsJSON)
|
|
html := `<html><body><p>hi</p><div id="large-file-area-1">` +
|
|
`<div>Title</div>` +
|
|
`<div id="large-file-item"><div>a.pdf</div><div><span>25.0 MB</span></div><a data-mail-token="tokOnly">D</a></div>` +
|
|
`</div></body></html>`
|
|
|
|
snapshot := &DraftSnapshot{
|
|
Headers: []Header{{Name: LargeAttachmentIDsHeader, Value: headerValue}},
|
|
Body: &Part{
|
|
MediaType: "text/html",
|
|
Body: []byte(html),
|
|
},
|
|
}
|
|
|
|
if err := removeLargeAttachment(snapshot, "tokOnly"); err != nil {
|
|
t.Fatalf("removeLargeAttachment: %v", err)
|
|
}
|
|
|
|
// Header should be entirely removed (empty list)
|
|
for _, h := range snapshot.Headers {
|
|
if strings.EqualFold(h.Name, LargeAttachmentIDsHeader) {
|
|
t.Errorf("header should have been removed when list is empty")
|
|
}
|
|
}
|
|
|
|
// HTML should not contain the container at all
|
|
newHTML := string(snapshot.Body.Body)
|
|
if strings.Contains(newHTML, "large-file-area-1") {
|
|
t.Errorf("container should have been removed:\n%s", newHTML)
|
|
}
|
|
if strings.Contains(newHTML, "large-file-item") {
|
|
t.Errorf("no items should remain:\n%s", newHTML)
|
|
}
|
|
// Other body content should survive
|
|
if !strings.Contains(newHTML, "<p>hi</p>") {
|
|
t.Errorf("user body should remain:\n%s", newHTML)
|
|
}
|
|
}
|
|
|
|
func TestRemoveLargeAttachment_UnknownToken(t *testing.T) {
|
|
type idItem struct {
|
|
ID string `json:"id"`
|
|
}
|
|
idsJSON, _ := json.Marshal([]idItem{{ID: "tokA"}})
|
|
headerValue := base64.StdEncoding.EncodeToString(idsJSON)
|
|
snapshot := &DraftSnapshot{
|
|
Headers: []Header{{Name: LargeAttachmentIDsHeader, Value: headerValue}},
|
|
Body: &Part{MediaType: "text/html", Body: []byte(`<p>hi</p>`)},
|
|
}
|
|
err := removeLargeAttachment(snapshot, "unknown")
|
|
if err == nil {
|
|
t.Errorf("expected error for unknown token")
|
|
}
|
|
}
|
|
|
|
func TestRemoveLargeAttachment_MissingHeader(t *testing.T) {
|
|
snapshot := &DraftSnapshot{
|
|
Headers: []Header{},
|
|
Body: &Part{MediaType: "text/html", Body: []byte(`<p>hi</p>`)},
|
|
}
|
|
err := removeLargeAttachment(snapshot, "any")
|
|
if err == nil {
|
|
t.Errorf("expected error when header is missing")
|
|
}
|
|
}
|