mirror of
https://github.com/larksuite/cli.git
synced 2026-07-03 14:02:43 +08:00
8c3cba17b2
Task commands now return structured, typed errors instead of the legacy exit-code envelope: every failure carries a stable category, subtype, and recovery hint, so callers can branch on the error class instead of parsing messages. Exit codes derive from the error category — input validation exits 2, a permission denial exits 3, other API errors exit 1. Batch operations (adding tasks to a tasklist, creating a tasklist with tasks) now report partial failure honestly: the per-item successes and failures stay on stdout and the command exits non-zero instead of masking failures as a success.
64 lines
2.2 KiB
Go
64 lines
2.2 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package task
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/larksuite/cli/errs"
|
|
"github.com/larksuite/cli/internal/output"
|
|
"github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
// TestFollowersTask_RequiresAddOrRemove covers the Validate guard: neither
|
|
// --add nor --remove yields a typed validation error (exit 2) before any API
|
|
// call.
|
|
func TestFollowersTask_RequiresAddOrRemove(t *testing.T) {
|
|
f, stdout, _, _ := taskShortcutTestFactory(t)
|
|
|
|
s := FollowersTask
|
|
args := []string{"+followers", "--task-id", "task-1", "--as", "bot", "--format", "json"}
|
|
err := runMountedTaskShortcut(t, s, args, f, stdout)
|
|
|
|
var ve *errs.ValidationError
|
|
if !errors.As(err, &ve) {
|
|
t.Fatalf("err = %T, want *errs.ValidationError; err = %v", err, err)
|
|
}
|
|
if ve.Subtype != errs.SubtypeInvalidArgument {
|
|
t.Errorf("subtype = %q, want %q", ve.Subtype, errs.SubtypeInvalidArgument)
|
|
}
|
|
if got := output.ExitCodeOf(err); got != output.ExitValidation {
|
|
t.Errorf("exit code = %d, want %d", got, output.ExitValidation)
|
|
}
|
|
}
|
|
|
|
func TestBuildFollowersBody(t *testing.T) {
|
|
convey.Convey("Build with ids and token", t, func() {
|
|
body := buildFollowersBody("u1, u2 , ", "token1")
|
|
members := body["members"].([]map[string]interface{})
|
|
convey.So(len(members), convey.ShouldEqual, 2)
|
|
convey.So(body["client_token"], convey.ShouldEqual, "token1")
|
|
convey.So(members[0]["role"], convey.ShouldEqual, "follower")
|
|
convey.So(members[0]["type"], convey.ShouldEqual, "user")
|
|
})
|
|
|
|
convey.Convey("Build infers app followers", t, func() {
|
|
body := buildFollowersBody("cli_bot_1", "")
|
|
members := body["members"].([]map[string]interface{})
|
|
convey.So(len(members), convey.ShouldEqual, 1)
|
|
convey.So(members[0]["id"], convey.ShouldEqual, "cli_bot_1")
|
|
convey.So(members[0]["role"], convey.ShouldEqual, "follower")
|
|
convey.So(members[0]["type"], convey.ShouldEqual, "app")
|
|
})
|
|
|
|
convey.Convey("Build infers mixed follower types in one list", t, func() {
|
|
body := buildFollowersBody("ou_user_1, cli_bot_1", "")
|
|
members := body["members"].([]map[string]interface{})
|
|
convey.So(len(members), convey.ShouldEqual, 2)
|
|
convey.So(members[0]["type"], convey.ShouldEqual, "user")
|
|
convey.So(members[1]["type"], convey.ShouldEqual, "app")
|
|
})
|
|
}
|