larksuite-cli

mirror of https://github.com/larksuite/cli.git synced 2026-07-10 11:04:26 +08:00

Files

shanglei f34d05164c fix(pruning): deny stub must override Args + PersistentPreRunE

The pruning denyStub and the strict-mode stub previously only swapped
RunE plus Hidden + DisableFlagParsing. Cobra's dispatch order means
several pre-RunE gates can fire BEFORE the stub's RunE ever runs:

  1. Args validator: shortcut commands often declare cobra.NoArgs.
     With DisableFlagParsing=true the user's `--doc xxx --mode append`
     looks like positional args, so ValidateArgs surfaces a usage
     error instead of the pruning / strict_mode envelope. Observer
     hooks also miss the dispatch entirely.

  2. Parent PersistentPreRunE: cmd/auth/auth.go declares a
     PersistentPreRunE that returns external_provider when env
     credentials are set. Cobra's "first PersistentPreRunE wins
     walking up from the leaf" then short-circuits with
     external_provider instead of the leaf's denial envelope.

Both stubs now also set:

  - Args               = cobra.ArbitraryArgs   (bypass gate 1)
  - PersistentPreRunE  = no-op leaf hook       (bypass gate 2)
  - PreRunE / PreRun / PersistentPreRun = nil  (defensive)

Effect: dispatch reaches the wrapped RunE, observers fire, the real
pruning / strict_mode envelope is emitted regardless of credential
provider or flag count.

Adds regression tests covering both gates on both stub paths.

2026-05-13 14:30:59 +08:00

yaml

feat(extension): introduce Plugin / Hook framework with command pruning

2026-05-13 11:27:22 +08:00

active.go

feat(extension): introduce Plugin / Hook framework with command pruning

2026-05-13 11:27:22 +08:00

aggregation_test.go

feat(extension): introduce Plugin / Hook framework with command pruning

2026-05-13 11:27:22 +08:00

apply.go

fix(pruning): deny stub must override Args + PersistentPreRunE