Files
larksuite-cli/tests/cli_e2e/core.go
liangshuo-1 619ec8c2cb fix(api): support stdin and quoted JSON inputs on Windows (#367)
* fix(api): add stdin and single-quote support for --params/--data on Windows (#64)

Windows PowerShell 5.x mangles JSON double-quotes when passing arguments
to native executables, causing --params and --data to fail with
"invalid JSON format". This commit adds two mitigations at the framework
level:

- stdin piping: `echo '{"k":"v"}' | lark-cli --params -` bypasses
  shell argument parsing entirely and works on all platforms/shells.
- single-quote stripping: cmd.exe passes literal single quotes which
  are now transparently removed before JSON parsing.

Implementation:
- New `cmdutil.ResolveInput(raw, stdin)` handles `-` (stdin), strip
  surrounding `'...'`, and plain passthrough.
- `ParseJSONMap` and `ParseOptionalBody` now accept an `io.Reader` and
  delegate to `ResolveInput` before JSON unmarshalling.
- `cmd/api` and `cmd/service` pass `IOStreams.In` and guard against
  simultaneous stdin usage by --params and --data.
- Empty stdin is rejected with a clear error message.

Closes #64

Change-Id: If21e735d0aed5c6a2d6674c1e6c898186fca3aba

* test: add stdin e2e regression coverage

Change-Id: I4e00bf1c6b6f3259f503e3414cae10fa4b34ba75
2026-04-09 19:10:50 +08:00

264 lines
7.2 KiB
Go

// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
// Package clie2e contains end-to-end tests for lark-cli.
package clie2e
import (
"bytes"
"context"
"encoding/json"
"errors"
"fmt"
"os"
"os/exec"
"path/filepath"
"strings"
"sync"
"testing"
"github.com/stretchr/testify/assert"
"github.com/tidwall/gjson"
)
const EnvBinaryPath = "LARK_CLI_BIN"
const projectRootMarkerDir = "tests"
const cliBinaryName = "lark-cli"
const defaultIdentity = "bot"
var defaultAsInitOnce sync.Once
// Request describes one lark-cli invocation.
type Request struct {
// Args are required and exclude the lark-cli binary name.
Args []string
// Params is optional and becomes --params '<json>' when non-nil.
Params any
// Data is optional and becomes --data '<json>' when non-nil.
Data any
// Stdin is optional and becomes the child process stdin when non-nil.
// Use an empty slice to exercise empty-stdin behavior explicitly.
Stdin []byte
// BinaryPath is optional. Empty means: LARK_CLI_BIN, project-root ./lark-cli, then PATH.
BinaryPath string
// DefaultAs is optional and becomes --as <value> when non-empty.
DefaultAs string
// Format is optional and becomes --format <format> when non-empty.
Format string
}
// Result captures process execution output.
type Result struct {
BinaryPath string
Args []string
ExitCode int
Stdout string
Stderr string
RunErr error
}
// RunCmd executes lark-cli and captures stdout/stderr/exit code.
func RunCmd(ctx context.Context, req Request) (*Result, error) {
binaryPath, err := ResolveBinaryPath(req)
if err != nil {
return nil, err
}
// Best-effort initialization only. Failing to set default-as should not hide
// the actual command-under-test result, because some environments may still
// run the target CLI flow successfully without this convenience setup.
defaultAsInitOnce.Do(func() {
_ = setDefaultAs(ctx, binaryPath, defaultIdentity)
})
args, err := BuildArgs(req)
if err != nil {
return nil, err
}
cmd := exec.CommandContext(ctx, binaryPath, args...)
var stdout bytes.Buffer
var stderr bytes.Buffer
if req.Stdin != nil {
cmd.Stdin = bytes.NewReader(req.Stdin)
}
cmd.Stdout = &stdout
cmd.Stderr = &stderr
runErr := cmd.Run()
result := &Result{
BinaryPath: binaryPath,
Args: args,
ExitCode: exitCode(runErr),
Stdout: stdout.String(),
Stderr: stderr.String(),
RunErr: runErr,
}
return result, nil
}
// ResolveBinaryPath finds the CLI binary path using request, env, then PATH.
func ResolveBinaryPath(req Request) (string, error) {
if req.BinaryPath != "" {
return normalizeBinaryPath(req.BinaryPath)
}
if envPath := strings.TrimSpace(os.Getenv(EnvBinaryPath)); envPath != "" {
return normalizeBinaryPath(envPath)
}
if rootDir, err := findProjectRootDir(); err == nil {
projectBinary := filepath.Join(rootDir, cliBinaryName)
if _, statErr := os.Stat(projectBinary); statErr == nil {
return normalizeBinaryPath(projectBinary)
}
}
path, err := exec.LookPath(cliBinaryName)
if err == nil {
return normalizeBinaryPath(path)
}
return "", fmt.Errorf("resolve lark-cli binary: not found via request.BinaryPath, %s, project-root ./%s, PATH:%s", EnvBinaryPath, cliBinaryName, cliBinaryName)
}
func normalizeBinaryPath(path string) (string, error) {
if strings.TrimSpace(path) == "" {
return "", errors.New("binary path is empty")
}
absPath, err := filepath.Abs(path)
if err != nil {
return "", fmt.Errorf("resolve absolute binary path %q: %w", path, err)
}
info, err := os.Stat(absPath)
if err != nil {
return "", fmt.Errorf("stat binary path %q: %w", absPath, err)
}
if info.IsDir() {
return "", fmt.Errorf("binary path %q is a directory", absPath)
}
if info.Mode()&0o111 == 0 {
return "", fmt.Errorf("binary path %q is not executable", absPath)
}
return absPath, nil
}
// BuildArgs converts a request into CLI arguments.
func BuildArgs(req Request) ([]string, error) {
args := append([]string{}, req.Args...)
if len(args) == 0 {
return nil, errors.New("request args are required")
}
if req.DefaultAs != "" {
args = append(args, "--as", req.DefaultAs)
}
if req.Format != "" {
args = append(args, "--format", req.Format)
}
if req.Params != nil {
paramsBytes, err := json.Marshal(req.Params)
if err != nil {
return nil, fmt.Errorf("marshal lark-cli params: %w", err)
}
args = append(args, "--params", string(paramsBytes))
}
if req.Data != nil {
dataBytes, err := json.Marshal(req.Data)
if err != nil {
return nil, fmt.Errorf("marshal lark-cli data: %w", err)
}
args = append(args, "--data", string(dataBytes))
}
return args, nil
}
func findProjectRootDir() (string, error) {
currentDir, err := os.Getwd()
if err != nil {
return "", fmt.Errorf("get working directory: %w", err)
}
for {
markerPath := filepath.Join(currentDir, projectRootMarkerDir)
fileInfo, statErr := os.Stat(markerPath)
if statErr == nil && fileInfo.IsDir() {
return currentDir, nil
}
parentDir := filepath.Dir(currentDir)
if parentDir == "" || parentDir == currentDir {
break
}
currentDir = parentDir
}
return "", fmt.Errorf("project root not found from cwd using marker %q", projectRootMarkerDir)
}
func setDefaultAs(ctx context.Context, binaryPath string, identity string) error {
cmd := exec.CommandContext(ctx, binaryPath, "config", "default-as", identity)
var stderr bytes.Buffer
cmd.Stderr = &stderr
if err := cmd.Run(); err != nil {
return fmt.Errorf("set default-as %q: %w; stderr: %s", identity, err, strings.TrimSpace(stderr.String()))
}
return nil
}
func exitCode(err error) int {
if err == nil {
return 0
}
var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
return exitErr.ExitCode()
}
return -1
}
// StdoutJSON decodes stdout as JSON.
func (r *Result) StdoutJSON(t *testing.T) any {
t.Helper()
return mustParseJSON(t, "stdout", r.Stdout)
}
// StderrJSON decodes stderr as JSON.
func (r *Result) StderrJSON(t *testing.T) any {
t.Helper()
return mustParseJSON(t, "stderr", r.Stderr)
}
func mustParseJSON(t *testing.T, stream string, raw string) any {
t.Helper()
if strings.TrimSpace(raw) == "" {
t.Fatalf("%s is empty", stream)
}
var value any
if err := json.Unmarshal([]byte(raw), &value); err != nil {
t.Fatalf("parse %s as JSON: %v\n%s:\n%s", stream, err, stream, raw)
}
return value
}
// AssertExitCode asserts the exit code.
func (r *Result) AssertExitCode(t *testing.T, code int) {
t.Helper()
assert.Equal(t, code, r.ExitCode, "stdout:\n%s\nstderr:\n%s", r.Stdout, r.Stderr)
}
// AssertStdoutStatus asserts stdout JSON status using either {"ok": ...} or {"code": ...}.
// This intentionally keeps one shared assertion entrypoint for CLI E2E call sites,
// so tests can stay uniform across shortcut-style {"ok": ...} responses and
// service-style {"code": ...} responses without branching on response shape.
func (r *Result) AssertStdoutStatus(t *testing.T, expected any) {
t.Helper()
if okResult := gjson.Get(r.Stdout, "ok"); okResult.Exists() {
assert.Equal(t, expected, okResult.Bool(), "stdout:\n%s", r.Stdout)
return
}
if codeResult := gjson.Get(r.Stdout, "code"); codeResult.Exists() {
assert.Equal(t, expected, int(codeResult.Int()), "stdout:\n%s", r.Stdout)
return
}
assert.Fail(t, "stdout status key not found; expected ok or code", "stdout:\n%s", r.Stdout)
}