mirror of
https://github.com/larksuite/cli.git
synced 2026-08-03 08:32:46 +08:00
* feat(sheets): support font_family in cell styles (#1549) Add a font_family field to cell_styles so a cell's font name can be set and read back through every style entry point: - +cells-set (--cells JSON) and +cells-set-style / +cells-batch-set-style gain a font_family field / --font-family flat flag - +workbook-create / +table-put --styles accept font_family in cell_styles - +cells-get returns font_family helpers.go buildCellStyleFromFlags reads the --font-family flag; lark_sheet_workbook.go allows font_family in the --styles cell_styles whitelist; data/ + skills/ are synced from sheet-skill-spec. * docs(sheets): inline editing rules into SKILL.md and clarify flag descriptions - Move cross-cutting editing rules and execution notes into the root SKILL.md and drop the now-redundant core-operations reference - Clarify flag descriptions: offset must be explicit inside +batch-update, range prefixes written bare (no quotes), chart requires a dim index, untyped --values lose date/number types, ungroup level semantics - Sync the corresponding reference docs * feat(sheets): add --type bitable to +sheet-create for creating bitable sub-sheets (#1520) * perf(sheets): cap fan-out cell-matrix materialization to prevent OOM (#1578) * perf(sheets): cap fan-out cell-matrix materialization to prevent OOM The +cells-set-style / +dropdown-set / +cells-batch-set-style / +dropdown-update shortcuts expand a single A1 range into a rows×cols matrix of per-cell maps client-side (the backing set_cell_range tool takes an explicit cells matrix). rangeDimensions() had no upper bound, so a tiny input like "A1:Z100000" balloons into ~2.6M heap maps (~900MB, doubled again by json.Marshal) and can OOM the process before the request is even sent. Add a 50000-cell safety cap (checkStampMatrixBudget) gating every fan-out materialization point, matching the documented but never-wired --max-cells default. Oversized ranges now fail fast with a clear validation error instead of allocating. Also preallocate the per-op slices now that the range count is known up front. Adds benchmarks + a boundary test as regression guards. * perf(sheets): cap table-put/batch fan-out materialization (siblings of the cell-matrix cap) The single-range fan-out cap (maxStampMatrixCells) left three sibling ingress paths uncapped, each able to materialize an unbounded matrix or op set in memory before the request leaves: - +table-put / +workbook-create --sheets/--values: buildSheetMatrix builds the whole rows×cols matrix before slicing it into per-write batches; tablePutMaxCellsPerWrite only bounds the batch size, not the total input. Add tablePayload.checkCellBudget (1M-cell guardrail), enforced in validate() and in buildValuesPayload (the --values path bypasses validate()). - batch fan-out (+cells-batch-set-style / +dropdown-update): per-range checkStampMatrixBudget can't stop many ranges from summing past the cap. Add an aggregate cell budget (checkBatchStampBudget) and a shared maxBatchRanges (100) count cap in validateDropdownRanges — covering all fan-out commands and replacing the now-redundant +dropdown-delete count check. - +batch-update: cap --operations at maxBatchOperations (100) in translateBatchOperations. Adds boundary regression tests for each cap. go vet + gofmt clean; full shortcuts/sheets + backward suites green. * test(sheets): measure table-put matrix materialization cost Add BenchmarkBuildSheetMatrix_* and TestTablePutMatrixPeakMemory mirroring the fan-out probes. Confirms the +table-put/+workbook-create ingress has the same OOM profile as the single-range stamp: 2.6M cells → ~917 MB / 5.3M allocs (+875 MB resident heap) materialized before the first write — now rejected up front by checkCellBudget. * feat(pivot): lark-sheets pivot reference 补 +pivot-list info 说明与落点覆盖校验 +pivot-list 返回 info(page_range/content_range/error_state 等): 1) 判断目标单元格在透视表内(改配置 +pivot-update)还是区域外(改值 +cells-set); 2) 透视表展开后会覆盖已有数据,落点强烈优先默认自动新建子表; 3) 创建后用 info.error_state / content_range 校验有没有覆盖/冲突。 * feat(sheets): add +formula-verify shortcut for verify_formula tool Wraps the new verify_formula read tool in a CLI shortcut so AI agents can run write-then-zero-error verification end-to-end: lark-cli sheets +formula-verify --url <url> Scans formulas + cell error states across one or more sub-sheets and returns a JSON status report (success / errors_found / partial). Aggregates all 7 Excel error categories (#REF! / #DIV/0! / #VALUE! / #NAME? / #NULL! / #NUM! / #N/A) plus compile failures into one envelope; the tool always reports every error in the scan window — callers needing a subset filter the returned error_summary client-side. The internal scan cap is hidden from callers; when it trips the response sets has_more=true and includes a warning_message asking the caller to narrow --range / split --sheet-id and continue. Flags follow the lark-sheets convention: - --url / --spreadsheet-token (XOR public) - --sheet-id / --sheet-name (repeat or comma-separate; mutually exclusive) - --range (repeatable A1) - --max-locations (default 20) - --exit-on-error (CI gate: status='errors_found' → exit 2 with failed_precondition) Generated artifacts (skills/lark-sheets/{SKILL.md, references/ lark-sheets-formula-verify.md}, shortcuts/sheets/data/flag-defs.json, shortcuts/sheets/flag_defs_gen.go) are mirrored from sheet-skill-spec generated/ via 'npm run sync:cli'. shortcuts.go registers FormulaVerify alongside the other lark_sheet_formula_verify skill shortcuts so +formula-verify is discoverable from 'lark-cli sheets --help'. Tests cover the dry-run wire shape (excel_id + sheet_ids/sheet_names/ ranges/max_locations packing), the read scope (invoke_read URL), the mutually-exclusive selector validation, the non-positive --max-locations guard, and the --exit-on-error status matrix (success/partial/errors_found/unknown). * feat(sheets): add +history-list / +history-revert / +history-revert-status shortcuts BE-1 + BE-2 (larksuite/cli lark-sheets) for spec sheet-history-revert. Three thin callTool wrappers over facade-agg history tools, following the existing sheets Validate/DryRun/Execute + --url/--spreadsheet-token(/--token) locator convention: - +history-list (read, history_list): passes the tool output through verbatim; facade-agg already does the minor_histories/4-field/RFC3339 transform. - +history-revert (write, history_revert): --history-version-id required, enforced at Validate stage with a typed *errs.ValidationError (no request on missing); returns the async receipt. - +history-revert-status (read, history_revert_status): polls in-progress / success / failure. Flags declared inline (not via *_gen.go) — flag_defs_gen.go / data/flag-defs.json are synced from sheet-skill-spec (BE-3) and must not be hand-edited. Notes: - history_revert / history_revert_status depend on facade-agg's downstream RPC wiring, a DEFERRED follow-up; the tools return a "not wired yet" guard today. These CLI wrappers are correct and go live when the backend follow-up lands. +history-list is fully functional now. - TestFlagDefsGen_MatchesJSON fails on baseline (pre-existing BE-3 gen/json drift); resolves once BE-3 sync:cli regenerates flag defs for these shortcuts. Validation: go build ./shortcuts/sheets/... PASS; new tests (TestHistoryShortcuts_DryRun, TestHistoryRevert_MissingVersionID) PASS. Spec source: active@2acd94a24ac3f835357a274a02344f78435bcc1c39ad0d695ce587f0cbddfb21 * chore(sheets): sync lark_sheet_history skill + flag defs from sheet-skill-spec (BE-3) Synced artifacts for the history shortcuts from ee/sheet-skill-spec (SSOT), landed surgically (history-only) to avoid regressing this branch's newer skills/lark-sheets content: - skills/lark-sheets/references/lark-sheets-history.md (new, mirrored). - skills/lark-sheets/SKILL.md: + Lark Sheet History references-table row only. - shortcuts/sheets/data/flag-defs.json: + 3 history shortcuts (additive; no existing entries touched). - shortcuts/sheets/flag_defs_gen.go: regenerated via go generate ./shortcuts/sheets/... (this also resolves the pre-existing flag-defs/gen drift — TestFlagDefsGen_MatchesJSON now passes). NOT a full mirror: the rest of skills/lark-sheets/ + flag-schemas.json on this branch (feat/lark-sheets-develop) are NEWER than the sheet-skill-spec worktree's canonical (e.g. /wiki/ URL support, schema_version 3). A wholesale sync:cli would have reverted them, so only the history delta is taken here. Full re-sync should happen once sheet-skill-spec canonical is realigned with this branch. Validation: go generate clean; go test ./shortcuts/sheets/ (TestFlagDefsGen_MatchesJSON, TestHistory*) PASS. Spec source: active@2acd94a24ac3f835357a274a02344f78435bcc1c39ad0d695ce587f0cbddfb21 * fix(sheets): +history-revert-status keys on --transaction-id, not version id BE-2 gap surfaced by PPE E2E: +history-revert-status sent history_version_id, but the facade-agg history_revert_status tool keys on transaction_id (the async receipt returned by +history-revert), so it returned "[40400] transaction_id is required". Give the status shortcut its own --transaction-id flag + input (excel_id + transaction_id); revert keeps --history-version-id. Tests updated. * fix(sheets): align history flag-defs with inline shortcuts (green TestFlagsFor) TestFlagsFor_EveryRegisteredCommandHasDefs was RED: generated flag-defs drifted from the hand-written history shortcuts. - +history-revert-status: flag-defs had --history-version-id; the BE-2 fix switched the shortcut to --transaction-id. Updated the entry to transaction-id. - +history-revert / -status --history-version-id were marked required="required", but the inline flags are cobra-optional (requiredness enforced in Validate). Set required="optional" to match. Regenerated flag_defs_gen.go. NOTE: canonical source is sheet-skill-spec (BE-3); apply the same change upstream or the next sync:cli will regress this. * chore(sheets): sync lark-sheets-history reference from spec (BE-2 transaction-id) Mirror the upstream BE-2 fix in canonical-spec/references/lark_sheet_history/ cli-reference.md: +history-revert-status now uses --transaction-id (taken from the async receipt returned by +history-revert), and +history-revert's --history-version-id flips required→optional (Validate enforces requiredness at runtime). This file is the only history-only delta from the upstream sheet-skill-spec sync; the rest of skills/lark-sheets/ stays on the cli's newer baseline (/wiki/ URL support, +cells-set-image / +float-image-create, etc.) to match commit 8ae516db's history-only mirror policy. Spec source companion change: feat/sheet-history-revert in ee/sheet-skill-spec, canonical-spec/{tool-shortcut-map.json,references/ lark_sheet_history/cli-reference.md}. * feat(sheets): +history-list --end-version for backward pagination Spec follow-up sheet-history-revert: thread the history_list pagination contract through the +history-list shortcut. - shortcuts/sheets/lark_sheet_history_list.go: + --end-version (int, optional). Mapped to the tool input's `end_version` only when explicitly set (so the server treats absence as "first page / latest"), via runtime.Changed / runtime.Int (matches the +formula-verify --max-locations precedent). + Tip: pass next_end_version from the response on the next call; capture exits the pagination loop when the server omits the field. - shortcuts/sheets/lark_sheet_history_test.go: + dry-run case asserting --end-version 12345 lands as input.end_version=12345 (post-JSON unmarshal float64). - skills/lark-sheets/references/lark-sheets-history.md: synced from ee/sheet-skill-spec (commit 39c6b61). Adds the "倒序分页" caveat row + --end-version flag + pagination Examples line. Drops the internal MajorHistory.Version implementation detail per spec follow-up. - shortcuts/sheets/data/flag-defs.json: synced from spec (+history-list +--end-version int optional). - shortcuts/sheets/flag_defs_gen.go: regenerated via `go generate ./shortcuts/sheets/...`. Companion changes: - ee/sheet-skill-spec MR !37: spec-tables + tool-schemas pagination contract (commits 09e8604, 39c6b61). - ee/sheet-facade-agg MR !1028: history_list tool plumbs end_version, emits next_end_version + has_more (omitted at earliest page), defaults PageSize=20 to datarpc. Validation: - go build ./shortcuts/sheets/... PASS - go test ./shortcuts/sheets/... PASS (sheets + backward) - TestHistoryShortcuts_DryRun (5 cases incl. new --end-version case): PASS - TestHistoryRevert_MissingRequiredFlag: PASS - TestFlagsFor_EveryRegisteredCommandHasDefs: PASS - TestFlagDefsGen_MatchesJSON: PASS * fix(sheets): make +history-revert --history-version-id cobra-required + revert max-cells default drift Two issues surfaced during MR !37 review: 1) +history-revert --history-version-id requiredness was set as "optional" in the spec table (BE-2 fix dc5fe0ea) so cobra wouldn't block before Validate. Per upstream review the flag should be required-by-cobra so the user gets the standard "required flag(s)" gate immediately and the runtime contract matches the JSON shape. - shortcuts/sheets/lark_sheet_history_revert.go: historyVersionIDFlag now sets Required: true. Validate keeps a trim/empty-string guard so '--history-version-id ""' still fails as a typed *errs.ValidationError (cobra accepts empty strings as "set"). - shortcuts/sheets/data/flag-defs.json: +history-revert --history-version-id required: optional -> required. - shortcuts/sheets/flag_defs_gen.go: regenerated. - shortcuts/sheets/lark_sheet_history_test.go: TestHistoryRevert_MissingRequiredFlag split into per-shortcut subtests; +history-revert asserts cobra's "required flag(s)" contract (raw err — the test rig calls cmd.Execute directly so it doesn't see the cmd dispatcher's typed envelope wrap); +history-revert-status keeps the typed *errs.ValidationError contract (its --transaction-id stays cobra-optional + Validate-enforced). 2) max-cells safety cap was accidentally rewritten from 200000 to 50000 by the last sync from sheet-skill-spec (the spec canonical side fell out of date — fixed separately on the spec MR follow-up). Restore desc: "Safety cap; default 200000" / default: "200000" so +cells-get / +csv-get keep the documented cap. Validation: - go test ./shortcuts/sheets/... PASS - TestHistoryRevert_MissingRequiredFlag (both subtests) PASS - TestHistoryShortcuts_DryRun (incl. +history-list pagination case) PASS - TestFlagsFor_EveryRegisteredCommandHasDefs PASS - TestFlagDefsGen_MatchesJSON PASS * fix(sheets): make +history-revert-status --transaction-id cobra-required (match +history-revert) Companion to commit 6ca35b06: same gating model now applies to both history receipts. - shortcuts/sheets/lark_sheet_history_revert.go: transactionIDFlag.Required=true. Validate keeps a trim/empty-string guard for '--transaction-id ""'. - shortcuts/sheets/data/flag-defs.json: +history-revert-status --transaction-id required: optional -> required (synced from sheet-skill-spec @9ca814d). - shortcuts/sheets/flag_defs_gen.go: regenerated. - shortcuts/sheets/lark_sheet_history_test.go: TestHistoryRevert_MissingRequiredFlag/+history-revert-status moved to the cobra "required flag(s)" text contract (the test rig invokes the shortcut via cmd.Execute, which sees the raw cobra error directly without the dispatcher's typed wrap). Drop now-unused `errors` and `errs` imports. Validation: - go test ./shortcuts/sheets/... PASS (sheets + backward) - TestFlagsFor_EveryRegisteredCommandHasDefs: PASS - TestFlagDefsGen_MatchesJSON: PASS - TestHistoryRevert_MissingRequiredFlag (both subtests): PASS * docs(sheets): sync history skill reference required badges from spec Companion to commit 9fa73312 (transaction-id) and 6ca35b06 (history-version-id): the two flag tables in skills/lark-sheets/references/lark-sheets-history.md still showed 'optional' even though the canonical contract — and shortcuts/sheets/data/ flag-defs.json — already moved to 'required'. The earlier syncs only picked up the data file from spec; the skill markdown drift slipped through. Pull in the spec-side regenerated reference (ee/sheet-skill-spec @9ca814d) so the human-readable doc matches the wire contract. * fix(sheets): lower cells-set --max-cells default to 50000 * docs(sheets): clarify workbook-import over read-then-recreate in skill * docs(sheets): bump lark-sheets skill version to 3.0.1 * docs(sheets): clarify number-vs-text typing and copy-to-range template guidance in references * docs(sheets): type by data nature, add pre-write reference column and chart/cond-format/filter rows - SKILL.md quick-reference: add a "read before acting" column pointing each intent at its reference doc; add chart / cond-format / filter rows. - Reframe number-vs-text decision to follow the data's nature (measure vs identifier), not whether the current task happens to sort/sum; a leaderboard/report "display only" use does not make a percentage text. - write-cells reference: mirror the same rule and the +cells-set fallback for layouts +table-put cannot express. * docs(sheets): tighten number-vs-text guidance and dedupe write-cells reference * Feat/lark sheets develop wzz (#1719) * feat(sheets): add +changeset-get shortcut for changeset review Wrap the get_changeset read tool: fetch the raw changeset (edit actions) between two versions to review whether an AI edit fulfilled the request. --start-revision required, --end-revision optional (defaults to latest), gap capped at 100. Adds flag-defs entry + regenerated gen, the ChangesetGet shortcut + tests, and skill docs. * feat(sheets): add +get-revision shortcut Return a spreadsheet's current document revision without pulling the full sub-sheet listing. +get-revision is a read-only derivative over get_workbook_structure (the lightest read — token only, no range) that projects the response down to the single revision field. Adds flag-defs entries and a unit test for the projection helper. * feat: 同步 spec 修改 * feat(sheets): rename +get-revision to +revision-get * feat: 移除 ppe 环境请求头 --------- Co-authored-by: wenzhuozhen <wenzhuozhen@bytedance.com> * docs(sheets): dedupe +changeset-get flag def and skill reference entry * feat(sheets): accept local_office_ token prefix for image parent_type The synthetic token prefix for imported office spreadsheets is being renamed from fake_office_ to local_office_. Accept either prefix when mapping a spreadsheet token to the drive media parent_type so image uploads keep working across the rename (main package and backward compat copy). * fix(sheets): replace undefined common.FlagErrorf with sheetsValidationForFlag changesetRevisions called common.FlagErrorf, which does not exist, breaking the build. Use sheetsValidationForFlag so the errors carry the offending flag param like the rest of the sheets validation paths. Also reword two doc comments in lark_sheet_history_revert.go that used '' for an empty shell string: gofmt (Go 1.19+) rewrites '' in doc comments to a curly quote, leaving the file permanently unformatted. * fix(sheets): satisfy errs-no-bare-wrap forbidigo and errorlint rules from main main introduced the errs-no-bare-wrap forbidigo rule and errorlint coverage that flag 27 issues in existing sheets code after the merge: - Replace direct *errs.ValidationError type assertions with errors.As in sheetsInputStatError and validateSheetMediaUploadFile so wrapped errors still match (errorlint). - Type the embedded flag-schemas.json parse failure as an InternalError with cause; it reaches the user directly via --print-schema. - Annotate genuine intermediate errors (recursive schema validator, batch sub-op raw type checks, A1 range/position parsers) with //nolint:forbidigo; every caller wraps them into typed flag validation errors. * docs: tighten formula verify workflow guidance * docs: align formula verify refs with file names * feat(sheets): let typed writes style blank cells past the data extent +workbook-create / +table-put apply cell_styles by writing them into the in-memory matrix, whose size was fixed to the data (cols × rows). A style range reaching past that extent was rejected as "outside the write range", so blank cells (reserved regions, decorative headers, empty borders) could not be styled on the typed --sheets path — only the untyped --values path padded for it. Pad the matrix down/right to cover every cell_styles range before applying (empty cells appended for the uncovered positions), mirroring the --values behavior. writeSheetData now derives the written width/range from the padded matrix; both dry-run previews and sheetCreateDims account for the style extent so the physical grid and the plan match Execute. Ranges above/left of the write anchor stay rejected (the matrix only grows down/right). * docs(sheets): warn that +csv-put silently coerces numeric-looking labels Add guidance that +csv-put numericizes date-like/ID-like columns whose values are all digits (12.10 becomes 12.1 losing the trailing zero, 001 becomes 1 losing the leading zero); recommend +table-put with dtypes=object/datetime64 or +cells-set + number_format="@". Also fix the batch-update example to use sheet_name instead of sheet_id. * docs(sheets): steer import-vs-append onto sheet-copy for existing workbooks * docs(sheets): warn that cells-clear --scope all is irreversibly destructive * docs(sheets): sync chart schema and labels guidance (#1716) * chore(sheets): update chart flag schema * docs(sheets): clarify chart labels field is presence-toggle, not value-toggle Synced from sheet-skill-spec. Chart labels (plotArea.plot.labels and per-series labels) are toggled by object existence — passing labels at all turns data labels on, even when value/category/series/percentage are all false (server falls back to showing value). Models repeatedly try `{ value: false, category: false, series: false }` to disable, which silently shows the value fallback. The reference doc now spells out both directions: pass labels to show, omit the whole labels field to hide. Also picks up earlier spec-side drift not yet propagated: - pivot-table reference: +pivot-list info return + overlap validation - flag-defs: cell-matrix fan-out cap default 200000 -> 50000 (#1578) * feat(sheets): drop pre-refactor aliases from `sheets --help` listing The refactored + commands have been the default for over a month. Hide the deprecated pre-refactor aliases from `sheets --help` via a custom cobra usage template that skips the deprecated group. Aliases stay registered and executable: their own `sheets <alias> --help` still shows the (→ +new-command) pointer, unknown-subcommand suggestions still span them, and execution still returns the _notice. * feat(sheets): let +csv-put fall back to piped stdin when --csv is omitted Agents routinely redirect a CSV into stdin but forget the `--csv -`, so `+csv-put ... < data.csv` failed its first try on a missing --csv and cost an extra round-trip (error, then --help, then retry). Relax --csv's cobra required-gate in the shortcut's PostMount and install a PreRunE that defaults an omitted --csv to "-" when stdin is a non-interactive pipe, so the standard stdin-resolution path reads it. The pipe guard keeps an interactive terminal from blocking on stdin, and a genuine miss (no piped data) still surfaces csvPutInput's typed "--csv is required" instead of cobra's bare "required flag(s) ... not set". Scoped entirely to the sheets domain — no changes to the shared runner or the flag schema. * feat(sheets): rework +rows-resize / +cols-resize to --height / --width 从上游 sheet-skill-spec 同步:+cols-resize 用 --width、+rows-resize 用 --height 直接给像素值, --type 变为可选(省略等价于 pixel)。--type standard/auto 走非像素模式,不能与像素 flag 同传; --type pixel 与 --width/--height 共存时视为等价形式。--size 已删除。 * docs(sheets): 更新 lark-sheets skill 版本至 3.0.2 将 SKILL.md 版本号从 3.0.1 升至 3.0.2,同步近期 sheets 命令改动(+rows-resize/+cols-resize 改 --height/--width、 +csv-put 支持 stdin 回退等)后的技能版本。 * feat(sheets): add --widths / --heights map form for per-column/row sizes 从上游 sheet-skill-spec 同步:+cols-resize --widths / +rows-resize --heights 接收 JSON map(键为单行列或闭区间,值为像素或 "standard"/"auto"),CLI 按起始位置排序后 展开为一次原子 batch_update 的多个 resize_range 操作,多列不同宽 / 多行不同高一次 调用完成,不再需要 +batch-update。map 形态与 --range/--width/--height/--type 互斥, 不可作为 +batch-update 子操作嵌入(batch_update 不支持嵌套)。列宽 < 20px 拒绝并提示 Excel 字符单位换算(px ≈ 字符数×8+16);--print-schema --flag-name widths/heights 可查 schema。 * fix(sheets): sync flag input/enum fixes from sheet-skill-spec 上游修复 spec-table 的 Input/Enum 字符串惯例后重新生成:--widths/--heights 现在带 file/stdin 输入声明,+sheet-create --type 的枚举正确进入 flag defs 与文档。 * feat(sheets): add sheets-scoped flag ergonomics via PostMount Two recovery loops from the edit-eval traces burn agent round-trips: hallucinated flag names (--cols for --range) whose unknown-flag error only points at --help, and enum values imported from CSS/Excel vocabulary ("center" for the vertical alignment Lark spells "middle"). - unknown-flag errors now inline the full valid-flag list (semantic guesses aren't rankable by edit distance; kills the --help round trip) - enum values with an unambiguous canonical form (casing, known alias) are normalized in place and the call proceeds; edit-distance typos stay errors with a did-you-mean hint and are never auto-applied Both ride the existing PostMount composition (same pattern as withTokenAlias), so the common framework is untouched and no other domain's behavior shifts. * feat(sheets): make validation errors prescriptive for hot failure modes Driven by the edit-eval-extra-35Q reports: ~70% of lark-cli sheets errors were missing-required / JSON-shape / wrong-value classes whose messages said what broke but not how to fix it, pushing agents into --help / --print-schema probe loops. - composite JSON shape errors inline a compact skeleton auto-generated from the schema (e.g. --cells -> [[{"value": ...}]]) when the type mismatch is shallow container confusion - +batch-update: missing 'shortcut' shows the entry template; a disallowed shortcut inlines the full allow-list; exceeding the 100-op cap says how many batches to split into; sub-op translator failures append the shortcut's complete input-key contract - +table-put: dtypes/formats keys that miss every column call out the A1-letter habit and inline the declared column names; empty cells in a date-typed column name the three ways out - schema enum errors suggest across casing, vocabulary aliases, and edit distance * fix(common): steer rejected @file paths to stdin instead of cd The absolute-path rejection hint said "cd to the target directory first" - advice the lark-sheets skill explicitly tells agents not to follow (it pollutes the working directory). The stdin-contention hint also demonstrated @file with an absolute path, which would itself be rejected. - @file failures on stdin-capable flags now show the equivalent stdin invocation (--csv - < /tmp/x.csv) - the path error recommends a relative path or stdin, not cd - the stdin-contention example uses a relative @file path Message-text only; no control-flow change for any domain. * chore(sheets): suppress forbidigo on csv-put stdin pipe detection os.Stdin.Stat is intentional here - pipe detection needs the real process fd; IOStreams.In is a plain io.Reader without Stat. Clears the lint failure left by the stdin-fallback commit. * fix(sheets): pass spreadsheet token to changeset tool (#1839) * fix(sheets): hide bitable sheet creation (#1843) * fix(sheets): resolve revision wiki URLs * fix(sheets): reject overlapping resize ranges * fix(sheets): address remaining review feedback * fix(sheets): avoid credential scanner false positive * fix(sheets): import mislabeled .xls workbooks by sniffing content Local .xls files that are actually OOXML (an .xlsx exported or renamed to .xls) failed +workbook-import with a cryptic backend "xml_version_not_support" because the CLI trusted the file name extension. +workbook-import now sniffs the file's leading magic bytes (PK -> xlsx, OLE2 -> xls) and passes the true extension to the drive import core via a new optional ImportParams.FileExtension override, correcting both the file_extension and the staged media file name (the latter avoids the backend's "import file extension not match", code 1069910). A declared Excel file whose bytes match neither container is rejected locally with a prescriptive error instead of the opaque backend failure. The drive import core gains only the neutral FileExtension override (empty = infer from the file name, i.e. unchanged behavior for drive +import); all Excel sniffing/correction policy lives in the sheets shortcut. * fix(ci): keep semantic waiver fixture active * fix(sheets): close remaining safety gaps * fix(sheets): align history shortcuts with generated flags Use generated flag defs for history revert commands, enforce control-character validation, and sync the refreshed lark-sheets references from sheet-skill-spec. * fix(sheets): require confirmation for history revert * fix(sheets): require explicit csv input --------- Co-authored-by: xiongyuanwen-byted <xiongyuanwen@bytedance.com> Co-authored-by: wuyanchun.anunwu <wuyanchun.anunwu@bytedance.com> Co-authored-by: wenzhuozhen <wenzhuozhen@bytedance.com>
462 lines
22 KiB
Go
462 lines
22 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
||
// SPDX-License-Identifier: MIT
|
||
|
||
package sheets
|
||
|
||
import (
|
||
"sort"
|
||
"strings"
|
||
)
|
||
|
||
// ─── +batch-update sub-op dispatch ─────────────────────────────────────
|
||
//
|
||
// 用户传给 +batch-update --operations 的形态是 CLI 视角的 {shortcut, input}:
|
||
//
|
||
// [{"shortcut": "+range-copy", "input": {"sheet_id":"...","source-range":"A1:B2","target-range":"A10"}}, ...]
|
||
//
|
||
// input 里用的是该 shortcut 的 **CLI flag 名**(与 standalone 调用一致;连字符 /
|
||
// 下划线两种写法都接受)。底层 MCP batch_update tool 要的是
|
||
// {tool_name, input(MCP body)} —— body 的字段名往往与 CLI flag 名不同
|
||
// (如 +range-copy 的 source-range/target-range 要翻成 range/destination_range)。
|
||
//
|
||
// 关键:每个子操作复用 **standalone shortcut 同一套 flag→body translator**
|
||
// (那些 *Input 构建函数,现在统一接收 flagView 接口)。这样 batch 子操作
|
||
// 产出的 MCP body 与该 shortcut 单独调用产出的 body 完全一致(由
|
||
// batch-vs-standalone 契约测试保证)。dispatch 表只列**可纳入 atomic batch
|
||
// 的 write shortcut**——读操作、fan-out wrapper(+batch-update 自身、
|
||
// +cells-batch-set-style、+cells-batch-clear、+dropdown-{update,delete})一律不放进表里,
|
||
// 用户传到 +batch-update 里会被 translator 拒绝。
|
||
|
||
// batchTranslateFn turns a sub-op's CLI-shape input (via flagView) into the MCP
|
||
// tool body for the underlying batch_update sub-tool. token is the
|
||
// +batch-update top-level spreadsheet token; sheetID/sheetName are the resolved
|
||
// sheet selector for this sub-op. The returned body already carries excel_id
|
||
// and (where the tool needs one) the operation discriminator — exactly as the
|
||
// standalone shortcut would emit.
|
||
type batchTranslateFn func(fv flagView, token, sheetID, sheetName string) (map[string]interface{}, error)
|
||
|
||
type batchOpMapping struct {
|
||
// mcpToolName 是底层 MCP batch_update 接受的 tool_name。
|
||
mcpToolName string
|
||
// translate 复用 standalone 的 *Input 构建逻辑,产出 MCP body。
|
||
translate batchTranslateFn
|
||
}
|
||
|
||
// sheetSelectorFlagsForSubOp returns the (id, name) flag names a +batch-update
|
||
// sub-op uses to express its placement / context sheet. Defaults are
|
||
// `sheet-id` / `sheet-name`; +pivot-create deviates because its create
|
||
// shortcut renamed the placement selector to `target-sheet-id` /
|
||
// `target-sheet-name` (the data-source sheet is encoded in --source as
|
||
// `'SheetName'!Range`, not in a sheet selector flag). Update / delete on
|
||
// pivot still use the default names — only the create create-side
|
||
// shortcut was renamed.
|
||
func sheetSelectorFlagsForSubOp(shortcut string) (string, string) {
|
||
if shortcut == "+pivot-create" {
|
||
return "target-sheet-id", "target-sheet-name"
|
||
}
|
||
return "sheet-id", "sheet-name"
|
||
}
|
||
|
||
// objCreateTranslate / objUpdateTranslate / objDeleteTranslate bind an object
|
||
// CRUD spec to the shared object_crud builders.
|
||
func objCreateTranslate(spec objectCRUDSpec) batchTranslateFn {
|
||
return func(fv flagView, token, sheetID, sheetName string) (map[string]interface{}, error) {
|
||
return objectCreateInput(fv, token, sheetID, sheetName, spec)
|
||
}
|
||
}
|
||
|
||
func objUpdateTranslate(spec objectCRUDSpec) batchTranslateFn {
|
||
return func(fv flagView, token, sheetID, sheetName string) (map[string]interface{}, error) {
|
||
return objectUpdateInput(fv, token, sheetID, sheetName, spec)
|
||
}
|
||
}
|
||
|
||
func objDeleteTranslate(spec objectCRUDSpec) batchTranslateFn {
|
||
return func(fv flagView, token, sheetID, sheetName string) (map[string]interface{}, error) {
|
||
return objectDeleteInput(fv, token, sheetID, sheetName, spec)
|
||
}
|
||
}
|
||
|
||
// batchOpDispatch covers every write shortcut that can join an atomic batch.
|
||
// Each entry plugs the shortcut's standalone xxxInput builder into the
|
||
// batch translator path — so the body is byte-identical to the standalone
|
||
// invocation (locked by TestBatchOp_BodyMatchesStandalone) and the missing-
|
||
// flag error is identical too (locked by TestBatchOp_ErrorEquivalence).
|
||
var batchOpDispatch = map[string]batchOpMapping{
|
||
// ─── 单元格内容 ──────────────────────────────────────────────────
|
||
"+cells-set": {"set_cell_range", cellsSetInput},
|
||
"+cells-set-style": {"set_cell_range", cellsSetStyleInput},
|
||
"+cells-clear": {"clear_cell_range", cellsClearInput},
|
||
"+cells-replace": {"replace_data", replaceInput},
|
||
"+csv-put": {"set_range_from_csv", csvPutInput},
|
||
"+dropdown-set": {"set_cell_range", dropdownSetInput},
|
||
|
||
// ─── 单元格合并 (merge_cells, operation 区分) ────────────────────
|
||
"+cells-merge": {"merge_cells", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return mergeInput(fv, token, sid, sname, "merge", true)
|
||
}},
|
||
"+cells-unmerge": {"merge_cells", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return mergeInput(fv, token, sid, sname, "unmerge", false)
|
||
}},
|
||
|
||
// ─── 行列结构 (modify_sheet_structure, operation 区分) ──────────
|
||
"+dim-insert": {"modify_sheet_structure", dimInsertInput},
|
||
"+dim-delete": {"modify_sheet_structure", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return dimRangeOpInput(fv, token, sid, sname, "delete")
|
||
}},
|
||
"+dim-hide": {"modify_sheet_structure", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return dimRangeOpInput(fv, token, sid, sname, "hide")
|
||
}},
|
||
"+dim-unhide": {"modify_sheet_structure", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return dimRangeOpInput(fv, token, sid, sname, "unhide")
|
||
}},
|
||
"+dim-freeze": {"modify_sheet_structure", dimFreezeInput},
|
||
"+dim-group": {"modify_sheet_structure", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return dimGroupInput(fv, token, sid, sname, "group")
|
||
}},
|
||
"+dim-ungroup": {"modify_sheet_structure", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return dimGroupInput(fv, token, sid, sname, "ungroup")
|
||
}},
|
||
|
||
// ─── 行高列宽 (resize_range, 无 operation 字段) ─────────────────
|
||
// The map form (--heights/--widths) fans out into its own batch_update
|
||
// and cannot nest inside +batch-update; sub-ops must use the uniform
|
||
// single-range form (range + height/width or type).
|
||
"+rows-resize": {"resize_range", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
if err := rejectResizeMapInBatch(fv, "row"); err != nil {
|
||
return nil, err
|
||
}
|
||
return resizeInput(fv, token, sid, sname, "row")
|
||
}},
|
||
"+cols-resize": {"resize_range", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
if err := rejectResizeMapInBatch(fv, "column"); err != nil {
|
||
return nil, err
|
||
}
|
||
return resizeInput(fv, token, sid, sname, "column")
|
||
}},
|
||
|
||
// ─── 区域操作 (transform_range, operation 区分) ─────────────────
|
||
"+range-move": {"transform_range", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return transformMoveCopyInput(fv, token, sid, sname, "move", false)
|
||
}},
|
||
"+range-copy": {"transform_range", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
return transformMoveCopyInput(fv, token, sid, sname, "copy", true)
|
||
}},
|
||
"+range-fill": {"transform_range", rangeFillInput},
|
||
"+range-sort": {"transform_range", rangeSortInput},
|
||
|
||
// ─── 工作簿 / 子表 (modify_workbook_structure, operation 区分) ──
|
||
"+sheet-create": {"modify_workbook_structure", func(fv flagView, token, _, _ string) (map[string]interface{}, error) {
|
||
return sheetCreateInput(fv, token)
|
||
}},
|
||
"+sheet-delete": {"modify_workbook_structure", sheetDeleteInput},
|
||
"+sheet-rename": {"modify_workbook_structure", sheetRenameInput},
|
||
"+sheet-move": {"modify_workbook_structure", sheetMoveBatchInput},
|
||
"+sheet-copy": {"modify_workbook_structure", sheetCopyInput},
|
||
"+sheet-hide": {"modify_workbook_structure", func(fv flagView, t, sid, sn string) (map[string]interface{}, error) {
|
||
return sheetVisibilityInput(fv, t, sid, sn, "hide")
|
||
}},
|
||
"+sheet-unhide": {"modify_workbook_structure", func(fv flagView, t, sid, sn string) (map[string]interface{}, error) {
|
||
return sheetVisibilityInput(fv, t, sid, sn, "unhide")
|
||
}},
|
||
"+sheet-set-tab-color": {"modify_workbook_structure", sheetSetTabColorInput},
|
||
"+sheet-show-gridline": {"modify_workbook_structure", func(fv flagView, t, sid, sn string) (map[string]interface{}, error) {
|
||
return sheetVisibilityInput(fv, t, sid, sn, "show_gridline")
|
||
}},
|
||
"+sheet-hide-gridline": {"modify_workbook_structure", func(fv flagView, t, sid, sn string) (map[string]interface{}, error) {
|
||
return sheetVisibilityInput(fv, t, sid, sn, "hide_gridline")
|
||
}},
|
||
|
||
// ─── 对象族 CRUD (manage_*_object, operation 区分) ─────────────
|
||
"+chart-create": {"manage_chart_object", objCreateTranslate(chartSpec)},
|
||
"+chart-update": {"manage_chart_object", objUpdateTranslate(chartSpec)},
|
||
"+chart-delete": {"manage_chart_object", objDeleteTranslate(chartSpec)},
|
||
|
||
"+pivot-create": {"manage_pivot_table_object", objCreateTranslate(pivotSpec)},
|
||
"+pivot-update": {"manage_pivot_table_object", objUpdateTranslate(pivotSpec)},
|
||
"+pivot-delete": {"manage_pivot_table_object", objDeleteTranslate(pivotSpec)},
|
||
|
||
"+cond-format-create": {"manage_conditional_format_object", objCreateTranslate(condFormatSpec)},
|
||
"+cond-format-update": {"manage_conditional_format_object", objUpdateTranslate(condFormatSpec)},
|
||
"+cond-format-delete": {"manage_conditional_format_object", objDeleteTranslate(condFormatSpec)},
|
||
|
||
"+filter-create": {"manage_filter_object", filterCreateInput},
|
||
"+filter-update": {"manage_filter_object", filterUpdateInput},
|
||
"+filter-delete": {"manage_filter_object", filterDeleteInput},
|
||
|
||
"+filter-view-create": {"manage_filter_view_object", objCreateTranslate(filterViewSpec)},
|
||
"+filter-view-update": {"manage_filter_view_object", objUpdateTranslate(filterViewSpec)},
|
||
"+filter-view-delete": {"manage_filter_view_object", objDeleteTranslate(filterViewSpec)},
|
||
|
||
"+sparkline-create": {"manage_sparkline_object", objCreateTranslate(sparklineSpec)},
|
||
"+sparkline-update": {"manage_sparkline_object", objUpdateTranslate(sparklineSpec)},
|
||
"+sparkline-delete": {"manage_sparkline_object", objDeleteTranslate(sparklineSpec)},
|
||
|
||
"+float-image-create": {"manage_float_image_object", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
if err := rejectLocalImageInBatch(fv); err != nil {
|
||
return nil, err
|
||
}
|
||
return floatImageWriteInput(fv, token, sid, sname, "create", false, "")
|
||
}},
|
||
"+float-image-update": {"manage_float_image_object", func(fv flagView, token, sid, sname string) (map[string]interface{}, error) {
|
||
if err := rejectLocalImageInBatch(fv); err != nil {
|
||
return nil, err
|
||
}
|
||
return floatImageWriteInput(fv, token, sid, sname, "update", true, "")
|
||
}},
|
||
"+float-image-delete": {"manage_float_image_object", objDeleteTranslate(floatImageDeleteSpec)},
|
||
}
|
||
|
||
// allowedBatchShortcuts lists every shortcut accepted inside +batch-update,
|
||
// sorted, for the not-allowed error hint.
|
||
func allowedBatchShortcuts() []string {
|
||
out := make([]string, 0, len(batchOpDispatch))
|
||
for sc := range batchOpDispatch {
|
||
out = append(out, sc)
|
||
}
|
||
sort.Strings(out)
|
||
return out
|
||
}
|
||
|
||
// subOpInputContract renders one shortcut's complete sub-op key vocabulary
|
||
// (wire-style underscore names) for the translator-failure hint: required
|
||
// flags are marked, the sheet selector pair collapses to a choose-one, and
|
||
// spreadsheet locators are omitted (reserved for the batch top level).
|
||
// Returns "" for shortcuts without a flag-defs entry.
|
||
func subOpInputContract(sc string) string {
|
||
defs, _ := loadFlagDefs()
|
||
spec, ok := defs[sc]
|
||
if !ok {
|
||
return ""
|
||
}
|
||
idFlag, nameFlag := sheetSelectorFlagsForSubOp(sc)
|
||
var keys []string
|
||
sheetSelector := ""
|
||
for _, df := range spec.Flags {
|
||
if df.Kind == "system" || df.Hidden {
|
||
continue
|
||
}
|
||
switch df.Name {
|
||
case "url", "spreadsheet-token":
|
||
continue // reserved: supplied by +batch-update top level
|
||
case idFlag, nameFlag:
|
||
sheetSelector = strings.ReplaceAll(idFlag, "-", "_") + "|" + strings.ReplaceAll(nameFlag, "-", "_") + " (choose one)"
|
||
continue
|
||
}
|
||
key := strings.ReplaceAll(df.Name, "-", "_")
|
||
if df.Required == "required" {
|
||
key += " (required)"
|
||
}
|
||
keys = append(keys, key)
|
||
}
|
||
if sheetSelector != "" {
|
||
keys = append([]string{sheetSelector}, keys...)
|
||
}
|
||
return strings.Join(keys, ", ")
|
||
}
|
||
|
||
// rejectLocalImageInBatch blocks the local-file --image source inside
|
||
// +batch-update: a batch sub-op has no upload phase, so the file could not be
|
||
// turned into a file_token. Callers must pass --image-token / --image-uri.
|
||
func rejectLocalImageInBatch(fv flagView) error {
|
||
if strings.TrimSpace(fv.Str("image")) != "" {
|
||
return sheetsValidationForFlag("image", "--image (local upload) is not supported inside +batch-update; pass --image-token or --image-uri instead")
|
||
}
|
||
return nil
|
||
}
|
||
|
||
// sheetMoveBatchInput translates +sheet-move inside a batch. Unlike the
|
||
// standalone shortcut it cannot issue the get_workbook_structure read that
|
||
// auto-derives sheet_id / source_index, so both must be supplied explicitly.
|
||
func sheetMoveBatchInput(fv flagView, token, sheetID, sheetName string) (map[string]interface{}, error) {
|
||
if sheetID == "" {
|
||
return nil, sheetsValidationForFlag("sheet-id", "+sheet-move in +batch-update requires sheet_id (sheet_name needs a network lookup unavailable mid-batch)")
|
||
}
|
||
if !fv.Changed("source-index") {
|
||
return nil, sheetsValidationForFlag("source-index", "+sheet-move in +batch-update requires source_index (auto-derive needs a network lookup unavailable mid-batch)")
|
||
}
|
||
if fv.Int("source-index") < 0 {
|
||
return nil, sheetsValidationForFlag("source-index", "--source-index must be >= 0")
|
||
}
|
||
// Standalone +sheet-move requires --index (see SheetMove.Validate). A batch
|
||
// sub-op skips that path, and mapFlagView falls back to the flag default (0),
|
||
// which would silently move the sheet to the front. Require it explicitly so
|
||
// the batch contract matches the standalone one.
|
||
if !fv.Changed("index") {
|
||
return nil, sheetsValidationForFlag("index", "+sheet-move in +batch-update requires index")
|
||
}
|
||
if fv.Int("index") < 0 {
|
||
return nil, sheetsValidationForFlag("index", "--index must be >= 0")
|
||
}
|
||
return map[string]interface{}{
|
||
"excel_id": token,
|
||
"operation": "move",
|
||
"sheet_id": sheetID,
|
||
"source_index": fv.Int("source-index"),
|
||
"target_index": fv.Int("index"),
|
||
}, nil
|
||
}
|
||
|
||
// reservedSubOpKeys 是禁止用户在 sub-op input 里手填的 key —— 它们由
|
||
// +batch-update 顶层 --url/--token 统一提供(excel_id / spreadsheet_token / url)。
|
||
var reservedSubOpKeys = []string{"excel_id", "spreadsheet_token", "url"}
|
||
|
||
// translateBatchOp 把一个 CLI 视角的 {shortcut, input} 翻成底层 MCP
|
||
// batch_update 的 {tool_name, input}。`index` 用于错误信息定位。input 用
|
||
// shortcut 的 CLI flag 名(连字符/下划线均可),经该 shortcut 的 standalone
|
||
// translator 翻成 MCP body。
|
||
//
|
||
// 失败场景:
|
||
// - shortcut 字段缺失 / 非 string
|
||
// - shortcut 不在 dispatch 表(拼写错;read 操作;嵌套 fan-out wrapper)
|
||
// - input 不是 object
|
||
// - input 里手填了 operation(由 shortcut 名隐含,禁手填以防 mismatch)
|
||
// - input 里手填了 excel_id / spreadsheet_token / url
|
||
// - 子操作的 translator 报错(如缺必填字段)
|
||
func translateBatchOp(raw interface{}, token string, index int) (map[string]interface{}, error) {
|
||
op, ok := raw.(map[string]interface{})
|
||
if !ok {
|
||
return nil, sheetsValidationForFlag("operations", "operations[%d] must be a JSON object", index)
|
||
}
|
||
scRaw, present := op["shortcut"]
|
||
if !present {
|
||
return nil, sheetsValidationForFlag("operations", "operations[%d]: 'shortcut' field is required", index).
|
||
WithHint(`each entry must look like {"shortcut":"+cells-set","input":{"sheet_name":"…","range":"A1:B2","cells":[[…]]}} — input uses the shortcut's own flag names`)
|
||
}
|
||
sc, ok := scRaw.(string)
|
||
if !ok || sc == "" {
|
||
return nil, sheetsValidationForFlag("operations", "operations[%d]: 'shortcut' must be a non-empty string (got %T)", index, scRaw)
|
||
}
|
||
mapping, ok := batchOpDispatch[sc]
|
||
if !ok {
|
||
// Inline the full allow-list: an agent that guessed a read op or a
|
||
// fan-out wrapper can pick the right shortcut immediately instead of
|
||
// spending a --print-schema round trip on the operations enum.
|
||
return nil, sheetsValidationForFlag(
|
||
"operations",
|
||
"operations[%d]: shortcut %q not allowed in +batch-update "+
|
||
"(read ops / fan-out wrappers like +batch-update / +cells-batch-set-style / +cells-batch-clear / +dropdown-{update,delete} are excluded)",
|
||
index, sc,
|
||
).WithHint("allowed shortcuts: %s", strings.Join(allowedBatchShortcuts(), ", "))
|
||
}
|
||
inputRaw, hasInput := op["input"]
|
||
var input map[string]interface{}
|
||
if !hasInput || inputRaw == nil {
|
||
input = map[string]interface{}{}
|
||
} else {
|
||
input, ok = inputRaw.(map[string]interface{})
|
||
if !ok {
|
||
return nil, sheetsValidationForFlag("operations", "operations[%d] (%s): 'input' must be a JSON object (got %T)", index, sc, inputRaw)
|
||
}
|
||
}
|
||
// 禁手填 operation —— 由 shortcut 名表达,手填易与 shortcut 不一致。
|
||
if _, has := input["operation"]; has {
|
||
return nil, sheetsValidationForFlag(
|
||
"operations",
|
||
"operations[%d] (%s): do not pass input.operation manually — it is implied by the shortcut name",
|
||
index, sc,
|
||
)
|
||
}
|
||
// 禁在 sub-op 重复填 spreadsheet 定位 —— 由 +batch-update 顶层 --url/--token 统一提供。
|
||
for _, k := range reservedSubOpKeys {
|
||
if _, has := input[k]; has {
|
||
return nil, sheetsValidationForFlag(
|
||
"operations",
|
||
"operations[%d] (%s): do not pass input.%s — it is already set from +batch-update top-level --url / --token",
|
||
index, sc, k,
|
||
)
|
||
}
|
||
}
|
||
// 拒绝任何额外的 sub-op 顶层 key(防御未来 schema drift / 用户笔误)。
|
||
for k := range op {
|
||
if k != "shortcut" && k != "input" {
|
||
return nil, sheetsValidationForFlag("operations", "operations[%d] (%s): unknown top-level key %q (expected only 'shortcut' and 'input')", index, sc, k)
|
||
}
|
||
}
|
||
fv := newMapFlagViewForCommand(sc, input)
|
||
// operations is skipped by parse-time schema validation, so type-check the
|
||
// sub-op's scalar fields here before the translator reads them via
|
||
// Int/Bool/Float64 (which would otherwise coerce a wrong type to zero).
|
||
if err := fv.validateRawTypes(); err != nil {
|
||
return nil, sheetsValidationForFlag("operations", "operations[%d] (%s): %v", index, sc, err)
|
||
}
|
||
if err := fv.normalizeAndValidateEnums(); err != nil {
|
||
return nil, sheetsValidationForFlag("operations", "operations[%d] (%s): %v", index, sc, err)
|
||
}
|
||
sheetIDFlag, sheetNameFlag := sheetSelectorFlagsForSubOp(sc)
|
||
sheetID := strings.TrimSpace(fv.Str(sheetIDFlag))
|
||
sheetName := strings.TrimSpace(fv.Str(sheetNameFlag))
|
||
body, err := mapping.translate(fv, token, sheetID, sheetName)
|
||
if err != nil {
|
||
// The inner error names one problem at a time (first missing flag);
|
||
// the hint lists the sub-op's complete key contract so an agent fixes
|
||
// every gap in a single retry instead of iterating flag by flag.
|
||
verr := sheetsValidationForFlag("operations", "operations[%d] (%s): %v", index, sc, err)
|
||
if contract := subOpInputContract(sc); contract != "" {
|
||
verr = verr.WithHint("%s input keys: %s", sc, contract)
|
||
}
|
||
return nil, verr
|
||
}
|
||
return map[string]interface{}{
|
||
"tool_name": mapping.mcpToolName,
|
||
"input": body,
|
||
}, nil
|
||
}
|
||
|
||
// maxBatchOperations caps how many sub-operations a single +batch-update may
|
||
// carry. Every translated op (with its own cells/properties payload) is held in
|
||
// the out slice at once before the whole batch is marshaled, so an unbounded
|
||
// operation count is the same unbounded-materialization hazard as the fan-out
|
||
// matrix, on the operations axis.
|
||
const maxBatchOperations = 100
|
||
|
||
// translateBatchOperations 翻译整个 ops 数组;fail-fast,遇错立即返回。
|
||
func translateBatchOperations(rawOps []interface{}, token string) ([]interface{}, error) {
|
||
if len(rawOps) == 0 {
|
||
return nil, sheetsValidationForFlag("operations", "--operations must be a non-empty JSON array")
|
||
}
|
||
if len(rawOps) > maxBatchOperations {
|
||
batches := (len(rawOps) + maxBatchOperations - 1) / maxBatchOperations
|
||
return nil, sheetsValidationForFlag("operations", "--operations accepts at most %d entries; got %d", maxBatchOperations, len(rawOps)).
|
||
WithHint("split the operations into %d separate +batch-update calls of at most %d entries each", batches, maxBatchOperations)
|
||
}
|
||
out := make([]interface{}, 0, len(rawOps))
|
||
var totalCells int64
|
||
for i, raw := range rawOps {
|
||
translated, err := translateBatchOp(raw, token, i)
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
totalCells += translatedCellCount(translated)
|
||
if totalCells > maxStampMatrixCells {
|
||
return nil, sheetsValidationForFlag("operations",
|
||
"--operations materialize %d cells total, over the %d-cell safety cap; reduce the number or size of cell operations",
|
||
totalCells, maxStampMatrixCells)
|
||
}
|
||
out = append(out, translated)
|
||
}
|
||
return out, nil
|
||
}
|
||
|
||
func translatedCellCount(op map[string]interface{}) int64 {
|
||
input, _ := op["input"].(map[string]interface{})
|
||
switch cells := input["cells"].(type) {
|
||
case [][]interface{}:
|
||
var total int64
|
||
for _, row := range cells {
|
||
total += int64(len(row))
|
||
}
|
||
return total
|
||
case []interface{}:
|
||
var total int64
|
||
for _, rawRow := range cells {
|
||
if row, ok := rawRow.([]interface{}); ok {
|
||
total += int64(len(row))
|
||
}
|
||
}
|
||
return total
|
||
default:
|
||
return 0
|
||
}
|
||
}
|