mirror of
https://github.com/larksuite/cli.git
synced 2026-07-07 00:37:51 +08:00
AI agents running inside OpenClaw / Hermes were routinely creating a parallel
app via `config init --new` instead of binding to the agent's existing app,
because every "not configured" hint and several deny errors hard-coded
`config init` regardless of workspace. Once bound, the same agents could
silently grant themselves user identity (impersonation) without the user
ever seeing a risk message in chat.
Changes:
- Introduce `core.NotConfiguredError` / `NoActiveProfileError` /
`reconfigureHint` helpers that branch on `CurrentWorkspace()`. In agent
workspaces they point at `lark-cli config bind --help` (a help page, not
a ready-to-run command) so AI must read the binding workflow and confirm
identity preset with the user before acting. In local terminals they
preserve the previous `config init --new` guidance.
- Migrate every `config init` hint that should be workspace-aware:
RequireConfigForProfile, default credential provider, credential provider
fallback, secret-resolve mismatch, config show, strict-mode entry-point
errors, default-as, profile use/rename/remove, auth list, doctor's
config_file check (which now also wraps the OS-level "no such file"
noise into the user-shaped "not configured" message).
- Refuse `config init` when run inside an OpenClaw / Hermes workspace by
default; add `--force-init` for the rare case the user genuinely wants
a parallel app. Without this guard, hint fixes were undone the moment
AI ignored them.
- Rewrite the strict-mode deny errors in cmd/auth/login.go, cmd/prune.go,
and internal/cmdutil/factory.go. The previous "AI agents are strictly
prohibited from modifying this setting" terminated AI reasoning while
providing no real gate. New errors point at `config strict-mode --help`
with the legitimate confirmation flow and explicitly note that switching
does NOT require re-bind. Integration test envelopes updated.
- Tighten `config bind --help` and `config strict-mode --help` to encode
the user-confirmation discipline directly: identity preset semantics
(bot-only vs user-default), "DO NOT switch without explicit user
confirmation", and a cross-reference clarifying that `config bind` is
for changing the underlying app while `config strict-mode` is the
policy-only switch (resolves an ambiguity an audit run found).
- Surface user-identity (impersonation) risk at every config write that
newly grants it, by reusing the canonical IdentityEscalationMessage
string from bind_messages.go:
- `noticeUserDefaultRisk` fires on flag-mode bind landing on
user-default, including the first-time case `warnIdentityEscalation`
misses (it requires a previous bot lock).
- `setStrictMode` warns when transitioning bot → user or bot → off
(newly permits user identity); stays quiet on narrowing changes
and on off → user (off already permitted user).
- Add tests: notconfigured_test.go (workspace branches),
init_guard_test.go (refuse + --force-init bypass), bind_warning_test.go
(user-default warning fires; bot-only does not), strict_mode_warning_test.go
(5 transitions covering both warn and no-warn paths).
Two follow-ups intentionally deferred: the keychain master-key hint at
internal/keychain/keychain.go:42 still suggests `config init` because the
keychain package can't import core (would be circular); fixing requires
either parameterizing the hint via callback or extracting workspace into
its own package. The lark-shared skill doc still tells AI to run
`config init` for first-time setup; updating the skill is in scope for
a follow-up PR.
Change-Id: I02273e044d9e061d211ceaa4f3ed5a3fb28325b3
84 lines
2.1 KiB
Go
84 lines
2.1 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package auth
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
larkauth "github.com/larksuite/cli/internal/auth"
|
|
"github.com/larksuite/cli/internal/cmdutil"
|
|
"github.com/larksuite/cli/internal/core"
|
|
"github.com/larksuite/cli/internal/output"
|
|
)
|
|
|
|
// ListOptions holds all inputs for auth list.
|
|
type ListOptions struct {
|
|
Factory *cmdutil.Factory
|
|
}
|
|
|
|
// NewCmdAuthList creates the auth list subcommand.
|
|
func NewCmdAuthList(f *cmdutil.Factory, runF func(*ListOptions) error) *cobra.Command {
|
|
opts := &ListOptions{Factory: f}
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "list",
|
|
Short: "List all logged-in users",
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if runF != nil {
|
|
return runF(opts)
|
|
}
|
|
return authListRun(opts)
|
|
},
|
|
}
|
|
|
|
return cmd
|
|
}
|
|
|
|
func authListRun(opts *ListOptions) error {
|
|
f := opts.Factory
|
|
|
|
multi, _ := core.LoadMultiAppConfig()
|
|
if multi == nil || len(multi.Apps) == 0 {
|
|
// auth list is a read-only probe; the "configured but no users"
|
|
// branch below already returns exit 0 with a stderr hint, so we
|
|
// keep the same contract here. We still want the hint to be
|
|
// workspace-aware, so we pull the message+hint out of
|
|
// NotConfiguredError() instead of hard-coding it.
|
|
var cfgErr *core.ConfigError
|
|
if errors.As(core.NotConfiguredError(), &cfgErr) {
|
|
fmt.Fprintln(f.IOStreams.ErrOut, cfgErr.Message)
|
|
if cfgErr.Hint != "" {
|
|
fmt.Fprintln(f.IOStreams.ErrOut, " hint: "+cfgErr.Hint)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
app := multi.CurrentAppConfig(f.Invocation.Profile)
|
|
if app == nil || len(app.Users) == 0 {
|
|
fmt.Fprintln(f.IOStreams.ErrOut, "No logged-in users. Run `lark-cli auth login` to log in.")
|
|
return nil
|
|
}
|
|
|
|
var items []map[string]interface{}
|
|
for _, u := range app.Users {
|
|
stored := larkauth.GetStoredToken(app.AppId, u.UserOpenId)
|
|
status := "no_token"
|
|
if stored != nil {
|
|
status = larkauth.TokenStatus(stored)
|
|
}
|
|
items = append(items, map[string]interface{}{
|
|
"userName": u.UserName,
|
|
"userOpenId": u.UserOpenId,
|
|
"appId": app.AppId,
|
|
"tokenStatus": status,
|
|
})
|
|
}
|
|
output.PrintJson(f.IOStreams.Out, items)
|
|
return nil
|
|
}
|