github/thedotmack-claude-mem
1
0
Fork 0
mirror of https://github.com/thedotmack/claude-mem.git synced 2026-08-03 13:52:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve Chroma relevance ordering in SQLite hydration

Browse Source 
When ChromaSearchStrategy queries by vector similarity with
orderBy='relevance', SessionStore.getObservationsByIds and related
methods silently coerced undefined to 'date_desc', destroying the
semantic ranking. Add 'relevance' as a valid orderBy value that skips
SQL ORDER BY and preserves caller-provided ID order.

Fixes #2153

(cherry picked from commit 9fedf8fc165c01cc3a8a8cdb8c057ea980bf511e)
This commit is contained in:
Roger Deng
2026-04-29 16:47:12 +08:00
committed by Alex Newman
parent 7e2da10a8e
commit 37c8988fe8
1 changed files with 28 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/services/sqlite/SessionStore.ts
View File

@@ -1669,12 +1669,13 @@ export class SessionStore {
*/
getObservationsByIds(
ids: number[],
options: { orderBy?: 'date_desc' | 'date_asc'; limit?: number; project?: string; type?: string | string[]; concepts?: string | string[]; files?: string | string[] } = {}
options: { orderBy?: 'date_desc' | 'date_asc' | 'relevance'; limit?: number; project?: string; type?: string | string[]; concepts?: string | string[]; files?: string | string[] } = {}
): ObservationSearchResult[] {
if (ids.length === 0) return [];
const { orderBy = 'date_desc', limit, project, type, concepts, files } = options;
const orderClause = orderBy === 'date_asc' ? 'ASC' : 'DESC';
const preserveIdOrder = orderBy === 'relevance';
const orderClause = preserveIdOrder ? '' : `ORDER BY created_at_epoch ${orderBy === 'date_asc' ? 'ASC' : 'DESC'}`;
const limitClause = limit ? `LIMIT ${limit}` : '';
// Build placeholders for IN clause
@@ -1730,11 +1731,16 @@ export class SessionStore {
SELECT *
FROM observations
${whereClause}
ORDER BY created_at_epoch ${orderClause}
${orderClause}
${limitClause}
`);
return stmt.all(...params) as ObservationSearchResult[];
const rows = stmt.all(...params) as ObservationSearchResult[];
if (!preserveIdOrder) return rows;
// Preserve caller-provided ID order (Chroma vector similarity ranking)
const rowMap = new Map(rows.map(r => [r.id, r]));
return ids.map(id => rowMap.get(id)).filter((r): r is ObservationSearchResult => !!r);
}
/**
@@ -2466,12 +2472,13 @@ export class SessionStore {
*/
getSessionSummariesByIds(
ids: number[],
options: { orderBy?: 'date_desc' | 'date_asc'; limit?: number; project?: string } = {}
options: { orderBy?: 'date_desc' | 'date_asc' | 'relevance'; limit?: number; project?: string } = {}
): SessionSummarySearchResult[] {
if (ids.length === 0) return [];
const { orderBy = 'date_desc', limit, project } = options;
const orderClause = orderBy === 'date_asc' ? 'ASC' : 'DESC';
const preserveIdOrder = orderBy === 'relevance';
const orderClause = preserveIdOrder ? '' : `ORDER BY created_at_epoch ${orderBy === 'date_asc' ? 'ASC' : 'DESC'}`;
const limitClause = limit ? `LIMIT ${limit}` : '';
const placeholders = ids.map(() => '?').join(',');
const params: any[] = [...ids];
@@ -2485,11 +2492,15 @@ export class SessionStore {
const stmt = this.db.prepare(`
SELECT * FROM session_summaries
${whereClause}
ORDER BY created_at_epoch ${orderClause}
${orderClause}
${limitClause}
`);
return stmt.all(...params) as SessionSummarySearchResult[];
const rows = stmt.all(...params) as SessionSummarySearchResult[];
if (!preserveIdOrder) return rows;
const rowMap = new Map(rows.map(r => [r.id, r]));
return ids.map(id => rowMap.get(id)).filter((r): r is SessionSummarySearchResult => !!r);
}
/**
@@ -2498,12 +2509,13 @@ export class SessionStore {
*/
getUserPromptsByIds(
ids: number[],
options: { orderBy?: 'date_desc' | 'date_asc'; limit?: number; project?: string } = {}
options: { orderBy?: 'date_desc' | 'date_asc' | 'relevance'; limit?: number; project?: string } = {}
): UserPromptRecord[] {
if (ids.length === 0) return [];
const { orderBy = 'date_desc', limit, project } = options;
const orderClause = orderBy === 'date_asc' ? 'ASC' : 'DESC';
const preserveIdOrder = orderBy === 'relevance';
const orderClause = preserveIdOrder ? '' : `ORDER BY up.created_at_epoch ${orderBy === 'date_asc' ? 'ASC' : 'DESC'}`;
const limitClause = limit ? `LIMIT ${limit}` : '';
const placeholders = ids.map(() => '?').join(',');
const params: any[] = [...ids];
@@ -2520,11 +2532,15 @@ export class SessionStore {
FROM user_prompts up
JOIN sdk_sessions s ON up.content_session_id = s.content_session_id
WHERE up.id IN (${placeholders}) ${projectFilter}
ORDER BY up.created_at_epoch ${orderClause}
${orderClause}
${limitClause}
`);
return stmt.all(...params) as UserPromptRecord[];
const rows = stmt.all(...params) as UserPromptRecord[];
if (!preserveIdOrder) return rows;
const rowMap = new Map(rows.map(r => [r.id, r]));
return ids.map(id => rowMap.get(id)).filter((r): r is UserPromptRecord => !!r);
}
/**