mirror of
https://github.com/thedotmack/claude-mem.git
synced 2026-08-03 13:52:49 +08:00
* plan-10 Phase 1: ship deterministic plugin runtime dependency closure Approach A — commit & ship plugin/bun.lock so the plugin's runtime node_modules install is deterministic, fixing the recurring `Cannot find module 'zod/v3'` (#2730). - align generated plugin zod range to root (^4.4.3) in build-hooks.js - new scripts/gen-plugin-lockfile.cjs generates plugin/bun.lock as a build artifact after build-hooks.js writes plugin/package.json - track & ship plugin/bun.lock (.gitignore negation, .npmignore, files allowlist) - install with `bun install --frozen-lockfile --ignore-scripts` at runtime Refs #2783, #2730 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * plan-10 Phase 2: fail loud at install time on a broken dependency closure Strengthen verifyCriticalModules to assert each dependency is actually importable via require.resolve (not merely a directory), and assert the worker-required zod subpaths resolve: zod/v3, zod/v4, zod/v4-mini. A partial/stale install now fails `npx claude-mem install` immediately instead of surfacing later as a Stop-hook `Cannot find module 'zod/v3'`. Bin-only packages (e.g. tree-sitter-cli, which has no bare-name entry point) fall back to resolving <dep>/package.json so a healthy install isn't falsely rejected. Adds tests/cli/verify-critical-modules.test.ts covering a missing zod/v3 subpath (throws), a complete zod (passes), and a bin-only dep (passes). Refs #2783, #2730 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * plan-10 Phase 3: clean-room install + import smoke test (#2730 backstop) Add scripts/smoke-clean-room.cjs and a `smoke:clean-room` npm script. Against fresh temp dirs (never the repo's node_modules) it: - copies plugin/, runs `bun install --frozen-lockfile --ignore-scripts`, asserts zod, zod/v3, zod/v4, zod/v4-mini resolve, and boots the bundled worker asserting no `Cannot find module` — the direct #2730 regression guard; - `npm pack`s, installs the tarball into a second temp dir, and load-tests the published bin entrypoint, warning loudly on any declared main/exports target missing from the tarball (latent #2537 gap). Exits non-zero naming the missing module on any failure; cleans up all temp dirs and the tarball in a finally. Refs #2783, #2730 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * plan-10 Phase 4: gate CI and publish on the clean-room dependency closure - ci.yml: new `clean-room-deps` job (between build and the docker e2e job) runs a frozen-lockfile drift check on the committed plugin lockfile, then `npm run build` + `npm run smoke:clean-room`. The drift step catches a contributor who changed plugin deps without regenerating plugin/bun.lock. - npm-publish.yml: add setup-bun and run `npm run smoke:clean-room` between build and `npm publish`, so a broken runtime closure cannot be published on a tag push (ci.yml does not run on tags). Secrets block untouched. Refs #2783, #2730 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * plan-10: doc recluster note + Phase 0 execution slice for #2730 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * plans: backlog recluster (2026-06-04) — cross-cluster execution order + plan-13 doc Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * plan-10: gen-plugin-lockfile degrades gracefully when bun is absent The Windows build CI job has no bun on PATH; regenerating the lockfile there threw and failed the build. The committed plugin/bun.lock is already the deterministic closure, so skip regeneration (non-fatal) when bun is missing and a lockfile exists; fail loud only when neither is available. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
72 lines
2.3 KiB
JavaScript
72 lines
2.3 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
// Generates plugin/bun.lock as a build artifact from the GENERATED
|
|
// plugin/package.json (written by scripts/build-hooks.js). Shipping this
|
|
// lockfile lets the runtime installer (src/npx-cli/install/setup-runtime.ts)
|
|
// run `bun install --frozen-lockfile --ignore-scripts` for a deterministic
|
|
// dependency closure. See plan-10 (Build Artifact Hygiene, Approach A).
|
|
//
|
|
// MUST run AFTER build-hooks.js. Uses --ignore-scripts so generating the
|
|
// lockfile never triggers tree-sitter postinstall builds.
|
|
|
|
const { execSync } = require('child_process');
|
|
const { existsSync } = require('fs');
|
|
const path = require('path');
|
|
|
|
const rootDir = path.join(__dirname, '..');
|
|
const pluginDir = path.join(rootDir, 'plugin');
|
|
const pluginManifest = path.join(pluginDir, 'package.json');
|
|
|
|
console.log('\n🔒 Generating plugin/bun.lock...');
|
|
|
|
if (!existsSync(pluginManifest)) {
|
|
throw new Error(
|
|
`gen-plugin-lockfile: no package.json at ${pluginManifest}. ` +
|
|
`Run scripts/build-hooks.js first (it generates plugin/package.json).`
|
|
);
|
|
}
|
|
|
|
const lockfile = path.join(pluginDir, 'bun.lock');
|
|
|
|
// bun is the only tool that can regenerate the lockfile. On hosts that build
|
|
// without bun on PATH (e.g. the Windows build CI job), regeneration is skipped:
|
|
// the committed lockfile is already the deterministic closure, so a missing bun
|
|
// is non-fatal AS LONG AS the lockfile is present. With neither, we cannot
|
|
// produce the closure and must fail loud.
|
|
function bunAvailable() {
|
|
try {
|
|
execSync('bun --version', { stdio: 'ignore' });
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
if (!bunAvailable()) {
|
|
if (existsSync(lockfile)) {
|
|
console.log('⚠️ bun not found on PATH — skipping regeneration; using committed plugin/bun.lock.');
|
|
process.exit(0);
|
|
}
|
|
throw new Error(
|
|
`gen-plugin-lockfile: bun is not on PATH and no committed lockfile exists at ${lockfile}. ` +
|
|
`Install bun (https://bun.sh) so the deterministic dependency closure can be generated.`
|
|
);
|
|
}
|
|
|
|
try {
|
|
execSync('bun install --ignore-scripts', {
|
|
cwd: pluginDir,
|
|
stdio: 'inherit',
|
|
});
|
|
} catch (error) {
|
|
throw new Error(`bun install failed in ${pluginDir}\n${error.message}`);
|
|
}
|
|
|
|
if (!existsSync(lockfile)) {
|
|
throw new Error(
|
|
`gen-plugin-lockfile: bun install completed but ${lockfile} was not produced.`
|
|
);
|
|
}
|
|
|
|
console.log('✓ plugin/bun.lock generated');
|