mirror of https://github.com/thedotmack/claude-mem.git synced 2026-07-03 12:32:32 +08:00

Files

Alex Newman cf450cec00 fix(build): enforce shipped dependency-closure boundary (plan-10, closes #2783 ) (#2800 )

* plan-10 Phase 1: ship deterministic plugin runtime dependency closure

Approach A — commit & ship plugin/bun.lock so the plugin's runtime
node_modules install is deterministic, fixing the recurring
`Cannot find module 'zod/v3'` (#2730).

- align generated plugin zod range to root (^4.4.3) in build-hooks.js
- new scripts/gen-plugin-lockfile.cjs generates plugin/bun.lock as a
  build artifact after build-hooks.js writes plugin/package.json
- track & ship plugin/bun.lock (.gitignore negation, .npmignore, files allowlist)
- install with `bun install --frozen-lockfile --ignore-scripts` at runtime

Refs #2783, #2730

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* plan-10 Phase 2: fail loud at install time on a broken dependency closure

Strengthen verifyCriticalModules to assert each dependency is actually
importable via require.resolve (not merely a directory), and assert the
worker-required zod subpaths resolve: zod/v3, zod/v4, zod/v4-mini.
A partial/stale install now fails `npx claude-mem install` immediately
instead of surfacing later as a Stop-hook `Cannot find module 'zod/v3'`.

Bin-only packages (e.g. tree-sitter-cli, which has no bare-name entry
point) fall back to resolving <dep>/package.json so a healthy install
isn't falsely rejected.

Adds tests/cli/verify-critical-modules.test.ts covering a missing zod/v3
subpath (throws), a complete zod (passes), and a bin-only dep (passes).

Refs #2783, #2730

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* plan-10 Phase 3: clean-room install + import smoke test (#2730 backstop)

Add scripts/smoke-clean-room.cjs and a `smoke:clean-room` npm script.
Against fresh temp dirs (never the repo's node_modules) it:
- copies plugin/, runs `bun install --frozen-lockfile --ignore-scripts`,
  asserts zod, zod/v3, zod/v4, zod/v4-mini resolve, and boots the bundled
  worker asserting no `Cannot find module` — the direct #2730 regression guard;
- `npm pack`s, installs the tarball into a second temp dir, and load-tests
  the published bin entrypoint, warning loudly on any declared main/exports
  target missing from the tarball (latent #2537 gap).

Exits non-zero naming the missing module on any failure; cleans up all
temp dirs and the tarball in a finally.

Refs #2783, #2730

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* plan-10 Phase 4: gate CI and publish on the clean-room dependency closure

- ci.yml: new `clean-room-deps` job (between build and the docker e2e job)
  runs a frozen-lockfile drift check on the committed plugin lockfile, then
  `npm run build` + `npm run smoke:clean-room`. The drift step catches a
  contributor who changed plugin deps without regenerating plugin/bun.lock.
- npm-publish.yml: add setup-bun and run `npm run smoke:clean-room` between
  build and `npm publish`, so a broken runtime closure cannot be published
  on a tag push (ci.yml does not run on tags). Secrets block untouched.

Refs #2783, #2730

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* plan-10: doc recluster note + Phase 0 execution slice for #2730

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* plans: backlog recluster (2026-06-04) — cross-cluster execution order + plan-13 doc

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* plan-10: gen-plugin-lockfile degrades gracefully when bun is absent

The Windows build CI job has no bun on PATH; regenerating the lockfile there
threw and failed the build. The committed plugin/bun.lock is already the
deterministic closure, so skip regeneration (non-fatal) when bun is missing
and a lockfile exists; fail loud only when neither is available.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-05 20:27:34 -07:00

4.9 KiB

Raw Permalink Blame History

Execution Plan — claude-mem plan-master backlog (recluster 2026-06-04)

Cross-cluster sequencing for the 9 open plan masters (#2778–#2786). Per-cluster phase detail lives in plans/0X-*.md. This file is the order, the dependencies, and the ship contract.

Ship contract (per cluster, Mode 3)

One PR per master. PR title = the architectural fix. PR body ends with Closes #<master>.
The cluster's test matrix (from its plans/0X doc) lands in CI in the same PR — no matrix, no merge.
A master closes only when every listed child symptom is covered by the merged PR(s). plan-12 is the exception: it closes when its independent slices have all shipped.

Dependency graph

plan-10 (build/deps)  ──blocks──▶  everything (runtime won't boot without the dep closure)

plan-01 (hook IO) ──┐
                    ├──▶ plan-03 (#2703 Windows 0-obs) ──▶ plan-04 (install detection)
plan-02 (spawn)  ──┘

plan-09 (data)    ─┐
plan-11 (observer) ├── independent of the Windows chain; can run fully in parallel
plan-13 (grammar) ─┘

plan-12 (roadmap) ── opportunistic; never blocks a defect cluster

Release waves

Wave 0 — Unblock (ship first, smallest)

plan-10 #2783 — zod/v3 missing from the shipped dependency closure crashes the worker/Stop hook on every auto-update (Linux). Nothing downstream runs reliably until this is fixed. Tiny PR + clean-room install smoke test in CI.
- ⚠️ Doc is thin — expand to phases before assigning.

Wave 1 — Windows spawn/IO foundation (largest symptom family)

plan-01 #2778 — Hook IO Discipline. Land first within the wave; plan-02's hook command emit depends on the typed IO wrapper. (full plan ready)
plan-02 #2779 — Spawn-Contract Templating. Retires the cmd.exe/uvx/PATH/encoding family once 01's emit discipline is in place. (full plan ready)

Wave 2 — Worker reliability (needs Wave 1 for the Windows path)

plan-03 #2780 — Worker/Daemon Lifecycle. PID identity, supervision, OOM + transcript bounds. Its child #2703 (0 observations on Windows) only fully resolves after 01+02 ship, so sequence it after Wave 1. (full plan ready)

Wave 3 — Platform-agnostic correctness (parallel with Waves 1–2, different owner)

plan-09 #2782 — Data-Pipeline Integrity (session-id stamping, EXCLUDED_PROJECTS in Stop, FTS5 type column, worker-runtime write tools). ⚠️ Thin doc — expand.
plan-11 #2784 — Observer Output Fidelity (poison classification + recovery, truncation protection). ⚠️ Thin doc — expand.
plan-13 #2786 — Grammar/Parser Fidelity (plain-JS query split, custom-grammar load). ⚠️ Thin doc — expand.

Wave 4 — Install UX (after 01/02/10 are stable)

plan-04 #2781 — Installer Transparency. Host/IDE detection must route correctly, which presumes the spawn + dep fixes have landed. (full plan ready)

Wave 5 — Roadmap (ongoing, non-blocking)

plan-12 #2785 — 14 net-new slices. Each slice gets its own /make-plan and ships opportunistically. Master stays open until the sub-areas land.

Consolidated CI matrix (the regression backstop)

Each cluster contributes its axes; together they form the suite that must stay green:

Source	Axis	Cells
plan-01	host × shell × locale	Windows PS7 / git-bash / GBK / Codex
plan-02	host × spawn surface	cmd.exe uvx pins, mcp-search, chroma-mcp, no-window
plan-03	lifecycle scenario	start PID, recycled PID, long-gen, host-dev OOM, transcript rotate
plan-04	host × install method	npm-g vs Desktop discrimination (12×4)
plan-09	write/read path	id-stamp parity, exclusion, `type:` search, runtime write
plan-10	publish	clean-room install: full runtime dep closure present
plan-11	observer output	idle / prose / truncation / missing-results recovery
plan-13	language	js/mjs/cjs, ts/tsx, custom grammar

Readiness summary

Master	Cluster	Plan depth	Blocked by	Wave
#2783	plan-10 build/deps	⚠️ thin	—	0
#2778	plan-01 hook IO	✅ full	#2783	1
#2779	plan-02 spawn	✅ full	#2778	1
#2780	plan-03 worker	✅ full	#2778, #2779	2
#2782	plan-09 data	⚠️ thin	—	3
#2784	plan-11 observer	⚠️ thin	—	3
#2786	plan-13 grammar	⚠️ thin	—	3
#2781	plan-04 install	✅ full	#2778, #2779, #2783	4
#2785	plan-12 roadmap	n/a (roadmap)	—	5

Outstanding work before this plan is fully executable

Expand 4 thin docs to phase-level (plan-09, plan-10, plan-11, plan-13) — same Phase 0→N structure as plan-01..04, each with its own CI matrix cells.
Decompose plan-12 into per-slice /make-plan prompts (14 slices).
Then each master is assignable as a single forcing PR per the ship contract above.

4.9 KiB Raw Permalink Blame History Unescape Escape