Merge pull request #910 from zidoshare/create-new-feature

fix: correct argument parsing in create-new-feature.sh script
Merge branch 'main' into create-new-feature
2026-07-03 20:36:23 +08:00 · 2025-10-18 20:04:53 -07:00 · 2025-10-18 20:04:37 -07:00 · 2025-10-18 20:03:39 -07:00 · 2025-10-18 20:03:14 -07:00 · 2025-10-17 23:53:47 +08:00
2 changed files with 23 additions and 10 deletions
--- a/scripts/bash/create-new-feature.sh
+++ b/scripts/bash/create-new-feature.sh
@@ -5,20 +5,26 @@ set -e
 JSON_MODE=false
 SHORT_NAME=""
 ARGS=()
-i=0
-while [ $i -lt $# ]; do
+i=1
+while [ $i -le $# ]; do
    arg="${!i}"
    case "$arg" in
        --json) 
            JSON_MODE=true 
            ;;
        --short-name)
-            if [ $((i + 1)) -ge $# ]; then
+            if [ $((i + 1)) -gt $# ]; then
                echo 'Error: --short-name requires a value' >&2
                exit 1
            fi
            i=$((i + 1))
-            SHORT_NAME="${!i}"
+            next_arg="${!i}"
+            # Check if the next argument is another option (starts with --)
+            if [[ "$next_arg" == --* ]]; then
+                echo 'Error: --short-name requires a value' >&2
+                exit 1
+            fi
+            SHORT_NAME="$next_arg"
            ;;
        --help|-h) 
            echo "Usage: $0 [--json] [--short-name <name>] <feature_description>"
@@ -197,4 +203,4 @@ else
    echo "SPEC_FILE: $SPEC_FILE"
    echo "FEATURE_NUM: $FEATURE_NUM"
    echo "SPECIFY_FEATURE environment variable set to: $BRANCH_NAME"
-fi
+fi
--- a/src/specify_cli/init.py
+++ b/src/specify_cli/init.py
@@ -1164,18 +1164,25 @@ def check():

    tracker.add("git", "Git version control")
    git_ok = check_tool("git", tracker=tracker)
-    
+
    agent_results = {}
    for agent_key, agent_config in AGENT_CONFIG.items():
        agent_name = agent_config["name"]
-        
+        requires_cli = agent_config["requires_cli"]
+
        tracker.add(agent_key, agent_name)
-        agent_results[agent_key] = check_tool(agent_key, tracker=tracker)
-    
+
+        if requires_cli:
+            agent_results[agent_key] = check_tool(agent_key, tracker=tracker)
+        else:
+            # IDE-based agent - skip CLI check and mark as optional
+            tracker.skip(agent_key, "IDE-based, no CLI check")
+            agent_results[agent_key] = False  # Don't count IDE agents as "found"
+
    # Check VS Code variants (not in agent config)
    tracker.add("code", "Visual Studio Code")
    code_ok = check_tool("code", tracker=tracker)
-    
+
    tracker.add("code-insiders", "Visual Studio Code Insiders")
    code_insiders_ok = check_tool("code-insiders", tracker=tracker)
Author	SHA1	Message	Date
Den Delimarsky	3e85f46465	Merge pull request #910 from zidoshare/create-new-feature fix: correct argument parsing in create-new-feature.sh script	2025-10-18 20:04:53 -07:00
Den Delimarsky	015440838a	Merge branch 'main' into create-new-feature	2025-10-18 20:04:37 -07:00
Den Delimarsky	7050a3151c	Merge pull request #918 from wfongcn/patch-1 Change loop condition to include last argument	2025-10-18 20:03:39 -07:00
Den Delimarsky	9e84f46e56	Merge pull request #929 from isdaniel/fix/ide-agent-cli-checks fix: Skip CLI checks for IDE-based agents in check command	2025-10-18 20:03:14 -07:00
danielshih	098380a46f	fix: Skip CLI checks for IDE-based agents in check command - Add requires_cli field handling to check() command - IDE-based agents (copilot, cursor-agent, windsurf, kilocode, roo) now properly skip CLI checks - Prevents false errors when checking for IDE-integrated agents that don't require CLI tools	2025-10-17 23:53:47 +08:00
Peter Wang	74f7e508a4	Change loop condition to include last argument The last argument is not processed. e.g. create-new-feature.sh -h doesn't show the help information.	2025-10-17 09:03:47 +08:00
hongxuww	b37a9516d0	fix: correct argument parsing in create-new-feature.sh script Fix two critical bugs in the argument parsing logic that caused incorrect behavior when --short-name parameter was used: 1. Index offset bug: The loop started at i=0 and used i < $#, which incorrectly processed $0 (script name) as the first argument and skipped the last actual parameter. Changed to i=1 and i <= $# to properly iterate through actual command-line arguments ($1 to $#). 2. Boundary condition bug: The condition `[ $((i + 1)) -ge $# ]` incorrectly flagged valid arguments as missing. When --short-name was at position $#-1, the next position $# was valid but treated as out-of-bounds. Changed to `[ $((i + 1)) -gt $# ]` for correct validation. 3. Enhanced validation: Added check to ensure --short-name value is not another option (doesn't start with --). Before: - `script --json "desc" --short-name "test"` → Error: requires a value - `script --json "desc1" "desc2" --short-name` → Generated wrong branch name After: - `script --json "desc" --short-name "test"` → Works correctly - `script --json "desc1" "desc2" --short-name` → Proper error message This ensures the script correctly supports both parameter orders: - `[--json] [--short-name <name>] <feature_description>` - `[--json] <feature_description> [--short-name <name>]`	2025-10-16 10:02:53 +00:00