mirror of
https://github.com/github/spec-kit.git
synced 2026-08-03 06:26:30 +08:00
* feat(scripts): port create-new-feature, setup-plan and setup-tasks to Python Ports the three core workflow scripts to Python as part of #3280, following the check-prerequisites PoC pattern from #3302. Adds resolve_template() to the shared common.py module and parity tests that run bash and Python side by side. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(tests): treat only None env as unset in parity run helper Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): fall back to directory scan on any registry error, skip hidden preset dirs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat(templates): add py: lines for setup_plan and setup_tasks Ships with the scripts they reference; the remaining templates got their py: lines in #3403. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: support py variant in skills placeholder resolver resolve_skill_placeholders only accepted sh/ps, so a py init option fell into the fallback path and {SCRIPT} rendered without an interpreter prefix. Accept py and prefix the resolved interpreter, matching process_template. Also guard ps_cmd against a missing PowerShell with a clear assert. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: pin clean-error behavior for invalid --number Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs(scripts): reword unused-arg comment to match implementation The loop accepts and silently ignores extra positional args (it doesn't build a collected list); match the wording to what the code and setup-plan.sh actually do. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: fall back when configured script variant is missing from frontmatter Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): reject signed/whitespace --number values to match bash 10# parity The bash twin uses $((10#$BRANCH_NUMBER)), which rejects signed and whitespace-padded values. Python's int() accepted them (e.g. -1), producing a malformed -01-... prefix that sequential scans ignore. Restrict --number to unsigned decimal digits before conversion, and pin the parity with a bash-comparison test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): complete Python port installation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(integrations): fall back for missing script variants Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: make Python script checks platform-aware Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix Windows Python command invocation parity Use PowerShell's call operator for spaced Python interpreter paths and align setup-tasks missing-template errors across script variants. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): preserve cross-platform Python parity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: reject signed PowerShell feature numbers Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): align feature number range Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): reject exhausted feature numbers Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): complete create feature parity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): align create feature outputs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): harden cross-platform parity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): keep truncation JSON clean Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): align setup failure parity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): close parity edge cases Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): propagate PowerShell setup errors Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): harden fallback resolution Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): stabilize PowerShell fallbacks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): complete setup-plan parity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(cli): require runnable script fallbacks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(cli): preserve shell fallback without preference Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): restore help and symlink parity - setup-tasks.ps1: check -Help before unknown-argument validation so '-Help --bogus' exits 0 like the Bash/Python variants - common.py: strip the repo root prefix lexically in persist_feature_json instead of resolve(), so a symlinked specs/ still persists the relative 'specs/NNN-name' path the Bash/PowerShell helpers store Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(scripts): align persist-hint quoting with shlex.quote - create-new-feature.sh: replace printf %q with a shell_quote helper that emits shlex.quote-identical output, so the persistence hints stay byte-identical between the Bash and Python variants (printf %q output also varies between bash versions) - promote the negative --number test to an all-variants parity test now that Bash and PowerShell reject signed values consistently - add a spaced-repo-path parity test for the persistence hints Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
86 lines
3.0 KiB
PowerShell
86 lines
3.0 KiB
PowerShell
#!/usr/bin/env pwsh
|
|
# Setup implementation plan for a feature
|
|
|
|
[CmdletBinding()]
|
|
param(
|
|
[switch]$Json,
|
|
[switch]$Help,
|
|
# Capture extra positional arguments to match Bash/Python behavior.
|
|
[Parameter(ValueFromRemainingArguments = $true)]
|
|
[string[]]$RemainingArgs
|
|
)
|
|
|
|
$ErrorActionPreference = 'Stop'
|
|
|
|
# Show help if requested
|
|
if ($Help) {
|
|
Write-Output "Usage: ./setup-plan.ps1 [-Json] [-Help]"
|
|
Write-Output " -Json Output results in JSON format"
|
|
Write-Output " -Help Show this help message"
|
|
exit 0
|
|
}
|
|
|
|
# Load common functions
|
|
. "$PSScriptRoot/common.ps1"
|
|
|
|
# Get all paths and variables from common functions
|
|
$paths = Get-FeaturePathsEnv -ReturnNullOnError
|
|
if (-not $paths) {
|
|
[Console]::Error.WriteLine("ERROR: Failed to resolve feature paths")
|
|
exit 1
|
|
}
|
|
|
|
# Ensure the feature directory exists
|
|
New-Item -ItemType Directory -Path $paths.FEATURE_DIR -Force | Out-Null
|
|
|
|
# Copy plan template if plan doesn't already exist
|
|
if (Test-Path $paths.IMPL_PLAN -PathType Leaf) {
|
|
if ($Json) {
|
|
[Console]::Error.WriteLine("Plan already exists at $($paths.IMPL_PLAN), skipping template copy")
|
|
} else {
|
|
Write-Output "Plan already exists at $($paths.IMPL_PLAN), skipping template copy"
|
|
}
|
|
} else {
|
|
$template = Resolve-Template -TemplateName 'plan-template' -RepoRoot $paths.REPO_ROOT
|
|
if ($template -and (Test-Path $template)) {
|
|
# Read the template content and write it to the implementation plan file with UTF-8 encoding without BOM
|
|
$content = [System.IO.File]::ReadAllText($template)
|
|
$utf8NoBom = New-Object System.Text.UTF8Encoding($false)
|
|
[System.IO.File]::WriteAllText($paths.IMPL_PLAN, $content, $utf8NoBom)
|
|
# Emit the copy status like the bash twin (setup-plan.sh); route to stderr
|
|
# in -Json mode so stdout stays pure JSON, matching the sibling messages.
|
|
if ($Json) {
|
|
[Console]::Error.WriteLine("Copied plan template to $($paths.IMPL_PLAN)")
|
|
} else {
|
|
Write-Output "Copied plan template to $($paths.IMPL_PLAN)"
|
|
}
|
|
} else {
|
|
# Match the bash twin's wording and stream routing (stderr in -Json so
|
|
# stdout stays pure JSON, stdout otherwise), consistent with the sibling
|
|
# "Copied plan template" message above.
|
|
if ($Json) {
|
|
[Console]::Error.WriteLine("Warning: Plan template not found")
|
|
} else {
|
|
Write-Output "Warning: Plan template not found"
|
|
}
|
|
# Create a basic plan file if template doesn't exist
|
|
New-Item -ItemType File -Path $paths.IMPL_PLAN -Force | Out-Null
|
|
}
|
|
}
|
|
|
|
# Output results
|
|
if ($Json) {
|
|
$result = [PSCustomObject]@{
|
|
FEATURE_SPEC = $paths.FEATURE_SPEC
|
|
IMPL_PLAN = $paths.IMPL_PLAN
|
|
SPECS_DIR = $paths.FEATURE_DIR
|
|
BRANCH = $paths.CURRENT_BRANCH
|
|
}
|
|
$result | ConvertTo-Json -Compress
|
|
} else {
|
|
Write-Output "FEATURE_SPEC: $($paths.FEATURE_SPEC)"
|
|
Write-Output "IMPL_PLAN: $($paths.IMPL_PLAN)"
|
|
Write-Output "SPECS_DIR: $($paths.FEATURE_DIR)"
|
|
Write-Output "BRANCH: $($paths.CURRENT_BRANCH)"
|
|
}
|