github/larksuite-cli
1
0
Fork 0
mirror of https://github.com/larksuite/cli.git synced 2026-08-03 08:32:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: make chat member recovery hints complete

Browse Source
This commit is contained in:
shanglei
2026-07-21 18:00:36 +08:00
parent 8a146c39e6
commit 971da28e47
2 changed files with 43 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
shortcuts/im/im_chat_members_add.go
View File

@@ -25,15 +25,29 @@ const (
imChatMembersAddBotLimit = 5
imChatMembersAddIDMaxBytes = 256
imChatMembersAddReadbackHint = "List current chat members with lark-cli im +chat-members-list --chat-id <chat_id> --page-all before retrying; retry only members not confirmed present."
imChatBotsAddReadbackHint = "List current chat members with lark-cli im +chat-members-list --chat-id <chat_id> --page-all before retrying; retry only bots not confirmed present."
imChatMembersAddReadbackHint = "List current chat members with lark-cli im +chat-members-list --chat-id <chat_id> --member-types user --page-all --page-limit 0 --as <same-identity> before retrying. Treat a member not found as missing only when has_more:false and truncations has no entry for member_type user; otherwise do not retry the unknown batch. Retry only user members not confirmed present."
imChatBotsAddReadbackHint = "List current chat members with lark-cli im +chat-members-list --chat-id <chat_id> --member-types bot --page-all --page-limit 0 --as <same-identity> before retrying. Treat a member not found as missing only when has_more:false and truncations has no entry for member_type bot; otherwise do not retry the unknown batch. Retry only bots not confirmed present."
)
var (
imChatMembersAddIDSuffix = regexp.MustCompile(`^[A-Za-z0-9_-]+$`)
errChatMembersAddMissingResponseData = errors.New("chat member response data is missing or invalid")
errChatMembersAddMissingResponseData = chatMembersAddInvalidResponseCause{
reason: "chat member response data is missing or invalid",
}
)
type chatMembersAddInvalidResponseCause struct {
field string
reason string
}
func (e chatMembersAddInvalidResponseCause) Error() string {
if e.field == "" {
return e.reason
}
return e.field + " " + e.reason
}
type chatMembersAddSpecContextKey struct{}
// ImChatMembersAdd is the +chat-members-add shortcut. User open IDs and bot
@@ -523,7 +537,7 @@ func projectChatMembersAddList(data map[string]interface{}, key string) ([]strin
}
func newInvalidChatMembersAddResponseError(field, reason string) error {
cause := fmt.Errorf("%s %s", field, reason)
cause := chatMembersAddInvalidResponseCause{field: field, reason: reason}
return errs.NewInternalError(
errs.SubtypeInvalidResponse,
"API returned invalid %s",

28
shortcuts/im/im_chat_members_add_test.go
View File

@@ -1676,13 +1676,35 @@ func assertChatMembersAddOutputLists(t *testing.T, data map[string]interface{},
func assertChatMembersAddReadbackHint(t *testing.T, hint string, botsOnly bool) {
t.Helper()
for _, want := range []string{"im +chat-members-list", "--chat-id <chat_id>", "--page-all", "only"} {
wantHint := "List current chat members with lark-cli im +chat-members-list --chat-id <chat_id> --member-types user --page-all --page-limit 0 --as <same-identity> before retrying. Treat a member not found as missing only when has_more:false and truncations has no entry for member_type user; otherwise do not retry the unknown batch. Retry only user members not confirmed present."
wantMemberType := "user"
if botsOnly {
wantHint = "List current chat members with lark-cli im +chat-members-list --chat-id <chat_id> --member-types bot --page-all --page-limit 0 --as <same-identity> before retrying. Treat a member not found as missing only when has_more:false and truncations has no entry for member_type bot; otherwise do not retry the unknown batch. Retry only bots not confirmed present."
wantMemberType = "bot"
}
if hint != wantHint {
t.Errorf("hint = %q, want %q", hint, wantHint)
}
for _, want := range []string{
"im +chat-members-list",
"--chat-id <chat_id>",
"--member-types " + wantMemberType,
"--page-all",
"--page-limit 0",
"--as <same-identity>",
"has_more:false",
"truncations",
"member_type " + wantMemberType,
"only",
} {
if !strings.Contains(hint, want) {
t.Errorf("hint = %q, want substring %q", hint, want)
}
}
if botsOnly && !strings.Contains(strings.ToLower(hint), "bot") {
t.Errorf("hint = %q, want bot-specific retry guidance", hint)
for _, prohibited := range []string{"oc_test", "ou_", "cli_", "tenant-token", "test-secret", "invalid-data-shape"} {
if strings.Contains(hint, prohibited) {
t.Errorf("hint contains protected runtime data %q", prohibited)
}
}
}