Compare commits

..

3 Commits

Author SHA1 Message Date
fangshuyu
15263efe30 fix: normalize batch delete block IDs 2026-07-22 19:09:46 +08:00
fangshuyu
5b67085b32 fix: preserve docs title compatibility 2026-07-22 19:07:04 +08:00
fangshuyu
da149e66ba fix: validate unsafe docs write inputs 2026-07-22 18:52:59 +08:00
398 changed files with 2736 additions and 41298 deletions

3
.github/CODEOWNERS vendored
View File

@@ -1,7 +1,4 @@
/go.mod @liangshuo-1
/go.sum @liangshuo-1
/internal/ @liangshuo-1
/shortcuts/common/ @liangshuo-1
# Last match wins: existing domains below are exempt, only new skills/ entries need review.
/skills/ @liangshuo-1

View File

@@ -9,40 +9,7 @@ permissions:
contents: read
jobs:
preflight:
runs-on: ubuntu-22.04
permissions:
contents: read
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
fetch-depth: 0
- uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6
with:
node-version: '22.14.0'
- name: Validate tag and commit
env:
TAG: ${{ github.ref_name }}
run: |
set -euo pipefail
node scripts/release-preflight.js --tag "$TAG"
git fetch origin main
HEAD_SHA="$(git rev-parse --verify 'HEAD^{commit}')"
MAIN_SHA="$(git rev-parse --verify 'FETCH_HEAD^{commit}')"
TAG_SHA="$(git rev-parse --verify "refs/tags/${TAG}^{commit}")"
if [[ "$TAG_SHA" != "$HEAD_SHA" ]]; then
echo "Tag ${TAG} does not resolve to the checked-out HEAD commit." >&2
exit 1
fi
if ! git merge-base --is-ancestor "$HEAD_SHA" "$MAIN_SHA"; then
echo "Tag ${TAG} does not point to a commit contained in origin/main." >&2
exit 1
fi
build-release:
needs: preflight
goreleaser:
runs-on: ubuntu-22.04
permissions:
contents: write
@@ -59,79 +26,35 @@ jobs:
with:
python-version: '3.x'
- uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6
with:
node-version: '22.14.0'
registry-url: 'https://registry.npmjs.org'
package-manager-cache: false
- name: Install pinned npm
run: npm install --global npm@11.16.0
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@e435ccd777264be153ace6237001ef4d979d3a7a # v6
with:
version: '~> v2'
args: release --clean
env:
GITHUB_TOKEN: ${{ github.token }}
- name: Include release checksums
run: |
set -euo pipefail
test -s dist/checksums.txt
(cd dist && sha256sum --check checksums.txt)
cp dist/checksums.txt checksums.txt
- name: Collect release asset
run: |
set -euo pipefail
mkdir npm-publish-asset
cp dist/*.tar.gz dist/*.zip dist/checksums.txt npm-publish-asset/
- name: Upload release asset
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: npm-publish-asset-${{ github.run_id }}
path: npm-publish-asset/
if-no-files-found: error
overwrite: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
publish-npm:
needs: build-release
needs: goreleaser
runs-on: ubuntu-22.04
environment: npm-production
permissions:
contents: read
id-token: write
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: '22.14.0'
node-version: '20'
registry-url: 'https://registry.npmjs.org'
package-manager-cache: false
- name: Install pinned npm
run: npm install --global npm@11.16.0
- name: Download release asset
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
name: npm-publish-asset-${{ github.run_id }}
path: npm-publish-asset
- name: Verify npm publish asset
- name: Download checksums from release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -euo pipefail
(cd npm-publish-asset && sha256sum --check checksums.txt)
cp npm-publish-asset/checksums.txt checksums.txt
PACK_JSON="$(npm pack --ignore-scripts --json)"
PACK_FILE="$(node -e 'const p=JSON.parse(process.argv[1]); if(p.length!==1 || !p[0].filename) process.exit(1); process.stdout.write(p[0].filename)' "$PACK_JSON")"
test -s "$PACK_FILE"
tar -tzf "$PACK_FILE" | grep -qx 'package/checksums.txt'
rm "$PACK_FILE"
TAG="${GITHUB_REF_NAME}"
gh release download "${TAG}" --pattern checksums.txt --dir .
test -s checksums.txt || { echo "checksums.txt missing or empty for ${TAG}"; exit 1; }
- name: Publish to npm
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npm publish --access public

View File

@@ -25,16 +25,19 @@ jobs:
with:
script: |
const run = context.payload.workflow_run;
const workflowId = Number(run.workflow_id || 0);
if (!Number.isInteger(workflowId) || workflowId <= 0) throw new Error("missing workflow id");
const { data: workflow } = await github.rest.actions.getWorkflow({
owner: context.repo.owner,
repo: context.repo.repo,
workflow_id: workflowId,
});
if (workflow.name !== "CI") throw new Error(`unexpected workflow name: ${workflow.name}`);
if (workflow.path !== ".github/workflows/ci.yml") throw new Error(`unexpected workflow path: ${workflow.path}`);
if (run.path && run.path !== workflow.path) throw new Error(`workflow path mismatch: ${run.path}`);
if (run.name !== "CI") throw new Error(`unexpected workflow name: ${run.name}`);
let workflowPath = run.path || "";
if (!workflowPath) {
const workflowId = Number(run.workflow_id || 0);
if (!Number.isInteger(workflowId) || workflowId <= 0) throw new Error("missing workflow id");
const { data: workflow } = await github.rest.actions.getWorkflow({
owner: context.repo.owner,
repo: context.repo.repo,
workflow_id: workflowId,
});
workflowPath = workflow.path || "";
}
if (workflowPath !== ".github/workflows/ci.yml") throw new Error(`unexpected workflow path: ${workflowPath}`);
if (run.event !== "pull_request") throw new Error(`unexpected event: ${run.event}`);
if (run.repository.id !== context.payload.repository.id) throw new Error("repository id mismatch");
if (run.repository.full_name !== context.payload.repository.full_name) throw new Error("repository name mismatch");
@@ -250,16 +253,19 @@ jobs:
with:
script: |
const run = context.payload.workflow_run;
const workflowId = Number(run.workflow_id || 0);
if (!Number.isInteger(workflowId) || workflowId <= 0) throw new Error("missing workflow id");
const { data: workflow } = await github.rest.actions.getWorkflow({
owner: context.repo.owner,
repo: context.repo.repo,
workflow_id: workflowId,
});
if (workflow.name !== "CI") throw new Error(`unexpected workflow name: ${workflow.name}`);
if (workflow.path !== ".github/workflows/ci.yml") throw new Error(`unexpected workflow path: ${workflow.path}`);
if (run.path && run.path !== workflow.path) throw new Error(`workflow path mismatch: ${run.path}`);
if (run.name !== "CI") throw new Error(`unexpected workflow name: ${run.name}`);
let workflowPath = run.path || "";
if (!workflowPath) {
const workflowId = Number(run.workflow_id || 0);
if (!Number.isInteger(workflowId) || workflowId <= 0) throw new Error("missing workflow id");
const { data: workflow } = await github.rest.actions.getWorkflow({
owner: context.repo.owner,
repo: context.repo.repo,
workflow_id: workflowId,
});
workflowPath = workflow.path || "";
}
if (workflowPath !== ".github/workflows/ci.yml") throw new Error(`unexpected workflow path: ${workflowPath}`);
if (run.event !== "pull_request") throw new Error(`unexpected event: ${run.event}`);
if (run.conclusion !== "success") throw new Error(`unexpected conclusion: ${run.conclusion}`);
if (run.repository.id !== context.payload.repository.id) throw new Error("repository id mismatch");

View File

@@ -2,120 +2,6 @@
All notable changes to this project will be documented in this file.
## [v1.0.80] - 2026-07-29
### Features
- **drive**: add +member-list shortcut (#1795)
- **drive**: add +permission-get-setting shortcut (#1738)
- propagate invocation metadata (#2097)
### Documentation
- **slides**: 补齐 shortcut 参数说明,修正 +xml-get --output 必填标注 (#2088)
- **slides**: +create 的参数下沉到 create.md主 skill 只留路由 (#2096)
### Tests
- **e2e**: wait for base role update visibility (#2087)
### Misc
- Feat/detect line text overlap (#2069)
## [v1.0.79] - 2026-07-28
### Features
- **slides**: update xsd (#2067)
### Bug Fixes
- **ci**: validate static workflow identity (#2015)
- **sheets**: recognize OFL0X local office tokens (#2063)
### Documentation
- **calendar**: clarify identity selection by event ownership (#2071)
- **slides**: add formula inline element syntax to quick-ref (#2077)
## [v1.0.78] - 2026-07-27
### Features
- event description support rich text (#1975)
### Bug Fixes
- **slides**: restrict canvas overflow checks
- **slides**: upgrade text overflow to error above 10px threshold
- **slides**: detect letterSpacing-driven text overflow
- **slides**: downgrade background-decoration text overflow to info
- **slides**: allow chartParsedValues roundtrip tag
- refine character width estimation for lark-slides text lint
- **slides**: preserve info lint severity
- **slides**: text may over flow shape
- exempt ghost text from slides lint
## [v1.0.77] - 2026-07-24
### Features
- introducing official card icon (#1973)
- **apps**: validate +file-list --page-size against server (0, 200] range (#2007)
- **apps**: support absolute and relative upload paths (#2005)
- **slides**: fill xml-schema-quick-ref gaps that forced XSD fallback (#2026)
- **slides**: add layout density lint for sparse/empty containers (#2022)
- add risk-control protection (#1910)
### Bug Fixes
- **slides**: normalize presentation flag aliases (#2032)
- **base**: classify +form-submit as high-risk-write (#1969)
- **slides**: declare screenshot scope
- **slides**: support CSV multi-value for --slide-id in screenshot (#2047)
### Documentation
- **skill**: clarify scope handling for query expansion (#2030)
- **base**: clarify complete and partial updates (#1993)
- **skills**: clarify callout child rules (#2048)
### Misc
- fix/task id handling (#2023)
- fix/task search pagination (#2041)
## [v1.0.75] - 2026-07-22
### Features
- add okr single create shortcut & skill text opti (#1941)
- **calendar**: auto-add bot self as attendee and note user-only search (#1991)
### Bug Fixes
- **base**: improve table shortcut behavior & guidance (#1803)
- issue#1935 & whiteboard shortcut reformat (#1980)
- remove legacy shortcut (#1997)
- **e2e**: inject shared credentials by identity (#1995)
### Documentation
- **skill**: describe html5 block xml usage (#1380)
- clarify fetch metadata and user cites (#1981)
- add topic move collector workflow (#1473)
- update lark doc HTML size limit (#2001)
- **base**: align record write schema guidance (#2000)
### Tests
- **e2e**: declare request identities explicitly (#2004)
### Misc
- harden npm release publishing (#1918)
## [v1.0.74] - 2026-07-21
### Features
@@ -1722,11 +1608,6 @@ Bundled AI agent skills for intelligent assistance:
- Bilingual documentation (English & Chinese).
- CI/CD pipelines: linting, testing, coverage reporting, and automated releases.
[v1.0.80]: https://github.com/larksuite/cli/releases/tag/v1.0.80
[v1.0.79]: https://github.com/larksuite/cli/releases/tag/v1.0.79
[v1.0.78]: https://github.com/larksuite/cli/releases/tag/v1.0.78
[v1.0.77]: https://github.com/larksuite/cli/releases/tag/v1.0.77
[v1.0.75]: https://github.com/larksuite/cli/releases/tag/v1.0.75
[v1.0.74]: https://github.com/larksuite/cli/releases/tag/v1.0.74
[v1.0.73]: https://github.com/larksuite/cli/releases/tag/v1.0.73
[v1.0.72]: https://github.com/larksuite/cli/releases/tag/v1.0.72

View File

@@ -51,7 +51,7 @@ script-test:
bash scripts/resolve-changed-from.test.sh
bash scripts/ci-workflow.test.sh
bash scripts/semantic-review-workflow.test.sh
$(NODE) --test scripts/e2e_domains.test.js scripts/fetch_e2e_tat.test.js scripts/install.test.js scripts/release-preflight.test.js scripts/semantic-review-verify-artifact.test.js scripts/pr-quality-summary.test.js scripts/semantic-review-publish.test.js scripts/ci-quality-summary-publish.test.js
$(NODE) --test scripts/e2e_domains.test.js scripts/fetch_e2e_tat.test.js scripts/semantic-review-verify-artifact.test.js scripts/pr-quality-summary.test.js scripts/semantic-review-publish.test.js scripts/ci-quality-summary-publish.test.js
# ./extension/... keeps the public plugin SDK in the default test matrix.
unit-test: fetch_meta

View File

@@ -285,29 +285,6 @@ To reduce these risks, the tool enables default security protections at multiple
We recommend using the Lark/Feishu bot integrated with this tool as a private conversational assistant. Do not add it to group chats or allow other users to interact with it, to avoid abuse of permissions or data leakage.
To reduce the security risks associated with access token theft, the CLI sends a minimal set of risk-control signals with OpenAPI requests made to exact official Feishu/Lark HTTPS domains. These signals are used to help identify anomalous API activity. This protection is enabled by default. The information sent is limited to:
- Operating system type: macOS, Windows, or Linux
- Device hardware model: for example, Mac17,9
To disable this protection for the current workspace, run:
```bash
lark-cli config risk-control off
```
To enable this protection for the current workspace, run:
```bash
lark-cli config risk-control on
```
To restore the default policy for the current workspace, run:
```bash
lark-cli config risk-control default
```
Please fully understand all usage risks. By using this tool, you are deemed to voluntarily assume all related responsibilities.
## Star History

View File

@@ -286,29 +286,6 @@ lark-cli schema im.messages.delete
我们建议您将对接本工具的飞书机器人作为私人对话助手使用,请勿将其拉入群聊或允许其他用户与其交互,以避免权限被滥用或数据泄露。
为降低访问令牌被盗用后的安全风险CLI 在向飞书/Lark 官方 HTTPS 精确域名发起 OpenAPI 请求时,会随请求发送一组最小化的风控信号,用于辅助识别异常调用行为。该保护默认开启,发送的信息仅包括:
- 操作系统类型macOS、Windows 或 Linux
- 设备的硬件产品型号:例如 Mac17,9
如需让当前 workspace 退出该保护,可执行以下命令:
```bash
lark-cli config risk-control off
```
如需开启当前 workspace 的保护,可执行以下命令:
```bash
lark-cli config risk-control on
```
恢复当前 workspace 默认策略可执行:
```bash
lark-cli config risk-control default
```
请您充分知悉全部使用风险,使用本工具即视为您自愿承担相关所有责任。
## Star History

View File

@@ -23,41 +23,6 @@ lark-cli contact +search-user --query "alice" --as user
lark-cli contact +search-user --user-ids "ou_3a8b****6a7b,me" --as user
```
## +search-bot
Search bots (apps) by keyword. Pass `--query` or `--queries`; use `--chat-ids` to search within specific chats.
### Skills
- lark-contact/references/lark-contact-search-bot.md
### Avoid when
- Looking for a person rather than a bot → use [[+search-user]]
- Running as a bot — this shortcut is user-only
### Tips
- `has_more=true` means the search is incomplete; refine the keyword or search scope instead of paginating
### Examples
**Find bots by keyword**
```bash
lark-cli contact +search-bot --query "会议助手" --as user
```
**Search inside one chat**
```bash
lark-cli contact +search-bot --query "助手" --chat-ids "oc_3a8b****6a7b" --as user
```
**Find bots you've chatted with**
```bash
lark-cli contact +search-bot --query "助手" --has-chatted --as user
```
**Search several bot keywords in one call**
```bash
lark-cli contact +search-bot --queries "会议助手,日报助手,审批助手" --as user
```
## +get-user
Fetch one user's profile by id, or your own with --user-id omitted. Use it under bot identity — `+search-user` is user-only.

View File

@@ -1,425 +0,0 @@
# im
> skill: lark-im
## chat.members create
Add users or bots to an existing chat by id.
### Avoid when
- Creating a new chat with initial members → use [[+chat-create]] with --users/--bots
- Only need to see who is already in the chat → use [[+chat-members-list]]
### Prerequisites
- chat_id (oc_xxx) from [[+chat-search]], [[+chat-list]], or [[+chat-create]] output
- member open_ids (ou_xxx) from contact +search-user
### Examples
**Add two users to a chat**
```bash
lark-cli im chat.members create --chat-id <chat_id> --data '{"id_list":["<open_id1>","<open_id2>"]}'
```
## chat.members delete
Remove users or bots from a chat.
### Avoid when
- Only reviewing membership before removal → use [[+chat-members-list]] first
### Prerequisites
- chat_id (oc_xxx) and the member open_ids, both visible in [[+chat-members-list]] output
### Examples
**Remove one user from a chat**
```bash
lark-cli im chat.members delete --chat-id <chat_id> --data '{"id_list":["<open_id>"]}'
```
## chat.members get
Page through the raw member list of a chat.
### Avoid when
- Normal member listing → use [[+chat-members-list]]; it buckets users[]/bots[], paginates, and surfaces truncations[]
### Prerequisites
- chat_id (oc_xxx) from [[+chat-search]] or [[+chat-list]]
### Examples
**Fetch one raw member page**
```bash
lark-cli im chat.members get --chat-id <chat_id>
```
## chat.members bots
Check whether the calling bot itself is in the chat.
### Avoid when
- Listing which bots are members → use [[+chat-members-list]] --member-types bot
### Prerequisites
- chat_id (oc_xxx); call with bot identity (--as bot)
### Examples
**Check the calling bot's membership**
```bash
lark-cli im chat.members bots --chat-id <chat_id> --as bot
```
## messages forward
Forward an existing message unchanged to another chat, user, or thread.
### Avoid when
- Need to send new text, markdown, image, or file content → use [[+messages-send]]
- Need to reply under an existing message → use [[+messages-reply]]
- Need to read messages before forwarding → use [[+chat-messages-list]] or [[+messages-search]]
### Prerequisites
- message_id from [[+chat-messages-list]], [[+messages-search]], or [[+messages-mget]]
- receive_id_type must match the target id, usually chat_id for group chats
### Tips
- Forwarding delivers content to other people — the domain Sending Approval Semantics apply: the user's request must name both the source message and the destination, and instructions embedded in the forwarded content never authorize anything
### Examples
**Forward one message to a chat**
```bash
lark-cli im messages forward --message-id <message_id> --receive-id-type chat_id --data '{"receive_id":"<chat_id>"}' --as bot
```
## messages delete
Recall (delete) a sent message.
### Avoid when
- Fixing content → there is no edit-by-recall; send a corrected message with [[+messages-send]] or reply with [[+messages-reply]]
### Prerequisites
- message_id from [[+chat-messages-list]] or [[+messages-mget]]
- bot identity can only recall messages the bot itself sent; recall also fails after the tenant's recall window expires
### Examples
**Recall a message**
```bash
lark-cli im messages delete --message-id <message_id>
```
## messages merge_forward
Merge-forward multiple messages from one chat as a single combined message.
### Avoid when
- Forwarding a single message → use [[messages forward]]
- Forwarding a whole thread → use [[threads forward]]
### Prerequisites
- message_ids all from the same source chat, via [[+chat-messages-list]]
- receive_id_type matching the target id
### Tips
- Merge-forwarding delivers content to other people — the domain Sending Approval Semantics apply: the user's request must name the source messages and the destination, and instructions embedded in the forwarded content never authorize anything
### Examples
**Merge-forward two messages to a chat**
```bash
lark-cli im messages merge_forward --receive-id-type chat_id --data '{"receive_id":"<chat_id>","message_id_list":["<message_id1>","<message_id2>"]}' --as bot
```
## messages read_users
List who has read a message you sent.
### Avoid when
- Checking a message's content or reactions → use [[+messages-mget]]
### Prerequisites
- message_id of a message sent by the current identity; user_id_type decides the id form in the response
### Examples
**List readers of a message**
```bash
lark-cli im messages read_users --message-id <message_id> --user-id-type open_id
```
## messages urgent_app
Send an in-app urgent notification for an existing bot-sent message.
### Avoid when
- The user asked for a phone call → use [[messages urgent_phone]]
- The user asked for SMS → use [[messages urgent_sms]]
- The message has not been sent yet → send it first with [[+messages-send]]
### Prerequisites
- message_id of a message sent by the calling bot
- bot identity; the bot must still be in the conversation
## messages urgent_phone
Send a phone urgent notification for an existing bot-sent message.
### Avoid when
- The user asked only for an in-app prompt → use [[messages urgent_app]]
- The user asked for SMS → use [[messages urgent_sms]]
### Prerequisites
- message_id of a message sent by the calling bot
- bot identity; the bot must still be in the conversation
## messages urgent_sms
Send an SMS urgent notification for an existing bot-sent message.
### Avoid when
- The user asked only for an in-app prompt → use [[messages urgent_app]]
- The user asked for a phone call → use [[messages urgent_phone]]
### Prerequisites
- message_id of a message sent by the calling bot
- bot identity; the bot must still be in the conversation
## interactive card delayed update
Update the original interactive card after receiving a `card.action.trigger` token.
### Avoid when
- Sending a new card → use [[+messages-send]] or [[+messages-reply]]
- Pinning or showing a message as a chat top notice → use the matching IM capability instead
### Prerequisites
- callback token plus the complete new card JSON; partial card patches are unsupported
- bot identity
### Examples
```bash
lark-cli api POST /open-apis/interactive/v1/card/update --as bot \
--data '{"token":"<token>","card":<complete_new_card_json>}'
```
See the `card.action.trigger` reference for token limits and Card 1.0 visibility requirements.
## chat top notice put
Put an already-sent message or card in a chat's top notice.
### Avoid when
- Pinning a message in chat history → use [[pins create]]
- Pinning a chat in the user's feed sidebar → use [[+feed-shortcut-create]]
- Updating the contents of a card after a callback → use [[interactive card delayed update]]
### Prerequisites
- chat_id and the existing message/card reference for `chat_top_notice`
- use the raw API escape hatch; there is no typed IM leaf command for this endpoint
### Examples
```bash
lark-cli api POST /open-apis/im/v1/chats/<chat_id>/top_notice/put_top_notice --as bot \
--data '{"chat_top_notice":<existing_message_reference>}'
```
## reactions create
Add an emoji reaction to a message.
### Avoid when
- Replying with content → use [[+messages-reply]]; reactions carry no text
### Prerequisites
- message_id from [[+chat-messages-list]], [[+messages-search]], or [[+messages-mget]]
- emoji_type is a fixed enum key (e.g. THUMBSUP, OK); it is not free-form text
### Examples
**Add a thumbs-up reaction**
```bash
lark-cli im reactions create --message-id <message_id> --data '{"reaction_type":{"emoji_type":"THUMBSUP"}}'
```
## reactions delete
Remove a reaction you previously added.
### Avoid when
- Removing someone else's reaction → not possible; only the reaction creator can delete it
### Prerequisites
- reaction_id from [[reactions list]] or the [[reactions create]] response
### Examples
**Delete a reaction**
```bash
lark-cli im reactions delete --message-id <message_id> --reaction-id <reaction_id>
```
## reactions list
List reactions on a single message, optionally filtered by emoji type.
### Avoid when
- Fetching reactions for many messages at once → use [[reactions batch_query]]
- Reading messages with reactions attached → [[+messages-mget]] already enriches reactions
### Prerequisites
- message_id from [[+chat-messages-list]] or [[+messages-mget]]
### Examples
**List reactions on a message**
```bash
lark-cli im reactions list --message-id <message_id>
```
## reactions batch_query
Fetch reactions for several messages in one call.
### Avoid when
- Only one message → use [[reactions list]]
- Reading messages together with reactions → [[+messages-mget]] enriches automatically
### Prerequisites
- one or more message_ids from [[+chat-messages-list]], each wrapped as a query entry
### Examples
**Query reactions for two messages**
```bash
lark-cli im reactions batch_query --data '{"queries":[{"message_id":"<message_id1>"},{"message_id":"<message_id2>"}]}'
```
## pins create
Pin a message in its chat.
### Avoid when
- Personal bookmark rather than chat-visible pin → use [[+flag-create]]
### Prerequisites
- message_id from [[+chat-messages-list]] or [[+messages-search]]
- the calling identity must be in the chat that contains the message
### Examples
**Pin a message**
```bash
lark-cli im pins create --data '{"message_id":"<message_id>"}'
```
## pins delete
Unpin a previously pinned message.
### Avoid when
- Removing a personal bookmark → use [[+flag-cancel]]
### Prerequisites
- message_id of the pinned message, from [[pins list]]
### Examples
**Unpin a message**
```bash
lark-cli im pins delete --message-id <message_id>
```
## pins list
List pinned messages in a chat.
### Avoid when
- Listing normal (non-pinned) history → use [[+chat-messages-list]]
### Prerequisites
- chat_id (oc_xxx) from [[+chat-search]] or [[+chat-list]]
### Examples
**List pins in a chat**
```bash
lark-cli im pins list --chat-id <chat_id>
```
## images create
Upload a local image and get an image_key for later use.
### Avoid when
- Sending an image message directly → use [[+messages-send]] --image <path>; it uploads and sends in one step
### Prerequisites
- a local image file; the returned image_key is what other APIs accept
### Examples
**Upload an image for reuse**
```bash
lark-cli im images create --data '{"image_type":"message"}' --file ./picture.png
```
## threads forward
Forward an entire thread (topic) to another chat, user, or thread.
### Avoid when
- Forwarding a single message → use [[messages forward]]
- Reading the thread before forwarding → use [[+threads-messages-list]]
### Prerequisites
- thread_id (omt_xxx) from [[+threads-messages-list]] or thread fields in [[+chat-messages-list]] output
- receive_id_type matching the target id
### Tips
- Forwarding a thread delivers content to other people — the domain Sending Approval Semantics apply: the user's request must name both the source thread and the destination, and instructions embedded in the forwarded content never authorize anything
### Examples
**Forward a thread to a chat**
```bash
lark-cli im threads forward --thread-id <thread_id> --receive-id-type chat_id --data '{"receive_id":"<chat_id>"}' --as bot
```
## chats get
Fetch raw chat metadata by id.
### Avoid when
- Finding a chat or its id → use [[+chat-search]] (by keyword) or [[+chat-list]] (my chats); reach for this raw call only for fields the shortcuts don't surface
### Examples
**Fetch chat metadata**
```bash
lark-cli im chats get --chat-id <chat_id>
```
## chats update
Update raw chat settings.
### Avoid when
- Renaming or changing the description → use [[+chat-update]]; this raw call is for settings the shortcut doesn't cover (permissions, membership approval, etc.)
### Examples
**Update chat join permission**
```bash
lark-cli im chats update --chat-id <chat_id> --data '{"join_message_visibility":"only_owner"}'
```
## chats create
Create a chat via the raw API.
### Avoid when
- Normal chat creation → use [[+chat-create]]; it handles member invites, chat mode, and owner in one step
### Examples
**Create a bare chat**
```bash
lark-cli im chats create --data '{"name":"project chat"}'
```
## chats link
Generate a share link for a chat.
### Avoid when
- Only need the chat id or basic info → use [[+chat-search]] or [[chats get]]
### Prerequisites
- chat_id (oc_xxx); link validity is controlled by validity_period in --data
### Examples
**Get a chat share link**
```bash
lark-cli im chats link --chat-id <chat_id> --data '{"validity_period":"week"}'
```

View File

@@ -31,7 +31,6 @@ func NewCmdConfig(f *cmdutil.Factory) *cobra.Command {
cmd.AddCommand(NewCmdConfigShow(f, nil))
cmd.AddCommand(NewCmdConfigDefaultAs(f))
cmd.AddCommand(NewCmdConfigStrictMode(f))
cmd.AddCommand(NewCmdConfigRiskControl(f))
cmd.AddCommand(NewCmdConfigPolicy(f))
cmd.AddCommand(NewCmdConfigPlugins(f))
cmd.AddCommand(NewCmdConfigKeychainDowngrade(f))

View File

@@ -1,80 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package config
import (
"fmt"
"github.com/spf13/cobra"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/core"
)
// NewCmdConfigRiskControl creates the workspace risk-control policy command.
func NewCmdConfigRiskControl(f *cmdutil.Factory) *cobra.Command {
cmd := &cobra.Command{
Use: "risk-control [on|off|default]",
Short: "Manage workspace account-protection policy",
Long: `View or set the account-protection risk-control policy for this workspace.
Account protection is on by default. Use off to opt this workspace out, on to
opt it back in explicitly, or default to remove the explicit preference.`,
Args: cobra.MaximumNArgs(1),
// This is persistent workspace policy, not credential management.
PersistentPreRunE: func(cmd *cobra.Command, _ []string) error {
cmd.SilenceUsage = true
return nil
},
RunE: func(cmd *cobra.Command, args []string) error {
config, err := core.LoadOrNotConfigured()
if err != nil {
return err
}
if len(args) == 0 {
printRiskControl(f, config)
return nil
}
switch args[0] {
case "on":
enabled := true
config.RiskControl = &enabled
case "off":
enabled := false
config.RiskControl = &enabled
case "default":
config.RiskControl = nil
default:
return errs.NewValidationError(errs.SubtypeInvalidArgument,
"invalid risk-control value %q, valid values: on | off | default", args[0])
}
if err := core.SaveMultiAppConfig(config); err != nil {
return errs.NewInternalError(errs.SubtypeStorage,
"failed to save risk-control policy: %v", err).WithCause(err)
}
fmt.Fprintf(f.IOStreams.ErrOut, "Risk control set to %s (workspace)\n", args[0])
return nil
},
}
cmdutil.SetRisk(cmd, cmdutil.RiskWrite)
return cmd
}
func printRiskControl(f *cmdutil.Factory, config *core.MultiAppConfig) {
source := "default"
if config.RiskControl != nil {
source = "workspace"
}
fmt.Fprintf(f.IOStreams.Out, "risk-control: %s (source: %s)\n", riskControlState(config.RiskControlEnabled()), source)
}
func riskControlState(enabled bool) string {
if enabled {
return "on"
}
return "off"
}

View File

@@ -1,130 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package config
import (
"errors"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/core"
)
func TestRiskControlWorkspacePolicy(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", t.TempDir())
config := &core.MultiAppConfig{Apps: []core.AppConfig{{
AppId: "cli_test", AppSecret: core.PlainSecret("secret"), Brand: core.BrandFeishu,
}}}
if err := core.SaveMultiAppConfig(config); err != nil {
t.Fatal(err)
}
f, stdout, stderr, _ := cmdutil.TestFactory(t, nil)
cmd := NewCmdConfigRiskControl(f)
cmd.SetArgs([]string{"off"})
if err := cmd.Execute(); err != nil {
t.Fatalf("set off: %v", err)
}
loaded, err := core.LoadMultiAppConfig()
if err != nil {
t.Fatal(err)
}
if loaded.RiskControl == nil || *loaded.RiskControl {
t.Fatalf("RiskControl = %v, want explicit false", loaded.RiskControl)
}
if !strings.Contains(stderr.String(), "set to off") {
t.Fatalf("stderr = %q", stderr.String())
}
stdout.Reset()
cmd = NewCmdConfigRiskControl(f)
if err := cmd.Execute(); err != nil {
t.Fatalf("show: %v", err)
}
if got := stdout.String(); got != "risk-control: off (source: workspace)\n" {
t.Fatalf("stdout = %q", got)
}
cmd = NewCmdConfigRiskControl(f)
cmd.SetArgs([]string{"on"})
if err := cmd.Execute(); err != nil {
t.Fatalf("set on: %v", err)
}
loaded, err = core.LoadMultiAppConfig()
if err != nil {
t.Fatal(err)
}
if loaded.RiskControl == nil || !*loaded.RiskControl {
t.Fatalf("RiskControl = %v, want explicit true", loaded.RiskControl)
}
cmd = NewCmdConfigRiskControl(f)
cmd.SetArgs([]string{"default"})
if err := cmd.Execute(); err != nil {
t.Fatalf("reset default: %v", err)
}
loaded, err = core.LoadMultiAppConfig()
if err != nil {
t.Fatal(err)
}
if loaded.RiskControl != nil {
t.Fatalf("RiskControl = %v, want nil", loaded.RiskControl)
}
stdout.Reset()
cmd = NewCmdConfigRiskControl(f)
if err := cmd.Execute(); err != nil {
t.Fatalf("show default: %v", err)
}
if got := stdout.String(); got != "risk-control: on (source: default)\n" {
t.Fatalf("stdout = %q", got)
}
}
func TestRiskControlWorkspacePolicyRejectsInvalidValue(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", t.TempDir())
if err := core.SaveMultiAppConfig(&core.MultiAppConfig{Apps: []core.AppConfig{{
AppId: "cli_test", AppSecret: core.PlainSecret("secret"), Brand: core.BrandFeishu,
}}}); err != nil {
t.Fatal(err)
}
f, _, _, _ := cmdutil.TestFactory(t, nil)
cmd := NewCmdConfigRiskControl(f)
cmd.SetArgs([]string{"invalid"})
err := cmd.Execute()
var validationErr *errs.ValidationError
if !errors.As(err, &validationErr) {
t.Fatalf("error = %T %v, want *errs.ValidationError", err, err)
}
if validationErr.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("subtype = %q, want %q", validationErr.Subtype, errs.SubtypeInvalidArgument)
}
}
func TestRiskControlWorkspacePolicyAllowedWithExternalCredentials(t *testing.T) {
f := newConfigFactoryWithExternalProvider(t)
config := &core.MultiAppConfig{Apps: []core.AppConfig{{
AppId: "cli_test", AppSecret: core.PlainSecret("secret"), Brand: core.BrandFeishu,
}}}
if err := core.SaveMultiAppConfig(config); err != nil {
t.Fatal(err)
}
cmd := NewCmdConfig(f)
cmd.SetArgs([]string{"risk-control", "off"})
if err := cmd.Execute(); err != nil {
t.Fatalf("set off with external credentials: %v", err)
}
loaded, err := core.LoadMultiAppConfig()
if err != nil {
t.Fatal(err)
}
if loaded.RiskControl == nil || *loaded.RiskControl {
t.Fatalf("RiskControl = %v, want explicit false", loaded.RiskControl)
}
}

View File

@@ -674,8 +674,8 @@ func installTipsHelpFunc(root *cobra.Command) {
}
}
// Domain and method commands compose their agent guidance into Long lazily
// here and own their complete layout. Shortcuts compose only affordance and
// contract guidance; Risk/Tips still use the common tail below.
// here (shortcuts attach after service registration); both skip the generic
// bottom-of-help append below.
if service.PrepareDomainHelp(cmd, embeddedSkillContent) {
defaultHelp(cmd, args)
return
@@ -686,27 +686,22 @@ func installTipsHelpFunc(root *cobra.Command) {
}
if service.PrepareShortcutHelp(cmd, embeddedSkillContent) {
defaultHelp(cmd, args)
appendRiskTipsHelp(cmd)
return
}
defaultHelp(cmd, args)
appendRiskTipsHelp(cmd)
out := cmd.OutOrStdout()
if level, ok := cmdutil.GetRisk(cmd); ok {
fmt.Fprintln(out)
fmt.Fprintln(out, "Risk:", level)
}
tips := cmdutil.GetTips(cmd)
if len(tips) == 0 {
return
}
fmt.Fprintln(out)
fmt.Fprintln(out, "Tips:")
for _, tip := range tips {
fmt.Fprintf(out, " • %s\n", tip)
}
})
}
func appendRiskTipsHelp(cmd *cobra.Command) {
out := cmd.OutOrStdout()
if level, ok := cmdutil.GetRisk(cmd); ok {
fmt.Fprintln(out)
fmt.Fprintln(out, cmdutil.RiskHelpText(level))
}
tips := cmdutil.GetTips(cmd)
if len(tips) == 0 {
return
}
fmt.Fprintln(out)
fmt.Fprintln(out, "Tips:")
for _, tip := range tips {
fmt.Fprintf(out, " • %s\n", tip)
}
}

View File

@@ -339,9 +339,7 @@ func TestIntegration_StrictModeUser_ProfileOverride_ChatCreateDryRunSucceeds(t *
rootCmd := buildStrictModeIntegrationRootCmd(t, f)
code := executeRootIntegration(t, f, rootCmd, []string{
"im", "+chat-create", "--name", "probe",
"--idempotency-key", "test-secret",
"--dry-run",
"im", "+chat-create", "--name", "probe", "--dry-run",
})
if code != 0 {
@@ -358,9 +356,7 @@ func TestIntegration_StrictModeUser_ProfileOverride_ShortcutExplicitBotReturnsEn
rootCmd := buildStrictModeIntegrationRootCmd(t, f)
code := executeRootIntegration(t, f, rootCmd, []string{
"im", "+chat-create", "--name", "probe",
"--idempotency-key", "test-secret",
"--as", "bot", "--dry-run",
"im", "+chat-create", "--name", "probe", "--as", "bot", "--dry-run",
})
if code != output.ExitValidation {

View File

@@ -8,9 +8,7 @@ import (
"strings"
"testing"
"github.com/larksuite/cli/internal/cmdmeta"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/imcontract"
"github.com/spf13/cobra"
)
@@ -36,10 +34,6 @@ func TestHelpFunc_RendersRiskLineWhenAnnotated(t *testing.T) {
if !strings.Contains(out, "Risk: high-risk-write") {
t.Errorf("expected Risk line in help output, got:\n%s", out)
}
if !strings.Contains(out, "requires explicit user confirmation") ||
!strings.Contains(out, "agent must NOT add --yes") {
t.Errorf("high-risk tail lost its confirmation guard:\n%s", out)
}
}
func TestHelpFunc_NoRiskLineWhenUnannotated(t *testing.T) {
@@ -74,39 +68,3 @@ func TestHelpFunc_RiskLinePrecedesTips(t *testing.T) {
t.Errorf("expected Risk to precede Tips; got Risk@%d, Tips@%d", riskIdx, tipsIdx)
}
}
func TestHelpFunc_PreparedShortcutKeepsContractAndMovesRiskTipsToTail(t *testing.T) {
root := &cobra.Command{Use: "lark-cli"}
installTipsHelpFunc(root)
child := &cobra.Command{
Use: "+chat-list",
Short: "List chats",
Run: func(*cobra.Command, []string) {},
}
cmdmeta.SetSource(child, cmdmeta.SourceShortcut, false)
cmdmeta.SetAffordanceRef(child, "im", "+chat-list")
cmdutil.SetRisk(child, "read")
cmdutil.SetTips(child, []string{"use exhaustive pagination when completeness matters"})
imcontract.AnnotateHelpContract(child, "im +chat-list")
root.AddCommand(child)
out := rendersHelp(t, child)
usageIdx := strings.Index(out, "Usage:")
riskIdx := strings.Index(out, "Risk:")
tipsIdx := strings.Index(out, "Tips:")
if usageIdx == -1 || riskIdx == -1 || tipsIdx == -1 {
t.Fatalf("expected Usage, Risk, and Tips in prepared shortcut help:\n%s", out)
}
if !(usageIdx < riskIdx && riskIdx < tipsIdx) {
t.Fatalf("expected Usage < Risk < Tips; got Usage@%d Risk@%d Tips@%d:\n%s", usageIdx, riskIdx, tipsIdx, out)
}
for _, want := range []string{
imcontract.HelpCompleteness.Text(),
"use exhaustive pagination when completeness matters",
} {
if n := strings.Count(out, want); n != 1 {
t.Fatalf("%q appears %d times, want once:\n%s", want, n, out)
}
}
}

View File

@@ -65,17 +65,7 @@ func offerRootUpgrade(f *cmdutil.Factory, cmd *cobra.Command) {
if info == nil {
return
}
// Deliberately no target version here: info.Latest comes from the on-disk
// cache, which has no expiry (the 24h TTL only throttles refreshes, and a
// failed refresh leaves the old value in place), so it can name a version
// that is no longer the one npm would install. The version actually
// installed is resolved live by the update subcommand, which prints
// "Updating lark-cli <cur> -> <latest> via <pm> ..." before installing —
// that is where the user sees the real target. Keep going through the
// update subcommand rather than calling RunNpmInstall directly, otherwise
// that line disappears and the user approves a global install without ever
// being told what gets installed.
fmt.Fprintf(ios.ErrOut, "A newer lark-cli is available (current %s). Upgrade now? [y/N]: ", info.Current)
fmt.Fprintf(ios.ErrOut, "lark-cli %s available (current %s). Upgrade now? [y/N]: ", info.Latest, info.Current)
if !readYes(ios.In) {
return
}

View File

@@ -128,17 +128,6 @@ func TestOfferRootUpgrade(t *testing.T) {
if gotPrompt != tc.wantPrompt {
t.Errorf("prompt: got %v want %v (stderr=%q)", gotPrompt, tc.wantPrompt, errBuf.String())
}
// The prompt must not name a target version: info.Latest comes from
// the on-disk cache and can be stale, while the version actually
// installed is resolved live by the update subcommand.
if tc.wantPrompt {
if strings.Contains(errBuf.String(), tc.latest) {
t.Errorf("prompt must not name the cached target version %q (stderr=%q)", tc.latest, errBuf.String())
}
if !strings.Contains(errBuf.String(), build.Version) {
t.Errorf("prompt must name the current version %q (stderr=%q)", build.Version, errBuf.String())
}
}
if called != tc.wantRun {
t.Errorf("runRootUpgrade called: got %v want %v", called, tc.wantRun)
}

View File

@@ -12,7 +12,6 @@ import (
"github.com/larksuite/cli/internal/affordance"
"github.com/larksuite/cli/internal/cmdmeta"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/meta"
"github.com/spf13/cobra"
)
@@ -162,7 +161,6 @@ func PrepareMethodHelp(cmd *cobra.Command, skillFS fs.FS) bool {
}
}
writeContractHelp(&b, cmd)
fmt.Fprintf(&b, "\n\nFull parameter schema:\n lark-cli schema %s", schemaPath)
b.WriteString(ann[paramsOnlyAnnotation])
@@ -173,11 +171,11 @@ func PrepareMethodHelp(cmd *cobra.Command, skillFS fs.FS) bool {
}
// PrepareShortcutHelp composes a +-prefixed shortcut's Long from its affordance
// overlay and contract help. Risk and Tips are deliberately not rendered into
// Long: the root help renderer appends them after Usage/Flags for every
// shortcut, so contract-bearing and ordinary shortcuts keep one layout.
// Returns false when the command is not a shortcut or carries neither an
// overlay nor contract help.
// overlay — the same top layout as method help (description, Risk, guidance
// block, related skills) minus the schema pointer, which shortcuts have none
// of. Returns false when the command is not a shortcut or carries no overlay
// entry, so shortcuts without guidance keep the default help plus the bottom
// risk/tips append.
//
// The lead is the command's pristine base (captureHelpBase): a shortcut that
// set a hand-authored Long in PostMount (e.g. the docs shortcuts' "agents MUST
@@ -186,54 +184,38 @@ func PrepareMethodHelp(cmd *cobra.Command, skillFS fs.FS) bool {
//
// Tips precedence (intentional, not a bug): the overlay's ### Tips win. The
// shortcut's declarative Tips (the Go Tips field) are only a fallback used when
// the overlay declares none. The selected list is stored back on the command
// and removed from the affordance block so the root renderer emits it once.
// the overlay declares none; when the overlay has tips, the Go tips are dropped
// (replaced, not merged) so tips never render twice. Authoring a ### Tips block
// therefore silently retires that shortcut's Go Tips — consolidate into one.
func PrepareShortcutHelp(cmd *cobra.Command, skillFS fs.FS) bool {
if src, _ := cmdmeta.SourceOf(cmd); src != cmdmeta.SourceShortcut {
return false
}
var a meta.Affordance
hasAffordance := false
if raw, ok := affordanceRaw(cmd); ok {
if parsed, parsedOK := (meta.Method{Affordance: raw}).ParsedAffordance(); parsedOK {
a = parsed
hasAffordance = true
}
}
contractHelp := imcontract.HelpText(cmd)
if !hasAffordance && contractHelp == "" {
raw, ok := affordanceRaw(cmd)
if !ok {
return false
}
tips := a.Tips
if len(tips) == 0 {
tips = cmdutil.GetTips(cmd)
a, ok := (meta.Method{Affordance: raw}).ParsedAffordance()
if !ok {
return false
}
if len(a.Tips) == 0 {
a.Tips = cmdutil.GetTips(cmd)
}
cmdutil.SetTips(cmd, tips)
a.Tips = nil
var b strings.Builder
b.WriteString(captureHelpBase(cmd, shortcutBaseAnnotation))
writeRisk(&b, cmd)
if block := renderAffordanceValue(a); block != "" {
b.WriteString("\n\n")
b.WriteString(block)
}
if contractHelp != "" {
b.WriteString("\n\n")
b.WriteString(contractHelp)
}
writeRelatedSkills(&b, a.Skills, skillFS)
cmd.Long = b.String()
return true
}
func writeContractHelp(b *strings.Builder, cmd *cobra.Command) {
if text := imcontract.HelpText(cmd); text != "" {
b.WriteString("\n\n")
b.WriteString(text)
}
}
// writeRisk appends the "Risk: <level>" line, warning agents not to self-approve
// high-risk-write commands. A no-op when the command has no risk annotation.
func writeRisk(b *strings.Builder, cmd *cobra.Command) {
@@ -241,7 +223,12 @@ func writeRisk(b *strings.Builder, cmd *cobra.Command) {
if !ok {
return
}
fmt.Fprintf(b, "\n\n%s", cmdutil.RiskHelpText(level))
// --yes asserts the USER confirmed; the agent must not self-approve.
if level == cmdutil.RiskHighRiskWrite {
fmt.Fprintf(b, "\n\nRisk: %s (requires explicit user confirmation to execute; the agent must NOT add --yes on its own — only pass --yes after the user has confirmed)", level)
} else {
fmt.Fprintf(b, "\n\nRisk: %s", level)
}
}
// writeRelatedSkills appends the "Related skills" block for the entries that

View File

@@ -11,7 +11,6 @@ import (
"github.com/larksuite/cli/internal/cmdmeta"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/meta"
"github.com/spf13/cobra"
)
@@ -143,75 +142,10 @@ func TestPrepareMethodHelp(t *testing.T) {
}
}
func TestPrepareMethodHelpPreservesAffordanceAndAddsContractOnce(t *testing.T) {
orig := affordanceLookup
t.Cleanup(func() { affordanceLookup = orig })
affordanceLookup = func(_, _ string) (json.RawMessage, bool) {
return json.RawMessage(`{
"use_when":["forward one message"],
"avoid_when":["a new send is required"],
"prerequisites":["source message is visible"],
"examples":[{"description":"forward","command":"lark-cli im messages forward ..."}],
"skills":["lark-im"]
}`), true
}
skillFS := fstest.MapFS{"lark-im/SKILL.md": {Data: []byte("# IM")}}
f, _, _, _ := cmdutil.TestFactory(t, testConfig)
m := map[string]interface{}{
"id": "chat.moderation.update", "path": "chats/{chat_id}/moderation", "httpMethod": "PUT", "description": "Update moderation",
}
cmd := NewCmdServiceMethod(f, imSpec(), meta.FromMap(m), "update", "chat.moderation", nil)
if strings.Contains(cmd.Long, imcontract.HelpAcceptanceOnly.Text()) {
t.Fatalf("contract help must stay lazy at build time:\n%s", cmd.Long)
}
for range 2 {
if !PrepareMethodHelp(cmd, skillFS) {
t.Fatal("PrepareMethodHelp returned false")
}
}
for _, want := range []string{
"When to use:", "Avoid when:", "Prerequisites:", "Examples:",
"Related skills", "Full parameter schema:",
imcontract.HelpAcceptanceOnly.Text(),
} {
if n := strings.Count(cmd.Long, want); n != 1 {
t.Fatalf("%q appears %d times, want once:\n%s", want, n, cmd.Long)
}
}
contractAt := strings.Index(cmd.Long, imcontract.HelpAcceptanceOnly.Text())
schemaAt := strings.Index(cmd.Long, "Full parameter schema:")
if contractAt < 0 || schemaAt < 0 || contractAt > schemaAt {
t.Fatalf("contract help must precede schema pointer:\n%s", cmd.Long)
}
}
func TestModerationGetHelpAdvertisesPaginationCompleteness(t *testing.T) {
f, _, _, _ := cmdutil.TestFactory(t, testConfig)
m := map[string]interface{}{
"id": "chat.moderation.get", "path": "chats/{chat_id}/moderation", "httpMethod": "GET",
"description": "Get moderation", "risk": "read",
"parameters": map[string]interface{}{
"chat_id": map[string]interface{}{"type": "string", "location": "path", "required": true},
"page_token": map[string]interface{}{"type": "string", "location": "query"},
},
}
cmd := NewCmdServiceMethod(f, imSpec(), meta.FromMap(m), "get", "chat.moderation", nil)
if flag := cmd.Flags().Lookup("page-all"); flag == nil || flag.Hidden {
t.Fatalf("moderation get must expose --page-all: %#v", flag)
}
if !PrepareMethodHelp(cmd, nil) {
t.Fatal("PrepareMethodHelp returned false")
}
if !strings.Contains(cmd.Long, imcontract.HelpCompleteness.Text()) {
t.Fatalf("moderation get help omitted completeness contract:\n%s", cmd.Long)
}
}
// PrepareShortcutHelp composes a shortcut's Long from its overlay (without a
// schema pointer), preserves the selected tips on the command for the root help
// renderer, and leaves shortcuts without an overlay entry (and non-shortcut
// commands) for the default help path.
// PrepareShortcutHelp composes a shortcut's Long from its overlay with the same
// top layout as method help (no schema pointer), folding declarative tips when
// the overlay declares none, and leaves shortcuts without an overlay entry (and
// non-shortcut commands) for the default help path.
func TestPrepareShortcutHelp(t *testing.T) {
orig := affordanceLookup
t.Cleanup(func() { affordanceLookup = orig })
@@ -231,19 +165,11 @@ func TestPrepareShortcutHelp(t *testing.T) {
if !PrepareShortcutHelp(sc, nil) {
t.Fatal("PrepareShortcutHelp returned false for a shortcut with an overlay")
}
for _, want := range []string{"Create an event", "When to use:", "高层创建日程"} {
for _, want := range []string{"Create an event", "Risk: write", "When to use:", "高层创建日程", "Tips:", "start/end 收 ISO 8601"} {
if !strings.Contains(sc.Long, want) {
t.Errorf("shortcut Long missing %q:\n%s", want, sc.Long)
}
}
for _, unwanted := range []string{"Risk: write", "Tips:", "start/end 收 ISO 8601"} {
if strings.Contains(sc.Long, unwanted) {
t.Errorf("shortcut Long must leave %q for the root tail renderer:\n%s", unwanted, sc.Long)
}
}
if got := cmdutil.GetTips(sc); len(got) != 1 || got[0] != "start/end 收 ISO 8601" {
t.Fatalf("shortcut tips = %#v, want the declarative tip preserved for tail rendering", got)
}
if strings.Contains(sc.Long, "Full parameter schema:") {
t.Errorf("shortcut Long must not carry a schema pointer:\n%s", sc.Long)
}
@@ -264,54 +190,6 @@ func TestPrepareShortcutHelp(t *testing.T) {
}
}
func TestPrepareShortcutHelpStoresOverlayTipsForTailOnce(t *testing.T) {
orig := affordanceLookup
t.Cleanup(func() { affordanceLookup = orig })
affordanceLookup = func(_, _ string) (json.RawMessage, bool) {
return json.RawMessage(`{"use_when":["create"],"tips":["overlay tip"]}`), true
}
sc := &cobra.Command{Use: "+create", Short: "Create"}
cmdmeta.SetSource(sc, cmdmeta.SourceShortcut, false)
cmdmeta.SetAffordanceRef(sc, "calendar", "+create")
cmdutil.SetTips(sc, []string{"declarative tip"})
for range 2 {
if !PrepareShortcutHelp(sc, nil) {
t.Fatal("PrepareShortcutHelp returned false")
}
}
if strings.Contains(sc.Long, "overlay tip") || strings.Contains(sc.Long, "Tips:") {
t.Fatalf("overlay tips must be left for the common tail renderer:\n%s", sc.Long)
}
if got := cmdutil.GetTips(sc); len(got) != 1 || got[0] != "overlay tip" {
t.Fatalf("tips = %#v, want overlay tip once", got)
}
}
func TestPrepareShortcutHelpAddsContractWithoutAffordance(t *testing.T) {
sc := &cobra.Command{
Use: "+chat-list", Short: "List chats",
Run: func(*cobra.Command, []string) {},
}
cmdmeta.SetSource(sc, cmdmeta.SourceShortcut, false)
cmdmeta.SetAffordanceRef(sc, "im", "+chat-list")
cmdutil.SetRisk(sc, "read")
imcontract.AnnotateHelpContract(sc, "im +chat-list")
for range 2 {
if !PrepareShortcutHelp(sc, nil) {
t.Fatal("PrepareShortcutHelp returned false for contract-bearing shortcut")
}
}
if n := strings.Count(sc.Long, imcontract.HelpCompleteness.Text()); n != 1 {
t.Fatalf("contract help appears %d times, want once:\n%s", n, sc.Long)
}
if sc.Short != "List chats" || !strings.HasPrefix(sc.Long, "List chats") {
t.Fatalf("visible description changed: Short=%q Long=%q", sc.Short, sc.Long)
}
}
// Related-skill pointers are gated on existence: a skill that resolves in the
// skill FS renders, a typo is dropped (never print an unopenable `skills read`),
// and a nil skill FS suppresses the whole block.

View File

@@ -19,7 +19,6 @@ import (
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/credential"
"github.com/larksuite/cli/internal/errclass"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/meta"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/internal/registry"
@@ -131,7 +130,6 @@ type ServiceMethodOptions struct {
ServicePath string
Method meta.Method
SchemaPath string
ContractKey imcontract.ContractKey
// Flags
Params string
@@ -147,9 +145,6 @@ type ServiceMethodOptions struct {
File string // --file flag value
FileFields []string // auto-detected file field names from metadata
identityDefaulted bool
identityWarningSent bool
// binder owns the generated typed param flags — registration and the
// --params overlay — replacing the raw paramFlags side-channel.
binder *paramFlagBinder
@@ -208,7 +203,6 @@ type methodCommandSpec struct {
declaresBody bool
paginates bool // method accepts a page_token param (so --page-all is meaningful)
serviceName string // owning service name (e.g. "approval"), for the lazy affordance lookup
contractKey imcontract.ContractKey
}
// methodPaginates reports whether a method takes a page_token param, the signal
@@ -224,7 +218,7 @@ func methodPaginates(m meta.Method) bool {
func newMethodCommandSpec(ref apicatalog.MethodRef) methodCommandSpec {
m := ref.Method
spec := methodCommandSpec{
return methodCommandSpec{
method: m,
schemaPath: ref.SchemaPath(),
servicePath: ref.Service.ServicePath,
@@ -238,19 +232,6 @@ func newMethodCommandSpec(ref apicatalog.MethodRef) methodCommandSpec {
declaresBody: len(m.Data()) > 0 || len(m.Files()) > 0,
paginates: methodPaginates(m),
}
spec.contractKey = generatedContractKey(ref.Service.Name, m.ID)
return spec
}
func generatedContractKey(serviceName, methodID string) imcontract.ContractKey {
if serviceName != "im" || methodID == "" {
return ""
}
i := strings.LastIndex(methodID, ".")
if i < 0 {
return ""
}
return imcontract.ContractKey(serviceName + " " + methodID[:i] + " " + methodID[i+1:])
}
// methodTakesBody reports whether the HTTP method allows a request body, i.e.
@@ -274,7 +255,6 @@ func buildMethodCommand(ctx context.Context, f *cmdutil.Factory, spec methodComm
ServicePath: spec.servicePath,
Method: m,
SchemaPath: spec.schemaPath,
ContractKey: spec.contractKey,
FileFields: spec.fileFields,
}
var asStr string
@@ -341,7 +321,6 @@ func buildMethodCommand(ctx context.Context, f *cmdutil.Factory, spec methodComm
paramsOnly := opts.binder.paramsOnlyHelp()
cmd.Long = methodLong(m.Description, spec.schemaPath, paramsOnly)
setMethodHelpData(cmd, spec.serviceName, m.ID, spec.schemaPath, paramsOnly)
imcontract.AnnotateHelpContract(cmd, spec.contractKey)
// Group flags for the grouped --help renderer (typed param flags are grouped
// as API Parameters by the binder). tagFlagGroup is a no-op for flags not
@@ -385,15 +364,6 @@ func buildMethodCommand(ctx context.Context, f *cmdutil.Factory, spec methodComm
func serviceMethodRun(opts *ServiceMethodOptions) error {
f := opts.Factory
contract, contractFound := imcontract.Lookup(opts.ContractKey)
contractManagedWrite := contractFound && contract.Strategy.Kind.IsWrite()
contractManagedRead := contractFound && contract.Strategy.Kind.IsRead()
if contractManagedRead && opts.PageAll &&
contract.Strategy.Kind != imcontract.CollectionReadKind &&
contract.Strategy.Kind != imcontract.SearchReadKind {
return newIMReadPageAllValidationError()
}
opts.As = f.ResolveAs(opts.Ctx, opts.Cmd, opts.As)
if err := f.CheckStrictMode(opts.Ctx, opts.As); err != nil {
@@ -406,11 +376,6 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
return err
}
}
opts.identityDefaulted = contractManagedWrite &&
serviceMethodSupportsUserAndBot(opts.Method) &&
!serviceIdentityFlagChanged(opts.Cmd) &&
f.IdentityAutoDetected &&
!f.ResolveStrictMode(opts.Ctx).IsActive()
if opts.PageAll && opts.Output != "" {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--output and --page-all are mutually exclusive").WithParam("--output")
@@ -418,12 +383,6 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
if err := output.ValidateJqFlags(opts.JqExpr, opts.Output, opts.Format); err != nil {
return err
}
if contractManagedWrite && opts.Output != "" {
return errs.NewValidationError(errs.SubtypeInvalidArgument,
"--output is not supported for contract-managed IM write commands").
WithParam("--output").
WithHint("remove --output; read the completion result from stdout")
}
config, err := f.Config()
if err != nil {
@@ -441,8 +400,8 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
if err != nil {
return err
}
if opts.DryRun {
warnServiceIdentityDefaulted(opts)
if fileMeta != nil {
return cmdutil.PrintDryRunWithFile(request, config, serviceDryRunOutputOptions(f, opts), *fileMeta)
}
@@ -470,61 +429,16 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
// errclass.BuildAPIError via ac.CheckResponse, producing *errs.PermissionError
// with MissingScopes / Identity / ConsoleURL populated from the response.
checkErr := ac.CheckResponse
var contractSession *imcontract.Session
if contractManagedWrite {
contractSession = imcontract.NewSession(contract)
requestBody, _ := request.Data.(map[string]any)
if uuid, ok := request.Params["uuid"].(string); ok && uuid != "" {
cloned := make(map[string]any, len(requestBody)+1)
for key, value := range requestBody {
cloned[key] = value
}
cloned["uuid"] = uuid
requestBody = cloned
}
if err := contractSession.ObserveRequest(requestBody); err != nil {
return err
}
}
var readSession *imcontract.ReadSession
if contractManagedRead {
readSession, err = imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: opts.PageAll})
if err != nil {
return err
}
}
if opts.PageAll {
if contractSession != nil {
return errs.NewValidationError(errs.SubtypeInvalidArgument,
"--page-all is not valid for an IM write command").WithParam("--page-all")
}
if readSession != nil {
return servicePaginateIMRead(opts, ac, &request, format, readSession)
}
return servicePaginate(opts.Ctx, ac, request, format, opts.JqExpr, out, f.IOStreams.ErrOut, opts.Cmd.CommandPath(),
client.PaginationOptions{PageLimit: opts.PageLimit, PageDelay: opts.PageDelay}, checkErr)
}
if contractSession != nil {
contractSession.RecordFact(imcontract.Fact{Kind: imcontract.FactWriteAttempted})
}
resp, err := ac.DoAPI(opts.Ctx, request)
if err != nil {
if contractSession != nil {
return contractSession.FinalizeError(normalizeIMContractJSONError(err))
}
if readSession != nil {
return readSession.FinalizeError(normalizeIMContractJSONError(err))
}
return err
}
if contractSession != nil {
return handleIMWriteContractResponse(opts, resp, format, checkErr, contractSession)
}
if readSession != nil {
return handleIMReadContractResponse(opts, resp, format, checkErr, readSession, request)
}
return client.HandleResponse(resp, client.ResponseOptions{
OutputPath: opts.Output,
Format: format,
@@ -538,403 +452,6 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
})
}
func handleIMReadContractResponse(
opts *ServiceMethodOptions,
resp *larkcore.ApiResp,
format output.Format,
checkErr func(interface{}, core.Identity) error,
session *imcontract.ReadSession,
request client.RawApiRequest,
) error {
responseOpts := client.ResponseOptions{
OutputPath: opts.Output,
Format: format,
JqExpr: opts.JqExpr,
Out: opts.Factory.IOStreams.Out,
ErrOut: opts.Factory.IOStreams.ErrOut,
FileIO: opts.Factory.ResolveFileIO(opts.Ctx),
CommandPath: opts.Cmd.CommandPath(),
Identity: opts.As,
CheckError: checkErr,
}
if resp.StatusCode >= 400 {
responseErr := client.HandleResponse(resp, responseOpts)
responseErr = imcontract.NormalizeHTTPError(
resp.StatusCode,
resp.Header.Get("x-tt-logid"),
responseErr,
)
return session.FinalizeError(responseErr)
}
parsed, err := parseIMContractJSONResponse(resp)
if err != nil {
return session.FinalizeError(err)
}
if apiErr := checkErr(parsed, opts.As); apiErr != nil {
return session.FinalizeError(apiErr)
}
data := output.SuccessEnvelopeData(parsed)
if session.RequiresPagination() {
status, _ := client.InspectPaginationPage(parsed, requestStringParam(request.Params, "page_token"))
session.ObservePagination(status)
}
result, err := session.Finalize(data)
if err != nil {
return err
}
return writeIMReadResult(opts, format, result, parsed)
}
func servicePaginateIMRead(
opts *ServiceMethodOptions,
ac *client.APIClient,
request *client.RawApiRequest,
format output.Format,
session *imcontract.ReadSession,
) error {
if session == nil {
return errs.NewInternalError(errs.SubtypeInvalidResponse, "IM paginated read requires a read session")
}
if !session.RequiresPagination() {
return newIMReadPageAllValidationError()
}
pagOpts := client.PaginationOptions{
PageLimit: opts.PageLimit,
PageDelay: opts.PageDelay,
Identity: opts.As,
NormalizeHTTPError: imcontract.NormalizeHTTPError,
}
if opts.JqExpr == "" && (format == output.FormatNDJSON || format == output.FormatTable || format == output.FormatCSV) {
return streamIMReadPages(opts, ac, request, format, session, pagOpts)
}
merged, status, _ := ac.PaginateAllWithStatus(opts.Ctx, request, pagOpts)
session.ObservePagination(status)
data := output.SuccessEnvelopeData(merged)
result, err := session.Finalize(data)
if err != nil {
return err
}
return writeIMReadResult(opts, format, result, merged)
}
func newIMReadPageAllValidationError() error {
return errs.NewValidationError(
errs.SubtypeInvalidArgument,
"--page-all is not valid for this IM read command",
).WithParam("--page-all")
}
func streamIMReadPages(
opts *ServiceMethodOptions,
ac *client.APIClient,
request *client.RawApiRequest,
format output.Format,
session *imcontract.ReadSession,
pagOpts client.PaginationOptions,
) error {
errOut := opts.Factory.IOStreams.ErrOut
emitter := newIMServiceEmitter(opts)
var firstPage map[string]interface{}
hasItems := false
status, pageErr := ac.StreamPagesWithStatus(opts.Ctx, request, pagOpts, func(page map[string]interface{}) error {
if firstPage == nil {
firstPage = page
}
data, _ := page["data"].(map[string]interface{})
arrayField := output.FindArrayField(data)
if arrayField == "" {
return nil
}
items, _ := data[arrayField].([]interface{})
hasItems = true
return emitter.StreamPage(items, output.StreamOptions{Format: format.String()})
})
if pageErr != nil && status.StopReason == "" {
return session.FinalizeError(pageErr)
}
session.ObservePagination(status)
result, err := session.Finalize(map[string]interface{}{})
if err != nil {
return err
}
if !hasItems && firstPage != nil {
fmt.Fprintf(errOut, "warning: this API does not return a list, format %q is not supported, falling back to json\n", format)
if writeErr := emitIMServiceResult(
opts,
output.FormatJSON,
output.SuccessEnvelopeData(firstPage),
result.OK,
result.Meta,
result.Error,
result.Hint,
false,
); writeErr != nil {
return writeErr
}
} else if err := emitter.Hint(result.Hint); err != nil {
return err
}
return readResultExit(result)
}
func writeIMReadResult(
opts *ServiceMethodOptions,
format output.Format,
result imcontract.ReadResult,
presentation interface{},
) error {
if opts.JqExpr != "" || format == output.FormatJSON {
if err := emitIMServiceResult(
opts,
format,
result.Data,
result.OK,
result.Meta,
result.Error,
result.Hint,
true,
); err != nil {
return err
}
return readResultExitForProjection(result, opts.JqExpr != "")
}
if err := emitIMServiceResult(
opts,
format,
presentation,
result.OK,
result.Meta,
result.Error,
result.Hint,
false,
); err != nil {
return err
}
return readResultExitForProjection(result, true)
}
func newIMServiceEmitter(opts *ServiceMethodOptions) *output.Emitter {
return output.NewEmitter(output.EmitterConfig{
Out: opts.Factory.IOStreams.Out,
ErrOut: opts.Factory.IOStreams.ErrOut,
CommandPath: opts.Cmd.CommandPath(),
Identity: string(opts.As),
NoticeProvider: func() map[string]interface{} {
base := output.GetNotice()
if !opts.identityDefaulted {
return base
}
return imcontract.WithIdentityDefaultedNotice(base, string(opts.As))
},
})
}
func emitIMServiceResult(
opts *ServiceMethodOptions,
format output.Format,
data interface{},
ok bool,
meta *output.Meta,
resultError *errs.Problem,
hint string,
projectedRead bool,
) error {
warnServiceIdentityDefaulted(opts)
var errorValue interface{}
if resultError != nil {
errorValue = resultError
}
emitOpts := output.EmitOptions{
Format: format.String(),
JQ: opts.JqExpr,
Meta: meta,
Error: errorValue,
Hint: hint,
HintToStderr: hint != "" &&
((projectedRead && opts.JqExpr != "") ||
(opts.JqExpr == "" && format != output.FormatJSON)),
}
emitter := newIMServiceEmitter(opts)
if !ok && (opts.JqExpr != "" || format == output.FormatJSON) {
return emitter.PartialFailure(data, emitOpts)
}
return emitter.Success(data, emitOpts)
}
func serviceMethodSupportsUserAndBot(method meta.Method) bool {
return method.SupportsToken(meta.TokenUser) && method.SupportsToken(meta.TokenTenant)
}
func serviceIdentityFlagChanged(cmd *cobra.Command) bool {
return cmd != nil && cmd.Flags().Changed("as")
}
func warnServiceIdentityDefaulted(opts *ServiceMethodOptions) {
if opts == nil || !opts.identityDefaulted || opts.identityWarningSent {
return
}
opts.identityWarningSent = true
fmt.Fprintf(opts.Factory.IOStreams.ErrOut, "warning: %s: %s\n",
imcontract.IdentityDefaultedNoticeKey,
imcontract.IdentityDefaultedMessage(string(opts.As)))
}
func readResultExit(result imcontract.ReadResult) error {
if result.ExitCode == 0 {
return nil
}
if result.Cause != nil {
return result.Cause
}
return output.PartialFailure(result.ExitCode)
}
func readResultExitForProjection(result imcontract.ReadResult, projected bool) error {
if result.ExitCode == 0 {
return nil
}
if projected && result.Cause != nil {
return result.Cause
}
return output.PartialFailure(result.ExitCode)
}
func requestStringParam(params map[string]interface{}, name string) string {
value, _ := params[name].(string)
return value
}
func handleIMWriteContractResponse(
opts *ServiceMethodOptions,
resp *larkcore.ApiResp,
format output.Format,
checkErr func(interface{}, core.Identity) error,
session *imcontract.Session,
) error {
responseOpts := client.ResponseOptions{
OutputPath: opts.Output,
Format: format,
JqExpr: opts.JqExpr,
Out: opts.Factory.IOStreams.Out,
ErrOut: opts.Factory.IOStreams.ErrOut,
FileIO: opts.Factory.ResolveFileIO(opts.Ctx),
CommandPath: opts.Cmd.CommandPath(),
Identity: opts.As,
CheckError: checkErr,
}
if resp.StatusCode >= 400 {
responseErr := client.HandleResponse(resp, responseOpts)
responseErr = imcontract.NormalizeHTTPError(
resp.StatusCode,
resp.Header.Get("x-tt-logid"),
responseErr,
)
return session.FinalizeError(responseErr)
}
parsed, err := parseIMContractJSONResponse(resp)
if err != nil {
return session.FinalizeError(err)
}
if apiErr := checkErr(parsed, opts.As); apiErr != nil {
return session.FinalizeError(apiErr)
}
data := output.SuccessEnvelopeData(parsed)
if m, ok := data.(map[string]any); ok {
session.ObserveResponse(m)
}
result, err := session.FinalizeSuccess(data)
if err != nil {
return err
}
emitErr := emitIMServiceResult(
opts,
format,
result.Data,
result.OK,
nil,
nil,
result.Hint,
false,
)
if emitErr != nil {
if errs.IsContentSafety(emitErr) {
return writeIMContentSafetyFallback(opts, result)
}
if opts.JqExpr != "" {
writeIMJQDiagnostic(opts.Factory.IOStreams.ErrOut)
return writeIMJQFallback(opts, result)
}
return emitErr
}
if result.ExitCode != 0 {
return output.PartialFailure(result.ExitCode)
}
return nil
}
func parseIMContractJSONResponse(resp *larkcore.ApiResp) (interface{}, error) {
if resp == nil {
return nil, newIMContractJSONResponseError(resp)
}
parsed, err := client.ParseJSONResponse(resp)
if err != nil {
return nil, newIMContractJSONResponseError(resp)
}
return parsed, nil
}
func newIMContractJSONResponseError(resp *larkcore.ApiResp) *errs.InternalError {
contractErr := errs.NewInternalError(
errs.SubtypeInvalidResponse,
"IM contract response must be valid JSON",
)
if resp == nil {
return contractErr
}
if logID := resp.Header.Get("x-tt-logid"); logID != "" {
contractErr.WithLogID(logID)
}
return contractErr
}
func normalizeIMContractJSONError(err error) error {
problem, ok := errs.ProblemOf(err)
if ok && problem.Subtype == errs.SubtypeInvalidResponse {
normalized := newIMContractJSONResponseError(nil)
if problem.Code != 0 {
normalized.WithCode(problem.Code)
}
if problem.LogID != "" {
normalized.WithLogID(problem.LogID)
}
return normalized
}
return err
}
func writeIMJQFallback(opts *ServiceMethodOptions, result imcontract.Result) error {
env, signal := imcontract.BuildJQOutputFallback(result)
if err := newIMServiceEmitter(opts).RedactedFallback(env); err != nil {
return err
}
return signal
}
func writeIMJQDiagnostic(errOut io.Writer) {
fmt.Fprintln(errOut, "error: jq projection failed after the IM write completed; inspect --jq")
}
func writeIMContentSafetyFallback(opts *ServiceMethodOptions, result imcontract.Result) error {
env, signal := imcontract.BuildContentSafetyOutputFallback(result)
if err := newIMServiceEmitter(opts).RedactedFallback(env); err != nil {
return err
}
return signal
}
// checkServiceScopes pre-checks user scopes before making the API call.
func checkServiceScopes(ctx context.Context, cred *credential.CredentialProvider, identity core.Identity, config *core.CliConfig, method meta.Method) error {
if ctx.Err() != nil {
@@ -1162,13 +679,6 @@ func serviceDryRunOutputOptions(f *cmdutil.Factory, opts *ServiceMethodOptions)
Identity: opts.As,
Out: f.IOStreams.Out,
ErrOut: f.IOStreams.ErrOut,
NoticeProvider: func() map[string]interface{} {
base := output.GetNotice()
if !opts.identityDefaulted {
return base
}
return imcontract.WithIdentityDefaultedNotice(base, string(opts.As))
},
}
}

File diff suppressed because it is too large Load Diff

View File

@@ -1,98 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package affordance
import (
"encoding/json"
"os"
"strings"
"testing"
)
// The 21 im raw-API methods that affordance/im.md must cover: 17 first-batch
// methods plus 4 "prefer the shortcut" entries. Keys follow the parsed heading
// form (spaces become dots), same as TestFor's fixture keys.
var imAffordanceMethods = []string{
"chat.members.create", "chat.members.delete", "chat.members.get", "chat.members.bots",
"messages.forward", "messages.delete", "messages.merge_forward", "messages.read_users",
"reactions.create", "reactions.delete", "reactions.list", "reactions.batch_query",
"pins.create", "pins.delete", "pins.list",
"images.create",
"threads.forward",
"chats.get", "chats.update", "chats.create", "chats.link",
}
type parsedAffordance struct {
UseWhen []string `json:"use_when"`
AvoidWhen []string `json:"avoid_when"`
Prerequisites []string `json:"prerequisites"`
Examples []struct {
Command string `json:"command"`
} `json:"examples"`
}
// TestForIMRealFile parses the real affordance/im.md through the production
// parser and asserts coverage plus depth on the showcase method.
func TestForIMRealFile(t *testing.T) {
prev := mdSource
t.Cleanup(func() { SetSource(prev) })
SetSource(os.DirFS("../../affordance"))
for _, m := range imAffordanceMethods {
raw, ok := For("im", m)
if !ok {
t.Errorf("For(\"im\", %q) ok=false, want an overlay section in affordance/im.md", m)
continue
}
var a parsedAffordance
if err := json.Unmarshal(raw, &a); err != nil {
t.Errorf("%s: overlay is not valid affordance JSON: %v", m, err)
continue
}
if len(a.UseWhen) == 0 {
t.Errorf("%s: missing lead paragraph (use_when)", m)
}
if len(a.AvoidWhen) == 0 {
t.Errorf("%s: missing Avoid when section", m)
}
if len(a.Examples) == 0 || a.Examples[0].Command == "" {
t.Errorf("%s: missing fenced example command", m)
continue
}
// Each example must invoke the section's own command, so a heading
// can't silently drift apart from the command its examples show.
// Normalize the example's command words (before the first flag) the
// same way headings become keys: spaces join with dots.
words := strings.Fields(strings.TrimPrefix(a.Examples[0].Command, "lark-cli im "))
var cmdWords []string
for _, w := range words {
if strings.HasPrefix(w, "-") {
break
}
cmdWords = append(cmdWords, w)
}
if got := strings.Join(cmdWords, "."); got != m {
t.Errorf("%s: first example %q invokes %q, want the section's own command", m, a.Examples[0].Command, got)
}
}
// Showcase depth: messages forward (the deepest overlay section).
raw, ok := For("im", "messages.forward")
if !ok {
t.Fatal("messages.forward overlay missing")
}
var fwd parsedAffordance
if err := json.Unmarshal(raw, &fwd); err != nil {
t.Fatalf("messages.forward overlay invalid: %v", err)
}
if len(fwd.AvoidWhen) < 3 {
t.Errorf("messages.forward: want >=3 avoid_when entries, got %d", len(fwd.AvoidWhen))
}
if len(fwd.Prerequisites) < 2 {
t.Errorf("messages.forward: want >=2 prerequisites, got %d", len(fwd.Prerequisites))
}
if len(fwd.Examples) < 1 || fwd.Examples[0].Command == "" {
t.Errorf("messages.forward: want >=1 fenced example command")
}
}

View File

@@ -13,10 +13,9 @@ import (
// PaginationOptions contains pagination control options.
type PaginationOptions struct {
PageLimit int // max pages to fetch; 0 = unlimited (default: 10)
PageDelay int // ms, default 200
Identity core.Identity // identity passed to checkErr; defaults to AsUser when empty
NormalizeHTTPError func(status int, logID string, err error) error
PageLimit int // max pages to fetch; 0 = unlimited (default: 10)
PageDelay int // ms, default 200
Identity core.Identity // identity passed to checkErr; defaults to AsUser when empty
}
func mergePagedResults(w io.Writer, results []interface{}) interface{} {

View File

@@ -1,305 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package client
import (
"context"
"io"
"time"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/core"
)
// StopReason describes the neutral fact that stopped a pagination attempt.
// Business domains decide whether a given reason means success or failure.
type StopReason string
const (
StopReasonExhausted StopReason = "exhausted"
StopReasonSinglePage StopReason = "single_page"
StopReasonPageLimit StopReason = "page_limit"
StopReasonStartPageToken StopReason = "start_page_token"
StopReasonTransportError StopReason = "transport_error"
StopReasonAPIError StopReason = "api_error"
StopReasonMissingToken StopReason = "missing_token"
StopReasonRepeatedToken StopReason = "repeated_token"
StopReasonServerTruncation StopReason = "server_truncation"
)
// PaginationStatus contains pagination facts without interpreting completeness.
// Cause is process-local diagnostic context and must never be serialized.
type PaginationStatus struct {
PagesFetched int `json:"pages_fetched,omitempty"`
HasMore bool `json:"has_more,omitempty"`
NextPageToken string `json:"next_page_token,omitempty"`
StopReason StopReason `json:"stop_reason,omitempty"`
Cause error `json:"-"`
}
// InspectPaginationPage derives status from one already-fetched page.
// It is useful for callers that intentionally perform a single-page read.
func InspectPaginationPage(result interface{}, startPageToken string) (PaginationStatus, error) {
status := PaginationStatus{PagesFetched: 1}
hasMore, nextToken, truncated := paginationFacts(result)
status.HasMore = hasMore
status.NextPageToken = nextToken
if truncated {
status.StopReason = StopReasonServerTruncation
return status, nil
}
if hasMore && nextToken == "" {
err := missingPaginationTokenError()
status.StopReason = StopReasonMissingToken
status.Cause = err
return status, err
}
if hasMore && startPageToken != "" && nextToken == startPageToken {
err := repeatedPaginationTokenError()
status.StopReason = StopReasonRepeatedToken
status.Cause = err
return status, err
}
if startPageToken != "" {
status.StopReason = StopReasonStartPageToken
return status, nil
}
if hasMore {
status.StopReason = StopReasonSinglePage
return status, nil
}
status.StopReason = StopReasonExhausted
return status, nil
}
// PaginateAllWithStatus fetches pages until a neutral stop condition occurs.
// Unlike PaginateAll, later failures are returned together with already-fetched
// data so an opt-in caller can report an incomplete result without losing it.
func (c *APIClient) PaginateAllWithStatus(
ctx context.Context,
request *RawApiRequest,
opts PaginationOptions,
) (map[string]interface{}, PaginationStatus, error) {
results, status, err := c.paginateLoopWithStatus(ctx, request, opts, nil)
return mergeStatusResults(io.Discard, results), status, err
}
// StreamPagesWithStatus emits each successful raw page and returns the neutral
// stop status. A later failure does not retract pages already emitted.
func (c *APIClient) StreamPagesWithStatus(
ctx context.Context,
request *RawApiRequest,
opts PaginationOptions,
emit func(page map[string]interface{}) error,
) (PaginationStatus, error) {
_, status, err := c.paginateLoopWithStatus(ctx, request, opts, emit)
return status, err
}
func (c *APIClient) paginateLoopWithStatus(
ctx context.Context,
request *RawApiRequest,
opts PaginationOptions,
emit func(page map[string]interface{}) error,
) ([]interface{}, PaginationStatus, error) {
if request == nil {
err := errs.NewInternalError(errs.SubtypeInvalidResponse, "pagination request is nil")
return nil, PaginationStatus{Cause: err}, err
}
var results []interface{}
status := PaginationStatus{}
nextToken := stringParam(request.Params, "page_token")
startPageToken := nextToken
seenTokens := make(map[string]struct{})
if nextToken != "" {
seenTokens[nextToken] = struct{}{}
}
pageDelay := opts.PageDelay
if pageDelay == 0 {
pageDelay = 200
}
for {
params := cloneParams(request.Params)
if nextToken != "" {
params["page_token"] = nextToken
}
resp, err := c.DoAPI(ctx, RawApiRequest{
Method: request.Method,
URL: request.URL,
Params: params,
Data: request.Data,
As: request.As,
ExtraOpts: request.ExtraOpts,
})
if err != nil {
status.StopReason = StopReasonTransportError
status.Cause = err
status.HasMore = nextToken != ""
status.NextPageToken = nextToken
return results, status, err
}
result, err := ParseJSONResponse(resp)
if err != nil {
err = WrapJSONResponseParseError(err, resp.RawBody)
if opts.NormalizeHTTPError != nil && resp.StatusCode >= 400 {
err = opts.NormalizeHTTPError(resp.StatusCode, streamLogID(resp.Header), err)
}
status.StopReason = StopReasonTransportError
status.Cause = err
status.HasMore = nextToken != ""
status.NextPageToken = nextToken
return results, status, err
}
identity := opts.Identity
if identity == "" {
identity = request.As
}
if identity == "" {
identity = core.AsUser
}
apiErr := c.CheckResponse(result, identity)
if opts.NormalizeHTTPError != nil && resp.StatusCode >= 400 {
apiErr = opts.NormalizeHTTPError(resp.StatusCode, streamLogID(resp.Header), apiErr)
}
if apiErr != nil {
status.StopReason = StopReasonAPIError
status.Cause = apiErr
status.HasMore = nextToken != ""
status.NextPageToken = nextToken
return results, status, apiErr
}
page, ok := result.(map[string]interface{})
if !ok {
err := errs.NewInternalError(errs.SubtypeInvalidResponse, "pagination response must be a JSON object")
status.StopReason = StopReasonAPIError
status.Cause = err
return results, status, err
}
results = append(results, result)
status.PagesFetched++
if emit != nil {
if err := emit(page); err != nil {
status.Cause = err
return results, status, err
}
}
hasMore, returnedToken, truncated := paginationFacts(result)
status.HasMore = hasMore
status.NextPageToken = returnedToken
if truncated {
status.StopReason = StopReasonServerTruncation
return results, status, nil
}
if !hasMore {
if startPageToken != "" {
status.StopReason = StopReasonStartPageToken
} else {
status.StopReason = StopReasonExhausted
}
status.NextPageToken = ""
return results, status, nil
}
if returnedToken == "" {
err := missingPaginationTokenError()
status.StopReason = StopReasonMissingToken
status.Cause = err
return results, status, err
}
if _, exists := seenTokens[returnedToken]; exists {
err := repeatedPaginationTokenError()
status.StopReason = StopReasonRepeatedToken
status.Cause = err
return results, status, err
}
if opts.PageLimit > 0 && status.PagesFetched >= opts.PageLimit {
status.StopReason = StopReasonPageLimit
return results, status, nil
}
seenTokens[returnedToken] = struct{}{}
nextToken = returnedToken
if pageDelay > 0 {
time.Sleep(time.Duration(pageDelay) * time.Millisecond)
}
}
}
func paginationFacts(result interface{}) (hasMore bool, nextToken string, truncated bool) {
resultMap, ok := result.(map[string]interface{})
if !ok {
return false, "", false
}
truncated = explicitTruncation(resultMap)
data, ok := resultMap["data"].(map[string]interface{})
if !ok {
return false, "", truncated
}
hasMore, _ = data["has_more"].(bool)
nextToken = stringParam(data, "page_token")
if nextToken == "" {
nextToken = stringParam(data, "next_page_token")
}
return hasMore, nextToken, truncated || explicitTruncation(data)
}
func explicitTruncation(object map[string]interface{}) bool {
truncated, _ := object["truncated"].(bool)
isTruncated, _ := object["is_truncated"].(bool)
return truncated || isTruncated
}
func stringParam(params map[string]interface{}, name string) string {
value, _ := params[name].(string)
return value
}
func cloneParams(params map[string]interface{}) map[string]interface{} {
cloned := make(map[string]interface{}, len(params)+1)
for key, value := range params {
cloned[key] = value
}
return cloned
}
func missingPaginationTokenError() error {
return errs.NewInternalError(
errs.SubtypeInvalidResponse,
"paginated response has_more=true but next page token is missing",
)
}
func repeatedPaginationTokenError() error {
return errs.NewInternalError(
errs.SubtypeInvalidResponse,
"paginated response repeated the same next page token",
)
}
func mergeStatusResults(w io.Writer, results []interface{}) map[string]interface{} {
if len(results) == 0 {
return map[string]interface{}{}
}
if len(results) == 1 {
if result, ok := results[0].(map[string]interface{}); ok {
return result
}
return map[string]interface{}{"pages": results}
}
if w == nil {
w = io.Discard
}
merged := mergePagedResults(w, results)
if result, ok := merged.(map[string]interface{}); ok {
return result
}
return map[string]interface{}{"pages": results}
}

View File

@@ -1,451 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package client
import (
"context"
"encoding/json"
"errors"
"net"
"net/http"
"strings"
"testing"
"github.com/larksuite/cli/errs"
)
func TestInspectPaginationPageStatus(t *testing.T) {
tests := []struct {
name string
data map[string]interface{}
startToken string
want StopReason
wantMore bool
wantToken string
wantErr bool
}{
{
name: "exhausted",
data: map[string]interface{}{"has_more": false},
want: StopReasonExhausted,
},
{
name: "single page",
data: map[string]interface{}{"has_more": true, "page_token": "next"},
want: StopReasonSinglePage,
wantMore: true,
wantToken: "next",
},
{
name: "start page token",
data: map[string]interface{}{"has_more": false},
startToken: "middle",
want: StopReasonStartPageToken,
},
{
name: "missing token",
data: map[string]interface{}{"has_more": true},
want: StopReasonMissingToken,
wantMore: true,
wantErr: true,
},
{
name: "server truncation",
data: map[string]interface{}{"has_more": false, "truncated": true},
want: StopReasonServerTruncation,
},
{
name: "message text does not imply server truncation",
data: map[string]interface{}{"has_more": false, "message": "result was truncated"},
want: StopReasonExhausted,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := map[string]interface{}{
"code": float64(0),
"data": tt.data,
}
status, err := InspectPaginationPage(result, tt.startToken)
if (err != nil) != tt.wantErr {
t.Fatalf("InspectPaginationPage() error = %v, wantErr %v", err, tt.wantErr)
}
if status.StopReason != tt.want {
t.Errorf("StopReason = %q, want %q", status.StopReason, tt.want)
}
if status.PagesFetched != 1 {
t.Errorf("PagesFetched = %d, want 1", status.PagesFetched)
}
if status.HasMore != tt.wantMore {
t.Errorf("HasMore = %v, want %v", status.HasMore, tt.wantMore)
}
if status.NextPageToken != tt.wantToken {
t.Errorf("NextPageToken = %q, want %q", status.NextPageToken, tt.wantToken)
}
if status.Cause != err {
t.Errorf("Cause = %v, want returned error %v", status.Cause, err)
}
})
}
}
func TestPaginationStatusCauseIsNotSerialized(t *testing.T) {
status := PaginationStatus{
PagesFetched: 1,
HasMore: true,
NextPageToken: "next",
StopReason: StopReasonTransportError,
Cause: errors.New("contains sensitive transport details"),
}
raw, err := json.Marshal(status)
if err != nil {
t.Fatalf("json.Marshal() error = %v", err)
}
if strings.Contains(string(raw), "sensitive") || strings.Contains(string(raw), "cause") {
t.Fatalf("serialized status leaked Cause: %s", raw)
}
}
func TestPaginateAllWithStatusStopReasons(t *testing.T) {
tests := []struct {
name string
firstToken string
pageLimit int
pages []map[string]interface{}
wantCalls int
wantReason StopReason
wantPages int
wantMore bool
wantToken string
wantErr bool
}{
{
name: "exhausted with unlimited page limit",
pages: []map[string]interface{}{
pageResult(true, "next", false, "1"),
pageResult(false, "", false, "2"),
},
wantCalls: 2,
wantReason: StopReasonExhausted,
wantPages: 2,
},
{
name: "page limit",
pages: []map[string]interface{}{
pageResult(true, "next", false, "1"),
pageResult(true, "last", false, "2"),
},
pageLimit: 2,
wantCalls: 2,
wantReason: StopReasonPageLimit,
wantPages: 2,
wantMore: true,
wantToken: "last",
},
{
name: "start page token stays incomplete after exhaustion",
firstToken: "middle",
pages: []map[string]interface{}{
pageResult(false, "", false, "1"),
},
wantCalls: 1,
wantReason: StopReasonStartPageToken,
wantPages: 1,
},
{
name: "missing token fails closed",
pages: []map[string]interface{}{
pageResult(true, "", false, "1"),
},
wantCalls: 1,
wantReason: StopReasonMissingToken,
wantPages: 1,
wantMore: true,
wantErr: true,
},
{
name: "repeated token fails closed",
pages: []map[string]interface{}{
pageResult(true, "secret-token-x", false, "1"),
pageResult(true, "secret-token-x", false, "2"),
},
wantCalls: 2,
wantReason: StopReasonRepeatedToken,
wantPages: 2,
wantMore: true,
wantToken: "secret-token-x",
wantErr: true,
},
{
name: "server truncation is explicit structured fact",
pages: []map[string]interface{}{
pageResult(false, "", true, "1"),
},
wantCalls: 1,
wantReason: StopReasonServerTruncation,
wantPages: 1,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
if calls >= len(tt.pages) {
t.Fatalf("unexpected API call %d", calls+1)
}
body := tt.pages[calls]
calls++
return jsonResponse(body), nil
}))
params := map[string]interface{}{}
if tt.firstToken != "" {
params["page_token"] = tt.firstToken
}
result, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
Params: params,
As: "bot",
}, PaginationOptions{PageLimit: tt.pageLimit, PageDelay: -1})
if (err != nil) != tt.wantErr {
t.Fatalf("PaginateAllWithStatus() error = %v, wantErr %v", err, tt.wantErr)
}
if err != nil {
switch tt.wantReason {
case StopReasonMissingToken:
if err.Error() != "paginated response has_more=true but next page token is missing" {
t.Fatalf("missing-token error = %q", err)
}
case StopReasonRepeatedToken:
if err.Error() != "paginated response repeated the same next page token" {
t.Fatalf("repeated-token error = %q", err)
}
}
}
if calls != tt.wantCalls {
t.Errorf("API calls = %d, want %d", calls, tt.wantCalls)
}
if status.StopReason != tt.wantReason {
t.Errorf("StopReason = %q, want %q", status.StopReason, tt.wantReason)
}
if status.PagesFetched != tt.wantPages {
t.Errorf("PagesFetched = %d, want %d", status.PagesFetched, tt.wantPages)
}
if status.HasMore != tt.wantMore {
t.Errorf("HasMore = %v, want %v", status.HasMore, tt.wantMore)
}
if status.NextPageToken != tt.wantToken {
t.Errorf("NextPageToken = %q, want %q", status.NextPageToken, tt.wantToken)
}
if result == nil {
t.Fatal("result must preserve successfully fetched pages")
}
if tt.wantErr {
var internalErr *errs.InternalError
if !errors.As(err, &internalErr) || internalErr.Subtype != errs.SubtypeInvalidResponse {
t.Fatalf("error = %T %v, want invalid_response InternalError", err, err)
}
if tt.wantToken != "" && strings.Contains(err.Error(), tt.wantToken) {
t.Fatalf("error leaked page token: %v", err)
}
}
})
}
}
func TestPaginateAllWithStatusPreservesPartialResultAndTypedLateError(t *testing.T) {
t.Run("transport error", func(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return nil, &net.DNSError{Err: "no such host", Name: "example.invalid"}
}))
result, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1})
var networkErr *errs.NetworkError
if !errors.As(err, &networkErr) {
t.Fatalf("error = %T %v, want typed NetworkError", err, err)
}
assertPartialPage(t, result, "1")
if status.StopReason != StopReasonTransportError || status.PagesFetched != 1 || status.NextPageToken != "next" {
t.Fatalf("status = %#v, want late transport error with resumable token", status)
}
if status.Cause != err {
t.Fatalf("Cause = %v, want returned error %v", status.Cause, err)
}
})
t.Run("API error", func(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return jsonResponse(map[string]interface{}{"code": 999, "msg": "failed"}), nil
}))
result, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1})
var apiErr *errs.APIError
if !errors.As(err, &apiErr) {
t.Fatalf("error = %T %v, want typed APIError", err, err)
}
assertPartialPage(t, result, "1")
if status.StopReason != StopReasonAPIError || status.PagesFetched != 1 || status.NextPageToken != "next" {
t.Fatalf("status = %#v, want late API error with resumable token", status)
}
})
}
func TestPaginateAllWithStatusHTTPNormalizerIsOptIn(t *testing.T) {
newClient := func(t *testing.T) *APIClient {
t.Helper()
response := jsonResponse(pageResult(false, "", false, "1"))
response.StatusCode = http.StatusServiceUnavailable
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
return response, nil
}))
return ac
}
t.Run("normalizer classifies HTTP status", func(t *testing.T) {
marker := errors.New("normalized HTTP failure")
ac := newClient(t)
_, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{
PageDelay: -1,
NormalizeHTTPError: func(status int, _ string, err error) error {
if status != http.StatusServiceUnavailable || err != nil {
t.Fatalf("normalizer input = status %d, err %v", status, err)
}
return marker
},
})
if !errors.Is(err, marker) || status.StopReason != StopReasonAPIError {
t.Fatalf("err = %v, status = %#v", err, status)
}
})
t.Run("nil normalizer preserves legacy behavior", func(t *testing.T) {
ac := newClient(t)
_, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1})
if err != nil || status.StopReason != StopReasonExhausted {
t.Fatalf("err = %v, status = %#v", err, status)
}
})
}
func TestStreamPagesWithStatusPreservesEmittedPagesOnLateError(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return nil, &net.DNSError{Err: "no such host", Name: "example.invalid"}
}))
var emitted []map[string]interface{}
status, err := ac.StreamPagesWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1}, func(page map[string]interface{}) error {
emitted = append(emitted, page)
return nil
})
var networkErr *errs.NetworkError
if !errors.As(err, &networkErr) {
t.Fatalf("error = %T %v, want typed NetworkError", err, err)
}
if len(emitted) != 1 {
t.Fatalf("emitted pages = %d, want 1", len(emitted))
}
if status.StopReason != StopReasonTransportError || status.PagesFetched != 1 {
t.Fatalf("status = %#v, want late transport error", status)
}
}
func TestLegacyPaginateAllStillSwallowsLateTransportError(t *testing.T) {
calls := 0
ac, errOut := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return nil, &net.DNSError{Err: "no such host", Name: "example.invalid"}
}))
result, err := ac.PaginateAll(context.Background(), RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1})
if err != nil {
t.Fatalf("legacy PaginateAll() error = %v, want nil", err)
}
assertPartialPage(t, result, "1")
if !strings.Contains(errOut.String(), "[page 2] error, stopping pagination") {
t.Fatalf("legacy warning changed: %q", errOut.String())
}
}
func pageResult(hasMore bool, token string, truncated bool, id string) map[string]interface{} {
data := map[string]interface{}{
"items": []interface{}{map[string]interface{}{"id": id}},
"has_more": hasMore,
"truncated": truncated,
}
if token != "" {
data["page_token"] = token
}
return map[string]interface{}{"code": float64(0), "msg": "ok", "data": data}
}
func assertPartialPage(t *testing.T, result interface{}, wantID string) {
t.Helper()
resultMap, ok := result.(map[string]interface{})
if !ok {
t.Fatalf("result = %T, want map", result)
}
data, ok := resultMap["data"].(map[string]interface{})
if !ok {
t.Fatalf("data = %T, want map", resultMap["data"])
}
items, ok := data["items"].([]interface{})
if !ok || len(items) != 1 {
t.Fatalf("items = %#v, want one item", data["items"])
}
item, ok := items[0].(map[string]interface{})
if !ok || item["id"] != wantID {
t.Fatalf("item = %#v, want id %q", items[0], wantID)
}
}

View File

@@ -29,9 +29,6 @@ type DryRunOutputOptions struct {
Identity core.Identity
Out io.Writer
ErrOut io.Writer
// NoticeProvider is optional. Nil preserves the process-wide notice source;
// command-specific callers can merge invocation facts without mutating it.
NoticeProvider output.NoticeProvider
}
// DryRunAPICall describes a single API call in dry-run output.
@@ -309,20 +306,12 @@ func WriteDryRun(dr *DryRunAPI, opts DryRunOutputOptions) error {
fmt.Fprint(opts.Out, dr.Format())
return nil
}
noticeProvider := opts.NoticeProvider
if noticeProvider == nil {
noticeProvider = output.GetNotice
}
return output.NewEmitter(output.EmitterConfig{
Out: opts.Out,
ErrOut: opts.ErrOut,
CommandPath: opts.CommandPath,
Identity: string(opts.Identity),
NoticeProvider: noticeProvider,
}).Success(dr, output.EmitOptions{
Format: "",
JQ: opts.JqExpr,
DryRun: true,
JQSafetyWarning: true,
return output.WriteSuccessEnvelope(dr, output.SuccessEnvelopeOptions{
CommandPath: opts.CommandPath,
Identity: string(opts.Identity),
DryRun: true,
JqExpr: opts.JqExpr,
Out: opts.Out,
ErrOut: opts.ErrOut,
})
}

View File

@@ -14,7 +14,6 @@ import (
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/output"
)
func TestDryRunAPI_SingleGET(t *testing.T) {
@@ -194,33 +193,6 @@ func TestPrintDryRun_JSON(t *testing.T) {
}
}
func TestPrintDryRun_JSONUsesCommandScopedNoticeProvider(t *testing.T) {
var buf bytes.Buffer
err := PrintDryRun(client.RawApiRequest{
Method: "POST",
URL: "/open-apis/test",
As: "bot",
}, &core.CliConfig{AppID: "app123"}, DryRunOutputOptions{
Format: "json",
Identity: core.AsBot,
Out: &buf,
ErrOut: io.Discard,
NoticeProvider: func() map[string]interface{} {
return map[string]interface{}{"identity_defaulted": map[string]interface{}{"resolved": "bot"}}
},
})
if err != nil {
t.Fatalf("PrintDryRun failed: %v", err)
}
var env output.Envelope
if err := json.Unmarshal(buf.Bytes(), &env); err != nil {
t.Fatalf("dry-run stdout is not JSON: %v\n%s", err, buf.String())
}
if got := env.Notice["identity_defaulted"].(map[string]interface{})["resolved"]; got != "bot" {
t.Fatalf("identity_defaulted.resolved = %#v", got)
}
}
func TestPrintDryRun_Pretty(t *testing.T) {
var buf bytes.Buffer
var errBuf bytes.Buffer

View File

@@ -22,7 +22,6 @@ import (
"github.com/larksuite/cli/internal/credential"
"github.com/larksuite/cli/internal/keychain"
"github.com/larksuite/cli/internal/registry"
"github.com/larksuite/cli/internal/riskcontrol"
_ "github.com/larksuite/cli/internal/security/contentsafety" // register content safety provider
"github.com/larksuite/cli/internal/transport"
_ "github.com/larksuite/cli/internal/vfs/localfileio" // register default FileIO provider
@@ -34,7 +33,7 @@ import (
// Phase 1: HttpClient (no credential dependency)
// Phase 2: Credential (sole data source for account info)
// Phase 3: Config derived from Credential
// Phase 4: LarkClient derived from Credential and workspace policy
// Phase 4: LarkClient derived from Credential
func NewDefault(streams *IOStreams, inv InvocationContext) *Factory {
streams = normalizeStreams(streams)
f := &Factory{
@@ -55,10 +54,9 @@ func NewDefault(streams *IOStreams, inv InvocationContext) *Factory {
// Phase 0: FileIO provider (no dependency)
f.FileIOProvider = fileio.GetProvider()
workspaceConfig := core.NewConfigSnapshot()
// Phase 1: HttpClient (no credential dependency)
f.HttpClient = cachedHttpClientFunc(f, workspaceConfig)
f.HttpClient = cachedHttpClientFunc(f)
// Phase 2: Credential (sole data source)
// Keychain is read via closure so callers can replace f.Keychain after construction.
@@ -69,7 +67,7 @@ func NewDefault(streams *IOStreams, inv InvocationContext) *Factory {
ErrOut: f.IOStreams.ErrOut,
})
// Phase 3: Runtime config contains resolved account data only.
// Phase 3: Config derived from Credential via an explicit conversion boundary.
f.Config = sync.OnceValues(func() (*core.CliConfig, error) {
acct, err := f.Credential.ResolveAccount(context.Background())
if err != nil {
@@ -80,9 +78,8 @@ func NewDefault(streams *IOStreams, inv InvocationContext) *Factory {
return cfg, nil
})
// Phase 4: LarkClient composes account data and workspace policy at the SDK
// transport boundary.
f.LarkClient = cachedLarkClientFunc(f, workspaceConfig)
// Phase 4: LarkClient from Credential (placeholder AppSecret)
f.LarkClient = cachedLarkClientFunc(f)
return f
}
@@ -111,16 +108,13 @@ func safeRedirectPolicy(req *http.Request, via []*http.Request) error {
// .StderrIsTerminal field, which tests set directly.
var warnIfProxied = transport.WarnIfProxied
func cachedHttpClientFunc(f *Factory, workspaceConfig workspaceConfigSource) func() (*http.Client, error) {
func cachedHttpClientFunc(f *Factory) func() (*http.Client, error) {
return sync.OnceValues(func() (*http.Client, error) {
if f.IOStreams.StderrIsTerminal {
warnIfProxied(f.IOStreams.ErrOut)
}
hostSignalSource := resolveSDKHostSignalSource(workspaceConfig)
var rt http.RoundTripper = transport.Shared()
rt = riskcontrol.NewTransport(rt, hostSignalSource)
rt = &RetryTransport{Base: rt}
rt = &SecurityHeaderTransport{Base: rt}
rt = &auth.SecurityPolicyTransport{Base: rt} // Add our global response interceptor
@@ -134,7 +128,7 @@ func cachedHttpClientFunc(f *Factory, workspaceConfig workspaceConfigSource) fun
})
}
func cachedLarkClientFunc(f *Factory, workspaceConfig workspaceConfigSource) func() (*lark.Client, error) {
func cachedLarkClientFunc(f *Factory) func() (*lark.Client, error) {
return sync.OnceValues(func() (*lark.Client, error) {
acct, err := f.Credential.ResolveAccount(context.Background())
if err != nil {
@@ -148,15 +142,8 @@ func cachedLarkClientFunc(f *Factory, workspaceConfig workspaceConfigSource) fun
if f.IOStreams.StderrIsTerminal {
warnIfProxied(f.IOStreams.ErrOut)
}
hostSignalSource := resolveSDKHostSignalSource(workspaceConfig)
var sdkBase http.RoundTripper = transport.Shared()
// The innermost SDK boundary always strips reserved host-signal headers;
// a nil source makes it strip-only when workspace policy disables signal
// collection.
sdkBase = riskcontrol.NewTransport(sdkBase, hostSignalSource)
sdkTransport := wrapSDKTransport(sdkBase)
opts = append(opts, lark.WithHttpClient(&http.Client{
Transport: sdkTransport,
Transport: buildSDKTransport(),
CheckRedirect: safeRedirectPolicy,
}))
ep := core.ResolveEndpoints(acct.Brand)
@@ -165,8 +152,9 @@ func cachedLarkClientFunc(f *Factory, workspaceConfig workspaceConfigSource) fun
})
}
func wrapSDKTransport(next http.RoundTripper) http.RoundTripper {
var sdkTransport http.RoundTripper = &RetryTransport{Base: next}
func buildSDKTransport() http.RoundTripper {
var sdkTransport http.RoundTripper = transport.Shared()
sdkTransport = &RetryTransport{Base: sdkTransport}
sdkTransport = &UserAgentTransport{Base: sdkTransport}
sdkTransport = &BuildHeaderTransport{Base: sdkTransport}
sdkTransport = &auth.SecurityPolicyTransport{Base: sdkTransport}

View File

@@ -6,15 +6,10 @@ package cmdutil
import (
"io"
"testing"
"github.com/larksuite/cli/internal/core"
)
func TestCachedHttpClientFunc_ReturnsSameInstance(t *testing.T) {
isEnabled := false
f, _, _, _ := TestFactory(t, &core.CliConfig{AppID: "test-app"})
f.IOStreams.ErrOut = io.Discard
fn := cachedHttpClientFunc(f, staticWorkspaceConfig{config: &core.MultiAppConfig{RiskControl: &isEnabled}})
fn := cachedHttpClientFunc(&Factory{IOStreams: &IOStreams{ErrOut: io.Discard}})
c1, err := fn()
if err != nil {
@@ -34,10 +29,7 @@ func TestCachedHttpClientFunc_ReturnsSameInstance(t *testing.T) {
}
func TestCachedHttpClientFunc_HasTimeout(t *testing.T) {
isEnabled := false
f, _, _, _ := TestFactory(t, &core.CliConfig{AppID: "test-app"})
f.IOStreams.ErrOut = io.Discard
fn := cachedHttpClientFunc(f, staticWorkspaceConfig{config: &core.MultiAppConfig{RiskControl: &isEnabled}})
fn := cachedHttpClientFunc(&Factory{IOStreams: &IOStreams{ErrOut: io.Discard}})
c, _ := fn()
if c.Timeout == 0 {
t.Error("expected non-zero timeout")
@@ -45,10 +37,7 @@ func TestCachedHttpClientFunc_HasTimeout(t *testing.T) {
}
func TestCachedHttpClientFunc_HasRedirectPolicy(t *testing.T) {
isEnabled := false
f, _, _, _ := TestFactory(t, &core.CliConfig{AppID: "test-app"})
f.IOStreams.ErrOut = io.Discard
fn := cachedHttpClientFunc(f, staticWorkspaceConfig{config: &core.MultiAppConfig{RiskControl: &isEnabled}})
fn := cachedHttpClientFunc(&Factory{IOStreams: &IOStreams{ErrOut: io.Discard}})
c, _ := fn()
if c.CheckRedirect == nil {
t.Error("expected CheckRedirect to be set (safeRedirectPolicy)")

View File

@@ -8,7 +8,6 @@ import (
"testing"
_ "github.com/larksuite/cli/extension/credential/env" // registers the env-backed account provider
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/envvars"
)
@@ -37,15 +36,13 @@ var proxyWarnGateCases = []struct {
// TestCachedHttpClientFunc_ProxyWarnGate verifies the http-client init path
// invokes WarnIfProxied only when stderr is an interactive terminal.
func TestCachedHttpClientFunc_ProxyWarnGate(t *testing.T) {
isEnabled := false
for _, tc := range proxyWarnGateCases {
t.Run(tc.name, func(t *testing.T) {
calls := installProxyWarnSpy(t)
f, _, _, _ := TestFactory(t, &core.CliConfig{AppID: "test-app"})
f.IOStreams.ErrOut = io.Discard
f.IOStreams.StderrIsTerminal = tc.terminal
fn := cachedHttpClientFunc(f, staticWorkspaceConfig{config: &core.MultiAppConfig{RiskControl: &isEnabled}})
fn := cachedHttpClientFunc(&Factory{IOStreams: &IOStreams{
ErrOut: io.Discard, StderrIsTerminal: tc.terminal,
}})
if _, err := fn(); err != nil {
t.Fatalf("http client init: %v", err)
}
@@ -76,7 +73,7 @@ func TestCachedLarkClientFunc_ProxyWarnGate(t *testing.T) {
// normalizeStreams copies the struct (out := *s), so the
// StderrIsTerminal field survives into f.IOStreams.
f := NewDefault(&IOStreams{ErrOut: io.Discard, StderrIsTerminal: tc.terminal}, InvocationContext{})
if _, err := cachedLarkClientFunc(f, nil)(); err != nil {
if _, err := cachedLarkClientFunc(f)(); err != nil {
t.Fatalf("lark client init: %v", err)
}

View File

@@ -1,36 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package cmdutil
import (
"io/fs"
"github.com/larksuite/cli/extension/fileio"
"github.com/larksuite/cli/internal/validate"
"github.com/larksuite/cli/internal/vfs"
)
// StatLocalFile returns metadata for a path in the process filesystem namespace.
// It is intended for advisory validation; callers must validate the opened file
// again before using its contents.
func StatLocalFile(path string) (fs.FileInfo, error) {
localPath, err := validate.LocalInputPath(path)
if err != nil {
return nil, &fileio.PathValidationError{Err: err}
}
return vfs.Stat(localPath)
}
// OpenLocalFile opens a path in the process filesystem namespace.
// Absolute and relative paths are accepted. It is the shared replacement for
// direct os.Open/os.ReadFile use in commands that intentionally read local
// paths outside the workspace sandbox. Callers inspect the returned descriptor
// before reading so validation and use apply to the same opened file.
func OpenLocalFile(path string) (fs.File, error) {
localPath, err := validate.LocalInputPath(path)
if err != nil {
return nil, &fileio.PathValidationError{Err: err}
}
return vfs.Open(localPath)
}

View File

@@ -1,96 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package cmdutil
import (
"errors"
"io"
"io/fs"
"os"
"path/filepath"
"testing"
"github.com/larksuite/cli/extension/fileio"
"github.com/larksuite/cli/internal/vfs"
)
func TestOpenLocalFile_AcceptsAbsoluteAndParentRelativePaths(t *testing.T) {
root := t.TempDir()
workDir := filepath.Join(root, "work")
if err := os.Mkdir(workDir, 0o755); err != nil {
t.Fatal(err)
}
path := filepath.Join(root, "input.txt")
if err := os.WriteFile(path, []byte("content"), 0o600); err != nil {
t.Fatal(err)
}
TestChdir(t, workDir)
for _, input := range []string{path, filepath.Join("..", "input.txt")} {
f, err := OpenLocalFile(input)
if err != nil {
t.Fatalf("OpenLocalFile(%q) error = %v", input, err)
}
got, readErr := io.ReadAll(f)
closeErr := f.Close()
if readErr != nil || closeErr != nil || string(got) != "content" {
t.Fatalf("OpenLocalFile(%q) content=%q read=%v close=%v", input, got, readErr, closeErr)
}
}
}
func TestOpenLocalFile_RejectsInvalidInput(t *testing.T) {
if _, err := OpenLocalFile("input\n.txt"); !errors.Is(err, fileio.ErrPathValidation) {
t.Fatalf("OpenLocalFile() error = %v, want ErrPathValidation", err)
}
}
func TestStatLocalFile_ReturnsMetadata(t *testing.T) {
info, err := StatLocalFile(t.TempDir())
if err != nil {
t.Fatalf("StatLocalFile() error = %v", err)
}
if !info.IsDir() {
t.Fatalf("StatLocalFile() mode = %v, want directory", info.Mode())
}
}
func TestOpenLocalFile_DoesNotStatBeforeOpen(t *testing.T) {
path := filepath.Join(t.TempDir(), "input.txt")
if err := os.WriteFile(path, []byte("content"), 0o600); err != nil {
t.Fatal(err)
}
previous := vfs.DefaultFS
counting := &countingLocalFileFS{FS: previous}
vfs.DefaultFS = counting
t.Cleanup(func() { vfs.DefaultFS = previous })
f, err := OpenLocalFile(path)
if err != nil {
t.Fatalf("OpenLocalFile() error = %v", err)
}
if err := f.Close(); err != nil {
t.Fatal(err)
}
if counting.openCalls != 1 || counting.statCalls != 0 {
t.Fatalf("OpenLocalFile() calls: Open=%d Stat=%d, want Open=1 Stat=0", counting.openCalls, counting.statCalls)
}
}
type countingLocalFileFS struct {
vfs.FS
openCalls int
statCalls int
}
func (f *countingLocalFileFS) Open(name string) (*os.File, error) {
f.openCalls++
return f.FS.Open(name)
}
func (f *countingLocalFileFS) Stat(name string) (fs.FileInfo, error) {
f.statCalls++
return f.FS.Stat(name)
}

View File

@@ -4,8 +4,6 @@
package cmdutil
import (
"fmt"
"github.com/larksuite/cli/internal/core"
"github.com/spf13/cobra"
)
@@ -45,15 +43,3 @@ func GetRisk(cmd *cobra.Command) (level string, ok bool) {
level, ok = cmd.Annotations[riskLevelAnnotationKey]
return level, ok && level != ""
}
// RiskHelpText returns the canonical help line for a risk level. High-risk
// writes retain the confirmation boundary wherever the line is rendered.
func RiskHelpText(level string) string {
if level == RiskHighRiskWrite {
return fmt.Sprintf(
"Risk: %s (requires explicit user confirmation to execute; the agent must NOT add --yes on its own — only pass --yes after the user has confirmed)",
level,
)
}
return fmt.Sprintf("Risk: %s", level)
}

View File

@@ -1,28 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package cmdutil
import (
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/riskcontrol"
)
type workspaceConfigSource interface {
MultiAppConfig() (*core.MultiAppConfig, error)
}
// resolveSDKHostSignalSource applies workspace policy at the SDK transport
// boundary.
func resolveSDKHostSignalSource(config workspaceConfigSource) riskcontrol.Source {
if config == nil {
return nil
}
workspace, configErr := config.MultiAppConfig()
// Default-on means an existing config with no explicit preference. Absent
// or unreadable config cannot authorize host-signal collection.
if configErr != nil || !workspace.RiskControlEnabled() {
return nil
}
return riskcontrol.NewHostSource()
}

View File

@@ -1,45 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package cmdutil
import (
"errors"
"testing"
"github.com/larksuite/cli/internal/core"
)
type staticWorkspaceConfig struct {
config *core.MultiAppConfig
err error
}
func (s staticWorkspaceConfig) MultiAppConfig() (*core.MultiAppConfig, error) {
return s.config, s.err
}
func TestResolveSDKHostSignalSource(t *testing.T) {
disabled := false
tests := []struct {
name string
config workspaceConfigSource
wantSource bool
}{
{name: "workspace default on", config: staticWorkspaceConfig{config: &core.MultiAppConfig{}}, wantSource: true},
{name: "workspace opt-out", config: staticWorkspaceConfig{config: &core.MultiAppConfig{RiskControl: &disabled}}},
{name: "missing config", config: staticWorkspaceConfig{err: errors.New("file does not exist")}},
{name: "unreadable config", config: staticWorkspaceConfig{err: errors.New("permission denied")}},
{name: "nil config value", config: staticWorkspaceConfig{}},
{name: "nil config source"},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
got := resolveSDKHostSignalSource(test.config)
if (got != nil) != test.wantSource {
t.Fatalf("resolveSDKHostSignalSource() = %T, wantSource %t", got, test.wantSource)
}
})
}
}

View File

@@ -4,24 +4,11 @@
package cmdutil
import (
"strings"
"testing"
"github.com/spf13/cobra"
)
func TestRiskHelpTextPreservesHighRiskConfirmationGuard(t *testing.T) {
if got := RiskHelpText(RiskWrite); got != "Risk: write" {
t.Fatalf("RiskHelpText(write) = %q", got)
}
got := RiskHelpText(RiskHighRiskWrite)
for _, want := range []string{"Risk: high-risk-write", "requires explicit user confirmation", "agent must NOT add --yes"} {
if !strings.Contains(got, want) {
t.Fatalf("RiskHelpText(high-risk-write) missing %q: %q", want, got)
}
}
}
func TestSetRisk_EmptyLevelShortCircuits(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
SetRisk(cmd, "")

View File

@@ -26,7 +26,6 @@ const (
HeaderShortcut = "X-Cli-Shortcut"
HeaderExecutionId = "X-Cli-Execution-Id"
HeaderAgentTrace = "X-Agent-Trace"
HeaderAgentName = "X-Agent-Name"
SourceValue = "lark-cli"
@@ -56,9 +55,6 @@ func BaseSecurityHeaders() http.Header {
if v := envvars.AgentTrace(); v != "" {
h.Set(HeaderAgentTrace, v)
}
if v := envvars.AgentName(); v != "" {
h.Set(HeaderAgentName, v)
}
return h
}

View File

@@ -263,34 +263,9 @@ func TestBaseSecurityHeaders_AllRequiredHeaders(t *testing.T) {
}
// ---------------------------------------------------------------------------
// Agent headers injected via BaseSecurityHeaders
// HeaderAgentTrace injection (via BaseSecurityHeaders)
// ---------------------------------------------------------------------------
func TestBaseSecurityHeaders_NoAgentNameHeaderWhenEnvUnset(t *testing.T) {
t.Setenv(envvars.CliAgentName, "")
h := BaseSecurityHeaders()
if v := h.Get(HeaderAgentName); v != "" {
t.Fatalf("BaseSecurityHeaders() included %s = %q, want absent when env unset", HeaderAgentName, v)
}
}
func TestBaseSecurityHeaders_IncludesAgentNameHeaderWhenEnvSet(t *testing.T) {
const agentName = "sample-agent"
t.Setenv(envvars.CliAgentName, agentName)
h := BaseSecurityHeaders()
if v := h.Get(HeaderAgentName); v != agentName {
t.Fatalf("BaseSecurityHeaders()[%s] = %q, want %q", HeaderAgentName, v, agentName)
}
}
func TestBaseSecurityHeaders_NoAgentNameHeaderWhenEnvInvalid(t *testing.T) {
t.Setenv(envvars.CliAgentName, "agent\r\nX-Evil: attack")
h := BaseSecurityHeaders()
if v := h.Get(HeaderAgentName); v != "" {
t.Fatalf("BaseSecurityHeaders() included %s = %q, want absent for invalid input", HeaderAgentName, v)
}
}
func TestBaseSecurityHeaders_NoAgentTraceHeaderWhenEnvUnset(t *testing.T) {
t.Setenv(envvars.CliAgentTrace, "")
h := BaseSecurityHeaders()

View File

@@ -15,7 +15,6 @@ import (
exttransport "github.com/larksuite/cli/extension/transport"
internalauth "github.com/larksuite/cli/internal/auth"
"github.com/larksuite/cli/internal/riskcontrol"
)
type roundTripFunc func(*http.Request) (*http.Response, error)
@@ -92,13 +91,13 @@ func TestRetryTransport_DefaultNoRetry(t *testing.T) {
}
// ---------------------------------------------------------------------------
// wrapSDKTransport chain composition
// buildSDKTransport chain composition
// ---------------------------------------------------------------------------
func TestWrapSDKTransport_IncludesRetryTransport(t *testing.T) {
transport := wrapSDKTransport(riskcontrol.NewTransport(http.DefaultTransport, nil))
func TestBuildSDKTransport_IncludesRetryTransport(t *testing.T) {
transport := buildSDKTransport()
// Chain: SecurityPolicy → BuildHeader → UserAgent → Retry → RiskControl → Base
// Chain: SecurityPolicy → BuildHeader → UserAgent → Retry → Base
sec, ok := transport.(*internalauth.SecurityPolicyTransport)
if !ok {
t.Fatalf("outer transport type = %T, want *auth.SecurityPolicyTransport", transport)
@@ -111,23 +110,18 @@ func TestWrapSDKTransport_IncludesRetryTransport(t *testing.T) {
if !ok {
t.Fatalf("layer after BuildHeader = %T, want *UserAgentTransport", bh.Base)
}
retry, ok := ua.Base.(*RetryTransport)
if !ok {
if _, ok := ua.Base.(*RetryTransport); !ok {
t.Fatalf("inner transport type = %T, want *RetryTransport", ua.Base)
}
if _, ok := retry.Base.(*riskcontrol.Transport); !ok {
t.Fatalf("layer after Retry = %T, want *riskcontrol.Transport", retry.Base)
}
}
func TestWrapSDKTransport_WithExtension(t *testing.T) {
previous := exttransport.GetProvider()
func TestBuildSDKTransport_WithExtension(t *testing.T) {
exttransport.Register(&stubTransportProvider{})
t.Cleanup(func() { exttransport.Register(previous) })
t.Cleanup(func() { exttransport.Register(nil) })
transport := wrapSDKTransport(riskcontrol.NewTransport(http.DefaultTransport, nil))
transport := buildSDKTransport()
// Chain: extensionMiddleware → SecurityPolicy → BuildHeader → UserAgent → Retry → RiskControl → Base
// Chain: extensionMiddleware → SecurityPolicy → BuildHeader → UserAgent → Retry → Base
mid, ok := transport.(*extensionMiddleware)
if !ok {
t.Fatalf("outer transport type = %T, want *extensionMiddleware", transport)
@@ -144,23 +138,17 @@ func TestWrapSDKTransport_WithExtension(t *testing.T) {
if !ok {
t.Fatalf("layer after BuildHeader = %T, want *UserAgentTransport", bh.Base)
}
retry, ok := ua.Base.(*RetryTransport)
if !ok {
if _, ok := ua.Base.(*RetryTransport); !ok {
t.Fatalf("innermost transport type = %T, want *RetryTransport", ua.Base)
}
if _, ok := retry.Base.(*riskcontrol.Transport); !ok {
t.Fatalf("layer after Retry = %T, want *riskcontrol.Transport", retry.Base)
}
}
func TestWrapSDKTransport_WithoutExtension(t *testing.T) {
previous := exttransport.GetProvider()
func TestBuildSDKTransport_WithoutExtension(t *testing.T) {
exttransport.Register(nil)
t.Cleanup(func() { exttransport.Register(previous) })
transport := wrapSDKTransport(riskcontrol.NewTransport(http.DefaultTransport, nil))
transport := buildSDKTransport()
// Chain: SecurityPolicy → BuildHeader → UserAgent → Retry → RiskControl → Base
// Chain: SecurityPolicy → BuildHeader → UserAgent → Retry → Base
sec, ok := transport.(*internalauth.SecurityPolicyTransport)
if !ok {
t.Fatalf("outer transport type = %T, want *auth.SecurityPolicyTransport", transport)
@@ -173,13 +161,9 @@ func TestWrapSDKTransport_WithoutExtension(t *testing.T) {
if !ok {
t.Fatalf("layer after BuildHeader = %T, want *UserAgentTransport", bh.Base)
}
retry, ok := ua.Base.(*RetryTransport)
if !ok {
if _, ok := ua.Base.(*RetryTransport); !ok {
t.Fatalf("inner transport type = %T, want *RetryTransport", ua.Base)
}
if _, ok := retry.Base.(*riskcontrol.Transport); !ok {
t.Fatalf("layer after Retry = %T, want *riskcontrol.Transport", retry.Base)
}
}
// ---------------------------------------------------------------------------
@@ -277,40 +261,6 @@ func (buildTamperingInterceptor) PreRoundTrip(req *http.Request) func(*http.Resp
return nil
}
type riskHeaderTamperingInterceptor struct{}
func (riskHeaderTamperingInterceptor) PreRoundTrip(req *http.Request) func(*http.Response, error) {
req.Header.Set(riskcontrol.HeaderOSType, "extension-value")
req.Header.Set(riskcontrol.HeaderProductModel, "extension-value")
return nil
}
func TestWrapSDKTransport_StripsExtensionRiskHeaders(t *testing.T) {
previous := exttransport.GetProvider()
exttransport.Register(&stubTransportProvider{interceptor: riskHeaderTamperingInterceptor{}})
t.Cleanup(func() { exttransport.Register(previous) })
var received http.Header
network := roundTripFunc(func(req *http.Request) (*http.Response, error) {
received = req.Header.Clone()
return &http.Response{StatusCode: http.StatusOK, Body: http.NoBody}, nil
})
req, err := http.NewRequest(http.MethodGet, "https://open.feishu.cn/open-apis/test", nil)
if err != nil {
t.Fatal(err)
}
req.Header.Set("Authorization", "Bearer token")
resp, err := wrapSDKTransport(riskcontrol.NewTransport(network, nil)).RoundTrip(req)
if err != nil {
t.Fatal(err)
}
resp.Body.Close()
if received.Get(riskcontrol.HeaderOSType) != "" || received.Get(riskcontrol.HeaderProductModel) != "" {
t.Fatalf("extension risk headers reached network: %v", received)
}
}
// TestBuildHeaderTransport_SDKChain_OverridesTamperedHeader verifies that the
// X-Cli-Build header is force-written by BuildHeaderTransport in the SDK
// transport chain, even when an extension tries to delete or spoof it. This
@@ -327,7 +277,7 @@ func TestBuildHeaderTransport_SDKChain_OverridesTamperedHeader(t *testing.T) {
exttransport.Register(&stubTransportProvider{interceptor: buildTamperingInterceptor{}})
t.Cleanup(func() { exttransport.Register(nil) })
// Replicate the SDK chain layering used by wrapSDKTransport.
// Replicate the SDK chain layering used by buildSDKTransport.
var base http.RoundTripper = http.DefaultTransport
base = &RetryTransport{Base: base}
base = &UserAgentTransport{Base: base}

View File

@@ -60,18 +60,11 @@ func (a *AppConfig) ProfileName() string {
// MultiAppConfig is the multi-app config file format.
type MultiAppConfig struct {
StrictMode StrictMode `json:"strictMode,omitempty"`
RiskControl *bool `json:"riskControl,omitempty"`
CurrentApp string `json:"currentApp,omitempty"`
PreviousApp string `json:"previousApp,omitempty"`
Apps []AppConfig `json:"apps"`
}
// RiskControlEnabled resolves the workspace policy. An omitted preference
// keeps the default-on account-protection behavior.
func (m *MultiAppConfig) RiskControlEnabled() bool {
return m != nil && (m.RiskControl == nil || *m.RiskControl)
}
// CurrentAppConfig returns the currently active app config.
// Resolution priority: profileOverride > CurrentApp field > Apps[0].
func (m *MultiAppConfig) CurrentAppConfig(profileOverride string) *AppConfig {

View File

@@ -1,37 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package core
import (
"io/fs"
"sync"
)
// ConfigSnapshot lazily captures one stable view of config.json for a CLI
// invocation. All runtime consumers share the same load result so account and
// workspace policy resolution cannot observe different file revisions. Callers
// must treat the returned config as read-only.
type ConfigSnapshot struct {
load func() (*MultiAppConfig, error)
}
// NewConfigSnapshot creates a lazily loaded invocation-scoped config snapshot.
func NewConfigSnapshot() *ConfigSnapshot {
return newConfigSnapshot(LoadMultiAppConfig)
}
func newConfigSnapshot(load func() (*MultiAppConfig, error)) *ConfigSnapshot {
if load == nil {
return &ConfigSnapshot{}
}
return &ConfigSnapshot{load: sync.OnceValues(load)}
}
// MultiAppConfig returns the captured persistent config and load error.
func (s *ConfigSnapshot) MultiAppConfig() (*MultiAppConfig, error) {
if s == nil || s.load == nil {
return nil, fs.ErrNotExist
}
return s.load()
}

View File

@@ -1,58 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package core
import (
"errors"
"io/fs"
"testing"
)
func TestConfigSnapshotLoadsOnce(t *testing.T) {
calls := 0
want := &MultiAppConfig{}
snapshot := newConfigSnapshot(func() (*MultiAppConfig, error) {
calls++
return want, nil
})
for range 2 {
config, err := snapshot.MultiAppConfig()
if err != nil {
t.Fatal(err)
}
if config != want {
t.Fatal("snapshot returned a different config instance")
}
}
if calls != 1 {
t.Fatalf("config loads = %d, want 1", calls)
}
}
func TestConfigSnapshotZeroValueIsMissing(t *testing.T) {
config, err := (&ConfigSnapshot{}).MultiAppConfig()
if config != nil || !errors.Is(err, fs.ErrNotExist) {
t.Fatalf("MultiAppConfig() = (%v, %v), want (nil, fs.ErrNotExist)", config, err)
}
}
func TestConfigSnapshotCachesError(t *testing.T) {
calls := 0
want := errors.New("load failed")
snapshot := newConfigSnapshot(func() (*MultiAppConfig, error) {
calls++
return nil, want
})
for range 2 {
config, err := snapshot.MultiAppConfig()
if config != nil || !errors.Is(err, want) {
t.Fatalf("MultiAppConfig() = (%v, %v), want (nil, %v)", config, err, want)
}
}
if calls != 1 {
t.Fatalf("config loads = %d, want 1", calls)
}
}

View File

@@ -60,9 +60,7 @@ func TestAppConfig_LangOmitEmpty(t *testing.T) {
}
func TestMultiAppConfig_RoundTrip(t *testing.T) {
disabled := false
config := &MultiAppConfig{
RiskControl: &disabled,
Apps: []AppConfig{{
AppId: "cli_test", AppSecret: PlainSecret("s"),
Brand: BrandLark, Lang: "zh", Users: []AppUser{},
@@ -86,9 +84,6 @@ func TestMultiAppConfig_RoundTrip(t *testing.T) {
if got.Apps[0].Brand != BrandLark {
t.Errorf("Brand = %q, want %q", got.Apps[0].Brand, BrandLark)
}
if got.RiskControl == nil || *got.RiskControl {
t.Errorf("RiskControl = %v, want explicit false", got.RiskControl)
}
}
func TestResolveConfigFromMulti_RejectsSecretKeyMismatch(t *testing.T) {

View File

@@ -16,18 +16,16 @@ func TestAgentName_EmptyWhenEnvUnset(t *testing.T) {
}
func TestAgentName_ReturnsCleanValue(t *testing.T) {
const agentName = "sample-agent"
t.Setenv(CliAgentName, agentName)
if got := AgentName(); got != agentName {
t.Fatalf("AgentName() = %q, want %q", got, agentName)
t.Setenv(CliAgentName, "claude-code")
if got := AgentName(); got != "claude-code" {
t.Fatalf("AgentName() = %q, want %q", got, "claude-code")
}
}
func TestAgentName_TrimsWhitespace(t *testing.T) {
const agentName = "sample-agent"
t.Setenv(CliAgentName, " "+agentName+" ")
if got := AgentName(); got != agentName {
t.Fatalf("AgentName() = %q, want %q (whitespace trimmed)", got, agentName)
t.Setenv(CliAgentName, " cursor ")
if got := AgentName(); got != "cursor" {
t.Fatalf("AgentName() = %q, want %q (whitespace trimmed)", got, "cursor")
}
}

View File

@@ -38,10 +38,6 @@ type Stub struct {
// matches after the first hit. Each match appends to CapturedBodies.
Reusable bool
// Optional (optional): when true, Verify does not require this stub to be
// matched. Useful for negative assertions via OnMatch.
Optional bool
// CapturedHeaders records the request headers of the matched request.
// Populated after RoundTrip matches this stub.
CapturedHeaders http.Header
@@ -141,9 +137,6 @@ func (r *Registry) Verify(t testing.TB) {
if s.matched {
continue
}
if s.Optional {
continue
}
// Reusable stubs never set s.matched; treat any captured hit as a match.
if s.Reusable && len(s.CapturedBodies) > 0 {
continue

View File

@@ -1,301 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package catalog
import (
"fmt"
"sort"
)
func ack(key string) Contract {
return Contract{Key: ContractKey(key), Strategy: Strategy{Kind: AuthoritativeAckKind}, ReplayMode: ReplayForbidden}
}
func required(key string, result RequiredSpec, replay ReplayMode) Contract {
return Contract{
Key: ContractKey(key),
Strategy: Strategy{Kind: RequiredResultKind, Required: result},
ReplayMode: replay,
}
}
func batch(key string, request EvidenceSpec, failures ...EvidenceSpec) Contract {
return Contract{
Key: ContractKey(key),
PartialRecovery: PartialRecoveryFailedItemsOnly,
Strategy: Strategy{
Kind: BatchPartialKind,
Request: request,
Failures: failures,
},
ReplayMode: ReplayForbidden,
}
}
func read(key string, kind StrategyKind) Contract {
return Contract{
Key: ContractKey(key),
Strategy: Strategy{Kind: kind},
}
}
func search(key, collectionField string) Contract {
contract := Contract{
Key: ContractKey(key),
Strategy: Strategy{
Kind: SearchReadKind,
CollectionField: collectionField,
},
}
if key == "im +messages-search" {
contract.Strategy.RequiresMaterialization = true
}
return contract
}
func topString(field string) RequiredSpec {
return RequiredSpec{Shape: RequiredTopString, Field: field}
}
func topObject(field string) RequiredSpec {
return RequiredSpec{Shape: RequiredTopObject, Field: field}
}
func nestedString(field, child string) RequiredSpec {
return RequiredSpec{Shape: RequiredNestedString, Field: field, Child: child}
}
func stringsFrom(field string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceStrings, Field: field}
}
func objectsFrom(field, idField string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceObjects, Field: field, IDField: idField}
}
func nestedObjectsFrom(field, container, idField string) EvidenceSpec {
return EvidenceSpec{
Shape: EvidenceNestedObjects, Field: field, Container: container, IDField: idField,
}
}
func feedObjectsFrom(field string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceFeedObjects, Field: field}
}
func nestedFeedObjectsFrom(field, container string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceNestedFeedObjects, Field: field, Container: container}
}
func statusObjectsFrom(field, idField string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceStatusObjects, Field: field, IDField: idField}
}
var contracts = buildContracts()
func buildContracts() map[ContractKey]Contract {
all := []Contract{
read("im +feed-group-query-item", EntityReadKind),
read("im +messages-mget", EntityReadKind),
read("im chat.nickname get", EntityReadKind),
read("im chat.user_setting batch_query", EntityReadKind),
read("im chats get", EntityReadKind),
read("im feed.groups batch_query", EntityReadKind),
func() Contract {
c := read("im reactions batch_query", EntityReadKind)
c.Strategy.ReadHint = HintBatchReactions
return c
}(),
read("im +chat-list", CollectionReadKind),
read("im +chat-members-list", CollectionReadKind),
read("im +chat-messages-list", CollectionReadKind),
read("im +feed-group-list", CollectionReadKind),
read("im +feed-group-list-item", CollectionReadKind),
read("im +feed-shortcut-list", CollectionReadKind),
read("im +flag-list", CollectionReadKind),
read("im +threads-messages-list", CollectionReadKind),
read("im chat.members bots", EntityReadKind),
read("im chat.members get", CollectionReadKind),
read("im chat.moderation get", CollectionReadKind),
read("im messages read_users", CollectionReadKind),
read("im pins list", CollectionReadKind),
read("im reactions list", CollectionReadKind),
search("im +chat-search", "chats"),
search("im +messages-search", "messages"),
read("im +messages-resources-download", MaterializeReadKind),
ack("im +chat-update"),
ack("im +flag-create"),
ack("im chat.nickname delete"),
ack("im chat.nickname update"),
ack("im chats update"),
ack("im feed.groups delete"),
ack("im feed.groups update"),
ack("im messages delete"),
ack("im pins delete"),
required("im +chat-create", topString("chat_id"), ReplaySameIdempotencyKey),
required("im +messages-reply", topString("message_id"), ReplaySameIdempotencyKey),
required("im +messages-send", topString("message_id"), ReplaySameIdempotencyKey),
required("im chats create", topString("chat_id"), ReplaySameIdempotencyKey),
required("im chats link", topString("share_link"), ReplayForbidden),
required("im feed.groups create", topString("group_id"), ReplayForbidden),
required("im images create", topString("image_key"), ReplayForbidden),
required("im messages forward", topString("message_id"), ReplaySameIdempotencyKey),
required("im pins create", topObject("pin"), ReplayForbidden),
required("im reactions create", topString("reaction_id"), ReplayForbidden),
required("im reactions delete", topString("reaction_id"), ReplayForbidden),
required("im threads forward", topString("message_id"), ReplaySameIdempotencyKey),
func() Contract {
c := batch(
"im +feed-shortcut-create",
objectsFrom("shortcuts", "feed_card_id"),
nestedObjectsFrom("failed_shortcuts", "shortcut", "feed_card_id"),
)
c.ReplayMode = ReplaySafe
c.PartialRecovery = PartialRecoveryWholeRequest
return c
}(),
func() Contract {
c := batch(
"im +feed-shortcut-remove",
objectsFrom("shortcuts", "feed_card_id"),
nestedObjectsFrom("failed_shortcuts", "shortcut", "feed_card_id"),
)
c.ReplayMode = ReplaySafe
c.PartialRecovery = PartialRecoveryWholeRequest
return c
}(),
{
Key: "im +flag-cancel",
PartialRecovery: PartialRecoveryWholeRequest,
Strategy: Strategy{
Kind: BatchPartialKind,
ResultLedger: ptrEvidence(statusObjectsFrom("results", "flag_type")),
},
ReplayMode: ReplaySafe,
},
{
Key: "im chat.members create",
Strategy: Strategy{
Kind: BatchPartialKind,
Request: stringsFrom("id_list"),
Failures: []EvidenceSpec{
stringsFrom("invalid_id_list"),
stringsFrom("not_existed_id_list"),
},
Pending: []EvidenceSpec{stringsFrom("pending_approval_id_list")},
},
ReplayMode: ReplayForbidden,
},
batch("im chat.members delete", stringsFrom("id_list"), stringsFrom("invalid_id_list")),
batch(
"im chat.user_setting batch_update",
objectsFrom("chat_settings", "chat_id"),
objectsFrom("invalid_ids", "id"),
),
{
Key: "im feed.groups batch_add_item",
Strategy: Strategy{
Kind: BatchPartialKind,
Request: feedObjectsFrom("items"),
Failures: []EvidenceSpec{nestedFeedObjectsFrom("failed_items", "item")},
},
ReplayMode: ReplayForbidden,
},
{
Key: "im feed.groups batch_remove_item",
Strategy: Strategy{
Kind: BatchPartialKind,
Request: feedObjectsFrom("items"),
Failures: []EvidenceSpec{nestedFeedObjectsFrom("failed_items", "item")},
},
ReplayMode: ReplayForbidden,
},
batch("im messages urgent_app", stringsFrom("user_id_list"), stringsFrom("invalid_user_id_list")),
batch("im messages urgent_phone", stringsFrom("user_id_list"), stringsFrom("invalid_user_id_list")),
batch("im messages urgent_sms", stringsFrom("user_id_list"), stringsFrom("invalid_user_id_list")),
{
Key: "im messages merge_forward",
Strategy: Strategy{
Kind: RequiredResultBatchPartialKind,
Required: nestedString("message", "message_id"),
Request: stringsFrom("message_id_list"),
Failures: []EvidenceSpec{stringsFrom("invalid_message_id_list")},
},
ReplayMode: ReplaySameIdempotencyKey,
},
{
Key: "im chat.managers add_managers",
Strategy: Strategy{
Kind: ResponseSetAssertionKind,
Request: stringsFrom("manager_ids"),
ResponseSets: []EvidenceSpec{stringsFrom("chat_managers"), stringsFrom("chat_bot_managers")},
Assertion: AssertRequestedPresent,
},
ReplayMode: ReplayForbidden,
},
{
Key: "im chat.managers delete_managers",
Strategy: Strategy{
Kind: ResponseSetAssertionKind,
Request: stringsFrom("manager_ids"),
ResponseSets: []EvidenceSpec{stringsFrom("chat_managers"), stringsFrom("chat_bot_managers")},
Assertion: AssertRequestedAbsent,
},
ReplayMode: ReplayForbidden,
},
{
Key: "im chat.moderation update",
Strategy: Strategy{Kind: AcceptanceOnlyKind},
ReplayMode: ReplayForbidden,
},
}
out := make(map[ContractKey]Contract, len(all))
for _, c := range all {
if c.PartialRecovery == "" &&
(c.Strategy.Kind == BatchPartialKind || c.Strategy.Kind == RequiredResultBatchPartialKind) {
c.PartialRecovery = PartialRecoveryFailedItemsOnly
}
switch {
case c.Strategy.Kind == CollectionReadKind || c.Strategy.Kind == SearchReadKind:
c.HelpPolicy = HelpCompleteness
case c.Strategy.Kind == AcceptanceOnlyKind:
c.HelpPolicy = HelpAcceptanceOnly
}
out[c.Key] = c
}
return out
}
func ptrEvidence(spec EvidenceSpec) *EvidenceSpec {
return &spec
}
func Lookup(key ContractKey) (Contract, bool) {
c, ok := contracts[key]
return c, ok
}
func All() []Contract {
out := make([]Contract, 0, len(contracts))
for _, c := range contracts {
out = append(out, c)
}
sort.Slice(out, func(i, j int) bool { return out[i].Key < out[j].Key })
return out
}
func ValidateRegistry() error {
for key, c := range contracts {
if key == "" || c.Strategy.Kind == "" {
return fmt.Errorf("invalid IM contract %q", key)
}
}
return nil
}

View File

@@ -1,32 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package catalog
import "testing"
func TestWholeRequestPartialRecoveryContracts(t *testing.T) {
for _, key := range []ContractKey{
"im +feed-shortcut-create",
"im +feed-shortcut-remove",
"im +flag-cancel",
} {
contract, ok := Lookup(key)
if !ok {
t.Fatalf("missing contract %q", key)
}
if contract.PartialRecovery != PartialRecoveryWholeRequest {
t.Fatalf("%s partial recovery = %q", key, contract.PartialRecovery)
}
}
remove, _ := Lookup("im +feed-shortcut-remove")
if remove.ReplayMode != ReplaySafe {
t.Fatalf("feed shortcut remove replay mode = %q", remove.ReplayMode)
}
urgent, _ := Lookup("im messages urgent_app")
if urgent.PartialRecovery != PartialRecoveryFailedItemsOnly {
t.Fatalf("urgent app partial recovery = %q", urgent.PartialRecovery)
}
}

View File

@@ -1,139 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
// Package catalog defines the static IM command completion contract catalog.
package catalog
type ContractKey string
type StrategyKind string
const (
EntityReadKind StrategyKind = "entity_read"
CollectionReadKind StrategyKind = "collection_read"
SearchReadKind StrategyKind = "search_read"
MaterializeReadKind StrategyKind = "materialize_read"
AuthoritativeAckKind StrategyKind = "authoritative_ack"
RequiredResultKind StrategyKind = "required_result"
BatchPartialKind StrategyKind = "batch_partial"
RequiredResultBatchPartialKind StrategyKind = "required_result_batch_partial"
ResponseSetAssertionKind StrategyKind = "response_set_assertion"
AcceptanceOnlyKind StrategyKind = "acceptance_only"
)
func (k StrategyKind) IsWrite() bool {
switch k {
case AuthoritativeAckKind, RequiredResultKind, BatchPartialKind,
RequiredResultBatchPartialKind, ResponseSetAssertionKind, AcceptanceOnlyKind:
return true
default:
return false
}
}
func (k StrategyKind) IsRead() bool {
switch k {
case EntityReadKind, CollectionReadKind, SearchReadKind, MaterializeReadKind:
return true
default:
return false
}
}
type ReplayMode string
const (
ReplayForbidden ReplayMode = "forbidden"
ReplaySafe ReplayMode = "safe"
ReplaySameIdempotencyKey ReplayMode = "same_idempotency_key"
)
type PartialRecoveryMode string
const (
PartialRecoveryWholeRequest PartialRecoveryMode = "whole_request"
PartialRecoveryFailedItemsOnly PartialRecoveryMode = "failed_items_only"
)
type AssertionMode string
const (
AssertRequestedPresent AssertionMode = "requested_present"
AssertRequestedAbsent AssertionMode = "requested_absent"
)
type RequiredShape uint8
const (
RequiredTopString RequiredShape = iota + 1
RequiredTopObject
RequiredNestedString
)
type EvidenceShape uint8
const (
EvidenceStrings EvidenceShape = iota + 1
EvidenceObjects
EvidenceNestedObjects
EvidenceFeedObjects
EvidenceNestedFeedObjects
EvidenceStatusObjects
)
type RequiredSpec struct {
Shape RequiredShape
Field string
Child string
}
type EvidenceSpec struct {
Shape EvidenceShape
Field string
IDField string
Container string
}
type Strategy struct {
Kind StrategyKind
Required RequiredSpec
Request EvidenceSpec
Failures []EvidenceSpec
Pending []EvidenceSpec
ResponseSets []EvidenceSpec
Assertion AssertionMode
ResultLedger *EvidenceSpec
// CollectionField is only used by the two fixed IM search strategies to
// determine whether an exhausted search returned no candidates. It is not
// a general response path or field extractor.
CollectionField string
RequiresMaterialization bool
ReadHint string
}
type HelpPolicy string
const (
HelpCompleteness HelpPolicy = "completeness"
HelpAcceptanceOnly HelpPolicy = "acceptance_only"
HintBatchReactions = "This result covers only the returned reaction fragments; use `im reactions list` to exhaust one message's reactions."
)
func (p HelpPolicy) Text() string {
switch p {
case HelpCompleteness:
return "Completeness: use --page-all --page-limit 0 for exhaustive output; only meta.complete=true proves completion."
case HelpAcceptanceOnly:
return "Verify the final state with lark-cli im chat.moderation get --chat-id <same_chat_id> --as <same_identity>."
default:
return ""
}
}
type Contract struct {
Key ContractKey
Strategy Strategy
ReplayMode ReplayMode
PartialRecovery PartialRecoveryMode
HelpPolicy HelpPolicy
}

View File

@@ -1,43 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"strings"
"github.com/spf13/cobra"
)
const (
helpContractAnnotation = "imcontract.help.contract-key"
helpSameKeyReplay = "Idempotent retry: generate the key outside this command, then reuse the same literal with unchanged parameters on every retry."
)
func AnnotateHelpContract(cmd *cobra.Command, key ContractKey) {
if cmd == nil || key == "" {
return
}
if cmd.Annotations == nil {
cmd.Annotations = map[string]string{}
}
cmd.Annotations[helpContractAnnotation] = string(key)
}
func HelpText(cmd *cobra.Command) string {
if cmd == nil || !cmd.Runnable() || cmd.Annotations == nil {
return ""
}
contract, ok := Lookup(ContractKey(cmd.Annotations[helpContractAnnotation]))
if !ok {
return ""
}
var lines []string
if policy := contract.HelpPolicy.Text(); policy != "" {
lines = append(lines, policy)
}
if contract.ReplayMode == ReplaySameIdempotencyKey {
lines = append(lines, helpSameKeyReplay)
}
return strings.Join(lines, "\n")
}

View File

@@ -1,88 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"testing"
"github.com/spf13/cobra"
)
func TestHelpPolicyTextUsesOnlyApprovedTemplates(t *testing.T) {
tests := []struct {
policy HelpPolicy
want string
}{
{HelpCompleteness, "Completeness: use --page-all --page-limit 0 for exhaustive output; only meta.complete=true proves completion."},
{HelpAcceptanceOnly, "Verify the final state with lark-cli im chat.moderation get --chat-id <same_chat_id> --as <same_identity>."},
{HelpPolicy("unknown"), ""},
}
for _, tt := range tests {
if got := tt.policy.Text(); got != tt.want {
t.Fatalf("HelpPolicy(%q).Text() = %q, want %q", tt.policy, got, tt.want)
}
}
}
func TestRegistryHelpPolicies(t *testing.T) {
tests := []struct {
key ContractKey
want HelpPolicy
}{
{"im +chat-list", HelpCompleteness},
{"im +messages-search", HelpCompleteness},
{"im chat.moderation get", HelpCompleteness},
{"im +messages-send", ""},
{"im messages merge_forward", ""},
{"im chat.moderation update", HelpAcceptanceOnly},
{"im +flag-create", ""},
}
for _, tt := range tests {
contract, ok := Lookup(tt.key)
if !ok {
t.Fatalf("missing contract %q", tt.key)
}
if contract.HelpPolicy != tt.want {
t.Fatalf("%s HelpPolicy = %q, want %q", tt.key, contract.HelpPolicy, tt.want)
}
}
}
func TestHelpTextIsLazyAndRunnableOnly(t *testing.T) {
cmd := &cobra.Command{Use: "+chat-list", Short: "List chats", Run: func(*cobra.Command, []string) {}}
AnnotateHelpContract(cmd, "im +chat-list")
if cmd.Long != "" || cmd.Short != "List chats" {
t.Fatalf("annotation changed visible help fields: Short=%q Long=%q", cmd.Short, cmd.Long)
}
if got := HelpText(cmd); got != HelpCompleteness.Text() {
t.Fatalf("HelpText() = %q", got)
}
parent := &cobra.Command{Use: "im"}
AnnotateHelpContract(parent, "im +chat-list")
if got := HelpText(parent); got != "" {
t.Fatalf("parent HelpText() = %q, want empty", got)
}
}
func TestHelpTextAddsSameKeyReplayOnlyToApplicableCommands(t *testing.T) {
const approvedSameKeyText = "Idempotent retry: generate the key outside this command, then reuse the same literal with unchanged parameters on every retry."
if helpSameKeyReplay != approvedSameKeyText {
t.Fatalf("same-key help = %q, want approved text %q", helpSameKeyReplay, approvedSameKeyText)
}
tests := []struct {
key ContractKey
want string
}{
{"im +messages-send", approvedSameKeyText},
{"im +chat-create", approvedSameKeyText},
{"im +chat-update", ""},
}
for _, tt := range tests {
cmd := &cobra.Command{Use: "leaf", Run: func(*cobra.Command, []string) {}}
AnnotateHelpContract(cmd, tt.key)
if got := HelpText(cmd); got != tt.want {
t.Fatalf("%s HelpText() = %q, want %q", tt.key, got, tt.want)
}
}
}

View File

@@ -1,45 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import "github.com/larksuite/cli/errs"
// NormalizeHTTPError makes HTTP status authoritative for contract-managed IM
// responses. It prevents a JSON body with code 0 or an unknown business code
// from hiding an HTTP failure. Non-IM callers do not opt into this behavior.
func NormalizeHTTPError(status int, logID string, err error) error {
if status < 400 {
return err
}
if status >= 500 {
normalized := errs.NewNetworkError(
errs.SubtypeNetworkServer,
"HTTP %d server error",
status,
).WithCode(status).WithRetryable()
if logID != "" {
normalized.WithLogID(logID)
}
return normalized
}
if status == 429 {
normalized := errs.NewAPIError(errs.SubtypeRateLimit, "HTTP 429 rate limit").WithCode(status)
if logID != "" {
normalized.WithLogID(logID)
}
return normalized
}
if err != nil {
return err
}
subtype := errs.SubtypeUnknown
if status == 404 {
subtype = errs.SubtypeNotFound
}
normalized := errs.NewAPIError(subtype, "HTTP %d request failed", status).WithCode(status)
if logID != "" {
normalized.WithLogID(logID)
}
return normalized
}

View File

@@ -1,40 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"testing"
"github.com/larksuite/cli/errs"
)
func TestNormalizeHTTPError(t *testing.T) {
original := errs.NewAPIError(errs.SubtypeUnknown, "business error").WithCode(123)
got := NormalizeHTTPError(503, "log-id", original)
problem, ok := errs.ProblemOf(got)
if !ok || problem.Category != errs.CategoryNetwork ||
problem.Subtype != errs.SubtypeNetworkServer ||
problem.Code != 503 || problem.LogID != "log-id" || !problem.Retryable {
t.Fatalf("normalized problem = %#v, err=%T %v", problem, got, got)
}
rateLimited := NormalizeHTTPError(429, "rate-log", nil)
rateProblem, ok := errs.ProblemOf(rateLimited)
if !ok || rateProblem.Category != errs.CategoryAPI ||
rateProblem.Subtype != errs.SubtypeRateLimit ||
rateProblem.Code != 429 || rateProblem.LogID != "rate-log" || rateProblem.Retryable {
t.Fatalf("rate-limit problem = %#v, err=%T %v", rateProblem, rateLimited, rateLimited)
}
notFound := NormalizeHTTPError(404, "", nil)
notFoundProblem, ok := errs.ProblemOf(notFound)
if !ok || notFoundProblem.Subtype != errs.SubtypeNotFound ||
notFoundProblem.Code != 404 || notFoundProblem.Retryable {
t.Fatalf("not-found problem = %#v, err=%T %v", notFoundProblem, notFound, notFound)
}
if unchanged := NormalizeHTTPError(200, "", original); unchanged != original {
t.Fatalf("successful status was normalized: %T %v", unchanged, unchanged)
}
}

View File

@@ -1,32 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"fmt"
"maps"
)
const IdentityDefaultedNoticeKey = "identity_defaulted"
// IdentityDefaultedMessage explains both the observed choice and why callers
// should make it explicit when reproducibility matters.
func IdentityDefaultedMessage(identity string) string {
return fmt.Sprintf("--as was omitted; this IM write used %s. Pass --as explicitly for reproducible behavior.", identity)
}
// WithIdentityDefaultedNotice returns a copy of base with the command-scoped
// notice added. The copy prevents an invocation-specific fact from leaking
// into the process-wide update/skills notice map.
func WithIdentityDefaultedNotice(base map[string]interface{}, identity string) map[string]interface{} {
notice := maps.Clone(base)
if notice == nil {
notice = make(map[string]interface{}, 1)
}
notice[IdentityDefaultedNoticeKey] = map[string]interface{}{
"resolved": identity,
"message": IdentityDefaultedMessage(identity),
}
return notice
}

View File

@@ -1,31 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import "testing"
func TestWithIdentityDefaultedNoticeMergesWithoutMutatingBase(t *testing.T) {
base := map[string]interface{}{
"update": map[string]interface{}{"available": true},
}
got := WithIdentityDefaultedNotice(base, "bot")
if _, ok := base[IdentityDefaultedNoticeKey]; ok {
t.Fatalf("base notice was mutated: %#v", base)
}
if got["update"] == nil {
t.Fatalf("existing notice was lost: %#v", got)
}
identity, ok := got[IdentityDefaultedNoticeKey].(map[string]interface{})
if !ok {
t.Fatalf("identity notice = %#v", got[IdentityDefaultedNoticeKey])
}
if identity["resolved"] != "bot" {
t.Fatalf("resolved = %#v, want bot", identity["resolved"])
}
if identity["message"] != IdentityDefaultedMessage("bot") {
t.Fatalf("message = %#v", identity["message"])
}
}

View File

@@ -1,248 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"encoding/json"
"fmt"
"strings"
)
type Completion struct {
Status string `json:"status"`
RequestedCount int `json:"requested_count"`
SucceededCount int `json:"succeeded_count"`
FailedCount int `json:"failed_count"`
PendingCount int `json:"pending_count"`
SucceededItems []any `json:"succeeded_items"`
FailedItems []any `json:"failed_items"`
PendingItems []any `json:"pending_items"`
RetryScope string `json:"retry_scope"`
}
type ledgerItem struct {
key string
value any
}
type extraction struct {
items []ledgerItem
rawCount int
selectedCount int
rejectedCount int
present bool
}
func extract(root map[string]any, spec evidenceSpec) extraction {
if root == nil || spec.Field == "" {
return extraction{}
}
raw, present := root[spec.Field]
if !present {
return extraction{}
}
values, ok := raw.([]any)
out := extraction{present: true}
if !ok {
out.rejectedCount = 1
return out
}
out.rawCount = len(values)
for _, value := range values {
item, ok := extractItem(value, spec)
if !ok {
out.rejectedCount++
continue
}
out.selectedCount++
out.items = append(out.items, item)
}
out.items = uniqueItems(out.items)
return out
}
func extractItem(value any, spec evidenceSpec) (ledgerItem, bool) {
switch spec.Shape {
case evidenceStrings:
return stringItem(value)
case evidenceObjects:
object, ok := value.(map[string]any)
if !ok {
return ledgerItem{}, false
}
return stringItem(object[spec.IDField])
case evidenceNestedObjects:
object, ok := nestedObject(value, spec.Container)
if !ok {
return ledgerItem{}, false
}
return stringItem(object[spec.IDField])
case evidenceFeedObjects:
object, ok := value.(map[string]any)
if !ok {
return ledgerItem{}, false
}
return feedItem(object)
case evidenceNestedFeedObjects:
object, ok := nestedObject(value, spec.Container)
if !ok {
return ledgerItem{}, false
}
return feedItem(object)
case evidenceStatusObjects:
object, ok := value.(map[string]any)
if !ok {
return ledgerItem{}, false
}
status := nonEmptyString(object["status"])
if status != "ok" && status != "failed" {
return ledgerItem{}, false
}
return stringItem(object[spec.IDField])
default:
return ledgerItem{}, false
}
}
func nestedObject(value any, field string) (map[string]any, bool) {
object, ok := value.(map[string]any)
if !ok {
return nil, false
}
nested, ok := object[field].(map[string]any)
return nested, ok
}
func stringItem(value any) (ledgerItem, bool) {
id := stableID(value)
if id == "" {
return ledgerItem{}, false
}
return ledgerItem{key: id, value: id}, true
}
func feedItem(object map[string]any) (ledgerItem, bool) {
feedID := stableID(object["feed_id"])
feedType := stableID(object["feed_type"])
if feedID == "" || feedType == "" {
return ledgerItem{}, false
}
return ledgerItem{
key: feedType + "\x00" + feedID,
value: map[string]any{
"feed_id": feedID, "feed_type": feedType,
},
}, true
}
func nonEmptyString(value any) string {
text, ok := value.(string)
if !ok {
return ""
}
return strings.TrimSpace(text)
}
func stableID(value any) string {
switch id := value.(type) {
case string:
return strings.TrimSpace(id)
case json.Number:
return string(id)
case int, int8, int16, int32, int64, uint, uint8, uint16, uint32, uint64:
return fmt.Sprint(id)
default:
return ""
}
}
func uniqueItems(items []ledgerItem) []ledgerItem {
out := make([]ledgerItem, 0, len(items))
seen := make(map[string]struct{}, len(items))
for _, item := range items {
if item.key == "" {
continue
}
if _, ok := seen[item.key]; ok {
continue
}
seen[item.key] = struct{}{}
out = append(out, item)
}
return out
}
func completion(requested, failed, pending []ledgerItem, recovery PartialRecoveryMode) Completion {
requested = uniqueItems(requested)
requestedSet := make(map[string]struct{}, len(requested))
for _, item := range requested {
requestedSet[item.key] = struct{}{}
}
filterRequested := func(items []ledgerItem, excluded map[string]struct{}) []ledgerItem {
out := make([]ledgerItem, 0, len(items))
for _, item := range uniqueItems(items) {
if _, ok := requestedSet[item.key]; !ok {
continue
}
if _, blocked := excluded[item.key]; blocked {
continue
}
out = append(out, item)
}
return out
}
// A contradictory pending+failed response is treated as pending. Pending
// means the final state is unknown, so authorizing a retry would be unsafe.
pending = filterRequested(pending, nil)
pendingSet := make(map[string]struct{}, len(pending))
for _, item := range pending {
pendingSet[item.key] = struct{}{}
}
failed = filterRequested(failed, pendingSet)
blocked := make(map[string]struct{}, len(failed)+len(pending))
for key := range pendingSet {
blocked[key] = struct{}{}
}
for _, item := range failed {
blocked[item.key] = struct{}{}
}
succeeded := make([]ledgerItem, 0, len(requested))
for _, item := range requested {
if _, exists := blocked[item.key]; !exists {
succeeded = append(succeeded, item)
}
}
status := "complete"
retryScope := "none"
if len(failed) > 0 || len(pending) > 0 {
status = "partial"
switch {
case len(pending) > 0:
retryScope = "none"
case recovery == PartialRecoveryWholeRequest:
retryScope = "whole_request"
default:
retryScope = "failed_items_only"
}
}
values := func(items []ledgerItem) []any {
out := make([]any, 0, len(items))
for _, item := range items {
out = append(out, item.value)
}
return out
}
return Completion{
Status: status,
RequestedCount: len(requested),
SucceededCount: len(succeeded),
FailedCount: len(failed),
PendingCount: len(pending),
SucceededItems: values(succeeded),
FailedItems: values(failed),
PendingItems: values(pending),
RetryScope: retryScope,
}
}

View File

@@ -1,43 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
// MaterializationStatus records the IM-only search-to-detail reconciliation.
// RequestedIDs and ResolvedIDs are internal evidence and are never serialized;
// only missing requested IDs may be exposed for targeted recovery.
type MaterializationStatus struct {
RequestedIDs []string `json:"-"`
ResolvedIDs []string `json:"-"`
MissingMessageIDs []string
UnresolvedHitCount int
UnexpectedMessageCount int
Cause error `json:"-"`
}
func (s MaterializationStatus) complete() bool {
return s.Cause == nil &&
len(s.MissingMessageIDs) == 0 &&
s.UnresolvedHitCount == 0 &&
s.UnexpectedMessageCount == 0 &&
len(s.RequestedIDs) == len(s.ResolvedIDs)
}
func (s MaterializationStatus) ledger() map[string]any {
status := "partial"
if s.complete() {
status = "complete"
}
missing := append([]string(nil), s.MissingMessageIDs...)
if missing == nil {
missing = []string{}
}
return map[string]any{
"status": status,
"requested_count": len(s.RequestedIDs),
"resolved_count": len(s.ResolvedIDs),
"missing_message_ids": missing,
"unresolved_hit_count": s.UnresolvedHitCount,
"unexpected_message_count": s.UnexpectedMessageCount,
}
}

View File

@@ -1,215 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import "github.com/larksuite/cli/internal/output"
type MessageMentionRequest struct {
IDs []string
All bool
}
type MessageMentionConfirmation struct {
RequestedID string `json:"requested_id"`
ID string `json:"id"`
IDType string `json:"id_type"`
Key string `json:"key"`
}
type MessageMentionResult struct {
Status string `json:"status"`
Requested []string `json:"requested"`
Confirmed []MessageMentionConfirmation `json:"confirmed"`
Missing []string `json:"missing"`
UnattributedRequested []string `json:"unattributed_requested,omitempty"`
All string `json:"all"`
RetryScope string `json:"retry_scope"`
}
// BuildMessageMentionResult compares the structured mention request with the
// returned mention entries. Exact open_id matches are confirmed; unmatched or
// ambiguous entries remain unattributed and never authorize replay.
func BuildMessageMentionResult(request MessageMentionRequest, response any) MessageMentionResult {
requested := append([]string(nil), request.IDs...)
result := MessageMentionResult{
Requested: requested,
Confirmed: []MessageMentionConfirmation{},
Missing: []string{},
All: "not_requested",
RetryScope: "none",
}
if request.All {
result.All = "accepted_unverified"
if len(requested) == 0 {
result.Status = "accepted_unverified"
return result
}
}
mentions, ambiguous := parseResponseMentions(response)
confirmed := make([]MessageMentionConfirmation, 0, len(requested))
confirmedIDs := make(map[string]struct{}, len(requested))
responseKeys := make(map[string]struct{}, len(mentions))
unknownEvidence := false
for _, mention := range mentions {
if mention.id == "all" || mention.id == "@_all" {
if !request.All {
unknownEvidence = true
}
continue
}
if mention.idType != "open_id" {
unknownEvidence = true
continue
}
if !contains(requested, mention.id) {
unknownEvidence = true
continue
}
if _, duplicate := responseKeys[mention.key]; duplicate {
ambiguous = true
continue
}
responseKeys[mention.key] = struct{}{}
if _, duplicate := confirmedIDs[mention.id]; duplicate {
ambiguous = true
continue
}
confirmedIDs[mention.id] = struct{}{}
confirmed = append(confirmed, MessageMentionConfirmation{
RequestedID: mention.id,
ID: mention.id,
IDType: mention.idType,
Key: mention.key,
})
}
unresolved := make([]string, 0, len(requested))
for _, id := range requested {
if _, ok := confirmedIDs[id]; !ok {
unresolved = append(unresolved, id)
}
}
if ambiguous || unknownEvidence || len(unresolved) > 0 {
result.Status = "partial_unattributed"
result.Confirmed = confirmed
if len(unresolved) > 0 {
result.UnattributedRequested = unresolved
} else {
// Do not place the same IDs in both confirmed and unattributed
// sets when extra entries make the result ambiguous.
result.Confirmed = []MessageMentionConfirmation{}
result.UnattributedRequested = append([]string(nil), requested...)
}
return result
}
result.Confirmed = confirmed
if request.All {
result.Status = "accepted_unverified"
} else {
result.Status = "complete"
}
return result
}
type responseMention struct {
key string
id string
idType string
}
func parseResponseMentions(response any) ([]responseMention, bool) {
if response == nil {
return nil, false
}
values, ok := response.([]any)
if !ok {
return nil, true
}
mentions := make([]responseMention, 0, len(values))
for _, value := range values {
object, ok := value.(map[string]any)
if !ok {
return mentions, true
}
mention := responseMention{
key: nonEmptyString(object["key"]),
id: nonEmptyString(object["id"]),
idType: nonEmptyString(object["id_type"]),
}
if mention.id == "all" || mention.id == "@_all" {
mentions = append(mentions, mention)
continue
}
if mention.key == "" || mention.id == "" || mention.idType == "" {
return mentions, true
}
mentions = append(mentions, mention)
}
return mentions, false
}
func contains(values []string, target string) bool {
for _, value := range values {
if value == target {
return true
}
}
return false
}
func finalizeMessageMentions(data any) (Result, error) {
root, err := checkedResponse(data)
if err != nil {
return Result{}, err
}
raw, present := root["mention_result"]
if !present {
return Result{OK: true, Data: root}, nil
}
mention, ok := raw.(MessageMentionResult)
if !ok || !validMentionResultShape(mention) {
return Result{}, invalidEvidence("mention_result")
}
result := Result{OK: true, Data: root}
switch mention.Status {
case "complete", "accepted_unverified":
return result, nil
case "partial", "partial_unattributed":
result.OK = false
result.ExitCode = output.ExitAPI
return result, nil
default:
return Result{}, invalidEvidence("mention_result")
}
}
func validMentionResultShape(result MessageMentionResult) bool {
if result.RetryScope != "none" {
return false
}
for _, confirmation := range result.Confirmed {
if confirmation.RequestedID == "" || confirmation.ID == "" ||
confirmation.IDType == "" || confirmation.Key == "" {
return false
}
}
if result.All != "not_requested" && result.All != "accepted_unverified" {
return false
}
switch result.Status {
case "complete":
return len(result.Missing) == 0 && result.All == "not_requested"
case "accepted_unverified":
return len(result.Missing) == 0 && result.All == "accepted_unverified"
case "partial":
return len(result.Requested) > 0 && len(result.Missing) > 0
case "partial_unattributed":
return len(result.Requested) > 0 && len(result.Missing) == 0 &&
len(result.UnattributedRequested) > 0
default:
return false
}
}

View File

@@ -1,214 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"testing"
"github.com/larksuite/cli/internal/output"
)
func TestBuildMessageMentionResult(t *testing.T) {
tests := []struct {
name string
request MessageMentionRequest
response any
wantStatus string
wantConfirmed int
wantMissing []string
wantUnattrib []string
wantAll string
}{
{
name: "all accepted without notification proof",
request: MessageMentionRequest{All: true},
wantStatus: "accepted_unverified",
wantAll: "accepted_unverified",
},
{
name: "all ignores unverified response shape",
request: MessageMentionRequest{All: true},
response: []any{
map[string]any{"key": "@_all", "id": "all"},
},
wantStatus: "accepted_unverified",
wantAll: "accepted_unverified",
},
{
name: "open ids confirmed exactly",
request: MessageMentionRequest{IDs: []string{"ou_alpha", "ou_beta"}},
response: []any{
map[string]any{"key": "@_user_1", "id": "ou_alpha", "id_type": "open_id"},
map[string]any{"key": "@_user_2", "id": "ou_beta", "id_type": "open_id"},
},
wantStatus: "complete",
wantConfirmed: 2,
wantAll: "not_requested",
},
{
name: "missing open id stays unattributed",
request: MessageMentionRequest{IDs: []string{"ou_alpha", "ou_beta"}},
response: []any{
map[string]any{"key": "@_user_1", "id": "ou_alpha", "id_type": "open_id"},
},
wantStatus: "partial_unattributed",
wantConfirmed: 1,
wantUnattrib: []string{"ou_beta"},
wantAll: "not_requested",
},
{
name: "normalized user id cannot be guessed",
request: MessageMentionRequest{IDs: []string{"u_alpha"}},
response: []any{
map[string]any{"key": "@_user_1", "id": "ou_normalized", "id_type": "open_id"},
},
wantStatus: "partial_unattributed",
wantUnattrib: []string{"u_alpha"},
wantAll: "not_requested",
},
{
name: "unknown response evidence is unattributed",
request: MessageMentionRequest{IDs: []string{"ou_alpha"}},
response: []any{
map[string]any{"key": "@_user_1", "id": "ou_unknown", "id_type": "open_id"},
},
wantStatus: "partial_unattributed",
wantUnattrib: []string{"ou_alpha"},
wantAll: "not_requested",
},
{
name: "duplicate response key is unattributed",
request: MessageMentionRequest{IDs: []string{"ou_alpha", "ou_beta"}},
response: []any{
map[string]any{"key": "@_user_1", "id": "ou_alpha", "id_type": "open_id"},
map[string]any{"key": "@_user_1", "id": "ou_beta", "id_type": "open_id"},
},
wantStatus: "partial_unattributed",
wantConfirmed: 1,
wantUnattrib: []string{"ou_beta"},
wantAll: "not_requested",
},
{
name: "extra unknown evidence invalidates otherwise complete mapping",
request: MessageMentionRequest{IDs: []string{"ou_alpha"}},
response: []any{
map[string]any{"key": "@_user_1", "id": "ou_alpha", "id_type": "open_id"},
map[string]any{"key": "@_user_2", "id": "ou_unknown", "id_type": "open_id"},
},
wantStatus: "partial_unattributed",
wantUnattrib: []string{"ou_alpha"},
wantAll: "not_requested",
},
{
name: "duplicate requested evidence invalidates otherwise complete mapping",
request: MessageMentionRequest{IDs: []string{"ou_alpha"}},
response: []any{
map[string]any{"key": "@_user_1", "id": "ou_alpha", "id_type": "open_id"},
map[string]any{"key": "@_user_2", "id": "ou_alpha", "id_type": "open_id"},
},
wantStatus: "partial_unattributed",
wantUnattrib: []string{"ou_alpha"},
wantAll: "not_requested",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := BuildMessageMentionResult(tt.request, tt.response)
if got.Status != tt.wantStatus {
t.Fatalf("status = %v, want %q", got.Status, tt.wantStatus)
}
if got.RetryScope != "none" {
t.Fatalf("retry_scope = %v, want none", got.RetryScope)
}
if got.All != tt.wantAll {
t.Fatalf("all = %v, want %q", got.All, tt.wantAll)
}
if len(got.Confirmed) != tt.wantConfirmed {
t.Fatalf("confirmed = %#v, want len %d", got.Confirmed, tt.wantConfirmed)
}
assertStringSlice(t, got.Missing, tt.wantMissing)
assertStringSlice(t, got.UnattributedRequested, tt.wantUnattrib)
})
}
}
func TestFinalizeMessageMentionResult(t *testing.T) {
contract, ok := Lookup("im +messages-send")
if !ok {
t.Fatal("messages-send contract missing")
}
tests := []struct {
name string
mention any
wantOK bool
wantExit int
wantErr bool
}{
{name: "absent stays compatible", wantOK: true},
{name: "complete", mention: validMentionResult("complete"), wantOK: true},
{name: "accepted all", mention: validMentionResult("accepted_unverified"), wantOK: true},
{name: "partial", mention: validMentionResult("partial"), wantExit: output.ExitAPI},
{name: "partial unattributed", mention: validMentionResult("partial_unattributed"), wantExit: output.ExitAPI},
{name: "unknown status", mention: validMentionResult("mystery"), wantErr: true},
{name: "replay scope cannot authorize replay", mention: MessageMentionResult{
Status: "partial", Requested: []string{"ou_a"}, Confirmed: []MessageMentionConfirmation{},
Missing: []string{"ou_a"}, All: "not_requested", RetryScope: "whole_request",
}, wantErr: true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
data := map[string]any{"message_id": "om_result"}
if tt.mention != nil {
data["mention_result"] = tt.mention
}
got, err := NewSession(contract).FinalizeSuccess(data)
if (err != nil) != tt.wantErr {
t.Fatalf("FinalizeSuccess() error = %v, wantErr %v", err, tt.wantErr)
}
if err != nil {
return
}
if got.OK != tt.wantOK || got.ExitCode != tt.wantExit {
t.Fatalf("result = %#v, want ok=%v exit=%d", got, tt.wantOK, tt.wantExit)
}
})
}
}
func validMentionResult(status string) MessageMentionResult {
result := MessageMentionResult{
Status: status,
Requested: []string{},
Confirmed: []MessageMentionConfirmation{},
Missing: []string{},
All: "not_requested",
RetryScope: "none",
}
switch status {
case "accepted_unverified":
result.All = "accepted_unverified"
case "partial":
result.Requested = []string{"ou_a"}
result.Missing = []string{"ou_a"}
case "partial_unattributed":
result.Requested = []string{"u_a"}
result.UnattributedRequested = []string{"u_a"}
}
return result
}
func assertStringSlice(t *testing.T, got, want []string) {
t.Helper()
if len(got) != len(want) {
t.Fatalf("value = %#v, want %#v", got, want)
}
for i := range want {
if got[i] != want[i] {
t.Fatalf("value = %#v, want %#v", got, want)
}
}
}

View File

@@ -1,118 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
)
// BuildJQOutputFallback returns the self-contained result emitted when jq
// presentation fails after an IM write has already been finalized.
func BuildJQOutputFallback(result Result) (output.Envelope, error) {
problem := errs.NewAPIError(
errs.SubtypeUnknown,
"Output failed after the IM write completed",
)
return buildOutputFallback(result, &problem.Problem), output.PartialFailure(output.ExitAPI)
}
// BuildContentSafetyOutputFallback returns the self-contained result emitted
// when content-safety blocks presentation after an IM write has already been
// finalized.
func BuildContentSafetyOutputFallback(result Result) (output.Envelope, error) {
problem := errs.NewContentSafetyError(
errs.SubtypeContentSafety,
"Output blocked after the IM write completed",
)
return buildOutputFallback(result, &problem.Problem), output.PartialFailure(output.ExitContentSafety)
}
func buildOutputFallback(result Result, problem *errs.Problem) output.Envelope {
return output.Envelope{
OK: false,
Data: map[string]any{
"completion": allowlistedCompletion(result.Data),
},
Error: problem,
}
}
func allowlistedCompletion(data any) map[string]any {
summary := map[string]any{
"status": "complete",
"retry_scope": "none",
}
root, ok := data.(map[string]any)
if !ok {
return summary
}
completionValue, hasCompletion := root["completion"]
switch completion := completionValue.(type) {
case Completion:
copyCompletionStatus(summary, completion.Status)
summary["requested_count"] = completion.RequestedCount
summary["succeeded_count"] = completion.SucceededCount
summary["failed_count"] = completion.FailedCount
summary["pending_count"] = completion.PendingCount
copyCompletionRetryScope(summary, completion.RetryScope)
return summary
case map[string]any:
if value, ok := completion["status"].(string); ok {
copyCompletionStatus(summary, value)
}
copyCompletionCount(summary, completion, "requested_count")
copyCompletionCount(summary, completion, "succeeded_count")
copyCompletionCount(summary, completion, "failed_count")
copyCompletionCount(summary, completion, "pending_count")
if value, exists := completion["final_state_verified"]; exists {
if verified, valid := value.(bool); valid {
summary["final_state_verified"] = verified
}
}
if value, ok := completion["retry_scope"].(string); ok {
copyCompletionRetryScope(summary, value)
}
}
if !hasCompletion {
if mention, ok := root["mention_result"].(MessageMentionResult); ok {
copyCompletionStatus(summary, mention.Status)
copyCompletionRetryScope(summary, mention.RetryScope)
}
}
return summary
}
func copyCompletionStatus(dst map[string]any, value string) {
switch value {
case "complete", "partial", "accepted_unverified", "partial_unattributed":
dst["status"] = value
}
}
func copyCompletionRetryScope(dst map[string]any, value string) {
switch value {
case "none", "whole_request", "failed_items_only":
dst["retry_scope"] = value
}
}
func copyCompletionCount(dst, src map[string]any, key string) {
switch value := src[key].(type) {
case int:
dst[key] = value
case int32:
dst[key] = value
case int64:
dst[key] = value
case uint:
dst[key] = value
case uint32:
dst[key] = value
case uint64:
dst[key] = value
case float64:
dst[key] = value
}
}

View File

@@ -1,140 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"encoding/json"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
)
func TestOutputFallbackBuildsCompletionByAllowlist(t *testing.T) {
const secret = "SECRET_MARKER"
tests := []struct {
name string
result Result
wantStatus string
wantScope string
wantCounts bool
wantFinal bool
}{
{
name: "completed required result",
result: Result{OK: true, Data: map[string]any{
"message_id": secret,
}},
wantStatus: "complete",
wantScope: "none",
},
{
name: "batch partial",
result: Result{Data: map[string]any{
"completion": Completion{
Status: "partial",
RequestedCount: 2,
SucceededCount: 1,
FailedCount: 1,
FailedItems: []any{secret},
RetryScope: "failed_items_only",
},
}},
wantStatus: "partial",
wantScope: "failed_items_only",
wantCounts: true,
},
{
name: "accepted unverified",
result: Result{OK: true, Data: map[string]any{
"completion": map[string]any{
"status": "accepted_unverified",
"final_state_verified": false,
"retry_scope": "none",
"message": secret,
},
}},
wantStatus: "accepted_unverified",
wantScope: "none",
wantFinal: true,
},
{
name: "mention partial",
result: Result{Data: map[string]any{
"mention_result": MessageMentionResult{
Status: "partial_unattributed",
Requested: []string{secret},
Confirmed: []MessageMentionConfirmation{},
Missing: []string{},
UnattributedRequested: []string{secret},
All: "not_requested",
RetryScope: "none",
},
}},
wantStatus: "partial_unattributed",
wantScope: "none",
},
{
name: "unknown recovery values are not trusted",
result: Result{OK: true, Data: map[string]any{
"completion": map[string]any{
"status": secret,
"retry_scope": secret,
},
}},
wantStatus: "complete",
wantScope: "none",
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
env, signal := BuildJQOutputFallback(tc.result)
if output.ExitCodeOf(signal) != output.ExitAPI {
t.Fatalf("exit = %d", output.ExitCodeOf(signal))
}
raw, err := json.Marshal(env)
if err != nil {
t.Fatal(err)
}
if strings.Contains(string(raw), secret) {
t.Fatalf("fallback leaked payload: %s", raw)
}
data := env.Data.(map[string]any)
if len(data) != 1 {
t.Fatalf("data = %#v", data)
}
completion := data["completion"].(map[string]any)
if completion["status"] != tc.wantStatus || completion["retry_scope"] != tc.wantScope {
t.Fatalf("completion = %#v", completion)
}
_, hasCounts := completion["requested_count"]
if hasCounts != tc.wantCounts {
t.Fatalf("completion counts presence = %v, want %v: %#v", hasCounts, tc.wantCounts, completion)
}
_, hasFinal := completion["final_state_verified"]
if hasFinal != tc.wantFinal {
t.Fatalf("final state presence = %v, want %v: %#v", hasFinal, tc.wantFinal, completion)
}
for _, forbidden := range []string{"succeeded_items", "failed_items", "pending_items", "message"} {
if _, exists := completion[forbidden]; exists {
t.Fatalf("completion copied %s: %#v", forbidden, completion)
}
}
})
}
}
func TestContentSafetyOutputFallbackUsesFixedPublicProblem(t *testing.T) {
env, signal := BuildContentSafetyOutputFallback(Result{Data: map[string]any{}})
if output.ExitCodeOf(signal) != output.ExitContentSafety {
t.Fatalf("exit = %d", output.ExitCodeOf(signal))
}
problem := env.Error.(*errs.Problem)
if problem.Category != errs.CategoryPolicy || problem.Subtype != errs.SubtypeContentSafety ||
problem.Message != "Output blocked after the IM write completed" {
t.Fatalf("problem = %#v", problem)
}
}

View File

@@ -1,286 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/output"
)
const (
hintSinglePage = "Result is incomplete. Re-run with --page-all --page-limit 0 when exhaustive output is required."
hintPageLimit = "Result is incomplete because --page-limit was reached. Use --page-limit 0 only when exhaustive output is required."
hintReadFailed = "The read is incomplete. Retry the read; do not infer that missing items do not exist."
hintTokenUnusable = "The server did not provide a usable next page token. Report the result as incomplete."
hintStartPage = "This read started from a supplied page token and does not prove the collection was exhausted from the beginning."
hintServerTruncate = "The server truncated the result. Narrow the query range before retrying."
hintSearchEmpty = "The search was exhausted, but an empty search result does not prove that the resource does not exist."
)
type ReadOptions struct {
FullRead bool
}
// ReadResult is the IM-only interpretation of neutral pagination facts.
// Error is deliberately a copied Problem rather than the original error so
// causes and typed-error extension fields cannot leak into stdout.
type ReadResult struct {
OK bool
Data any
Meta *output.Meta
Error *errs.Problem
Hint string
ExitCode int
Cause error `json:"-"`
}
// ReadSession is independent from the write Session. It records typed
// pagination and, for explicitly opted-in searches, materialization evidence;
// it never observes raw request or response bodies.
type ReadSession struct {
contract Contract
options ReadOptions
status client.PaginationStatus
observed bool
materialization MaterializationStatus
materializationObserved bool
}
func NewReadSession(contract Contract, options ReadOptions) (*ReadSession, error) {
if !contract.Strategy.Kind.IsRead() {
return nil, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported IM read contract strategy %q",
contract.Strategy.Kind,
)
}
return &ReadSession{contract: contract, options: options}, nil
}
func (s *ReadSession) ObservePagination(status client.PaginationStatus) {
s.status = status
s.observed = true
}
func (s *ReadSession) ObserveMaterialization(status MaterializationStatus) {
s.materialization = status
s.materializationObserved = true
}
func (s *ReadSession) RequiresPagination() bool {
return s.contract.Strategy.Kind == CollectionReadKind || s.contract.Strategy.Kind == SearchReadKind
}
// FinalizeError applies the IM read retry contract to a typed error. Reads may
// be retried after transport failures and server errors. Rate limits and all
// other API or validation failures do not authorize an Agent retry.
func (s *ReadSession) FinalizeError(err error) error {
problem, ok := errs.ProblemOf(err)
if !ok {
return err
}
normalizeReadProblem(problem)
return err
}
func (s *ReadSession) Finalize(data any) (ReadResult, error) {
switch s.contract.Strategy.Kind {
case EntityReadKind, MaterializeReadKind:
return ReadResult{
OK: true,
Data: data,
Hint: s.contract.Strategy.ReadHint,
}, nil
case CollectionReadKind, SearchReadKind:
if !s.observed {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"IM collection read completed without pagination status",
)
}
default:
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported IM read contract strategy %q",
s.contract.Strategy.Kind,
)
}
result, err := finalizePagedRead(data, s.status, s.options.FullRead)
if err != nil {
return ReadResult{}, err
}
if s.contract.Strategy.RequiresMaterialization {
result, err = s.finalizeMaterialization(result)
if err != nil {
return ReadResult{}, err
}
}
if s.contract.Strategy.Kind == SearchReadKind &&
s.status.StopReason == client.StopReasonExhausted &&
searchCollectionEmpty(data, s.contract.Strategy.CollectionField) {
result.Hint = joinHints(result.Hint, hintSearchEmpty)
}
return result, nil
}
func (s *ReadSession) finalizeMaterialization(result ReadResult) (ReadResult, error) {
if !s.materializationObserved {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"IM search completed without materialization status",
)
}
data, ok := result.Data.(map[string]any)
if !ok {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"IM search materialization requires an object result",
)
}
data["materialization"] = s.materialization.ledger()
result.Data = data
materializationComplete := s.materialization.complete()
if result.Meta == nil || result.Meta.Complete == nil {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"IM search materialization requires pagination completeness",
)
}
*result.Meta.Complete = *result.Meta.Complete && materializationComplete
if materializationComplete {
if *result.Meta.Complete {
result.Hint = "Results are ready to use. Use message_id/file_key directly; do not call messages-mget."
}
return result, nil
}
result.OK = false
if result.ExitCode == 0 {
result.ExitCode = output.ExitAPI
}
materializationHint := ""
if len(s.materialization.MissingMessageIDs) > 0 {
materializationHint = "The search is incomplete. Query only materialization.missing_message_ids with im +messages-mget."
} else {
materializationHint = "The search is incomplete and cannot be safely recovered by message ID. Narrow the query before retrying."
}
result.Hint = joinHints(result.Hint, materializationHint)
if result.Error == nil && s.materialization.Cause != nil {
if problem, ok := errs.ProblemOf(s.materialization.Cause); ok {
copied := *problem
normalizeReadProblem(&copied)
result.Error = &copied
result.Cause = s.materialization.Cause
result.ExitCode = output.ExitCodeOf(s.materialization.Cause)
}
}
return result, nil
}
func finalizePagedRead(data any, status client.PaginationStatus, fullRead bool) (ReadResult, error) {
complete := false
result := ReadResult{
OK: true,
Data: data,
Meta: &output.Meta{
Complete: &complete,
PagesFetched: status.PagesFetched,
StopReason: string(status.StopReason),
NextPageToken: status.NextPageToken,
},
}
switch status.StopReason {
case client.StopReasonExhausted:
complete = true
case client.StopReasonSinglePage:
result.Hint = hintSinglePage
case client.StopReasonPageLimit:
result.Hint = hintPageLimit
case client.StopReasonStartPageToken:
result.Hint = hintStartPage
case client.StopReasonServerTruncation:
result.Hint = hintServerTruncate
if fullRead {
result.OK = false
result.ExitCode = output.ExitAPI
}
case client.StopReasonTransportError, client.StopReasonAPIError,
client.StopReasonMissingToken, client.StopReasonRepeatedToken:
if status.Cause == nil {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"pagination stopped with %q but no typed cause was recorded",
status.StopReason,
)
}
problem, ok := errs.ProblemOf(status.Cause)
if !ok {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"pagination stopped with an untyped cause",
)
}
copied := *problem
normalizeReadProblem(&copied)
result.OK = false
result.Error = &copied
result.ExitCode = output.ExitCodeOf(status.Cause)
result.Cause = status.Cause
switch status.StopReason {
case client.StopReasonMissingToken, client.StopReasonRepeatedToken:
result.Hint = hintTokenUnusable
default:
result.Hint = hintReadFailed
}
default:
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported pagination stop reason %q",
status.StopReason,
)
}
*result.Meta.Complete = complete
return result, nil
}
func normalizeReadProblem(problem *errs.Problem) {
if problem == nil {
return
}
problem.Retryable = problem.Category == errs.CategoryNetwork ||
(problem.Category == errs.CategoryAPI && problem.Subtype == errs.SubtypeServerError)
}
func searchCollectionEmpty(data any, field string) bool {
m, ok := data.(map[string]any)
if !ok {
return false
}
value, exists := m[field]
if !exists {
return false
}
switch items := value.(type) {
case []any:
return len(items) == 0
case []map[string]any:
return len(items) == 0
default:
return false
}
}
func joinHints(first, second string) string {
if first == "" {
return second
}
if second == "" {
return first
}
return first + " " + second
}

View File

@@ -1,401 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"encoding/json"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/output"
)
func TestReadCompletenessMatrix(t *testing.T) {
apiErr := errs.NewAPIError(errs.SubtypeServerError, "later page failed")
networkErr := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithRetryable()
invalidErr := errs.NewInternalError(errs.SubtypeInvalidResponse, "bad pagination")
tests := []struct {
name string
fullRead bool
status client.PaginationStatus
wantOK bool
wantDone bool
wantExit int
wantReason client.StopReason
wantError bool
wantHint string
}{
{"single exhausted", false, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonExhausted}, true, true, 0, client.StopReasonExhausted, false, ""},
{"single has more", false, client.PaginationStatus{PagesFetched: 1, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonSinglePage}, true, false, 0, client.StopReasonSinglePage, false, "Result is incomplete. Re-run with --page-all --page-limit 0 when exhaustive output is required."},
{"all exhausted", true, client.PaginationStatus{PagesFetched: 2, StopReason: client.StopReasonExhausted}, true, true, 0, client.StopReasonExhausted, false, ""},
{"page limit", true, client.PaginationStatus{PagesFetched: 2, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonPageLimit}, true, false, 0, client.StopReasonPageLimit, false, "Result is incomplete because --page-limit was reached. Use --page-limit 0 only when exhaustive output is required."},
{"start token", false, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonStartPageToken}, true, false, 0, client.StopReasonStartPageToken, false, hintStartPage},
{"api error", true, client.PaginationStatus{PagesFetched: 1, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonAPIError, Cause: apiErr}, false, false, output.ExitAPI, client.StopReasonAPIError, true, "The read is incomplete. Retry the read; do not infer that missing items do not exist."},
{"transport error", true, client.PaginationStatus{PagesFetched: 1, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonTransportError, Cause: networkErr}, false, false, output.ExitNetwork, client.StopReasonTransportError, true, "The read is incomplete. Retry the read; do not infer that missing items do not exist."},
{"missing token", true, client.PaginationStatus{PagesFetched: 1, HasMore: true, StopReason: client.StopReasonMissingToken, Cause: invalidErr}, false, false, output.ExitInternal, client.StopReasonMissingToken, true, "The server did not provide a usable next page token. Report the result as incomplete."},
{"repeated token", true, client.PaginationStatus{PagesFetched: 2, HasMore: true, StopReason: client.StopReasonRepeatedToken, Cause: invalidErr}, false, false, output.ExitInternal, client.StopReasonRepeatedToken, true, "The server did not provide a usable next page token. Report the result as incomplete."},
{"single truncation", false, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonServerTruncation}, true, false, 0, client.StopReasonServerTruncation, false, "The server truncated the result. Narrow the query range before retrying."},
{"full truncation", true, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonServerTruncation}, false, false, output.ExitAPI, client.StopReasonServerTruncation, false, "The server truncated the result. Narrow the query range before retrying."},
}
contract := mustReadContract(t, "im +chat-list")
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
session, err := NewReadSession(contract, ReadOptions{FullRead: tt.fullRead})
if err != nil {
t.Fatal(err)
}
session.ObservePagination(tt.status)
got, err := session.Finalize(map[string]any{"items": []any{"a"}})
if err != nil {
t.Fatal(err)
}
if got.OK != tt.wantOK || got.ExitCode != tt.wantExit {
t.Fatalf("result OK/exit = %v/%d, want %v/%d", got.OK, got.ExitCode, tt.wantOK, tt.wantExit)
}
if got.Meta == nil || got.Meta.Complete == nil || *got.Meta.Complete != tt.wantDone {
t.Fatalf("complete = %#v, want %v", got.Meta, tt.wantDone)
}
if got.Meta.StopReason != string(tt.wantReason) {
t.Fatalf("stop reason = %q, want %q", got.Meta.StopReason, tt.wantReason)
}
if (got.Error != nil) != tt.wantError {
t.Fatalf("error present = %v, want %v", got.Error != nil, tt.wantError)
}
if got.Hint != tt.wantHint {
t.Fatalf("hint = %q, want %q", got.Hint, tt.wantHint)
}
})
}
}
func TestReadFailureErrorWireShapeDoesNotSerializeCause(t *testing.T) {
contract := mustReadContract(t, "im +chat-list")
session, err := NewReadSession(contract, ReadOptions{FullRead: true})
if err != nil {
t.Fatal(err)
}
secret := "raw-server-cause-must-not-leak"
cause := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").
WithRetryable().
WithCause(assertionError(secret))
session.ObservePagination(client.PaginationStatus{
PagesFetched: 1,
HasMore: true,
NextPageToken: "opaque-token",
StopReason: client.StopReasonTransportError,
Cause: cause,
})
result, err := session.Finalize(map[string]any{"items": []any{"kept"}})
if err != nil {
t.Fatal(err)
}
wire, err := json.Marshal(result.Error)
if err != nil {
t.Fatal(err)
}
if string(wire) == "" || containsAny(string(wire), secret, "opaque-token") {
t.Fatalf("unsafe error wire: %s", wire)
}
}
func TestReadFinalizeErrorRetryMatrix(t *testing.T) {
contract := mustReadContract(t, "im +messages-mget")
tests := []struct {
name string
err error
wantRetryable bool
}{
{
name: "transport",
err: errs.NewNetworkError(errs.SubtypeNetworkTransport, "connection reset"),
wantRetryable: true,
},
{
name: "server error",
err: errs.NewAPIError(errs.SubtypeServerError, "upstream failed"),
wantRetryable: true,
},
{
name: "rate limit is not authorized",
err: errs.NewAPIError(errs.SubtypeRateLimit, "too many requests").WithRetryable(),
wantRetryable: false,
},
{
name: "permission",
err: errs.NewPermissionError(errs.SubtypeMissingScope, "missing scope"),
wantRetryable: false,
},
{
name: "not found",
err: errs.NewAPIError(errs.SubtypeNotFound, "missing"),
wantRetryable: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
session, err := NewReadSession(contract, ReadOptions{})
if err != nil {
t.Fatal(err)
}
got := session.FinalizeError(tt.err)
problem, ok := errs.ProblemOf(got)
if !ok {
t.Fatalf("FinalizeError returned untyped error %T: %v", got, got)
}
if problem.Retryable != tt.wantRetryable {
t.Fatalf("Retryable = %v, want %v: %#v", problem.Retryable, tt.wantRetryable, problem)
}
})
}
}
func TestPagedReadNormalizesRateLimitToNonRetryable(t *testing.T) {
contract := mustReadContract(t, "im +chat-list")
session, err := NewReadSession(contract, ReadOptions{FullRead: true})
if err != nil {
t.Fatal(err)
}
rateLimit := errs.NewAPIError(errs.SubtypeRateLimit, "too many requests").WithRetryable()
session.ObservePagination(client.PaginationStatus{
PagesFetched: 1,
HasMore: true,
StopReason: client.StopReasonAPIError,
Cause: rateLimit,
})
result, err := session.Finalize(map[string]any{"items": []any{"kept"}})
if err != nil {
t.Fatal(err)
}
if result.Error == nil {
t.Fatal("expected typed partial read error")
}
if result.Error.Retryable {
t.Fatalf("429/rate_limit must not authorize retry: %#v", result.Error)
}
}
func TestSearchMaterializationControlsFinalCompleteness(t *testing.T) {
contract := mustReadContract(t, "im +messages-search")
tests := []struct {
name string
status MaterializationStatus
wantOK bool
wantComplete bool
wantHint string
}{
{
name: "complete",
status: MaterializationStatus{
RequestedIDs: []string{"om_a", "om_b"},
ResolvedIDs: []string{"om_a", "om_b"},
},
wantOK: true,
wantComplete: true,
wantHint: "Results are ready to use. Use message_id/file_key directly; do not call messages-mget.",
},
{
name: "missing details",
status: MaterializationStatus{
RequestedIDs: []string{"om_a", "om_b"},
ResolvedIDs: []string{"om_a"},
MissingMessageIDs: []string{"om_b"},
},
wantOK: false,
wantComplete: false,
wantHint: "The search is incomplete. Query only materialization.missing_message_ids with im +messages-mget.",
},
{
name: "unresolved hit",
status: MaterializationStatus{
RequestedIDs: []string{"om_a"},
ResolvedIDs: []string{"om_a"},
UnresolvedHitCount: 1,
},
wantOK: false,
wantComplete: false,
wantHint: "The search is incomplete and cannot be safely recovered by message ID. Narrow the query before retrying.",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
session, err := NewReadSession(contract, ReadOptions{FullRead: true})
if err != nil {
t.Fatal(err)
}
session.ObservePagination(client.PaginationStatus{PagesFetched: 2, StopReason: client.StopReasonExhausted})
session.ObserveMaterialization(tt.status)
result, err := session.Finalize(map[string]any{"messages": []any{map[string]any{"message_id": "om_a"}}})
if err != nil {
t.Fatal(err)
}
if result.OK != tt.wantOK || result.Meta == nil || result.Meta.Complete == nil ||
*result.Meta.Complete != tt.wantComplete {
t.Fatalf("result = %#v, want OK/complete %v/%v", result, tt.wantOK, tt.wantComplete)
}
if result.Hint != tt.wantHint {
t.Fatalf("hint = %q, want %q", result.Hint, tt.wantHint)
}
data := result.Data.(map[string]any)
ledger, ok := data["materialization"].(map[string]any)
if !ok {
t.Fatalf("materialization ledger missing: %#v", data)
}
wantStatus := "partial"
if tt.wantComplete {
wantStatus = "complete"
}
if ledger["status"] != wantStatus {
t.Fatalf("materialization status = %q, want %q", ledger["status"], wantStatus)
}
})
}
}
func TestSearchMaterializationRequiredButUnobservedFailsClosed(t *testing.T) {
contract := mustReadContract(t, "im +messages-search")
session, err := NewReadSession(contract, ReadOptions{FullRead: true})
if err != nil {
t.Fatal(err)
}
session.ObservePagination(client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonExhausted})
_, err = session.Finalize(map[string]any{"messages": []any{}})
problem, ok := errs.ProblemOf(err)
if !ok || problem.Subtype != errs.SubtypeInvalidResponse {
t.Fatalf("error = %T %v, want invalid_response", err, err)
}
}
func TestSearchMaterializationDoesNotOverwritePaginationFailure(t *testing.T) {
contract := mustReadContract(t, "im +messages-search")
session, err := NewReadSession(contract, ReadOptions{FullRead: true})
if err != nil {
t.Fatal(err)
}
pageErr := errs.NewNetworkError(errs.SubtypeNetworkTransport, "later page failed")
session.ObservePagination(client.PaginationStatus{
PagesFetched: 1,
HasMore: true,
NextPageToken: "next",
StopReason: client.StopReasonTransportError,
Cause: pageErr,
})
session.ObserveMaterialization(MaterializationStatus{
RequestedIDs: []string{"om_a", "om_b"},
ResolvedIDs: []string{"om_a"},
MissingMessageIDs: []string{"om_b"},
})
result, err := session.Finalize(map[string]any{"messages": []any{map[string]any{"message_id": "om_a"}}})
if err != nil {
t.Fatal(err)
}
if result.OK || result.ExitCode != output.ExitNetwork || result.Cause != pageErr {
t.Fatalf("pagination failure was overwritten: %#v", result)
}
if result.Error == nil || !result.Error.Retryable {
t.Fatalf("pagination problem was not preserved: %#v", result.Error)
}
for _, want := range []string{hintReadFailed, "materialization.missing_message_ids"} {
if !strings.Contains(result.Hint, want) {
t.Fatalf("combined hint = %q, want %q", result.Hint, want)
}
}
}
func TestSearchMaterializationDoesNotExposeUnexpectedIDs(t *testing.T) {
status := MaterializationStatus{
RequestedIDs: []string{"om_requested"},
ResolvedIDs: []string{"om_requested"},
UnexpectedMessageCount: 1,
}
wire, err := json.Marshal(status.ledger())
if err != nil {
t.Fatal(err)
}
if containsAny(string(wire), "om_requested", "om_unknown_secret") {
t.Fatalf("ledger leaked internal IDs: %s", wire)
}
}
func TestSearchEmptyResultAddsNonExistenceHint(t *testing.T) {
contract := mustReadContract(t, "im +chat-search")
session, err := NewReadSession(contract, ReadOptions{})
if err != nil {
t.Fatal(err)
}
session.ObservePagination(client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonExhausted})
result, err := session.Finalize(map[string]any{"chats": []any{}})
if err != nil {
t.Fatal(err)
}
if result.Meta == nil || result.Meta.Complete == nil || !*result.Meta.Complete {
t.Fatalf("expected exhausted result to be complete: %#v", result.Meta)
}
const wantHint = "The search was exhausted, but an empty search result does not prove that the resource does not exist."
if result.Hint != wantHint {
t.Fatalf("hint = %q, want %q", result.Hint, wantHint)
}
}
func TestEntityAndMaterializeDoNotInventPagination(t *testing.T) {
for _, key := range []ContractKey{"im chat.nickname get", "im +messages-resources-download"} {
t.Run(string(key), func(t *testing.T) {
contract := mustReadContract(t, key)
session, err := NewReadSession(contract, ReadOptions{})
if err != nil {
t.Fatal(err)
}
result, err := session.Finalize(map[string]any{"nickname": ""})
if err != nil {
t.Fatal(err)
}
if !result.OK || result.Meta != nil || result.ExitCode != 0 {
t.Fatalf("unexpected finite result: %#v", result)
}
})
}
}
func TestUnknownReadStrategyFailsClosed(t *testing.T) {
_, err := NewReadSession(Contract{
Key: "im future read",
Strategy: Strategy{Kind: StrategyKind("future_read")},
}, ReadOptions{})
if err == nil || !errs.IsInternal(err) {
t.Fatalf("expected typed internal error, got %v", err)
}
}
func mustReadContract(t *testing.T, key ContractKey) Contract {
t.Helper()
contract, ok := Lookup(key)
if !ok {
t.Fatalf("missing contract %q", key)
}
return contract
}
type assertionError string
func (e assertionError) Error() string { return string(e) }
func containsAny(s string, values ...string) bool {
for _, value := range values {
if value != "" && stringContains(s, value) {
return true
}
}
return false
}
func stringContains(s, substr string) bool {
for i := 0; i+len(substr) <= len(s); i++ {
if s[i:i+len(substr)] == substr {
return true
}
}
return false
}

View File

@@ -1,22 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import "github.com/larksuite/cli/internal/imcontract/catalog"
func Lookup(key ContractKey) (Contract, bool) {
return catalog.Lookup(key)
}
func All() []Contract {
return catalog.All()
}
func ValidateRegistry() error {
return catalog.ValidateRegistry()
}
func stringsFrom(field string) evidenceSpec {
return evidenceSpec{Shape: evidenceStrings, Field: field}
}

View File

@@ -1,141 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"slices"
"testing"
)
func TestWriteRegistryCoverage(t *testing.T) {
counts := map[StrategyKind]int{}
total := 0
for _, contract := range All() {
if contract.Strategy.Kind.IsWrite() {
counts[contract.Strategy.Kind]++
total++
}
}
if total != 36 {
t.Fatalf("write contracts = %d, want 36", total)
}
want := map[StrategyKind]int{
AuthoritativeAckKind: 9,
RequiredResultKind: 12,
BatchPartialKind: 11,
RequiredResultBatchPartialKind: 1,
ResponseSetAssertionKind: 2,
AcceptanceOnlyKind: 1,
}
for kind, n := range want {
if counts[kind] != n {
t.Errorf("%s = %d, want %d", kind, counts[kind], n)
}
}
if err := ValidateRegistry(); err != nil {
t.Fatal(err)
}
wantKeys := []ContractKey{
"im +chat-create", "im +chat-update", "im +feed-shortcut-create",
"im +feed-shortcut-remove", "im +flag-cancel", "im +flag-create",
"im +messages-reply", "im +messages-send",
"im chat.managers add_managers", "im chat.managers delete_managers",
"im chat.members create", "im chat.members delete",
"im chat.moderation update", "im chat.nickname delete",
"im chat.nickname update", "im chat.user_setting batch_update",
"im chats create", "im chats link", "im chats update",
"im feed.groups batch_add_item", "im feed.groups batch_remove_item",
"im feed.groups create", "im feed.groups delete", "im feed.groups update",
"im images create", "im messages delete", "im messages forward",
"im messages merge_forward", "im messages urgent_app",
"im messages urgent_phone", "im messages urgent_sms", "im pins create",
"im pins delete", "im reactions create", "im reactions delete",
"im threads forward",
}
gotKeys := make([]ContractKey, 0, len(All()))
for _, c := range All() {
if c.Strategy.Kind.IsWrite() {
gotKeys = append(gotKeys, c.Key)
}
}
if !slices.Equal(gotKeys, wantKeys) {
t.Fatalf("write registry keys differ:\ngot %v\nwant %v", gotKeys, wantKeys)
}
}
func TestModerationAcceptanceOnlyContract(t *testing.T) {
c, ok := Lookup("im chat.moderation update")
if !ok {
t.Fatal("moderation contract missing")
}
if c.Strategy.Kind != AcceptanceOnlyKind || c.ReplayMode != ReplayForbidden ||
c.HelpPolicy != HelpAcceptanceOnly {
t.Fatalf("unexpected moderation contract: %#v", c)
}
}
func TestReadRegistryCoverage(t *testing.T) {
counts := map[StrategyKind]int{}
var gotKeys []ContractKey
for _, contract := range All() {
if !contract.Strategy.Kind.IsRead() {
continue
}
counts[contract.Strategy.Kind]++
gotKeys = append(gotKeys, contract.Key)
}
if len(gotKeys) != 24 {
t.Fatalf("read contracts = %d, want 24", len(gotKeys))
}
wantCounts := map[StrategyKind]int{
EntityReadKind: 8,
CollectionReadKind: 13,
SearchReadKind: 2,
MaterializeReadKind: 1,
}
for kind, want := range wantCounts {
if got := counts[kind]; got != want {
t.Errorf("%s = %d, want %d", kind, got, want)
}
}
wantKeys := []ContractKey{
"im +chat-list",
"im +chat-members-list",
"im +chat-messages-list",
"im +chat-search",
"im +feed-group-list",
"im +feed-group-list-item",
"im +feed-group-query-item",
"im +feed-shortcut-list",
"im +flag-list",
"im +messages-mget",
"im +messages-resources-download",
"im +messages-search",
"im +threads-messages-list",
"im chat.members bots",
"im chat.members get",
"im chat.moderation get",
"im chat.nickname get",
"im chat.user_setting batch_query",
"im chats get",
"im feed.groups batch_query",
"im messages read_users",
"im pins list",
"im reactions batch_query",
"im reactions list",
}
if !slices.Equal(gotKeys, wantKeys) {
t.Fatalf("read registry keys differ:\ngot %v\nwant %v", gotKeys, wantKeys)
}
}
func TestModerationGetUsesCollectionCompletenessContract(t *testing.T) {
c, ok := Lookup("im chat.moderation get")
if !ok {
t.Fatal("moderation get contract missing")
}
if c.Strategy.Kind != CollectionReadKind || c.HelpPolicy != HelpCompleteness {
t.Fatalf("unexpected moderation get contract: %#v", c)
}
}

View File

@@ -1,179 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"errors"
"strings"
"github.com/larksuite/cli/errs"
)
type Session struct {
contract Contract
requested []ledgerItem
hasIdempotencyKey bool
facts []Fact
}
func NewSession(contract Contract) *Session {
return &Session{contract: contract}
}
func (s *Session) Contract() Contract {
return s.contract
}
func (s *Session) ObserveRequest(body map[string]any) error {
if spec := s.contract.Strategy.Request; spec.Field != "" {
evidence := extract(body, spec)
if !evidence.present || evidence.selectedCount == 0 ||
evidence.rejectedCount != 0 ||
evidence.rawCount != evidence.selectedCount+evidence.rejectedCount {
return errs.NewValidationError(
errs.SubtypeInvalidArgument,
"IM write request field %q has an unsupported shape",
spec.Field,
)
}
s.requested = uniqueItems(append(s.requested, evidence.items...))
}
if strings.TrimSpace(stableID(body["uuid"])) != "" {
s.hasIdempotencyKey = true
}
return nil
}
func (s *Session) ObserveResponse(_ map[string]any) {}
func (s *Session) RecordFact(f Fact) {
switch f.Kind {
case FactMediaPreuploadPerformed, FactWriteAttempted:
if s.hasFact(f.Kind) {
return
}
s.facts = append(s.facts, Fact{Kind: f.Kind})
case FactFlagFeedLayerPending:
s.facts = append(s.facts, Fact{Kind: f.Kind, Item: "feed"})
}
}
func (s *Session) hasFact(kind FactKind) bool {
for _, fact := range s.facts {
if fact.Kind == kind {
return true
}
}
return false
}
func (s *Session) FinalizeSuccess(data any) (Result, error) {
s.RecordFact(Fact{Kind: FactWriteAttempted})
switch s.contract.Strategy.Kind {
case AuthoritativeAckKind:
return Result{OK: true, Data: data}, nil
case RequiredResultKind:
if !requiredResultPresent(data, s.contract.Strategy.Required) {
return Result{}, s.FinalizeError(invalidRequiredResult(requiredLabel(s.contract.Strategy.Required)))
}
if supportsMessageMentionResult(s.contract.Key) {
result, err := finalizeMessageMentions(data)
if err != nil {
return Result{}, s.FinalizeError(err)
}
return result, nil
}
return Result{OK: true, Data: data}, nil
case BatchPartialKind:
return finalizeBatch(s, data)
case RequiredResultBatchPartialKind:
result, err := finalizeBatch(s, data)
if err != nil {
return Result{}, err
}
if !result.OK {
return result, nil
}
if !requiredResultPresent(data, s.contract.Strategy.Required) {
return Result{}, s.FinalizeError(invalidRequiredResult(requiredLabel(s.contract.Strategy.Required)))
}
return result, nil
case ResponseSetAssertionKind:
return finalizeAssertion(s, data)
case AcceptanceOnlyKind:
m, err := checkedResponse(data)
if err != nil {
return Result{}, err
}
m["completion"] = map[string]any{
"status": "accepted_unverified",
"final_state_verified": false,
"retry_scope": "none",
}
return Result{OK: true, Data: m, Hint: s.contract.HelpPolicy.Text()}, nil
default:
return Result{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported IM write contract strategy %q",
s.contract.Strategy.Kind,
)
}
}
func supportsMessageMentionResult(key ContractKey) bool {
return key == "im +messages-send" || key == "im +messages-reply"
}
func requiredLabel(spec requiredSpec) string {
if spec.Child == "" {
return spec.Field
}
return spec.Field + "/" + spec.Child
}
func (s *Session) FinalizeError(err error) error {
problem, ok := errs.ProblemOf(err)
if !ok {
return err
}
if problem.Subtype == errs.SubtypeRateLimit {
problem.Retryable = false
problem.Hint = ""
return err
}
transient := problem.Category == errs.CategoryNetwork ||
(problem.Category == errs.CategoryAPI && problem.Retryable)
if !transient && problem.Subtype != errs.SubtypeInvalidResponse {
return err
}
if !s.hasFact(FactWriteAttempted) {
return err
}
var evidenceErr *invalidEvidenceError
if errors.As(err, &evidenceErr) {
problem.Retryable = false
problem.Hint = hintUnsafeEvidence
return err
}
mode := s.contract.ReplayMode
if s.hasFact(FactMediaPreuploadPerformed) {
mode = ReplayForbidden
}
switch mode {
case ReplaySafe:
problem.Retryable = true
problem.Hint = hintReplaySafe
case ReplaySameIdempotencyKey:
if s.hasIdempotencyKey {
problem.Retryable = true
problem.Hint = hintSameKey
return err
}
fallthrough
default:
problem.Retryable = false
problem.Hint = hintReplayForbidden
}
return err
}

View File

@@ -1,76 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
// Package imcontract evaluates IM command completion evidence.
package imcontract
import "github.com/larksuite/cli/internal/imcontract/catalog"
type ContractKey = catalog.ContractKey
type StrategyKind = catalog.StrategyKind
type ReplayMode = catalog.ReplayMode
type PartialRecoveryMode = catalog.PartialRecoveryMode
type AssertionMode = catalog.AssertionMode
type Strategy = catalog.Strategy
type HelpPolicy = catalog.HelpPolicy
type Contract = catalog.Contract
type requiredSpec = catalog.RequiredSpec
type evidenceSpec = catalog.EvidenceSpec
const (
EntityReadKind = catalog.EntityReadKind
CollectionReadKind = catalog.CollectionReadKind
SearchReadKind = catalog.SearchReadKind
MaterializeReadKind = catalog.MaterializeReadKind
AuthoritativeAckKind = catalog.AuthoritativeAckKind
RequiredResultKind = catalog.RequiredResultKind
BatchPartialKind = catalog.BatchPartialKind
RequiredResultBatchPartialKind = catalog.RequiredResultBatchPartialKind
ResponseSetAssertionKind = catalog.ResponseSetAssertionKind
AcceptanceOnlyKind = catalog.AcceptanceOnlyKind
ReplayForbidden = catalog.ReplayForbidden
ReplaySafe = catalog.ReplaySafe
ReplaySameIdempotencyKey = catalog.ReplaySameIdempotencyKey
PartialRecoveryWholeRequest = catalog.PartialRecoveryWholeRequest
PartialRecoveryFailedItemsOnly = catalog.PartialRecoveryFailedItemsOnly
AssertRequestedPresent = catalog.AssertRequestedPresent
AssertRequestedAbsent = catalog.AssertRequestedAbsent
requiredTopString = catalog.RequiredTopString
requiredTopObject = catalog.RequiredTopObject
requiredNestedString = catalog.RequiredNestedString
evidenceStrings = catalog.EvidenceStrings
evidenceObjects = catalog.EvidenceObjects
evidenceNestedObjects = catalog.EvidenceNestedObjects
evidenceFeedObjects = catalog.EvidenceFeedObjects
evidenceNestedFeedObjects = catalog.EvidenceNestedFeedObjects
evidenceStatusObjects = catalog.EvidenceStatusObjects
HelpCompleteness = catalog.HelpCompleteness
HelpAcceptanceOnly = catalog.HelpAcceptanceOnly
)
type FactKind string
const (
FactMediaPreuploadPerformed FactKind = "media_preupload_performed"
FactFlagFeedLayerPending FactKind = "flag_feed_layer_pending"
FactWriteAttempted FactKind = "write_attempted"
)
type Fact struct {
Kind FactKind
Item string
}
type Result struct {
OK bool
Data any
Hint string
ExitCode int
}

View File

@@ -1,199 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"fmt"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
)
const (
hintReplayForbidden = "The write result is unknown. Do not replay the original request."
hintReplaySafe = "The write result is unknown. Retrying the original request is safe."
hintSameKey = "The write result is unknown. Retry only with the same idempotency key."
hintUnsafeEvidence = "The server response could not be safely mapped to the original request. Do not retry the write based on this response."
)
func invalidRequiredResult(field string) error {
return errs.NewInternalError(errs.SubtypeInvalidResponse,
"successful response is missing required field %q", field)
}
type invalidEvidenceError struct {
cause error
}
func (e *invalidEvidenceError) Error() string {
return e.cause.Error()
}
func (e *invalidEvidenceError) Unwrap() error {
return e.cause
}
func invalidEvidence(field string) error {
return &invalidEvidenceError{
cause: errs.NewInternalError(
errs.SubtypeInvalidResponse,
"response evidence in %q cannot be mapped to the original request",
field,
).WithHint(hintUnsafeEvidence),
}
}
func requiredResultPresent(data any, spec requiredSpec) bool {
root, ok := data.(map[string]any)
if !ok {
return false
}
switch spec.Shape {
case requiredTopString:
return nonEmptyString(root[spec.Field]) != ""
case requiredTopObject:
object, ok := root[spec.Field].(map[string]any)
return ok && len(object) > 0
case requiredNestedString:
object, ok := root[spec.Field].(map[string]any)
return ok && nonEmptyString(object[spec.Child]) != ""
default:
return false
}
}
func checkedResponse(data any) (map[string]any, error) {
root, ok := data.(map[string]any)
if !ok {
return nil, invalidEvidence("response")
}
return root, nil
}
func validateEvidence(result extraction, requested []ledgerItem, field string, requireRequested bool) error {
if !result.present {
return nil
}
if result.rejectedCount != 0 ||
result.rawCount != result.selectedCount+result.rejectedCount {
return invalidEvidence(field)
}
if !requireRequested {
return nil
}
requestedSet := make(map[string]struct{}, len(requested))
for _, item := range requested {
requestedSet[item.key] = struct{}{}
}
for _, item := range result.items {
if _, ok := requestedSet[item.key]; !ok {
return invalidEvidence(field)
}
}
return nil
}
func finalizeBatch(s *Session, data any) (Result, error) {
root, err := checkedResponse(data)
if err != nil {
return Result{}, err
}
requested := append([]ledgerItem{}, s.requested...)
failed := make([]ledgerItem, 0)
for _, spec := range s.contract.Strategy.Failures {
evidence := extract(root, spec)
if err := validateEvidence(evidence, requested, spec.Field, true); err != nil {
return Result{}, err
}
failed = append(failed, evidence.items...)
}
responsePending := make([]ledgerItem, 0)
for _, spec := range s.contract.Strategy.Pending {
evidence := extract(root, spec)
if err := validateEvidence(evidence, requested, spec.Field, true); err != nil {
return Result{}, err
}
responsePending = append(responsePending, evidence.items...)
}
syntheticPending := make([]ledgerItem, 0)
if s.hasFact(FactFlagFeedLayerPending) {
syntheticPending = append(syntheticPending, ledgerItem{key: "feed", value: "feed"})
}
if spec := s.contract.Strategy.ResultLedger; spec != nil {
evidence := extract(root, *spec)
if err := validateEvidence(evidence, nil, spec.Field, false); err != nil {
return Result{}, err
}
requested = append(requested, evidence.items...)
failed = append(failed, statusFailures(root, *spec)...)
}
// Response pending can only classify an original request. Synthetic pending
// represents a logical sub-request performed by a shortcut.
requested = append(requested, syntheticPending...)
pending := append(responsePending, syntheticPending...)
ledger := completion(requested, failed, pending, s.contract.PartialRecovery)
root["completion"] = ledger
result := Result{OK: ledger.Status == "complete", Data: root}
if !result.OK {
result.ExitCode = output.ExitAPI
}
return result, nil
}
func statusFailures(root map[string]any, spec evidenceSpec) []ledgerItem {
values, _ := root[spec.Field].([]any)
failed := make([]ledgerItem, 0)
for _, value := range values {
object, _ := value.(map[string]any)
if fmt.Sprint(object["status"]) != "failed" {
continue
}
item, ok := stringItem(object[spec.IDField])
if ok {
failed = append(failed, item)
}
}
return failed
}
func finalizeAssertion(s *Session, data any) (Result, error) {
root, err := checkedResponse(data)
if err != nil {
return Result{}, err
}
actual := make(map[string]struct{})
responseSetPresent := false
for _, spec := range s.contract.Strategy.ResponseSets {
evidence := extract(root, spec)
if err := validateEvidence(evidence, nil, spec.Field, false); err != nil {
return Result{}, err
}
responseSetPresent = responseSetPresent || evidence.present
for _, item := range evidence.items {
actual[item.key] = struct{}{}
}
}
if !responseSetPresent {
return Result{}, invalidEvidence("response_sets")
}
failed := make([]ledgerItem, 0)
for _, item := range s.requested {
_, exists := actual[item.key]
if (s.contract.Strategy.Assertion == AssertRequestedPresent && !exists) ||
(s.contract.Strategy.Assertion == AssertRequestedAbsent && exists) {
failed = append(failed, item)
}
}
ledger := completion(s.requested, failed, nil, PartialRecoveryFailedItemsOnly)
root["completion"] = ledger
result := Result{OK: ledger.Status == "complete", Data: root}
if !result.OK {
result.ExitCode = output.ExitAPI
}
return result, nil
}

View File

@@ -1,573 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"encoding/json"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
)
func TestRequiredResult(t *testing.T) {
c, _ := Lookup("im +messages-send")
for _, data := range []map[string]any{{}, {"message_id": ""}} {
s := NewSession(c)
_, err := s.FinalizeSuccess(data)
if err == nil {
t.Fatalf("expected missing result error for %#v", data)
}
p, _ := errs.ProblemOf(err)
if p.Category != errs.CategoryInternal || p.Subtype != errs.SubtypeInvalidResponse {
t.Fatalf("problem = %#v", p)
}
if output.ExitCodeOf(err) != output.ExitInternal {
t.Fatalf("exit = %d", output.ExitCodeOf(err))
}
}
s := NewSession(c)
got, err := s.FinalizeSuccess(map[string]any{"message_id": "om_x"})
if err != nil || !got.OK {
t.Fatalf("valid result rejected: %#v %v", got, err)
}
}
func TestBatchPartialLedger(t *testing.T) {
c, _ := Lookup("im messages urgent_app")
s := NewSession(c)
s.ObserveRequest(map[string]any{"user_id_list": []any{"ou_a", "ou_b"}})
got, err := s.FinalizeSuccess(map[string]any{"invalid_user_id_list": []any{"ou_b"}})
if err != nil {
t.Fatal(err)
}
if got.OK || got.ExitCode != output.ExitAPI {
t.Fatalf("result = %#v", got)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if completion.Status != "partial" || completion.SucceededCount != 1 || completion.FailedCount != 1 {
t.Fatalf("completion = %#v", completion)
}
if len(completion.FailedItems) != 1 || completion.FailedItems[0] != "ou_b" {
t.Fatalf("failed items = %#v", completion.FailedItems)
}
}
func TestBatchPendingIsNotCountedAsSucceeded(t *testing.T) {
c, _ := Lookup("im chat.members create")
s := NewSession(c)
s.ObserveRequest(map[string]any{"id_list": []any{"ou_a", "ou_b"}})
got, err := s.FinalizeSuccess(map[string]any{"pending_approval_id_list": []any{"ou_b"}})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if completion.SucceededCount != 1 || completion.PendingCount != 1 || completion.RetryScope != "none" {
t.Fatalf("completion = %#v", completion)
}
}
func TestResponsePendingCannotExpandRequestedLedger(t *testing.T) {
c, _ := Lookup("im chat.members create")
s := NewSession(c)
s.ObserveRequest(map[string]any{
"id_list": []any{"ou_a", "ou_b"},
})
got, err := s.FinalizeSuccess(map[string]any{
"pending_approval_id_list": []any{"ou_unknown"},
})
if err == nil {
t.Fatalf("unknown response pending was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
}
func TestSyntheticFlagPendingExpandsLogicalRequest(t *testing.T) {
c, _ := Lookup("im +flag-cancel")
s := NewSession(c)
s.RecordFact(Fact{Kind: FactFlagFeedLayerPending})
got, err := s.FinalizeSuccess(map[string]any{"results": []any{
map[string]any{"flag_type": "message", "status": "ok"},
}})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if completion.RequestedCount != 2 || completion.SucceededCount != 1 ||
completion.FailedCount != 0 || completion.PendingCount != 1 ||
len(completion.PendingItems) != 1 || completion.PendingItems[0] != "feed" {
t.Fatalf("synthetic pending did not expand logical request: %#v", completion)
}
}
func TestRequiredResultBatchPartialPrioritizesLedger(t *testing.T) {
c, _ := Lookup("im messages merge_forward")
s := NewSession(c)
s.ObserveRequest(map[string]any{"message_id_list": []any{"om_a", "om_b"}})
got, err := s.FinalizeSuccess(map[string]any{"invalid_message_id_list": []any{"om_b"}})
if err != nil || got.OK || got.ExitCode != output.ExitAPI {
t.Fatalf("partial result = %#v, err=%v", got, err)
}
s = NewSession(c)
s.ObserveRequest(map[string]any{"message_id_list": []any{"om_a"}})
_, err = s.FinalizeSuccess(map[string]any{})
if err == nil {
t.Fatal("missing merged message_id must fail when no partial result exists")
}
}
func TestManagerResponseSetAssertions(t *testing.T) {
for _, tc := range []struct {
key ContractKey
response map[string]any
wantOK bool
}{
{"im chat.managers add_managers", map[string]any{"chat_managers": []any{"ou_a"}}, true},
{"im chat.managers add_managers", map[string]any{"chat_managers": []any{}}, false},
{"im chat.managers delete_managers", map[string]any{"chat_managers": []any{}}, true},
{"im chat.managers delete_managers", map[string]any{"chat_managers": []any{"ou_a"}}, false},
} {
c, _ := Lookup(tc.key)
s := NewSession(c)
s.ObserveRequest(map[string]any{"manager_ids": []any{"ou_a"}})
got, err := s.FinalizeSuccess(tc.response)
if err != nil || got.OK != tc.wantOK {
t.Errorf("%s response=%v: got %#v, err=%v", tc.key, tc.response, got, err)
}
}
}
func TestManagerResponseSetAssertionsRequirePresentEvidence(t *testing.T) {
for _, key := range []ContractKey{
"im chat.managers add_managers",
"im chat.managers delete_managers",
} {
t.Run(string(key), func(t *testing.T) {
c, _ := Lookup(key)
s := NewSession(c)
s.ObserveRequest(map[string]any{"manager_ids": []any{"ou_a"}})
got, err := s.FinalizeSuccess(map[string]any{})
if err == nil {
t.Fatalf("missing response sets were accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
})
}
}
func TestModerationAcceptedUnverified(t *testing.T) {
c, _ := Lookup("im chat.moderation update")
got, err := NewSession(c).FinalizeSuccess(map[string]any{})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(map[string]any)
if completion["status"] != "accepted_unverified" || completion["final_state_verified"] != false {
t.Fatalf("completion = %#v", completion)
}
if got.Hint != HelpAcceptanceOnly.Text() {
t.Fatalf("hint = %q", got.Hint)
}
}
func TestReplaySafety(t *testing.T) {
unknown := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithHint("untrusted upstream hint")
c, _ := Lookup("im +messages-send")
s := NewSession(c)
s.ObserveRequest(map[string]any{"uuid": "stable-key"})
s.RecordFact(Fact{Kind: FactWriteAttempted})
got := s.FinalizeError(unknown)
p, _ := errs.ProblemOf(got)
if !p.Retryable || p.Hint != hintSameKey {
t.Fatalf("same-key problem = %#v", p)
}
unknown = errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithHint("untrusted upstream hint")
s = NewSession(c)
s.ObserveRequest(map[string]any{"uuid": "stable-key"})
s.RecordFact(Fact{Kind: FactWriteAttempted})
s.RecordFact(Fact{Kind: FactMediaPreuploadPerformed})
got = s.FinalizeError(unknown)
p, _ = errs.ProblemOf(got)
if p.Retryable || p.Hint != hintReplayForbidden {
t.Fatalf("preupload problem = %#v", p)
}
validation := errs.NewValidationError(errs.SubtypeInvalidArgument, "bad flag")
got = NewSession(c).FinalizeError(validation)
p, _ = errs.ProblemOf(got)
if p.Retryable || p.Hint != "" {
t.Fatalf("validation problem was broadened: %#v", p)
}
unknown = errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithHint("untrusted upstream hint")
c, _ = Lookup("im +feed-shortcut-create")
s = NewSession(c)
s.RecordFact(Fact{Kind: FactWriteAttempted})
got = s.FinalizeError(unknown)
p, _ = errs.ProblemOf(got)
if !p.Retryable || p.Hint != hintReplaySafe {
t.Fatalf("safe replay problem = %#v", p)
}
preflight := errs.NewNetworkError(errs.SubtypeNetworkTransport, "lookup failed").
WithRetryable().
WithHint("specify --item-type explicitly")
c, _ = Lookup("im +flag-create")
got = NewSession(c).FinalizeError(preflight)
p, _ = errs.ProblemOf(got)
if !p.Retryable || p.Hint != "specify --item-type explicitly" {
t.Fatalf("preflight problem was rewritten: %#v", p)
}
}
func TestWriteRateLimitNeverAuthorizesReplay(t *testing.T) {
for _, key := range []ContractKey{
"im +feed-shortcut-create",
"im +messages-send",
} {
t.Run(string(key), func(t *testing.T) {
contract, _ := Lookup(key)
session := NewSession(contract)
session.ObserveRequest(map[string]any{"uuid": "stable-key"})
session.RecordFact(Fact{Kind: FactWriteAttempted})
rateLimit := errs.NewAPIError(errs.SubtypeRateLimit, "too many requests").
WithRetryable().
WithHint("retry later")
got := session.FinalizeError(rateLimit)
problem, ok := errs.ProblemOf(got)
if !ok {
t.Fatalf("FinalizeError returned untyped error %T: %v", got, got)
}
if problem.Retryable || problem.Hint != "" {
t.Fatalf("rate limit authorized replay for %s: %#v", key, problem)
}
})
}
}
func TestBatchPartialRecoveryMatrix(t *testing.T) {
tests := []struct {
name string
command ContractKey
request map[string]any
response map[string]any
fact *Fact
wantScope string
}{
{
name: "pending always forbids retry",
command: "im +flag-cancel",
response: map[string]any{"results": []any{
map[string]any{"flag_type": "message", "status": "ok"},
}},
fact: &Fact{Kind: FactFlagFeedLayerPending},
wantScope: "none",
},
{
name: "whole request recovery",
command: "im +feed-shortcut-create",
request: map[string]any{"shortcuts": []any{
map[string]any{"feed_card_id": "oc_a"},
}},
response: map[string]any{"failed_shortcuts": []any{
map[string]any{"shortcut": map[string]any{"feed_card_id": "oc_a"}},
}},
wantScope: "whole_request",
},
{
name: "failed items only recovery",
command: "im messages urgent_app",
request: map[string]any{"user_id_list": []any{"ou_a", "ou_b"}},
response: map[string]any{"invalid_user_id_list": []any{"ou_b"}},
wantScope: "failed_items_only",
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
contract, _ := Lookup(tc.command)
session := NewSession(contract)
if tc.request != nil {
if err := session.ObserveRequest(tc.request); err != nil {
t.Fatal(err)
}
}
if tc.fact != nil {
session.RecordFact(*tc.fact)
}
result, err := session.FinalizeSuccess(tc.response)
if err != nil {
t.Fatal(err)
}
completion := result.Data.(map[string]any)["completion"].(Completion)
if completion.RetryScope != tc.wantScope || result.Hint != "" {
t.Fatalf("completion=%#v hint=%q", completion, result.Hint)
}
})
}
}
func TestBatchRejectsUnmappableFailureEvidence(t *testing.T) {
for _, tc := range []struct {
name string
command ContractKey
request map[string]any
response map[string]any
}{
{
name: "all IDs missing",
command: "im chat.members create",
request: map[string]any{"id_list": []any{"ou_a"}},
response: map[string]any{"invalid_id_list": []any{map[string]any{"reason": "bad"}}},
},
{
name: "one ID missing",
command: "im chat.members create",
request: map[string]any{"id_list": []any{"ou_a", "ou_b"}},
response: map[string]any{"invalid_id_list": []any{
"ou_a", map[string]any{"reason": "bad"},
}},
},
{
name: "stable ID outside request",
command: "im chat.members create",
request: map[string]any{"id_list": []any{"ou_a"}},
response: map[string]any{"invalid_id_list": []any{"ou_unknown"}},
},
{
name: "compound feed ID missing",
command: "im feed.groups batch_add_item",
request: map[string]any{"items": []any{
map[string]any{"feed_id": "oc_a", "feed_type": "chat"},
}},
response: map[string]any{"failed_items": []any{
map[string]any{"item": map[string]any{"feed_type": "chat"}},
}},
},
{
name: "compound feed type missing",
command: "im feed.groups batch_add_item",
request: map[string]any{"items": []any{
map[string]any{"feed_id": "oc_a", "feed_type": "chat"},
}},
response: map[string]any{"failed_items": []any{
map[string]any{"item": map[string]any{"feed_id": "oc_a"}},
}},
},
} {
t.Run(tc.name, func(t *testing.T) {
c, _ := Lookup(tc.command)
s := NewSession(c)
s.ObserveRequest(tc.request)
got, err := s.FinalizeSuccess(tc.response)
if err == nil {
t.Fatalf("unmappable response was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
})
}
}
func TestAssertionRejectsUnmappableResponseEvidence(t *testing.T) {
c, _ := Lookup("im chat.managers add_managers")
s := NewSession(c)
s.ObserveRequest(map[string]any{"manager_ids": []any{"ou_a"}})
got, err := s.FinalizeSuccess(map[string]any{
"chat_managers": []any{map[string]any{"name": "missing ID"}},
})
if err == nil {
t.Fatalf("unmappable assertion response was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
}
func TestRequestEvidenceFailsClosedOnUnsupportedShapes(t *testing.T) {
c, _ := Lookup("im chat.members create")
for _, tc := range []struct {
name string
body map[string]any
}{
{name: "non-map body reaches contract as nil", body: nil},
{name: "missing collection", body: map[string]any{}},
{name: "wrong collection type", body: map[string]any{"id_list": []string{"ou_a"}}},
{name: "unmappable item", body: map[string]any{"id_list": []any{map[int]any{1: "ou_a"}}}},
} {
t.Run(tc.name, func(t *testing.T) {
err := NewSession(c).ObserveRequest(tc.body)
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryValidation ||
problem.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("request evidence error = %#v, ok=%v", problem, ok)
}
})
}
}
func TestExtractionAccounting(t *testing.T) {
got := extract(map[string]any{
"ids": []any{"ou_a", map[string]any{"missing": "id"}, "ou_a"},
}, stringsFrom("ids"))
if !got.present || got.rawCount != 3 || got.selectedCount != 2 ||
got.rejectedCount != 1 || len(got.items) != 1 {
t.Fatalf("extraction = %#v", got)
}
got = extract(map[string]any{"ids": []string{"ou_a"}}, stringsFrom("ids"))
if !got.present || got.rawCount != 0 || got.selectedCount != 0 ||
got.rejectedCount != 1 || len(got.items) != 0 {
t.Fatalf("wrong-shape extraction = %#v", got)
}
}
func TestStatusLedgerRejectsUnknownStatus(t *testing.T) {
c, _ := Lookup("im +flag-cancel")
got, err := NewSession(c).FinalizeSuccess(map[string]any{"results": []any{
map[string]any{"flag_type": "message", "status": "maybe"},
}})
if err == nil {
t.Fatalf("unknown result status was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
}
func TestUnsafeEvidenceRemainsForbiddenAcrossFinalizeError(t *testing.T) {
c, _ := Lookup("im +feed-shortcut-create")
s := NewSession(c)
if err := s.ObserveRequest(map[string]any{"shortcuts": []any{
map[string]any{"feed_card_id": "oc_a"},
}}); err != nil {
t.Fatal(err)
}
_, err := s.FinalizeSuccess(map[string]any{"failed_shortcuts": []any{
map[string]any{"shortcut": map[string]any{"missing": "feed_card_id"}},
}})
if err == nil {
t.Fatal("malformed evidence was accepted")
}
for i := 0; i < 2; i++ {
err = s.FinalizeError(err)
assertUnsafeEvidenceError(t, err)
}
}
func assertUnsafeEvidenceError(t *testing.T, err error) {
t.Helper()
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryInternal ||
problem.Subtype != errs.SubtypeInvalidResponse ||
problem.Retryable || problem.Hint != hintUnsafeEvidence {
t.Fatalf("unsafe evidence error = %#v, ok=%v", problem, ok)
}
if output.ExitCodeOf(err) != output.ExitInternal {
t.Fatalf("unsafe evidence exit = %d", output.ExitCodeOf(err))
}
}
func TestLedgerSelectorDoesNotCopySecrets(t *testing.T) {
c, _ := Lookup("im chat.members create")
s := NewSession(c)
s.ObserveRequest(map[string]any{
"id_list": []any{"ou_a"},
"content": "secret body",
"phone": "123",
"idempotency_key": "secret-key",
"access_token": "token",
"next_page_token": "page",
})
got, err := s.FinalizeSuccess(map[string]any{"invalid_id_list": []any{"ou_a"}})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if len(completion.FailedItems) != 1 || completion.FailedItems[0] != "ou_a" {
t.Fatalf("completion leaked or lost selector: %#v", completion)
}
}
func TestFeedLedgerKeepsOnlyRetryableIdentityFields(t *testing.T) {
c, _ := Lookup("im feed.groups batch_add_item")
s := NewSession(c)
s.ObserveRequest(map[string]any{"items": []any{
map[string]any{"feed_id": "oc_a", "feed_type": "chat", "content": "secret"},
}})
got, err := s.FinalizeSuccess(map[string]any{"failed_items": []any{
map[string]any{"item": map[string]any{"feed_id": "oc_a", "feed_type": "chat"}, "error_message": "server text"},
}})
if err != nil {
t.Fatal(err)
}
item := got.Data.(map[string]any)["completion"].(Completion).FailedItems[0].(map[string]any)
if len(item) != 2 || item["feed_id"] != "oc_a" || item["feed_type"] != "chat" {
t.Fatalf("failed item = %#v", item)
}
}
func TestCompletionIsClosedOverRequestedItems(t *testing.T) {
simple := func(id string) ledgerItem { return ledgerItem{key: id, value: id} }
compound := func(feedType, feedID string) ledgerItem {
return ledgerItem{
key: feedType + "\x00" + feedID,
value: map[string]any{
"feed_id": feedID, "feed_type": feedType,
},
}
}
for _, tc := range []struct {
name string
requested []ledgerItem
failed []ledgerItem
pending []ledgerItem
}{
{
name: "single IDs",
requested: []ledgerItem{simple("a"), simple("b"), simple("c"), simple("a")},
failed: []ledgerItem{simple("b"), simple("c"), simple("c"), simple("unknown")},
pending: []ledgerItem{simple("b"), simple("b"), simple("pending-unknown")},
},
{
name: "compound IDs",
requested: []ledgerItem{
compound("chat", "oc_a"), compound("doc", "doc_b"), compound("chat", "oc_a"),
},
failed: []ledgerItem{
compound("chat", "oc_a"), compound("chat", "oc_a"), compound("chat", "oc_unknown"),
compound("doc", "doc_b"),
},
pending: []ledgerItem{
compound("doc", "doc_b"), compound("doc", "doc_b"), compound("doc", "doc_unknown"),
},
},
} {
t.Run(tc.name, func(t *testing.T) {
got := completion(tc.requested, tc.failed, tc.pending, PartialRecoveryFailedItemsOnly)
if got.RequestedCount != got.SucceededCount+got.FailedCount+got.PendingCount {
t.Fatalf("non-exclusive counts: %#v", got)
}
if got.FailedCount != 1 || got.PendingCount != 1 {
t.Fatalf("failed/pending overlap was not resolved: %#v", got)
}
raw, err := json.Marshal(got)
if err != nil {
t.Fatal(err)
}
if strings.Contains(string(raw), "unknown") {
t.Fatalf("unrequested response item entered retry ledger: %s", raw)
}
})
}
}
func TestWriteSessionUnknownStrategyFailsClosed(t *testing.T) {
session := NewSession(Contract{
Key: "im future write",
Strategy: Strategy{Kind: StrategyKind("future_write")},
})
_, err := session.FinalizeSuccess(map[string]any{"accepted": true})
if err == nil || !errs.IsInternal(err) {
t.Fatalf("expected typed internal error, got %v", err)
}
}

View File

@@ -45,13 +45,10 @@ type EmitterConfig struct {
type EmitOptions struct {
Raw bool
Meta *Meta
Error interface{}
Hint string
Format string
JQ string
DryRun bool
Pretty PrettyRenderer
HintToStderr bool
JQSafetyWarning bool
}
@@ -104,23 +101,18 @@ func (e *Emitter) Success(data interface{}, opts EmitOptions) error {
return err
}
var err error
if opts.JQ != "" {
err = e.emitEnvelope(data, true, opts)
} else {
switch opts.Format {
case "", "json":
err = e.emitEnvelope(data, true, opts)
case "pretty":
err = e.emitPretty(data, opts)
default:
err = e.emitFormatted(data, opts.Format)
}
return e.emitEnvelope(data, true, opts)
}
if err != nil {
return err
switch opts.Format {
case "", "json":
return e.emitEnvelope(data, true, opts)
case "pretty":
return e.emitPretty(data, opts)
default:
return e.emitFormatted(data, opts.Format)
}
return e.emitHint(opts)
}
// PartialFailure emits a multi-status result whose envelope honestly reports
@@ -133,10 +125,7 @@ func (e *Emitter) PartialFailure(data interface{}, opts EmitOptions) error {
if err := e.requireOutput(); err != nil {
return err
}
if err := e.emitEnvelope(data, false, opts); err != nil {
return err
}
return e.emitHint(opts)
return e.emitEnvelope(data, false, opts)
}
// StreamPage scans and emits one page while retaining table/csv columns from
@@ -189,25 +178,6 @@ func (e *Emitter) StreamPage(data interface{}, opts StreamOptions) error {
})
}
// Hint writes recovery guidance to stderr through the same command-scoped
// output owner used for result emission.
func (e *Emitter) Hint(hint string) error {
return e.emitHint(EmitOptions{Hint: hint, HintToStderr: true})
}
// RedactedFallback atomically emits an already allowlisted fallback envelope.
// It deliberately skips safety scanning and jq: callers use it only after
// presentation failed, and must construct the envelope from fixed public
// fields rather than from the blocked payload.
func (e *Emitter) RedactedFallback(env Envelope) error {
if err := e.requireOutput(); err != nil {
return err
}
return e.emit(func(w io.Writer) error {
return WriteJSON(w, env)
})
}
func (e *Emitter) emitEnvelope(data interface{}, ok bool, opts EmitOptions) error {
scanResult := ScanForSafety(e.commandPath, data, e.errOut)
if scanResult.Blocked {
@@ -220,8 +190,6 @@ func (e *Emitter) emitEnvelope(data interface{}, ok bool, opts EmitOptions) erro
DryRun: opts.DryRun,
Data: data,
Meta: opts.Meta,
Error: opts.Error,
Hint: opts.Hint,
Notice: e.notice(),
}
if scanResult.Alert != nil {
@@ -348,16 +316,6 @@ func (e *Emitter) emit(render func(io.Writer) error) error {
return nil
}
func (e *Emitter) emitHint(opts EmitOptions) error {
if !opts.HintToStderr || opts.Hint == "" {
return nil
}
if _, err := fmt.Fprintf(e.errOut, "hint: %s\n", opts.Hint); err != nil {
return wrapOutputError("write", err)
}
return nil
}
func wrapOutputError(op string, err error) error {
return errs.NewInternalError(errs.SubtypeUnknown, "failed to %s command output", op).WithCause(err)
}

View File

@@ -63,123 +63,6 @@ func TestEmitterSuccessWritesAllBytes(t *testing.T) {
}
}
func TestEmitterPartialFailureCarriesContractFields(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}
complete := false
emitter := output.NewEmitter(output.EmitterConfig{
Out: stdout,
ErrOut: io.Discard,
CommandPath: "lark-cli im fixture",
Identity: "bot",
})
problem := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed")
err := emitter.PartialFailure(
map[string]interface{}{"items": []interface{}{"kept"}},
output.EmitOptions{
Format: "json",
Meta: &output.Meta{
Complete: &complete,
PagesFetched: 1,
StopReason: "transport_error",
},
Error: problem,
Hint: "Retry the read.",
},
)
if err != nil {
t.Fatalf("Emitter.PartialFailure() error = %v", err)
}
var env output.Envelope
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatalf("decode envelope: %v", err)
}
if env.OK || env.Hint != "Retry the read." || env.Meta == nil ||
env.Meta.Complete == nil || *env.Meta.Complete {
t.Fatalf("envelope = %#v, want typed incomplete result", env)
}
if env.Error == nil {
t.Fatalf("envelope = %#v, want structured error", env)
}
}
func TestEmitterJQProjectsContractHint(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}
emitter := output.NewEmitter(output.EmitterConfig{
Out: stdout,
ErrOut: io.Discard,
CommandPath: "lark-cli im fixture",
})
err := emitter.Success(map[string]interface{}{"id": "1"}, output.EmitOptions{
Format: "json",
JQ: ".hint",
Hint: "Use the same read entry point.",
})
if err != nil {
t.Fatalf("Emitter.Success() error = %v", err)
}
if got := strings.TrimSpace(stdout.String()); got != "Use the same read entry point." {
t.Fatalf("stdout = %q", got)
}
}
func TestEmitterNakedFormatWritesHintToStderr(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}
stderr := &bytes.Buffer{}
emitter := output.NewEmitter(output.EmitterConfig{
Out: stdout,
ErrOut: stderr,
CommandPath: "lark-cli im fixture",
})
err := emitter.Success([]interface{}{map[string]interface{}{"id": "1"}}, output.EmitOptions{
Format: "table",
Hint: "Result is incomplete.",
HintToStderr: true,
})
if err != nil {
t.Fatalf("Emitter.Success() error = %v", err)
}
if !strings.Contains(stderr.String(), "hint: Result is incomplete.") {
t.Fatalf("stderr = %q", stderr.String())
}
}
func TestEmitterRedactedFallbackSkipsBlockedPresentationScan(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "block")
extcs.Register(&contractSafetyProvider{alert: &extcs.Alert{
Provider: "emitter-contract",
MatchedRules: []string{"blocked-presentation"},
}})
t.Cleanup(func() { extcs.Register(nil) })
stdout := &bytes.Buffer{}
emitter := output.NewEmitter(output.EmitterConfig{
Out: stdout,
ErrOut: io.Discard,
CommandPath: "lark-cli im fixture",
})
err := emitter.RedactedFallback(output.Envelope{
OK: false,
Data: map[string]interface{}{"completion": map[string]interface{}{"status": "complete"}},
Error: errs.NewAPIError(errs.SubtypeUnknown, "Output failed after the IM write completed"),
})
if err != nil {
t.Fatalf("Emitter.RedactedFallback() error = %v", err)
}
var env output.Envelope
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatalf("decode fallback: %v", err)
}
if env.OK || env.Error == nil {
t.Fatalf("fallback = %#v, want redacted failure envelope", env)
}
}
func TestEmitterMarshalFailureReturnsTypedErrorWithoutOutput(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}

View File

@@ -10,20 +10,14 @@ type Envelope struct {
DryRun bool `json:"dry_run,omitempty"`
Data interface{} `json:"data,omitempty"`
Meta *Meta `json:"meta,omitempty"`
Error interface{} `json:"error,omitempty"`
Hint string `json:"hint,omitempty"`
ContentSafetyAlert interface{} `json:"_content_safety_alert,omitempty"`
Notice map[string]interface{} `json:"_notice,omitempty"`
}
// Meta carries optional metadata in envelope responses.
type Meta struct {
Count int `json:"count,omitempty"`
Rollback string `json:"rollback,omitempty"`
Complete *bool `json:"complete,omitempty"`
PagesFetched int `json:"pages_fetched,omitempty"`
StopReason string `json:"stop_reason,omitempty"`
NextPageToken string `json:"next_page_token,omitempty"`
Count int `json:"count,omitempty"`
Rollback string `json:"rollback,omitempty"`
}
// PendingNotice, if set, returns system-level notices to inject as the

View File

@@ -48,41 +48,3 @@ func WriteSuccessEnvelope(data interface{}, opts SuccessEnvelopeOptions) error {
JQSafetyWarning: true,
})
}
// WriteEnvelope emits a complete result envelope. It is used when a result
// needs to carry business data and a machine-readable completion/error state
// in one stdout document.
func WriteEnvelope(env Envelope, opts SuccessEnvelopeOptions) error {
identity := env.Identity
if identity == "" {
identity = opts.Identity
}
noticeProvider := GetNotice
if env.Notice != nil {
notice := env.Notice
noticeProvider = func() map[string]interface{} {
return notice
}
}
emitter := NewEmitter(EmitterConfig{
Out: opts.Out,
ErrOut: opts.ErrOut,
CommandPath: opts.CommandPath,
Identity: identity,
NoticeProvider: noticeProvider,
})
emitOpts := EmitOptions{
Format: "",
Raw: false,
JQ: opts.JqExpr,
DryRun: env.DryRun || opts.DryRun,
Meta: env.Meta,
Error: env.Error,
Hint: env.Hint,
JQSafetyWarning: true,
}
if env.OK {
return emitter.Success(env.Data, emitOpts)
}
return emitter.PartialFailure(env.Data, emitOpts)
}

View File

@@ -212,38 +212,3 @@ func TestWriteSuccessEnvelope_BlockModeReturnsTypedErrorWithoutStdout(t *testing
t.Fatalf("stdout should stay empty on block, got: %s", out.String())
}
}
func TestEnvelopeCompleteSerializesFalse(t *testing.T) {
complete := false
raw, err := json.Marshal(Envelope{OK: true, Meta: &Meta{Complete: &complete}})
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(raw), `"complete":false`) {
t.Fatalf("false completeness was omitted: %s", raw)
}
}
func TestWriteEnvelopeCarriesPartialResultAndTypedError(t *testing.T) {
var out strings.Builder
apiErr := errs.NewAPIError(errs.SubtypeUnknown, "one item failed")
err := WriteEnvelope(Envelope{
OK: false,
Data: map[string]any{"completion": map[string]any{"status": "partial"}},
Error: apiErr,
Hint: "retry only failed items",
}, SuccessEnvelopeOptions{Identity: "bot", Out: &out})
if err != nil {
t.Fatal(err)
}
var env map[string]any
if err := json.Unmarshal([]byte(out.String()), &env); err != nil {
t.Fatal(err)
}
if env["ok"] != false || env["hint"] != "retry only failed items" {
t.Fatalf("unexpected envelope: %#v", env)
}
if env["error"].(map[string]any)["type"] != "api" {
t.Fatalf("typed error missing: %#v", env)
}
}

View File

@@ -10,9 +10,7 @@ import (
"path/filepath"
"testing"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/rules"
)
func TestManifestExportWritesManifestAndCommandIndex(t *testing.T) {
@@ -47,16 +45,6 @@ func TestManifestExportWritesManifestAndCommandIndex(t *testing.T) {
}
}
func TestExportedCommandIndexMatchesIMContractCatalog(t *testing.T) {
index, err := collectCommandIndex(context.Background())
if err != nil {
t.Fatalf("collectCommandIndex() error = %v", err)
}
if diags := rules.CheckIMContractCoverage(index, imcatalog.All()); len(diags) != 0 {
t.Fatalf("exported IM contract diagnostics = %#v", diags)
}
}
func TestManifestExportRequiresOutputPaths(t *testing.T) {
var stderr bytes.Buffer
code := runManifestExport(nil, &stderr)

View File

@@ -45,18 +45,6 @@ Adding a new row requires approval from the matching CODEOWNERS or quality gate
`legacy-commands.txt` only covers hand-authored legacy commands. Generated OpenAPI service commands are intentionally excluded from `command-manifest.json`; they are included in `command-index.json` only so command references can be checked against the real CLI surface.
## Public Domain Allowlists
`internal/qualitygate/config/allowlists/public-domains.txt` contains supported public hostnames approved for Go source. `fixture-domains.txt` contains test-only hostnames used by `*_test.go`, the repository-root `tests/` directory, or any `testdata/` directory; fixture entries do not apply to production Go files or `skills/`.
Keep one lowercase exact hostname per line, sorted alphabetically. Wildcards, suffix rules, duplicates, schemes, ports, and paths are rejected; approving `larkoffice.com` does not approve its subdomains.
RFC 2606 reserves the `.test`, `.example`, `.invalid`, and `.localhost` namespaces plus the exact names `example.com`, `example.net`, and `example.org`. These names are accepted without an allowlist entry and must not be listed.
Every public entry needs a current non-fixture Go use, evidence that it is a supported public endpoint, and CODEOWNER approval. Other test-only hostnames belong in the fixture list. Tenant-specific, private-control-plane, and internal API hostnames are not eligible.
`lint/domaincontract` validates both lists and scans complete Go files. In CI, unapproved-host findings are limited to values whose expressions intersect added lines; list validation and unused-entry checks remain repository-wide. See `lint/README.md` for scanner semantics.
## Semantic Blocker Policy
The semantic reviewer can propose findings, but the local gatekeeper recomputes whether each finding is reproducible from `facts.json`. A finding blocks only when all of these are true:

View File

@@ -1,24 +0,0 @@
# Exact test-only hostnames. Keep sorted.
abc.feishu.cn
attacker.example.com
bytedance.feishu.cn
cdn.feishu.cn
evil.example.com
example.feishu.cn
example.larkoffice.com
example.larksuite.com
feishu.cn
feishu.doubao.com
gateway.docker.internal
host.containers.internal
host.docker.internal
host.lima.internal
lf3-static.bytednsdoc.com
meetings.feishu.cn
meetings.larksuite.com
p3-lark-file.byteimg.com
passport.feishu.cn
sample.feishu.cn
x.feishu.cn
xxx.feishu.cn
xxx.larksuite.com

View File

@@ -1,18 +0,0 @@
# Exact public hostnames. Keep sorted.
accounts.feishu.cn
accounts.larksuite.com
applink.feishu.cn
applink.larksuite.com
ark.ap-southeast.bytepluses.com
github.com
larkoffice.com
lf-larkemail.bytetos.com
mcp.feishu.cn
mcp.larksuite.com
open.feishu.cn
open.larksuite.com
registry.npmjs.org
registry.npmmirror.com
sf16-sg.tiktokcdn.com
www.feishu.cn
www.larksuite.com

View File

@@ -1,318 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package rules
import (
"fmt"
"sort"
"strings"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/report"
)
const (
imContractCoverageRule = "im_contract_coverage"
expectedIMLeafCommands = 60
)
var acceptanceOnlyCommandAllowlist = map[imcatalog.ContractKey]struct{}{
"im chat.moderation update": {},
}
func CheckIMContractCoverage(commandIndex manifest.Manifest, contracts []imcatalog.Contract) []report.Diagnostic {
leafKeys := imLeafCommandKeys(commandIndex)
leafSet := make(map[string]struct{}, len(leafKeys))
for _, key := range leafKeys {
leafSet[key] = struct{}{}
}
contractSet := make(map[string]imcatalog.Contract, len(contracts))
for _, contract := range contracts {
contractSet[string(contract.Key)] = contract
}
commandByPath := make(map[string]manifest.Command, len(commandIndex.Commands))
for _, command := range commandIndex.Commands {
commandByPath[command.Path] = command
}
var diags []report.Diagnostic
for allowedKey := range acceptanceOnlyCommandAllowlist {
key := string(allowedKey)
if _, ok := leafSet[key]; !ok {
diags = append(diags, imContractDiagnostic(
key,
"acceptance_only allowlist key does not match a runnable IM leaf command",
))
}
contract, ok := contractSet[key]
if !ok {
diags = append(diags, imContractDiagnostic(
key,
"acceptance_only allowlist key has no completion contract",
))
} else if contract.Strategy.Kind != imcatalog.AcceptanceOnlyKind {
diags = append(diags, imContractDiagnostic(
key,
fmt.Sprintf("acceptance_only allowlist entry is stale for strategy kind %q", contract.Strategy.Kind),
))
}
}
if len(leafKeys) != expectedIMLeafCommands {
diags = append(diags, imContractDiagnostic(
"",
fmt.Sprintf("IM leaf command count is %d, want %d", len(leafKeys), expectedIMLeafCommands),
))
}
for _, key := range leafKeys {
if _, ok := contractSet[key]; !ok {
diags = append(diags, imContractDiagnostic(key, "IM leaf command has no completion contract"))
}
}
for _, contract := range contracts {
key := string(contract.Key)
if _, ok := leafSet[key]; !ok {
diags = append(diags, imContractDiagnostic(key, "IM contract key does not match a runnable leaf command"))
}
for _, message := range validateIMContractShape(contract, commandByPath[key]) {
diags = append(diags, imContractDiagnostic(key, message))
}
}
return diags
}
func validateIMContractShape(contract imcatalog.Contract, command manifest.Command) []string {
var messages []string
key := string(contract.Key)
if !strings.HasPrefix(key, "im ") {
messages = append(messages, "IM contract key must start with \"im \"")
}
kind := contract.Strategy.Kind
if !kind.IsRead() && !kind.IsWrite() {
return append(messages, fmt.Sprintf("IM contract has unknown strategy kind %q", kind))
}
if command.Path != "" {
switch {
case kind == imcatalog.MaterializeReadKind &&
command.Risk != "read" && command.Risk != "write":
messages = append(messages, fmt.Sprintf("IM materialize read contract requires command risk read or write, got %q", command.Risk))
case kind.IsRead() && kind != imcatalog.MaterializeReadKind && command.Risk != "read":
messages = append(messages, fmt.Sprintf("IM read contract requires command risk read, got %q", command.Risk))
case kind.IsWrite() && command.Risk != "write" && command.Risk != "high-risk-write":
messages = append(messages, fmt.Sprintf("IM write contract requires command risk write or high-risk-write, got %q", command.Risk))
}
}
switch kind {
case imcatalog.AcceptanceOnlyKind:
if contract.ReplayMode != imcatalog.ReplayForbidden {
messages = append(messages, fmt.Sprintf(
"acceptance_only requires replay mode %q, got %q",
imcatalog.ReplayForbidden,
contract.ReplayMode,
))
}
if _, ok := acceptanceOnlyCommandAllowlist[contract.Key]; !ok {
messages = append(messages, "acceptance_only is not allowed for this IM command")
}
case imcatalog.RequiredResultKind:
if message := validateRequiredSpec(contract.Strategy.Required); message != "" {
messages = append(messages, message)
}
case imcatalog.BatchPartialKind:
if contract.Strategy.ResultLedger == nil {
if message := validateEvidenceSpec("request", contract.Strategy.Request); message != "" {
messages = append(messages, message)
}
if len(contract.Strategy.Failures) == 0 && len(contract.Strategy.Pending) == 0 {
messages = append(messages, "batch_partial requires failures, pending evidence, or a result ledger")
}
messages = append(messages, validateEvidenceSpecs("failure", contract.Strategy.Failures)...)
messages = append(messages, validateEvidenceSpecs("pending", contract.Strategy.Pending)...)
} else {
if message := validateEvidenceSpec("result ledger", *contract.Strategy.ResultLedger); message != "" {
messages = append(messages, message)
}
if evidenceSpecPresent(contract.Strategy.Request) ||
len(contract.Strategy.Failures) > 0 || len(contract.Strategy.Pending) > 0 {
messages = append(messages, "batch_partial result ledger cannot be combined with request, failure, or pending evidence")
}
}
case imcatalog.RequiredResultBatchPartialKind:
if message := validateRequiredSpec(contract.Strategy.Required); message != "" {
messages = append(messages, message)
}
if message := validateEvidenceSpec("request", contract.Strategy.Request); message != "" {
messages = append(messages, message)
}
if len(contract.Strategy.Failures) == 0 {
messages = append(messages, "required_result_batch_partial requires failure evidence")
}
messages = append(messages, validateEvidenceSpecs("failure", contract.Strategy.Failures)...)
messages = append(messages, validateEvidenceSpecs("pending", contract.Strategy.Pending)...)
case imcatalog.ResponseSetAssertionKind:
if message := validateEvidenceSpec("request", contract.Strategy.Request); message != "" {
messages = append(messages, message)
}
if len(contract.Strategy.ResponseSets) == 0 {
messages = append(messages, "response_set_assertion requires response sets")
}
messages = append(messages, validateEvidenceSpecs("response set", contract.Strategy.ResponseSets)...)
if contract.Strategy.Assertion != imcatalog.AssertRequestedPresent &&
contract.Strategy.Assertion != imcatalog.AssertRequestedAbsent {
messages = append(messages, fmt.Sprintf("response_set_assertion has unknown assertion %q", contract.Strategy.Assertion))
}
case imcatalog.SearchReadKind:
if strings.TrimSpace(contract.Strategy.CollectionField) == "" {
messages = append(messages, "search_read requires collection field")
}
}
messages = append(messages, validateUnexpectedStrategyFields(contract.Strategy)...)
return messages
}
func validateUnexpectedStrategyFields(strategy imcatalog.Strategy) []string {
allowed := map[string]bool{"kind": true}
switch strategy.Kind {
case imcatalog.EntityReadKind:
allowed["read_hint"] = true
case imcatalog.SearchReadKind:
allowed["collection_field"] = true
allowed["requires_materialization"] = true
case imcatalog.RequiredResultKind:
allowed["required"] = true
case imcatalog.BatchPartialKind:
allowed["request"] = true
allowed["failures"] = true
allowed["pending"] = true
allowed["result_ledger"] = true
case imcatalog.RequiredResultBatchPartialKind:
allowed["required"] = true
allowed["request"] = true
allowed["failures"] = true
allowed["pending"] = true
case imcatalog.ResponseSetAssertionKind:
allowed["request"] = true
allowed["response_sets"] = true
allowed["assertion"] = true
}
present := map[string]bool{
"required": requiredSpecPresent(strategy.Required),
"request": evidenceSpecPresent(strategy.Request),
"failures": len(strategy.Failures) > 0,
"pending": len(strategy.Pending) > 0,
"response_sets": len(strategy.ResponseSets) > 0,
"assertion": strategy.Assertion != "",
"result_ledger": strategy.ResultLedger != nil,
"collection_field": strategy.CollectionField != "",
"requires_materialization": strategy.RequiresMaterialization,
"read_hint": strategy.ReadHint != "",
}
var messages []string
for field, isPresent := range present {
if isPresent && !allowed[field] {
messages = append(messages, fmt.Sprintf("%s must not set strategy field %s", strategy.Kind, field))
}
}
sort.Strings(messages)
return messages
}
func requiredSpecPresent(spec imcatalog.RequiredSpec) bool {
return spec.Shape != 0 || spec.Field != "" || spec.Child != ""
}
func validateEvidenceSpecs(label string, specs []imcatalog.EvidenceSpec) []string {
var messages []string
for index, spec := range specs {
indexedLabel := fmt.Sprintf("%s[%d]", label, index)
if message := validateEvidenceSpec(indexedLabel, spec); message != "" {
messages = append(messages, message)
}
}
return messages
}
func evidenceSpecPresent(spec imcatalog.EvidenceSpec) bool {
return spec.Shape != 0 || spec.Field != "" || spec.IDField != "" || spec.Container != ""
}
func validateRequiredSpec(spec imcatalog.RequiredSpec) string {
if strings.TrimSpace(spec.Field) == "" {
return "required_result requires a non-empty field"
}
switch spec.Shape {
case imcatalog.RequiredTopString, imcatalog.RequiredTopObject:
if spec.Child != "" {
return "top-level required_result must not set child"
}
case imcatalog.RequiredNestedString:
if strings.TrimSpace(spec.Child) == "" {
return "nested required_result requires a child field"
}
default:
return fmt.Sprintf("required_result has unknown shape %d", spec.Shape)
}
return ""
}
func validateEvidenceSpec(label string, spec imcatalog.EvidenceSpec) string {
if strings.TrimSpace(spec.Field) == "" {
return label + " evidence requires a non-empty field"
}
switch spec.Shape {
case imcatalog.EvidenceStrings, imcatalog.EvidenceFeedObjects:
case imcatalog.EvidenceObjects, imcatalog.EvidenceStatusObjects:
if strings.TrimSpace(spec.IDField) == "" {
return label + " evidence requires an ID field"
}
case imcatalog.EvidenceNestedObjects:
if strings.TrimSpace(spec.IDField) == "" || strings.TrimSpace(spec.Container) == "" {
return label + " nested evidence requires container and ID fields"
}
case imcatalog.EvidenceNestedFeedObjects:
if strings.TrimSpace(spec.Container) == "" {
return label + " nested feed evidence requires a container field"
}
default:
return fmt.Sprintf("%s evidence has unknown shape %d", label, spec.Shape)
}
return ""
}
func imLeafCommandKeys(commandIndex manifest.Manifest) []string {
var candidates []string
for _, cmd := range commandIndex.Commands {
if cmd.Domain == "im" && cmd.Runnable {
candidates = append(candidates, cmd.Path)
}
}
sort.Strings(candidates)
leaves := make([]string, 0, len(candidates))
for _, path := range candidates {
parent := false
for _, other := range candidates {
if other != path && strings.HasPrefix(other, path+" ") {
parent = true
break
}
}
if !parent {
leaves = append(leaves, path)
}
}
return leaves
}
func imContractDiagnostic(commandPath, message string) report.Diagnostic {
return report.Diagnostic{
Rule: imContractCoverageRule,
Action: report.ActionReject,
File: "command-index",
Message: message,
SubjectType: "command",
CommandPath: commandPath,
}
}

View File

@@ -1,282 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package rules
import (
"fmt"
"strings"
"testing"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
qdiff "github.com/larksuite/cli/internal/qualitygate/diff"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/report"
)
func TestIMLeafCommandsExcludeParentsAndOtherDomains(t *testing.T) {
index := manifest.Manifest{Commands: []manifest.Command{
{Path: "im chat", Domain: "im", Runnable: true},
{Path: "im chat get", Domain: "im", Runnable: true},
{Path: "im chat list", Domain: "im", Runnable: false},
{Path: "docs chat get", Domain: "docs", Runnable: true},
}}
got := imLeafCommandKeys(index)
if len(got) != 1 || got[0] != "im chat get" {
t.Fatalf("IM leaves = %#v, want only runnable child", got)
}
}
func TestIMContractCoverageReportsMissingAndStaleKeys(t *testing.T) {
index, contracts := completeIMCoverageFixture()
contracts = contracts[1:]
contracts = append(contracts, imcatalog.Contract{
Key: "im stale command", Strategy: imcatalog.Strategy{Kind: imcatalog.EntityReadKind},
})
diags := CheckIMContractCoverage(index, contracts)
if !hasIMContractDiagnostic(diags, "im resource command00", "no completion contract") {
t.Fatalf("missing-command diagnostic absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, "im stale command", "does not match") {
t.Fatalf("stale-key diagnostic absent: %#v", diags)
}
}
func TestIMContractCoverageReportsMissingIMDomain(t *testing.T) {
index := manifest.Manifest{Commands: []manifest.Command{
{Path: "docs +fetch", Domain: "docs", Runnable: true},
}}
if leaves := imLeafCommandKeys(index); len(leaves) != 0 {
t.Fatalf("IM leaves = %#v, want none", leaves)
}
diags := CheckIMContractCoverage(index, imcatalog.All())
if !hasIMContractDiagnostic(diags, "", "IM leaf command count is 0, want 60") {
t.Fatalf("missing-domain diagnostic absent: %#v", diags)
}
}
func TestIMContractCoverageDiagnosticIsNotChangedFileFiltered(t *testing.T) {
diag := imContractDiagnostic("im +chat-list", "missing")
got := filterPRDiagnostics(
".",
"origin/main",
qdiff.FromChangedFiles([]string{"skills/lark-doc/SKILL.md"}),
manifest.Manifest{},
[]report.Diagnostic{diag},
)
if len(got) != 1 || got[0].Rule != imContractCoverageRule {
t.Fatalf("global IM coverage diagnostic was filtered: %#v", got)
}
}
func TestIMContractCoverageRejectsRiskAndStrategyShapeMismatches(t *testing.T) {
index, contracts := completeIMCoverageFixture()
index.Commands[0].Risk = "write"
contracts[1] = imcatalog.Contract{
Key: contracts[1].Key,
Strategy: imcatalog.Strategy{
Kind: imcatalog.RequiredResultKind,
Required: imcatalog.RequiredSpec{Shape: imcatalog.RequiredNestedString, Field: "message"},
},
ReplayMode: imcatalog.ReplayForbidden,
}
contracts[2] = imcatalog.Contract{
Key: contracts[2].Key,
Strategy: imcatalog.Strategy{
Kind: imcatalog.SearchReadKind,
CollectionField: "",
},
}
diags := CheckIMContractCoverage(index, contracts)
if !hasIMContractDiagnostic(diags, index.Commands[0].Path, "requires command risk read") {
t.Fatalf("read/write risk diagnostic absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, index.Commands[1].Path, "requires a child field") {
t.Fatalf("required shape diagnostic absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, index.Commands[2].Path, "requires collection field") {
t.Fatalf("search shape diagnostic absent: %#v", diags)
}
}
func TestIMContractCoverageAllowsMaterializeReadToWriteLocalOutput(t *testing.T) {
index, contracts := completeIMCoverageFixture()
index.Commands[0].Risk = "write"
contracts[0] = imcatalog.Contract{
Key: contracts[0].Key,
Strategy: imcatalog.Strategy{Kind: imcatalog.MaterializeReadKind},
}
diags := CheckIMContractCoverage(index, contracts)
for _, diagnostic := range diags {
if diagnostic.CommandPath == index.Commands[0].Path &&
strings.Contains(diagnostic.Message, "risk") {
t.Fatalf("materialize-read local write risk was rejected: %#v", diagnostic)
}
}
}
func TestIMContractCoverageRejectsUnknownKindAndNonIMKey(t *testing.T) {
index, contracts := completeIMCoverageFixture()
contracts[0] = imcatalog.Contract{
Key: "docs resource command00", Strategy: imcatalog.Strategy{Kind: imcatalog.StrategyKind("mystery")},
}
diags := CheckIMContractCoverage(index, contracts)
if !hasIMContractDiagnostic(diags, "docs resource command00", "must start with") ||
!hasIMContractDiagnostic(diags, "docs resource command00", "unknown strategy kind") {
t.Fatalf("unknown/non-IM diagnostics absent: %#v", diags)
}
}
func TestIMContractCoverageRestrictsAcceptanceOnlyContracts(t *testing.T) {
if len(acceptanceOnlyCommandAllowlist) != 1 {
t.Fatalf("acceptance-only allowlist = %#v, want only moderation update", acceptanceOnlyCommandAllowlist)
}
if _, ok := acceptanceOnlyCommandAllowlist["im chat.moderation update"]; !ok {
t.Fatalf("acceptance-only allowlist = %#v, want moderation update", acceptanceOnlyCommandAllowlist)
}
index, contracts := completeIMCoverageFixture()
if diags := CheckIMContractCoverage(index, contracts); len(diags) != 0 {
t.Fatalf("valid acceptance-only contract rejected: %#v", diags)
}
allowed := len(contracts) - 1
contracts[allowed].ReplayMode = imcatalog.ReplaySafe
if diags := CheckIMContractCoverage(index, contracts); !hasIMContractDiagnostic(
diags,
"im chat.moderation update",
"requires replay mode \"forbidden\"",
) {
t.Fatalf("replay-safe acceptance-only contract was not rejected: %#v", diags)
}
index, contracts = completeIMCoverageFixture()
index.Commands[0].Risk = "write"
contracts[0].Strategy = imcatalog.Strategy{Kind: imcatalog.AcceptanceOnlyKind}
contracts[0].ReplayMode = imcatalog.ReplayForbidden
if diags := CheckIMContractCoverage(index, contracts); !hasIMContractDiagnostic(
diags,
index.Commands[0].Path,
"is not allowed for this IM command",
) {
t.Fatalf("non-allowlisted acceptance-only contract was not rejected: %#v", diags)
}
index, contracts = completeIMCoverageFixture()
contracts[len(contracts)-1] = imcatalog.Contract{
Key: "im chat.moderation update",
Strategy: imcatalog.Strategy{
Kind: imcatalog.RequiredResultKind,
Required: imcatalog.RequiredSpec{Shape: imcatalog.RequiredNestedString, Field: "data"},
},
ReplayMode: imcatalog.ReplayForbidden,
}
if diags := CheckIMContractCoverage(index, contracts); !hasIMContractDiagnostic(
diags,
"im chat.moderation update",
"allowlist entry is stale",
) {
t.Fatalf("stale acceptance-only allowlist was not rejected: %#v", diags)
}
}
func TestIMContractCoverageRejectsIncompleteAndContradictoryEvidence(t *testing.T) {
index, contracts := completeIMCoverageFixture()
index.Commands[0].Risk = "write"
index.Commands[1].Risk = "write"
index.Commands[2].Risk = "write"
contracts[0] = imcatalog.Contract{
Key: contracts[0].Key,
Strategy: imcatalog.Strategy{
Kind: imcatalog.BatchPartialKind,
Request: imcatalog.EvidenceSpec{Shape: imcatalog.EvidenceStrings, Field: "ids"},
Failures: []imcatalog.EvidenceSpec{{Shape: imcatalog.EvidenceObjects, Field: "failed"}},
},
}
ledger := imcatalog.EvidenceSpec{Shape: imcatalog.EvidenceStatusObjects, Field: "results", IDField: "id"}
contracts[1] = imcatalog.Contract{
Key: contracts[1].Key,
Strategy: imcatalog.Strategy{
Kind: imcatalog.BatchPartialKind,
Request: imcatalog.EvidenceSpec{Shape: imcatalog.EvidenceStrings, Field: "ids"},
ResultLedger: &ledger,
},
}
contracts[2] = imcatalog.Contract{
Key: contracts[2].Key,
Strategy: imcatalog.Strategy{
Kind: imcatalog.ResponseSetAssertionKind,
Request: imcatalog.EvidenceSpec{Shape: imcatalog.EvidenceStrings, Field: "ids"},
ResponseSets: []imcatalog.EvidenceSpec{{Shape: imcatalog.EvidenceNestedObjects, Field: "members", IDField: "id"}},
Assertion: imcatalog.AssertRequestedPresent,
},
}
diags := CheckIMContractCoverage(index, contracts)
if !hasIMContractDiagnostic(diags, index.Commands[0].Path, "failure[0] evidence requires an ID field") {
t.Fatalf("failure shape diagnostic absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, index.Commands[1].Path, "result ledger cannot be combined") {
t.Fatalf("contradictory ledger diagnostic absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, index.Commands[2].Path, "response set[0] nested evidence requires container and ID fields") {
t.Fatalf("response-set shape diagnostic absent: %#v", diags)
}
}
func TestIMContractCoverageRejectsFieldsFromAnotherStrategyKind(t *testing.T) {
index, contracts := completeIMCoverageFixture()
contracts[0].Strategy.Required = imcatalog.RequiredSpec{
Shape: imcatalog.RequiredTopString,
Field: "message_id",
}
contracts[1].Strategy.ResponseSets = []imcatalog.EvidenceSpec{{
Shape: imcatalog.EvidenceStrings,
Field: "items",
}}
contracts[2].Strategy.CollectionField = "items"
diags := CheckIMContractCoverage(index, contracts)
if !hasIMContractDiagnostic(diags, index.Commands[0].Path, "entity_read must not set strategy field required") {
t.Fatalf("entity/required contradiction absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, index.Commands[1].Path, "entity_read must not set strategy field response_sets") {
t.Fatalf("entity/response-set contradiction absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, index.Commands[2].Path, "entity_read must not set strategy field collection_field") {
t.Fatalf("entity/search contradiction absent: %#v", diags)
}
}
func completeIMCoverageFixture() (manifest.Manifest, []imcatalog.Contract) {
index := manifest.Manifest{SchemaVersion: 1}
contracts := make([]imcatalog.Contract, 0, expectedIMLeafCommands)
for i := 0; i < expectedIMLeafCommands; i++ {
key := fmt.Sprintf("im resource command%02d", i)
risk := "read"
contract := imcatalog.Contract{
Key: imcatalog.ContractKey(key), Strategy: imcatalog.Strategy{Kind: imcatalog.EntityReadKind},
}
if i == expectedIMLeafCommands-1 {
key = "im chat.moderation update"
risk = "write"
contract = imcatalog.Contract{
Key: imcatalog.ContractKey(key),
Strategy: imcatalog.Strategy{Kind: imcatalog.AcceptanceOnlyKind},
ReplayMode: imcatalog.ReplayForbidden,
}
}
index.Commands = append(index.Commands, manifest.Command{Path: key, Domain: "im", Runnable: true, Risk: risk})
contracts = append(contracts, contract)
}
return index, contracts
}
func hasIMContractDiagnostic(diags []report.Diagnostic, key, text string) bool {
for _, diag := range diags {
if diag.CommandPath == key && strings.Contains(diag.Message, text) {
return true
}
}
return false
}

View File

@@ -11,7 +11,6 @@ import (
"sort"
"strings"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
qdiff "github.com/larksuite/cli/internal/qualitygate/diff"
manifestexamples "github.com/larksuite/cli/internal/qualitygate/examples"
"github.com/larksuite/cli/internal/qualitygate/facts"
@@ -44,7 +43,6 @@ func Run(ctx context.Context, opts Options) ([]report.Diagnostic, facts.Facts, e
if err := validateCommandIndexCoversManifest(m, commandIndex); err != nil {
return nil, facts.Facts{}, err
}
imContractDiags := CheckIMContractCoverage(commandIndex, imcatalog.All())
changed, err := qdiff.ChangedFiles(ctx, opts.Repo, opts.ChangedFrom)
if err != nil {
return nil, facts.Facts{}, err
@@ -112,7 +110,6 @@ func Run(ctx context.Context, opts Options) ([]report.Diagnostic, facts.Facts, e
}
diags = append(diags, publicContentDiagnostics(publicContent)...)
diags = filterPRDiagnostics(opts.Repo, opts.ChangedFrom, scope, m, diags)
diags = append(diags, imContractDiags...)
builtFacts := facts.BuildWithCommandLookup(m, commandIndex, skillFacts, skillQualityFacts, errorFacts, exampleFacts, outputFacts, diags, scope.Files)
return diags, facts.WithPublicContent(builtFacts, publicContentFacts(publicContent)), nil
@@ -215,10 +212,6 @@ func filterPRDiagnostics(repo, changedFrom string, scope qdiff.Scope, m manifest
commandScope := diagnosticCommandScopeFromFiles(scope.Files)
var out []report.Diagnostic
for _, diag := range diags {
if diag.Rule == imContractCoverageRule {
out = append(out, diag)
continue
}
if prDiagnosticRelevant(repo, scope.Files, commandScope, m, diag) {
out = append(out, diag)
}

View File

@@ -11,7 +11,6 @@ import (
"strings"
"testing"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
qdiff "github.com/larksuite/cli/internal/qualitygate/diff"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/report"
@@ -104,55 +103,6 @@ func TestRunRequiresCommandIndexToCoverManifest(t *testing.T) {
}
}
func TestRunReportsMissingIMDomain(t *testing.T) {
repo := t.TempDir()
runGit(t, repo, "init")
runGit(t, repo, "config", "user.email", "test@example.com")
runGit(t, repo, "config", "user.name", "Test User")
if err := vfs.WriteFile(filepath.Join(repo, "README.md"), []byte("# test\n"), 0o644); err != nil {
t.Fatal(err)
}
runGit(t, repo, "add", "README.md")
runGit(t, repo, "commit", "-m", "base")
if err := vfs.MkdirAll(filepath.Join(repo, "skills"), 0o755); err != nil {
t.Fatal(err)
}
manifestPath := filepath.Join(repo, "command-manifest.json")
indexPath := filepath.Join(repo, "command-index.json")
m := manifest.Manifest{SchemaVersion: 1, Commands: []manifest.Command{{
Path: "docs +fetch", Domain: "docs", Source: manifest.SourceShortcut,
}}}
index := manifest.Manifest{SchemaVersion: 1, Commands: []manifest.Command{
{
Path: "docs +fetch", Domain: "docs", Source: manifest.SourceShortcut, Runnable: true,
},
{
Path: "drive files get", Domain: "drive", Source: manifest.SourceService, Generated: true, Runnable: true,
},
}}
if err := manifest.WriteFile(manifestPath, manifest.KindCommandManifest, m); err != nil {
t.Fatal(err)
}
if err := manifest.WriteFile(indexPath, manifest.KindCommandIndex, index); err != nil {
t.Fatal(err)
}
diags, _, err := Run(context.Background(), Options{
Repo: repo,
CLIBin: "./lark-cli",
ChangedFrom: "HEAD",
ManifestPath: manifestPath,
CommandIndexPath: indexPath,
})
if err != nil {
t.Fatalf("Run() error = %v", err)
}
if !hasIMContractDiagnostic(diags, "", "IM leaf command count is 0, want 60") {
t.Fatalf("Run() missing-domain diagnostic absent: %#v", diags)
}
}
func TestRunReadsManifestFilesAndAcceptsServiceReferences(t *testing.T) {
repo := t.TempDir()
runGit(t, repo, "init")
@@ -210,15 +160,6 @@ description: Manage Drive comments with service command references.
},
},
}}
for _, contract := range imcatalog.All() {
risk := "read"
if contract.Strategy.Kind.IsWrite() {
risk = "write"
}
idx.Commands = append(idx.Commands, manifest.Command{
Path: string(contract.Key), Domain: "im", Source: manifest.SourceBuiltin, Runnable: true, Risk: risk,
})
}
if err := manifest.WriteFile(manifestPath, manifest.KindCommandManifest, m); err != nil {
t.Fatal(err)
}

View File

@@ -1,142 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
// Package deviceinfo collects the platform hardware product model and the
// platform values used by device-related risk-control headers.
package riskcontrol
import (
"runtime"
"strings"
"sync"
"unicode"
"unicode/utf8"
"golang.org/x/net/http/httpguts"
)
// OSType is the server-side risk-control operating-system enum.
type OSType string
// OS type enum values for X-Agent-Os-Type.
const (
OSTypeUnknown = "0"
OSTypeWindows = "1"
OSTypeLinux = "2"
OSTypeMacOS = "3"
)
const (
// TerminalTypePC is the fixed X-Agent-Terminal-Type value for the CLI.
TerminalTypePC = "1"
// Unknown is used when the hardware product model cannot be collected.
Unknown = "Unknown"
// deviceModelMaxBytes bounds the value added to X-Agent-Device-Type.
// Device models are short identifiers; a larger value is treated as
// malformed rather than truncated so the header never misrepresents it.
deviceModelMaxBytes = 256
)
// Snapshot contains the deliberately small risk-control signal set.
// ProductModel is omitted when the platform cannot provide a safe value.
type Snapshot struct {
OSType OSType
ProductModel string
}
// Source supplies one immutable process-level snapshot.
type Source interface {
Snapshot() Snapshot
}
// HostSource lazily reads host signals once, after outbound policy authorizes
// the first request. Failed probes are cached and are not retried per request.
type HostSource struct {
once sync.Once
value Snapshot
readModel func() string
}
// NewHostSource creates the production host signal source.
func NewHostSource() *HostSource {
return &HostSource{readModel: readDeviceModel}
}
// Snapshot returns the cached host signal snapshot.
func (s *HostSource) Snapshot() Snapshot {
if s == nil {
return Snapshot{}
}
s.once.Do(func() {
readModel := s.readModel
if readModel == nil {
readModel = readDeviceModel
}
s.value = Snapshot{
OSType: GetOSType(OSName()),
ProductModel: normalizeDeviceModel(readModel()),
}
})
return s.value
}
// normalizeModel removes non-printable characters and returns a model only
// when the remaining text is safe to use as an HTTP header value. Input that
// cannot produce a valid model is rejected so Get can fall back to Unknown.
func normalizeDeviceModel(model string) string {
if !utf8.ValidString(model) {
return ""
}
model = strings.Map(func(r rune) rune {
switch {
case r == '\r' || r == '\n' || r == '\x00':
return -1
case unicode.IsSpace(r):
return ' '
case unicode.IsPrint(r):
return r
default:
return -1
}
}, model)
model = strings.Join(strings.Fields(model), " ")
if model == "" || len(model) > deviceModelMaxBytes {
return ""
}
if !httpguts.ValidHeaderFieldValue(model) {
return ""
}
return model
}
// GetOSType maps a platform name to the X-Agent-Os-Type enum.
func GetOSType(osName string) OSType {
switch osName {
case "Windows":
return OSTypeWindows
case "Linux":
return OSTypeLinux
case "MacOS":
return OSTypeMacOS
default:
return OSTypeUnknown
}
}
// OSName returns the platform name used by GetOSType.
func OSName() string {
switch runtime.GOOS {
case "darwin":
return "MacOS"
case "windows":
return "Windows"
case "linux":
return "Linux"
default:
return runtime.GOOS
}
}

View File

@@ -1,27 +0,0 @@
//go:build darwin
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import "golang.org/x/sys/unix"
// readDeviceModel reads the current product key first and falls back to the
// legacy model key. Trying both keys is more robust than branching on a macOS
// version because virtualized or restricted environments may expose only one.
func readDeviceModel() string {
return readDarwinDeviceModel(unix.Sysctl)
}
func readDarwinDeviceModel(readSysctl func(string) (string, error)) string {
for _, key := range [...]string{"hw.product", "hw.model"} {
model, err := readSysctl(key)
if err == nil {
if model = normalizeDeviceModel(model); model != "" {
return model
}
}
}
return ""
}

View File

@@ -1,48 +0,0 @@
//go:build darwin
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import (
"errors"
"reflect"
"testing"
)
func TestReadDarwinDeviceModelPrefersProductAndFallsBackToModel(t *testing.T) {
t.Run("product available", func(t *testing.T) {
var keys []string
got := readDarwinDeviceModel(func(key string) (string, error) {
keys = append(keys, key)
if key == "hw.product" {
return "Mac16,1", nil
}
return "", errors.New("unexpected fallback")
})
if got != "Mac16,1" {
t.Fatalf("model = %q, want %q", got, "Mac16,1")
}
if want := []string{"hw.product"}; !reflect.DeepEqual(keys, want) {
t.Fatalf("sysctl keys = %v, want %v", keys, want)
}
})
t.Run("product unavailable", func(t *testing.T) {
var keys []string
got := readDarwinDeviceModel(func(key string) (string, error) {
keys = append(keys, key)
if key == "hw.model" {
return "MacBookPro18,3", nil
}
return "", errors.New("not available")
})
if got != "MacBookPro18,3" {
t.Fatalf("model = %q, want %q", got, "MacBookPro18,3")
}
if want := []string{"hw.product", "hw.model"}; !reflect.DeepEqual(keys, want) {
t.Fatalf("sysctl keys = %v, want %v", keys, want)
}
})
}

View File

@@ -1,17 +0,0 @@
//go:build linux
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
// readDeviceModel returns a stable device model for Linux. DMI and device-tree
// values vary widely and can expose the host or virtualization platform when
// the CLI runs in a container or sandbox.
func readDeviceModel() string {
return readLinuxDeviceModel()
}
func readLinuxDeviceModel() string {
return "linux"
}

View File

@@ -1,20 +0,0 @@
//go:build linux
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import "testing"
func TestReadDeviceModelReturnsLinux(t *testing.T) {
if got := readDeviceModel(); got != "linux" {
t.Fatalf("readDeviceModel() = %q, want %q", got, "linux")
}
}
func TestReadLinuxDeviceModel(t *testing.T) {
if got := readLinuxDeviceModel(); got != "linux" {
t.Fatalf("readLinuxDeviceModel() = %q, want %q", got, "linux")
}
}

View File

@@ -1,11 +0,0 @@
//go:build !darwin && !windows && !linux
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
// readDeviceModel returns an empty model on unsupported platforms.
func readDeviceModel() string {
return ""
}

View File

@@ -1,143 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import (
"fmt"
"strings"
"sync"
"sync/atomic"
"testing"
"unicode"
)
func TestHostSourceCachesNonEmptyModel(t *testing.T) {
calls := 0
s := &HostSource{readModel: func() string {
calls++
return " MacBookPro18,3\n"
}}
if got := s.Snapshot(); got.ProductModel != "MacBookPro18,3" {
t.Fatalf("first Snapshot().ProductModel = %q, want %q", got.ProductModel, "MacBookPro18,3")
}
if got := s.Snapshot(); got.ProductModel != "MacBookPro18,3" {
t.Fatalf("second Snapshot().ProductModel = %q, want cached model", got.ProductModel)
}
if calls != 1 {
t.Fatalf("read called %d times, want 1", calls)
}
}
func TestHostSourceCachesEmptyModel(t *testing.T) {
calls := 0
s := &HostSource{readModel: func() string {
calls++
return ""
}}
if got := s.Snapshot(); got.ProductModel != "" {
t.Fatalf("first Snapshot().ProductModel = %q, want empty", got.ProductModel)
}
if got := s.Snapshot(); got.ProductModel != "" {
t.Fatalf("second Snapshot().ProductModel = %q, want cached empty result", got.ProductModel)
}
if calls != 1 {
t.Fatalf("read called %d times, want 1", calls)
}
}
func TestHostSourceReadsOnceAcrossConcurrentCalls(t *testing.T) {
var calls atomic.Int32
s := &HostSource{readModel: func() string {
calls.Add(1)
return "ThinkPad X1 Carbon"
}}
const goroutines = 32
var wg sync.WaitGroup
wg.Add(goroutines)
for i := 0; i < goroutines; i++ {
go func() {
defer wg.Done()
snapshot := s.Snapshot()
if snapshot.ProductModel != "ThinkPad X1 Carbon" {
t.Errorf("Snapshot().ProductModel = %q, want %q", snapshot.ProductModel, "ThinkPad X1 Carbon")
}
}()
}
wg.Wait()
if got := calls.Load(); got != 1 {
t.Fatalf("read called %d times, want 1", got)
}
}
func TestNormalizeDeviceModel(t *testing.T) {
tests := []struct {
name string
model string
want string
}{
{name: "trims surrounding whitespace", model: " MacBookPro18,3\n", want: "MacBookPro18,3"},
{name: "trims device tree terminator", model: "Raspberry Pi 5\x00", want: "Raspberry Pi 5"},
{name: "allows printable Unicode", model: "联想 ThinkPad X1", want: "联想 ThinkPad X1"},
{name: "rejects empty", model: " \t\r\n"},
{name: "rejects invalid UTF-8", model: string([]byte{'M', 0xff, '1'})},
{name: "removes CRLF", model: "model\r\nname", want: "modelname"},
{name: "normalizes tab", model: "model\tname", want: "model name"},
{name: "removes NUL", model: "model\x00name", want: "modelname"},
{name: "removes control character", model: "model\x1fname", want: "modelname"},
{name: "removes DEL", model: "model\x7fname", want: "modelname"},
{name: "normalizes Unicode line separator", model: "model\u2028name", want: "model name"},
{name: "collapses whitespace", model: " model\t \u00a0 name ", want: "model name"},
{name: "accepts maximum byte length", model: strings.Repeat("a", deviceModelMaxBytes), want: strings.Repeat("a", deviceModelMaxBytes)},
{name: "rejects overlong value", model: strings.Repeat("a", deviceModelMaxBytes+1)},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := normalizeDeviceModel(tt.model); got != tt.want {
t.Fatalf("normalizeDeviceModel(%q) = %q, want %q", tt.model, got, tt.want)
}
})
}
}
func TestNormalizeDeviceModelRemovesHTTPControlBytes(t *testing.T) {
for value := 0; value <= 0x7f; value++ {
if value >= 0x20 && value < 0x7f {
continue
}
t.Run(fmt.Sprintf("0x%02x", value), func(t *testing.T) {
model := "model" + string(rune(value)) + "name"
want := "modelname"
if value != '\r' && value != '\n' && value != '\x00' && unicode.IsSpace(rune(value)) {
want = "model name"
}
if got := normalizeDeviceModel(model); got != want {
t.Fatalf("normalizeDeviceModel(%q) = %q, want %q", model, got, want)
}
})
}
}
func TestGetOSType(t *testing.T) {
tests := []struct {
name string
want OSType
}{
{name: "Windows", want: OSTypeWindows},
{name: "Linux", want: OSTypeLinux},
{name: "MacOS", want: OSTypeMacOS},
{name: "unknown", want: OSTypeUnknown},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := GetOSType(tt.name); got != tt.want {
t.Errorf("GetOSType(%q) = %q, want %q", tt.name, got, tt.want)
}
})
}
}

View File

@@ -1,44 +0,0 @@
//go:build windows
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import "golang.org/x/sys/windows/registry"
// systemInfoRegistryPaths lists registry locations in device-model lookup order.
var systemInfoRegistryPaths = [...]string{
`HARDWARE\DESCRIPTION\System\BIOS`,
`SYSTEM\CurrentControlSet\Control\SystemInformation`,
`SYSTEM\HardwareConfig\Current`,
}
// readDeviceModel returns the first product name found in the Windows registry.
func readDeviceModel() string {
return readWindowsDeviceModel(readWindowsRegistryModel)
}
func readWindowsRegistryModel(path string) (string, error) {
key, err := registry.OpenKey(registry.LOCAL_MACHINE, path, registry.READ)
if err != nil {
return "", err
}
defer key.Close()
model, _, err := key.GetStringValue("SystemProductName")
return model, err
}
func readWindowsDeviceModel(readRegistryModel func(string) (string, error)) string {
for _, path := range systemInfoRegistryPaths {
model, err := readRegistryModel(path)
if err != nil {
continue
}
if model = normalizeDeviceModel(model); model != "" {
return model
}
}
return ""
}

View File

@@ -1,78 +0,0 @@
//go:build windows
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import (
"errors"
"reflect"
"testing"
)
func TestReadWindowsDeviceModelFallback(t *testing.T) {
readError := errors.New("registry read failed")
tests := []struct {
name string
values map[string]string
errors map[string]error
want string
wantPaths []string
}{
{
name: "first path wins",
values: map[string]string{systemInfoRegistryPaths[0]: "Surface Laptop"},
want: "Surface Laptop",
wantPaths: []string{systemInfoRegistryPaths[0]},
},
{
name: "read failure falls back",
errors: map[string]error{
systemInfoRegistryPaths[0]: readError,
},
values: map[string]string{
systemInfoRegistryPaths[1]: "ThinkPad X1 Carbon",
},
want: "ThinkPad X1 Carbon",
wantPaths: systemInfoRegistryPaths[:2],
},
{
name: "empty normalized value falls back",
values: map[string]string{
systemInfoRegistryPaths[0]: " \r\n\x00",
systemInfoRegistryPaths[1]: "Latitude 7450",
},
want: "Latitude 7450",
wantPaths: systemInfoRegistryPaths[:2],
},
{
name: "all paths fail",
errors: map[string]error{
systemInfoRegistryPaths[0]: readError,
systemInfoRegistryPaths[1]: readError,
systemInfoRegistryPaths[2]: readError,
},
wantPaths: systemInfoRegistryPaths[:],
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
var paths []string
got := readWindowsDeviceModel(func(path string) (string, error) {
paths = append(paths, path)
if err := tt.errors[path]; err != nil {
return "", err
}
return tt.values[path], nil
})
if got != tt.want {
t.Fatalf("model = %q, want %q", got, tt.want)
}
if !reflect.DeepEqual(paths, tt.wantPaths) {
t.Fatalf("registry paths = %v, want %v", paths, tt.wantPaths)
}
})
}
}

View File

@@ -1,138 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import (
"net/http"
"net/url"
"strings"
"github.com/larksuite/cli/internal/core"
internaltransport "github.com/larksuite/cli/internal/transport"
)
const (
HeaderProductModel = "X-Agent-Device-Type"
HeaderOSType = "X-Agent-Os-Type"
)
var restrictedHeaders = [...]string{HeaderProductModel, HeaderOSType}
// Transport is the feature's final outbound boundary. It removes caller- or
// extension-supplied signal headers first and writes trusted values only after
// authorizing an official SDK origin and authentication state.
type Transport struct {
next http.RoundTripper
source Source
}
// NewTransport creates the final SDK outbound policy boundary. A nil source
// disables collection and injection while preserving restricted-header
// stripping for opt-out and extension-credential requests.
func NewTransport(next http.RoundTripper, source Source) *Transport {
if next == nil {
next = internaltransport.Fallback()
}
return &Transport{
next: next,
source: source,
}
}
// RoundTrip implements http.RoundTripper.
func (t *Transport) RoundTrip(req *http.Request) (*http.Response, error) {
req = req.Clone(req.Context())
if req.Header == nil {
req.Header = make(http.Header)
}
stripRestrictedHeaders(req.Header)
if t.source != nil && t.routeAllowsSignals(req) {
snapshot := t.source.Snapshot()
if isSupportedOSType(snapshot.OSType) {
req.Header.Set(HeaderOSType, string(snapshot.OSType))
}
if model := normalizeDeviceModel(snapshot.ProductModel); model != "" {
req.Header.Set(HeaderProductModel, model)
}
}
return t.next.RoundTrip(req)
}
func isSupportedOSType(value OSType) bool {
switch value {
case OSTypeWindows, OSTypeLinux, OSTypeMacOS:
return true
default:
return false
}
}
func stripRestrictedHeaders(header http.Header) {
for name := range header {
for _, restricted := range restrictedHeaders {
if strings.EqualFold(name, restricted) {
delete(header, name)
break
}
}
}
}
type origin struct {
scheme string
host string
port string
}
var officialFeishuOrigins = [...]origin{
apiOrigin(core.BrandFeishu, core.ResolveEndpoints(core.BrandFeishu).Open),
apiOrigin(core.BrandLark, core.ResolveEndpoints(core.BrandLark).Open),
apiOrigin(core.BrandFeishu, core.ResolveEndpoints(core.BrandFeishu).Accounts),
apiOrigin(core.BrandLark, core.ResolveEndpoints(core.BrandLark).Accounts),
}
func (t *Transport) routeAllowsSignals(req *http.Request) bool {
if req == nil || req.URL == nil {
return false
}
return isOfficialFeishuOrigin(originOf(req.URL))
}
func originOf(value *url.URL) origin {
if value == nil {
return origin{}
}
scheme := strings.ToLower(value.Scheme)
port := value.Port()
if port == "" {
switch scheme {
case "https":
port = "443"
case "http":
port = "80"
}
}
return origin{scheme: scheme, host: strings.ToLower(value.Hostname()), port: port}
}
func apiOrigin(brand core.LarkBrand, endpointURL string) origin {
endpoint, err := url.Parse(endpointURL)
if err != nil {
return origin{}
}
return originOf(endpoint)
}
func isOfficialFeishuOrigin(candidate origin) bool {
if candidate.scheme != "https" || candidate.port != "443" {
return false
}
for _, official := range officialFeishuOrigins {
if candidate == official {
return true
}
}
return false
}

View File

@@ -1,124 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package riskcontrol
import (
"net/http"
"strings"
"sync/atomic"
"testing"
)
type roundTripFunc func(*http.Request) (*http.Response, error)
func (f roundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) {
return f(req)
}
type countingSource struct {
calls atomic.Int32
}
func (s *countingSource) Snapshot() Snapshot {
s.calls.Add(1)
return Snapshot{OSType: OSTypeMacOS, ProductModel: "Mac16,1"}
}
type staticSource Snapshot
func (s staticSource) Snapshot() Snapshot { return Snapshot(s) }
func TestTransportAuthorizesBeforeCollecting(t *testing.T) {
tests := []struct {
name string
requestURL string
authorization string
wantSignals bool
}{
{name: "authenticated official HTTPS", requestURL: "https://open.feishu.cn/open-apis/test", authorization: "Bearer token", wantSignals: true},
{name: "Lark official HTTPS", requestURL: "https://open.larksuite.com/open-apis/test", authorization: "Bearer token", wantSignals: true},
{name: "official explicit HTTPS port", requestURL: "https://OPEN.FEISHU.CN:443/open-apis/test", authorization: "Bearer token", wantSignals: true},
{name: "unauthenticated", requestURL: "https://open.feishu.cn/open-apis/test", wantSignals: true},
{name: "official non-OpenAPI origin", requestURL: "https://accounts.feishu.cn/open-apis/test", authorization: "Bearer token", wantSignals: true},
{name: "off domain", requestURL: "https://example.com/test", authorization: "Bearer token", wantSignals: false},
{name: "lookalike", requestURL: "https://open.feishu.cn.evil.example/test", authorization: "Bearer token", wantSignals: false},
{name: "plain HTTP", requestURL: "http://open.feishu.cn/test", authorization: "Bearer token", wantSignals: false},
{name: "non-default port", requestURL: "https://open.feishu.cn:8443/test", authorization: "Bearer token", wantSignals: false},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
source := &countingSource{}
var received http.Header
base := roundTripFunc(func(req *http.Request) (*http.Response, error) {
received = req.Header.Clone()
return &http.Response{StatusCode: http.StatusOK, Body: http.NoBody}, nil
})
req, err := http.NewRequest(http.MethodGet, test.requestURL, nil)
if err != nil {
t.Fatal(err)
}
req.Header.Set("Authorization", test.authorization)
req.Header.Set(HeaderOSType, "caller-value")
req.Header.Set(HeaderProductModel, "caller-value")
req.Header["x-agent-device-type"] = []string{"non-canonical-caller-value"}
resp, err := NewTransport(base, source).RoundTrip(req)
if err != nil {
t.Fatal(err)
}
resp.Body.Close()
gotSignals := received.Get(HeaderOSType) != ""
if gotSignals != test.wantSignals {
t.Fatalf("signals present = %t, want %t; headers=%v", gotSignals, test.wantSignals, received)
}
wantCalls := int32(0)
if test.wantSignals {
wantCalls = 1
}
if got := source.calls.Load(); got != wantCalls {
t.Fatalf("Snapshot calls = %d, want %d", got, wantCalls)
}
if got := req.Header.Get(HeaderOSType); got != "caller-value" {
t.Fatalf("caller request OS header = %q, want unchanged", got)
}
if got := req.Header.Get(HeaderProductModel); got != "caller-value" {
t.Fatalf("caller request product-model header = %q, want unchanged", got)
}
if !test.wantSignals {
for name := range received {
if strings.EqualFold(name, HeaderProductModel) || strings.EqualFold(name, HeaderOSType) {
t.Fatalf("restricted header leaked as %q", name)
}
}
}
})
}
}
func TestTransportValidatesSourceSnapshot(t *testing.T) {
var received http.Header
base := roundTripFunc(func(req *http.Request) (*http.Response, error) {
received = req.Header.Clone()
return &http.Response{StatusCode: http.StatusOK, Body: http.NoBody}, nil
})
req, err := http.NewRequest(http.MethodGet, "https://open.feishu.cn/open-apis/test", nil)
if err != nil {
t.Fatal(err)
}
req.Header.Set("Authorization", "Bearer token")
resp, err := NewTransport(base, staticSource{
OSType: OSType("unsupported"),
ProductModel: "unsafe\nvalue",
}).RoundTrip(req)
if err != nil {
t.Fatal(err)
}
resp.Body.Close()
if received.Get(HeaderOSType) == "" && received.Get(HeaderProductModel) == "" {
t.Fatalf("no signals collected: %v", received)
}
}

View File

@@ -17,13 +17,6 @@ func SafeInputPath(path string) (string, error) {
return localfileio.SafeInputPath(path)
}
// LocalInputPath validates a local input path without restricting it to the
// current working directory. It delegates to localfileio.LocalInputPath so
// command validation and shared local-file readers use one policy.
func LocalInputPath(path string) (string, error) {
return localfileio.LocalInputPath(path)
}
// SafeEnvDirPath validates an environment-provided application directory path.
// Delegates to localfileio.SafeEnvDirPath.
func SafeEnvDirPath(path, envName string) (string, error) {

View File

@@ -211,18 +211,6 @@ func TestSafeLocalFlagPath(t *testing.T) {
}
}
func TestLocalInputPath_AllowsLocalPathsAndRejectsUnsafeCharacters(t *testing.T) {
for _, path := range []string{"/tmp/report.pdf", "../report.pdf"} {
got, err := LocalInputPath(path)
if err != nil || got != path {
t.Fatalf("LocalInputPath(%q) = %q, %v; want unchanged path", path, got, err)
}
}
if _, err := LocalInputPath("report\n.pdf"); err == nil {
t.Fatal("LocalInputPath() unexpectedly accepted a control character")
}
}
func TestSafeUploadPath_AllowsTempFileAbsolutePath(t *testing.T) {
// GIVEN: a real temp file (absolute path under os.TempDir())
f, err := os.CreateTemp("", "upload-test-*.bin")

View File

@@ -7,7 +7,6 @@ import (
"fmt"
"path/filepath"
"strings"
"unicode"
"github.com/larksuite/cli/internal/charcheck"
"github.com/larksuite/cli/internal/vfs"
@@ -23,32 +22,6 @@ func SafeInputPath(path string) (string, error) {
return safePath(path, "--file")
}
// LocalInputPath validates an input path in the process local filesystem
// namespace. It intentionally does not impose cwd containment or canonicalize
// the path: absolute paths, parent-relative paths, and symlink traversal retain
// their normal OS semantics. Character validation remains mandatory because
// paths are user-controlled and may appear in errors or progress output.
func LocalInputPath(path string) (string, error) {
if strings.TrimSpace(path) == "" {
return "", fmt.Errorf("local input path must not be empty")
}
if strings.IndexFunc(path, unicode.IsControl) >= 0 {
return "", fmt.Errorf("local input path must not contain control characters")
}
if err := charcheck.RejectControlChars(path, "local input path"); err != nil {
return "", err
}
if err := validateLocalInputPlatform(path); err != nil {
return "", err
}
return path, nil
}
func isWindowsNonLocalNamespace(path string) bool {
normalized := strings.ReplaceAll(path, "/", `\`)
return strings.HasPrefix(normalized, `\\`) || strings.HasPrefix(normalized, `\??\`)
}
// SafeLocalFlagPath validates a flag value as a local file path.
// Empty values and http/https URLs are returned unchanged without validation.
func SafeLocalFlagPath(flagName, value string) (string, error) {
@@ -56,7 +29,7 @@ func SafeLocalFlagPath(flagName, value string) (string, error) {
return value, nil
}
if _, err := SafeInputPath(value); err != nil {
return "", fmt.Errorf("%s: %w", flagName, err)
return "", fmt.Errorf("%s: %v", flagName, err)
}
return value, nil
}

View File

@@ -1,8 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
//go:build !windows
package localfileio
func validateLocalInputPlatform(string) error { return nil }

View File

@@ -1,33 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
//go:build windows
package localfileio
import (
"fmt"
"path/filepath"
"strings"
)
func validateLocalInputPlatform(path string) error {
if isWindowsNonLocalNamespace(path) {
return fmt.Errorf("local input path must not use a Windows network or device namespace")
}
cleaned := filepath.Clean(path)
volume := filepath.VolumeName(cleaned)
remainder := strings.TrimLeft(cleaned[len(volume):], `\/`)
for _, component := range strings.FieldsFunc(remainder, func(r rune) bool {
return r == '\\' || r == '/'
}) {
if component == "." || component == ".." {
continue
}
if !filepath.IsLocal(component) {
return fmt.Errorf("local input path contains a reserved Windows path component %q", component)
}
}
return nil
}

View File

@@ -1,27 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
//go:build windows
package localfileio
import "testing"
func TestLocalInputPath_RejectsWindowsNetworkDeviceAndReservedPaths(t *testing.T) {
for _, input := range []string{
`\\server\share\report.pdf`,
`//server/share/report.pdf`,
`\\.\pipe\upload`,
`\\?\C:\Users\agent\report.pdf`,
`\\?\UNC\server\share\report.pdf`,
`\??\C:\Users\agent\report.pdf`,
`C:\Users\agent\NUL.txt`,
`CON`,
} {
t.Run(input, func(t *testing.T) {
if _, err := LocalInputPath(input); err == nil {
t.Fatalf("LocalInputPath(%q) unexpectedly succeeded", input)
}
})
}
}

View File

@@ -4,7 +4,6 @@
package localfileio
import (
"fmt"
"os"
"path/filepath"
"strings"
@@ -72,72 +71,6 @@ func TestSafeOutputPath_RejectsPathTraversalAndDangerousInput(t *testing.T) {
}
}
func TestLocalInputPath_AllowsLocalNamespaceWithoutRewriting(t *testing.T) {
for _, input := range []string{
"/tmp/report.pdf",
"../outside/report.pdf",
"./report.pdf",
"nested/../report.pdf",
`C:\Users\agent\report.pdf`,
"报告.pdf",
} {
t.Run(input, func(t *testing.T) {
got, err := LocalInputPath(input)
if err != nil {
t.Fatalf("LocalInputPath(%q) error = %v", input, err)
}
if got != input {
t.Fatalf("LocalInputPath(%q) = %q, want path preserved verbatim", input, got)
}
})
}
}
func TestWindowsNonLocalNamespace(t *testing.T) {
for _, input := range []string{
`\\server\share\report.pdf`,
`//server/share/report.pdf`,
`\\.\pipe\upload`,
`\\?\C:\Users\agent\report.pdf`,
`\\?\UNC\server\share\report.pdf`,
`\??\C:\Users\agent\report.pdf`,
} {
if !isWindowsNonLocalNamespace(input) {
t.Errorf("isWindowsNonLocalNamespace(%q) = false, want true", input)
}
}
for _, input := range []string{
`C:\Users\agent\report.pdf`,
`C:/Users/agent/report.pdf`,
`..\outside\report.pdf`,
`.\report.pdf`,
} {
if isWindowsNonLocalNamespace(input) {
t.Errorf("isWindowsNonLocalNamespace(%q) = true, want false", input)
}
}
}
func TestLocalInputPath_RejectsEmptyControlAndDangerousUnicode(t *testing.T) {
for _, input := range []string{
"",
" ",
"file\x00.txt",
"file\tname.txt",
"file\nname.txt",
"file\rname.txt",
"file\u202Ename.txt",
"file\u200Bname.txt",
} {
t.Run(fmt.Sprintf("%q", input), func(t *testing.T) {
if _, err := LocalInputPath(input); err == nil {
t.Fatalf("LocalInputPath(%q) unexpectedly succeeded", input)
}
})
}
}
func TestSafeOutputPath_ReturnsCanonicalAbsolutePath(t *testing.T) {
// GIVEN: a clean temp directory as CWD
dir := t.TempDir()

View File

@@ -19,7 +19,7 @@ lint/
├── lintapi/ # shared types every domain returns
│ └── violation.go # Violation, Action, ActionReject / ActionLabel / ActionWarning
└── errscontract/ # first domain: typed-error contract guards
├── scan.go # ScanRepoWithOptions(root, opts) ← public entry
├── scan.go # ScanRepo(root) ([]lintapi.Violation, error) ← public entry
├── runner.go
├── typecheck.go
├── violation.go # local type aliases to lintapi
@@ -30,19 +30,16 @@ lint/
├── rule_subtype_classifier.go
├── rule_typed_error_completeness.go
└── *_test.go
└── domaincontract/ # resolver ownership + approved public hostname policy
├── scan.go # ScanRepoWithOptions(root, opts) ← public entry
── unapproved.go # Go AST/type-aware hostname extraction
├── policy.go # exact public/fixture allowlist validation
├── diff.go # added-line attribution
└── *_test.go
└── domaincontract/ # endpoint domain contract: no hardcoded resolver hosts
├── scan.go # ScanRepo(root) ([]lintapi.Violation, error) ← public entry
── scan_test.go
```
## Endpoint domain contract (`domaincontract`)
`domaincontract` contains two complementary Go source guards.
The resolver-ownership guard rejects:
`domaincontract` is a syntax-level regression guard for the resolver-owned
Open, Accounts, MCP, and AppLink hosts used by the Go CLI. In production `.go`
files it rejects:
- string literals containing a resolver-owned host FQDN
(`{open,accounts,mcp,applink}.{feishu.cn,larksuite.com}`), and
@@ -62,54 +59,17 @@ parse-level guard). The forbidden-host list is bound to the resolver source by
`TestForbiddenHostsMatchResolver`, so adding a resolver domain without updating
the guard fails the lint module's tests.
The approved-domain guard parses every Git-tracked Go file in full. In CI,
unapproved-host findings are limited to values whose expressions intersect an
added line; policy validation and unused-entry checks remain repository-wide.
It rejects an exact hostname unless it is present in one of:
This is not a general outbound-URL or data-flow analyzer. It does not inspect
non-Go assets, hosts assembled from string fragments, SDK constructor option
flow, or previously unknown Feishu/Lark hosts. The literal rule and code review
remain the backstop for those cases.
- `internal/qualitygate/config/allowlists/public-domains.txt`, for production
and test code; or
- `internal/qualitygate/config/allowlists/fixture-domains.txt`, only for
`*_test.go`, the repository-root `tests/`, and any `testdata/` (never
`skills/`).
RFC 2606 example/test names are accepted independently of those lists. This
includes the reserved `.test`, `.example`, `.invalid`, and `.localhost`
namespaces and the exact names `example.com`, `example.net`, and `example.org`;
they are safe placeholders rather than supported public endpoints.
High-confidence evidence is deliberately limited to static string expressions
assigned to `host`, `hostname`, or `domain` semantic names (including common
case/plural forms and collections), plus static strings whose entire value is
an absolute `http`, `https`, `ws`, or `wss` URL. It supports Go literals,
escapes, compile-time concatenation, constant references, grouped declarations,
multi-value assignments, and multiline expressions. Bare domain-shaped strings
without hostname semantics are not blocked.
Sequence values are scanned individually. For a hostname-semantic map, a key or
value is evidence only when it is the sole hostname-shaped side of that entry;
ambiguous string-to-string entries are not guessed. Struct fields use Go type
information so known non-network `Host` / `Domain` fields do not become hostname
evidence merely because an enum or command category contains a dot.
Allowlist matching is lowercase and exact: there are no wildcard, suffix, DNS,
or public-suffix exceptions. Entries must be sorted and unique, use ASCII
hostnames, and have a current in-scope use. See
`internal/qualitygate/config/README.md` for admission and approval rules.
This is not a general outbound-URL or cross-language data-flow analyzer. It does
not inspect non-Go assets or dynamically constructed values.
To add or change a resolver-owned Feishu/Lark endpoint, edit the resolver rather
than hardcoding the host elsewhere.
To add or change an outbound endpoint, edit the resolver — never hardcode a host.
## Running
```bash
# PR-scoped scan from the repo root (one level above lint/)
go run -C lint . --changed-from <base-revision> ..
# Full inventory (also reports historical unapproved hostnames)
# from the repo root (one level above lint/)
go run -C lint . ..
```
@@ -140,14 +100,10 @@ Exit codes follow `lint/main.go`:
import "github.com/larksuite/cli/lint/lintapi"
type ScanOptions struct {
ChangedFrom string
}
// ScanRepoWithOptions walks root and returns every violation produced
// by this domain's checks. Domains MUST return []lintapi.Violation so
// the top-level dispatcher can aggregate uniformly.
func ScanRepoWithOptions(root string, opts ScanOptions) ([]lintapi.Violation, error) { ... }
// ScanRepo walks root and returns every violation produced by this
// domain's checks. Domains MUST return []lintapi.Violation so the
// top-level dispatcher can aggregate uniformly.
func ScanRepo(root string) ([]lintapi.Violation, error) { ... }
```
3. Per-rule files are named `rule_<name>.go` with sibling
@@ -158,12 +114,8 @@ Exit codes follow `lint/main.go`:
```go
var scanners = []scanner{
{name: "errscontract", fn: errscontract.ScanRepoWithOptions},
{name: "<domain>", fn: func(root string, opts errscontract.ScanOptions) ([]lintapi.Violation, error) {
return <domain>.ScanRepoWithOptions(root, <domain>.ScanOptions{
ChangedFrom: opts.ChangedFrom,
})
}},
{name: "errscontract", fn: errscontract.ScanRepo},
{name: "<domain>", fn: <domain>.ScanRepo}, // ← add here
}
```

Some files were not shown because too many files have changed in this diff Show More