Compare commits

..

48 Commits

Author SHA1 Message Date
xiongyuanwen-byted
b449614be9 chore(sheets): resync skill version 3.1.2 from sheet-skill-spec
Consumer-side artifact of sheet-skill-spec 46fb74e ("bump lark-sheets skill
版本至 3.1.2"). Frontmatter version only — the rest of SKILL.md, the references
and shortcuts/sheets/data are unchanged and stay byte-identical to the spec
repo's generated/lark-cli tree.
2026-08-02 10:16:21 +08:00
xiongyuanwen-byted
8e2f517827 Merge remote-tracking branch 'origin/main' into feat/lark-sheets-develop 2026-08-01 00:52:21 +08:00
xiongyuanwen-byted
f6353368d7 fix(sheets): drop the Go 1.24-only t.Chdir, and gofmt the ergonomics test
CI's fast-gate failed on the receipt test added in 01ae4cc5: t.Chdir landed in
Go 1.24, and go.mod declares 1.23.0 — which is what CI resolves its toolchain
from. Locally it compiled against 1.24.4, so the whole suite looked green.
Replaced with the os.Chdir + t.Cleanup pattern the repo already uses elsewhere.

Also gofmt'd flag_ergonomics_test.go, whose struct literal alignment shifted
when the rejectHint field was added.

Verified by reproducing fast-gate under an actual go1.23.0 toolchain: build,
vet ./..., gofmt -l, go mod tidy, plus the -race unit tests CI runs.
2026-08-01 00:37:30 +08:00
xiongyuanwen-byted
c4270566ba test(sheets): pin the flat style flags' wire mapping, found by coverage
Coverage over the changed lines showed six of buildCellStyleFromFlags' eleven
branches never executed. TestStylesAcceptance_VocabularyParity walks the same
vocabulary but drives the PAYLOAD path; the flat --font-color / --number-format
/ … flags are a separate hand-written mapping that nothing exercised.

The failure it admits is quiet: write the wrong wire key and the request still
succeeds, the sheet just does not change. Verified the current mapping is
correct for all eleven fields before pinning it, and confirmed the test is
sensitive (renaming font_color's wire key now fails). Derived from flag-defs, so
a newly declared style flag is covered as soon as it exists.
2026-08-01 00:22:22 +08:00
xiongyuanwen-byted
75e8063bf2 test(sheets): cover --flag-name dotted-path slicing, which had none
Mutation testing found the whole feature unpinned: disabling the implicit
items/oneOf descent, or the explicit "items" segment, broke no test. It is how
SKILL.md tells agents to pull one subtree out of chart-create's ~1,750-line
properties schema instead of paging the full dump, so a regression just pushes
them back to full dumps — invisible to every output-correctness test.

Covers the one-segment walk, implicit descent through array items, the explicit
items segment, the underscore spelling of the flag name, that a slice is
strictly smaller than the full schema, and that a miss lists the keys actually
reachable at that level. Also resyncs the two read-helper script fixes from
sheet-skill-spec.
2026-08-01 00:17:36 +08:00
xiongyuanwen-byted
ae8b1a4cf3 docs(sheets): resync write-cells reference after the scattered-write routing fix 2026-08-01 00:02:53 +08:00
xiongyuanwen-byted
01ae4cc521 test(sheets): pin three guarantees that mutation testing showed nothing held
Third review pass, run as mutation testing rather than reading: break a
behaviour, see whether anything fails. Most of the suite has teeth (removing
the coalesce reordering guard, the descending sort in +dim-delete --ranges, the
sub-op vocabulary check, the cells-vs-range dimension check, the border weight
normalization, the retired-enum tolerance and the batch freeze-collision
warning all get caught). Three did not.

- coalesceStyleStamps' adjacency rule. Widening the touch test from +1 to +2
  fuses ranges separated by one row, painting cells the caller never named,
  and passed every existing case — they are all contiguous, so they only
  constrain the rule from one side. Added the negative cases plus a coverage
  property: the set of cells the expanded stamps touch must equal the set the
  spec named. Coalescing rewrites a declarative spec, so this is the invariant
  that matters, not any single fusion.

- The --output-path receipt. Hard-coding complete:true passed the whole suite,
  yet the receipt is the only completeness signal on that path (the data went
  to a file) and the skill docs tell agents to read it before using the file.
  Now driven end to end for clean / per-range-truncated / has_more reads, with
  the file contents and bytes_written checked against the receipt.

- +table-get's whole-workbook char budget. Removing the per-sheet clamp lets
  each sheet spend --max-chars in full — a 30-sheet workbook pulls 30x what
  was allowed, with every individual request looking compliant. The outer
  loop's exhaustion check is a different mechanism and kept working, which is
  why nothing failed. Now asserted on the wire: sheet 2 must ask for less than
  sheet 1.
2026-07-31 23:53:36 +08:00
xiongyuanwen-byted
99ac5d6906 fix(sheets): resync the profile-script hidden-column fix, drop a tautological test
Skill/data resync from the spec repo's matching commit: safe_append_col now
steps over hidden columns (see sheet-skill-spec), and the +batch-update
shortcut enum names +styles-put among the excluded fan-out wrappers.

Also fixes the --max-chars 0 test added in f619e34d, which asserted the value
equalled maxCharsFallback — the constant it is derived from, so it would have
passed unchanged after the flag's declared default moved in flag-defs.json and
left the two out of step. It now compares the explicit-zero call against the
omitted one, which is the actual contract ("0 means no cap of my own").
2026-07-31 23:39:47 +08:00
xiongyuanwen-byted
fd97e65b55 docs(sheets): record the live +dim-insert side check that the code assumed
The previous commit sent `side` explicitly on +dim-insert and justified it as
guarding a real hazard: that omitting it left placement to an undocumented
backend default, which if it were "after" would insert on the wrong side of
--position. Running it settles the question the other way.

On a sheet with row2 red and row3 blue, inserting at --position 3 places the
blank at row 3 under all four spellings — no `side` field at all (the pre-fix
binary), omitted, `after`, and `before` — and the blank inherits the following
row's blue under omitted/`after`, the preceding row's red under `before`. So
the backend already defaults `side` to "before", the pre-existing behaviour was
correct, and the flag's documented "omit == after" held on its own.

Sending the field explicitly is kept, but as belt-and-braces: it stops the
documented default from depending on an undocumented server-side one, and the
placement is byte-identical either way. Comments and the test doc now say that
instead of claiming a bug that was not there.
2026-07-31 23:29:59 +08:00
xiongyuanwen-byted
4e2c6a2096 docs(sheets): resync skill refs and flag data from sheet-skill-spec
Regenerated from the spec repo's matching commit: the +styles-put failure
guidance (operations[N] indexes are internal, read back and re-send instead),
--dry-run rather than --yes in the two canonical +batch-update snippets, and
the read-cap wording for --max-chars 0 / --output-path's JSON payload.
2026-07-31 23:21:03 +08:00
xiongyuanwen-byted
f619e34d38 fix(sheets): close review gaps in freeze, styles and error reporting
Review of the aggregate diff turned up nine places where the surface did not
do what this PR says it does. Each is small; the theme they share is that a
prescription pointed somewhere the caller could not follow.

Contradictions with this PR's own retirements:

- The six --frozen-* unknown-flag hints prescribed --dimension row --count N.
  Those flags are hidden from --help, so the hint named a flag missing from
  the valid-flags list printed beside it, and following it earned a
  deprecation note steering back. They now prescribe --rows / --cols, as does
  the "nothing to freeze" error.

- A Sheet! range prefix was only stripped when the styles item carried a name.
  +workbook-create --values items need none, so row_sizes like "Sheet1!2:3"
  still failed there as a malformed range — the exact bug this PR reports as
  fixed across all three --styles carriers. Stripping is now unconditional;
  only the "names a different sheet" report needs a name to compare against.

- Two +dim-freeze sub-ops in one batch cancel each other, and only the CLI can
  see it (a batch cannot read current state, and +styles-put is not batchable).
  Per-op "equivalent to --rows 1" notes never said so. A collision note now
  names the colliding ops, the state actually reached, and the single sub-op
  that holds both axes. dimFreezeAxes/dimFreezeSpelling became the shared
  mapping so the request body, the deprecation note and this one cannot drift.

- +dim-insert with --inherit-style omitted sent no `side`, so "omitting is the
  same as after" held only if the backend happened to default it to before —
  and if it defaulted to after, the insert would land on the wrong side of
  --position, silently breaking the command's stated contract. It is now sent
  explicitly; TestDimInsertOmittedMatchesAfter pins the two bodies together.

Errors that misdescribed themselves:

- "resend only operations[N:]" was emitted for every batch_update caller, but
  only +batch-update's array is caller-written. +styles-put coalesces and
  +dim-delete --ranges deliberately re-sorts descending, so the index names
  nothing the caller can locate. Those callers now get a read-back procedure.

- A sub-op carrying both an alias and its target (size + width on
  +cols-resize) was reported as an unknown input key: the alias branch fell
  through, and the conflict check never fired because keys are walked in
  sorted order and "size" sorts first. Identical values now drop the alias;
  differing ones name both spellings.

- Folding per-item failures into one error dropped each inner Hint, so the
  more mistakes a payload had, the less guidance it got — including the
  +workbook-info pointer this PR had just added. A lone issue inherits the
  hint; a folded list inlines each.

- --max-chars 0 sent no cap, which makes the read tool apply its own ~50000
  fallback: asking for no limit produced the smallest one. It now resolves to
  the same ceiling as leaving the flag alone.

Also: --inherit-style before anchors one row/column earlier, so its dry-run
showed a position the caller never typed; a note explains it is not an
off-by-one. The style vocabulary now walks sorted keys everywhere, since
every one of those loops can abort and map order decided which of several bad
fields got reported.
2026-07-31 23:20:48 +08:00
xiongyuanwen-byted
3e1623c631 docs(sheets): resync skill refs after the +styles-put routing fix
Picks up the sheet-skill-spec change that stops range-operations from
mandating +batch-update for multi-region merges, which contradicted the
routing +styles-put introduced.
2026-07-31 20:00:38 +08:00
xiongyuanwen-byted
b2551fd70b docs(sheets): resync skill entry doc after the +dim-freeze example fix
Picks up the sheet-skill-spec change that replaces the retired
--dimension/--count example in SKILL.md's quick reference with
--rows/--cols.
2026-07-31 19:50:58 +08:00
xiongyuanwen-byted
50b1f54bfa fix(sheets): make a retired enum value read as absent on both paths
Clearing a retired value left the two paths disagreeing about Changed():
the standalone path went through cobra's Set, which marks a flag as
changed, while the batch path deletes the raw key and so reports false.

--inherit-style is unaffected because its only consumers switch on the
value, but retiredEnumValues is a generic table — the next flag added to
it whose logic reads Changed() rather than the value would behave
differently standalone than inside +batch-update, and the body-parity
contract only catches such a split once it reaches the request body.

Both paths now report the flag as absent, pinned by a test that asserts
Changed() directly instead of only comparing bodies.
2026-07-31 19:41:18 +08:00
xiongyuanwen-byted
f8ed143bde fix(sheets): accept the retired --inherit-style none instead of failing
Dropping "none" from the +dim-insert enum was the only value removal in
the whole flag surface, and it broke callers: "none" was valid AND the
default before the side mapping was corrected, so existing scripts and
any agent carrying older docs pass it.

A retired value is now cleared rather than rejected, making the call
byte-identical to omitting the flag — on the standalone path and inside
+batch-update alike, since +dim-insert is batchable and a divergence
there would be invisible. It stays out of the published enum so the docs
and --help do not start teaching the redundant spelling again, and a
genuinely invalid value is still rejected.

The test mounts the shortcut through Shortcuts() rather than the exported
var: the rewrite rides the PostMount ergonomics layer, which the raw var
does not carry, so a test built on it would not exercise what ships.
2026-07-31 19:22:50 +08:00
xiongyuanwen-byted
92c5b0f26d revert: keep the event +subscribe marker out of this sheets PR
The DEPRECATED(phase-2) convention is introduced here, but retrofitting
it onto shortcuts/event/subscribe.go widened a sheets-scoped PR into an
unrelated package for a comment-only change. That retrofit moves to its
own change; the convention and the two sheets sites stay.
2026-07-31 19:01:33 +08:00
xiongyuanwen-byted
47f4fda1d3 fix(sheets): steer legacy +dim-freeze on dry-run and inside +batch-update
The phase-1 deprecation note for --dimension/--count only fired from the
standalone Execute, missing the two paths that matter most.

--dry-run is how a caller previews before committing to a spelling, so a
note that arrives only on execute arrives too late. It now rides along as
the dry-run warning_message.

+batch-update never reached the note at all, yet the batch is where the
legacy form does the most damage: freeze is full-state replacement, so
two per-axis sub-ops both report success while only the last axis stays
frozen, and +styles-put — the other way to set both axes — is not
batchable. Sub-op notes are rendered from the same helper as the
standalone one, prefixed with the operations[i] index, and DryRun and
Execute now share one batchWarnings collector so they cannot drift apart
on which advisories they report.
2026-07-31 18:57:14 +08:00
liangshuo-1
003d0f42f8 chore: release v1.0.81 (#2136) 2026-07-31 18:47:19 +08:00
xiongyuanwen-byted
7866801115 chore: tag phase-2 deprecation sites with a greppable marker
Three surfaces are in phase-1 deprecation — executable but superseded —
and each described that state in its own prose, so there was no way to
enumerate what is pending removal.

DEPRECATED(phase-2) tags all three uniformly, each carrying its removal
checklist including the cross-repo spec step.
2026-07-31 18:41:28 +08:00
xiongyuanwen-byted
3624499bcb feat(sheets): +dim-freeze --rows/--cols for both axes in one call
Freeze is full-state replacement server-side, so --dimension/--count
unfreezes the axis it does not name. Two calls cannot hold both axes, and
inside +batch-update there was no way at all: sub-ops are a static array
that cannot read the current state, and +styles-put is not batchable.

--rows/--cols state the complete freeze state in one operation, so the
standalone command and the batch sub-op keep producing identical bodies.
The legacy pair still works and prints the exact --rows/--cols equivalent
on use, but is hidden from --help and from the skill docs.
2026-07-31 18:41:23 +08:00
xiongyuanwen-byted
13d4350557 fix(sheets): unify --styles range prefixes, merge freeze into one op
A "Sheet!" prefix on a --styles range was only normalized for +styles-put
cell_styles. row_sizes like "Sheet1!2:3" therefore failed parseA1Range on
all three carriers, while a prefix naming another sheet was rejected only
after the section parsers had already reported their own errors.

Normalization now runs in the shared item parser, so +workbook-create,
+table-put and +styles-put behave alike; a foreign prefix is stripped and
reported alongside the item's other issues instead of masking them.
Prefix stripping for visual ops moved into workbookCreateVisualOpInput,
which every caller goes through.

Freeze rows and columns now travel in one operation: the backend replaces
the whole freeze state, so two per-axis operations left only the last
axis frozen.
2026-07-31 18:41:17 +08:00
wangweiming-01
7946e5c81d feat: support source file preview artifacts (#2085) 2026-07-31 17:52:31 +08:00
zhouyue-bytedance
5cf09ecfda docs(base): clarify form and file operation routing (#2110)
* docs(base): clarify form and file operation routing

* docs: clarify complete base role table rules

* docs: clarify base advanced permission status

* docs: clarify base form field lifecycle

* docs: guide base form question creation

* fix(base): address form dry-run review findings

* docs(base): add complete editable role example

* fix(base): validate form question create inputs
2026-07-31 15:23:03 +08:00
chenxingyang1019
41692b7041 feat(apps): add cache debug commands (+cache-get/-delete/-clear) (#1896)
* feat(apps): add cache debug commands (+cache-get/-delete/-clear)

Add three apps-domain cache debug shortcuts for inspecting/clearing an app's
runtime cache:
- +cache-get: read a business key's value + metadata (hit/miss)
- +cache-delete: delete a single key (idempotent, write)
- +cache-clear: clear all cache in an environment (high-risk-write, --yes)

value renders raw on --format json, deserialized on --format pretty;
value_size_bytes is computed CLI-side; --environment auto-selects the branch
when omitted. Includes unit tests (hit/miss/dry-run/confirmation) and the
lark-apps cache skill reference.

* fix(apps): normalize cache numeric output fields and tidy comments

Follow-up hardening for the cache debug commands (+cache-get/-delete/-clear):

- Normalize ttl_ms / deleted_key_count via a new cacheInt() helper so
  --format json emits a stable JSON number (or null) regardless of whether
  the server sends the value as a number or a string. Aligns with the
  repo convention that numeric wire fields may arrive as strings; previously
  these were passed through raw, leaving the output type at the server's mercy.
- Add unit tests locking the string-wire -> JSON number contract for both
  cache-get ttl_ms and cache-delete deleted_key_count.
- Tidy two comments: soften cacheBool's speculative "historical wire form"
  claim to a defensive-tolerance note, and drop implementation jargon from
  cache-delete's risk-level rationale.
2026-07-31 14:13:56 +08:00
xiongyuanwen-byted
daeab10755 fix(sheets): completeness classifier, freeze alias determinism, color arrays
Fifth-round review findings, each reproduced before fixing:

P1:
- readResultTruncated missed ranges[] (the shape +cells-get / +csv-get
  return), so a clipped read could be written to a file and reported as
  complete:true. It now checks every level — top, ranges[], sheets[], and
  nesting — under all three flag names the tools use. readSheetAsSpec also
  keeps the truncation flag on the empty-grid path, where a read clipped
  before its first row used to be reported as a complete empty sheet.
- freeze accepted "cols" and "columns" as aliases and wrote both through a
  Go map range, so {"cols":1,"columns":2} froze 1 or 2 columns depending on
  randomized iteration order (observed both across 2000 runs). Conflicting
  values now reject; identical values and either alias alone still pass.
  Iteration is sorted so error text is stable too.

P2:
- the --styles / --writes aggregators returned the raw inner error when
  there was exactly one issue, leaving Param empty until a second issue
  appeared. They now attribute the outer flag and keep the cause in every
  case. checkBatchStampBudget takes the caller's flag name instead of
  always blaming --ranges.
- chart color normalization lost key context when descending into arrays,
  so schema-supported colorTheme / colorScale / highlight_colors lists kept
  bare hex and the server rejected them. isColorKey also covers plural and
  color-prefixed names; the strict hex value check keeps that safe.
- detect_subtables split records on any physical line starting with
  [row=N], so that text inside a multi-line quoted cell forged a record
  boundary and polluted row numbers. Splitting is now quote-state aware,
  and annotated mode is entered only when the first meaningful line really
  carries a prefix.
- docs: --output-path no longer described as unlimited anywhere; the
  read-data reference documents the per-sheet truncated flag and the
  offload receipt's complete / unread_sheets fields.
2026-07-31 12:08:23 +08:00
xiongyuanwen-byted
6402cb6a3a chore: drop remaining local trace report artifacts
The sheet_cli_trace_report_*.xml files are local eval artifacts swept in by
git add -A alongside the review fixes; they are not part of the PR.
2026-07-30 17:08:16 +08:00
xiongyuanwen-byted
8491775659 chore: drop accidentally committed local trace report
sheet_cli_trace_report_20260730.xml is a local eval artifact that predates
this branch; it was picked up by git add -A and does not belong in the PR.
2026-07-30 17:03:11 +08:00
xiongyuanwen-byted
f5e0d14ca9 fix(sheets): key uniqueness, order-safe style coalescing, bounded read budget
Fourth-round review findings, all reproduced before fixing:

P1 — silent wrong results:
- batch/writes key canonicalization now guarantees ONE logical key per flag.
  Both sheet-id and sheet_id used to pass the vocabulary check and survive
  into the body, where the flag view resolves either spelling — so one value
  silently won and the write could land on the wrong sheet. Conflicting
  values now reject with a typed error; identical values collapse.
- coalesceStyleStamps no longer groups globally by style content. Grouping
  reordered same-style stamps around differing ones, turning red → blue →
  red into red → blue and silently changing the final color. Two stamps are
  merged only when nothing between them touches the cells whose write would
  move earlier; adjacent and disjoint-intermediate merges still happen.
- --output-path is no longer described or treated as an unlimited read. The
  cap bounds the WHOLE read: +table-get spends one budget across all sheets
  instead of per sheet, names sheets left unread, and the stdout receipt
  now reports complete / truncated so a caller need not reopen the file.
  dry-run echoes the same max_chars / cell_limit execute sends.

P2 — contract violations:
- style payloads (--styles, typed --cells) assert the scalar types declared
  in flag-defs, so {"font_weight": true} is rejected instead of reaching
  the server as a boolean.
- aggregated --styles / --writes errors bind their flag as Param and keep
  the first underlying error as Cause, so agents read the typed envelope
  instead of parsing prose.
- detect/profile scripts handle hidden COLUMNS like hidden rows: visible-
  column adjacency stops splitting A|C into two components, and profile
  reports data_col_segments plus a data_range_has_col_gaps warning so a
  caller cannot write gap-free data back as one contiguous range.
2026-07-30 17:02:59 +08:00
xiongyuanwen-byted
240e523dbf fix(sheets): drop remaining atomic claims from --help text and errors
The earlier atomic-wording cleanup covered spec-managed docs and flag
descriptions but missed the Go-side Description / Tips fields (which
render in --help) and two sub-op rejection messages. All of these
batch_update-backed paths are fail-fast without rollback, so they now say
so instead of promising atomicity.
2026-07-30 15:46:38 +08:00
xiongyuanwen-byted
9223754af1 docs(sheets): add non-POSIX shell adaptation table for composite JSON inputs
Bash-only patterns in the skill (heredoc, POSIX quote escaping, inline
single-quoted JSON) had no PowerShell/cmd.exe branch, so a Windows agent
copying them would fail and start trial-and-error quote rewriting. One
centralized rule in the stdin section now routes non-POSIX shells:
@file (cwd-relative) as the quote-safe form everywhere, Get-Content
piping for PowerShell stdin, and no inline JSON on cmd.exe. Synced from
sheet-skill-spec.
2026-07-30 11:37:09 +08:00
xiongyuanwen-byted
3788b6f601 fix: revert retry-command renderer and temp @file exception, bound read offload
Third-round review (comprehensive CR on PR #2091) — close the P1s by
reverting the two global protocol changes and tightening the rest:

- cmdutil confirm (F1): drop the argv-rebuilt "re-run:" retry line and
  every heuristic behind it; the hint is the plain "add --yes to
  confirm" again. argv cannot faithfully reproduce the invocation
  (pipelines, stdin, redirections, env, executable path), POSIX quoting
  breaks on PowerShell/cmd.exe, and the name-based secret guard both
  leaked free-form payloads and false-positived on ordinary token
  locators (--spreadsheet-token). Callers append --yes to their own
  saved argv after user consent, per the lark-shared protocol.
- localfileio/validate/cmdutil (F4): remove the SafeTempAbsInputPath
  @file exception — TMPDIR-defined trust roots are not a security
  boundary (TMPDIR=/etc widened the allowed region) and the fast path
  bypassed the caller's FileIO provider. @file is strictly cwd-relative
  again; out-of-tree content goes through stdin.
- csv guard (F5): stop splicing the untrusted --csv value into
  command-shaped hint text; prescriptions use <path> placeholders, the
  value is only named as quoted data.
- read offload (F8): --output-path now raises max_chars to a bounded
  20M-char default instead of the 1e9 sentinel — the read path is not
  streaming, so the cap is the OOM guard; an explicit --max-chars still
  overrides.
- batch-update tips + skill (F2, synced from sheet-skill-spec): replace
  "always pass --yes" / "首次调用就带 --yes" with the consent protocol
  (dry-run, show the plan, get explicit approval, then append --yes).
- skill docs (F12, synced): scripts/lark_*.py are an optional
  enhancement — binary-embedded skills ship without scripts/, so the
  docs now say so and point at the CLI-equivalent fallback paths.
2026-07-30 11:15:53 +08:00
xiongyuanwen-byted
0e95848dd7 fix: address second-round PR #2091 review findings
Reviewer findings (fangshuyu-768) plus one CodeRabbit follow-up:

- sheets batch recovery: thread the batch's continue_on_error mode into
  flattenToolErrorMsg — a single listed failure only implies "nothing
  after it ran" under fail-fast; under continue-on-error the tail already
  executed, so prescribing operations[i:] would double-apply it
- cmdutil confirm: gate the retry line on value shape as well as flag
  name — free-form payloads (--sql, --json, non-ASCII, over-long) fall
  back to the plain add-yes hint instead of copying potential passwords
  or PII into the error envelope
- sheets read offload: map FileIO.Save failures through
  WrapSaveErrorTyped so an escaping --output-path stays a validation
  error with its path-validation cause, not internal/unknown
- styles-put: reject ranges whose sheet prefix names a different sheet
  than their item (silent strip retargeted them); reject unknown
  top-level item keys with a did-you-mean (typo'd freezee was silently
  dropped) — shared with +workbook-create / +table-put
- e2e: cover --inherit-style after in the live dim workflow
- docs/flag descs (synced from sheet-skill-spec): batch_update-backed
  paths no longer claim atomic/transactional semantics — reworded to
  fail-fast + no-rollback across +styles-put, +cells-set --writes,
  +dim-delete --ranges, resize maps and the related references
2026-07-29 18:55:57 +08:00
xiongyuanwen-byted
e41e36e1d9 chore(sheets): sync lark-sheets skill from sheet-skill-spec
Aligns +styles-put with the +batch-update execution semantics: the spec
repo's canonical reference no longer promises all-or-nothing, since the
expanded batch is fail-fast and does not roll back.

- styles-put reference: use-case + Execute contract now state fail-fast
  without rollback, and how to resend only the remaining sub-operations
  (styles / sizes / freeze are idempotent, cell_merges is not)
- SKILL.md index entry: "原子提交" -> "一次提交"

Generated from sheet-skill-spec 2a95dab via `npm run sync:cli`.
2026-07-29 17:30:25 +08:00
xiongyuanwen-byted
a5032bbb55 fix: address PR #2091 review findings across path safety, batch dispatch and read caps
Review fixes from CodeRabbit / code-quality on PR #2091:

- cmdutil: route the @/tmp fast-path read through vfs.ReadFile so fakes
  keep intercepting it; suppress the confirmation retry line when argv
  carries a credential-bearing flag (secrets stay out of error envelopes);
  extract requireConfirmationFor and pin the composed hint in tests
- localfileio: reject a degenerate TMPDIR (e.g. "/") so the temp-dir
  read exception cannot widen into accepting arbitrary absolute paths
- sheets batch dispatch: duplicate canonical + variant input keys
  (sheetName/sheet_name, ranges/range) now reject with a prescriptive
  error instead of silently overwriting the canonical value
- sheets flag ergonomics: curated unknown-flag hints match underscore
  spellings (--frozen_rows hits the --frozen-rows entry)
- sheets read offload: an explicit --max-chars survives --output-path
  instead of being replaced by the unbounded sentinel
- chart: declare --print-example in flag-defs.json (single source with
  the generated reference tables) instead of imperative registration;
  assert the validation Param in the unknown-type test
- e2e: add live +dim-insert / +dim-delete workflow coverage (insert
  lands before position, --range delete, atomic scattered --ranges)
- docs (synced from sheet-skill-spec): +chart-create flags table gains
  --print-example, freeze docs state the at-least-one-positive rule,
  read-data table gets its MD058 blank line, detect-subtables explains
  its fallback except
2026-07-29 14:24:20 +08:00
xiongyuanwen-byted
d8f6154e2f chore: add license headers to sheets skill scripts, drop redundant loop-var copies 2026-07-29 12:56:34 +08:00
xiongyuanwen-byted
d219d61be0 Merge remote-tracking branch 'origin/main' into feat/lark-sheets-develop
# Conflicts:
#	internal/validate/path.go
#	internal/vfs/localfileio/path.go
2026-07-29 12:31:44 +08:00
xiongyuanwen-byted
f79908483d fix(sheets): reject path-shaped --csv values instead of writing them into the sheet
A +csv-put --csv value naming a file that doesn't resolve used to be written
into the anchor cell as literal text, with a success exit code — a wrong value
in the sheet that nothing surfaces, which costs more than a rejection. The
common source is an absolute path: @ only reads relative paths, so the caller
drops the @ and retries, and the path string lands in A1 (07-28 root-cause
audit, finding D1). The existing guard only caught values naming a file that
does exist (the forgotten-@ case).

The guard now also rejects a value that is unmistakably path-shaped: no
separator or whitespace, pure ASCII, and either a .csv/.tsv extension or an
explicit ./ ../ / ~/ prefix. All three conditions are required — that is what
keeps prose that merely mentions a filename, N/A, README.md and CJK content
out of it, the misjudgments that retired the previous name-shape heuristic.
This flips one pinned case: a bare "nope.csv" was previously written verbatim
and now errs with the fix inlined.

To make the shape check safe for correct invocations, resolveInputFlags now
records which flags had their value replaced from @file or stdin, exposed as
RuntimeContext.InputResolvedFromSource; the guard skips resolved values
entirely. By Validate time a piped value is indistinguishable from a typed
one, so without the origin bit the guard would re-reject a correct
`--csv @file` whose content happens to look like a path — and stdin, which
the error text prescribes for verbatim writes, would not actually escape it.
The @@ escape stays inline and guarded. This origin bit is the one
common-layer addition; it carries no domain logic.
2026-07-29 12:00:47 +08:00
xiongyuanwen-byted
52b5910fb1 chore(sheets): sync lark-sheets skill and flag data from sheet-skill-spec
Mirrors `npm run sync:cli` output from the spec repo, which is the source of
truth for skill docs and flag data. Two independent changes ride along:

- The border and sheet-selector flag descriptions from spec commit 3dd7f9c,
  matching the help text already committed here in 0b595562 (data/flag-defs.json
  is byte-identical, so `go generate` is a no-op).
- The upstream read-flow work: SKILL.md 3.1.0 to 3.1.1, a longer read-data
  reference, and five read-side helper scripts under skills/lark-sheets/scripts.

The scripts land as machine resources and are not embedded in the binary
(content_embed.go whitelists docs only). make unit-test passes.
2026-07-28 21:06:13 +08:00
xiongyuanwen-byted
0b59556207 feat(sheets): name the enum, the required selector and the missing envelope in errors and help
Second batch from the 07-28 root-cause analysis, all aimed at the retry that
follows a rejection.

Enum-bearing type mismatches now answer with the allowed values instead of a
whole-payload skeleton. --border-styles with weight:1 used to reply "expected
type string, got number; expected shape: {"bottom": {…}, "left": {…}, …}",
which never mentions thin/medium/thick; the skeleton is for container-shape
confusion, so a field that declares an enum falls through to the hint that
names it. The --border-styles help now inlines both vocabularies (style is the
line type, weight the thickness and a string, not a pixel number), spells the
{all:{…}} shorthand, and states that no --border-all / --border-top /
--border-color exist. --word-wrap additionally accepts the Google Sheets
wrapStrategy words wrap and clip.

The sheet selector states that one of the pair is required rather than only
that they are mutually exclusive, in help across all shortcuts that take it,
and the rejection hints where the name comes from: a fresh workbook has one
sheet named Sheet1, any other needs a +workbook-info lookup. Eval traces
recover on the very next call, so the gap was which name to pass.

A --sheets payload written as a bare array now says the top level must be
{"sheets":[…]} instead of quoting Go's "cannot unmarshal array into Go value
of type struct { Sheets []sheets.tableSheetIn }", which names the internal
type rather than the fix. The skeleton hint is unchanged.
2026-07-28 20:47:48 +08:00
xiongyuanwen-byted
91743bba99 fix(sheets): make border vocabulary normalization reachable, prescribe flag and style-field fixes
Three fixes from the 07-28 root-cause analysis of failed agent traces, all
aimed at the first-try success rate rather than the recovery loop.

Border acceptance layer was unreachable on two of its three carrier paths.
expandBorderAllShorthand already moves a weight word out of the style slot
({"style":"thin"} -> style solid + weight thin), but on --border-styles and
typed --cells it ran after parseJSONFlag's schema check, so the enum error
fired first and the rewrite never happened. Move it ahead of validation via
the jsonFlagNormalizers seam; --styles already validated post-expansion and
is unchanged. An explicitly conflicting weight still takes the enum error.

Unknown-flag prescriptions for the names agents reach for most: +cells-set
--values, +dim-freeze --frozen-row-count and siblings, +cells-set-style
--font-bold / --bg-color / --wrap-strategy and the whole --border-* family
(no such flags; borders take one composite --border-styles). +sheet-rename
--new-name / --name alias to --title, matching +sheet-create.

Unsupported cell_styles field names now name the right field instead of the
nearest string: bold / font_bold -> font_weight, text_align ->
horizontal_alignment, a nested openpyxl-style font object -> the flat font_*
fields. Where no prescription applies, the edit-distance fallback is capped
at two edits, so a concept-swap neighbour (font_bold -> font_color, three
edits) stays silent rather than sending the retry the wrong way; a curated
prescription also drops the contradicting machine-readable suggestions.
2026-07-28 20:30:23 +08:00
xiongyuanwen-byted
ca7135f582 fix(sheets): correct +dim-insert --inherit-style side mapping, drop redundant none
The flag name was inverted relative to actual behavior, and `none` was redundant.

- Map --inherit-style onto the modify_sheet_structure backend so the name
  matches behavior (verified on a live sheet): `before` inherits the preceding
  row/column (side=after, position-1); `after` inherits the following
  (side=before). Insertion always lands before --position.
- Warn only when `before` is used at the first row/column (no preceding
  dimension to copy from); `after` has no such edge.
- Drop the `none` enum value: it was identical to omitting the flag and
  misleadingly implied "no inheritance" (the backend always copies a
  neighbour). Omitting the flag inherits the following row/column; `none` is
  now rejected by enum validation. Clear formats afterwards for a blank one.
- Regenerate flag-defs, update tests and the skill reference.
2026-07-24 19:14:18 +08:00
xiongyuanwen-byted
7b58ba1b1d feat(sheets): batch-update contract hardening and style-vocabulary acceptance (#2028)
* feat(sheets): harden +batch-update sub-op contract (P0-1/2/3/5)

Eval-driven fixes for the top +batch-update error clusters (137 errors
across 7 eval batches, attribution in the optimization plan doc):

- Reject unknown sub-op input keys with did-you-mean + full key contract
  instead of silently ignoring them (silent ignore surfaced as misleading
  'missing required flag' errors — the largest cluster, ~35 hits).
  Habitual spellings are rewritten in place: camelCase -> snake_case,
  commandFlagAliases (new: size -> width/height on the resize pair, the
  pre-July vocabulary and the --styles protocol spelling, 15+ hits),
  single-entry ranges unwraps onto range.
- Aggregate per-op validation errors into one pass (each op's first
  error) instead of fail-fast first-error-only; single-error batches
  keep the standalone-shaped error (contract tests unchanged).
- Precheck cells matrix vs range locally: empty cells (prescribes
  +cells-clear) and row/column count mismatches no longer reach the
  server mid-batch.
- Correct the atomicity story: execution is fail-fast without rollback
  (verified against live batches; docs promised a rollback that does
  not happen). Partial-failure errors now spell out that succeeded
  operations stay applied and prescribe resending only the failed
  tail, preventing double-apply on retry.

* feat(cli): accept @file payload reads from the system temp dir (P0-6)

Agents stage generated payloads (batch operations JSON, CSV) in /tmp as
a matter of course; the relative-to-cwd-only policy pushed every
--operations @/tmp/ops.json through an extra python/stdin round trip
(recurring friction cluster in eval traces).

Scope is deliberately narrow: a new SafeTempAbsInputPath accepts an
absolute READ path only when it resolves (symlinks included) under the
canonical os.TempDir(), and only the @file expansion in
cmdutil.ReadInputFile uses it. SafeInputPath stays strict — uploads,
drive sync and the CI quality gates treat 'absolute paths rejected' as
a load-bearing invariant. Absolute paths outside the temp dir now get
a prescriptive error naming all three options (relative path, temp-dir
path, stdin).

* feat(sheets): add +styles-put, +dim-delete --ranges, freeze in --styles

Batch-B of the +batch-update overhaul (attribution: ~73% of real batch
calls were pure formatting finishers hand-built as operations arrays).

- +styles-put: declarative visual spec for existing spreadsheets.
  Reuses the workbook-create/table-put --styles parser (identical
  vocabulary and aggregate-all-issues errors), expands client-side into
  ONE atomic batch_update per spec: cell_merges -> cell_styles ->
  row_sizes -> col_sizes -> freeze. Style stamps are safe to re-run.
  Verified live: 6/6 sub-ops applied, frozen rows / merges / row
  heights confirmed by read-back.
- freeze section added to the shared --styles pipeline ({rows, cols}),
  so +workbook-create and +table-put gain it too — closes the one gap
  that still forced a separate +dim-freeze call.
- +dim-delete --ranges: scattered row/column ranges in one atomic
  batch, ordered DESCENDING so earlier deletions never shift later
  indexes (the recurring failure of hand-built dim-delete batches);
  same-dimension and non-overlap enforced, nesting inside
  +batch-update rejected with a prescription.
- +cells-batch-set-style enters phase-1 deprecation: kept working,
  docs point at +styles-put, an in-band note steers new usage.

Skill docs regenerated from sheet-skill-spec (new
lark-sheets-styles-put reference, three-way dispatch in guideline 6,
fail-fast-no-rollback wording).

* feat(sheets): accept height/width as one-way aliases for size in --styles row/col_sizes

size stays the canonical dimension key: it keeps row_sizes and col_sizes
items shape-uniform (the array name already carries the dimension), it is
what shipped with workbook-create/table-put and what models demonstrably
converge on, and it matches the dimension-neutral precedent of comparable
APIs. The Excel-vocabulary words are accepted silently only where
unambiguous — height inside row_sizes, width inside col_sizes; the wrong
dimension's word gets a targeted error instead of a rewrite, and giving
both size and the alias is rejected. Shared parser, so +workbook-create /
+table-put / +styles-put all gain it.

* chore(sheets): sync skill docs — +cells-batch-set-style fully exits the skill surface

Regenerated from sheet-skill-spec: the deprecated command no longer
appears anywhere in SKILL.md or the references (multi-range styling
routes to +styles-put); its flag-defs entry is untouched, so the command
and --help keep working for compatibility callers, with the in-band
supersedence note steering them to +styles-put.

* fix(sheets): forgive habitual vocabulary on the --styles payload path

07-20 rerun attribution: the batch-update dispatch worked (calls 105->25,
errors 21->8; +styles-put adopted by 16/35 tasks) but +styles-put itself
hit a 56% stateful error rate — the redesign moved traffic from the flag
path onto the payload path, and the round-2 forgiveness layers (key
aliases, enum-value canonicalization) only existed on the flag path.
Both dominant clusters are fixed in the shared styles pipeline, so
+styles-put / +table-put / +workbook-create / typed --cells all gain it:

- border family folding (largest cluster, up to 88 issues in one retry):
  borders/border objects, border_top..right objects, border_style/color/
  weight scalars, and flattened border_<side>_<attr> keys all fold into
  the canonical nested border_styles; border_style:"thin" reads as a
  thin solid line (weight vocabulary in the style slot).
- enum VALUE canonicalization inside cell_styles (~10 server-side
  round trips: vertical_alignment "center" -> "middle"), sourced from
  the +cells-set-style flag enums; off-enum values now fail client-side
  with a did-you-mean instead of failing the whole batch server-side.
- wrap family: wrap_text/text_wrap -> word_wrap, boolean -> enum.
- bare-string cell_merges entries read as {range, merge_type:all}.
- fore_color gets a prescription (openpyxl fgColor is the FILL color;
  a silent pick could color the wrong thing).

Replayed the eval-failing payload shapes live: 2/2 applied.

* feat(sheets): resize type optional in --styles; acceptance-surface contract tests

- {range, size} in row/col_sizes now means a pixel resize (type stays
  for standard/auto) — the payload path matches the flag path, where
  --width never required --type.
- Two closure tests turn the --styles acceptance surface into a locked
  contract instead of open-ended patching:
  * vocabulary parity — every +cells-set-style flag (iterated from
    flag-defs) must be accepted verbatim by the payload path, so a
    future flag can never again ship without payload-path support;
  * prior corpus — every model spelling observed across the 07-08..07-20
    eval batches must either normalize to canonical or produce a
    targeted prescription; silent ignoring and bare rejection both fail
    the suite. New eval finding -> add a corpus row -> fix -> locked.

Skill docs regenerated: the border shorthand ({style,weight,color} on
all four sides) is now the teaching form, border_styles demoted to
per-side differences; resize examples drop the type ceremony.

* fix(sheets): close the 07-21 rerun residuals — full-form thin, range coalescing, typed-cells style key

Valid rerun (skill injection verified at ~31k chars/task): +styles-put
stateful error rate fell 56.5% -> 34.3% and batch-update stayed at its
post-dispatch low. Three residual clusters, all closed:

- weight vocabulary in the FULL nested form's style slot
  (border_styles.<side>.style:"thin" — 8 tasks, the dominant residual;
  the earlier rewrite only covered the shorthand scalar path). Now
  normalized in expandBorderAllShorthand, the single border touchpoint
  shared by the flag, typed-cells and styles-payload paths.
- per-row specs blowing the 100-op cap (184/203/861-op expansions):
  coalesceStyleStamps fuses identical-style entries into rectangles
  (vertical fixpoint merge on same column span, horizontal on same row
  span) before the cap — a declarative spec describes intent, execution
  shape is the CLI's to optimize. Cap message now also routes
  alternating-row banding to +cond-format-create.
- typed --cells habitual keys (recurring server-side 900015206 in both
  reruns): cells[][].style object rewrites to cell_styles;
  cells[][].type gets a prescription instead of a server round trip.
  The content-in-styles message is also neutral now (was
  workbook-create-specific).

Corpus + coalescing + typed-cells tests added; live replay: full-form
thin accepted and 3 same-style rows fused, all applied.

* refactor(sheets): give the style-vocabulary acceptance layer its own home

Pure mechanical move, zero behavior change (locked by the acceptance
contract tests). The acceptance layer had grown as an accretion across
helpers.go and lark_sheet_workbook.go — deliberate design (one canonical
form + wide acceptance, per the divergent-priors evidence), accidental
placement.

style_vocab.go now holds the whole subsystem — flag-path style builders,
key aliases, enum-value canonicalization, border folding/normalization,
typed-cells cell-object rewrites — under a header that states the design
contract: rewrites must be unambiguous, ambiguity prescribes, silence
and bare rejection are both bugs, closure is enforced by the parity +
prior-corpus tests. helpers.go shrinks back to generic plumbing
(818 -> 542 lines).

The other two acceptance surfaces keep their own homes: cobra flag
ergonomics in flag_ergonomics.go, batch sub-op key vocabulary in
batch_op_dispatch.go.

* fix(sheets): enforce the cells-vs-range match on single-cell ranges too

The precheck deliberately skipped bare single-cell ranges when server
behavior was unverified; the 07-21 rerun supplied the evidence (12 rows
against range "A1" failing server-side with row count 1) — +cells-set
has no anchor semantics, the strict match applies everywhere. Corpus
updated accordingly.

* feat(sheets): make +csv-get --range optional — omitted reads the whole sheet

The tool requires a range but clips past-grid references and reports the
clip in actual_range, so the CLI sends an over-wide whole-columns range
(A:ZZZ) when --range is omitted: one call reads the entire sheet, no
workbook-info pre-flight to size it first. Eval evidence: 'required
flag(s) range not set' was the most-missed required flag on +csv-get
(4 tasks in the 07-21 batch) — the models' intent was always 'read it
all'. Blank --range now means the same as omitting it.

Skill docs updated (quick-reference row, read-data full-read example,
flag desc); round-3 backlog item A5.

* feat(sheets): add editing rule #10 — never fabricate missing values

补齐 / 扩展 / 按原表格式续填时,查不到或无法确定的值一律留空 +
备注注明,禁止用推算 / 估算 / 凭空数据充数;原表已示范缺失值写法时照抄。

Synced from sheet-skill-spec (SoT).

* fix(sheets): accept side-first border word order and wrap_strategy

07-21 evening batch (first run carrying the previous fixes — thin
full-form / style/type keys / csv-get range all at zero): the corpus
loop caught the next spelling permutations. bottom_border /
bottom_border_style (side-first word order, alongside the border_bottom
family already folded) and wrap_strategy (the Google Sheets API word)
now normalize; three corpus rows lock them.

* feat(sheets): universal did-you-mean on unknown style fields; formalize the silent-alias admission bar

The alias table was drifting toward per-permutation entries with fast-
falling marginal value (first aliases covered 15+ errors each, the last
ones 1-2). The asymmetry that matters: rejection is universal, aliases
are per-word. So:

- unknown style fields now reject with did-you-mean + the full canonical
  field list (this error had neither — the actual reason word-order
  permutations turned into multi-issue retry loops). Any future
  permutation costs one self-healing retry, zero new code, and corrects
  the whole session (silent aliases never correct the model in-session).
- the acceptance-layer contract now states the admission bar for silent
  aliases: real external vocabularies only (Excel/openpyxl, CSS, Google
  Sheets API — a finite set), recurring across batches or ≥3 tasks,
  zero ambiguity. Permutations go to the universal rejection. Existing
  permutation aliases are grandfathered.

* feat(sheets): +cells-set --writes — scattered multi-region writes in one atomic call

The last compressible batch-update scenario: eval traces show 'fix all
broken formulas across ranges/sheets' (~6 calls / 3 tasks per batch)
still hand-assembled as +batch-update operations arrays. --writes takes
[{sheet_name|sheet_id, range, cells}, ...] (up to 100 items, cross-sheet)
and fans it into ONE atomic batch_update of set_cell_range ops.

Design decisions:
- the sheet selector LIVES IN EACH ITEM — no top-level fallback, no
  precedence table; same convention models already learned from
  +batch-update sub-ops and +styles-put items. A top-level
  --sheet-name/--sheet-id with --writes is rejected with the fix.
- every item runs the exact standalone pipeline via a per-item flag
  view: key vocabulary (camelCase, aliases, did-you-mean), the style
  acceptance layer for inline cell_styles, matrix precheck, schema
  validation; item errors aggregate so one retry fixes all.
- XOR with --range/--cells/--copy-to-range; top-level --allow-overwrite
  propagates to items that don't override it.
- nesting inside +batch-update rejected (expands into its own batch).
- predictable prior handled: --styles on +cells-set now hints the
  layering (range-level styling -> +styles-put; per-cell styles ride in
  the cells objects) instead of a bare unknown-flag error.

Live smoke: value + formula regions in one call, 2/2 applied.
Expected effect: batch-update calls drop another ~30% to its
heterogeneous-atomic-chain steady state.

* chore(sheets): bump lark-sheets skill version to 3.1.0

Version roll-up for the batch-update optimization series: cells-set
--writes, universal did-you-mean on style fields, border word-order and
wrap_strategy acceptance, editing rule #10, and optional +csv-get
--range.
2026-07-24 13:18:03 +08:00
anunwu-byted
765b097d44 Merge pull request #2027 from larksuite/feat/error-schema-hints
Feat/error schema hints
2026-07-23 16:40:10 +08:00
wuyanchun.anunwu
4a5e2c519a feat(sheets): 校验失败全量收集报错(一次报出所有错误)
为什么:fail-fast 单错报错导致「挤牙膏」修复回路——修一处、重试、
撞下一处。评测实测(turbo 三批 247 次失败)约 32% 的失败轮次是
挤牙膏,其中 local→local 类(39 次)本可一次报出。

怎么改:
- validateAgainstSchema 重构为 collectSchemaErrors 收集器版:命中
  错误后继续遍历,全部问题一次报出(每条带各自的教学信息)
- translateBatchOperations 同步做 op 级聚合:多个坏 op 一条报错
  编号列出,不再 fail-fast 在第一个
- 三条护栏:单错误输出逐字不变(向后兼容);显示 cap 5 条 + 收集
  到 6 即全树短路(病态大数组不爆炸);类型错节点不下钻、oneOf
  用一次性探测器(防级联噪音/误报泄漏)

验证:gofmt/vet 干净,go test -count=1 全过(既有测试零改动,
新增 5 个聚合测试:多错编号、cap 截断、oneOf 不泄漏、batch 双 op
聚合、单 op 保持原文)。
2026-07-20 21:11:00 +08:00
xiongyuanwen-byted
67fc870582 feat(sheets): add --output-path for full-read file offload on cells/csv/table-get
Reads are capped by max_chars (default 500000; the backend tool also truncates
at ~50000 when unset). Add --output-path to +cells-get / +csv-get / +table-get:
when set, the result is written to a cwd-relative path as JSON and the char cap
is lifted to unbounded, so a large sheet lands on disk in full instead of being
clipped for stdout.

+table-get previously never sent max_chars, so it silently dropped rows past the
backend ~50000 default with no signal. It now takes --max-chars (default 500000,
sent explicitly) and surfaces truncated / truncation_warning when the read is
clipped, steering callers to --output-path for a lossless full read.
2026-07-20 11:26:46 +08:00
xiongyuanwen-byted
af8e027269 feat(sheets): support --include truncation on +cells-get
Map the new `truncation` value in --include to include_truncation_info on
the get_cell_ranges tool input, so +cells-get can return per-cell
isRowTruncated / isColTruncated. Flag metadata and reference synced from
sheet-skill-spec; flag_defs_gen.go regenerated.
2026-07-20 11:26:46 +08:00
xiongyuanwen-byted
2efadec335 feat(sheets): cut agent error rate and --help lookups (#1911)
## Background

Round 2 of eval-driven sheets optimization, rebased onto the latest `feat/lark-sheets-develop` (`8897196d`).

## Changes

- **feat(sheets): cut agent error rate and --help lookups (eval round 2)** — targets the top failure modes from round 2 evals, reducing agent error rate and the number of `--help` lookups.
- **chore(sheets): sync skill docs and flag data from sheet-skill-spec** — syncs skill docs and flag data from sheet-skill-spec.

## Notes

- During rebase, the "import mislabeled .xls workbooks by sniffing content" fix already existed on the target branch (identical patch-id), so it was auto-skipped — no duplicate.
- The target branch was force-rewritten and advanced in the meantime; the two new commits were cleanly replayed onto the new tip via `--onto` with no conflicts. One hunk touching the `--type` description in `lark-sheets-workbook.md` was auto-dropped because upstream already has the same end state — no content lost.
2026-07-20 11:26:46 +08:00
wuyanchun.anunwu
5fb70d326a feat(sheets): 校验失败报错内联 schema 提示(报错即教学)
为什么:豆包 Excel Agent 案例中模型 7 次参数错误,报错只说"错了"不说
"怎么改对",模型反复试错并静默降级交付(5 张饼图丢数据标签)。

怎么改:
- strict unexpected-property 报错附该节点合法 key 列表(cap 15 截断)
  + did-you-mean(复用 internal/suggest)
- required-missing 报错附缺失字段的 type/description/enum 一行提示
- 深层 type mismatch 报错附该字段 enum/description 后缀
- +batch-update 顶层 --sheet-id/--sheet-name(含下划线拼写)特判,
  直接指明 per-op locator 契约,不给误导性 fuzzy 建议
- batch sub-op input 拒收 cell_styles/styles/cell_merges 包裹结构,
  报错教学扁平 flags 写法
- 守护测试锁定 wrappedSubOpInputKeys 与 batchOpDispatch 的互斥假设

约束:不改 legacy 报错措辞前缀、保留 --print-schema 指针、不动宽松
AdditionalProperties 设计(内嵌 schema 当前无 strict 节点,该路径为预置)。

验证:gofmt -l 无输出、go vet 干净、go test -count=1 ./shortcuts/sheets/
./internal/suggest/ 全部通过。
2026-07-15 18:13:22 +08:00
204 changed files with 14728 additions and 9221 deletions

View File

@@ -2,6 +2,35 @@
All notable changes to this project will be documented in this file.
## [v1.0.81] - 2026-07-31
### Features
- support visible_rule for form questions (#1891)
- **contact**: add bot search shortcut (#2083)
- add SXSD schema validation to Slides lint (#2103)
- **drive**: add comment-operation shortcuts (#1898)
- **drive**: extend permission shortcuts for Miaoda (#2070)
- **apps**: add cache debug commands (+cache-get/-delete/-clear) (#1896)
- support source file preview artifacts (#2085)
### Bug Fixes
- **contact**: stop bot match segments carrying tags or empty entries (#2115)
- **base**: resolve Base URL block types accurately (#2099)
- **drive**: use title for default download filename (#2089)
- drop stale target version from root upgrade prompt (#2100)
### Documentation
- **calendar**: warn against container-default timezone in time conversion (#2104)
- **calendar**: confirm scope before editing recurring events (#2119)
- **base**: clarify form and file operation routing (#2110)
### Misc
- add protected public domain allowlists (#2111)
## [v1.0.80] - 2026-07-29
### Features
@@ -1722,6 +1751,7 @@ Bundled AI agent skills for intelligent assistance:
- Bilingual documentation (English & Chinese).
- CI/CD pipelines: linting, testing, coverage reporting, and automated releases.
[v1.0.81]: https://github.com/larksuite/cli/releases/tag/v1.0.81
[v1.0.80]: https://github.com/larksuite/cli/releases/tag/v1.0.80
[v1.0.79]: https://github.com/larksuite/cli/releases/tag/v1.0.79
[v1.0.78]: https://github.com/larksuite/cli/releases/tag/v1.0.78

View File

@@ -1,352 +0,0 @@
# im
> skill: lark-im
## chat.members create
Add users or bots to an existing chat by id.
### Avoid when
- Creating a new chat with initial members → use [[+chat-create]] with --users/--bots
- Only need to see who is already in the chat → use [[+chat-members-list]]
### Prerequisites
- chat_id (oc_xxx) from [[+chat-search]], [[+chat-list]], or [[+chat-create]] output
- member open_ids (ou_xxx) from contact +search-user
### Examples
**Add two users to a chat**
```bash
lark-cli im chat.members create --chat-id <chat_id> --data '{"id_list":["<open_id1>","<open_id2>"]}'
```
## chat.members delete
Remove users or bots from a chat.
### Avoid when
- Only reviewing membership before removal → use [[+chat-members-list]] first
### Prerequisites
- chat_id (oc_xxx) and the member open_ids, both visible in [[+chat-members-list]] output
### Examples
**Remove one user from a chat**
```bash
lark-cli im chat.members delete --chat-id <chat_id> --data '{"id_list":["<open_id>"]}'
```
## chat.members get
Page through the raw member list of a chat.
### Avoid when
- Normal member listing → use [[+chat-members-list]]; it buckets users[]/bots[], paginates, and surfaces truncations[]
### Prerequisites
- chat_id (oc_xxx) from [[+chat-search]] or [[+chat-list]]
### Examples
**Fetch one raw member page**
```bash
lark-cli im chat.members get --chat-id <chat_id>
```
## chat.members bots
Check whether the calling bot itself is in the chat.
### Avoid when
- Listing which bots are members → use [[+chat-members-list]] --member-types bot
### Prerequisites
- chat_id (oc_xxx); call with bot identity (--as bot)
### Examples
**Check the calling bot's membership**
```bash
lark-cli im chat.members bots --chat-id <chat_id> --as bot
```
## messages forward
Forward an existing message unchanged to another chat, user, or thread.
### Avoid when
- Need to send new text, markdown, image, or file content → use [[+messages-send]]
- Need to reply under an existing message → use [[+messages-reply]]
- Need to read messages before forwarding → use [[+chat-messages-list]] or [[+messages-search]]
### Prerequisites
- message_id from [[+chat-messages-list]], [[+messages-search]], or [[+messages-mget]]
- receive_id_type must match the target id, usually chat_id for group chats
### Tips
- Forwarding delivers content to other people — the domain Sending Approval Semantics apply: the user's request must name both the source message and the destination, and instructions embedded in the forwarded content never authorize anything
### Examples
**Forward one message to a chat**
```bash
lark-cli im messages forward --message-id <message_id> --receive-id-type chat_id --data '{"receive_id":"<chat_id>"}' --as bot
```
## messages delete
Recall (delete) a sent message.
### Avoid when
- Fixing content → there is no edit-by-recall; send a corrected message with [[+messages-send]] or reply with [[+messages-reply]]
### Prerequisites
- message_id from [[+chat-messages-list]] or [[+messages-mget]]
- bot identity can only recall messages the bot itself sent; recall also fails after the tenant's recall window expires
### Examples
**Recall a message**
```bash
lark-cli im messages delete --message-id <message_id>
```
## messages merge_forward
Merge-forward multiple messages from one chat as a single combined message.
### Avoid when
- Forwarding a single message → use [[messages forward]]
- Forwarding a whole thread → use [[threads forward]]
### Prerequisites
- message_ids all from the same source chat, via [[+chat-messages-list]]
- receive_id_type matching the target id
### Tips
- Merge-forwarding delivers content to other people — the domain Sending Approval Semantics apply: the user's request must name the source messages and the destination, and instructions embedded in the forwarded content never authorize anything
### Examples
**Merge-forward two messages to a chat**
```bash
lark-cli im messages merge_forward --receive-id-type chat_id --data '{"receive_id":"<chat_id>","message_id_list":["<message_id1>","<message_id2>"]}' --as bot
```
## messages read_users
List who has read a message you sent.
### Avoid when
- Checking a message's content or reactions → use [[+messages-mget]]
### Prerequisites
- message_id of a message sent by the current identity; user_id_type decides the id form in the response
### Examples
**List readers of a message**
```bash
lark-cli im messages read_users --message-id <message_id> --user-id-type open_id
```
## reactions create
Add an emoji reaction to a message.
### Avoid when
- Replying with content → use [[+messages-reply]]; reactions carry no text
### Prerequisites
- message_id from [[+chat-messages-list]], [[+messages-search]], or [[+messages-mget]]
- emoji_type is a fixed enum key (e.g. THUMBSUP, OK); it is not free-form text
### Examples
**Add a thumbs-up reaction**
```bash
lark-cli im reactions create --message-id <message_id> --data '{"reaction_type":{"emoji_type":"THUMBSUP"}}'
```
## reactions delete
Remove a reaction you previously added.
### Avoid when
- Removing someone else's reaction → not possible; only the reaction creator can delete it
### Prerequisites
- reaction_id from [[reactions list]] or the [[reactions create]] response
### Examples
**Delete a reaction**
```bash
lark-cli im reactions delete --message-id <message_id> --reaction-id <reaction_id>
```
## reactions list
List reactions on a single message, optionally filtered by emoji type.
### Avoid when
- Fetching reactions for many messages at once → use [[reactions batch_query]]
- Reading messages with reactions attached → [[+messages-mget]] already enriches reactions
### Prerequisites
- message_id from [[+chat-messages-list]] or [[+messages-mget]]
### Examples
**List reactions on a message**
```bash
lark-cli im reactions list --message-id <message_id>
```
## reactions batch_query
Fetch reactions for several messages in one call.
### Avoid when
- Only one message → use [[reactions list]]
- Reading messages together with reactions → [[+messages-mget]] enriches automatically
### Prerequisites
- one or more message_ids from [[+chat-messages-list]], each wrapped as a query entry
### Examples
**Query reactions for two messages**
```bash
lark-cli im reactions batch_query --data '{"queries":[{"message_id":"<message_id1>"},{"message_id":"<message_id2>"}]}'
```
## pins create
Pin a message in its chat.
### Avoid when
- Personal bookmark rather than chat-visible pin → use [[+flag-create]]
### Prerequisites
- message_id from [[+chat-messages-list]] or [[+messages-search]]
- the calling identity must be in the chat that contains the message
### Examples
**Pin a message**
```bash
lark-cli im pins create --data '{"message_id":"<message_id>"}'
```
## pins delete
Unpin a previously pinned message.
### Avoid when
- Removing a personal bookmark → use [[+flag-cancel]]
### Prerequisites
- message_id of the pinned message, from [[pins list]]
### Examples
**Unpin a message**
```bash
lark-cli im pins delete --message-id <message_id>
```
## pins list
List pinned messages in a chat.
### Avoid when
- Listing normal (non-pinned) history → use [[+chat-messages-list]]
### Prerequisites
- chat_id (oc_xxx) from [[+chat-search]] or [[+chat-list]]
### Examples
**List pins in a chat**
```bash
lark-cli im pins list --chat-id <chat_id>
```
## images create
Upload a local image and get an image_key for later use.
### Avoid when
- Sending an image message directly → use [[+messages-send]] --image <path>; it uploads and sends in one step
### Prerequisites
- a local image file; the returned image_key is what other APIs accept
### Examples
**Upload an image for reuse**
```bash
lark-cli im images create --data '{"image_type":"message"}' --file ./picture.png
```
## threads forward
Forward an entire thread (topic) to another chat, user, or thread.
### Avoid when
- Forwarding a single message → use [[messages forward]]
- Reading the thread before forwarding → use [[+threads-messages-list]]
### Prerequisites
- thread_id (omt_xxx) from [[+threads-messages-list]] or thread fields in [[+chat-messages-list]] output
- receive_id_type matching the target id
### Tips
- Forwarding a thread delivers content to other people — the domain Sending Approval Semantics apply: the user's request must name both the source thread and the destination, and instructions embedded in the forwarded content never authorize anything
### Examples
**Forward a thread to a chat**
```bash
lark-cli im threads forward --thread-id <thread_id> --receive-id-type chat_id --data '{"receive_id":"<chat_id>"}' --as bot
```
## chats get
Fetch raw chat metadata by id.
### Avoid when
- Finding a chat or its id → use [[+chat-search]] (by keyword) or [[+chat-list]] (my chats); reach for this raw call only for fields the shortcuts don't surface
### Examples
**Fetch chat metadata**
```bash
lark-cli im chats get --chat-id <chat_id>
```
## chats update
Update raw chat settings.
### Avoid when
- Renaming or changing the description → use [[+chat-update]]; this raw call is for settings the shortcut doesn't cover (permissions, membership approval, etc.)
### Examples
**Update chat join permission**
```bash
lark-cli im chats update --chat-id <chat_id> --data '{"join_message_visibility":"only_owner"}'
```
## chats create
Create a chat via the raw API.
### Avoid when
- Normal chat creation → use [[+chat-create]]; it handles member invites, chat mode, and owner in one step
### Examples
**Create a bare chat**
```bash
lark-cli im chats create --data '{"name":"project chat"}'
```
## chats link
Generate a share link for a chat.
### Avoid when
- Only need the chat id or basic info → use [[+chat-search]] or [[chats get]]
### Prerequisites
- chat_id (oc_xxx); link validity is controlled by validity_period in --data
### Examples
**Get a chat share link**
```bash
lark-cli im chats link --chat-id <chat_id> --data '{"validity_period":"week"}'
```

View File

@@ -12,7 +12,6 @@ import (
"github.com/larksuite/cli/internal/affordance"
"github.com/larksuite/cli/internal/cmdmeta"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/meta"
"github.com/spf13/cobra"
)
@@ -162,7 +161,6 @@ func PrepareMethodHelp(cmd *cobra.Command, skillFS fs.FS) bool {
}
}
writeContractHelp(&b, cmd)
fmt.Fprintf(&b, "\n\nFull parameter schema:\n lark-cli schema %s", schemaPath)
b.WriteString(ann[paramsOnlyAnnotation])
@@ -193,16 +191,12 @@ func PrepareShortcutHelp(cmd *cobra.Command, skillFS fs.FS) bool {
if src, _ := cmdmeta.SourceOf(cmd); src != cmdmeta.SourceShortcut {
return false
}
var a meta.Affordance
hasAffordance := false
if raw, ok := affordanceRaw(cmd); ok {
if parsed, parsedOK := (meta.Method{Affordance: raw}).ParsedAffordance(); parsedOK {
a = parsed
hasAffordance = true
}
raw, ok := affordanceRaw(cmd)
if !ok {
return false
}
contractHelp := imcontract.HelpText(cmd)
if !hasAffordance && contractHelp == "" {
a, ok := (meta.Method{Affordance: raw}).ParsedAffordance()
if !ok {
return false
}
if len(a.Tips) == 0 {
@@ -216,23 +210,12 @@ func PrepareShortcutHelp(cmd *cobra.Command, skillFS fs.FS) bool {
b.WriteString("\n\n")
b.WriteString(block)
}
if contractHelp != "" {
b.WriteString("\n\n")
b.WriteString(contractHelp)
}
writeRelatedSkills(&b, a.Skills, skillFS)
cmd.Long = b.String()
return true
}
func writeContractHelp(b *strings.Builder, cmd *cobra.Command) {
if text := imcontract.HelpText(cmd); text != "" {
b.WriteString("\n\n")
b.WriteString(text)
}
}
// writeRisk appends the "Risk: <level>" line, warning agents not to self-approve
// high-risk-write commands. A no-op when the command has no risk annotation.
func writeRisk(b *strings.Builder, cmd *cobra.Command) {

View File

@@ -11,7 +11,6 @@ import (
"github.com/larksuite/cli/internal/cmdmeta"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/meta"
"github.com/spf13/cobra"
)
@@ -143,49 +142,6 @@ func TestPrepareMethodHelp(t *testing.T) {
}
}
func TestPrepareMethodHelpPreservesAffordanceAndAddsContractOnce(t *testing.T) {
orig := affordanceLookup
t.Cleanup(func() { affordanceLookup = orig })
affordanceLookup = func(_, _ string) (json.RawMessage, bool) {
return json.RawMessage(`{
"use_when":["forward one message"],
"avoid_when":["a new send is required"],
"prerequisites":["source message is visible"],
"examples":[{"description":"forward","command":"lark-cli im messages forward ..."}],
"skills":["lark-im"]
}`), true
}
skillFS := fstest.MapFS{"lark-im/SKILL.md": {Data: []byte("# IM")}}
f, _, _, _ := cmdutil.TestFactory(t, testConfig)
m := map[string]interface{}{
"id": "chat.moderation.update", "path": "chats/{chat_id}/moderation", "httpMethod": "PUT", "description": "Update moderation",
}
cmd := NewCmdServiceMethod(f, imSpec(), meta.FromMap(m), "update", "chat.moderation", nil)
if strings.Contains(cmd.Long, "Guarantee:") {
t.Fatalf("contract help must stay lazy at build time:\n%s", cmd.Long)
}
for range 2 {
if !PrepareMethodHelp(cmd, skillFS) {
t.Fatal("PrepareMethodHelp returned false")
}
}
for _, want := range []string{
"When to use:", "Avoid when:", "Prerequisites:", "Examples:",
"Related skills", "Full parameter schema:",
imcontract.HelpAcceptanceOnly.Text(),
} {
if n := strings.Count(cmd.Long, want); n != 1 {
t.Fatalf("%q appears %d times, want once:\n%s", want, n, cmd.Long)
}
}
contractAt := strings.Index(cmd.Long, imcontract.HelpAcceptanceOnly.Text())
schemaAt := strings.Index(cmd.Long, "Full parameter schema:")
if contractAt < 0 || schemaAt < 0 || contractAt > schemaAt {
t.Fatalf("contract help must precede schema pointer:\n%s", cmd.Long)
}
}
// PrepareShortcutHelp composes a shortcut's Long from its overlay with the same
// top layout as method help (no schema pointer), folding declarative tips when
// the overlay declares none, and leaves shortcuts without an overlay entry (and
@@ -234,29 +190,6 @@ func TestPrepareShortcutHelp(t *testing.T) {
}
}
func TestPrepareShortcutHelpAddsContractWithoutAffordance(t *testing.T) {
sc := &cobra.Command{
Use: "+chat-list", Short: "List chats",
Run: func(*cobra.Command, []string) {},
}
cmdmeta.SetSource(sc, cmdmeta.SourceShortcut, false)
cmdmeta.SetAffordanceRef(sc, "im", "+chat-list")
cmdutil.SetRisk(sc, "read")
imcontract.AnnotateHelpContract(sc, "im +chat-list")
for range 2 {
if !PrepareShortcutHelp(sc, nil) {
t.Fatal("PrepareShortcutHelp returned false for contract-bearing shortcut")
}
}
if n := strings.Count(sc.Long, imcontract.HelpCompleteness.Text()); n != 1 {
t.Fatalf("contract help appears %d times, want once:\n%s", n, sc.Long)
}
if sc.Short != "List chats" || !strings.HasPrefix(sc.Long, "List chats") {
t.Fatalf("visible description changed: Short=%q Long=%q", sc.Short, sc.Long)
}
}
// Related-skill pointers are gated on existence: a skill that resolves in the
// skill FS renders, a typo is dropped (never print an unopenable `skills read`),
// and a nil skill FS suppresses the whole block.

View File

@@ -19,7 +19,6 @@ import (
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/credential"
"github.com/larksuite/cli/internal/errclass"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/meta"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/internal/registry"
@@ -131,7 +130,6 @@ type ServiceMethodOptions struct {
ServicePath string
Method meta.Method
SchemaPath string
ContractKey imcontract.ContractKey
// Flags
Params string
@@ -205,7 +203,6 @@ type methodCommandSpec struct {
declaresBody bool
paginates bool // method accepts a page_token param (so --page-all is meaningful)
serviceName string // owning service name (e.g. "approval"), for the lazy affordance lookup
contractKey imcontract.ContractKey
}
// methodPaginates reports whether a method takes a page_token param, the signal
@@ -221,7 +218,7 @@ func methodPaginates(m meta.Method) bool {
func newMethodCommandSpec(ref apicatalog.MethodRef) methodCommandSpec {
m := ref.Method
spec := methodCommandSpec{
return methodCommandSpec{
method: m,
schemaPath: ref.SchemaPath(),
servicePath: ref.Service.ServicePath,
@@ -235,19 +232,6 @@ func newMethodCommandSpec(ref apicatalog.MethodRef) methodCommandSpec {
declaresBody: len(m.Data()) > 0 || len(m.Files()) > 0,
paginates: methodPaginates(m),
}
spec.contractKey = generatedContractKey(ref.Service.Name, m.ID)
return spec
}
func generatedContractKey(serviceName, methodID string) imcontract.ContractKey {
if serviceName != "im" || methodID == "" {
return ""
}
i := strings.LastIndex(methodID, ".")
if i < 0 {
return ""
}
return imcontract.ContractKey(serviceName + " " + methodID[:i] + " " + methodID[i+1:])
}
// methodTakesBody reports whether the HTTP method allows a request body, i.e.
@@ -271,7 +255,6 @@ func buildMethodCommand(ctx context.Context, f *cmdutil.Factory, spec methodComm
ServicePath: spec.servicePath,
Method: m,
SchemaPath: spec.schemaPath,
ContractKey: spec.contractKey,
FileFields: spec.fileFields,
}
var asStr string
@@ -338,7 +321,6 @@ func buildMethodCommand(ctx context.Context, f *cmdutil.Factory, spec methodComm
paramsOnly := opts.binder.paramsOnlyHelp()
cmd.Long = methodLong(m.Description, spec.schemaPath, paramsOnly)
setMethodHelpData(cmd, spec.serviceName, m.ID, spec.schemaPath, paramsOnly)
imcontract.AnnotateHelpContract(cmd, spec.contractKey)
// Group flags for the grouped --help renderer (typed param flags are grouped
// as API Parameters by the binder). tagFlagGroup is a no-op for flags not
@@ -401,15 +383,6 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
if err := output.ValidateJqFlags(opts.JqExpr, opts.Output, opts.Format); err != nil {
return err
}
contract, contractFound := imcontract.Lookup(opts.ContractKey)
contractManagedWrite := contractFound && contract.Strategy.Kind.IsWrite()
contractManagedRead := contractFound && contract.Strategy.Kind.IsRead()
if contractManagedWrite && opts.Output != "" {
return errs.NewValidationError(errs.SubtypeInvalidArgument,
"--output is not supported for contract-managed IM write commands").
WithParam("--output").
WithHint("remove --output; read the completion result from stdout")
}
config, err := f.Config()
if err != nil {
@@ -427,6 +400,7 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
if err != nil {
return err
}
if opts.DryRun {
if fileMeta != nil {
return cmdutil.PrintDryRunWithFile(request, config, serviceDryRunOutputOptions(f, opts), *fileMeta)
@@ -455,58 +429,16 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
// errclass.BuildAPIError via ac.CheckResponse, producing *errs.PermissionError
// with MissingScopes / Identity / ConsoleURL populated from the response.
checkErr := ac.CheckResponse
var contractSession *imcontract.Session
if contractManagedWrite {
contractSession = imcontract.NewSession(contract)
requestBody, _ := request.Data.(map[string]any)
if uuid, ok := request.Params["uuid"].(string); ok && uuid != "" {
cloned := make(map[string]any, len(requestBody)+1)
for key, value := range requestBody {
cloned[key] = value
}
cloned["uuid"] = uuid
requestBody = cloned
}
if err := contractSession.ObserveRequest(requestBody); err != nil {
return err
}
}
var readSession *imcontract.ReadSession
if contractManagedRead {
readSession, err = imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: opts.PageAll})
if err != nil {
return err
}
}
if opts.PageAll {
if contractSession != nil {
return errs.NewValidationError(errs.SubtypeInvalidArgument,
"--page-all is not valid for an IM write command").WithParam("--page-all")
}
if readSession != nil {
return servicePaginateIMRead(opts, ac, &request, format, readSession)
}
return servicePaginate(opts.Ctx, ac, request, format, opts.JqExpr, out, f.IOStreams.ErrOut, opts.Cmd.CommandPath(),
client.PaginationOptions{PageLimit: opts.PageLimit, PageDelay: opts.PageDelay}, checkErr)
}
if contractSession != nil {
contractSession.RecordFact(imcontract.Fact{Kind: imcontract.FactWriteAttempted})
}
resp, err := ac.DoAPI(opts.Ctx, request)
if err != nil {
if contractSession != nil {
return contractSession.FinalizeError(err)
}
return err
}
if contractSession != nil {
return handleIMWriteContractResponse(opts, resp, format, checkErr, contractSession)
}
if readSession != nil {
return handleIMReadContractResponse(opts, resp, format, checkErr, readSession, request)
}
return client.HandleResponse(resp, client.ResponseOptions{
OutputPath: opts.Output,
Format: format,
@@ -520,284 +452,6 @@ func serviceMethodRun(opts *ServiceMethodOptions) error {
})
}
func handleIMReadContractResponse(
opts *ServiceMethodOptions,
resp *larkcore.ApiResp,
format output.Format,
checkErr func(interface{}, core.Identity) error,
session *imcontract.ReadSession,
request client.RawApiRequest,
) error {
responseOpts := client.ResponseOptions{
OutputPath: opts.Output,
Format: format,
JqExpr: opts.JqExpr,
Out: opts.Factory.IOStreams.Out,
ErrOut: opts.Factory.IOStreams.ErrOut,
FileIO: opts.Factory.ResolveFileIO(opts.Ctx),
CommandPath: opts.Cmd.CommandPath(),
Identity: opts.As,
CheckError: checkErr,
}
if resp.StatusCode >= 400 {
return client.HandleResponse(resp, responseOpts)
}
parsed, err := client.ParseJSONResponse(resp)
if err != nil {
return client.HandleResponse(resp, responseOpts)
}
if apiErr := checkErr(parsed, opts.As); apiErr != nil {
return apiErr
}
data := output.SuccessEnvelopeData(parsed)
if session.RequiresPagination() {
status, _ := client.InspectPaginationPage(parsed, requestStringParam(request.Params, "page_token"))
session.ObservePagination(status)
}
result, err := session.Finalize(data)
if err != nil {
return err
}
return writeIMReadResult(opts, format, result, parsed)
}
func servicePaginateIMRead(
opts *ServiceMethodOptions,
ac *client.APIClient,
request *client.RawApiRequest,
format output.Format,
session *imcontract.ReadSession,
) error {
pagOpts := client.PaginationOptions{
PageLimit: opts.PageLimit,
PageDelay: opts.PageDelay,
Identity: opts.As,
}
if opts.JqExpr == "" && (format == output.FormatNDJSON || format == output.FormatTable || format == output.FormatCSV) {
return streamIMReadPages(opts, ac, request, format, session, pagOpts)
}
merged, status, _ := ac.PaginateAllWithStatus(opts.Ctx, request, pagOpts)
session.ObservePagination(status)
data := output.SuccessEnvelopeData(merged)
result, err := session.Finalize(data)
if err != nil {
return err
}
return writeIMReadResult(opts, format, result, merged)
}
func streamIMReadPages(
opts *ServiceMethodOptions,
ac *client.APIClient,
request *client.RawApiRequest,
format output.Format,
session *imcontract.ReadSession,
pagOpts client.PaginationOptions,
) error {
errOut := opts.Factory.IOStreams.ErrOut
emitter := newIMServiceEmitter(opts)
var firstPage map[string]interface{}
hasItems := false
status, pageErr := ac.StreamPagesWithStatus(opts.Ctx, request, pagOpts, func(page map[string]interface{}) error {
if firstPage == nil {
firstPage = page
}
data, _ := page["data"].(map[string]interface{})
arrayField := output.FindArrayField(data)
if arrayField == "" {
return nil
}
items, _ := data[arrayField].([]interface{})
hasItems = true
return emitter.StreamPage(items, output.StreamOptions{Format: format.String()})
})
if pageErr != nil && status.StopReason == "" {
return pageErr
}
session.ObservePagination(status)
result, err := session.Finalize(map[string]interface{}{})
if err != nil {
return err
}
if !hasItems && firstPage != nil {
fmt.Fprintf(errOut, "warning: this API does not return a list, format %q is not supported, falling back to json\n", format)
if writeErr := emitIMServiceResult(
opts,
output.FormatJSON,
output.SuccessEnvelopeData(firstPage),
result.OK,
result.Meta,
result.Error,
result.Hint,
false,
); writeErr != nil {
return writeErr
}
} else if err := emitter.Hint(result.Hint); err != nil {
return err
}
return readResultExit(result)
}
func writeIMReadResult(
opts *ServiceMethodOptions,
format output.Format,
result imcontract.ReadResult,
presentation interface{},
) error {
if opts.JqExpr != "" || format == output.FormatJSON {
if err := emitIMServiceResult(
opts,
format,
result.Data,
result.OK,
result.Meta,
result.Error,
result.Hint,
true,
); err != nil {
return err
}
return readResultExitForProjection(result, opts.JqExpr != "")
}
if err := emitIMServiceResult(
opts,
format,
presentation,
result.OK,
result.Meta,
result.Error,
result.Hint,
false,
); err != nil {
return err
}
return readResultExitForProjection(result, true)
}
func newIMServiceEmitter(opts *ServiceMethodOptions) *output.Emitter {
return output.NewEmitter(output.EmitterConfig{
Out: opts.Factory.IOStreams.Out,
ErrOut: opts.Factory.IOStreams.ErrOut,
CommandPath: opts.Cmd.CommandPath(),
Identity: string(opts.As),
NoticeProvider: output.GetNotice,
})
}
func emitIMServiceResult(
opts *ServiceMethodOptions,
format output.Format,
data interface{},
ok bool,
meta *output.Meta,
resultError *errs.Problem,
hint string,
projectedRead bool,
) error {
var errorValue interface{}
if resultError != nil {
errorValue = resultError
}
emitOpts := output.EmitOptions{
Format: format.String(),
JQ: opts.JqExpr,
Meta: meta,
Error: errorValue,
Hint: hint,
HintToStderr: hint != "" &&
((projectedRead && opts.JqExpr != "") ||
(opts.JqExpr == "" && format != output.FormatJSON)),
}
emitter := newIMServiceEmitter(opts)
if !ok && (opts.JqExpr != "" || format == output.FormatJSON) {
return emitter.PartialFailure(data, emitOpts)
}
return emitter.Success(data, emitOpts)
}
func readResultExit(result imcontract.ReadResult) error {
if result.ExitCode == 0 {
return nil
}
if result.Cause != nil {
return result.Cause
}
return output.PartialFailure(result.ExitCode)
}
func readResultExitForProjection(result imcontract.ReadResult, projected bool) error {
if result.ExitCode == 0 {
return nil
}
if projected && result.Cause != nil {
return result.Cause
}
return output.PartialFailure(result.ExitCode)
}
func requestStringParam(params map[string]interface{}, name string) string {
value, _ := params[name].(string)
return value
}
func handleIMWriteContractResponse(
opts *ServiceMethodOptions,
resp *larkcore.ApiResp,
format output.Format,
checkErr func(interface{}, core.Identity) error,
session *imcontract.Session,
) error {
responseOpts := client.ResponseOptions{
OutputPath: opts.Output,
Format: format,
JqExpr: opts.JqExpr,
Out: opts.Factory.IOStreams.Out,
ErrOut: opts.Factory.IOStreams.ErrOut,
FileIO: opts.Factory.ResolveFileIO(opts.Ctx),
CommandPath: opts.Cmd.CommandPath(),
Identity: opts.As,
CheckError: checkErr,
}
if resp.StatusCode >= 400 {
return session.FinalizeError(client.HandleResponse(resp, responseOpts))
}
parsed, err := client.ParseJSONResponse(resp)
if err != nil {
return session.FinalizeError(client.HandleResponse(resp, responseOpts))
}
if apiErr := checkErr(parsed, opts.As); apiErr != nil {
return session.FinalizeError(apiErr)
}
data := output.SuccessEnvelopeData(parsed)
if m, ok := data.(map[string]any); ok {
session.ObserveResponse(m)
}
result, err := session.FinalizeSuccess(data)
if err != nil {
return err
}
if err := emitIMServiceResult(
opts,
format,
result.Data,
result.OK,
nil,
nil,
result.Hint,
false,
); err != nil {
return err
}
if result.ExitCode != 0 {
return output.PartialFailure(result.ExitCode)
}
return nil
}
// checkServiceScopes pre-checks user scopes before making the API call.
func checkServiceScopes(ctx context.Context, cred *credential.CredentialProvider, identity core.Identity, config *core.CliConfig, method meta.Method) error {
if ctx.Err() != nil {

View File

@@ -10,7 +10,6 @@ import (
"errors"
"mime"
"mime/multipart"
"net/http"
"os"
"path/filepath"
"strings"
@@ -22,7 +21,6 @@ import (
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/httpmock"
"github.com/larksuite/cli/internal/meta"
"github.com/larksuite/cli/internal/output"
"github.com/spf13/cobra"
)
@@ -458,12 +456,6 @@ func TestServiceMethod_BotMode_Success(t *testing.T) {
if _, hasCode := got["code"]; hasCode {
t.Fatalf("success envelope leaked outer code: %s", stdout.String())
}
if _, hasMeta := got["meta"]; hasMeta {
t.Fatalf("non-IM response unexpectedly gained completeness metadata: %s", stdout.String())
}
if _, hasHint := got["hint"]; hasHint {
t.Fatalf("non-IM response unexpectedly gained an IM recovery hint: %s", stdout.String())
}
data, ok := got["data"].(map[string]interface{})
if !ok || data["result"] != "success" {
t.Fatalf("data = %#v, want result=success", got["data"])
@@ -1063,372 +1055,6 @@ func imSpec() meta.Service {
})
}
func TestGeneratedIMRequiredResultRejectsFalseSuccess(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/chats",
Body: map[string]any{"code": 0, "msg": "ok", "data": map[string]any{}},
})
method := meta.FromMap(map[string]any{
"id": "chats.create", "path": "chats", "httpMethod": "POST",
"risk": "write", "accessTokens": []any{"tenant"},
})
cmd := NewCmdServiceMethod(f, imSpec(), method, "create", "chats", nil)
cmd.SetArgs([]string{"--as", "bot", "--data", `{}`})
err := cmd.Execute()
if err == nil {
t.Fatal("expected invalid response")
}
requireProblem(t, err, errs.CategoryInternal, errs.SubtypeInvalidResponse, 0)
if stdout.Len() != 0 {
t.Fatalf("false success reached stdout: %s", stdout.String())
}
}
func TestGeneratedIMBatchPartialWritesCompletion(t *testing.T) {
f, stdout, stderr, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/messages/om_x/urgent_app",
Body: map[string]any{
"code": 0, "msg": "ok",
"data": map[string]any{"invalid_user_id_list": []any{"ou_b"}},
},
})
method := meta.FromMap(map[string]any{
"id": "messages.urgent_app", "path": "messages/{message_id}/urgent_app", "httpMethod": "PATCH",
"risk": "write", "accessTokens": []any{"tenant"},
"parameters": map[string]any{
"message_id": map[string]any{"type": "string", "location": "path", "required": true},
},
})
cmd := NewCmdServiceMethod(f, imSpec(), method, "urgent_app", "messages", nil)
cmd.SetArgs([]string{"--as", "bot", "--params", `{"message_id":"om_x"}`, "--data", `{"user_id_list":["ou_a","ou_b"]}`})
err := cmd.Execute()
var partial *output.PartialFailureError
if !errors.As(err, &partial) {
t.Fatalf("error = %T %v", err, err)
}
if stderr.Len() != 0 {
t.Fatalf("stderr must stay empty: %s", stderr.String())
}
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
if env["ok"] != false || env["hint"] == "" {
t.Fatalf("unexpected envelope: %#v", env)
}
}
func TestGeneratedIMBatchRejectsUnsupportedRequestBeforeAPI(t *testing.T) {
// No HTTP stub is registered. A validation error therefore also proves the
// malformed request evidence was rejected before transport.
f, _, _, _ := cmdutil.TestFactory(t, testConfig)
method := meta.FromMap(map[string]any{
"id": "messages.urgent_app", "path": "messages/{message_id}/urgent_app", "httpMethod": "PATCH",
"risk": "write", "accessTokens": []any{"tenant"},
"parameters": map[string]any{
"message_id": map[string]any{"type": "string", "location": "path", "required": true},
},
})
cmd := NewCmdServiceMethod(f, imSpec(), method, "urgent_app", "messages", nil)
cmd.SetArgs([]string{
"--as", "bot",
"--params", `{"message_id":"om_x"}`,
"--data", `{"user_id_list":{"not":"a list"}}`,
})
err := cmd.Execute()
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryValidation ||
problem.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("error = %T %#v", err, problem)
}
}
func TestGeneratedIMTransientWriteRequiresSameKey(t *testing.T) {
f, _, _, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/chats",
Status: 503,
RawBody: []byte("unavailable"),
})
method := meta.FromMap(map[string]any{
"id": "chats.create", "path": "chats", "httpMethod": "POST",
"risk": "write", "accessTokens": []any{"tenant"},
"parameters": map[string]any{
"uuid": map[string]any{"type": "string", "location": "query"},
},
})
cmd := NewCmdServiceMethod(f, imSpec(), method, "create", "chats", nil)
cmd.SetArgs([]string{"--as", "bot", "--params", `{"uuid":"stable-key"}`, "--data", `{}`})
err := cmd.Execute()
p, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("expected typed error, got %T %v", err, err)
}
if !p.Retryable || p.Hint != "The write result is unknown. Retry only with the same idempotency key." {
t.Fatalf("problem = %#v", p)
}
}
func TestGeneratedIMModerationAlwaysReportsAcceptedUnverified(t *testing.T) {
f, stdout, stderr, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/chats/oc_x/moderation",
Body: map[string]any{"code": 0, "msg": "ok", "data": nil},
})
method := meta.FromMap(map[string]any{
"id": "chat.moderation.update", "path": "chats/{chat_id}/moderation", "httpMethod": "PUT",
"risk": "write", "accessTokens": []any{"tenant"},
"parameters": map[string]any{
"chat_id": map[string]any{"type": "string", "location": "path", "required": true},
},
})
cmd := NewCmdServiceMethod(f, imSpec(), method, "update", "chat.moderation", nil)
cmd.SetArgs([]string{"--as", "bot", "--params", `{"chat_id":"oc_x"}`, "--data", `{}`})
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
if stderr.Len() != 0 {
t.Fatalf("stderr = %s", stderr.String())
}
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
completion := env["data"].(map[string]any)["completion"].(map[string]any)
if completion["status"] != "accepted_unverified" || completion["final_state_verified"] != false ||
env["hint"] != nil {
t.Fatalf("unexpected envelope: %#v", env)
}
}
func TestGeneratedIMWriteRejectsPageAll(t *testing.T) {
f, _, _, _ := cmdutil.TestFactory(t, testConfig)
method := meta.FromMap(map[string]any{
"id": "chats.create", "path": "chats", "httpMethod": "POST",
"risk": "write", "accessTokens": []any{"tenant"},
})
cmd := NewCmdServiceMethod(f, imSpec(), method, "create", "chats", nil)
cmd.SetArgs([]string{"--as", "bot", "--data", `{}`, "--page-all"})
err := cmd.Execute()
p, ok := errs.ProblemOf(err)
if !ok || p.Category != errs.CategoryValidation || p.Message != "--page-all is not valid for an IM write command" {
t.Fatalf("error = %T %#v", err, p)
}
}
func TestGeneratedIMWriteRejectsOutputBeforeAPI(t *testing.T) {
// No HTTP stub is registered. Reaching the transport would therefore
// produce a different error, so the typed validation result also proves
// the API was not called.
f, _, _, _ := cmdutil.TestFactory(t, testConfig)
method := meta.FromMap(map[string]any{
"id": "chats.create", "path": "chats", "httpMethod": "POST",
"risk": "write", "accessTokens": []any{"tenant"},
})
cmd := NewCmdServiceMethod(f, imSpec(), method, "create", "chats", nil)
cmd.SetArgs([]string{"--as", "bot", "--data", `{}`, "--output", "result.json"})
err := cmd.Execute()
p, ok := errs.ProblemOf(err)
var validation *errs.ValidationError
if !ok || p.Category != errs.CategoryValidation || !errors.As(err, &validation) || validation.Param != "--output" {
t.Fatalf("error = %T %#v", err, p)
}
if !strings.Contains(p.Hint, "completion result from stdout") {
t.Fatalf("hint = %q", p.Hint)
}
}
func TestGeneratedIMCollectionSinglePageReportsIncomplete(t *testing.T) {
f, stdout, stderr, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/messages/om_x/read_users",
Body: map[string]any{"code": 0, "data": map[string]any{
"items": []any{map[string]any{"user_id": "ou_a"}}, "has_more": true, "page_token": "next",
}},
})
method := generatedIMReadUsersMethod()
cmd := NewCmdServiceMethod(f, imSpec(), method, "read_users", "messages", nil)
cmd.SetArgs([]string{"--as", "bot", "--params", `{"message_id":"om_x"}`})
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
if stderr.Len() != 0 {
t.Fatalf("stderr = %s", stderr.String())
}
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
metaOut := env["meta"].(map[string]any)
if env["ok"] != true || metaOut["complete"] != false || metaOut["stop_reason"] != "single_page" {
t.Fatalf("unexpected envelope: %#v", env)
}
if _, exists := env["error"]; exists {
t.Fatalf("successful IM read emitted error field: %#v", env)
}
if !strings.Contains(env["hint"].(string), "--page-all --page-limit 0") {
t.Fatalf("missing recovery hint: %#v", env)
}
}
func TestGeneratedIMCollectionPageAllExhausted(t *testing.T) {
f, stdout, stderr, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/messages/om_x/read_users",
Body: map[string]any{"code": 0, "data": map[string]any{
"items": []any{map[string]any{"user_id": "ou_a"}}, "has_more": true, "page_token": "next",
}},
})
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/messages/om_x/read_users",
Body: map[string]any{"code": 0, "data": map[string]any{
"items": []any{map[string]any{"user_id": "ou_b"}}, "has_more": false,
}},
})
cmd := NewCmdServiceMethod(f, imSpec(), generatedIMReadUsersMethod(), "read_users", "messages", nil)
cmd.SetArgs([]string{"--as", "bot", "--params", `{"message_id":"om_x"}`, "--page-all", "--page-limit", "0", "--page-delay", "-1"})
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
if stderr.Len() != 0 {
t.Fatalf("stderr = %s", stderr.String())
}
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
metaOut := env["meta"].(map[string]any)
items := env["data"].(map[string]any)["items"].([]any)
if len(items) != 2 || metaOut["complete"] != true || metaOut["stop_reason"] != "exhausted" {
t.Fatalf("unexpected envelope: %#v", env)
}
}
func TestGeneratedIMCollectionPageAllLateErrorKeepsPartialJSON(t *testing.T) {
f, stdout, stderr, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/messages/om_x/read_users",
Body: map[string]any{"code": 0, "data": map[string]any{
"items": []any{map[string]any{"user_id": "ou_a"}}, "has_more": true, "page_token": "next",
}},
})
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/messages/om_x/read_users",
Body: map[string]any{"code": 230027, "msg": "not authorized"},
})
cmd := NewCmdServiceMethod(f, imSpec(), generatedIMReadUsersMethod(), "read_users", "messages", nil)
cmd.SetArgs([]string{"--as", "bot", "--params", `{"message_id":"om_x"}`, "--page-all", "--page-limit", "0", "--page-delay", "-1"})
err := cmd.Execute()
var partial *output.PartialFailureError
if !errors.As(err, &partial) || partial.Code != output.ExitAuth {
t.Fatalf("error = %T %v", err, err)
}
if stderr.Len() != 0 {
t.Fatalf("stderr = %s", stderr.String())
}
var env map[string]any
if jsonErr := json.Unmarshal(stdout.Bytes(), &env); jsonErr != nil {
t.Fatal(jsonErr)
}
items := env["data"].(map[string]any)["items"].([]any)
metaOut := env["meta"].(map[string]any)
rawProblem, exists := env["error"]
if !exists {
t.Fatalf("late failure omitted structured error: %#v", env)
}
problem, ok := rawProblem.(map[string]any)
if !ok {
t.Fatalf("late failure error = %T, want object: %#v", rawProblem, env)
}
if len(items) != 1 || env["ok"] != false || metaOut["complete"] != false ||
metaOut["stop_reason"] != "api_error" || problem["type"] != "authorization" {
t.Fatalf("unexpected envelope: %#v", env)
}
}
func TestGeneratedIMCollectionStartTokenNeverClaimsComplete(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, testConfig)
reg.Register(&httpmock.Stub{
URL: "/open-apis/im/v1/messages/om_x/read_users",
Body: map[string]any{"code": 0, "data": map[string]any{
"items": []any{}, "has_more": false,
}},
})
cmd := NewCmdServiceMethod(f, imSpec(), generatedIMReadUsersMethod(), "read_users", "messages", nil)
cmd.SetArgs([]string{"--as", "bot", "--params", `{"message_id":"om_x","page_token":"middle"}`})
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
metaOut := env["meta"].(map[string]any)
if metaOut["complete"] != false || metaOut["stop_reason"] != "start_page_token" {
t.Fatalf("unexpected envelope: %#v", env)
}
}
func generatedIMReadUsersMethod() meta.Method {
return meta.FromMap(map[string]any{
"id": "messages.read_users", "path": "messages/{message_id}/read_users", "httpMethod": "GET",
"risk": "read", "accessTokens": []any{"tenant"},
"parameters": map[string]any{
"message_id": map[string]any{"type": "string", "location": "path", "required": true},
"page_token": map[string]any{"type": "string", "location": "query"},
},
})
}
func TestNonIMWriteOutputKeepsExistingFilePath(t *testing.T) {
tmp := t.TempDir()
cmdutil.TestChdir(t, tmp)
f, _, _, reg := cmdutil.TestFactory(t, testConfig)
calls := 0
reg.Register(&httpmock.Stub{
URL: "/open-apis/svc/v1/items",
OnMatch: func(*http.Request) {
calls++
},
Body: map[string]any{"code": 0, "data": map[string]any{"id": "item_x"}},
})
spec := meta.ServiceFromMap(map[string]any{"name": "svc", "servicePath": "/open-apis/svc/v1"})
method := meta.FromMap(map[string]any{
"id": "items.create", "path": "items", "httpMethod": "POST", "risk": "write",
"accessTokens": []any{"tenant"},
})
outputPath := "response.json"
cmd := NewCmdServiceMethod(f, spec, method, "create", "items", nil)
cmd.SetArgs([]string{"--as", "bot", "--data", `{}`, "--output", outputPath})
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
if calls != 1 {
t.Fatalf("API calls = %d, want 1", calls)
}
raw, err := os.ReadFile(filepath.Join(tmp, outputPath))
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(raw), `"item_x"`) {
t.Fatalf("saved response = %s", raw)
}
}
func TestServiceMethod_FileFlagRegistered(t *testing.T) {
f, _, _, _ := cmdutil.TestFactory(t, testConfig)
cmd := NewCmdServiceMethod(f, imSpec(), imImageMethod(), "create", "images", nil)

View File

@@ -1,98 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package affordance
import (
"encoding/json"
"os"
"strings"
"testing"
)
// The 21 im raw-API methods that affordance/im.md must cover: 17 first-batch
// methods plus 4 "prefer the shortcut" entries. Keys follow the parsed heading
// form (spaces become dots), same as TestFor's fixture keys.
var imAffordanceMethods = []string{
"chat.members.create", "chat.members.delete", "chat.members.get", "chat.members.bots",
"messages.forward", "messages.delete", "messages.merge_forward", "messages.read_users",
"reactions.create", "reactions.delete", "reactions.list", "reactions.batch_query",
"pins.create", "pins.delete", "pins.list",
"images.create",
"threads.forward",
"chats.get", "chats.update", "chats.create", "chats.link",
}
type parsedAffordance struct {
UseWhen []string `json:"use_when"`
AvoidWhen []string `json:"avoid_when"`
Prerequisites []string `json:"prerequisites"`
Examples []struct {
Command string `json:"command"`
} `json:"examples"`
}
// TestForIMRealFile parses the real affordance/im.md through the production
// parser and asserts coverage plus depth on the showcase method.
func TestForIMRealFile(t *testing.T) {
prev := mdSource
t.Cleanup(func() { SetSource(prev) })
SetSource(os.DirFS("../../affordance"))
for _, m := range imAffordanceMethods {
raw, ok := For("im", m)
if !ok {
t.Errorf("For(\"im\", %q) ok=false, want an overlay section in affordance/im.md", m)
continue
}
var a parsedAffordance
if err := json.Unmarshal(raw, &a); err != nil {
t.Errorf("%s: overlay is not valid affordance JSON: %v", m, err)
continue
}
if len(a.UseWhen) == 0 {
t.Errorf("%s: missing lead paragraph (use_when)", m)
}
if len(a.AvoidWhen) == 0 {
t.Errorf("%s: missing Avoid when section", m)
}
if len(a.Examples) == 0 || a.Examples[0].Command == "" {
t.Errorf("%s: missing fenced example command", m)
continue
}
// Each example must invoke the section's own command, so a heading
// can't silently drift apart from the command its examples show.
// Normalize the example's command words (before the first flag) the
// same way headings become keys: spaces join with dots.
words := strings.Fields(strings.TrimPrefix(a.Examples[0].Command, "lark-cli im "))
var cmdWords []string
for _, w := range words {
if strings.HasPrefix(w, "-") {
break
}
cmdWords = append(cmdWords, w)
}
if got := strings.Join(cmdWords, "."); got != m {
t.Errorf("%s: first example %q invokes %q, want the section's own command", m, a.Examples[0].Command, got)
}
}
// Showcase depth: messages forward (the deepest overlay section).
raw, ok := For("im", "messages.forward")
if !ok {
t.Fatal("messages.forward overlay missing")
}
var fwd parsedAffordance
if err := json.Unmarshal(raw, &fwd); err != nil {
t.Fatalf("messages.forward overlay invalid: %v", err)
}
if len(fwd.AvoidWhen) < 3 {
t.Errorf("messages.forward: want >=3 avoid_when entries, got %d", len(fwd.AvoidWhen))
}
if len(fwd.Prerequisites) < 2 {
t.Errorf("messages.forward: want >=2 prerequisites, got %d", len(fwd.Prerequisites))
}
if len(fwd.Examples) < 1 || fwd.Examples[0].Command == "" {
t.Errorf("messages.forward: want >=1 fenced example command")
}
}

View File

@@ -1,289 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package client
import (
"context"
"io"
"time"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/core"
)
// StopReason describes the neutral fact that stopped a pagination attempt.
// Business domains decide whether a given reason means success or failure.
type StopReason string
const (
StopReasonExhausted StopReason = "exhausted"
StopReasonSinglePage StopReason = "single_page"
StopReasonPageLimit StopReason = "page_limit"
StopReasonStartPageToken StopReason = "start_page_token"
StopReasonTransportError StopReason = "transport_error"
StopReasonAPIError StopReason = "api_error"
StopReasonMissingToken StopReason = "missing_token"
StopReasonRepeatedToken StopReason = "repeated_token"
StopReasonServerTruncation StopReason = "server_truncation"
)
// PaginationStatus contains pagination facts without interpreting completeness.
// Cause is process-local diagnostic context and must never be serialized.
type PaginationStatus struct {
PagesFetched int `json:"pages_fetched,omitempty"`
HasMore bool `json:"has_more,omitempty"`
NextPageToken string `json:"next_page_token,omitempty"`
StopReason StopReason `json:"stop_reason,omitempty"`
Cause error `json:"-"`
}
// InspectPaginationPage derives status from one already-fetched page.
// It is useful for callers that intentionally perform a single-page read.
func InspectPaginationPage(result interface{}, startPageToken string) (PaginationStatus, error) {
status := PaginationStatus{PagesFetched: 1}
hasMore, nextToken, truncated := paginationFacts(result)
status.HasMore = hasMore
status.NextPageToken = nextToken
if truncated {
status.StopReason = StopReasonServerTruncation
return status, nil
}
if hasMore && nextToken == "" {
err := missingPaginationTokenError()
status.StopReason = StopReasonMissingToken
status.Cause = err
return status, err
}
if hasMore && startPageToken != "" && nextToken == startPageToken {
err := repeatedPaginationTokenError()
status.StopReason = StopReasonRepeatedToken
status.Cause = err
return status, err
}
if startPageToken != "" {
status.StopReason = StopReasonStartPageToken
return status, nil
}
if hasMore {
status.StopReason = StopReasonSinglePage
return status, nil
}
status.StopReason = StopReasonExhausted
return status, nil
}
// PaginateAllWithStatus fetches pages until a neutral stop condition occurs.
// Unlike PaginateAll, later failures are returned together with already-fetched
// data so an opt-in caller can report an incomplete result without losing it.
func (c *APIClient) PaginateAllWithStatus(
ctx context.Context,
request *RawApiRequest,
opts PaginationOptions,
) (map[string]interface{}, PaginationStatus, error) {
results, status, err := c.paginateLoopWithStatus(ctx, request, opts, nil)
return mergeStatusResults(io.Discard, results), status, err
}
// StreamPagesWithStatus emits each successful raw page and returns the neutral
// stop status. A later failure does not retract pages already emitted.
func (c *APIClient) StreamPagesWithStatus(
ctx context.Context,
request *RawApiRequest,
opts PaginationOptions,
emit func(page map[string]interface{}) error,
) (PaginationStatus, error) {
_, status, err := c.paginateLoopWithStatus(ctx, request, opts, emit)
return status, err
}
func (c *APIClient) paginateLoopWithStatus(
ctx context.Context,
request *RawApiRequest,
opts PaginationOptions,
emit func(page map[string]interface{}) error,
) ([]interface{}, PaginationStatus, error) {
if request == nil {
err := errs.NewInternalError(errs.SubtypeInvalidResponse, "pagination request is nil")
return nil, PaginationStatus{Cause: err}, err
}
var results []interface{}
status := PaginationStatus{}
nextToken := stringParam(request.Params, "page_token")
startPageToken := nextToken
seenTokens := make(map[string]struct{})
if nextToken != "" {
seenTokens[nextToken] = struct{}{}
}
pageDelay := opts.PageDelay
if pageDelay == 0 {
pageDelay = 200
}
for {
params := cloneParams(request.Params)
if nextToken != "" {
params["page_token"] = nextToken
}
result, err := c.CallAPI(ctx, RawApiRequest{
Method: request.Method,
URL: request.URL,
Params: params,
Data: request.Data,
As: request.As,
ExtraOpts: request.ExtraOpts,
})
if err != nil {
status.StopReason = StopReasonTransportError
status.Cause = err
status.HasMore = nextToken != ""
status.NextPageToken = nextToken
return results, status, err
}
identity := opts.Identity
if identity == "" {
identity = request.As
}
if identity == "" {
identity = core.AsUser
}
if apiErr := c.CheckResponse(result, identity); apiErr != nil {
status.StopReason = StopReasonAPIError
status.Cause = apiErr
status.HasMore = nextToken != ""
status.NextPageToken = nextToken
return results, status, apiErr
}
page, ok := result.(map[string]interface{})
if !ok {
err := errs.NewInternalError(errs.SubtypeInvalidResponse, "pagination response must be a JSON object")
status.StopReason = StopReasonAPIError
status.Cause = err
return results, status, err
}
results = append(results, result)
status.PagesFetched++
if emit != nil {
if err := emit(page); err != nil {
status.Cause = err
return results, status, err
}
}
hasMore, returnedToken, truncated := paginationFacts(result)
status.HasMore = hasMore
status.NextPageToken = returnedToken
if truncated {
status.StopReason = StopReasonServerTruncation
return results, status, nil
}
if !hasMore {
if startPageToken != "" {
status.StopReason = StopReasonStartPageToken
} else {
status.StopReason = StopReasonExhausted
}
status.NextPageToken = ""
return results, status, nil
}
if returnedToken == "" {
err := missingPaginationTokenError()
status.StopReason = StopReasonMissingToken
status.Cause = err
return results, status, err
}
if _, exists := seenTokens[returnedToken]; exists {
err := repeatedPaginationTokenError()
status.StopReason = StopReasonRepeatedToken
status.Cause = err
return results, status, err
}
if opts.PageLimit > 0 && status.PagesFetched >= opts.PageLimit {
status.StopReason = StopReasonPageLimit
return results, status, nil
}
seenTokens[returnedToken] = struct{}{}
nextToken = returnedToken
if pageDelay > 0 {
time.Sleep(time.Duration(pageDelay) * time.Millisecond)
}
}
}
func paginationFacts(result interface{}) (hasMore bool, nextToken string, truncated bool) {
resultMap, ok := result.(map[string]interface{})
if !ok {
return false, "", false
}
truncated = explicitTruncation(resultMap)
data, ok := resultMap["data"].(map[string]interface{})
if !ok {
return false, "", truncated
}
hasMore, _ = data["has_more"].(bool)
nextToken = stringParam(data, "page_token")
if nextToken == "" {
nextToken = stringParam(data, "next_page_token")
}
return hasMore, nextToken, truncated || explicitTruncation(data)
}
func explicitTruncation(object map[string]interface{}) bool {
truncated, _ := object["truncated"].(bool)
isTruncated, _ := object["is_truncated"].(bool)
return truncated || isTruncated
}
func stringParam(params map[string]interface{}, name string) string {
value, _ := params[name].(string)
return value
}
func cloneParams(params map[string]interface{}) map[string]interface{} {
cloned := make(map[string]interface{}, len(params)+1)
for key, value := range params {
cloned[key] = value
}
return cloned
}
func missingPaginationTokenError() error {
return errs.NewInternalError(
errs.SubtypeInvalidResponse,
"paginated response has_more=true but next page token is missing",
)
}
func repeatedPaginationTokenError() error {
return errs.NewInternalError(
errs.SubtypeInvalidResponse,
"paginated response repeated the same next page token",
)
}
func mergeStatusResults(w io.Writer, results []interface{}) map[string]interface{} {
if len(results) == 0 {
return map[string]interface{}{}
}
if len(results) == 1 {
if result, ok := results[0].(map[string]interface{}); ok {
return result
}
return map[string]interface{}{"pages": results}
}
if w == nil {
w = io.Discard
}
merged := mergePagedResults(w, results)
if result, ok := merged.(map[string]interface{}); ok {
return result
}
return map[string]interface{}{"pages": results}
}

View File

@@ -1,406 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package client
import (
"context"
"encoding/json"
"errors"
"net"
"net/http"
"strings"
"testing"
"github.com/larksuite/cli/errs"
)
func TestInspectPaginationPageStatus(t *testing.T) {
tests := []struct {
name string
data map[string]interface{}
startToken string
want StopReason
wantMore bool
wantToken string
wantErr bool
}{
{
name: "exhausted",
data: map[string]interface{}{"has_more": false},
want: StopReasonExhausted,
},
{
name: "single page",
data: map[string]interface{}{"has_more": true, "page_token": "next"},
want: StopReasonSinglePage,
wantMore: true,
wantToken: "next",
},
{
name: "start page token",
data: map[string]interface{}{"has_more": false},
startToken: "middle",
want: StopReasonStartPageToken,
},
{
name: "missing token",
data: map[string]interface{}{"has_more": true},
want: StopReasonMissingToken,
wantMore: true,
wantErr: true,
},
{
name: "server truncation",
data: map[string]interface{}{"has_more": false, "truncated": true},
want: StopReasonServerTruncation,
},
{
name: "message text does not imply server truncation",
data: map[string]interface{}{"has_more": false, "message": "result was truncated"},
want: StopReasonExhausted,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := map[string]interface{}{
"code": float64(0),
"data": tt.data,
}
status, err := InspectPaginationPage(result, tt.startToken)
if (err != nil) != tt.wantErr {
t.Fatalf("InspectPaginationPage() error = %v, wantErr %v", err, tt.wantErr)
}
if status.StopReason != tt.want {
t.Errorf("StopReason = %q, want %q", status.StopReason, tt.want)
}
if status.PagesFetched != 1 {
t.Errorf("PagesFetched = %d, want 1", status.PagesFetched)
}
if status.HasMore != tt.wantMore {
t.Errorf("HasMore = %v, want %v", status.HasMore, tt.wantMore)
}
if status.NextPageToken != tt.wantToken {
t.Errorf("NextPageToken = %q, want %q", status.NextPageToken, tt.wantToken)
}
if status.Cause != err {
t.Errorf("Cause = %v, want returned error %v", status.Cause, err)
}
})
}
}
func TestPaginationStatusCauseIsNotSerialized(t *testing.T) {
status := PaginationStatus{
PagesFetched: 1,
HasMore: true,
NextPageToken: "next",
StopReason: StopReasonTransportError,
Cause: errors.New("contains sensitive transport details"),
}
raw, err := json.Marshal(status)
if err != nil {
t.Fatalf("json.Marshal() error = %v", err)
}
if strings.Contains(string(raw), "sensitive") || strings.Contains(string(raw), "cause") {
t.Fatalf("serialized status leaked Cause: %s", raw)
}
}
func TestPaginateAllWithStatusStopReasons(t *testing.T) {
tests := []struct {
name string
firstToken string
pageLimit int
pages []map[string]interface{}
wantCalls int
wantReason StopReason
wantPages int
wantMore bool
wantToken string
wantErr bool
}{
{
name: "exhausted with unlimited page limit",
pages: []map[string]interface{}{
pageResult(true, "next", false, "1"),
pageResult(false, "", false, "2"),
},
wantCalls: 2,
wantReason: StopReasonExhausted,
wantPages: 2,
},
{
name: "page limit",
pages: []map[string]interface{}{
pageResult(true, "next", false, "1"),
pageResult(true, "last", false, "2"),
},
pageLimit: 2,
wantCalls: 2,
wantReason: StopReasonPageLimit,
wantPages: 2,
wantMore: true,
wantToken: "last",
},
{
name: "start page token stays incomplete after exhaustion",
firstToken: "middle",
pages: []map[string]interface{}{
pageResult(false, "", false, "1"),
},
wantCalls: 1,
wantReason: StopReasonStartPageToken,
wantPages: 1,
},
{
name: "missing token fails closed",
pages: []map[string]interface{}{
pageResult(true, "", false, "1"),
},
wantCalls: 1,
wantReason: StopReasonMissingToken,
wantPages: 1,
wantMore: true,
wantErr: true,
},
{
name: "repeated token fails closed",
pages: []map[string]interface{}{
pageResult(true, "secret-token-x", false, "1"),
pageResult(true, "secret-token-x", false, "2"),
},
wantCalls: 2,
wantReason: StopReasonRepeatedToken,
wantPages: 2,
wantMore: true,
wantToken: "secret-token-x",
wantErr: true,
},
{
name: "server truncation is explicit structured fact",
pages: []map[string]interface{}{
pageResult(false, "", true, "1"),
},
wantCalls: 1,
wantReason: StopReasonServerTruncation,
wantPages: 1,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
if calls >= len(tt.pages) {
t.Fatalf("unexpected API call %d", calls+1)
}
body := tt.pages[calls]
calls++
return jsonResponse(body), nil
}))
params := map[string]interface{}{}
if tt.firstToken != "" {
params["page_token"] = tt.firstToken
}
result, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
Params: params,
As: "bot",
}, PaginationOptions{PageLimit: tt.pageLimit, PageDelay: -1})
if (err != nil) != tt.wantErr {
t.Fatalf("PaginateAllWithStatus() error = %v, wantErr %v", err, tt.wantErr)
}
if err != nil {
switch tt.wantReason {
case StopReasonMissingToken:
if err.Error() != "paginated response has_more=true but next page token is missing" {
t.Fatalf("missing-token error = %q", err)
}
case StopReasonRepeatedToken:
if err.Error() != "paginated response repeated the same next page token" {
t.Fatalf("repeated-token error = %q", err)
}
}
}
if calls != tt.wantCalls {
t.Errorf("API calls = %d, want %d", calls, tt.wantCalls)
}
if status.StopReason != tt.wantReason {
t.Errorf("StopReason = %q, want %q", status.StopReason, tt.wantReason)
}
if status.PagesFetched != tt.wantPages {
t.Errorf("PagesFetched = %d, want %d", status.PagesFetched, tt.wantPages)
}
if status.HasMore != tt.wantMore {
t.Errorf("HasMore = %v, want %v", status.HasMore, tt.wantMore)
}
if status.NextPageToken != tt.wantToken {
t.Errorf("NextPageToken = %q, want %q", status.NextPageToken, tt.wantToken)
}
if result == nil {
t.Fatal("result must preserve successfully fetched pages")
}
if tt.wantErr {
var internalErr *errs.InternalError
if !errors.As(err, &internalErr) || internalErr.Subtype != errs.SubtypeInvalidResponse {
t.Fatalf("error = %T %v, want invalid_response InternalError", err, err)
}
if tt.wantToken != "" && strings.Contains(err.Error(), tt.wantToken) {
t.Fatalf("error leaked page token: %v", err)
}
}
})
}
}
func TestPaginateAllWithStatusPreservesPartialResultAndTypedLateError(t *testing.T) {
t.Run("transport error", func(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return nil, &net.DNSError{Err: "no such host", Name: "example.invalid"}
}))
result, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1})
var networkErr *errs.NetworkError
if !errors.As(err, &networkErr) {
t.Fatalf("error = %T %v, want typed NetworkError", err, err)
}
assertPartialPage(t, result, "1")
if status.StopReason != StopReasonTransportError || status.PagesFetched != 1 || status.NextPageToken != "next" {
t.Fatalf("status = %#v, want late transport error with resumable token", status)
}
if status.Cause != err {
t.Fatalf("Cause = %v, want returned error %v", status.Cause, err)
}
})
t.Run("API error", func(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return jsonResponse(map[string]interface{}{"code": 999, "msg": "failed"}), nil
}))
result, status, err := ac.PaginateAllWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1})
var apiErr *errs.APIError
if !errors.As(err, &apiErr) {
t.Fatalf("error = %T %v, want typed APIError", err, err)
}
assertPartialPage(t, result, "1")
if status.StopReason != StopReasonAPIError || status.PagesFetched != 1 || status.NextPageToken != "next" {
t.Fatalf("status = %#v, want late API error with resumable token", status)
}
})
}
func TestStreamPagesWithStatusPreservesEmittedPagesOnLateError(t *testing.T) {
calls := 0
ac, _ := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return nil, &net.DNSError{Err: "no such host", Name: "example.invalid"}
}))
var emitted []map[string]interface{}
status, err := ac.StreamPagesWithStatus(context.Background(), &RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1}, func(page map[string]interface{}) error {
emitted = append(emitted, page)
return nil
})
var networkErr *errs.NetworkError
if !errors.As(err, &networkErr) {
t.Fatalf("error = %T %v, want typed NetworkError", err, err)
}
if len(emitted) != 1 {
t.Fatalf("emitted pages = %d, want 1", len(emitted))
}
if status.StopReason != StopReasonTransportError || status.PagesFetched != 1 {
t.Fatalf("status = %#v, want late transport error", status)
}
}
func TestLegacyPaginateAllStillSwallowsLateTransportError(t *testing.T) {
calls := 0
ac, errOut := newTestAPIClient(t, roundTripFunc(func(_ *http.Request) (*http.Response, error) {
calls++
if calls == 1 {
return jsonResponse(pageResult(true, "next", false, "1")), nil
}
return nil, &net.DNSError{Err: "no such host", Name: "example.invalid"}
}))
result, err := ac.PaginateAll(context.Background(), RawApiRequest{
Method: "GET",
URL: "/open-apis/test",
As: "bot",
}, PaginationOptions{PageDelay: -1})
if err != nil {
t.Fatalf("legacy PaginateAll() error = %v, want nil", err)
}
assertPartialPage(t, result, "1")
if !strings.Contains(errOut.String(), "[page 2] error, stopping pagination") {
t.Fatalf("legacy warning changed: %q", errOut.String())
}
}
func pageResult(hasMore bool, token string, truncated bool, id string) map[string]interface{} {
data := map[string]interface{}{
"items": []interface{}{map[string]interface{}{"id": id}},
"has_more": hasMore,
"truncated": truncated,
}
if token != "" {
data["page_token"] = token
}
return map[string]interface{}{"code": float64(0), "msg": "ok", "data": data}
}
func assertPartialPage(t *testing.T, result interface{}, wantID string) {
t.Helper()
resultMap, ok := result.(map[string]interface{})
if !ok {
t.Fatalf("result = %T, want map", result)
}
data, ok := resultMap["data"].(map[string]interface{})
if !ok {
t.Fatalf("data = %T, want map", resultMap["data"])
}
items, ok := data["items"].([]interface{})
if !ok || len(items) != 1 {
t.Fatalf("items = %#v, want one item", data["items"])
}
item, ok := items[0].(map[string]interface{})
if !ok || item["id"] != wantID {
t.Fatalf("item = %#v, want id %q", items[0], wantID)
}
}

View File

@@ -14,12 +14,16 @@ import (
// with --yes.
//
// action identifies the operation for the agent (e.g. "mail +send",
// "drive.files.delete"). The envelope does not carry a pre-built retry
// command: agents already know their original invocation and only need to
// append --yes per the hint, which keeps the protocol free of shell-quoting
// pitfalls.
// "drive.files.delete"). The hint is deliberately NOT a pre-built retry
// command: argv cannot faithfully reproduce the original invocation (pipeline
// producers, stdin bytes, redirections, inline env and the executable's real
// path are all gone), POSIX quoting does not survive PowerShell/cmd.exe, and
// echoing argv values can copy credentials or free-form payloads (--sql,
// --json) into the error envelope and every log that captures it. Per the
// lark-shared approval protocol, the caller that obtained the user's consent
// appends --yes to its own saved argv array and re-executes.
func RequireConfirmation(action string) error {
return errs.NewConfirmationRequiredError(errs.RiskHighRiskWrite, action,
"%s requires confirmation", action).
WithHint("add --yes to confirm")
err := errs.NewConfirmationRequiredError(errs.RiskHighRiskWrite, action,
"%s requires confirmation", action)
return err.WithHint("add --yes to confirm")
}

View File

@@ -35,8 +35,11 @@ func TestRequireConfirmation_TypedShape(t *testing.T) {
if !strings.Contains(cre.Message, "drive +delete") || !strings.Contains(cre.Message, "requires confirmation") {
t.Errorf("Message = %q, want it to mention action and 'requires confirmation'", cre.Message)
}
// The hint is the plain add-yes contract and nothing more: no pre-built
// retry command may ride behind it (argv cannot faithfully reproduce the
// invocation and may carry sensitive payloads — see RequireConfirmation).
if cre.Hint != "add --yes to confirm" {
t.Errorf("Hint = %q, want 'add --yes to confirm'", cre.Hint)
t.Errorf("Hint = %q, want exactly 'add --yes to confirm'", cre.Hint)
}
if cre.Risk != errs.RiskHighRiskWrite {
t.Errorf("Risk = %q, want %q", cre.Risk, errs.RiskHighRiskWrite)
@@ -61,8 +64,8 @@ func TestRequireConfirmation_JSONShape(t *testing.T) {
t.Fatalf("unmarshal: %v", err)
}
// No fix_command field leaks into the envelope: the protocol avoids
// shell-quoting hazards by delegating retry to agent-side logic.
// No fix_command field leaks into the envelope: the typed protocol stays
// action-only.
if _, has := back["fix_command"]; has {
t.Errorf("unexpected fix_command present in JSON: %s", raw)
}

View File

@@ -77,6 +77,11 @@ func ResolveInput(raw string, stdin io.Reader, fileIO fileio.FileIO) (string, er
// ReadInputFile reads path through fileIO. Open/read failures are wrapped with
// path context; fileio.ErrPathValidation remains matchable with errors.Is.
// All paths go through the caller's fileIO provider and its relative-to-cwd
// policy — no absolute-path side door: a trust root defined by the process
// environment (TMPDIR) is not a security boundary, and reading outside the
// provider would break sidecar/custom-FileIO ownership. Out-of-tree content
// reaches flags via stdin ("-").
func ReadInputFile(fileIO fileio.FileIO, path string) ([]byte, error) {
if fileIO == nil {
return nil, fmt.Errorf("file input is not available in this context")

View File

@@ -1,297 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package catalog
import (
"fmt"
"sort"
)
func ack(key string) Contract {
return Contract{Key: ContractKey(key), Strategy: Strategy{Kind: AuthoritativeAckKind}, ReplayMode: ReplayForbidden}
}
func required(key string, result RequiredSpec, replay ReplayMode) Contract {
return Contract{
Key: ContractKey(key),
Strategy: Strategy{Kind: RequiredResultKind, Required: result},
ReplayMode: replay,
}
}
func batch(key string, request EvidenceSpec, failures ...EvidenceSpec) Contract {
return Contract{
Key: ContractKey(key),
PartialRecovery: PartialRecoveryFailedItemsOnly,
Strategy: Strategy{
Kind: BatchPartialKind,
Request: request,
Failures: failures,
},
ReplayMode: ReplayForbidden,
}
}
func read(key string, kind StrategyKind) Contract {
return Contract{
Key: ContractKey(key),
Strategy: Strategy{Kind: kind},
}
}
func search(key, collectionField string) Contract {
return Contract{
Key: ContractKey(key),
Strategy: Strategy{
Kind: SearchReadKind,
CollectionField: collectionField,
},
}
}
func topString(field string) RequiredSpec {
return RequiredSpec{Shape: RequiredTopString, Field: field}
}
func topObject(field string) RequiredSpec {
return RequiredSpec{Shape: RequiredTopObject, Field: field}
}
func nestedString(field, child string) RequiredSpec {
return RequiredSpec{Shape: RequiredNestedString, Field: field, Child: child}
}
func stringsFrom(field string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceStrings, Field: field}
}
func objectsFrom(field, idField string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceObjects, Field: field, IDField: idField}
}
func nestedObjectsFrom(field, container, idField string) EvidenceSpec {
return EvidenceSpec{
Shape: EvidenceNestedObjects, Field: field, Container: container, IDField: idField,
}
}
func feedObjectsFrom(field string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceFeedObjects, Field: field}
}
func nestedFeedObjectsFrom(field, container string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceNestedFeedObjects, Field: field, Container: container}
}
func statusObjectsFrom(field, idField string) EvidenceSpec {
return EvidenceSpec{Shape: EvidenceStatusObjects, Field: field, IDField: idField}
}
var contracts = buildContracts()
func buildContracts() map[ContractKey]Contract {
all := []Contract{
read("im +feed-group-query-item", EntityReadKind),
read("im +messages-mget", EntityReadKind),
read("im chat.nickname get", EntityReadKind),
read("im chat.user_setting batch_query", EntityReadKind),
read("im chats get", EntityReadKind),
read("im feed.groups batch_query", EntityReadKind),
func() Contract {
c := read("im reactions batch_query", EntityReadKind)
c.Strategy.ReadHint = HintBatchReactions
return c
}(),
read("im +chat-list", CollectionReadKind),
read("im +chat-members-list", CollectionReadKind),
read("im +chat-messages-list", CollectionReadKind),
read("im +feed-group-list", CollectionReadKind),
read("im +feed-group-list-item", CollectionReadKind),
read("im +feed-shortcut-list", CollectionReadKind),
read("im +flag-list", CollectionReadKind),
read("im +threads-messages-list", CollectionReadKind),
read("im chat.members bots", CollectionReadKind),
read("im chat.members get", CollectionReadKind),
read("im chat.moderation get", CollectionReadKind),
read("im messages read_users", CollectionReadKind),
read("im pins list", CollectionReadKind),
read("im reactions list", CollectionReadKind),
search("im +chat-search", "chats"),
search("im +messages-search", "messages"),
read("im +messages-resources-download", MaterializeReadKind),
ack("im +chat-update"),
ack("im +flag-create"),
ack("im chat.nickname delete"),
ack("im chat.nickname update"),
ack("im chats update"),
ack("im feed.groups delete"),
ack("im feed.groups update"),
ack("im messages delete"),
ack("im pins delete"),
required("im +chat-create", topString("chat_id"), ReplayForbidden),
required("im +messages-reply", topString("message_id"), ReplaySameIdempotencyKey),
required("im +messages-send", topString("message_id"), ReplaySameIdempotencyKey),
required("im chats create", topString("chat_id"), ReplaySameIdempotencyKey),
required("im chats link", topString("share_link"), ReplayForbidden),
required("im feed.groups create", topString("group_id"), ReplayForbidden),
required("im images create", topString("image_key"), ReplayForbidden),
required("im messages forward", topString("message_id"), ReplaySameIdempotencyKey),
required("im pins create", topObject("pin"), ReplayForbidden),
required("im reactions create", topString("reaction_id"), ReplayForbidden),
required("im reactions delete", topString("reaction_id"), ReplayForbidden),
required("im threads forward", topString("message_id"), ReplaySameIdempotencyKey),
func() Contract {
c := batch(
"im +feed-shortcut-create",
objectsFrom("shortcuts", "feed_card_id"),
nestedObjectsFrom("failed_shortcuts", "shortcut", "feed_card_id"),
)
c.ReplayMode = ReplaySafe
c.PartialRecovery = PartialRecoveryWholeRequest
return c
}(),
func() Contract {
c := batch(
"im +feed-shortcut-remove",
objectsFrom("shortcuts", "feed_card_id"),
nestedObjectsFrom("failed_shortcuts", "shortcut", "feed_card_id"),
)
c.ReplayMode = ReplaySafe
c.PartialRecovery = PartialRecoveryWholeRequest
return c
}(),
{
Key: "im +flag-cancel",
PartialRecovery: PartialRecoveryWholeRequest,
Strategy: Strategy{
Kind: BatchPartialKind,
ResultLedger: ptrEvidence(statusObjectsFrom("results", "flag_type")),
},
ReplayMode: ReplaySafe,
},
{
Key: "im chat.members create",
Strategy: Strategy{
Kind: BatchPartialKind,
Request: stringsFrom("id_list"),
Failures: []EvidenceSpec{
stringsFrom("invalid_id_list"),
stringsFrom("not_existed_id_list"),
},
Pending: []EvidenceSpec{stringsFrom("pending_approval_id_list")},
},
ReplayMode: ReplayForbidden,
},
batch("im chat.members delete", stringsFrom("id_list"), stringsFrom("invalid_id_list")),
batch(
"im chat.user_setting batch_update",
objectsFrom("chat_settings", "chat_id"),
objectsFrom("invalid_ids", "id"),
),
{
Key: "im feed.groups batch_add_item",
Strategy: Strategy{
Kind: BatchPartialKind,
Request: feedObjectsFrom("items"),
Failures: []EvidenceSpec{nestedFeedObjectsFrom("failed_items", "item")},
},
ReplayMode: ReplayForbidden,
},
{
Key: "im feed.groups batch_remove_item",
Strategy: Strategy{
Kind: BatchPartialKind,
Request: feedObjectsFrom("items"),
Failures: []EvidenceSpec{nestedFeedObjectsFrom("failed_items", "item")},
},
ReplayMode: ReplayForbidden,
},
batch("im messages urgent_app", stringsFrom("user_id_list"), stringsFrom("invalid_user_id_list")),
batch("im messages urgent_phone", stringsFrom("user_id_list"), stringsFrom("invalid_user_id_list")),
batch("im messages urgent_sms", stringsFrom("user_id_list"), stringsFrom("invalid_user_id_list")),
{
Key: "im messages merge_forward",
Strategy: Strategy{
Kind: RequiredResultBatchPartialKind,
Required: nestedString("message", "message_id"),
Request: stringsFrom("message_id_list"),
Failures: []EvidenceSpec{stringsFrom("invalid_message_id_list")},
},
ReplayMode: ReplaySameIdempotencyKey,
},
{
Key: "im chat.managers add_managers",
Strategy: Strategy{
Kind: ResponseSetAssertionKind,
Request: stringsFrom("manager_ids"),
ResponseSets: []EvidenceSpec{stringsFrom("chat_managers"), stringsFrom("chat_bot_managers")},
Assertion: AssertRequestedPresent,
},
ReplayMode: ReplayForbidden,
},
{
Key: "im chat.managers delete_managers",
Strategy: Strategy{
Kind: ResponseSetAssertionKind,
Request: stringsFrom("manager_ids"),
ResponseSets: []EvidenceSpec{stringsFrom("chat_managers"), stringsFrom("chat_bot_managers")},
Assertion: AssertRequestedAbsent,
},
ReplayMode: ReplayForbidden,
},
{
Key: "im chat.moderation update",
Strategy: Strategy{Kind: AcceptanceOnlyKind},
ReplayMode: ReplayForbidden,
},
}
out := make(map[ContractKey]Contract, len(all))
for _, c := range all {
if c.PartialRecovery == "" &&
(c.Strategy.Kind == BatchPartialKind || c.Strategy.Kind == RequiredResultBatchPartialKind) {
c.PartialRecovery = PartialRecoveryFailedItemsOnly
}
switch {
case c.Strategy.Kind == CollectionReadKind || c.Strategy.Kind == SearchReadKind:
c.HelpPolicy = HelpCompleteness
case c.Strategy.Kind == AcceptanceOnlyKind:
c.HelpPolicy = HelpAcceptanceOnly
}
out[c.Key] = c
}
return out
}
func ptrEvidence(spec EvidenceSpec) *EvidenceSpec {
return &spec
}
func Lookup(key ContractKey) (Contract, bool) {
c, ok := contracts[key]
return c, ok
}
func All() []Contract {
out := make([]Contract, 0, len(contracts))
for _, c := range contracts {
out = append(out, c)
}
sort.Slice(out, func(i, j int) bool { return out[i].Key < out[j].Key })
return out
}
func ValidateRegistry() error {
for key, c := range contracts {
if key == "" || c.Strategy.Kind == "" {
return fmt.Errorf("invalid IM contract %q", key)
}
}
return nil
}

View File

@@ -1,32 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package catalog
import "testing"
func TestWholeRequestPartialRecoveryContracts(t *testing.T) {
for _, key := range []ContractKey{
"im +feed-shortcut-create",
"im +feed-shortcut-remove",
"im +flag-cancel",
} {
contract, ok := Lookup(key)
if !ok {
t.Fatalf("missing contract %q", key)
}
if contract.PartialRecovery != PartialRecoveryWholeRequest {
t.Fatalf("%s partial recovery = %q", key, contract.PartialRecovery)
}
}
remove, _ := Lookup("im +feed-shortcut-remove")
if remove.ReplayMode != ReplaySafe {
t.Fatalf("feed shortcut remove replay mode = %q", remove.ReplayMode)
}
urgent, _ := Lookup("im messages urgent_app")
if urgent.PartialRecovery != PartialRecoveryFailedItemsOnly {
t.Fatalf("urgent app partial recovery = %q", urgent.PartialRecovery)
}
}

View File

@@ -1,138 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
// Package catalog defines the static IM command completion contract catalog.
package catalog
type ContractKey string
type StrategyKind string
const (
EntityReadKind StrategyKind = "entity_read"
CollectionReadKind StrategyKind = "collection_read"
SearchReadKind StrategyKind = "search_read"
MaterializeReadKind StrategyKind = "materialize_read"
AuthoritativeAckKind StrategyKind = "authoritative_ack"
RequiredResultKind StrategyKind = "required_result"
BatchPartialKind StrategyKind = "batch_partial"
RequiredResultBatchPartialKind StrategyKind = "required_result_batch_partial"
ResponseSetAssertionKind StrategyKind = "response_set_assertion"
AcceptanceOnlyKind StrategyKind = "acceptance_only"
)
func (k StrategyKind) IsWrite() bool {
switch k {
case AuthoritativeAckKind, RequiredResultKind, BatchPartialKind,
RequiredResultBatchPartialKind, ResponseSetAssertionKind, AcceptanceOnlyKind:
return true
default:
return false
}
}
func (k StrategyKind) IsRead() bool {
switch k {
case EntityReadKind, CollectionReadKind, SearchReadKind, MaterializeReadKind:
return true
default:
return false
}
}
type ReplayMode string
const (
ReplayForbidden ReplayMode = "forbidden"
ReplaySafe ReplayMode = "safe"
ReplaySameIdempotencyKey ReplayMode = "same_idempotency_key"
)
type PartialRecoveryMode string
const (
PartialRecoveryWholeRequest PartialRecoveryMode = "whole_request"
PartialRecoveryFailedItemsOnly PartialRecoveryMode = "failed_items_only"
)
type AssertionMode string
const (
AssertRequestedPresent AssertionMode = "requested_present"
AssertRequestedAbsent AssertionMode = "requested_absent"
)
type RequiredShape uint8
const (
RequiredTopString RequiredShape = iota + 1
RequiredTopObject
RequiredNestedString
)
type EvidenceShape uint8
const (
EvidenceStrings EvidenceShape = iota + 1
EvidenceObjects
EvidenceNestedObjects
EvidenceFeedObjects
EvidenceNestedFeedObjects
EvidenceStatusObjects
)
type RequiredSpec struct {
Shape RequiredShape
Field string
Child string
}
type EvidenceSpec struct {
Shape EvidenceShape
Field string
IDField string
Container string
}
type Strategy struct {
Kind StrategyKind
Required RequiredSpec
Request EvidenceSpec
Failures []EvidenceSpec
Pending []EvidenceSpec
ResponseSets []EvidenceSpec
Assertion AssertionMode
ResultLedger *EvidenceSpec
// CollectionField is only used by the two fixed IM search strategies to
// determine whether an exhausted search returned no candidates. It is not
// a general response path or field extractor.
CollectionField string
ReadHint string
}
type HelpPolicy string
const (
HelpCompleteness HelpPolicy = "completeness"
HelpAcceptanceOnly HelpPolicy = "acceptance_only"
HintBatchReactions = "This result covers only the returned reaction fragments; use `im reactions list` to exhaust one message's reactions."
)
func (p HelpPolicy) Text() string {
switch p {
case HelpCompleteness:
return "Completeness: use --page-all --page-limit 0 for exhaustive output; only meta.complete=true proves completion."
case HelpAcceptanceOnly:
return "Guarantee: success confirms request acceptance only; independently query the final moderator state before claiming completion."
default:
return ""
}
}
type Contract struct {
Key ContractKey
Strategy Strategy
ReplayMode ReplayMode
PartialRecovery PartialRecoveryMode
HelpPolicy HelpPolicy
}

View File

@@ -1,31 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import "github.com/spf13/cobra"
const (
helpContractAnnotation = "imcontract.help.contract-key"
)
func AnnotateHelpContract(cmd *cobra.Command, key ContractKey) {
if cmd == nil || key == "" {
return
}
if cmd.Annotations == nil {
cmd.Annotations = map[string]string{}
}
cmd.Annotations[helpContractAnnotation] = string(key)
}
func HelpText(cmd *cobra.Command) string {
if cmd == nil || !cmd.Runnable() || cmd.Annotations == nil {
return ""
}
contract, ok := Lookup(ContractKey(cmd.Annotations[helpContractAnnotation]))
if !ok {
return ""
}
return contract.HelpPolicy.Text()
}

View File

@@ -1,65 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"testing"
"github.com/spf13/cobra"
)
func TestHelpPolicyTextUsesOnlyApprovedTemplates(t *testing.T) {
tests := []struct {
policy HelpPolicy
want string
}{
{HelpCompleteness, "Completeness: use --page-all --page-limit 0 for exhaustive output; only meta.complete=true proves completion."},
{HelpAcceptanceOnly, "Guarantee: success confirms request acceptance only; independently query the final moderator state before claiming completion."},
{HelpPolicy("unknown"), ""},
}
for _, tt := range tests {
if got := tt.policy.Text(); got != tt.want {
t.Fatalf("HelpPolicy(%q).Text() = %q, want %q", tt.policy, got, tt.want)
}
}
}
func TestRegistryHelpPolicies(t *testing.T) {
tests := []struct {
key ContractKey
want HelpPolicy
}{
{"im +chat-list", HelpCompleteness},
{"im +messages-search", HelpCompleteness},
{"im +messages-send", ""},
{"im messages merge_forward", ""},
{"im chat.moderation update", HelpAcceptanceOnly},
{"im +flag-create", ""},
}
for _, tt := range tests {
contract, ok := Lookup(tt.key)
if !ok {
t.Fatalf("missing contract %q", tt.key)
}
if contract.HelpPolicy != tt.want {
t.Fatalf("%s HelpPolicy = %q, want %q", tt.key, contract.HelpPolicy, tt.want)
}
}
}
func TestHelpTextIsLazyAndRunnableOnly(t *testing.T) {
cmd := &cobra.Command{Use: "+chat-list", Short: "List chats", Run: func(*cobra.Command, []string) {}}
AnnotateHelpContract(cmd, "im +chat-list")
if cmd.Long != "" || cmd.Short != "List chats" {
t.Fatalf("annotation changed visible help fields: Short=%q Long=%q", cmd.Short, cmd.Long)
}
if got := HelpText(cmd); got != HelpCompleteness.Text() {
t.Fatalf("HelpText() = %q", got)
}
parent := &cobra.Command{Use: "im"}
AnnotateHelpContract(parent, "im +chat-list")
if got := HelpText(parent); got != "" {
t.Fatalf("parent HelpText() = %q, want empty", got)
}
}

View File

@@ -1,248 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"encoding/json"
"fmt"
"strings"
)
type Completion struct {
Status string `json:"status"`
RequestedCount int `json:"requested_count"`
SucceededCount int `json:"succeeded_count"`
FailedCount int `json:"failed_count"`
PendingCount int `json:"pending_count"`
SucceededItems []any `json:"succeeded_items"`
FailedItems []any `json:"failed_items"`
PendingItems []any `json:"pending_items"`
RetryScope string `json:"retry_scope"`
}
type ledgerItem struct {
key string
value any
}
type extraction struct {
items []ledgerItem
rawCount int
selectedCount int
rejectedCount int
present bool
}
func extract(root map[string]any, spec evidenceSpec) extraction {
if root == nil || spec.Field == "" {
return extraction{}
}
raw, present := root[spec.Field]
if !present {
return extraction{}
}
values, ok := raw.([]any)
out := extraction{present: true}
if !ok {
out.rejectedCount = 1
return out
}
out.rawCount = len(values)
for _, value := range values {
item, ok := extractItem(value, spec)
if !ok {
out.rejectedCount++
continue
}
out.selectedCount++
out.items = append(out.items, item)
}
out.items = uniqueItems(out.items)
return out
}
func extractItem(value any, spec evidenceSpec) (ledgerItem, bool) {
switch spec.Shape {
case evidenceStrings:
return stringItem(value)
case evidenceObjects:
object, ok := value.(map[string]any)
if !ok {
return ledgerItem{}, false
}
return stringItem(object[spec.IDField])
case evidenceNestedObjects:
object, ok := nestedObject(value, spec.Container)
if !ok {
return ledgerItem{}, false
}
return stringItem(object[spec.IDField])
case evidenceFeedObjects:
object, ok := value.(map[string]any)
if !ok {
return ledgerItem{}, false
}
return feedItem(object)
case evidenceNestedFeedObjects:
object, ok := nestedObject(value, spec.Container)
if !ok {
return ledgerItem{}, false
}
return feedItem(object)
case evidenceStatusObjects:
object, ok := value.(map[string]any)
if !ok {
return ledgerItem{}, false
}
status := nonEmptyString(object["status"])
if status != "ok" && status != "failed" {
return ledgerItem{}, false
}
return stringItem(object[spec.IDField])
default:
return ledgerItem{}, false
}
}
func nestedObject(value any, field string) (map[string]any, bool) {
object, ok := value.(map[string]any)
if !ok {
return nil, false
}
nested, ok := object[field].(map[string]any)
return nested, ok
}
func stringItem(value any) (ledgerItem, bool) {
id := stableID(value)
if id == "" {
return ledgerItem{}, false
}
return ledgerItem{key: id, value: id}, true
}
func feedItem(object map[string]any) (ledgerItem, bool) {
feedID := stableID(object["feed_id"])
feedType := stableID(object["feed_type"])
if feedID == "" || feedType == "" {
return ledgerItem{}, false
}
return ledgerItem{
key: feedType + "\x00" + feedID,
value: map[string]any{
"feed_id": feedID, "feed_type": feedType,
},
}, true
}
func nonEmptyString(value any) string {
text, ok := value.(string)
if !ok {
return ""
}
return strings.TrimSpace(text)
}
func stableID(value any) string {
switch id := value.(type) {
case string:
return strings.TrimSpace(id)
case json.Number:
return string(id)
case int, int8, int16, int32, int64, uint, uint8, uint16, uint32, uint64:
return fmt.Sprint(id)
default:
return ""
}
}
func uniqueItems(items []ledgerItem) []ledgerItem {
out := make([]ledgerItem, 0, len(items))
seen := make(map[string]struct{}, len(items))
for _, item := range items {
if item.key == "" {
continue
}
if _, ok := seen[item.key]; ok {
continue
}
seen[item.key] = struct{}{}
out = append(out, item)
}
return out
}
func completion(requested, failed, pending []ledgerItem, recovery PartialRecoveryMode) Completion {
requested = uniqueItems(requested)
requestedSet := make(map[string]struct{}, len(requested))
for _, item := range requested {
requestedSet[item.key] = struct{}{}
}
filterRequested := func(items []ledgerItem, excluded map[string]struct{}) []ledgerItem {
out := make([]ledgerItem, 0, len(items))
for _, item := range uniqueItems(items) {
if _, ok := requestedSet[item.key]; !ok {
continue
}
if _, blocked := excluded[item.key]; blocked {
continue
}
out = append(out, item)
}
return out
}
// A contradictory pending+failed response is treated as pending. Pending
// means the final state is unknown, so authorizing a retry would be unsafe.
pending = filterRequested(pending, nil)
pendingSet := make(map[string]struct{}, len(pending))
for _, item := range pending {
pendingSet[item.key] = struct{}{}
}
failed = filterRequested(failed, pendingSet)
blocked := make(map[string]struct{}, len(failed)+len(pending))
for key := range pendingSet {
blocked[key] = struct{}{}
}
for _, item := range failed {
blocked[item.key] = struct{}{}
}
succeeded := make([]ledgerItem, 0, len(requested))
for _, item := range requested {
if _, exists := blocked[item.key]; !exists {
succeeded = append(succeeded, item)
}
}
status := "complete"
retryScope := "none"
if len(failed) > 0 || len(pending) > 0 {
status = "partial"
switch {
case len(pending) > 0:
retryScope = "none"
case recovery == PartialRecoveryWholeRequest:
retryScope = "whole_request"
default:
retryScope = "failed_items_only"
}
}
values := func(items []ledgerItem) []any {
out := make([]any, 0, len(items))
for _, item := range items {
out = append(out, item.value)
}
return out
}
return Completion{
Status: status,
RequestedCount: len(requested),
SucceededCount: len(succeeded),
FailedCount: len(failed),
PendingCount: len(pending),
SucceededItems: values(succeeded),
FailedItems: values(failed),
PendingItems: values(pending),
RetryScope: retryScope,
}
}

View File

@@ -1,196 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/output"
)
const (
hintSinglePage = "Result is incomplete. Re-run with --page-all --page-limit 0 when exhaustive output is required."
hintPageLimit = "Result is incomplete because --page-limit was reached. Use --page-limit 0 only when exhaustive output is required."
hintReadFailed = "The read is incomplete. Retry the read; do not infer that missing items do not exist."
hintTokenUnusable = "The server did not provide a usable next page token. Report the result as incomplete."
hintStartPage = "This read started from a supplied page token and does not prove the collection was exhausted from the beginning."
hintServerTruncate = "The server truncated the result. Narrow the query range before retrying."
hintSearchEmpty = "The search was exhausted, but an empty search result does not prove that the resource does not exist."
)
type ReadOptions struct {
FullRead bool
}
// ReadResult is the IM-only interpretation of neutral pagination facts.
// Error is deliberately a copied Problem rather than the original error so
// causes and typed-error extension fields cannot leak into stdout.
type ReadResult struct {
OK bool
Data any
Meta *output.Meta
Error *errs.Problem
Hint string
ExitCode int
Cause error `json:"-"`
}
// ReadSession is independent from the write Session. It only records one
// pagination outcome and never observes request or response bodies.
type ReadSession struct {
contract Contract
options ReadOptions
status client.PaginationStatus
observed bool
}
func NewReadSession(contract Contract, options ReadOptions) (*ReadSession, error) {
if !contract.Strategy.Kind.IsRead() {
return nil, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported IM read contract strategy %q",
contract.Strategy.Kind,
)
}
return &ReadSession{contract: contract, options: options}, nil
}
func (s *ReadSession) ObservePagination(status client.PaginationStatus) {
s.status = status
s.observed = true
}
func (s *ReadSession) RequiresPagination() bool {
return s.contract.Strategy.Kind == CollectionReadKind || s.contract.Strategy.Kind == SearchReadKind
}
func (s *ReadSession) Finalize(data any) (ReadResult, error) {
switch s.contract.Strategy.Kind {
case EntityReadKind, MaterializeReadKind:
return ReadResult{
OK: true,
Data: data,
Hint: s.contract.Strategy.ReadHint,
}, nil
case CollectionReadKind, SearchReadKind:
if !s.observed {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"IM collection read completed without pagination status",
)
}
default:
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported IM read contract strategy %q",
s.contract.Strategy.Kind,
)
}
result, err := finalizePagedRead(data, s.status, s.options.FullRead)
if err != nil {
return ReadResult{}, err
}
if s.contract.Strategy.Kind == SearchReadKind &&
s.status.StopReason == client.StopReasonExhausted &&
searchCollectionEmpty(data, s.contract.Strategy.CollectionField) {
result.Hint = joinHints(result.Hint, hintSearchEmpty)
}
return result, nil
}
func finalizePagedRead(data any, status client.PaginationStatus, fullRead bool) (ReadResult, error) {
complete := false
result := ReadResult{
OK: true,
Data: data,
Meta: &output.Meta{
Complete: &complete,
PagesFetched: status.PagesFetched,
StopReason: string(status.StopReason),
NextPageToken: status.NextPageToken,
},
}
switch status.StopReason {
case client.StopReasonExhausted:
complete = true
case client.StopReasonSinglePage:
result.Hint = hintSinglePage
case client.StopReasonPageLimit:
result.Hint = hintPageLimit
case client.StopReasonStartPageToken:
result.Hint = hintStartPage
case client.StopReasonServerTruncation:
result.Hint = hintServerTruncate
if fullRead {
result.OK = false
result.ExitCode = output.ExitAPI
}
case client.StopReasonTransportError, client.StopReasonAPIError,
client.StopReasonMissingToken, client.StopReasonRepeatedToken:
if status.Cause == nil {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"pagination stopped with %q but no typed cause was recorded",
status.StopReason,
)
}
problem, ok := errs.ProblemOf(status.Cause)
if !ok {
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"pagination stopped with an untyped cause",
)
}
copied := *problem
result.OK = false
result.Error = &copied
result.ExitCode = output.ExitCodeOf(status.Cause)
result.Cause = status.Cause
switch status.StopReason {
case client.StopReasonMissingToken, client.StopReasonRepeatedToken:
result.Hint = hintTokenUnusable
default:
result.Hint = hintReadFailed
}
default:
return ReadResult{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported pagination stop reason %q",
status.StopReason,
)
}
*result.Meta.Complete = complete
return result, nil
}
func searchCollectionEmpty(data any, field string) bool {
m, ok := data.(map[string]any)
if !ok {
return false
}
value, exists := m[field]
if !exists {
return false
}
switch items := value.(type) {
case []any:
return len(items) == 0
case []map[string]any:
return len(items) == 0
default:
return false
}
}
func joinHints(first, second string) string {
if first == "" {
return second
}
if second == "" {
return first
}
return first + " " + second
}

View File

@@ -1,181 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"encoding/json"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/output"
)
func TestReadCompletenessMatrix(t *testing.T) {
apiErr := errs.NewAPIError(errs.SubtypeServerError, "later page failed")
networkErr := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithRetryable()
invalidErr := errs.NewInternalError(errs.SubtypeInvalidResponse, "bad pagination")
tests := []struct {
name string
fullRead bool
status client.PaginationStatus
wantOK bool
wantDone bool
wantExit int
wantReason client.StopReason
wantError bool
wantHint string
}{
{"single exhausted", false, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonExhausted}, true, true, 0, client.StopReasonExhausted, false, ""},
{"single has more", false, client.PaginationStatus{PagesFetched: 1, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonSinglePage}, true, false, 0, client.StopReasonSinglePage, false, "Result is incomplete. Re-run with --page-all --page-limit 0 when exhaustive output is required."},
{"all exhausted", true, client.PaginationStatus{PagesFetched: 2, StopReason: client.StopReasonExhausted}, true, true, 0, client.StopReasonExhausted, false, ""},
{"page limit", true, client.PaginationStatus{PagesFetched: 2, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonPageLimit}, true, false, 0, client.StopReasonPageLimit, false, "Result is incomplete because --page-limit was reached. Use --page-limit 0 only when exhaustive output is required."},
{"start token", false, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonStartPageToken}, true, false, 0, client.StopReasonStartPageToken, false, hintStartPage},
{"api error", true, client.PaginationStatus{PagesFetched: 1, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonAPIError, Cause: apiErr}, false, false, output.ExitAPI, client.StopReasonAPIError, true, "The read is incomplete. Retry the read; do not infer that missing items do not exist."},
{"transport error", true, client.PaginationStatus{PagesFetched: 1, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonTransportError, Cause: networkErr}, false, false, output.ExitNetwork, client.StopReasonTransportError, true, "The read is incomplete. Retry the read; do not infer that missing items do not exist."},
{"missing token", true, client.PaginationStatus{PagesFetched: 1, HasMore: true, StopReason: client.StopReasonMissingToken, Cause: invalidErr}, false, false, output.ExitInternal, client.StopReasonMissingToken, true, "The server did not provide a usable next page token. Report the result as incomplete."},
{"repeated token", true, client.PaginationStatus{PagesFetched: 2, HasMore: true, StopReason: client.StopReasonRepeatedToken, Cause: invalidErr}, false, false, output.ExitInternal, client.StopReasonRepeatedToken, true, "The server did not provide a usable next page token. Report the result as incomplete."},
{"single truncation", false, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonServerTruncation}, true, false, 0, client.StopReasonServerTruncation, false, "The server truncated the result. Narrow the query range before retrying."},
{"full truncation", true, client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonServerTruncation}, false, false, output.ExitAPI, client.StopReasonServerTruncation, false, "The server truncated the result. Narrow the query range before retrying."},
}
contract := mustReadContract(t, "im +chat-list")
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
session, err := NewReadSession(contract, ReadOptions{FullRead: tt.fullRead})
if err != nil {
t.Fatal(err)
}
session.ObservePagination(tt.status)
got, err := session.Finalize(map[string]any{"items": []any{"a"}})
if err != nil {
t.Fatal(err)
}
if got.OK != tt.wantOK || got.ExitCode != tt.wantExit {
t.Fatalf("result OK/exit = %v/%d, want %v/%d", got.OK, got.ExitCode, tt.wantOK, tt.wantExit)
}
if got.Meta == nil || got.Meta.Complete == nil || *got.Meta.Complete != tt.wantDone {
t.Fatalf("complete = %#v, want %v", got.Meta, tt.wantDone)
}
if got.Meta.StopReason != string(tt.wantReason) {
t.Fatalf("stop reason = %q, want %q", got.Meta.StopReason, tt.wantReason)
}
if (got.Error != nil) != tt.wantError {
t.Fatalf("error present = %v, want %v", got.Error != nil, tt.wantError)
}
if got.Hint != tt.wantHint {
t.Fatalf("hint = %q, want %q", got.Hint, tt.wantHint)
}
})
}
}
func TestReadFailureErrorWireShapeDoesNotSerializeCause(t *testing.T) {
contract := mustReadContract(t, "im +chat-list")
session, err := NewReadSession(contract, ReadOptions{FullRead: true})
if err != nil {
t.Fatal(err)
}
secret := "raw-server-cause-must-not-leak"
cause := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").
WithRetryable().
WithCause(assertionError(secret))
session.ObservePagination(client.PaginationStatus{
PagesFetched: 1,
HasMore: true,
NextPageToken: "opaque-token",
StopReason: client.StopReasonTransportError,
Cause: cause,
})
result, err := session.Finalize(map[string]any{"items": []any{"kept"}})
if err != nil {
t.Fatal(err)
}
wire, err := json.Marshal(result.Error)
if err != nil {
t.Fatal(err)
}
if string(wire) == "" || containsAny(string(wire), secret, "opaque-token") {
t.Fatalf("unsafe error wire: %s", wire)
}
}
func TestSearchEmptyResultAddsNonExistenceHint(t *testing.T) {
contract := mustReadContract(t, "im +chat-search")
session, err := NewReadSession(contract, ReadOptions{})
if err != nil {
t.Fatal(err)
}
session.ObservePagination(client.PaginationStatus{PagesFetched: 1, StopReason: client.StopReasonExhausted})
result, err := session.Finalize(map[string]any{"chats": []any{}})
if err != nil {
t.Fatal(err)
}
if result.Meta == nil || result.Meta.Complete == nil || !*result.Meta.Complete {
t.Fatalf("expected exhausted result to be complete: %#v", result.Meta)
}
const wantHint = "The search was exhausted, but an empty search result does not prove that the resource does not exist."
if result.Hint != wantHint {
t.Fatalf("hint = %q, want %q", result.Hint, wantHint)
}
}
func TestEntityAndMaterializeDoNotInventPagination(t *testing.T) {
for _, key := range []ContractKey{"im chat.nickname get", "im +messages-resources-download"} {
t.Run(string(key), func(t *testing.T) {
contract := mustReadContract(t, key)
session, err := NewReadSession(contract, ReadOptions{})
if err != nil {
t.Fatal(err)
}
result, err := session.Finalize(map[string]any{"nickname": ""})
if err != nil {
t.Fatal(err)
}
if !result.OK || result.Meta != nil || result.ExitCode != 0 {
t.Fatalf("unexpected finite result: %#v", result)
}
})
}
}
func TestUnknownReadStrategyFailsClosed(t *testing.T) {
_, err := NewReadSession(Contract{
Key: "im future read",
Strategy: Strategy{Kind: StrategyKind("future_read")},
}, ReadOptions{})
if err == nil || !errs.IsInternal(err) {
t.Fatalf("expected typed internal error, got %v", err)
}
}
func mustReadContract(t *testing.T, key ContractKey) Contract {
t.Helper()
contract, ok := Lookup(key)
if !ok {
t.Fatalf("missing contract %q", key)
}
return contract
}
type assertionError string
func (e assertionError) Error() string { return string(e) }
func containsAny(s string, values ...string) bool {
for _, value := range values {
if value != "" && stringContains(s, value) {
return true
}
}
return false
}
func stringContains(s, substr string) bool {
for i := 0; i+len(substr) <= len(s); i++ {
if s[i:i+len(substr)] == substr {
return true
}
}
return false
}

View File

@@ -1,22 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import "github.com/larksuite/cli/internal/imcontract/catalog"
func Lookup(key ContractKey) (Contract, bool) {
return catalog.Lookup(key)
}
func All() []Contract {
return catalog.All()
}
func ValidateRegistry() error {
return catalog.ValidateRegistry()
}
func stringsFrom(field string) evidenceSpec {
return evidenceSpec{Shape: evidenceStrings, Field: field}
}

View File

@@ -1,131 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"slices"
"testing"
)
func TestWriteRegistryCoverage(t *testing.T) {
counts := map[StrategyKind]int{}
total := 0
for _, contract := range All() {
if contract.Strategy.Kind.IsWrite() {
counts[contract.Strategy.Kind]++
total++
}
}
if total != 36 {
t.Fatalf("write contracts = %d, want 36", total)
}
want := map[StrategyKind]int{
AuthoritativeAckKind: 9,
RequiredResultKind: 12,
BatchPartialKind: 11,
RequiredResultBatchPartialKind: 1,
ResponseSetAssertionKind: 2,
AcceptanceOnlyKind: 1,
}
for kind, n := range want {
if counts[kind] != n {
t.Errorf("%s = %d, want %d", kind, counts[kind], n)
}
}
if err := ValidateRegistry(); err != nil {
t.Fatal(err)
}
wantKeys := []ContractKey{
"im +chat-create", "im +chat-update", "im +feed-shortcut-create",
"im +feed-shortcut-remove", "im +flag-cancel", "im +flag-create",
"im +messages-reply", "im +messages-send",
"im chat.managers add_managers", "im chat.managers delete_managers",
"im chat.members create", "im chat.members delete",
"im chat.moderation update", "im chat.nickname delete",
"im chat.nickname update", "im chat.user_setting batch_update",
"im chats create", "im chats link", "im chats update",
"im feed.groups batch_add_item", "im feed.groups batch_remove_item",
"im feed.groups create", "im feed.groups delete", "im feed.groups update",
"im images create", "im messages delete", "im messages forward",
"im messages merge_forward", "im messages urgent_app",
"im messages urgent_phone", "im messages urgent_sms", "im pins create",
"im pins delete", "im reactions create", "im reactions delete",
"im threads forward",
}
gotKeys := make([]ContractKey, 0, len(All()))
for _, c := range All() {
if c.Strategy.Kind.IsWrite() {
gotKeys = append(gotKeys, c.Key)
}
}
if !slices.Equal(gotKeys, wantKeys) {
t.Fatalf("write registry keys differ:\ngot %v\nwant %v", gotKeys, wantKeys)
}
}
func TestModerationAcceptanceOnlyContract(t *testing.T) {
c, ok := Lookup("im chat.moderation update")
if !ok {
t.Fatal("moderation contract missing")
}
if c.Strategy.Kind != AcceptanceOnlyKind || c.ReplayMode != ReplayForbidden ||
c.HelpPolicy != HelpAcceptanceOnly {
t.Fatalf("unexpected moderation contract: %#v", c)
}
}
func TestReadRegistryCoverage(t *testing.T) {
counts := map[StrategyKind]int{}
var gotKeys []ContractKey
for _, contract := range All() {
if !contract.Strategy.Kind.IsRead() {
continue
}
counts[contract.Strategy.Kind]++
gotKeys = append(gotKeys, contract.Key)
}
if len(gotKeys) != 24 {
t.Fatalf("read contracts = %d, want 24", len(gotKeys))
}
wantCounts := map[StrategyKind]int{
EntityReadKind: 7,
CollectionReadKind: 14,
SearchReadKind: 2,
MaterializeReadKind: 1,
}
for kind, want := range wantCounts {
if got := counts[kind]; got != want {
t.Errorf("%s = %d, want %d", kind, got, want)
}
}
wantKeys := []ContractKey{
"im +chat-list",
"im +chat-members-list",
"im +chat-messages-list",
"im +chat-search",
"im +feed-group-list",
"im +feed-group-list-item",
"im +feed-group-query-item",
"im +feed-shortcut-list",
"im +flag-list",
"im +messages-mget",
"im +messages-resources-download",
"im +messages-search",
"im +threads-messages-list",
"im chat.members bots",
"im chat.members get",
"im chat.moderation get",
"im chat.nickname get",
"im chat.user_setting batch_query",
"im chats get",
"im feed.groups batch_query",
"im messages read_users",
"im pins list",
"im reactions batch_query",
"im reactions list",
}
if !slices.Equal(gotKeys, wantKeys) {
t.Fatalf("read registry keys differ:\ngot %v\nwant %v", gotKeys, wantKeys)
}
}

View File

@@ -1,163 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"errors"
"strings"
"github.com/larksuite/cli/errs"
)
type Session struct {
contract Contract
requested []ledgerItem
hasIdempotencyKey bool
facts []Fact
}
func NewSession(contract Contract) *Session {
return &Session{contract: contract}
}
func (s *Session) Contract() Contract {
return s.contract
}
func (s *Session) ObserveRequest(body map[string]any) error {
if spec := s.contract.Strategy.Request; spec.Field != "" {
evidence := extract(body, spec)
if !evidence.present || evidence.selectedCount == 0 ||
evidence.rejectedCount != 0 ||
evidence.rawCount != evidence.selectedCount+evidence.rejectedCount {
return errs.NewValidationError(
errs.SubtypeInvalidArgument,
"IM write request field %q has an unsupported shape",
spec.Field,
)
}
s.requested = uniqueItems(append(s.requested, evidence.items...))
}
if strings.TrimSpace(stableID(body["uuid"])) != "" {
s.hasIdempotencyKey = true
}
return nil
}
func (s *Session) ObserveResponse(_ map[string]any) {}
func (s *Session) RecordFact(f Fact) {
switch f.Kind {
case FactMediaPreuploadPerformed, FactWriteAttempted:
if s.hasFact(f.Kind) {
return
}
s.facts = append(s.facts, Fact{Kind: f.Kind})
case FactFlagFeedLayerPending:
s.facts = append(s.facts, Fact{Kind: f.Kind, Item: "feed"})
}
}
func (s *Session) hasFact(kind FactKind) bool {
for _, fact := range s.facts {
if fact.Kind == kind {
return true
}
}
return false
}
func (s *Session) FinalizeSuccess(data any) (Result, error) {
s.RecordFact(Fact{Kind: FactWriteAttempted})
switch s.contract.Strategy.Kind {
case AuthoritativeAckKind:
return Result{OK: true, Data: data}, nil
case RequiredResultKind:
if !requiredResultPresent(data, s.contract.Strategy.Required) {
return Result{}, s.FinalizeError(invalidRequiredResult(requiredLabel(s.contract.Strategy.Required)))
}
return Result{OK: true, Data: data}, nil
case BatchPartialKind:
return finalizeBatch(s, data)
case RequiredResultBatchPartialKind:
result, err := finalizeBatch(s, data)
if err != nil {
return Result{}, err
}
if !result.OK {
return result, nil
}
if !requiredResultPresent(data, s.contract.Strategy.Required) {
return Result{}, s.FinalizeError(invalidRequiredResult(requiredLabel(s.contract.Strategy.Required)))
}
return result, nil
case ResponseSetAssertionKind:
return finalizeAssertion(s, data)
case AcceptanceOnlyKind:
m, err := checkedResponse(data)
if err != nil {
return Result{}, err
}
m["completion"] = map[string]any{
"status": "accepted_unverified",
"final_state_verified": false,
"retry_scope": "none",
}
return Result{OK: true, Data: m}, nil
default:
return Result{}, errs.NewInternalError(
errs.SubtypeInvalidResponse,
"unsupported IM write contract strategy %q",
s.contract.Strategy.Kind,
)
}
}
func requiredLabel(spec requiredSpec) string {
if spec.Child == "" {
return spec.Field
}
return spec.Field + "/" + spec.Child
}
func (s *Session) FinalizeError(err error) error {
problem, ok := errs.ProblemOf(err)
if !ok {
return err
}
transient := problem.Category == errs.CategoryNetwork ||
(problem.Category == errs.CategoryAPI && problem.Retryable)
if !transient && problem.Subtype != errs.SubtypeInvalidResponse {
return err
}
if !s.hasFact(FactWriteAttempted) {
return err
}
var evidenceErr *invalidEvidenceError
if errors.As(err, &evidenceErr) {
problem.Retryable = false
problem.Hint = hintUnsafeEvidence
return err
}
mode := s.contract.ReplayMode
if s.hasFact(FactMediaPreuploadPerformed) {
mode = ReplayForbidden
}
switch mode {
case ReplaySafe:
problem.Retryable = true
problem.Hint = hintReplaySafe
case ReplaySameIdempotencyKey:
if s.hasIdempotencyKey {
problem.Retryable = true
problem.Hint = hintSameKey
return err
}
fallthrough
default:
problem.Retryable = false
problem.Hint = hintReplayForbidden
}
return err
}

View File

@@ -1,76 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
// Package imcontract evaluates IM command completion evidence.
package imcontract
import "github.com/larksuite/cli/internal/imcontract/catalog"
type ContractKey = catalog.ContractKey
type StrategyKind = catalog.StrategyKind
type ReplayMode = catalog.ReplayMode
type PartialRecoveryMode = catalog.PartialRecoveryMode
type AssertionMode = catalog.AssertionMode
type Strategy = catalog.Strategy
type HelpPolicy = catalog.HelpPolicy
type Contract = catalog.Contract
type requiredSpec = catalog.RequiredSpec
type evidenceSpec = catalog.EvidenceSpec
const (
EntityReadKind = catalog.EntityReadKind
CollectionReadKind = catalog.CollectionReadKind
SearchReadKind = catalog.SearchReadKind
MaterializeReadKind = catalog.MaterializeReadKind
AuthoritativeAckKind = catalog.AuthoritativeAckKind
RequiredResultKind = catalog.RequiredResultKind
BatchPartialKind = catalog.BatchPartialKind
RequiredResultBatchPartialKind = catalog.RequiredResultBatchPartialKind
ResponseSetAssertionKind = catalog.ResponseSetAssertionKind
AcceptanceOnlyKind = catalog.AcceptanceOnlyKind
ReplayForbidden = catalog.ReplayForbidden
ReplaySafe = catalog.ReplaySafe
ReplaySameIdempotencyKey = catalog.ReplaySameIdempotencyKey
PartialRecoveryWholeRequest = catalog.PartialRecoveryWholeRequest
PartialRecoveryFailedItemsOnly = catalog.PartialRecoveryFailedItemsOnly
AssertRequestedPresent = catalog.AssertRequestedPresent
AssertRequestedAbsent = catalog.AssertRequestedAbsent
requiredTopString = catalog.RequiredTopString
requiredTopObject = catalog.RequiredTopObject
requiredNestedString = catalog.RequiredNestedString
evidenceStrings = catalog.EvidenceStrings
evidenceObjects = catalog.EvidenceObjects
evidenceNestedObjects = catalog.EvidenceNestedObjects
evidenceFeedObjects = catalog.EvidenceFeedObjects
evidenceNestedFeedObjects = catalog.EvidenceNestedFeedObjects
evidenceStatusObjects = catalog.EvidenceStatusObjects
HelpCompleteness = catalog.HelpCompleteness
HelpAcceptanceOnly = catalog.HelpAcceptanceOnly
)
type FactKind string
const (
FactMediaPreuploadPerformed FactKind = "media_preupload_performed"
FactFlagFeedLayerPending FactKind = "flag_feed_layer_pending"
FactWriteAttempted FactKind = "write_attempted"
)
type Fact struct {
Kind FactKind
Item string
}
type Result struct {
OK bool
Data any
Hint string
ExitCode int
}

View File

@@ -1,199 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"fmt"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
)
const (
hintReplayForbidden = "The write result is unknown. Do not replay the original request."
hintReplaySafe = "The write result is unknown. Retrying the original request is safe."
hintSameKey = "The write result is unknown. Retry only with the same idempotency key."
hintUnsafeEvidence = "The server response could not be safely mapped to the original request. Do not retry the write based on this response."
)
func invalidRequiredResult(field string) error {
return errs.NewInternalError(errs.SubtypeInvalidResponse,
"successful response is missing required field %q", field)
}
type invalidEvidenceError struct {
cause error
}
func (e *invalidEvidenceError) Error() string {
return e.cause.Error()
}
func (e *invalidEvidenceError) Unwrap() error {
return e.cause
}
func invalidEvidence(field string) error {
return &invalidEvidenceError{
cause: errs.NewInternalError(
errs.SubtypeInvalidResponse,
"response evidence in %q cannot be mapped to the original request",
field,
).WithHint(hintUnsafeEvidence),
}
}
func requiredResultPresent(data any, spec requiredSpec) bool {
root, ok := data.(map[string]any)
if !ok {
return false
}
switch spec.Shape {
case requiredTopString:
return nonEmptyString(root[spec.Field]) != ""
case requiredTopObject:
object, ok := root[spec.Field].(map[string]any)
return ok && len(object) > 0
case requiredNestedString:
object, ok := root[spec.Field].(map[string]any)
return ok && nonEmptyString(object[spec.Child]) != ""
default:
return false
}
}
func checkedResponse(data any) (map[string]any, error) {
root, ok := data.(map[string]any)
if !ok {
return nil, invalidEvidence("response")
}
return root, nil
}
func validateEvidence(result extraction, requested []ledgerItem, field string, requireRequested bool) error {
if !result.present {
return nil
}
if result.rejectedCount != 0 ||
result.rawCount != result.selectedCount+result.rejectedCount {
return invalidEvidence(field)
}
if !requireRequested {
return nil
}
requestedSet := make(map[string]struct{}, len(requested))
for _, item := range requested {
requestedSet[item.key] = struct{}{}
}
for _, item := range result.items {
if _, ok := requestedSet[item.key]; !ok {
return invalidEvidence(field)
}
}
return nil
}
func finalizeBatch(s *Session, data any) (Result, error) {
root, err := checkedResponse(data)
if err != nil {
return Result{}, err
}
requested := append([]ledgerItem{}, s.requested...)
failed := make([]ledgerItem, 0)
for _, spec := range s.contract.Strategy.Failures {
evidence := extract(root, spec)
if err := validateEvidence(evidence, requested, spec.Field, true); err != nil {
return Result{}, err
}
failed = append(failed, evidence.items...)
}
responsePending := make([]ledgerItem, 0)
for _, spec := range s.contract.Strategy.Pending {
evidence := extract(root, spec)
if err := validateEvidence(evidence, requested, spec.Field, true); err != nil {
return Result{}, err
}
responsePending = append(responsePending, evidence.items...)
}
syntheticPending := make([]ledgerItem, 0)
if s.hasFact(FactFlagFeedLayerPending) {
syntheticPending = append(syntheticPending, ledgerItem{key: "feed", value: "feed"})
}
if spec := s.contract.Strategy.ResultLedger; spec != nil {
evidence := extract(root, *spec)
if err := validateEvidence(evidence, nil, spec.Field, false); err != nil {
return Result{}, err
}
requested = append(requested, evidence.items...)
failed = append(failed, statusFailures(root, *spec)...)
}
// Response pending can only classify an original request. Synthetic pending
// represents a logical sub-request performed by a shortcut.
requested = append(requested, syntheticPending...)
pending := append(responsePending, syntheticPending...)
ledger := completion(requested, failed, pending, s.contract.PartialRecovery)
root["completion"] = ledger
result := Result{OK: ledger.Status == "complete", Data: root}
if !result.OK {
result.ExitCode = output.ExitAPI
}
return result, nil
}
func statusFailures(root map[string]any, spec evidenceSpec) []ledgerItem {
values, _ := root[spec.Field].([]any)
failed := make([]ledgerItem, 0)
for _, value := range values {
object, _ := value.(map[string]any)
if fmt.Sprint(object["status"]) != "failed" {
continue
}
item, ok := stringItem(object[spec.IDField])
if ok {
failed = append(failed, item)
}
}
return failed
}
func finalizeAssertion(s *Session, data any) (Result, error) {
root, err := checkedResponse(data)
if err != nil {
return Result{}, err
}
actual := make(map[string]struct{})
responseSetPresent := false
for _, spec := range s.contract.Strategy.ResponseSets {
evidence := extract(root, spec)
if err := validateEvidence(evidence, nil, spec.Field, false); err != nil {
return Result{}, err
}
responseSetPresent = responseSetPresent || evidence.present
for _, item := range evidence.items {
actual[item.key] = struct{}{}
}
}
if !responseSetPresent {
return Result{}, invalidEvidence("response_sets")
}
failed := make([]ledgerItem, 0)
for _, item := range s.requested {
_, exists := actual[item.key]
if (s.contract.Strategy.Assertion == AssertRequestedPresent && !exists) ||
(s.contract.Strategy.Assertion == AssertRequestedAbsent && exists) {
failed = append(failed, item)
}
}
ledger := completion(s.requested, failed, nil, PartialRecoveryFailedItemsOnly)
root["completion"] = ledger
result := Result{OK: ledger.Status == "complete", Data: root}
if !result.OK {
result.ExitCode = output.ExitAPI
}
return result, nil
}

View File

@@ -1,547 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package imcontract
import (
"encoding/json"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
)
func TestRequiredResult(t *testing.T) {
c, _ := Lookup("im +messages-send")
for _, data := range []map[string]any{{}, {"message_id": ""}} {
s := NewSession(c)
_, err := s.FinalizeSuccess(data)
if err == nil {
t.Fatalf("expected missing result error for %#v", data)
}
p, _ := errs.ProblemOf(err)
if p.Category != errs.CategoryInternal || p.Subtype != errs.SubtypeInvalidResponse {
t.Fatalf("problem = %#v", p)
}
if output.ExitCodeOf(err) != output.ExitInternal {
t.Fatalf("exit = %d", output.ExitCodeOf(err))
}
}
s := NewSession(c)
got, err := s.FinalizeSuccess(map[string]any{"message_id": "om_x"})
if err != nil || !got.OK {
t.Fatalf("valid result rejected: %#v %v", got, err)
}
}
func TestBatchPartialLedger(t *testing.T) {
c, _ := Lookup("im messages urgent_app")
s := NewSession(c)
s.ObserveRequest(map[string]any{"user_id_list": []any{"ou_a", "ou_b"}})
got, err := s.FinalizeSuccess(map[string]any{"invalid_user_id_list": []any{"ou_b"}})
if err != nil {
t.Fatal(err)
}
if got.OK || got.ExitCode != output.ExitAPI {
t.Fatalf("result = %#v", got)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if completion.Status != "partial" || completion.SucceededCount != 1 || completion.FailedCount != 1 {
t.Fatalf("completion = %#v", completion)
}
if len(completion.FailedItems) != 1 || completion.FailedItems[0] != "ou_b" {
t.Fatalf("failed items = %#v", completion.FailedItems)
}
}
func TestBatchPendingIsNotCountedAsSucceeded(t *testing.T) {
c, _ := Lookup("im chat.members create")
s := NewSession(c)
s.ObserveRequest(map[string]any{"id_list": []any{"ou_a", "ou_b"}})
got, err := s.FinalizeSuccess(map[string]any{"pending_approval_id_list": []any{"ou_b"}})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if completion.SucceededCount != 1 || completion.PendingCount != 1 || completion.RetryScope != "none" {
t.Fatalf("completion = %#v", completion)
}
}
func TestResponsePendingCannotExpandRequestedLedger(t *testing.T) {
c, _ := Lookup("im chat.members create")
s := NewSession(c)
s.ObserveRequest(map[string]any{
"id_list": []any{"ou_a", "ou_b"},
})
got, err := s.FinalizeSuccess(map[string]any{
"pending_approval_id_list": []any{"ou_unknown"},
})
if err == nil {
t.Fatalf("unknown response pending was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
}
func TestSyntheticFlagPendingExpandsLogicalRequest(t *testing.T) {
c, _ := Lookup("im +flag-cancel")
s := NewSession(c)
s.RecordFact(Fact{Kind: FactFlagFeedLayerPending})
got, err := s.FinalizeSuccess(map[string]any{"results": []any{
map[string]any{"flag_type": "message", "status": "ok"},
}})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if completion.RequestedCount != 2 || completion.SucceededCount != 1 ||
completion.FailedCount != 0 || completion.PendingCount != 1 ||
len(completion.PendingItems) != 1 || completion.PendingItems[0] != "feed" {
t.Fatalf("synthetic pending did not expand logical request: %#v", completion)
}
}
func TestRequiredResultBatchPartialPrioritizesLedger(t *testing.T) {
c, _ := Lookup("im messages merge_forward")
s := NewSession(c)
s.ObserveRequest(map[string]any{"message_id_list": []any{"om_a", "om_b"}})
got, err := s.FinalizeSuccess(map[string]any{"invalid_message_id_list": []any{"om_b"}})
if err != nil || got.OK || got.ExitCode != output.ExitAPI {
t.Fatalf("partial result = %#v, err=%v", got, err)
}
s = NewSession(c)
s.ObserveRequest(map[string]any{"message_id_list": []any{"om_a"}})
_, err = s.FinalizeSuccess(map[string]any{})
if err == nil {
t.Fatal("missing merged message_id must fail when no partial result exists")
}
}
func TestManagerResponseSetAssertions(t *testing.T) {
for _, tc := range []struct {
key ContractKey
response map[string]any
wantOK bool
}{
{"im chat.managers add_managers", map[string]any{"chat_managers": []any{"ou_a"}}, true},
{"im chat.managers add_managers", map[string]any{"chat_managers": []any{}}, false},
{"im chat.managers delete_managers", map[string]any{"chat_managers": []any{}}, true},
{"im chat.managers delete_managers", map[string]any{"chat_managers": []any{"ou_a"}}, false},
} {
c, _ := Lookup(tc.key)
s := NewSession(c)
s.ObserveRequest(map[string]any{"manager_ids": []any{"ou_a"}})
got, err := s.FinalizeSuccess(tc.response)
if err != nil || got.OK != tc.wantOK {
t.Errorf("%s response=%v: got %#v, err=%v", tc.key, tc.response, got, err)
}
}
}
func TestManagerResponseSetAssertionsRequirePresentEvidence(t *testing.T) {
for _, key := range []ContractKey{
"im chat.managers add_managers",
"im chat.managers delete_managers",
} {
t.Run(string(key), func(t *testing.T) {
c, _ := Lookup(key)
s := NewSession(c)
s.ObserveRequest(map[string]any{"manager_ids": []any{"ou_a"}})
got, err := s.FinalizeSuccess(map[string]any{})
if err == nil {
t.Fatalf("missing response sets were accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
})
}
}
func TestModerationAcceptedUnverified(t *testing.T) {
c, _ := Lookup("im chat.moderation update")
got, err := NewSession(c).FinalizeSuccess(map[string]any{})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(map[string]any)
if completion["status"] != "accepted_unverified" || completion["final_state_verified"] != false {
t.Fatalf("completion = %#v", completion)
}
if got.Hint != "" {
t.Fatalf("hint = %q", got.Hint)
}
}
func TestReplaySafety(t *testing.T) {
unknown := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithHint("untrusted upstream hint")
c, _ := Lookup("im +messages-send")
s := NewSession(c)
s.ObserveRequest(map[string]any{"uuid": "stable-key"})
s.RecordFact(Fact{Kind: FactWriteAttempted})
got := s.FinalizeError(unknown)
p, _ := errs.ProblemOf(got)
if !p.Retryable || p.Hint != hintSameKey {
t.Fatalf("same-key problem = %#v", p)
}
unknown = errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithHint("untrusted upstream hint")
s = NewSession(c)
s.ObserveRequest(map[string]any{"uuid": "stable-key"})
s.RecordFact(Fact{Kind: FactWriteAttempted})
s.RecordFact(Fact{Kind: FactMediaPreuploadPerformed})
got = s.FinalizeError(unknown)
p, _ = errs.ProblemOf(got)
if p.Retryable || p.Hint != hintReplayForbidden {
t.Fatalf("preupload problem = %#v", p)
}
validation := errs.NewValidationError(errs.SubtypeInvalidArgument, "bad flag")
got = NewSession(c).FinalizeError(validation)
p, _ = errs.ProblemOf(got)
if p.Retryable || p.Hint != "" {
t.Fatalf("validation problem was broadened: %#v", p)
}
unknown = errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithHint("untrusted upstream hint")
c, _ = Lookup("im +feed-shortcut-create")
s = NewSession(c)
s.RecordFact(Fact{Kind: FactWriteAttempted})
got = s.FinalizeError(unknown)
p, _ = errs.ProblemOf(got)
if !p.Retryable || p.Hint != hintReplaySafe {
t.Fatalf("safe replay problem = %#v", p)
}
preflight := errs.NewNetworkError(errs.SubtypeNetworkTransport, "lookup failed").
WithRetryable().
WithHint("specify --item-type explicitly")
c, _ = Lookup("im +flag-create")
got = NewSession(c).FinalizeError(preflight)
p, _ = errs.ProblemOf(got)
if !p.Retryable || p.Hint != "specify --item-type explicitly" {
t.Fatalf("preflight problem was rewritten: %#v", p)
}
}
func TestBatchPartialRecoveryMatrix(t *testing.T) {
tests := []struct {
name string
command ContractKey
request map[string]any
response map[string]any
fact *Fact
wantScope string
}{
{
name: "pending always forbids retry",
command: "im +flag-cancel",
response: map[string]any{"results": []any{
map[string]any{"flag_type": "message", "status": "ok"},
}},
fact: &Fact{Kind: FactFlagFeedLayerPending},
wantScope: "none",
},
{
name: "whole request recovery",
command: "im +feed-shortcut-create",
request: map[string]any{"shortcuts": []any{
map[string]any{"feed_card_id": "oc_a"},
}},
response: map[string]any{"failed_shortcuts": []any{
map[string]any{"shortcut": map[string]any{"feed_card_id": "oc_a"}},
}},
wantScope: "whole_request",
},
{
name: "failed items only recovery",
command: "im messages urgent_app",
request: map[string]any{"user_id_list": []any{"ou_a", "ou_b"}},
response: map[string]any{"invalid_user_id_list": []any{"ou_b"}},
wantScope: "failed_items_only",
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
contract, _ := Lookup(tc.command)
session := NewSession(contract)
if tc.request != nil {
if err := session.ObserveRequest(tc.request); err != nil {
t.Fatal(err)
}
}
if tc.fact != nil {
session.RecordFact(*tc.fact)
}
result, err := session.FinalizeSuccess(tc.response)
if err != nil {
t.Fatal(err)
}
completion := result.Data.(map[string]any)["completion"].(Completion)
if completion.RetryScope != tc.wantScope || result.Hint != "" {
t.Fatalf("completion=%#v hint=%q", completion, result.Hint)
}
})
}
}
func TestBatchRejectsUnmappableFailureEvidence(t *testing.T) {
for _, tc := range []struct {
name string
command ContractKey
request map[string]any
response map[string]any
}{
{
name: "all IDs missing",
command: "im chat.members create",
request: map[string]any{"id_list": []any{"ou_a"}},
response: map[string]any{"invalid_id_list": []any{map[string]any{"reason": "bad"}}},
},
{
name: "one ID missing",
command: "im chat.members create",
request: map[string]any{"id_list": []any{"ou_a", "ou_b"}},
response: map[string]any{"invalid_id_list": []any{
"ou_a", map[string]any{"reason": "bad"},
}},
},
{
name: "stable ID outside request",
command: "im chat.members create",
request: map[string]any{"id_list": []any{"ou_a"}},
response: map[string]any{"invalid_id_list": []any{"ou_unknown"}},
},
{
name: "compound feed ID missing",
command: "im feed.groups batch_add_item",
request: map[string]any{"items": []any{
map[string]any{"feed_id": "oc_a", "feed_type": "chat"},
}},
response: map[string]any{"failed_items": []any{
map[string]any{"item": map[string]any{"feed_type": "chat"}},
}},
},
{
name: "compound feed type missing",
command: "im feed.groups batch_add_item",
request: map[string]any{"items": []any{
map[string]any{"feed_id": "oc_a", "feed_type": "chat"},
}},
response: map[string]any{"failed_items": []any{
map[string]any{"item": map[string]any{"feed_id": "oc_a"}},
}},
},
} {
t.Run(tc.name, func(t *testing.T) {
c, _ := Lookup(tc.command)
s := NewSession(c)
s.ObserveRequest(tc.request)
got, err := s.FinalizeSuccess(tc.response)
if err == nil {
t.Fatalf("unmappable response was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
})
}
}
func TestAssertionRejectsUnmappableResponseEvidence(t *testing.T) {
c, _ := Lookup("im chat.managers add_managers")
s := NewSession(c)
s.ObserveRequest(map[string]any{"manager_ids": []any{"ou_a"}})
got, err := s.FinalizeSuccess(map[string]any{
"chat_managers": []any{map[string]any{"name": "missing ID"}},
})
if err == nil {
t.Fatalf("unmappable assertion response was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
}
func TestRequestEvidenceFailsClosedOnUnsupportedShapes(t *testing.T) {
c, _ := Lookup("im chat.members create")
for _, tc := range []struct {
name string
body map[string]any
}{
{name: "non-map body reaches contract as nil", body: nil},
{name: "missing collection", body: map[string]any{}},
{name: "wrong collection type", body: map[string]any{"id_list": []string{"ou_a"}}},
{name: "unmappable item", body: map[string]any{"id_list": []any{map[int]any{1: "ou_a"}}}},
} {
t.Run(tc.name, func(t *testing.T) {
err := NewSession(c).ObserveRequest(tc.body)
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryValidation ||
problem.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("request evidence error = %#v, ok=%v", problem, ok)
}
})
}
}
func TestExtractionAccounting(t *testing.T) {
got := extract(map[string]any{
"ids": []any{"ou_a", map[string]any{"missing": "id"}, "ou_a"},
}, stringsFrom("ids"))
if !got.present || got.rawCount != 3 || got.selectedCount != 2 ||
got.rejectedCount != 1 || len(got.items) != 1 {
t.Fatalf("extraction = %#v", got)
}
got = extract(map[string]any{"ids": []string{"ou_a"}}, stringsFrom("ids"))
if !got.present || got.rawCount != 0 || got.selectedCount != 0 ||
got.rejectedCount != 1 || len(got.items) != 0 {
t.Fatalf("wrong-shape extraction = %#v", got)
}
}
func TestStatusLedgerRejectsUnknownStatus(t *testing.T) {
c, _ := Lookup("im +flag-cancel")
got, err := NewSession(c).FinalizeSuccess(map[string]any{"results": []any{
map[string]any{"flag_type": "message", "status": "maybe"},
}})
if err == nil {
t.Fatalf("unknown result status was accepted: %#v", got)
}
assertUnsafeEvidenceError(t, err)
}
func TestUnsafeEvidenceRemainsForbiddenAcrossFinalizeError(t *testing.T) {
c, _ := Lookup("im +feed-shortcut-create")
s := NewSession(c)
if err := s.ObserveRequest(map[string]any{"shortcuts": []any{
map[string]any{"feed_card_id": "oc_a"},
}}); err != nil {
t.Fatal(err)
}
_, err := s.FinalizeSuccess(map[string]any{"failed_shortcuts": []any{
map[string]any{"shortcut": map[string]any{"missing": "feed_card_id"}},
}})
if err == nil {
t.Fatal("malformed evidence was accepted")
}
for i := 0; i < 2; i++ {
err = s.FinalizeError(err)
assertUnsafeEvidenceError(t, err)
}
}
func assertUnsafeEvidenceError(t *testing.T, err error) {
t.Helper()
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryInternal ||
problem.Subtype != errs.SubtypeInvalidResponse ||
problem.Retryable || problem.Hint != hintUnsafeEvidence {
t.Fatalf("unsafe evidence error = %#v, ok=%v", problem, ok)
}
if output.ExitCodeOf(err) != output.ExitInternal {
t.Fatalf("unsafe evidence exit = %d", output.ExitCodeOf(err))
}
}
func TestLedgerSelectorDoesNotCopySecrets(t *testing.T) {
c, _ := Lookup("im chat.members create")
s := NewSession(c)
s.ObserveRequest(map[string]any{
"id_list": []any{"ou_a"},
"content": "secret body",
"phone": "123",
"idempotency_key": "secret-key",
"access_token": "token",
"next_page_token": "page",
})
got, err := s.FinalizeSuccess(map[string]any{"invalid_id_list": []any{"ou_a"}})
if err != nil {
t.Fatal(err)
}
completion := got.Data.(map[string]any)["completion"].(Completion)
if len(completion.FailedItems) != 1 || completion.FailedItems[0] != "ou_a" {
t.Fatalf("completion leaked or lost selector: %#v", completion)
}
}
func TestFeedLedgerKeepsOnlyRetryableIdentityFields(t *testing.T) {
c, _ := Lookup("im feed.groups batch_add_item")
s := NewSession(c)
s.ObserveRequest(map[string]any{"items": []any{
map[string]any{"feed_id": "oc_a", "feed_type": "chat", "content": "secret"},
}})
got, err := s.FinalizeSuccess(map[string]any{"failed_items": []any{
map[string]any{"item": map[string]any{"feed_id": "oc_a", "feed_type": "chat"}, "error_message": "server text"},
}})
if err != nil {
t.Fatal(err)
}
item := got.Data.(map[string]any)["completion"].(Completion).FailedItems[0].(map[string]any)
if len(item) != 2 || item["feed_id"] != "oc_a" || item["feed_type"] != "chat" {
t.Fatalf("failed item = %#v", item)
}
}
func TestCompletionIsClosedOverRequestedItems(t *testing.T) {
simple := func(id string) ledgerItem { return ledgerItem{key: id, value: id} }
compound := func(feedType, feedID string) ledgerItem {
return ledgerItem{
key: feedType + "\x00" + feedID,
value: map[string]any{
"feed_id": feedID, "feed_type": feedType,
},
}
}
for _, tc := range []struct {
name string
requested []ledgerItem
failed []ledgerItem
pending []ledgerItem
}{
{
name: "single IDs",
requested: []ledgerItem{simple("a"), simple("b"), simple("c"), simple("a")},
failed: []ledgerItem{simple("b"), simple("c"), simple("c"), simple("unknown")},
pending: []ledgerItem{simple("b"), simple("b"), simple("pending-unknown")},
},
{
name: "compound IDs",
requested: []ledgerItem{
compound("chat", "oc_a"), compound("doc", "doc_b"), compound("chat", "oc_a"),
},
failed: []ledgerItem{
compound("chat", "oc_a"), compound("chat", "oc_a"), compound("chat", "oc_unknown"),
compound("doc", "doc_b"),
},
pending: []ledgerItem{
compound("doc", "doc_b"), compound("doc", "doc_b"), compound("doc", "doc_unknown"),
},
},
} {
t.Run(tc.name, func(t *testing.T) {
got := completion(tc.requested, tc.failed, tc.pending, PartialRecoveryFailedItemsOnly)
if got.RequestedCount != got.SucceededCount+got.FailedCount+got.PendingCount {
t.Fatalf("non-exclusive counts: %#v", got)
}
if got.FailedCount != 1 || got.PendingCount != 1 {
t.Fatalf("failed/pending overlap was not resolved: %#v", got)
}
raw, err := json.Marshal(got)
if err != nil {
t.Fatal(err)
}
if strings.Contains(string(raw), "unknown") {
t.Fatalf("unrequested response item entered retry ledger: %s", raw)
}
})
}
}
func TestWriteSessionUnknownStrategyFailsClosed(t *testing.T) {
session := NewSession(Contract{
Key: "im future write",
Strategy: Strategy{Kind: StrategyKind("future_write")},
})
_, err := session.FinalizeSuccess(map[string]any{"accepted": true})
if err == nil || !errs.IsInternal(err) {
t.Fatalf("expected typed internal error, got %v", err)
}
}

View File

@@ -45,13 +45,10 @@ type EmitterConfig struct {
type EmitOptions struct {
Raw bool
Meta *Meta
Error interface{}
Hint string
Format string
JQ string
DryRun bool
Pretty PrettyRenderer
HintToStderr bool
JQSafetyWarning bool
}
@@ -104,23 +101,18 @@ func (e *Emitter) Success(data interface{}, opts EmitOptions) error {
return err
}
var err error
if opts.JQ != "" {
err = e.emitEnvelope(data, true, opts)
} else {
switch opts.Format {
case "", "json":
err = e.emitEnvelope(data, true, opts)
case "pretty":
err = e.emitPretty(data, opts)
default:
err = e.emitFormatted(data, opts.Format)
}
return e.emitEnvelope(data, true, opts)
}
if err != nil {
return err
switch opts.Format {
case "", "json":
return e.emitEnvelope(data, true, opts)
case "pretty":
return e.emitPretty(data, opts)
default:
return e.emitFormatted(data, opts.Format)
}
return e.emitHint(opts)
}
// PartialFailure emits a multi-status result whose envelope honestly reports
@@ -133,10 +125,7 @@ func (e *Emitter) PartialFailure(data interface{}, opts EmitOptions) error {
if err := e.requireOutput(); err != nil {
return err
}
if err := e.emitEnvelope(data, false, opts); err != nil {
return err
}
return e.emitHint(opts)
return e.emitEnvelope(data, false, opts)
}
// StreamPage scans and emits one page while retaining table/csv columns from
@@ -189,12 +178,6 @@ func (e *Emitter) StreamPage(data interface{}, opts StreamOptions) error {
})
}
// Hint writes recovery guidance to stderr through the same command-scoped
// output owner used for result emission.
func (e *Emitter) Hint(hint string) error {
return e.emitHint(EmitOptions{Hint: hint, HintToStderr: true})
}
func (e *Emitter) emitEnvelope(data interface{}, ok bool, opts EmitOptions) error {
scanResult := ScanForSafety(e.commandPath, data, e.errOut)
if scanResult.Blocked {
@@ -207,8 +190,6 @@ func (e *Emitter) emitEnvelope(data interface{}, ok bool, opts EmitOptions) erro
DryRun: opts.DryRun,
Data: data,
Meta: opts.Meta,
Error: opts.Error,
Hint: opts.Hint,
Notice: e.notice(),
}
if scanResult.Alert != nil {
@@ -335,16 +316,6 @@ func (e *Emitter) emit(render func(io.Writer) error) error {
return nil
}
func (e *Emitter) emitHint(opts EmitOptions) error {
if !opts.HintToStderr || opts.Hint == "" {
return nil
}
if _, err := fmt.Fprintf(e.errOut, "hint: %s\n", opts.Hint); err != nil {
return wrapOutputError("write", err)
}
return nil
}
func wrapOutputError(op string, err error) error {
return errs.NewInternalError(errs.SubtypeUnknown, "failed to %s command output", op).WithCause(err)
}

View File

@@ -63,92 +63,6 @@ func TestEmitterSuccessWritesAllBytes(t *testing.T) {
}
}
func TestEmitterPartialFailureCarriesContractFields(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}
complete := false
emitter := output.NewEmitter(output.EmitterConfig{
Out: stdout,
ErrOut: io.Discard,
CommandPath: "lark-cli im fixture",
Identity: "bot",
})
problem := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed")
err := emitter.PartialFailure(
map[string]interface{}{"items": []interface{}{"kept"}},
output.EmitOptions{
Format: "json",
Meta: &output.Meta{
Complete: &complete,
PagesFetched: 1,
StopReason: "transport_error",
},
Error: problem,
Hint: "Retry the read.",
},
)
if err != nil {
t.Fatalf("Emitter.PartialFailure() error = %v", err)
}
var env output.Envelope
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatalf("decode envelope: %v", err)
}
if env.OK || env.Hint != "Retry the read." || env.Meta == nil ||
env.Meta.Complete == nil || *env.Meta.Complete {
t.Fatalf("envelope = %#v, want typed incomplete result", env)
}
if env.Error == nil {
t.Fatalf("envelope = %#v, want structured error", env)
}
}
func TestEmitterJQProjectsContractHint(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}
emitter := output.NewEmitter(output.EmitterConfig{
Out: stdout,
ErrOut: io.Discard,
CommandPath: "lark-cli im fixture",
})
err := emitter.Success(map[string]interface{}{"id": "1"}, output.EmitOptions{
Format: "json",
JQ: ".hint",
Hint: "Use the same read entry point.",
})
if err != nil {
t.Fatalf("Emitter.Success() error = %v", err)
}
if got := strings.TrimSpace(stdout.String()); got != "Use the same read entry point." {
t.Fatalf("stdout = %q", got)
}
}
func TestEmitterNakedFormatWritesHintToStderr(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}
stderr := &bytes.Buffer{}
emitter := output.NewEmitter(output.EmitterConfig{
Out: stdout,
ErrOut: stderr,
CommandPath: "lark-cli im fixture",
})
err := emitter.Success([]interface{}{map[string]interface{}{"id": "1"}}, output.EmitOptions{
Format: "table",
Hint: "Result is incomplete.",
HintToStderr: true,
})
if err != nil {
t.Fatalf("Emitter.Success() error = %v", err)
}
if !strings.Contains(stderr.String(), "hint: Result is incomplete.") {
t.Fatalf("stderr = %q", stderr.String())
}
}
func TestEmitterMarshalFailureReturnsTypedErrorWithoutOutput(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONTENT_SAFETY_MODE", "off")
stdout := &bytes.Buffer{}

View File

@@ -10,20 +10,14 @@ type Envelope struct {
DryRun bool `json:"dry_run,omitempty"`
Data interface{} `json:"data,omitempty"`
Meta *Meta `json:"meta,omitempty"`
Error interface{} `json:"error,omitempty"`
Hint string `json:"hint,omitempty"`
ContentSafetyAlert interface{} `json:"_content_safety_alert,omitempty"`
Notice map[string]interface{} `json:"_notice,omitempty"`
}
// Meta carries optional metadata in envelope responses.
type Meta struct {
Count int `json:"count,omitempty"`
Rollback string `json:"rollback,omitempty"`
Complete *bool `json:"complete,omitempty"`
PagesFetched int `json:"pages_fetched,omitempty"`
StopReason string `json:"stop_reason,omitempty"`
NextPageToken string `json:"next_page_token,omitempty"`
Count int `json:"count,omitempty"`
Rollback string `json:"rollback,omitempty"`
}
// PendingNotice, if set, returns system-level notices to inject as the

View File

@@ -48,41 +48,3 @@ func WriteSuccessEnvelope(data interface{}, opts SuccessEnvelopeOptions) error {
JQSafetyWarning: true,
})
}
// WriteEnvelope emits a complete result envelope. It is used when a result
// needs to carry business data and a machine-readable completion/error state
// in one stdout document.
func WriteEnvelope(env Envelope, opts SuccessEnvelopeOptions) error {
identity := env.Identity
if identity == "" {
identity = opts.Identity
}
noticeProvider := GetNotice
if env.Notice != nil {
notice := env.Notice
noticeProvider = func() map[string]interface{} {
return notice
}
}
emitter := NewEmitter(EmitterConfig{
Out: opts.Out,
ErrOut: opts.ErrOut,
CommandPath: opts.CommandPath,
Identity: identity,
NoticeProvider: noticeProvider,
})
emitOpts := EmitOptions{
Format: "",
Raw: false,
JQ: opts.JqExpr,
DryRun: env.DryRun || opts.DryRun,
Meta: env.Meta,
Error: env.Error,
Hint: env.Hint,
JQSafetyWarning: true,
}
if env.OK {
return emitter.Success(env.Data, emitOpts)
}
return emitter.PartialFailure(env.Data, emitOpts)
}

View File

@@ -212,38 +212,3 @@ func TestWriteSuccessEnvelope_BlockModeReturnsTypedErrorWithoutStdout(t *testing
t.Fatalf("stdout should stay empty on block, got: %s", out.String())
}
}
func TestEnvelopeCompleteSerializesFalse(t *testing.T) {
complete := false
raw, err := json.Marshal(Envelope{OK: true, Meta: &Meta{Complete: &complete}})
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(raw), `"complete":false`) {
t.Fatalf("false completeness was omitted: %s", raw)
}
}
func TestWriteEnvelopeCarriesPartialResultAndTypedError(t *testing.T) {
var out strings.Builder
apiErr := errs.NewAPIError(errs.SubtypeUnknown, "one item failed")
err := WriteEnvelope(Envelope{
OK: false,
Data: map[string]any{"completion": map[string]any{"status": "partial"}},
Error: apiErr,
Hint: "retry only failed items",
}, SuccessEnvelopeOptions{Identity: "bot", Out: &out})
if err != nil {
t.Fatal(err)
}
var env map[string]any
if err := json.Unmarshal([]byte(out.String()), &env); err != nil {
t.Fatal(err)
}
if env["ok"] != false || env["hint"] != "retry only failed items" {
t.Fatalf("unexpected envelope: %#v", env)
}
if env["error"].(map[string]any)["type"] != "api" {
t.Fatalf("typed error missing: %#v", env)
}
}

View File

@@ -10,9 +10,7 @@ import (
"path/filepath"
"testing"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/rules"
)
func TestManifestExportWritesManifestAndCommandIndex(t *testing.T) {
@@ -47,16 +45,6 @@ func TestManifestExportWritesManifestAndCommandIndex(t *testing.T) {
}
}
func TestExportedCommandIndexMatchesIMContractCatalog(t *testing.T) {
index, err := collectCommandIndex(context.Background())
if err != nil {
t.Fatalf("collectCommandIndex() error = %v", err)
}
if diags := rules.CheckIMContractCoverage(index, imcatalog.All()); len(diags) != 0 {
t.Fatalf("exported IM contract diagnostics = %#v", diags)
}
}
func TestManifestExportRequiresOutputPaths(t *testing.T) {
var stderr bytes.Buffer
code := runManifestExport(nil, &stderr)

View File

@@ -1,86 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package rules
import (
"fmt"
"sort"
"strings"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/report"
)
const (
imContractCoverageRule = "im_contract_coverage"
expectedIMLeafCommands = 60
)
func CheckIMContractCoverage(commandIndex manifest.Manifest, contracts []imcatalog.Contract) []report.Diagnostic {
leafKeys := imLeafCommandKeys(commandIndex)
leafSet := make(map[string]struct{}, len(leafKeys))
for _, key := range leafKeys {
leafSet[key] = struct{}{}
}
contractSet := make(map[string]imcatalog.Contract, len(contracts))
for _, contract := range contracts {
contractSet[string(contract.Key)] = contract
}
var diags []report.Diagnostic
if len(leafKeys) != expectedIMLeafCommands {
diags = append(diags, imContractDiagnostic(
"",
fmt.Sprintf("IM leaf command count is %d, want %d", len(leafKeys), expectedIMLeafCommands),
))
}
for _, key := range leafKeys {
if _, ok := contractSet[key]; !ok {
diags = append(diags, imContractDiagnostic(key, "IM leaf command has no completion contract"))
}
}
for _, contract := range contracts {
key := string(contract.Key)
if _, ok := leafSet[key]; !ok {
diags = append(diags, imContractDiagnostic(key, "IM contract key does not match a runnable leaf command"))
}
}
return diags
}
func imLeafCommandKeys(commandIndex manifest.Manifest) []string {
var candidates []string
for _, cmd := range commandIndex.Commands {
if cmd.Domain == "im" && cmd.Runnable {
candidates = append(candidates, cmd.Path)
}
}
sort.Strings(candidates)
leaves := make([]string, 0, len(candidates))
for _, path := range candidates {
parent := false
for _, other := range candidates {
if other != path && strings.HasPrefix(other, path+" ") {
parent = true
break
}
}
if !parent {
leaves = append(leaves, path)
}
}
return leaves
}
func imContractDiagnostic(commandPath, message string) report.Diagnostic {
return report.Diagnostic{
Rule: imContractCoverageRule,
Action: report.ActionReject,
File: "command-index",
Message: message,
SubjectType: "command",
CommandPath: commandPath,
}
}

View File

@@ -1,92 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package rules
import (
"fmt"
"strings"
"testing"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
qdiff "github.com/larksuite/cli/internal/qualitygate/diff"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/report"
)
func TestIMLeafCommandsExcludeParentsAndOtherDomains(t *testing.T) {
index := manifest.Manifest{Commands: []manifest.Command{
{Path: "im chat", Domain: "im", Runnable: true},
{Path: "im chat get", Domain: "im", Runnable: true},
{Path: "im chat list", Domain: "im", Runnable: false},
{Path: "docs chat get", Domain: "docs", Runnable: true},
}}
got := imLeafCommandKeys(index)
if len(got) != 1 || got[0] != "im chat get" {
t.Fatalf("IM leaves = %#v, want only runnable child", got)
}
}
func TestIMContractCoverageReportsMissingAndStaleKeys(t *testing.T) {
index, contracts := completeIMCoverageFixture()
contracts = contracts[1:]
contracts = append(contracts, imcatalog.Contract{
Key: "im stale command", Strategy: imcatalog.Strategy{Kind: imcatalog.EntityReadKind},
})
diags := CheckIMContractCoverage(index, contracts)
if !hasIMContractDiagnostic(diags, "im resource command00", "no completion contract") {
t.Fatalf("missing-command diagnostic absent: %#v", diags)
}
if !hasIMContractDiagnostic(diags, "im stale command", "does not match") {
t.Fatalf("stale-key diagnostic absent: %#v", diags)
}
}
func TestIMContractCoverageReportsMissingIMDomain(t *testing.T) {
index := manifest.Manifest{Commands: []manifest.Command{
{Path: "docs +fetch", Domain: "docs", Runnable: true},
}}
if leaves := imLeafCommandKeys(index); len(leaves) != 0 {
t.Fatalf("IM leaves = %#v, want none", leaves)
}
diags := CheckIMContractCoverage(index, imcatalog.All())
if !hasIMContractDiagnostic(diags, "", "IM leaf command count is 0, want 60") {
t.Fatalf("missing-domain diagnostic absent: %#v", diags)
}
}
func TestIMContractCoverageDiagnosticIsNotChangedFileFiltered(t *testing.T) {
diag := imContractDiagnostic("im +chat-list", "missing")
got := filterPRDiagnostics(
".",
"origin/main",
qdiff.FromChangedFiles([]string{"skills/lark-doc/SKILL.md"}),
manifest.Manifest{},
[]report.Diagnostic{diag},
)
if len(got) != 1 || got[0].Rule != imContractCoverageRule {
t.Fatalf("global IM coverage diagnostic was filtered: %#v", got)
}
}
func completeIMCoverageFixture() (manifest.Manifest, []imcatalog.Contract) {
index := manifest.Manifest{SchemaVersion: 1}
contracts := make([]imcatalog.Contract, 0, expectedIMLeafCommands)
for i := 0; i < expectedIMLeafCommands; i++ {
key := fmt.Sprintf("im resource command%02d", i)
index.Commands = append(index.Commands, manifest.Command{Path: key, Domain: "im", Runnable: true})
contracts = append(contracts, imcatalog.Contract{
Key: imcatalog.ContractKey(key), Strategy: imcatalog.Strategy{Kind: imcatalog.EntityReadKind},
})
}
return index, contracts
}
func hasIMContractDiagnostic(diags []report.Diagnostic, key, text string) bool {
for _, diag := range diags {
if diag.CommandPath == key && strings.Contains(diag.Message, text) {
return true
}
}
return false
}

View File

@@ -11,7 +11,6 @@ import (
"sort"
"strings"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
qdiff "github.com/larksuite/cli/internal/qualitygate/diff"
manifestexamples "github.com/larksuite/cli/internal/qualitygate/examples"
"github.com/larksuite/cli/internal/qualitygate/facts"
@@ -44,7 +43,6 @@ func Run(ctx context.Context, opts Options) ([]report.Diagnostic, facts.Facts, e
if err := validateCommandIndexCoversManifest(m, commandIndex); err != nil {
return nil, facts.Facts{}, err
}
imContractDiags := CheckIMContractCoverage(commandIndex, imcatalog.All())
changed, err := qdiff.ChangedFiles(ctx, opts.Repo, opts.ChangedFrom)
if err != nil {
return nil, facts.Facts{}, err
@@ -112,7 +110,6 @@ func Run(ctx context.Context, opts Options) ([]report.Diagnostic, facts.Facts, e
}
diags = append(diags, publicContentDiagnostics(publicContent)...)
diags = filterPRDiagnostics(opts.Repo, opts.ChangedFrom, scope, m, diags)
diags = append(diags, imContractDiags...)
builtFacts := facts.BuildWithCommandLookup(m, commandIndex, skillFacts, skillQualityFacts, errorFacts, exampleFacts, outputFacts, diags, scope.Files)
return diags, facts.WithPublicContent(builtFacts, publicContentFacts(publicContent)), nil
@@ -215,10 +212,6 @@ func filterPRDiagnostics(repo, changedFrom string, scope qdiff.Scope, m manifest
commandScope := diagnosticCommandScopeFromFiles(scope.Files)
var out []report.Diagnostic
for _, diag := range diags {
if diag.Rule == imContractCoverageRule {
out = append(out, diag)
continue
}
if prDiagnosticRelevant(repo, scope.Files, commandScope, m, diag) {
out = append(out, diag)
}

View File

@@ -11,7 +11,6 @@ import (
"strings"
"testing"
imcatalog "github.com/larksuite/cli/internal/imcontract/catalog"
qdiff "github.com/larksuite/cli/internal/qualitygate/diff"
"github.com/larksuite/cli/internal/qualitygate/manifest"
"github.com/larksuite/cli/internal/qualitygate/report"
@@ -104,55 +103,6 @@ func TestRunRequiresCommandIndexToCoverManifest(t *testing.T) {
}
}
func TestRunReportsMissingIMDomain(t *testing.T) {
repo := t.TempDir()
runGit(t, repo, "init")
runGit(t, repo, "config", "user.email", "test@example.com")
runGit(t, repo, "config", "user.name", "Test User")
if err := vfs.WriteFile(filepath.Join(repo, "README.md"), []byte("# test\n"), 0o644); err != nil {
t.Fatal(err)
}
runGit(t, repo, "add", "README.md")
runGit(t, repo, "commit", "-m", "base")
if err := vfs.MkdirAll(filepath.Join(repo, "skills"), 0o755); err != nil {
t.Fatal(err)
}
manifestPath := filepath.Join(repo, "command-manifest.json")
indexPath := filepath.Join(repo, "command-index.json")
m := manifest.Manifest{SchemaVersion: 1, Commands: []manifest.Command{{
Path: "docs +fetch", Domain: "docs", Source: manifest.SourceShortcut,
}}}
index := manifest.Manifest{SchemaVersion: 1, Commands: []manifest.Command{
{
Path: "docs +fetch", Domain: "docs", Source: manifest.SourceShortcut, Runnable: true,
},
{
Path: "drive files get", Domain: "drive", Source: manifest.SourceService, Generated: true, Runnable: true,
},
}}
if err := manifest.WriteFile(manifestPath, manifest.KindCommandManifest, m); err != nil {
t.Fatal(err)
}
if err := manifest.WriteFile(indexPath, manifest.KindCommandIndex, index); err != nil {
t.Fatal(err)
}
diags, _, err := Run(context.Background(), Options{
Repo: repo,
CLIBin: "./lark-cli",
ChangedFrom: "HEAD",
ManifestPath: manifestPath,
CommandIndexPath: indexPath,
})
if err != nil {
t.Fatalf("Run() error = %v", err)
}
if !hasIMContractDiagnostic(diags, "", "IM leaf command count is 0, want 60") {
t.Fatalf("Run() missing-domain diagnostic absent: %#v", diags)
}
}
func TestRunReadsManifestFilesAndAcceptsServiceReferences(t *testing.T) {
repo := t.TempDir()
runGit(t, repo, "init")
@@ -210,11 +160,6 @@ description: Manage Drive comments with service command references.
},
},
}}
for _, contract := range imcatalog.All() {
idx.Commands = append(idx.Commands, manifest.Command{
Path: string(contract.Key), Domain: "im", Source: manifest.SourceBuiltin, Runnable: true,
})
}
if err := manifest.WriteFile(manifestPath, manifest.KindCommandManifest, m); err != nil {
t.Fatal(err)
}

View File

@@ -19,6 +19,9 @@ func SafeOutputPath(path string) (string, error) {
}
// SafeInputPath validates an upload/read source path for --file flags.
// Deliberately strict (relative-to-cwd only): several callers — drive sync,
// upload flags, the CI quality gates — treat "absolute paths rejected" as a
// load-bearing invariant. Out-of-tree content reaches flags via stdin ("-").
func SafeInputPath(path string) (string, error) {
return safePath(path, "--file")
}

View File

@@ -242,7 +242,7 @@ func TestSafeOutputPath_DeepNonExistentPathStaysInCWD(t *testing.T) {
}
}
func TestSafeUploadPath_AllowsTempFileAbsolutePath(t *testing.T) {
func TestSafeUploadPath_RejectsTempFileAbsolutePath(t *testing.T) {
// GIVEN: a real temp file (absolute path under os.TempDir())
f, err := os.CreateTemp("", "upload-test-*.bin")
if err != nil {
@@ -252,10 +252,11 @@ func TestSafeUploadPath_AllowsTempFileAbsolutePath(t *testing.T) {
f.Close()
t.Cleanup(func() { os.Remove(tmpPath) })
// WHEN: SafeUploadPath validates the absolute temp path
// WHEN: SafeInputPath validates the absolute temp path
_, err = SafeInputPath(tmpPath)
// THEN: absolute paths are rejected even in temp dir
// THEN: the strict validator rejects it — uploads / drive sync rely on
// relative-only; out-of-tree content reaches flags via stdin ("-")
if err == nil {
t.Fatal("expected error for absolute temp path, got nil")
}

4
package-lock.json generated
View File

@@ -1,12 +1,12 @@
{
"name": "@larksuite/cli",
"version": "1.0.80",
"version": "1.0.81",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@larksuite/cli",
"version": "1.0.80",
"version": "1.0.81",
"cpu": [
"x64",
"arm64",

View File

@@ -1,6 +1,6 @@
{
"name": "@larksuite/cli",
"version": "1.0.80",
"version": "1.0.81",
"description": "The official CLI for Lark/Feishu open platform",
"bin": {
"lark-cli": "scripts/run.js"

View File

@@ -0,0 +1,71 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package apps
import (
"context"
"fmt"
"io"
"github.com/larksuite/cli/shortcuts/common"
)
// AppsCacheClear clears all cache entries for the app in the given environment.
//
// POST /apps/{app_id}/cache/clearbody {env}。清空当前应用指定环境下全部缓存,用于无法定位
// 具体 key 的快速恢复;影响面大,定 high-risk-write框架自动注入 --yes 确认)。
var AppsCacheClear = common.Shortcut{
Service: appsService,
Command: "+cache-clear",
Description: "Clear all cache entries for the app in the given environment",
Risk: "high-risk-write",
Tips: []string{
"Example: lark-cli apps +cache-clear --app-id <app_id> --environment dev --yes",
},
Scopes: []string{"spark:app:write"},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: []common.Flag{
{Name: "app-id", Desc: "Miaoda app id", Required: true},
cacheEnvFlag(),
},
Validate: func(ctx context.Context, rctx *common.RuntimeContext) error {
_, err := requireAppID(rctx.Str("app-id"))
return err
},
DryRun: func(ctx context.Context, rctx *common.RuntimeContext) *common.DryRunAPI {
appID, _ := requireAppID(rctx.Str("app-id"))
return common.NewDryRunAPI().
POST(appCacheClearPath(appID)).
Desc("Clear all cache entries for the app in the given environment").
Body(dbEnvParams(rctx, map[string]interface{}{}))
},
Execute: func(ctx context.Context, rctx *common.RuntimeContext) error {
appID, err := requireAppID(rctx.Str("app-id"))
if err != nil {
return err
}
data, err := rctx.CallAPITyped("POST", appCacheClearPath(appID), nil, dbEnvParams(rctx, map[string]interface{}{}))
if err != nil {
return withAppsHint(err, appIDListHint)
}
out := map[string]interface{}{
"environment": resolvedEnv(data, rctx),
"deleted_key_count": cacheInt(data["deleted_key_count"]),
}
rctx.OutFormat(out, nil, func(w io.Writer) {
renderCacheClearPretty(w, out)
})
return nil
},
}
// renderCacheClearPretty 打 "✓ cache cleared: N entries (env)"。
func renderCacheClearPretty(w io.Writer, out map[string]interface{}) {
n := int64(0)
if f, ok := numericAsFloat(out["deleted_key_count"]); ok {
n = int64(f)
}
fmt.Fprintf(w, "✓ cache cleared: %d entries (%s)\n", n, common.GetString(out, "environment"))
}

View File

@@ -0,0 +1,75 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package apps
import (
"context"
"fmt"
"io"
"github.com/larksuite/cli/shortcuts/common"
)
// AppsCacheDelete deletes a single business cache key (idempotent).
//
// DELETE /apps/{app_id}/cache?env=&key=。缓存是派生数据、删单 key 影响面小且可重建,
// 故定 write非 high-risk-write、不需 --yes。目标不存在按幂等成功处理deleted_key_count=0
var AppsCacheDelete = common.Shortcut{
Service: appsService,
Command: "+cache-delete",
Description: "Delete a single business cache key (idempotent)",
Risk: "write",
Tips: []string{
"Example: lark-cli apps +cache-delete --app-id <app_id> --environment dev --key <key>",
},
Scopes: []string{"spark:app:write"},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: []common.Flag{
{Name: "app-id", Desc: "Miaoda app id", Required: true},
{Name: "key", Desc: "business cache key", Required: true},
cacheEnvFlag(),
},
Validate: func(ctx context.Context, rctx *common.RuntimeContext) error {
_, err := requireAppID(rctx.Str("app-id"))
return err
},
DryRun: func(ctx context.Context, rctx *common.RuntimeContext) *common.DryRunAPI {
appID, _ := requireAppID(rctx.Str("app-id"))
return common.NewDryRunAPI().
DELETE(appCachePath(appID)).
Desc("Delete a Miaoda app runtime cache key").
Params(dbEnvParams(rctx, map[string]interface{}{"key": rctx.Str("key")}))
},
Execute: func(ctx context.Context, rctx *common.RuntimeContext) error {
appID, err := requireAppID(rctx.Str("app-id"))
if err != nil {
return err
}
key := rctx.Str("key")
data, err := rctx.CallAPITyped("DELETE", appCachePath(appID), dbEnvParams(rctx, map[string]interface{}{"key": key}), nil)
if err != nil {
return withAppsHint(err, appIDListHint)
}
out := map[string]interface{}{
"key": key,
"environment": resolvedEnv(data, rctx),
"deleted_key_count": cacheInt(data["deleted_key_count"]),
}
rctx.OutFormat(out, nil, func(w io.Writer) {
renderCacheDeletePretty(w, out)
})
return nil
},
}
// renderCacheDeletePretty 命中打 "✓ cache deleted",幂等未命中打 "✓ cache already absent"(措辞区分,都成功)。
func renderCacheDeletePretty(w io.Writer, out map[string]interface{}) {
key := common.GetString(out, "key")
if n, ok := numericAsFloat(out["deleted_key_count"]); ok && n > 0 {
fmt.Fprintf(w, "✓ cache deleted: %s\n", key)
return
}
fmt.Fprintf(w, "✓ cache already absent: %s\n", key)
}

View File

@@ -0,0 +1,105 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package apps
import (
"context"
"fmt"
"io"
"github.com/larksuite/cli/shortcuts/common"
)
// AppsCacheGet reads a single business cache key's value + metadata.
//
// GET /apps/{app_id}/cache?env=&key=。value 在 wire 上是 JSON 字符串透传:--format json
// 原样输出该字符串(不反序列化),--format pretty 反序列化后缩进展开。value_size_bytes 由 CLI
// 按 value 字节长度算出端点不返回未命中exists=false时不带 valuettl_ms/value_size_bytes 为 null。
var AppsCacheGet = common.Shortcut{
Service: appsService,
Command: "+cache-get",
Description: "Get a business cache key's value and metadata",
Risk: "read",
Tips: []string{
"Example: lark-cli apps +cache-get --app-id <app_id> --key spotbonus:2026:winners:list:v1",
"Example: lark-cli apps +cache-get --app-id <app_id> --environment online --key <key>",
},
Scopes: []string{"spark:app:read"},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: []common.Flag{
{Name: "app-id", Desc: "Miaoda app id", Required: true},
{Name: "key", Desc: "business cache key", Required: true},
cacheEnvFlag(),
},
Validate: func(ctx context.Context, rctx *common.RuntimeContext) error {
_, err := requireAppID(rctx.Str("app-id"))
return err
},
DryRun: func(ctx context.Context, rctx *common.RuntimeContext) *common.DryRunAPI {
appID, _ := requireAppID(rctx.Str("app-id"))
return common.NewDryRunAPI().
GET(appCachePath(appID)).
Desc("Get a Miaoda app runtime cache key").
Params(dbEnvParams(rctx, map[string]interface{}{"key": rctx.Str("key")}))
},
Execute: func(ctx context.Context, rctx *common.RuntimeContext) error {
appID, err := requireAppID(rctx.Str("app-id"))
if err != nil {
return err
}
key := rctx.Str("key")
data, err := rctx.CallAPITyped("GET", appCachePath(appID), dbEnvParams(rctx, map[string]interface{}{"key": key}), nil)
if err != nil {
return withAppsHint(err, appIDListHint)
}
out := projectCacheGet(data, key, rctx)
rctx.OutFormat(out, nil, func(w io.Writer) {
renderCacheGetPretty(w, out)
})
return nil
},
}
// projectCacheGet 组装 cache-get 输出key 回显、environment 取 resolved env、exists 直读;
// 命中时带 ttl_ms + value原始串+ value_size_bytesCLI 算),未命中时 ttl_ms/value_size_bytes 为 null、无 value。
func projectCacheGet(data map[string]interface{}, key string, rctx *common.RuntimeContext) map[string]interface{} {
exists := cacheBool(data["exists"])
out := map[string]interface{}{
"key": key,
"environment": resolvedEnv(data, rctx),
"exists": exists,
}
if exists {
val := common.GetString(data, "value")
out["ttl_ms"] = cacheInt(data["ttl_ms"])
out["value_size_bytes"] = len([]byte(val))
out["value"] = val
} else {
out["ttl_ms"] = nil
out["value_size_bytes"] = nil
}
return out
}
// renderCacheGetPretty 打元信息块key/environment/exists命中再加 ttl/value_size命中时末尾展开 value。
func renderCacheGetPretty(w io.Writer, out map[string]interface{}) {
exists, _ := out["exists"].(bool)
pairs := [][2]string{
{"key", common.GetString(out, "key")},
{"environment", common.GetString(out, "environment")},
{"exists", fmt.Sprintf("%v", exists)},
}
if exists {
pairs = append(pairs,
[2]string{"ttl", formatCacheTTL(out["ttl_ms"])},
[2]string{"value_size", humanBytes(out["value_size_bytes"])},
)
}
renderKeyValuePairs(w, pairs)
if exists {
fmt.Fprintln(w, "value:")
printCacheValuePretty(w, common.GetString(out, "value"))
}
}

View File

@@ -0,0 +1,357 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package apps
import (
"encoding/json"
"strings"
"testing"
"github.com/larksuite/cli/internal/httpmock"
)
const (
cacheURL = "/open-apis/spark/v1/apps/app_x/cache"
cacheClearURL = "/open-apis/spark/v1/apps/app_x/cache/clear"
)
// cacheValueStr 是服务端在 wire 上透传的原始 JSON 字符串value 不反序列化)。
const cacheValueStr = `[{"name":"Alice","award":"Gold"},{"name":"Bob","award":"Silver"}]`
// ── cache-get ──
// TestAppsCacheGet_HitJSON命中时 json 默认——value 原样透传(不反序列化),
// value_size_bytes 由 CLI 按 value 字节长度算出environment 取服务端 resolved env。
func TestAppsCacheGet_HitJSON(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "GET", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{
"env": "online", "exists": true, "ttl_ms": 272000, "value": cacheValueStr,
}},
})
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--environment", "online", "--key", "k:1", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
d := parseEnvelopeData(t, stdout)
if d["key"] != "k:1" || d["environment"] != "online" || d["exists"] != true {
t.Fatalf("get hit data=%v", d)
}
if v, _ := d["value"].(string); v != cacheValueStr {
t.Fatalf("value must be raw passthrough string, got %v", d["value"])
}
if sz, _ := numericAsFloat(d["value_size_bytes"]); int(sz) != len(cacheValueStr) {
t.Fatalf("value_size_bytes = %v, want %d", d["value_size_bytes"], len(cacheValueStr))
}
// ttl_ms 必须是 JSON number透传服务端数字不得变成字符串JSON 解析后为 float64。
if _, ok := d["ttl_ms"].(float64); !ok {
t.Fatalf("ttl_ms must be a JSON number, got %T (%v)", d["ttl_ms"], d["ttl_ms"])
}
}
// TestAppsCacheGet_HitPrettypretty 把 value 反序列化后展开(含缩进后的字段),并打元信息标签。
func TestAppsCacheGet_HitPretty(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "GET", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{
"env": "online", "exists": true, "ttl_ms": 272000, "value": cacheValueStr,
}},
})
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--environment", "online", "--key", "k:1", "--format", "pretty", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
got := stdout.String()
for _, want := range []string{"key", "environment", "exists", "value", "Alice"} {
if !strings.Contains(got, want) {
t.Errorf("pretty missing %q:\n%s", want, got)
}
}
}
// TestAppsCacheGet_Miss未命中——exists=false无 valuettl_ms / value_size_bytes 为 null。
func TestAppsCacheGet_Miss(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "GET", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{
"env": "online", "exists": false,
}},
})
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--environment", "online", "--key", "k:1", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
d := parseEnvelopeData(t, stdout)
if d["exists"] != false {
t.Fatalf("miss exists=%v", d["exists"])
}
if _, ok := d["value"]; ok {
t.Fatalf("miss must not carry value: %v", d)
}
if d["ttl_ms"] != nil || d["value_size_bytes"] != nil {
t.Fatalf("miss ttl_ms/value_size_bytes must be null: %v", d)
}
}
// TestAppsCacheGet_ExistsAsString服务端把 exists 返成字符串 "true" 时仍按命中处理
// cacheBool 容错,防 exists 以字符串形态出现被误判成未命中、hit→miss 翻转)。
func TestAppsCacheGet_ExistsAsString(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "GET", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{
"env": "online", "exists": "true", "ttl_ms": 272000, "value": cacheValueStr,
}},
})
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--environment", "online", "--key", "k:1", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
d := parseEnvelopeData(t, stdout)
if d["exists"] != true {
t.Fatalf("exists string \"true\" 应按命中解析, got exists=%v", d["exists"])
}
if v, _ := d["value"].(string); v != cacheValueStr {
t.Fatalf("命中应带 value, got %v", d["value"])
}
}
// TestAppsCacheGet_PrettyNonJSONFallbackpretty 下 value 不是合法 JSON 时降级原样输出
// safeParseJSON 解析失败→原样打印,不报错、不吞值)。补齐 HitPretty 只覆盖了"能反序列化"路径的缺口。
func TestAppsCacheGet_PrettyNonJSONFallback(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "GET", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{
"env": "online", "exists": true, "ttl_ms": 272000, "value": "hello-plain-not-json",
}},
})
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--environment", "online", "--key", "k:1", "--format", "pretty", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
if !strings.Contains(stdout.String(), "hello-plain-not-json") {
t.Fatalf("非 JSON value 应原样输出(降级), got:\n%s", stdout.String())
}
}
// TestAppsCacheGet_TTLAsStringNormalized服务端把 ttl_ms 返成字符串 "272000" 时,
// 输出的 ttl_ms 必须归一成 JSON numbercacheInt不得随 wire 形态漂移成字符串。
func TestAppsCacheGet_TTLAsStringNormalized(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "GET", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{
"env": "online", "exists": true, "ttl_ms": "272000", "value": cacheValueStr,
}},
})
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--environment", "online", "--key", "k:1", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
d := parseEnvelopeData(t, stdout)
f, ok := d["ttl_ms"].(float64)
if !ok {
t.Fatalf("ttl_ms string wire 应归一成 JSON number, got %T (%v)", d["ttl_ms"], d["ttl_ms"])
}
if int(f) != 272000 {
t.Fatalf("ttl_ms = %v, want 272000", f)
}
}
// TestAppsCacheDelete_CountAsStringNormalized服务端把 deleted_key_count 返成字符串 "1" 时,
// 输出必须归一成 JSON numbercacheInt
func TestAppsCacheDelete_CountAsStringNormalized(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "DELETE", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{"env": "dev", "deleted_key_count": "1"}},
})
if err := runAppsShortcut(t, AppsCacheDelete,
[]string{"+cache-delete", "--app-id", "app_x", "--environment", "dev", "--key", "k:1", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
d := parseEnvelopeData(t, stdout)
if _, ok := d["deleted_key_count"].(float64); !ok {
t.Fatalf("deleted_key_count string wire 应归一成 JSON number, got %T (%v)", d["deleted_key_count"], d["deleted_key_count"])
}
}
// TestAppsCacheGet_DryRunOmitsEnv不传 --environment 时 dry-run query 不带 env服务端自动选但带 key。
func TestAppsCacheGet_DryRunOmitsEnv(t *testing.T) {
factory, stdout, _ := newAppsExecuteFactory(t)
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--key", "k:1", "--dry-run", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("dry-run err=%v", err)
}
a := firstDryRunAPI(t, stdout.String())
if a.Method != "GET" || a.URL != cacheURL {
t.Fatalf("dry-run = %s %s", a.Method, a.URL)
}
if _, ok := a.Params["env"]; ok {
t.Fatalf("no --environment → env must be omitted, params=%v", a.Params)
}
if a.Params["key"] != "k:1" {
t.Fatalf("key must be in query, params=%v", a.Params)
}
}
// TestAppsCacheGet_DryRunWithEnv显式 --environment dev → query 带 env=dev。
func TestAppsCacheGet_DryRunWithEnv(t *testing.T) {
factory, stdout, _ := newAppsExecuteFactory(t)
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--environment", "dev", "--key", "k:1", "--dry-run", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("dry-run err=%v", err)
}
a := firstDryRunAPI(t, stdout.String())
if a.Params["env"] != "dev" {
t.Fatalf("env must be dev, params=%v", a.Params)
}
}
// TestAppsCacheGet_RequiresKey缺 --key → 校验错。
func TestAppsCacheGet_RequiresKey(t *testing.T) {
factory, stdout, _ := newAppsExecuteFactory(t)
if err := runAppsShortcut(t, AppsCacheGet,
[]string{"+cache-get", "--app-id", "app_x", "--as", "user"}, factory, stdout); err == nil {
t.Fatalf("expected required --key error")
}
}
// ── cache-delete ──
// TestAppsCacheDelete_Hit删中命中的 key → deleted_key_count=1pretty 打 "✓ cache deleted"。
func TestAppsCacheDelete_Hit(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "DELETE", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{"env": "dev", "deleted_key_count": 1}},
})
if err := runAppsShortcut(t, AppsCacheDelete,
[]string{"+cache-delete", "--app-id", "app_x", "--environment", "dev", "--key", "k:1", "--format", "pretty", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
if !strings.Contains(stdout.String(), "✓ cache deleted") {
t.Fatalf("pretty: %s", stdout.String())
}
}
// TestAppsCacheDelete_AbsentJSON目标不存在 → 幂等成功deleted_key_count=0pretty 措辞区分。
func TestAppsCacheDelete_AbsentJSON(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "DELETE", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{"env": "dev", "deleted_key_count": 0}},
})
if err := runAppsShortcut(t, AppsCacheDelete,
[]string{"+cache-delete", "--app-id", "app_x", "--environment", "dev", "--key", "k:1", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
d := parseEnvelopeData(t, stdout)
if sz, _ := numericAsFloat(d["deleted_key_count"]); int(sz) != 0 || d["key"] != "k:1" || d["environment"] != "dev" {
t.Fatalf("absent data=%v", d)
}
}
// TestAppsCacheDelete_AbsentPretty不存在 pretty 打 "✓ cache already absent"。
func TestAppsCacheDelete_AbsentPretty(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "DELETE", URL: cacheURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{"env": "dev", "deleted_key_count": 0}},
})
if err := runAppsShortcut(t, AppsCacheDelete,
[]string{"+cache-delete", "--app-id", "app_x", "--environment", "dev", "--key", "k:1", "--format", "pretty", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
if !strings.Contains(stdout.String(), "already absent") {
t.Fatalf("pretty: %s", stdout.String())
}
}
// TestAppsCacheDelete_DryRunDELETE 方法、/cache 路由query 带 key + env。
func TestAppsCacheDelete_DryRun(t *testing.T) {
factory, stdout, _ := newAppsExecuteFactory(t)
if err := runAppsShortcut(t, AppsCacheDelete,
[]string{"+cache-delete", "--app-id", "app_x", "--environment", "dev", "--key", "k:1", "--dry-run", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("dry-run err=%v", err)
}
a := firstDryRunAPI(t, stdout.String())
if a.Method != "DELETE" || a.URL != cacheURL {
t.Fatalf("dry-run = %s %s", a.Method, a.URL)
}
if a.Params["key"] != "k:1" || a.Params["env"] != "dev" {
t.Fatalf("params=%v", a.Params)
}
}
// ── cache-clear ──
// TestAppsCacheClear_Success清空成功 → deleted_key_count=128pretty 打 "✓ cache cleared: 128 entries (dev)"。
func TestAppsCacheClear_Success(t *testing.T) {
factory, stdout, reg := newAppsExecuteFactory(t)
reg.Register(&httpmock.Stub{
Method: "POST", URL: cacheClearURL,
Body: map[string]interface{}{"code": 0, "data": map[string]interface{}{"env": "dev", "deleted_key_count": 128}},
})
if err := runAppsShortcut(t, AppsCacheClear,
[]string{"+cache-clear", "--app-id", "app_x", "--environment", "dev", "--yes", "--format", "pretty", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("execute err=%v", err)
}
if !strings.Contains(stdout.String(), "✓ cache cleared: 128 entries (dev)") {
t.Fatalf("pretty: %s", stdout.String())
}
}
// TestAppsCacheClear_RequiresConfirmationhigh-risk-write 无 --yes → 被确认门拦截。
func TestAppsCacheClear_RequiresConfirmation(t *testing.T) {
factory, stdout, _ := newAppsExecuteFactory(t)
if err := runAppsShortcut(t, AppsCacheClear,
[]string{"+cache-clear", "--app-id", "app_x", "--environment", "dev", "--as", "user"}, factory, stdout); err == nil {
t.Fatalf("expected confirmation gate without --yes")
}
}
// TestAppsCacheClear_DryRunBodyWithEnvdry-run POST /cache/clearbody 带 env=dev。
func TestAppsCacheClear_DryRunBodyWithEnv(t *testing.T) {
factory, stdout, _ := newAppsExecuteFactory(t)
if err := runAppsShortcut(t, AppsCacheClear,
[]string{"+cache-clear", "--app-id", "app_x", "--environment", "dev", "--dry-run", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("dry-run err=%v", err)
}
a := firstDryRunAPI(t, stdout.String())
if a.Method != "POST" || a.URL != cacheClearURL {
t.Fatalf("dry-run = %s %s", a.Method, a.URL)
}
if a.Body["env"] != "dev" {
t.Fatalf("body must carry env=dev, body=%v", a.Body)
}
}
// TestAppsCacheClear_DryRunBodyOmitsEnv不传 --environment → body 不带 env服务端自动选
func TestAppsCacheClear_DryRunBodyOmitsEnv(t *testing.T) {
factory, stdout, _ := newAppsExecuteFactory(t)
if err := runAppsShortcut(t, AppsCacheClear,
[]string{"+cache-clear", "--app-id", "app_x", "--dry-run", "--as", "user"}, factory, stdout); err != nil {
t.Fatalf("dry-run err=%v", err)
}
a := firstDryRunAPI(t, stdout.String())
if _, ok := a.Body["env"]; ok {
t.Fatalf("no --environment → body env must be omitted, body=%v", a.Body)
}
}
// firstDryRunAPI 解析 dry-run 输出的第一个 api[] 项method/url/params/body
// 复用本包规范的 dryRunAPIEnvelopeapi 现嵌在 data.api 下,见 dryrun_test.go
func firstDryRunAPI(t *testing.T, s string) dryRunAPICall {
t.Helper()
var env dryRunAPIEnvelope
if err := json.Unmarshal([]byte(s), &env); err != nil || len(env.API) == 0 {
t.Fatalf("bad dry-run json: %v\n%s", err, s)
}
return env.API[0]
}

View File

@@ -0,0 +1,99 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package apps
import (
"encoding/json"
"fmt"
"io"
"strings"
"time"
"github.com/larksuite/cli/internal/validate"
"github.com/larksuite/cli/shortcuts/common"
)
// 应用运行时缓存Cache调试命令共享件路由 + 环境 flag + 渲染。
//
// 三条命令都走 spark OpenAPI `/apps/{app_id}/cache[/clear]`按运行环境env→dbBranch隔离
// 环境 flag 用 cacheEnvFlag()(只 --environment不带 db 家族的旧名 --envenv 值经 dbEnv 读、
// 经 dbEnvParams 注入——get/delete 放 queryclear 放 body省略即服务端自动选分支
// appCachePath 返回缓存单 key 读/删 URLcacheGET 读、DELETE 删,靠方法区分)。
func appCachePath(appID string) string {
return fmt.Sprintf("%s/apps/%s/cache", apiBasePath, validate.EncodePathSegment(appID))
}
// appCacheClearPath 返回清空指定环境缓存 URLcache/clear。
func appCacheClearPath(appID string) string {
return fmt.Sprintf("%s/apps/%s/cache/clear", apiBasePath, validate.EncodePathSegment(appID))
}
// cacheEnvFlag 返回缓存命令的运行环境 flag。cache 是全新命令、从无旧名 --env
// 故只注册干净的 --environment不带 db 家族那套隐藏 --env + 拒收逻辑)。
// 省略即服务端按应用多环境状态自动选分支多环境→dev非多环境→online
func cacheEnvFlag() common.Flag {
return common.Flag{
Name: "environment",
Enum: []string{"dev", "online"},
Desc: "target runtime environment; leave unset to auto-select (multi-env app uses dev, single-env uses online), or pass dev/online",
}
}
// cacheBool 防御性解析布尔:真 bool 直接用;若服务端把 exists 返成字符串 "true"/"false" 也归一成 bool
// 其它类型按 false。避免 exists 万一以字符串形态出现时被误判成未命中hit→miss 翻转)。
func cacheBool(v interface{}) bool {
switch x := v.(type) {
case bool:
return x
case string:
return strings.EqualFold(strings.TrimSpace(x), "true")
}
return false
}
// cacheInt 把服务端下发的数值字段归一成 int64无法解析→nil。本仓惯例数值可能以字符串下发
// (见 numericAsFloat 的 string 分支),若直接透传,--format json 的字段类型会随服务端 wire 形态漂移
// number ↔ string。归一后输出类型恒定为数字或 null消费方无需自己容忍字符串。
func cacheInt(raw interface{}) interface{} {
if f, ok := numericAsFloat(raw); ok {
return int64(f)
}
return nil
}
// resolvedEnv 取服务端回吐的 resolved env缺失时兜底成请求侧 --environment可能为空
// 省略 --environment 时服务端自动选分支,靠服务端回吐才知道实际命中 dev / online。
func resolvedEnv(data map[string]interface{}, rctx *common.RuntimeContext) string {
if env := common.GetString(data, "env"); env != "" {
return env
}
return dbEnv(rctx)
}
// formatCacheTTL 把剩余 TTL毫秒格式化成 4m32s 这样的时长串;非数字返回 "—"。
func formatCacheTTL(ms interface{}) string {
f, ok := numericAsFloat(ms)
if !ok {
return "—"
}
return (time.Duration(int64(f)) * time.Millisecond).String()
}
// printCacheValuePretty 把 value 反序列化后缩进展开pretty 口径);非 JSON 则原样打印。
// 与「json 原样字符串、pretty 才反序列化」的设计一致。
func printCacheValuePretty(w io.Writer, raw string) {
v := safeParseJSON(raw)
if s, ok := v.(string); ok {
fmt.Fprintln(w, s)
return
}
b, err := json.MarshalIndent(v, "", " ")
if err != nil {
fmt.Fprintln(w, raw)
return
}
w.Write(b)
fmt.Fprintln(w)
}

View File

@@ -64,6 +64,9 @@ func Shortcuts() []common.Shortcut {
AppsFileUpload,
AppsFileDelete,
AppsFileQuotaGet,
AppsCacheGet,
AppsCacheDelete,
AppsCacheClear,
AppsGitCredentialInit,
AppsGitCredentialList,
AppsGitCredentialRemove,

View File

@@ -20,13 +20,14 @@ import (
// - 3 git-credential
// - 5 sessioncreate/list/get/stop/chat+ 1 session-messages-list
// - 8 openapi-keylist/get/create/update/enable/disable/delete/reset
// - 3 cacheget/delete/clear
// - 3 plugininstall/uninstall/list
// - 6 automationlist/get/create/update/enable/disable
// - 9 rolerole CRUD + role-member list/add/remove + role-match-list= 79
func TestAppsShortcuts_Returns79(t *testing.T) {
// - 9 rolerole CRUD + role-member list/add/remove + role-match-list= 82
func TestAppsShortcuts_Returns82(t *testing.T) {
got := Shortcuts()
if len(got) != 79 {
t.Fatalf("Shortcuts() returned %d entries, want 79", len(got))
if len(got) != 82 {
t.Fatalf("Shortcuts() returned %d entries, want 82", len(got))
}
}

View File

@@ -8,6 +8,7 @@ import (
"encoding/json"
"fmt"
"io"
"strings"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/shortcuts/common"
@@ -27,19 +28,23 @@ var BaseFormQuestionsCreate = common.Shortcut{
{Name: "form-id", Desc: "form ID", Required: true},
{Name: "questions", Desc: `questions JSON array, max 10 items. Each item requires "title"(field title) and "type"(text/number/select/datetime/user/attachment/location). Optional fields: "description"(plain text or markdown link like [text](https://example.com)),"required","option_display_mode"(0=dropdown/1=vertical/2=horizontal,select only),"multiple"(bool,select/user),"options"([{"name":"opt","hue":"Blue"}],select only),"style"({"type":"plain/phone/url/email/barcode/rating","precision":2,"format":"yyyy/MM/dd","icon":"star","min":1,"max":5}),"visible_rule"(display condition; same shape as view filter {"logic":"and","conditions":[["前序题目","==","是"]]}, field references another question's title/id, empty/absent = always shown). E.g. '[{"type":"text","title":"Your name","required":true}]'`, Required: true},
},
Tips: []string{
"If the form may already contain questions and has not been checked, run +form-questions-list for the same --base-token, --table-id, and --form-id. A verified empty form can create directly.",
"Each new question creates a field in the form's table; question IDs are field IDs.",
"Unless the user explicitly requests a separate same-title question, update an existing title with +form-questions-update instead of creating a duplicate.",
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
_, err := parseFormQuestionsCreate(runtime.Str("questions"))
return err
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
api := common.NewDryRunAPI().
questions, _ := parseFormQuestionsCreate(runtime.Str("questions"))
return common.NewDryRunAPI().
POST("/open-apis/base/v3/bases/:base_token/tables/:table_id/forms/:form_id/questions").
Set("base_token", runtime.Str("base-token")).
Set("table_id", runtime.Str("table-id")).
Set("form_id", runtime.Str("form-id"))
// Transcribe the questions body verbatim so the preview shows exactly
// what would be sent (including optional fields like visible_rule).
var questions []interface{}
if err := json.Unmarshal([]byte(runtime.Str("questions")), &questions); err == nil {
api.Body(map[string]interface{}{"questions": questions})
}
return api
Set("form_id", runtime.Str("form-id")).
Body(map[string]interface{}{"questions": questions})
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
baseToken := runtime.Str("base-token")
@@ -47,9 +52,9 @@ var BaseFormQuestionsCreate = common.Shortcut{
formId := runtime.Str("form-id")
questionsJSON := runtime.Str("questions")
var questions []interface{}
if err := json.Unmarshal([]byte(questionsJSON), &questions); err != nil {
return baseValidationErrorf("--questions must be a valid JSON array: %s", err)
questions, err := parseFormQuestionsCreate(questionsJSON)
if err != nil {
return err
}
data, err := baseV3Call(runtime, "POST",
@@ -78,3 +83,31 @@ var BaseFormQuestionsCreate = common.Shortcut{
return nil
},
}
func parseFormQuestionsCreate(raw string) ([]interface{}, error) {
var questions []interface{}
if err := json.Unmarshal([]byte(raw), &questions); err != nil {
return nil, baseValidationErrorf("--questions must be a valid JSON array: %s", err)
}
if questions == nil {
return nil, baseValidationErrorf("--questions must be a non-null JSON array")
}
if len(questions) > 10 {
return nil, baseValidationErrorf("--questions must contain at most 10 items")
}
for i, question := range questions {
item, ok := question.(map[string]interface{})
if !ok {
return nil, baseValidationErrorf("--questions item %d must be an object", i+1)
}
title, ok := item["title"].(string)
if !ok || strings.TrimSpace(title) == "" {
return nil, baseValidationErrorf("--questions item %d must include a non-empty string \"title\"", i+1)
}
questionType, ok := item["type"].(string)
if !ok || strings.TrimSpace(questionType) == "" {
return nil, baseValidationErrorf("--questions item %d must include a non-empty string \"type\"", i+1)
}
}
return questions, nil
}

View File

@@ -0,0 +1,24 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package base
import (
"strings"
"testing"
)
func TestBaseFormQuestionsCreateTipsRequireExistingQuestionCheck(t *testing.T) {
tips := strings.Join(BaseFormQuestionsCreate.Tips, "\n")
for _, want := range []string{
"+form-questions-list",
"verified empty form can create directly",
"question IDs are field IDs",
"explicitly requests a separate same-title question",
"+form-questions-update",
} {
if !strings.Contains(tips, want) {
t.Fatalf("tips missing %q:\n%s", want, tips)
}
}
}

View File

@@ -16,7 +16,6 @@ import (
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/httpmock"
"github.com/larksuite/cli/internal/imcontract"
)
func newCallAPITypedRuntime(t *testing.T) (*RuntimeContext, *httpmock.Registry) {
@@ -163,19 +162,6 @@ func TestDoAPIJSONTyped_HTTPErrorWithZeroBodyCodeNotSwallowed(t *testing.T) {
}
}
func TestDoAPIJSONTypedRejectsUnsupportedIMRequestBeforeAPI(t *testing.T) {
rt, _ := newCallAPITypedRuntime(t)
contract, _ := imcontract.Lookup("im messages urgent_app")
rt.contractSession = imcontract.NewSession(contract)
_, err := rt.DoAPIJSONTyped("PATCH", "/open-apis/im/v1/messages/om_x/urgent_app", nil, []any{"not", "an", "object"})
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryValidation ||
problem.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("error = %T %#v", err, problem)
}
}
func TestCallAPITyped_NonJSON5xx(t *testing.T) {
rt, reg := newCallAPITypedRuntime(t)
reg.Register(&httpmock.Stub{

View File

@@ -29,7 +29,6 @@ import (
"github.com/larksuite/cli/internal/credential"
"github.com/larksuite/cli/internal/errclass"
"github.com/larksuite/cli/internal/i18n"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/output"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
@@ -37,22 +36,21 @@ import (
// RuntimeContext provides helpers for shortcut execution.
type RuntimeContext struct {
ctx context.Context // from cmd.Context(), propagated through the call chain
Config *core.CliConfig
Cmd *cobra.Command
Format string
JqExpr string // --jq expression; empty = no filter
outputErrOnce sync.Once // guards first-error capture in Out()/OutFormat()
outputErr error // deferred error from jq filtering; written at most once
botOnly bool // set by framework for bot-only shortcuts
resolvedAs core.Identity // effective identity resolved by framework
Factory *cmdutil.Factory // injected by framework
apiClientFunc func() (*client.APIClient, error) // sync.OnceValues; initialized in newRuntimeContext
botInfoFunc func() (*BotInfo, error) // sync.OnceValues; lazy bot identity from /bot/v3/info
larkSDK *lark.Client // eagerly initialized in mountDeclarative
stdinConsumed bool // set when an Input flag has consumed stdin (`-`); guards against a second flag also using `-` within the same call
contractSession *imcontract.Session
readSession *imcontract.ReadSession
ctx context.Context // from cmd.Context(), propagated through the call chain
Config *core.CliConfig
Cmd *cobra.Command
Format string
JqExpr string // --jq expression; empty = no filter
outputErrOnce sync.Once // guards first-error capture in Out()/OutFormat()
outputErr error // deferred error from jq filtering; written at most once
botOnly bool // set by framework for bot-only shortcuts
resolvedAs core.Identity // effective identity resolved by framework
Factory *cmdutil.Factory // injected by framework
apiClientFunc func() (*client.APIClient, error) // sync.OnceValues; initialized in newRuntimeContext
botInfoFunc func() (*BotInfo, error) // sync.OnceValues; lazy bot identity from /bot/v3/info
larkSDK *lark.Client // eagerly initialized in mountDeclarative
stdinConsumed bool // set when an Input flag has consumed stdin (`-`); guards against a second flag also using `-` within the same call
inputResolved map[string]bool // flags whose value was replaced by @file / stdin content in resolveInputFlags; see InputResolvedFromSource
}
// ── Identity ──
@@ -502,20 +500,6 @@ func (ctx *RuntimeContext) DoAPIStream(callCtx context.Context, req *larkcore.Ap
// auth error from the client boundary is already typed and passes through
// unchanged; a non-zero API code is classified with subtype / code / log_id.
func (ctx *RuntimeContext) DoAPIJSONTyped(method, apiPath string, query larkcore.QueryParams, body any) (map[string]any, error) {
if ctx.contractSession != nil {
requestBody, _ := body.(map[string]any)
if values := query["uuid"]; len(values) > 0 {
cloned := make(map[string]any, len(requestBody)+1)
for key, value := range requestBody {
cloned[key] = value
}
cloned["uuid"] = values[0]
requestBody = cloned
}
if err := ctx.contractSession.ObserveRequest(requestBody); err != nil {
return nil, err
}
}
req := &larkcore.ApiReq{
HttpMethod: method,
ApiPath: apiPath,
@@ -528,36 +512,7 @@ func (ctx *RuntimeContext) DoAPIJSONTyped(method, apiPath string, query larkcore
if err != nil {
return nil, typedOrInternal(err)
}
data, err := ctx.ClassifyAPIResponse(resp)
if ctx.contractSession != nil && err == nil {
ctx.contractSession.ObserveResponse(data)
}
return data, err
}
// DoWriteAPIJSONTyped marks the narrow point at which a contract-managed
// shortcut starts its target business write, then delegates to the typed JSON
// transport. Preflight and enrichment calls must use DoAPIJSONTyped instead.
func (ctx *RuntimeContext) DoWriteAPIJSONTyped(method, apiPath string, query larkcore.QueryParams, body any) (map[string]any, error) {
ctx.RecordContractFact(imcontract.Fact{Kind: imcontract.FactWriteAttempted})
return ctx.DoAPIJSONTyped(method, apiPath, query, body)
}
// RecordContractFact records one of the small, fixed execution facts that
// cannot be inferred from an API request or response.
func (ctx *RuntimeContext) RecordContractFact(f imcontract.Fact) {
if ctx.contractSession != nil {
ctx.contractSession.RecordFact(f)
}
}
// RecordPagination gives the IM read contract the neutral reason why paging
// stopped. The shortcut does not interpret this status as complete or
// incomplete; that decision belongs to internal/imcontract.
func (ctx *RuntimeContext) RecordPagination(status client.PaginationStatus) {
if ctx.readSession != nil {
ctx.readSession.ObservePagination(status)
}
return ctx.ClassifyAPIResponse(resp)
}
// logIDFromHeader extracts x-tt-logid from response headers and returns it as a detail map.
@@ -746,14 +701,24 @@ func wrapLegacyPrettyRenderer(prettyFn func(w io.Writer)) output.PrettyRenderer
// Out prints a success JSON envelope to stdout.
func (ctx *RuntimeContext) Out(data interface{}, meta *output.Meta) {
ctx.emitFinalized(data, meta, false, true, "", nil)
ctx.handleEmitterError(ctx.newEmitter().Success(data, output.EmitOptions{
Format: "",
Raw: false,
JQ: ctx.JqExpr,
Meta: meta,
}))
}
// OutRaw prints a success JSON envelope to stdout with HTML escaping disabled.
// Use this instead of Out when the data contains XML/HTML content (e.g. document bodies)
// that should be preserved as-is in JSON output.
func (ctx *RuntimeContext) OutRaw(data interface{}, meta *output.Meta) {
ctx.emitFinalized(data, meta, true, true, "", nil)
ctx.handleEmitterError(ctx.newEmitter().Success(data, output.EmitOptions{
Format: "",
Raw: true,
JQ: ctx.JqExpr,
Meta: meta,
}))
}
// OutPartialFailure writes an ok:false multi-status result envelope to stdout
@@ -767,112 +732,42 @@ func (ctx *RuntimeContext) OutRaw(data interface{}, meta *output.Meta) {
// ok:true, and the exit signal is distinct from ErrBare (the
// stdout-carries-the-answer silent-exit signal).
func (ctx *RuntimeContext) OutPartialFailure(data interface{}, meta *output.Meta) error {
ctx.emitFinalized(data, meta, false, false, "", nil)
ctx.handleEmitterError(ctx.newEmitter().PartialFailure(data, output.EmitOptions{
Format: "",
Raw: false,
JQ: ctx.JqExpr,
Meta: meta,
}))
if ctx.outputErr != nil {
return ctx.outputErr
}
return output.PartialFailure(output.ExitAPI)
}
// emitFinalized lets an IM contract determine the business result before the
// command-scoped Emitter performs all safety checks, projection, formatting,
// buffering, and stdout/stderr writes. Non-IM commands pass through unchanged.
func (ctx *RuntimeContext) emitFinalized(
data interface{},
meta *output.Meta,
raw bool,
ok bool,
format string,
pretty output.PrettyRenderer,
) {
hint := ""
var resultExit int
var resultError interface{}
var resultCause error
if ctx.contractSession != nil {
result, err := ctx.contractSession.FinalizeSuccess(data)
if err != nil {
ctx.outputErrOnce.Do(func() { ctx.outputErr = err })
return
}
data = result.Data
ok = result.OK
hint = result.Hint
resultExit = result.ExitCode
}
if ctx.readSession != nil {
result, err := ctx.readSession.Finalize(data)
if err != nil {
ctx.outputErrOnce.Do(func() { ctx.outputErr = err })
return
}
data = result.Data
ok = result.OK
meta = mergeIMReadMeta(meta, result.Meta)
hint = result.Hint
resultExit = result.ExitCode
if result.Error != nil {
resultError = result.Error
}
resultCause = result.Cause
}
// Legacy OutFormat falls back to the JSON envelope when a command does not
// provide a pretty renderer. Preserve that behavior without re-finalizing
// the contract or introducing another output path.
if format == "pretty" && pretty == nil {
format = ""
}
emitOpts := output.EmitOptions{
Format: format,
Raw: raw,
JQ: ctx.JqExpr,
Meta: meta,
Error: resultError,
Hint: hint,
Pretty: pretty,
// Structured JSON carries the hint in-band. Projected reads and naked
// formats need the recovery guidance on stderr so it is not discarded.
HintToStderr: hint != "" &&
((ctx.readSession != nil && ctx.JqExpr != "") ||
(ctx.JqExpr == "" && format != "" && format != "json")),
}
emitter := ctx.newEmitter()
var emitErr error
if !ok && (ctx.JqExpr != "" || format == "" || format == "json") {
emitErr = emitter.PartialFailure(data, emitOpts)
} else {
emitErr = emitter.Success(data, emitOpts)
}
ctx.handleEmitterError(emitErr)
if emitErr != nil {
return
}
if resultExit != 0 {
ctx.outputErrOnce.Do(func() {
if resultCause != nil &&
(ctx.JqExpr != "" || (format != "" && format != "json")) {
ctx.outputErr = resultCause
return
}
ctx.outputErr = output.PartialFailure(resultExit)
})
}
}
// OutFormat prints output based on --format flag.
// "json" (default) outputs JSON envelope; "pretty" calls prettyFn; others delegate to FormatValue.
// When JqExpr is set, envelope filtering takes precedence over format.
// The Emitter handles content safety scanning for every format.
func (ctx *RuntimeContext) OutFormat(data interface{}, meta *output.Meta, prettyFn func(w io.Writer)) {
ctx.emitFinalized(data, meta, false, true, ctx.Format, wrapLegacyPrettyRenderer(prettyFn))
ctx.handleEmitterError(ctx.newEmitter().Success(data, output.EmitOptions{
Format: ctx.Format,
Raw: false,
JQ: ctx.JqExpr,
Meta: meta,
Pretty: wrapLegacyPrettyRenderer(prettyFn),
}))
}
// OutFormatRaw is like OutFormat but with HTML escaping disabled in JSON output.
// Use this when the data contains XML/HTML content that should be preserved as-is.
func (ctx *RuntimeContext) OutFormatRaw(data interface{}, meta *output.Meta, prettyFn func(w io.Writer)) {
ctx.emitFinalized(data, meta, true, true, ctx.Format, wrapLegacyPrettyRenderer(prettyFn))
ctx.handleEmitterError(ctx.newEmitter().Success(data, output.EmitOptions{
Format: ctx.Format,
Raw: true,
JQ: ctx.JqExpr,
Meta: meta,
Pretty: wrapLegacyPrettyRenderer(prettyFn),
}))
}
// ── Scope pre-check ──
@@ -969,10 +864,6 @@ func (s Shortcut) mountDeclarative(ctx context.Context, parent *cobra.Command, f
}
cmdmeta.SetSource(cmd, cmdmeta.SourceShortcut, false)
cmdmeta.SetAffordanceRef(cmd, shortcut.Service, shortcut.Command)
contractKey := imcontract.ContractKey(shortcut.Service + " " + shortcut.Command)
if _, ok := imcontract.Lookup(contractKey); ok {
imcontract.AnnotateHelpContract(cmd, contractKey)
}
cmdutil.SetSupportedIdentities(cmd, shortcut.AuthTypes)
registerShortcutFlagsWithContext(ctx, cmd, f, &shortcut)
cmdutil.SetTips(cmd, shortcut.Tips)
@@ -1056,9 +947,6 @@ func runShortcut(cmd *cobra.Command, f *cmdutil.Factory, s *Shortcut, botOnly bo
}
if err := s.Execute(rctx.ctx, rctx); err != nil {
if rctx.contractSession != nil {
return rctx.contractSession.FinalizeError(err)
}
return err
}
return rctx.outputErr
@@ -1102,20 +990,6 @@ func newRuntimeContext(cmd *cobra.Command, f *cmdutil.Factory, s *Shortcut, conf
ctx := cmd.Context()
ctx = cmdutil.ContextWithShortcut(ctx, s.Service+":"+s.Command, uuid.New().String())
rctx := &RuntimeContext{ctx: ctx, Config: config, Cmd: cmd, botOnly: botOnly, resolvedAs: as, Factory: f}
if contract, ok := imcontract.Lookup(imcontract.ContractKey(s.Service + " " + s.Command)); ok {
switch {
case contract.Strategy.Kind.IsWrite():
rctx.contractSession = imcontract.NewSession(contract)
case contract.Strategy.Kind.IsRead():
readSession, readErr := imcontract.NewReadSession(contract, imcontract.ReadOptions{
FullRead: shortcutBoolFlag(cmd, "page-all"),
})
if readErr != nil {
return nil, readErr
}
rctx.readSession = readSession
}
}
rctx.apiClientFunc = sync.OnceValues(func() (*client.APIClient, error) {
return f.NewAPIClientWithConfig(config)
})
@@ -1133,31 +1007,6 @@ func newRuntimeContext(cmd *cobra.Command, f *cmdutil.Factory, s *Shortcut, conf
return rctx, nil
}
func shortcutBoolFlag(cmd *cobra.Command, name string) bool {
if cmd == nil || cmd.Flags().Lookup(name) == nil {
return false
}
value, _ := cmd.Flags().GetBool(name)
return value
}
func mergeIMReadMeta(base, contract *output.Meta) *output.Meta {
if base == nil && contract == nil {
return nil
}
merged := output.Meta{}
if base != nil {
merged = *base
}
if contract != nil {
merged.Complete = contract.Complete
merged.PagesFetched = contract.PagesFetched
merged.StopReason = contract.StopReason
merged.NextPageToken = contract.NextPageToken
}
return &merged
}
// stripUTF8BOM removes a leading UTF-8 byte-order mark from content read from a
// file or stdin. A BOM that survives into a CSV cell corrupts the first value
// (e.g. "\ufeffNorth", which then makes a MAXIFS/lookup miss it), and a BOM at the
@@ -1168,6 +1017,25 @@ func stripUTF8BOM(s string) string {
return strings.TrimPrefix(s, "\uFEFF")
}
// InputResolvedFromSource reports whether the named flag's value was loaded
// from an external source (@file or stdin `-`) by resolveInputFlags, as
// opposed to typed inline on the command line. Domain guards that apply
// shape heuristics to inline values ("this looks like a file path — did you
// forget the @?") must skip resolved values: their content was already read
// from the right place and may legitimately look like anything, including a
// path. Without this bit such a guard re-rejects correct @file / stdin
// invocations, because by the time Validate runs both arrive as plain text.
func (ctx *RuntimeContext) InputResolvedFromSource(name string) bool {
return ctx.inputResolved[name]
}
func (ctx *RuntimeContext) markInputResolved(name string) {
if ctx.inputResolved == nil {
ctx.inputResolved = map[string]bool{}
}
ctx.inputResolved[name] = true
}
// resolveInputFlags resolves @file and - (stdin) for flags with Input sources.
// Must be called before Validate/DryRun/Execute so that runtime.Str() returns resolved content.
func resolveInputFlags(rctx *RuntimeContext, flags []Flag) error {
@@ -1207,6 +1075,7 @@ func resolveInputFlags(rctx *RuntimeContext, flags []Flag) error {
// strip a leading UTF-8 BOM so it can't corrupt the first CSV
// cell or break JSON parsing downstream.
rctx.Cmd.Flags().Set(fl.Name, stripUTF8BOM(string(data)))
rctx.markInputResolved(fl.Name)
continue
}
@@ -1243,6 +1112,7 @@ func resolveInputFlags(rctx *RuntimeContext, flags []Flag) error {
// strip a leading UTF-8 BOM so it
// can't corrupt the first CSV cell or break JSON parsing downstream.
rctx.Cmd.Flags().Set(fl.Name, stripUTF8BOM(string(data)))
rctx.markInputResolved(fl.Name)
continue
}
}

View File

@@ -8,32 +8,9 @@ import (
"testing"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/imcontract"
"github.com/spf13/cobra"
)
func TestShortcutMountStoresOnlyLazyIMContractHelpKey(t *testing.T) {
f, _, _, _ := cmdutil.TestFactory(t, nil)
parent := &cobra.Command{Use: "im"}
shortcut := Shortcut{
Service: "im",
Command: "+chat-list",
Description: "List chats",
Execute: func(context.Context, *RuntimeContext) error { return nil },
}
shortcut.Mount(parent, f)
cmd, _, err := parent.Find([]string{"+chat-list"})
if err != nil {
t.Fatal(err)
}
if cmd.Long != "" || cmd.Short != "List chats" {
t.Fatalf("mount changed visible help fields: Short=%q Long=%q", cmd.Short, cmd.Long)
}
if got := imcontract.HelpText(cmd); got != imcontract.HelpCompleteness.Text() {
t.Fatalf("lazy contract help = %q", got)
}
}
// TestShortcutMount_FlagCompletionsRegistered exercises the two
// cmdutil.RegisterFlagCompletion call sites in registerShortcutFlagsWithContext:
// the per-flag enum completion (runner.go:879) and the auto-injected --format

View File

@@ -43,6 +43,9 @@ func TestResolveInputFlags_DirectValue(t *testing.T) {
if got := rctx.Str("markdown"); got != "hello world" {
t.Errorf("expected %q, got %q", "hello world", got)
}
if rctx.InputResolvedFromSource("markdown") {
t.Error("inline value must not be marked as resolved from a source")
}
}
func TestResolveInputFlags_Stdin(t *testing.T) {
@@ -55,6 +58,9 @@ func TestResolveInputFlags_Stdin(t *testing.T) {
if got := rctx.Str("markdown"); got != "content from stdin" {
t.Errorf("expected %q, got %q", "content from stdin", got)
}
if !rctx.InputResolvedFromSource("markdown") {
t.Error("stdin value should be marked as resolved from a source")
}
}
func TestResolveInputFlags_File(t *testing.T) {
@@ -75,6 +81,27 @@ func TestResolveInputFlags_File(t *testing.T) {
if got := rctx.Str("markdown"); got != content {
t.Errorf("expected %q, got %q", content, got)
}
if !rctx.InputResolvedFromSource("markdown") {
t.Error("@file value should be marked as resolved from a source")
}
}
// TestResolveInputFlags_EscapedAtStaysInline pins that the @@ escape is
// inline content (a literal leading @), not an external source — heuristic
// guards keyed on InputResolvedFromSource must still see it.
func TestResolveInputFlags_EscapedAtStaysInline(t *testing.T) {
rctx := newTestRuntimeWithStdin(map[string]string{"markdown": "@@handle"}, "")
flags := []Flag{{Name: "markdown", Input: []string{File, Stdin}}}
if err := resolveInputFlags(rctx, flags); err != nil {
t.Fatalf("unexpected error: %v", err)
}
if got := rctx.Str("markdown"); got != "@handle" {
t.Errorf("expected %q, got %q", "@handle", got)
}
if rctx.InputResolvedFromSource("markdown") {
t.Error("escaped @@ value must not be marked as resolved from a source")
}
}
func TestResolveInputFlags_EmptyFile(t *testing.T) {

View File

@@ -7,18 +7,12 @@ import (
"context"
"encoding/json"
"errors"
"fmt"
"io"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/spf13/cobra"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/output"
)
@@ -67,251 +61,3 @@ func TestOutPartialFailure(t *testing.T) {
t.Fatalf("both succeeded and failed items must ride on stdout, got %d items\nstdout: %s", len(items), stdout.String())
}
}
func TestNonIMShortcutSuccessOmitsErrorField(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, _, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "+fetch"}, cfg, f, core.AsUser)
rt.Out(map[string]any{"document_id": "docx_x"}, nil)
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
if _, exists := env["error"]; exists {
t.Fatalf("successful non-IM shortcut emitted error field: %#v", env)
}
}
func TestIMContractRequiredResultStopsFalseSuccess(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, _, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "+messages-send"}, cfg, f, core.AsUser)
contract, _ := imcontract.Lookup("im +messages-send")
rt.contractSession = imcontract.NewSession(contract)
rt.Out(map[string]any{"message_id": ""}, nil)
if stdout.Len() != 0 {
t.Fatalf("false success reached stdout: %s", stdout.String())
}
if output.ExitCodeOf(rt.outputErr) != output.ExitInternal {
t.Fatalf("exit = %d, want 5; err=%v", output.ExitCodeOf(rt.outputErr), rt.outputErr)
}
}
func TestIMContractPartialWritesOneResultEnvelope(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, _, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "urgent_app"}, cfg, f, core.AsBot)
contract, _ := imcontract.Lookup("im messages urgent_app")
rt.contractSession = imcontract.NewSession(contract)
rt.contractSession.ObserveRequest(map[string]any{"user_id_list": []any{"ou_a", "ou_b"}})
rt.Out(map[string]any{"invalid_user_id_list": []any{"ou_b"}}, nil)
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
if env["ok"] != false || env["hint"] == "" {
t.Fatalf("unexpected envelope: %#v", env)
}
var partial *output.PartialFailureError
if !errors.As(rt.outputErr, &partial) || partial.Code != output.ExitAPI {
t.Fatalf("output error = %T %v", rt.outputErr, rt.outputErr)
}
}
func TestIMContractFlagCancelPendingLayerIsPartial(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, _, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "+flag-cancel"}, cfg, f, core.AsUser)
contract, _ := imcontract.Lookup("im +flag-cancel")
rt.contractSession = imcontract.NewSession(contract)
rt.RecordContractFact(imcontract.Fact{Kind: imcontract.FactFlagFeedLayerPending})
rt.Out(map[string]any{"results": []any{
map[string]any{"flag_type": "message", "status": "ok"},
}}, nil)
var env struct {
OK bool `json:"ok"`
Data struct {
Completion imcontract.Completion `json:"completion"`
} `json:"data"`
}
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
if env.OK || env.Data.Completion.PendingCount != 1 ||
len(env.Data.Completion.PendingItems) != 1 || env.Data.Completion.PendingItems[0] != "feed" {
t.Fatalf("unexpected pending ledger: %#v", env)
}
}
func TestRunShortcutAppliesIMReplayPolicy(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x", AppSecret: "secret"}
f, _, _, _ := cmdutil.TestFactory(t, cfg)
parent := &cobra.Command{Use: "im"}
shortcut := Shortcut{
Service: "im",
Command: "+flag-create",
Description: "test",
Risk: "write",
AuthTypes: []string{"bot"},
Execute: func(_ context.Context, runtime *RuntimeContext) error {
runtime.RecordContractFact(imcontract.Fact{Kind: imcontract.FactWriteAttempted})
return errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithRetryable()
},
}
shortcut.Mount(parent, f)
parent.SetArgs([]string{"+flag-create", "--as", "bot"})
err := parent.Execute()
p, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("expected typed error, got %T %v", err, err)
}
if p.Retryable || p.Hint != "The write result is unknown. Do not replay the original request." {
t.Fatalf("problem = %#v", p)
}
}
func TestIMContractAlsoAppliesToPrettyOutput(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, _, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "+chat-create"}, cfg, f, core.AsUser)
rt.Format = "pretty"
contract, _ := imcontract.Lookup("im +chat-create")
rt.contractSession = imcontract.NewSession(contract)
rt.OutFormat(map[string]any{"chat_id": ""}, nil, func(w io.Writer) {
fmt.Fprintln(w, "Group created successfully")
})
if stdout.Len() != 0 {
t.Fatalf("false pretty success reached stdout: %s", stdout.String())
}
if output.ExitCodeOf(rt.outputErr) != output.ExitInternal {
t.Fatalf("exit = %d, want 5; err=%v", output.ExitCodeOf(rt.outputErr), rt.outputErr)
}
}
func TestIMReadLateFailureWritesOneSelfContainedJSONEnvelope(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, stderr, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "+chat-list"}, cfg, f, core.AsUser)
contract, _ := imcontract.Lookup("im +chat-list")
rt.readSession, _ = imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: true})
cause := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithRetryable()
rt.RecordPagination(client.PaginationStatus{
PagesFetched: 1, HasMore: true, NextPageToken: "next",
StopReason: client.StopReasonTransportError, Cause: cause,
})
rt.Out(map[string]any{"items": []any{"kept"}}, nil)
if stderr.Len() != 0 {
t.Fatalf("stderr must stay empty for unprojected JSON, got %s", stderr.String())
}
var env map[string]any
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
meta := env["meta"].(map[string]any)
rawProblem, exists := env["error"]
if !exists {
t.Fatalf("late failure omitted structured error: %#v", env)
}
problem, ok := rawProblem.(map[string]any)
if !ok {
t.Fatalf("late failure error = %T, want object: %#v", rawProblem, env)
}
if env["ok"] != false || meta["complete"] != false ||
meta["stop_reason"] != "transport_error" || problem["type"] != "network" {
t.Fatalf("unexpected envelope: %#v", env)
}
var partial *output.PartialFailureError
if !errors.As(rt.outputErr, &partial) || partial.Code != output.ExitNetwork {
t.Fatalf("output error = %T %v", rt.outputErr, rt.outputErr)
}
}
func TestIMReadLateFailureKeepsPresentationAndTypedErrorOutsideJSON(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, stderr, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "+chat-list"}, cfg, f, core.AsUser)
rt.Format = "pretty"
contract, _ := imcontract.Lookup("im +chat-list")
rt.readSession, _ = imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: true})
cause := errs.NewNetworkError(errs.SubtypeNetworkTransport, "request failed").WithRetryable()
rt.RecordPagination(client.PaginationStatus{
PagesFetched: 1, HasMore: true, NextPageToken: "next",
StopReason: client.StopReasonTransportError, Cause: cause,
})
rt.OutFormat(map[string]any{"items": []any{"kept"}}, nil, func(w io.Writer) {
fmt.Fprintln(w, "kept")
})
if stdout.String() != "kept\n" {
t.Fatalf("stdout = %q", stdout.String())
}
if !strings.Contains(stderr.String(), "hint: The read is incomplete") {
t.Fatalf("stderr = %q", stderr.String())
}
if !errors.Is(rt.outputErr, cause) {
t.Fatalf("output error = %T %v, want original cause", rt.outputErr, rt.outputErr)
}
}
func TestMergeIMReadMetaHandlesNilInputsAndPreservesBaseFields(t *testing.T) {
if got := mergeIMReadMeta(nil, nil); got != nil {
t.Fatalf("mergeIMReadMeta(nil, nil) = %#v, want nil", got)
}
base := &output.Meta{Count: 7, Rollback: "undo-token"}
baseOnly := mergeIMReadMeta(base, nil)
if baseOnly == nil || baseOnly.Count != 7 || baseOnly.Rollback != "undo-token" {
t.Fatalf("base-only meta = %#v", baseOnly)
}
complete := false
contract := &output.Meta{
Complete: &complete, PagesFetched: 1, StopReason: "single_page", NextPageToken: "next",
}
contractOnly := mergeIMReadMeta(nil, contract)
if contractOnly == nil || contractOnly.Complete == nil || *contractOnly.Complete ||
contractOnly.PagesFetched != 1 || contractOnly.StopReason != "single_page" {
t.Fatalf("contract-only meta = %#v", contractOnly)
}
merged := mergeIMReadMeta(base, contract)
if merged.Count != 7 || merged.Rollback != "undo-token" ||
merged.Complete == nil || *merged.Complete || merged.NextPageToken != "next" {
t.Fatalf("merged meta = %#v", merged)
}
}
func TestIMChatMembersReadPreservesCountMeta(t *testing.T) {
cfg := &core.CliConfig{Brand: core.BrandFeishu, AppID: "cli_x"}
f, stdout, _, _ := cmdutil.TestFactory(t, cfg)
rt := TestNewRuntimeContextForAPI(context.Background(), &cobra.Command{Use: "+chat-members-list"}, cfg, f, core.AsUser)
contract, _ := imcontract.Lookup("im +chat-members-list")
rt.readSession, _ = imcontract.NewReadSession(contract, imcontract.ReadOptions{})
rt.RecordPagination(client.PaginationStatus{
PagesFetched: 1, HasMore: true, NextPageToken: "next", StopReason: client.StopReasonSinglePage,
})
rt.Out(map[string]any{"users": []any{"ou_a"}, "bots": []any{"cli_a"}}, &output.Meta{Count: 2})
var env struct {
Meta output.Meta `json:"meta"`
}
if err := json.Unmarshal(stdout.Bytes(), &env); err != nil {
t.Fatal(err)
}
if env.Meta.Count != 2 || env.Meta.Complete == nil || *env.Meta.Complete ||
env.Meta.StopReason != "single_page" {
t.Fatalf("meta = %#v, want count plus incomplete contract fields", env.Meta)
}
}

View File

@@ -39,6 +39,13 @@ func TestNewRuntimeContextWithBotInfo(cmd *cobra.Command, cfg *core.CliConfig, i
return rctx
}
// TestMarkInputResolved marks a flag as resolved from @file / stdin, so
// domain tests can exercise guards that branch on InputResolvedFromSource
// without wiring the full resolveInputFlags path.
func TestMarkInputResolved(rctx *RuntimeContext, name string) {
rctx.markInputResolved(name)
}
// TestNewRuntimeContextForAPI creates a RuntimeContext ready for HTTP tests:
// sets Cmd, Config, Factory, context, and the requested identity so callers
// can invoke DoAPI / CallAPI directly without wiring through a cobra parent

View File

@@ -202,7 +202,7 @@ var DriveDownload = common.Shortcut{
ApiPath: fmt.Sprintf("/open-apis/drive/v1/files/%s/download", validate.EncodePathSegment(fileToken)),
})
if err != nil {
return wrapDriveNetworkErr(err, "download failed: %s", err)
return withDriveDownloadForbiddenPreviewHint(wrapDriveNetworkErr(err, "download failed: %s", err), fileToken)
}
defer resp.Body.Close()

View File

@@ -5,6 +5,8 @@ package drive
import (
"errors"
"fmt"
"net/http"
"strings"
"github.com/larksuite/cli/errs"
@@ -21,6 +23,30 @@ func wrapDriveNetworkErr(err error, format string, args ...any) error {
return errs.NewNetworkError(errs.SubtypeNetworkTransport, format, args...).WithCause(err)
}
// withDriveDownloadForbiddenPreviewHint keeps the HTTP 403 network error from
// +download intact while giving callers a preview-based path to view content.
func withDriveDownloadForbiddenPreviewHint(err error, _ string) error {
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryNetwork || problem.Code != http.StatusForbidden {
return err
}
if strings.Contains(problem.Hint, "drive +preview") {
return err
}
hint := driveDownloadForbiddenPreviewHint()
if strings.TrimSpace(problem.Hint) == "" {
problem.Hint = hint
return err
}
problem.Hint = strings.TrimSpace(problem.Hint) + " " + hint
return err
}
func driveDownloadForbiddenPreviewHint() string {
const tokenArg = "<FILE_TOKEN>"
return fmt.Sprintf("Direct Drive download returned HTTP 403. To view file content through preview artifacts, try `lark-cli drive +preview --file-token %s --type source_file --output <path>`; for PDF/text/image preview choices, run `lark-cli drive +preview --file-token %s --list-only`.", tokenArg, tokenArg)
}
// driveInputStatError maps a FileIO.Stat/Open error for input file validation
// to a typed validation error:
// - Path validation failures → "unsafe file path: ..."

View File

@@ -1580,6 +1580,84 @@ func TestDriveDownloadAllowsOverwriteFlag(t *testing.T) {
}
}
func TestDriveDownloadHTTP403SuggestsPreview(t *testing.T) {
f, _, _, reg := cmdutil.TestFactory(t, driveTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/file_403/download",
Status: http.StatusForbidden,
RawBody: []byte("permission denied"),
})
tmpDir := t.TempDir()
withDriveWorkingDir(t, tmpDir)
err := mountAndRunDrive(t, DriveDownload, []string{
"+download",
"--file-token", "file_403",
"--output", "blocked.md",
"--as", "bot",
}, f, nil)
if err == nil {
t.Fatal("expected HTTP 403 error, got nil")
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("expected typed error, got %T: %v", err, err)
}
if problem.Category != errs.CategoryNetwork {
t.Fatalf("category=%q, want network", problem.Category)
}
if problem.Code != http.StatusForbidden {
t.Fatalf("code=%d, want %d", problem.Code, http.StatusForbidden)
}
if !strings.Contains(problem.Hint, "drive +preview") {
t.Fatalf("hint=%q, want preview guidance", problem.Hint)
}
if strings.Contains(problem.Hint, "file_403") {
t.Fatalf("hint=%q, want placeholder file token", problem.Hint)
}
if !strings.Contains(problem.Hint, "--file-token <FILE_TOKEN>") {
t.Fatalf("hint=%q, want file token placeholder", problem.Hint)
}
if !strings.Contains(problem.Hint, "--type source_file") || !strings.Contains(problem.Hint, "--output <path>") {
t.Fatalf("hint=%q, want source_file output command", problem.Hint)
}
}
func TestDriveDownloadHTTP404DoesNotSuggestPreview(t *testing.T) {
f, _, _, reg := cmdutil.TestFactory(t, driveTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/file_missing/download",
Status: http.StatusNotFound,
RawBody: []byte("not found"),
})
tmpDir := t.TempDir()
withDriveWorkingDir(t, tmpDir)
err := mountAndRunDrive(t, DriveDownload, []string{
"+download",
"--file-token", "file_missing",
"--output", "missing.md",
"--as", "bot",
}, f, nil)
if err == nil {
t.Fatal("expected HTTP 404 error, got nil")
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("expected typed error, got %T: %v", err, err)
}
if problem.Code != http.StatusNotFound {
t.Fatalf("code=%d, want %d", problem.Code, http.StatusNotFound)
}
if strings.Contains(problem.Hint, "drive +preview") {
t.Fatalf("hint=%q, want no preview guidance for non-403", problem.Hint)
}
}
func TestDriveDownloadDefaultOutputPathSanitizesSlashOnlyNames(t *testing.T) {
header := http.Header{
"Content-Disposition": []string{`attachment; filename="////"`},

View File

@@ -16,13 +16,13 @@ import (
var DrivePreview = common.Shortcut{
Service: "drive",
Command: "+preview",
Description: "List or download available preview artifacts for a Drive file",
Description: "View or download Drive file content, or list and fetch available preview artifacts",
Risk: "read",
Scopes: []string{"drive:file:download"},
AuthTypes: []string{"user", "bot"},
Flags: []common.Flag{
{Name: "file-token", Desc: "Drive file token", Required: true},
{Name: "type", Desc: "preview type to download: pdf | html | text | image | source"},
{Name: "type", Desc: "preview type to download: pdf | html | text | image | source_file"},
{Name: "version", Desc: "optional file version"},
{Name: "list-only", Type: "bool", Desc: "list preview candidates without downloading"},
{Name: "output", Desc: "local output path for downloaded preview"},
@@ -40,6 +40,25 @@ var DrivePreview = common.Shortcut{
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
fileToken := runtime.Str("file-token")
version := strings.TrimSpace(runtime.Str("version"))
requestedType := strings.TrimSpace(runtime.Str("type"))
if requestedType == "source_file" {
downloadParams := map[string]interface{}{
"preview_type": drivePreviewTypeSourceFile,
}
if version != "" {
downloadParams["version"] = version
}
return common.NewDryRunAPI().
GET("/open-apis/drive/v1/medias/:file_token/preview_download").
Desc("Download the source file artifact").
Params(downloadParams).
Set("file_token", fileToken).
Set("mode", "download").
Set("requested_type", requestedType).
Set("selected_type", "source_file").
Set("selected_type_code", drivePreviewTypeSourceFile).
Set("output", runtime.Str("output"))
}
body := map[string]interface{}{}
if version != "" {
body["version"] = version
@@ -67,7 +86,7 @@ var DrivePreview = common.Shortcut{
Desc("[2] Download the requested preview after selecting a matching candidate from preview_result").
Params(downloadParams).
Set("mode", "download").
Set("requested_type", runtime.Str("type")).
Set("requested_type", requestedType).
Set("output", runtime.Str("output"))
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
@@ -82,9 +101,25 @@ var DrivePreview = common.Shortcut{
body["version"] = version
}
if requestedType == "source_file" {
fmt.Fprintf(runtime.IO().ErrOut, "Downloading source file artifact: %s\n", common.MaskToken(fileToken))
result, err := downloadDrivePreviewArtifact(ctx, runtime, fileToken, drivePreviewTypeSourceFile, version, outputPath, ifExists, drivePreviewFallbackExt("source_file"))
if err != nil {
return err
}
result["mode"] = "download"
result["file_token"] = fileToken
result["selected_type"] = "source_file"
runtime.Out(result, nil)
return nil
}
fmt.Fprintf(runtime.IO().ErrOut, "Fetching preview candidates: %s\n", common.MaskToken(fileToken))
data, candidates, err := fetchDrivePreviewCandidates(runtime, fileToken, body)
if err != nil {
if runtime.Bool("list-only") {
return withDrivePreviewSourceFileHint(err)
}
return err
}
if runtime.Bool("list-only") {

View File

@@ -27,6 +27,8 @@ const (
drivePreviewIfExistsError = "error"
drivePreviewIfExistsOverwrite = "overwrite"
drivePreviewIfExistsRename = "rename"
drivePreviewTypeSourceFile = "16"
drivePreviewSourceFileHint = "Preview candidates are unavailable for this file. To fetch the source file artifact, rerun with --type source_file --output <path>."
)
type drivePreviewCandidate struct {
@@ -88,7 +90,9 @@ var drivePreviewMimeToExt = map[string]string{
"image/webp": ".webp",
"text/csv": ".csv",
"text/html": ".html",
"text/markdown": ".md",
"text/plain": ".txt",
"text/x-markdown": ".md",
"text/xml": ".xml",
"video/mp4": ".mp4",
"application/octet-stream": "",
@@ -464,7 +468,7 @@ func downloadDrivePreviewArtifactWithParams(ctx context.Context, runtime *common
}
defer resp.Body.Close()
finalPath, _, err := resolveDrivePreviewOutputPath(runtime, outputPath, resp.Header, fallbackExt, ifExists)
finalPath, _, err := resolveDrivePreviewOutputPath(runtime, outputPath, resp.Header, fallbackExt, ifExists, fileToken)
if err != nil {
return nil, err
}
@@ -492,8 +496,8 @@ func downloadDrivePreviewArtifactWithParams(ctx context.Context, runtime *common
// resolveDrivePreviewOutputPath finalizes the save path, applying extension
// inference and the selected collision policy.
func resolveDrivePreviewOutputPath(runtime *common.RuntimeContext, outputPath string, header http.Header, fallbackExt, ifExists string) (string, *driveExtensionResolution, error) {
finalPath, resolution := autoAppendDrivePreviewExtension(outputPath, header, fallbackExt)
func resolveDrivePreviewOutputPath(runtime *common.RuntimeContext, outputPath string, header http.Header, fallbackExt, ifExists, fallbackName string) (string, *driveExtensionResolution, error) {
finalPath, resolution := resolveDrivePreviewOutputPathName(runtime, outputPath, header, fallbackExt, fallbackName)
if _, err := runtime.ResolveSavePath(finalPath); err != nil {
return "", nil, errs.NewValidationError(errs.SubtypeInvalidArgument, "unsafe output path: %s", err).WithParam("--output")
}
@@ -522,6 +526,32 @@ func resolveDrivePreviewOutputPath(runtime *common.RuntimeContext, outputPath st
}
}
func resolveDrivePreviewOutputPathName(runtime *common.RuntimeContext, outputPath string, header http.Header, fallbackExt, fallbackName string) (string, *driveExtensionResolution) {
if drivePreviewOutputIsDirectory(runtime, outputPath) {
fileName, resolution := drivePreviewDefaultFileName(header, fallbackExt, fallbackName)
return filepath.Join(outputPath, fileName), resolution
}
return autoAppendDrivePreviewExtension(outputPath, header, fallbackExt)
}
func drivePreviewOutputIsDirectory(runtime *common.RuntimeContext, outputPath string) bool {
if strings.HasSuffix(outputPath, "/") || strings.HasSuffix(outputPath, "\\") {
return true
}
info, err := runtime.FileIO().Stat(outputPath)
return err == nil && info.IsDir()
}
func drivePreviewDefaultFileName(header http.Header, fallbackExt, fallbackName string) (string, *driveExtensionResolution) {
name := driveDownloadNormalizeFileName(larkcore.FileNameByHeader(header))
if name == "" {
name = driveDownloadNormalizeFileName(fallbackName)
}
name = sanitizeExportFileName(name, "preview")
name, resolution := autoAppendDrivePreviewExtension(name, header, fallbackExt)
return name, resolution
}
// nextAvailableDrivePreviewPath finds the first unused "name (n)" variant for a
// target output path.
func nextAvailableDrivePreviewPath(fio fileio.FileIO, path string) (string, error) {
@@ -556,6 +586,15 @@ func autoAppendDrivePreviewExtension(outputPath string, header http.Header, fall
if filepath.Ext(outputPath) == "." {
normalizedPath = strings.TrimSuffix(outputPath, ".")
}
if fallbackExt == "" {
if resolution := drivePreviewExtensionByContentDisposition(header); resolution != nil {
return normalizedPath + resolution.Ext, resolution
}
if resolution := drivePreviewExtensionByContentType(header.Get("Content-Type")); resolution != nil {
return normalizedPath + resolution.Ext, resolution
}
return normalizedPath, nil
}
if resolution := drivePreviewExtensionByContentType(header.Get("Content-Type")); resolution != nil {
return normalizedPath + resolution.Ext, resolution
}
@@ -804,6 +843,36 @@ func wrapDrivePreviewNotReady(fileToken, requested string, candidate drivePrevie
return errs.NewValidationError(errs.SubtypeFailedPrecondition, reason).WithHint(hint).WithParam("--type")
}
// withDrivePreviewSourceFileHint adds source_file guidance to preview candidate
// API failures without changing their classification or server diagnostics.
func withDrivePreviewSourceFileHint(err error) error {
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryAPI {
return err
}
if problem.Retryable || problem.Subtype == errs.SubtypeRateLimit {
return err
}
if strings.Contains(problem.Hint, "--type source_file") {
return err
}
if !isDrivePreviewCandidatesUnavailableProblem(problem) {
return err
}
if strings.TrimSpace(problem.Hint) == "" {
problem.Hint = drivePreviewSourceFileHint
return err
}
problem.Hint = strings.TrimSpace(problem.Hint) + " " + drivePreviewSourceFileHint
return err
}
func isDrivePreviewCandidatesUnavailableProblem(problem *errs.Problem) bool {
return problem != nil &&
problem.Code == 1 &&
strings.Contains(problem.Message, "mGetFilePreviewCore failed")
}
// wrapDriveCoverUnavailable builds a validation error for an unknown cover
// spec.
func wrapDriveCoverUnavailable(requested string) error {

View File

@@ -147,6 +147,63 @@ func TestDrivePreviewDownloadUsesResolvedTypeCodeAndRenamePolicy(t *testing.T) {
}
}
// TestDrivePreviewSourceFileDirectDownloadSkipsPreviewResult verifies
// source_file downloads the source file artifact without first fetching preview
// candidates.
func TestDrivePreviewSourceFileDirectDownloadSkipsPreviewResult(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, driveTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/medias/file_source/preview_download?preview_type=16",
Status: 200,
Body: []byte("# markdown\n"),
Headers: http.Header{
"Content-Disposition": []string{`attachment; filename="README.md"`},
"Content-Type": []string{"text/plain; charset=utf-8"},
},
})
tmpDir := t.TempDir()
withDriveWorkingDir(t, tmpDir)
err := mountAndRunDrive(t, DrivePreview, []string{
"+preview",
"--file-token", "file_source",
"--type", "source_file",
"--output", "artifacts/",
"--as", "bot",
}, f, stdout)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
data := decodeDriveEnvelope(t, stdout)
if _, ok := data["requested_type"]; ok {
t.Fatalf("requested_type should be omitted from execute output: %#v", data)
}
if got := data["selected_type"]; got != "source_file" {
t.Fatalf("selected_type=%v, want source_file", got)
}
if _, ok := data["selected_type_code"]; ok {
t.Fatalf("selected_type_code should be omitted from execute output: %#v", data)
}
resolvedTmpDir, err := filepath.EvalSymlinks(tmpDir)
if err != nil {
t.Fatalf("EvalSymlinks() error: %v", err)
}
wantPath := filepath.Join(resolvedTmpDir, "artifacts", "README.md")
if got := data["output_path"]; got != wantPath {
t.Fatalf("output_path=%v, want %s", got, wantPath)
}
gotBody, err := os.ReadFile(wantPath)
if err != nil {
t.Fatalf("ReadFile(%q) error: %v", wantPath, err)
}
if string(gotBody) != "# markdown\n" {
t.Fatalf("saved body=%q, want markdown source", string(gotBody))
}
}
// TestDrivePreviewRejectsUnavailableType verifies unavailable preview types
// return an actionable validation error.
func TestDrivePreviewRejectsUnavailableType(t *testing.T) {
@@ -434,6 +491,72 @@ func TestDrivePreviewDryRunIncludesVersionAndMode(t *testing.T) {
}
}
// TestDrivePreviewDryRunSourceFileDocumentsDirectDownload verifies source_file
// dry-run documents the direct source artifact download path.
func TestDrivePreviewDryRunSourceFileDocumentsDirectDownload(t *testing.T) {
runtime := newDrivePreviewRuntime(t, "drive +preview", map[string]string{
"file-token": "file_source",
"type": "source_file",
"version": "7",
"output": "source",
}, nil)
data := decodeDryRunOutput(t, DrivePreview.DryRun(context.Background(), runtime))
if got := data["mode"]; got != "download" {
t.Fatalf("mode=%v, want download", got)
}
if got := data["requested_type"]; got != "source_file" {
t.Fatalf("requested_type=%v, want source_file", got)
}
if got := data["selected_type"]; got != "source_file" {
t.Fatalf("selected_type=%v, want source_file", got)
}
if got := data["selected_type_code"]; got != drivePreviewTypeSourceFile {
t.Fatalf("selected_type_code=%v, want %s", got, drivePreviewTypeSourceFile)
}
api, _ := data["api"].([]interface{})
if len(api) != 1 {
t.Fatalf("len(api)=%d, want 1", len(api))
}
call, _ := api[0].(map[string]interface{})
if got := call["method"]; got != "GET" {
t.Fatalf("method=%v, want GET", got)
}
if got := call["url"]; got != "/open-apis/drive/v1/medias/file_source/preview_download" {
t.Fatalf("url=%v, want preview_download", got)
}
params, _ := call["params"].(map[string]interface{})
if got := params["preview_type"]; got != drivePreviewTypeSourceFile {
t.Fatalf("params.preview_type=%v, want %s", got, drivePreviewTypeSourceFile)
}
if got := params["version"]; got != "7" {
t.Fatalf("params.version=%v, want 7", got)
}
}
// TestDrivePreviewDryRunSourceAliasUsesPreviewCandidates verifies only the
// explicit source_file request bypasses preview_result.
func TestDrivePreviewDryRunSourceAliasUsesPreviewCandidates(t *testing.T) {
runtime := newDrivePreviewRuntime(t, "drive +preview", map[string]string{
"file-token": "file_source",
"type": "source",
"output": "source",
}, nil)
data := decodeDryRunOutput(t, DrivePreview.DryRun(context.Background(), runtime))
api, _ := data["api"].([]interface{})
if len(api) != 2 {
t.Fatalf("len(api)=%d, want 2", len(api))
}
call, _ := api[0].(map[string]interface{})
if got := call["url"]; got != "/open-apis/drive/v1/medias/file_source/preview_result" {
t.Fatalf("url=%v, want preview_result", got)
}
if _, ok := data["selected_type_code"]; ok {
t.Fatalf("selected_type_code should be omitted for non-source_file dry-run: %#v", data)
}
}
// TestDrivePreviewDryRunListOmitsBodyWithoutVersion verifies list-mode DryRun
// omits the request body when no version is supplied.
func TestDrivePreviewDryRunListOmitsBodyWithoutVersion(t *testing.T) {
@@ -612,6 +735,135 @@ func TestDrivePreviewNotReadyReturnsFailedPrecondition(t *testing.T) {
}
}
// TestDrivePreviewListOnlyErrorAddsSourceFileHint verifies preview_result API
// failures keep server diagnostics while guiding callers to source_file.
func TestDrivePreviewListOnlyErrorAddsSourceFileHint(t *testing.T) {
f, _, _, reg := cmdutil.TestFactory(t, driveTestConfig())
reg.Register(&httpmock.Stub{
Method: "POST",
URL: "/open-apis/drive/v1/medias/file_markdown/preview_result",
Body: map[string]interface{}{
"code": 1,
"msg": "fail:mGetFilePreviewCore failed",
"log_id": "log-preview-result",
"error": map[string]interface{}{
"troubleshooter": "https://open.feishu.cn/document/troubleshoot/preview-result",
"details": []interface{}{
map[string]interface{}{"value": "server preview_result detail"},
},
},
},
})
err := mountAndRunDrive(t, DrivePreview, []string{
"+preview",
"--file-token", "file_markdown",
"--list-only",
"--as", "bot",
}, f, nil)
if err == nil {
t.Fatal("expected preview_result error, got nil")
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("expected typed error, got %T: %v", err, err)
}
if problem.Category != errs.CategoryAPI {
t.Fatalf("category=%q, want api", problem.Category)
}
if problem.Code != 1 {
t.Fatalf("code=%d, want 1", problem.Code)
}
if problem.LogID != "log-preview-result" {
t.Fatalf("log_id=%q, want log-preview-result", problem.LogID)
}
if problem.Troubleshooter != "https://open.feishu.cn/document/troubleshoot/preview-result" {
t.Fatalf("troubleshooter=%q, want passthrough", problem.Troubleshooter)
}
if !strings.Contains(problem.Hint, "server preview_result detail") {
t.Fatalf("hint=%q, want server detail preserved", problem.Hint)
}
if !strings.Contains(problem.Hint, "--type source_file") || !strings.Contains(problem.Hint, "--output") {
t.Fatalf("hint=%q, want source_file output guidance", problem.Hint)
}
}
// TestDrivePreviewListOnlyRateLimitKeepsOriginalHint verifies retryable API
// errors are not reframed as source_file recovery.
func TestDrivePreviewListOnlyRateLimitKeepsOriginalHint(t *testing.T) {
err := withDrivePreviewSourceFileHint(errs.NewAPIError(errs.SubtypeRateLimit, "request trigger frequency limit").WithCode(99991400).WithRetryable())
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("expected typed error, got %T: %v", err, err)
}
if problem.Hint != "" {
t.Fatalf("hint=%q, want empty hint for rate limit", problem.Hint)
}
if !problem.Retryable {
t.Fatal("retryable=false, want true")
}
}
// TestDrivePreviewSourceFileHintGuards verifies source_file recovery guidance
// only rewrites eligible API errors and preserves existing source_file hints.
func TestDrivePreviewSourceFileHintGuards(t *testing.T) {
plainErr := errors.New("plain failure")
if got := withDrivePreviewSourceFileHint(plainErr); got != plainErr {
t.Fatalf("non-API error changed: got %T %v, want original", got, got)
}
for _, tt := range []struct {
name string
err *errs.APIError
want string
}{
{
name: "already has source file hint",
err: errs.NewAPIError(errs.SubtypeServerError, "preview_result failed").WithHint("rerun with --type source_file --output <path>"),
want: "rerun with --type source_file --output <path>",
},
{
name: "candidate core failure empty hint",
err: errs.NewAPIError(errs.SubtypeServerError, "fail:mGetFilePreviewCore failed").WithCode(1),
want: drivePreviewSourceFileHint,
},
{
name: "candidate core failure whitespace hint",
err: errs.NewAPIError(errs.SubtypeServerError, "fail:mGetFilePreviewCore failed").WithCode(1).WithHint(" \n\t "),
want: drivePreviewSourceFileHint,
},
{
name: "generic server error",
err: errs.NewAPIError(errs.SubtypeServerError, "preview_result failed"),
want: "",
},
{
name: "not found",
err: errs.NewAPIError(errs.SubtypeNotFound, "file not found").WithCode(1061044),
want: "",
},
{
name: "invalid parameters",
err: errs.NewAPIError(errs.SubtypeInvalidParameters, "invalid file token").WithCode(1063007),
want: "",
},
} {
t.Run(tt.name, func(t *testing.T) {
gotErr := withDrivePreviewSourceFileHint(tt.err)
if gotErr != tt.err {
t.Fatalf("API error pointer changed: got %T, want original", gotErr)
}
problem, ok := errs.ProblemOf(gotErr)
if !ok {
t.Fatalf("expected typed error, got %T: %v", gotErr, gotErr)
}
if problem.Hint != tt.want {
t.Fatalf("hint=%q, want %q", problem.Hint, tt.want)
}
})
}
}
// TestDriveCoverRejectsUnknownSpec verifies unsupported cover specs produce a
// validation error with available alternatives.
func TestDriveCoverRejectsUnknownSpec(t *testing.T) {
@@ -721,6 +973,21 @@ func TestDrivePreviewCommonHelpers(t *testing.T) {
if path != "cover.pdf" || fallback != nil {
t.Fatalf("explicit ext append = (%q, %+v), want unchanged path", path, fallback)
}
header = http.Header{}
header.Set("Content-Type", "text/plain")
header.Set("Content-Disposition", `attachment; filename="README.md"`)
path, fallback = autoAppendDrivePreviewExtension("source", header, "")
if path != "source.md" || fallback == nil || fallback.Source != "Content-Disposition" {
t.Fatalf("source_file append = (%q, %+v), want source.md from Content-Disposition", path, fallback)
}
header = http.Header{}
header.Set("Content-Type", "text/plain")
path, fallback = autoAppendDrivePreviewExtension("source", header, "")
if path != "source.txt" || fallback == nil || fallback.Source != "Content-Type" {
t.Fatalf("source_file content-type append = (%q, %+v), want source.txt from Content-Type", path, fallback)
}
}
// TestDrivePreviewMetadataAndPathResolution verifies metadata normalization
@@ -751,7 +1018,7 @@ func TestDrivePreviewMetadataAndPathResolution(t *testing.T) {
runtime := newDrivePreviewRuntime(t, "drive +preview", nil, nil)
header := http.Header{}
header.Set("Content-Type", "application/pdf")
renamed, _, err := resolveDrivePreviewOutputPath(runtime, "preview", header, ".pdf", drivePreviewIfExistsRename)
renamed, _, err := resolveDrivePreviewOutputPath(runtime, "preview", header, ".pdf", drivePreviewIfExistsRename, "file_preview")
if err != nil {
t.Fatalf("resolveDrivePreviewOutputPath(rename) error: %v", err)
}
@@ -759,7 +1026,7 @@ func TestDrivePreviewMetadataAndPathResolution(t *testing.T) {
t.Fatalf("renamed=%q, want preview (1).pdf suffix", renamed)
}
_, _, err = resolveDrivePreviewOutputPath(runtime, "preview", header, ".pdf", "keep")
_, _, err = resolveDrivePreviewOutputPath(runtime, "preview", header, ".pdf", "keep", "file_preview")
if err == nil {
t.Fatal("expected invalid if-exists error, got nil")
}
@@ -771,6 +1038,20 @@ func TestDrivePreviewMetadataAndPathResolution(t *testing.T) {
t.Fatalf("param=%q, want --if-exists", validationErr.Param)
}
if err := os.Mkdir("artifacts", 0755); err != nil {
t.Fatalf("Mkdir() error: %v", err)
}
sourceHeader := http.Header{}
sourceHeader.Set("Content-Type", "text/plain")
sourceHeader.Set("Content-Disposition", `attachment; filename="README.md"`)
dirOutput, _, err := resolveDrivePreviewOutputPath(runtime, "artifacts", sourceHeader, "", drivePreviewIfExistsError, "file_source")
if err != nil {
t.Fatalf("resolveDrivePreviewOutputPath(directory) error: %v", err)
}
if !strings.HasSuffix(dirOutput, filepath.Join("artifacts", "README.md")) {
t.Fatalf("dirOutput=%q, want artifacts/README.md suffix", dirOutput)
}
unusedPath, err := nextAvailableDrivePreviewPath(runtime.FileIO(), "fresh.pdf")
if err != nil {
t.Fatalf("nextAvailableDrivePreviewPath(unused) error: %v", err)
@@ -779,7 +1060,7 @@ func TestDrivePreviewMetadataAndPathResolution(t *testing.T) {
t.Fatalf("unusedPath=%q, want fresh.pdf", unusedPath)
}
overwritten, _, err := resolveDrivePreviewOutputPath(runtime, "preview.pdf", header, ".pdf", drivePreviewIfExistsOverwrite)
overwritten, _, err := resolveDrivePreviewOutputPath(runtime, "preview.pdf", header, ".pdf", drivePreviewIfExistsOverwrite, "file_preview")
if err != nil {
t.Fatalf("resolveDrivePreviewOutputPath(overwrite) error: %v", err)
}
@@ -791,7 +1072,7 @@ func TestDrivePreviewMetadataAndPathResolution(t *testing.T) {
f.FileIOProvider = &statErrorProvider{inner: f.FileIOProvider, err: fs.ErrPermission}
runtimeWithStatErr := newDrivePreviewRuntime(t, "drive +preview", nil, nil)
runtimeWithStatErr.Factory = f
_, _, err = resolveDrivePreviewOutputPath(runtimeWithStatErr, "blocked.pdf", header, ".pdf", drivePreviewIfExistsError)
_, _, err = resolveDrivePreviewOutputPath(runtimeWithStatErr, "blocked.pdf", header, ".pdf", drivePreviewIfExistsError, "file_preview")
if err == nil {
t.Fatal("expected stat permission error, got nil")
}
@@ -876,7 +1157,6 @@ func TestDrivePreviewAliasAndAvailabilityHelpers(t *testing.T) {
if got := normalizeDrivePreviewRequest(" Source File "); got != "source_file" {
t.Fatalf("normalizeDrivePreviewRequest()=%q, want source_file", got)
}
aliases := previewAliasesForCandidate(drivePreviewCandidate{TypeCode: "1"})
if len(aliases) == 0 || aliases[0] != "image" {
t.Fatalf("previewAliasesForCandidate()=%v, want image alias", aliases)

View File

@@ -6,12 +6,10 @@ package im
import (
"context"
"encoding/json"
"errors"
"reflect"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/shortcuts/common"
"github.com/spf13/cobra"
@@ -412,23 +410,6 @@ func TestShortcutValidateBranches(t *testing.T) {
if err == nil || !strings.Contains(err.Error(), "--content is not valid JSON") {
t.Fatalf("ImMessagesSend.Validate() error = %v", err)
}
if !strings.Contains(err.Error(), "--text") {
t.Fatalf("ImMessagesSend.Validate() error = %v, want it to mention --text as a recovery alternative", err)
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("ImMessagesSend.Validate() error is not a typed Problem: %v", err)
}
if problem.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("ImMessagesSend.Validate() Subtype = %v, want %v", problem.Subtype, errs.SubtypeInvalidArgument)
}
var verr *errs.ValidationError
if !errors.As(err, &verr) {
t.Fatalf("ImMessagesSend.Validate() error is not *errs.ValidationError: %v", err)
}
if verr.Param != "--content" {
t.Fatalf("ImMessagesSend.Validate() Param = %q, want --content", verr.Param)
}
})
t.Run("ImMessagesSend media with text", func(t *testing.T) {
@@ -670,23 +651,6 @@ func TestShortcutValidateBranches(t *testing.T) {
if err == nil || !strings.Contains(err.Error(), "requires user identity") {
t.Fatalf("ImChatMessageList.Validate() error = %v, want requires user identity", err)
}
if !strings.Contains(err.Error(), "--as user") || !strings.Contains(err.Error(), "--chat-id") {
t.Fatalf("ImChatMessageList.Validate() error = %v, want it to mention both --as user and --chat-id as recovery actions", err)
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("ImChatMessageList.Validate() error is not a typed Problem: %v", err)
}
if problem.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("ImChatMessageList.Validate() Subtype = %v, want %v", problem.Subtype, errs.SubtypeInvalidArgument)
}
var verr *errs.ValidationError
if !errors.As(err, &verr) {
t.Fatalf("ImChatMessageList.Validate() error is not *errs.ValidationError: %v", err)
}
if verr.Param != "--user-id" {
t.Fatalf("ImChatMessageList.Validate() Param = %q, want --user-id", verr.Param)
}
})
t.Run("ImMessagesMGet empty ids", func(t *testing.T) {
@@ -747,7 +711,7 @@ func TestShortcutValidateBranches(t *testing.T) {
"page-limit": "41",
}, nil)
err := ImMessagesSearch.Validate(context.Background(), runtime)
if err == nil || !strings.Contains(err.Error(), "--page-limit must be between 0 and 40") {
if err == nil || !strings.Contains(err.Error(), "--page-limit must be an integer between 1 and 40") {
t.Fatalf("ImMessagesSearch.Validate() error = %v", err)
}
})
@@ -797,7 +761,7 @@ func TestMessagesSearchPaginationConfig(t *testing.T) {
}
})
t.Run("page all keeps the safe default limit", func(t *testing.T) {
t.Run("page all uses max limit", func(t *testing.T) {
runtime := newMessagesSearchTestRuntimeContext(t, nil, map[string]bool{
"page-all": true,
})
@@ -805,33 +769,19 @@ func TestMessagesSearchPaginationConfig(t *testing.T) {
if !autoPaginate {
t.Fatal("messagesSearchPaginationConfig() autoPaginate = false, want true")
}
if pageLimit != messagesSearchDefaultPageLimit {
t.Fatalf("messagesSearchPaginationConfig() pageLimit = %d, want %d", pageLimit, messagesSearchDefaultPageLimit)
if pageLimit != messagesSearchMaxPageLimit {
t.Fatalf("messagesSearchPaginationConfig() pageLimit = %d, want %d", pageLimit, messagesSearchMaxPageLimit)
}
})
t.Run("explicit page all honors page limit", func(t *testing.T) {
runtime := newMessagesSearchTestRuntimeContext(t, map[string]string{
"query": "incident",
"page-limit": "3",
}, map[string]bool{"page-all": true})
if err := ImMessagesSearch.Validate(context.Background(), runtime); err != nil {
t.Fatalf("ImMessagesSearch.Validate() error = %v, want valid explicit --page-limit", err)
}
autoPaginate, pageLimit := messagesSearchPaginationConfig(runtime)
if !autoPaginate {
t.Fatal("messagesSearchPaginationConfig() autoPaginate = false, want true")
}
if pageLimit != 3 {
t.Fatalf("messagesSearchPaginationConfig() pageLimit = %d, want 3", pageLimit)
}
})
t.Run("explicit page limit preserves legacy auto pagination", func(t *testing.T) {
t.Run("explicit page limit enables auto pagination", func(t *testing.T) {
runtime := newMessagesSearchTestRuntimeContext(t, map[string]string{
"query": "incident",
"page-limit": "3",
}, nil)
if err := ImMessagesSearch.Validate(context.Background(), runtime); err != nil {
t.Fatalf("ImMessagesSearch.Validate() error = %v, want valid explicit --page-limit", err)
}
autoPaginate, pageLimit := messagesSearchPaginationConfig(runtime)
if !autoPaginate {
t.Fatal("messagesSearchPaginationConfig() autoPaginate = false, want true")

View File

@@ -17,7 +17,6 @@ import (
larkcore "github.com/larksuite/oapi-sdk-go/v3/core"
"github.com/spf13/cobra"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/cmdutil"
)
@@ -99,10 +98,7 @@ func TestReadDurationHelpersInvalid(t *testing.T) {
}
func TestResolveMarkdownAsPost(t *testing.T) {
got, err := resolveMarkdownAsPost(context.Background(), nil, "# Title\n## Subtitle\n\nbody")
if err != nil {
t.Fatalf("resolveMarkdownAsPost() error = %v", err)
}
got := resolveMarkdownAsPost(context.Background(), nil, "# Title\n## Subtitle\n\nbody")
if !strings.Contains(got, `"tag":"md"`) {
t.Fatalf("resolveMarkdownAsPost() = %q, want post payload", got)
}
@@ -114,33 +110,6 @@ func TestResolveMarkdownAsPost(t *testing.T) {
}
}
// TestResolveMarkdownImageURLsFailureAborts locks the governance contract for
// markdown images that fail to resolve: the whole send aborts — the image is
// never silently stripped, because the user approved a draft that includes it.
func TestResolveMarkdownImageURLsFailureAborts(t *testing.T) {
runtime := newBotShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
return nil, fmt.Errorf("unexpected request: %s", req.URL.String())
}))
md := "before ![diagram](http://127.0.0.1/pic.png) after"
got, err := resolveMarkdownImageURLs(context.Background(), runtime, md)
if err == nil {
t.Fatalf("resolveMarkdownImageURLs() = (%q, nil), want hard error instead of stripping the image", got)
}
if got != "" {
t.Fatalf("resolveMarkdownImageURLs() returned content %q alongside error", got)
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("resolveMarkdownImageURLs() error is not a typed Problem: %v", err)
}
for _, want := range []string{"nothing was sent", "approval"} {
if !strings.Contains(problem.Hint, want) {
t.Fatalf("resolveMarkdownImageURLs() hint = %q, want it to contain %q", problem.Hint, want)
}
}
}
func TestValidateContentFlags(t *testing.T) {
tests := []struct {
name string
@@ -527,11 +496,7 @@ func TestParseMediaDurationSuccess(t *testing.T) {
})
}
// TestResolveMediaContentURLUploadFailure locks the governance contract for
// URL media whose upload fails: the send must hard-fail with a re-approval
// hint — never downgrade to a "[... upload failed, sending link]" text the
// user never approved (the pre-governance fallback behavior).
func TestResolveMediaContentURLUploadFailure(t *testing.T) {
func TestResolveMediaContentURLFallback(t *testing.T) {
runtime := newBotShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
return nil, fmt.Errorf("unexpected request: %s", req.URL.String())
}))
@@ -543,30 +508,26 @@ func TestResolveMediaContentURLUploadFailure(t *testing.T) {
video string
videoCover string
audio string
wantType string
wantText string
}{
{name: "image URL upload failure", image: "https://mock.example.com/image.png"},
{name: "file URL upload failure", file: "https://mock.example.com/report.pdf"},
{name: "video URL upload failure", video: "https://mock.example.com/video.mp4", videoCover: "img_cover_x"},
{name: "audio URL upload failure", audio: "https://mock.example.com/audio.ogg"},
{name: "image URL fallback", image: "http://127.0.0.1/image.png", wantType: "text", wantText: "[image upload failed, sending link] http://127.0.0.1/image.png"},
{name: "file URL fallback", file: "http://127.0.0.1/report.pdf", wantType: "text", wantText: "[file upload failed, sending link] http://127.0.0.1/report.pdf"},
{name: "video URL fallback", video: "http://127.0.0.1/video.mp4", videoCover: "img_cover_x", wantType: "text", wantText: "[video upload failed, sending link] http://127.0.0.1/video.mp4"},
{name: "audio URL fallback", audio: "http://127.0.0.1/audio.ogg", wantType: "text", wantText: "[audio upload failed, sending link] http://127.0.0.1/audio.ogg"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gotType, gotContent, err := resolveMediaContent(context.Background(), runtime, "", tt.image, tt.file, tt.video, tt.videoCover, tt.audio)
if err == nil {
t.Fatalf("resolveMediaContent() = (%q, %q, nil), want hard error instead of text fallback", gotType, gotContent)
if err != nil {
t.Fatalf("resolveMediaContent() error = %v", err)
}
if gotType != "" || gotContent != "" {
t.Fatalf("resolveMediaContent() returned content (%q, %q) alongside error", gotType, gotContent)
if gotType != tt.wantType {
t.Fatalf("resolveMediaContent() type = %q, want %q", gotType, tt.wantType)
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("resolveMediaContent() error is not a typed Problem: %v", err)
}
for _, want := range []string{"nothing was sent", "--text", "approval"} {
if !strings.Contains(problem.Hint, want) {
t.Fatalf("resolveMediaContent() hint = %q, want it to contain %q (explicit re-approval path)", problem.Hint, want)
}
if !strings.Contains(gotContent, tt.wantText) {
t.Fatalf("resolveMediaContent() content = %q, want substring %q", gotContent, tt.wantText)
}
})
}

View File

@@ -23,7 +23,6 @@ import (
"github.com/larksuite/cli/extension/fileio"
"github.com/larksuite/cli/internal/auth"
"github.com/larksuite/cli/internal/credential"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/validate"
"github.com/larksuite/cli/shortcuts/common"
larkcore "github.com/larksuite/oapi-sdk-go/v3/core"
@@ -327,19 +326,10 @@ func resolveOneMedia(ctx context.Context, runtime *common.RuntimeContext, s medi
return s.value, nil
}
var (
key string
err error
)
if isURL(s.value) {
key, err = resolveURLMedia(ctx, runtime, s)
} else {
key, err = resolveLocalMedia(ctx, runtime, s)
return resolveURLMedia(ctx, runtime, s)
}
if err == nil {
runtime.RecordContractFact(imcontract.Fact{Kind: imcontract.FactMediaPreuploadPerformed})
}
return key, err
return resolveLocalMedia(ctx, runtime, s)
}
// resolveURLMedia downloads a URL and uploads it.
@@ -410,29 +400,14 @@ func resolveVideoContent(ctx context.Context, runtime *common.RuntimeContext, vi
return "media", string(jsonBytes), nil
}
// mediaUploadFallbackHint is the recovery path for a failed URL-media upload.
// The CLI must never rewrite approved content on its own, so the degraded
// form (a plain text link) is only reachable through explicit re-approval.
const mediaUploadFallbackHint = "nothing was sent — to fall back to sending the link as plain text, show the user the degraded content and, after their approval, re-send it explicitly with --text"
// mediaFallbackOrError returns a hard error when a media upload fails.
// A failed URL upload used to downgrade to a "[... upload failed, sending
// link]" text message, which sent the recipient wording the user never saw
// or approved. Now nothing is sent; for URL inputs the hint points at the
// explicit re-approval path. An already-typed cause keeps its classification
// (and its own hint, when it has one).
// mediaFallbackOrError returns a text fallback for URL inputs when upload fails,
// or a hard error for local file inputs.
func mediaFallbackOrError(originalValue, mediaType string, uploadErr error) (string, string, error) {
if isURL(originalValue) {
if p, ok := errs.ProblemOf(uploadErr); ok {
if p.Hint == "" {
p.Hint = mediaUploadFallbackHint
}
return "", "", uploadErr
}
return "", "", errs.NewNetworkError(errs.SubtypeNetworkTransport,
"%s upload failed for %s; nothing was sent", mediaType, sanitizeURLForDisplay(originalValue)).
WithCause(uploadErr).
WithHint("%s", mediaUploadFallbackHint)
// Fallback: send URL as text link instead of failing.
fallbackText := fmt.Sprintf("[%s upload failed, sending link] %s", mediaType, originalValue)
jsonBytes, _ := json.Marshal(map[string]string{"text": fallbackText})
return "text", string(jsonBytes), nil
}
return "", "", wrapIMNetworkErr(uploadErr, "%s upload failed", mediaType)
}
@@ -953,29 +928,20 @@ func wrapMarkdownAsPostForDryRun(markdown string) (content, desc string) {
// resolveMarkdownAsPost resolves image URLs in markdown, applies style optimization,
// and wraps as post format JSON. Used by Execute (makes network calls).
func resolveMarkdownAsPost(ctx context.Context, runtime *common.RuntimeContext, markdown string) (string, error) {
resolved, err := resolveMarkdownImageURLs(ctx, runtime, markdown)
if err != nil {
return "", err
}
func resolveMarkdownAsPost(ctx context.Context, runtime *common.RuntimeContext, markdown string) string {
resolved := resolveMarkdownImageURLs(ctx, runtime, markdown)
optimized := optimizeMarkdownStyle(resolved)
inner, _ := json.Marshal(optimized)
return `{"zh_cn":{"content":[[{"tag":"md","text":` + string(inner) + `}]]}}`, nil
return `{"zh_cn":{"content":[[{"tag":"md","text":` + string(inner) + `}]]}}`
}
// resolveMarkdownImageURLs finds ![alt](https://...) in markdown, downloads each URL,
// uploads as image, and replaces with ![alt](img_xxx). A failed download or
// upload aborts the send: silently stripping the image would deliver content
// the user never approved (the message they saw included that image).
func resolveMarkdownImageURLs(ctx context.Context, runtime *common.RuntimeContext, markdown string) (string, error) {
// uploads as image, and replaces with ![alt](img_xxx). Failed uploads are stripped.
func resolveMarkdownImageURLs(ctx context.Context, runtime *common.RuntimeContext, markdown string) string {
if !strings.Contains(markdown, "![") {
return markdown, nil
return markdown
}
var resolveErr error
resolved := reMarkdownImage.ReplaceAllStringFunc(markdown, func(m string) string {
if resolveErr != nil {
return m
}
return reMarkdownImage.ReplaceAllStringFunc(markdown, func(m string) string {
sub := reMarkdownImage.FindStringSubmatch(m)
if len(sub) < 2 {
return m
@@ -984,18 +950,17 @@ func resolveMarkdownImageURLs(ctx context.Context, runtime *common.RuntimeContex
rc, _, err := downloadURLToReader(ctx, runtime, imgURL, maxImageUploadSize, "--markdown")
if err != nil {
resolveErr = markdownImageError(imgURL, "download", err)
return m
fmt.Fprintf(runtime.IO().ErrOut, "warning: failed to download image %s: %v\n", sanitizeURLForDisplay(imgURL), err)
return ""
}
defer rc.Close()
fmt.Fprintf(runtime.IO().ErrOut, "uploading image from URL: %s\n", sanitizeURLForDisplay(imgURL))
imgKey, err := uploadImageFromReader(ctx, runtime, rc, "message")
if err != nil {
resolveErr = markdownImageError(imgURL, "upload", err)
return m
fmt.Fprintf(runtime.IO().ErrOut, "warning: failed to upload image %s: %v\n", sanitizeURLForDisplay(imgURL), err)
return ""
}
runtime.RecordContractFact(imcontract.Fact{Kind: imcontract.FactMediaPreuploadPerformed})
// Reconstruct ![alt](img_xxx)
altStart := strings.Index(m, "[")
@@ -1006,33 +971,6 @@ func resolveMarkdownImageURLs(ctx context.Context, runtime *common.RuntimeContex
}
return fmt.Sprintf("![%s](%s)", alt, imgKey)
})
if resolveErr != nil {
return "", resolveErr
}
return resolved, nil
}
// markdownImageFallbackHint is the recovery path for a markdown image that
// could not be resolved: revise the draft explicitly instead of letting the
// CLI strip the image behind the user's back.
const markdownImageFallbackHint = "nothing was sent — remove the failing image from the markdown or replace it with a plain link, show the user the revised draft, and re-send after their approval"
// markdownImageError builds the hard error for a markdown image that could
// not be resolved. Stripping the image and sending the rest is forbidden —
// that would deliver content differing from what the user approved. An
// already-typed cause keeps its classification (and its own hint, when it
// has one).
func markdownImageError(imgURL, stage string, cause error) error {
if p, ok := errs.ProblemOf(cause); ok {
if p.Hint == "" {
p.Hint = markdownImageFallbackHint
}
return cause
}
return errs.NewNetworkError(errs.SubtypeNetworkTransport,
"markdown image %s failed for %s; nothing was sent", stage, sanitizeURLForDisplay(imgURL)).
WithCause(cause).
WithHint("%s", markdownImageFallbackHint)
}
// validateContentFlags checks mutual exclusion between content flags (text/markdown/content)
@@ -1544,7 +1482,7 @@ type shortcutItem struct {
func collectChatIDs(rt *common.RuntimeContext) ([]string, error) {
raw := rt.StrSlice("chat-id")
if len(raw) == 0 {
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument, "--chat-id is required (oc_xxx); repeat the flag or pass comma-separated values").WithParam("--chat-id").WithHint("get the open_chat_id from im +chat-search (by name) or im +chat-list (my chats)")
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument, "--chat-id is required (oc_xxx); repeat the flag or pass comma-separated values").WithParam("--chat-id")
}
seen := make(map[string]struct{}, len(raw))
@@ -1556,7 +1494,7 @@ func collectChatIDs(rt *common.RuntimeContext) ([]string, error) {
}
if !strings.HasPrefix(v, "oc_") {
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument,
"invalid --chat-id %q: must be an open_chat_id starting with oc_", v).WithParam("--chat-id").WithHint("get the open_chat_id from im +chat-search (by name) or im +chat-list (my chats)")
"invalid --chat-id %q: must be an open_chat_id starting with oc_", v).WithParam("--chat-id")
}
if _, ok := seen[v]; ok {
continue
@@ -1565,7 +1503,7 @@ func collectChatIDs(rt *common.RuntimeContext) ([]string, error) {
out = append(out, v)
}
if len(out) == 0 {
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument, "--chat-id is required (oc_xxx)").WithParam("--chat-id").WithHint("get the open_chat_id from im +chat-search (by name) or im +chat-list (my chats)")
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument, "--chat-id is required (oc_xxx)").WithParam("--chat-id")
}
if len(out) > feedShortcutBatchLimit {
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument,
@@ -1584,17 +1522,6 @@ func buildShortcutItems(ids []string) []shortcutItem {
return items
}
func shortcutItemsBody(items []shortcutItem) []any {
body := make([]any, 0, len(items))
for _, item := range items {
body = append(body, map[string]any{
"feed_card_id": item.FeedCardID,
"type": item.Type,
})
}
return body
}
// shortcutFailedReasonString converts the numeric failed-reason enum returned
// by the server into a human-readable label. Used to enrich the response
// when the API reports per-item failures.

View File

@@ -28,7 +28,6 @@ import (
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/credential"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/shortcuts/common"
)
@@ -119,47 +118,6 @@ func newUserShortcutRuntime(t *testing.T, rt http.RoundTripper) *common.RuntimeC
return runtime
}
func TestMediaHelperMarksSendAndReplyPreuploadAsNonReplayable(t *testing.T) {
tmp := t.TempDir()
if err := os.WriteFile(filepath.Join(tmp, "image.png"), []byte("image-bytes"), 0600); err != nil {
t.Fatal(err)
}
cmdutil.TestChdir(t, tmp)
for _, key := range []imcontract.ContractKey{"im +messages-send", "im +messages-reply"} {
t.Run(string(key), func(t *testing.T) {
runtime := newBotShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
if strings.Contains(req.URL.Path, "/open-apis/im/v1/images") {
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{"image_key": "img_uploaded"},
}), nil
}
return nil, fmt.Errorf("unexpected request: %s", req.URL.Path)
}))
contract, _ := imcontract.Lookup(key)
session := imcontract.NewSession(contract)
setRuntimeField(t, runtime, "contractSession", session)
got, err := resolveOneMedia(context.Background(), runtime, mediaSpec{
value: "image.png", flagName: "--image", mediaType: "image",
msgType: "image", kind: mediaKindImage, maxSize: maxImageUploadSize, resultKey: "image_key",
})
if err != nil || got != "img_uploaded" {
t.Fatalf("resolveOneMedia() = (%q, %v)", got, err)
}
session.ObserveRequest(map[string]any{"uuid": "stable-key"})
session.RecordFact(imcontract.Fact{Kind: imcontract.FactWriteAttempted})
unknown := errs.NewNetworkError(errs.SubtypeNetworkTransport, "send result unknown").WithRetryable()
problem, _ := errs.ProblemOf(session.FinalizeError(unknown))
if problem.Retryable ||
problem.Hint != "The write result is unknown. Do not replay the original request." {
t.Fatalf("problem = %#v", problem)
}
})
}
}
func TestResolveP2PChatID(t *testing.T) {
runtime := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
switch {

View File

@@ -438,46 +438,19 @@ func TestFileNameFromURL(t *testing.T) {
func TestMediaFallbackOrError(t *testing.T) {
testErr := errors.New("upload failed")
// URL input: must hard-fail — never downgrade to a text link the user
// never approved. The hint must point at the explicit re-approval path.
// URL input: should fallback to text
mt, content, err := mediaFallbackOrError("https://example.com/photo.jpg", "image", testErr)
if err == nil {
t.Fatalf("mediaFallbackOrError(URL) = (%q, %q, nil), want hard error", mt, content)
if err != nil {
t.Fatalf("mediaFallbackOrError(URL) returned error: %v", err)
}
if mt != "" || content != "" {
t.Fatalf("mediaFallbackOrError(URL) returned content (%q, %q) alongside error", mt, content)
if mt != "text" {
t.Fatalf("mediaFallbackOrError(URL) mt = %q, want text", mt)
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("mediaFallbackOrError(URL) error is not a typed Problem: %v", err)
}
if !strings.Contains(problem.Message, "nothing was sent") {
t.Fatalf("mediaFallbackOrError(URL) message = %q, want it to state nothing was sent", problem.Message)
}
if !strings.Contains(problem.Hint, "--text") || !strings.Contains(problem.Hint, "approval") {
t.Fatalf("mediaFallbackOrError(URL) hint = %q, want explicit --text re-approval path", problem.Hint)
if !strings.Contains(content, "https://example.com/photo.jpg") {
t.Fatalf("mediaFallbackOrError(URL) content missing URL: %s", content)
}
// A cause that is already a typed Problem passes through with its
// classification preserved and, lacking its own hint, gains the
// governance re-approval hint.
typedCause := errs.NewPermissionError(errs.SubtypePermissionDenied, "missing scope")
_, _, err = mediaFallbackOrError("https://example.com/photo.jpg", "image", typedCause)
if err != error(typedCause) {
t.Fatalf("mediaFallbackOrError(URL, typed cause) = %v, want the cause passed through", err)
}
if p, _ := errs.ProblemOf(err); p == nil || !strings.Contains(p.Hint, "--text") {
t.Fatalf("mediaFallbackOrError(URL, typed cause) hint = %v, want governance hint attached", p)
}
// A typed cause that already carries a hint keeps it.
hinted := errs.NewPermissionError(errs.SubtypePermissionDenied, "missing scope").WithHint("run auth login")
_, _, err = mediaFallbackOrError("https://example.com/photo.jpg", "image", hinted)
if p, _ := errs.ProblemOf(err); p == nil || p.Hint != "run auth login" {
t.Fatalf("mediaFallbackOrError(URL, hinted cause) hint = %v, want original hint kept", p)
}
// Local file input: hard error as before.
// Local file input: should return hard error
_, _, err = mediaFallbackOrError("./local.jpg", "image", testErr)
if err == nil {
t.Fatal("mediaFallbackOrError(local) should return error")
@@ -486,10 +459,7 @@ func TestMediaFallbackOrError(t *testing.T) {
func TestResolveMarkdownImageURLs_NoImages(t *testing.T) {
input := "just text, no images"
got, err := resolveMarkdownImageURLs(context.Background(), nil, input)
if err != nil {
t.Fatalf("resolveMarkdownImageURLs(no images) returned error: %v", err)
}
got := resolveMarkdownImageURLs(context.Background(), nil, input)
if got != input {
t.Fatalf("resolveMarkdownImageURLs(no images) changed text: %q", got)
}

View File

@@ -40,10 +40,6 @@ var ImChatCreate = common.Shortcut{
{Name: "chat-mode", Default: "group", Desc: "group mode (\"topic\" creates a topic chat; differs from a normal group in topic-message mode)", Enum: []string{"group", "topic"}},
{Name: "set-bot-manager", Type: "bool", Desc: "set the bot that creates this chat as manager (bot identity only)"},
},
Tips: []string{
`Example: lark-cli im +chat-create --name "project chat"`,
`Example: lark-cli im +chat-create --name "project chat" --users <open_id1>,<open_id2>`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
body := buildCreateChatBody(runtime)
params := map[string]interface{}{"user_id_type": "open_id"}
@@ -117,7 +113,7 @@ var ImChatCreate = common.Shortcut{
if runtime.Bool("set-bot-manager") {
qp["set_bot_manager"] = []string{"true"}
}
resData, err := runtime.DoWriteAPIJSONTyped(http.MethodPost, "/open-apis/im/v1/chats", qp, body)
resData, err := runtime.DoAPIJSONTyped(http.MethodPost, "/open-apis/im/v1/chats", qp, body)
if err != nil {
return err
}

View File

@@ -46,7 +46,7 @@ var ImChatList = common.Shortcut{
Scopes: []string{"im:chat:read"},
AuthTypes: []string{"user", "bot"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "user-id-type", Default: "open_id", Desc: "ID type for owner_id in response", Enum: []string{"open_id", "union_id", "user_id"}},
{Name: "sort", Default: "create_time", Desc: "sort field: create_time (ascending) | active_time (descending)", Enum: []string{"create_time", "active_time"}},
{Name: "sort-type", Hidden: true, Desc: "alias of --sort (hidden)", Enum: []string{"ByCreateTimeAsc", "ByActiveTimeDesc"}},
@@ -54,10 +54,6 @@ var ImChatList = common.Shortcut{
{Name: "page-size", Type: "int", Default: "20", Desc: "page size (1-100)"},
{Name: "page-token", Desc: "pagination token for next page"},
{Name: "exclude-muted", Type: "bool", Desc: "(user identity only) drop chats the current user has muted (do-not-disturb); bot identity returns all chats unfiltered"},
}, imPaginationFlags(imReadDefaultPageLimit)...),
Tips: []string{
`Example: lark-cli im +chat-list`,
`Example: lark-cli im +chat-list --sort active_time`,
},
// DryRun previews the GET /open-apis/im/v1/chats request without executing.
// When bot identity strips p2p from --types, emits the same stderr warning
@@ -87,7 +83,7 @@ var ImChatList = common.Shortcut{
return errs.NewValidationError(errs.SubtypeInvalidArgument,
`--types=p2p (single chats) is only supported with user identity (--as user). To protect user privacy, bot identity cannot list p2p chats. Use --as user, or include "group" in --types.`).WithParam("--types")
}
return validateIMPagination(runtime)
return nil
},
// Execute fetches one page of chats, optionally applies --exclude-muted
// via MaybeApplyMuteFilter, and renders the result. outData["filter"] is
@@ -100,23 +96,14 @@ var ImChatList = common.Shortcut{
if stripped {
writeBotStripP2pWarning(runtime.IO().ErrOut)
}
pages, status, pageErr := paginateIM(runtime, func(pageToken string) (map[string]any, error) {
params := buildChatListParams(runtime, effective)
if pageToken == "" {
delete(params, "page_token")
} else {
params["page_token"] = pageToken
}
return runtime.CallAPITyped("GET", imChatListPath, params, nil)
})
if len(pages) == 0 {
return pageErr
params := buildChatListParams(runtime, effective)
resData, err := runtime.CallAPITyped("GET", imChatListPath, params, nil)
if err != nil {
return err
}
runtime.RecordPagination(status)
resData := mergeIMPageArrays(pages, "items")
rawItems, _ := resData["items"].([]interface{})
hasMore, pageToken := status.HasMore, status.NextPageToken
hasMore, pageToken := common.PaginationMeta(resData)
var items []map[string]interface{}
for _, raw := range rawItems {

View File

@@ -9,6 +9,7 @@ import (
"fmt"
"io"
"strings"
"time"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
@@ -43,17 +44,17 @@ var ImChatMembersList = common.Shortcut{
// im:chat.members:read are honored (same rationale as +chat-list).
Scopes: []string{"im:chat.members:read"},
AuthTypes: []string{"user", "bot"},
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "chat-id", Required: true, Desc: "chat ID (oc_xxx)"},
{Name: "member-types", Type: "string_slice", Desc: "member types to return (user, bot); omit = all"},
{Name: "member-id-type", Default: "open_id", Desc: "ID type for member_id in response", Enum: []string{"open_id", "union_id", "user_id"}},
{Name: "page-size", Type: "int", Default: fmt.Sprintf("%d", chatMembersListDefaultPageSize), Desc: fmt.Sprintf("page size, 1-%d", chatMembersListMaxPageSize)},
{Name: "page-token", Desc: "page token; implies single-page fetch (no auto-pagination)"},
{Name: "page-all", Type: "bool", Desc: "automatically paginate through all pages (capped by --page-limit)"},
{Name: "page-limit", Type: "int", Default: "10", Desc: "max pages to fetch with --page-all (default 10, 0 = unlimited)"},
{Name: "page-delay", Type: "int", Default: fmt.Sprintf("%d", chatMembersListDefaultPageDelay), Desc: "delay in ms between pages when --page-all (0 = no delay)"},
}, imPaginationFlags(10)...),
},
Tips: []string{
`Example: lark-cli im +chat-members-list --chat-id <chat_id>`,
`Example: lark-cli im +chat-members-list --chat-id <chat_id> --page-all`,
"Default fetches a single page; pass --page-all to walk every page.",
"With --page-all and no explicit --page-size, the max page size is used to minimize round-trips.",
"truncations[] in the result means the server capped a bucket due to security config — the member list is incomplete.",
@@ -69,11 +70,14 @@ var ImChatMembersList = common.Shortcut{
if n := runtime.Int("page-size"); n < 1 || n > chatMembersListMaxPageSize {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-size must be an integer between 1 and %d", chatMembersListMaxPageSize).WithParam("--page-size")
}
_, err := normalizeMemberTypes(runtime.StrSlice("member-types"))
if err != nil {
return err
if n := runtime.Int("page-limit"); n < 0 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be a non-negative integer").WithParam("--page-limit")
}
return validateIMPagination(runtime)
if n := runtime.Int("page-delay"); n < 0 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-delay must be a non-negative integer").WithParam("--page-delay")
}
_, err := normalizeMemberTypes(runtime.StrSlice("member-types"))
return err
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
chatID := strings.TrimSpace(runtime.Str("chat-id"))
@@ -189,20 +193,59 @@ func buildChatMembersParams(runtime *common.RuntimeContext, startToken string) (
// page), so peak memory is just the aggregated members plus the single most
// recent page — important for large groups under --page-limit 0.
func fetchChatMembers(ctx context.Context, runtime *common.RuntimeContext, chatID string) (*chatMembersResult, error) {
auto := chatMembersShouldAutoPaginate(runtime)
pageLimit := runtime.Int("page-limit")
pageDelay := runtime.Int("page-delay")
apiPath := fmt.Sprintf(imChatMembersListPathFmt, validate.EncodePathSegment(chatID))
pages, status, pageErr := paginateIM(runtime, func(pageToken string) (map[string]any, error) {
params, err := buildChatMembersParams(runtime, pageToken)
params, err := buildChatMembersParams(runtime, strings.TrimSpace(runtime.Str("page-token")))
if err != nil {
return nil, err
}
res := newChatMembersResult()
var lastData map[string]interface{}
pageToken := strings.TrimSpace(runtime.Str("page-token"))
for page := 0; ; page++ {
if pageToken != "" {
params["page_token"] = pageToken
}
fmt.Fprintf(runtime.IO().ErrOut, "[page %d] fetching...\n", page+1)
data, err := runtime.CallAPITyped("GET", apiPath, params, nil)
if err != nil {
return nil, err
}
return runtime.CallAPITyped("GET", apiPath, params, nil)
})
if len(pages) == 0 {
return nil, pageErr
addMemberBuckets(res, data)
lastData = data
hasMore, nextToken := common.PaginationMeta(data)
if !auto {
break
}
if !hasMore || nextToken == "" {
break
}
if nextToken == pageToken {
// Guard against a buggy server echoing the same cursor with
// has_more=true: without --page-limit we would loop forever.
fmt.Fprintln(runtime.IO().ErrOut, "Stopping pagination: server returned a non-advancing page_token.")
break
}
if pageLimit > 0 && page+1 >= pageLimit {
fmt.Fprintf(runtime.IO().ErrOut, "[pagination] reached page limit (%d), stopping. Use --page-all --page-limit 0 to fetch all pages.\n", pageLimit)
break
}
pageToken = nextToken
// Throttle between pages (only reached when another page follows), so
// draining a large untruncated list doesn't hammer the API.
if pageDelay > 0 {
time.Sleep(time.Duration(pageDelay) * time.Millisecond)
}
}
runtime.RecordPagination(status)
return mergeChatMemberPages(pages), nil
if lastData != nil {
applyLastPageSignals(res, lastData)
}
return res, nil
}
// newChatMembersResult returns an empty aggregate with non-nil buckets so the

View File

@@ -4,6 +4,7 @@
package im
import (
"bytes"
"context"
"errors"
"fmt"
@@ -317,4 +318,8 @@ func TestFetchChatMembers_PageLimitStops(t *testing.T) {
if !res.hasMore {
t.Error("has_more: want true (loop cut short by page-limit)")
}
errOut := runtime.IO().ErrOut.(*bytes.Buffer)
if !strings.Contains(errOut.String(), "reached page limit (3)") {
t.Errorf("want page-limit notice on stderr, got: %s", errOut.String())
}
}

View File

@@ -27,7 +27,7 @@ var ImChatMessageList = common.Shortcut{
BotScopes: []string{"im:message.group_msg", "im:message.p2p_msg:readonly", "im:message.reactions:read"},
AuthTypes: []string{"user", "bot"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "chat-id", Desc: "(required, mutually exclusive with --user-id) chat ID (oc_xxx)"},
{Name: "user-id", Desc: "(required, mutually exclusive with --chat-id; user identity only) user open_id (ou_xxx)"},
{Name: "start", Desc: "start time (ISO 8601)"},
@@ -38,10 +38,6 @@ var ImChatMessageList = common.Shortcut{
{Name: "page-token", Desc: "pagination token for next page"},
{Name: "no-reactions", Type: "bool", Desc: "skip auto-fetching reactions for each message (default: enrichment enabled)"},
downloadResourcesFlag,
}, imPaginationFlags(imReadDefaultPageLimit)...),
Tips: []string{
`Example: lark-cli im +chat-messages-list --chat-id <chat_id>`,
`Example: lark-cli im +chat-messages-list --chat-id <chat_id> --start 2026-07-01 --end 2026-07-08 --order asc`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
d := common.NewDryRunAPI()
@@ -106,37 +102,25 @@ var ImChatMessageList = common.Shortcut{
if chatId == "" {
chatId = "<resolved_chat_id>"
}
if _, err := buildChatMessageListRequest(runtime, chatId); err != nil {
return err
}
return validateIMPagination(runtime)
_, err := buildChatMessageListRequest(runtime, chatId)
return err
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
chatId, err := resolveChatIDForMessagesList(runtime, false)
if err != nil {
return err
}
baseParams, err := buildChatMessageListRequest(runtime, chatId)
params, err := buildChatMessageListRequest(runtime, chatId)
if err != nil {
return err
}
pages, status, pageErr := paginateIM(runtime, func(pageToken string) (map[string]any, error) {
params := cloneQueryParams(baseParams)
if pageToken == "" {
delete(params, "page_token")
} else {
params["page_token"] = []string{pageToken}
}
return runtime.DoAPIJSONTyped(http.MethodGet, "/open-apis/im/v1/messages", params, nil)
})
if len(pages) == 0 {
return pageErr
data, err := runtime.DoAPIJSONTyped(http.MethodGet, "/open-apis/im/v1/messages", params, nil)
if err != nil {
return err
}
runtime.RecordPagination(status)
data := mergeIMPageArrays(pages, "items")
rawItems, _ := data["items"].([]interface{})
hasMore, nextPageToken := status.HasMore, status.NextPageToken
hasMore, nextPageToken := common.PaginationMeta(data)
nameCache := make(map[string]string)
// Pre-fetch merge_forward sub-messages concurrently before the per-item

View File

@@ -28,7 +28,7 @@ var ImChatSearch = common.Shortcut{
Scopes: []string{"im:chat:read"},
AuthTypes: []string{"user", "bot"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "query", Desc: "search keyword (server may return data.notice for overly long input)"},
{Name: "search-types", Desc: "chat types, comma-separated (private, external, public_joined, public_not_joined)"},
{Name: "chat-modes", Desc: "filter by chat mode, comma-separated (group, topic)"},
@@ -40,9 +40,6 @@ var ImChatSearch = common.Shortcut{
{Name: "page-size", Type: "int", Default: "20", Desc: "page size (1-100)"},
{Name: "page-token", Desc: "pagination token for next page"},
{Name: "exclude-muted", Type: "bool", Desc: "(user identity only) drop chats the current user has muted (do-not-disturb); bot identity returns all chats unfiltered"},
}, imPaginationFlags(imReadDefaultPageLimit)...),
Tips: []string{
`Example: lark-cli im +chat-search --query "project"`,
},
// DryRun previews the POST /open-apis/im/v2/chats/search request without executing.
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
@@ -95,7 +92,7 @@ var ImChatSearch = common.Shortcut{
if n := runtime.Int("page-size"); n < 1 || n > 100 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-size must be an integer between 1 and 100").WithParam("--page-size")
}
return validateIMPagination(runtime)
return nil
},
// Execute fetches one page, extracts per-item meta_data, optionally applies
// the --exclude-muted client-side filter (with a PreSkipReason when
@@ -103,25 +100,16 @@ var ImChatSearch = common.Shortcut{
// outData["filter"] is populated only when --exclude-muted is set.
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
body := buildSearchChatBody(runtime)
pages, status, pageErr := paginateIM(runtime, func(pageToken string) (map[string]any, error) {
params := buildSearchChatParams(runtime)
if pageToken == "" {
delete(params, "page_token")
} else {
params["page_token"] = pageToken
}
return runtime.CallAPITyped("POST", "/open-apis/im/v2/chats/search", params, body)
})
if len(pages) == 0 {
return pageErr
params := buildSearchChatParams(runtime)
resData, err := runtime.CallAPITyped("POST", "/open-apis/im/v2/chats/search", params, body)
if err != nil {
return err
}
runtime.RecordPagination(status)
resData := mergeIMPageArrays(pages, "items")
rawItems, _ := resData["items"].([]interface{})
totalF, _ := util.ToFloat64(resData["total"])
total := totalF
hasMore, pageToken := status.HasMore, status.NextPageToken
hasMore, pageToken := common.PaginationMeta(resData)
// Extract MetaData from each item
var items []map[string]interface{}

View File

@@ -28,9 +28,6 @@ var ImChatUpdate = common.Shortcut{
{Name: "name", Desc: "group name (max 60 chars)"},
{Name: "description", Desc: "group description (max 100 chars)"},
},
Tips: []string{
`Example: lark-cli im +chat-update --chat-id <chat_id> --name "new name"`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
chatID := runtime.Str("chat-id")
body := buildUpdateChatBody(runtime)
@@ -68,7 +65,7 @@ var ImChatUpdate = common.Shortcut{
chatID := runtime.Str("chat-id")
body := buildUpdateChatBody(runtime)
_, err := runtime.DoWriteAPIJSONTyped(http.MethodPut,
_, err := runtime.DoAPIJSONTyped(http.MethodPut,
fmt.Sprintf("/open-apis/im/v1/chats/%s", validate.EncodePathSegment(chatID)),
larkcore.QueryParams{"user_id_type": []string{"open_id"}},
body,

View File

@@ -423,7 +423,7 @@ func TestFeedGroupValidationErrors(t *testing.T) {
}{
{"list missing feed-group-id", ImFeedGroupListItem, map[string]string{}, "--feed-group-id is required"},
{"list bad page-size", ImFeedGroupListItem, map[string]string{"feed-group-id": "ofg_x", "page-size": "0"}, "--page-size must be an integer between 1 and 50"},
{"list bad page-limit", ImFeedGroupListItem, map[string]string{"feed-group-id": "ofg_x", "page-limit": "2000"}, "--page-limit"},
{"list bad page-limit", ImFeedGroupListItem, map[string]string{"feed-group-id": "ofg_x", "page-limit": "2000"}, "--page-limit must be an integer between 1 and 1000"},
{"list bad start-time", ImFeedGroupListItem, map[string]string{"feed-group-id": "ofg_x", "start-time": "notnum"}, "--start-time must be Unix milliseconds"},
{"list bad end-time", ImFeedGroupListItem, map[string]string{"feed-group-id": "ofg_x", "end-time": "notnum"}, "--end-time must be Unix milliseconds"},
{"query missing feed-group-id", ImFeedGroupQueryItem, map[string]string{"feed-id": "oc_a"}, "--feed-group-id is required"},
@@ -580,6 +580,10 @@ func TestFeedGroupListItemPageAllStopsOnRepeatedToken(t *testing.T) {
if got := countFGRequests(reqs, "/list_item"); got != 2 {
t.Errorf("expected 2 list_item requests (stop on repeated token), got %d", got)
}
errOut, _ := runtime.Factory.IOStreams.ErrOut.(*bytes.Buffer)
if !strings.Contains(errOut.String(), "page_token did not change") {
t.Errorf("stderr missing loop warning; got:\n%s", errOut.String())
}
})
}
}

View File

@@ -32,12 +32,14 @@ var ImFeedGroupList = common.Shortcut{
UserScopes: []string{feedGroupReadScope},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "page-size", Type: "int", Default: "50", Desc: "page size (1-50)"},
{Name: "page-token", Desc: "pagination token for next page"},
{Name: "page-all", Type: "bool", Desc: "automatically paginate through all pages"},
{Name: "page-limit", Type: "int", Default: "20", Desc: "max pages when auto-pagination is enabled (default 20, max 1000)"},
{Name: "start-time", Desc: "update-time window start (Unix milliseconds as a decimal string)"},
{Name: "end-time", Desc: "update-time window end (Unix milliseconds as a decimal string)"},
}, imPaginationFlags(imReadDefaultPageLimit)...),
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
return validateFeedGroupListPageOptions(runtime)
},
@@ -50,7 +52,22 @@ var ImFeedGroupList = common.Shortcut{
Params(feedGroupListGroupsDryRunParams(runtime))
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
return executeFeedGroupListGroupsAllPages(runtime)
// When --page-token is explicitly provided, the user wants a specific
// page — no auto-pagination regardless of --page-all.
if runtime.Bool("page-all") && !runtime.Cmd.Flags().Changed("page-token") {
return executeFeedGroupListGroupsAllPages(runtime)
}
data, err := runtime.DoAPIJSONTyped("GET", feedGroupListPath, feedGroupListGroupsQuery(runtime), nil)
if err != nil {
return err
}
hasMore, _ := data["has_more"].(bool)
runtime.OutFormat(data, nil, func(w io.Writer) {
renderFeedGroupsTable(w, data, hasMore)
})
return nil
},
}
@@ -58,8 +75,8 @@ func validateFeedGroupListPageOptions(rt *common.RuntimeContext) error {
if n := rt.Int("page-size"); n < 1 || n > 50 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-size must be an integer between 1 and 50").WithParam("--page-size")
}
if n := rt.Int("page-limit"); n > 1000 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be at most 1000 (0 = unlimited)").WithParam("--page-limit")
if n := rt.Int("page-limit"); n < 1 || n > 1000 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be an integer between 1 and 1000").WithParam("--page-limit")
}
if v := rt.Str("start-time"); v != "" {
if _, err := strconv.ParseInt(v, 10, 64); err != nil {
@@ -71,7 +88,7 @@ func validateFeedGroupListPageOptions(rt *common.RuntimeContext) error {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--end-time must be Unix milliseconds (a decimal integer string)").WithParam("--end-time")
}
}
return validateIMPagination(rt)
return nil
}
// feedGroupListGroupsQuery builds the query parameters. page_token is always
@@ -110,10 +127,30 @@ func feedGroupListGroupsDryRunParams(rt *common.RuntimeContext) map[string]any {
// (groups) and soft-deleted (deleted_groups) lists into a single response. It
// merges each array independently so neither list loses its later pages.
func executeFeedGroupListGroupsAllPages(rt *common.RuntimeContext) error {
pages, status, pageErr := paginateIM(rt, func(pageToken string) (map[string]any, error) {
maxPages := rt.Int("page-limit")
if maxPages < 1 {
maxPages = 20
}
if maxPages > 1000 {
maxPages = 1000
}
// Use make([]any, 0) so empty arrays serialize as [] not null.
allGroups := make([]any, 0)
allDeletedGroups := make([]any, 0)
var lastHasMore bool
var lastPageToken string
prevPageToken := "__START__"
for page := 0; page < maxPages; page++ {
// page_token is always sent (empty on the first page) — the groups
// endpoint rejects requests that omit it.
params := larkcore.QueryParams{
"page_size": []string{strconv.Itoa(rt.Int("page-size"))},
"page_token": []string{pageToken},
"page_token": []string{""},
}
if page > 0 {
params["page_token"] = []string{lastPageToken}
}
if start := rt.Str("start-time"); start != "" {
params["start_time"] = []string{start}
@@ -122,15 +159,41 @@ func executeFeedGroupListGroupsAllPages(rt *common.RuntimeContext) error {
params["end_time"] = []string{end}
}
return rt.DoAPIJSONTyped("GET", feedGroupListPath, params, nil)
})
if len(pages) == 0 {
return pageErr
data, err := rt.DoAPIJSONTyped("GET", feedGroupListPath, params, nil)
if err != nil {
return err
}
if v, ok := data["groups"].([]any); ok {
allGroups = append(allGroups, v...)
}
if v, ok := data["deleted_groups"].([]any); ok {
allDeletedGroups = append(allDeletedGroups, v...)
}
lastHasMore, _ = data["has_more"].(bool)
lastPageToken, _ = data["page_token"].(string)
fmt.Fprintf(rt.IO().ErrOut, "page %d: %d groups, %d deleted\n",
page+1, len(allGroups), len(allDeletedGroups))
if !lastHasMore || lastPageToken == "" {
break
}
if lastPageToken == prevPageToken {
fmt.Fprintf(rt.IO().ErrOut, "warning: page_token did not change, stopping pagination to avoid infinite loop\n")
break
}
prevPageToken = lastPageToken
}
merged := map[string]any{
"groups": allGroups,
"deleted_groups": allDeletedGroups,
"has_more": lastHasMore,
"page_token": lastPageToken,
}
rt.RecordPagination(status)
merged := mergeIMPageArrays(pages, "groups", "deleted_groups")
lastHasMore, _ := merged["has_more"].(bool)
rt.OutFormat(merged, nil, func(w io.Writer) {
renderFeedGroupsTable(w, merged, lastHasMore)
})

View File

@@ -5,6 +5,7 @@ package im
import (
"context"
"fmt"
"io"
"strconv"
@@ -25,15 +26,14 @@ var ImFeedGroupListItem = common.Shortcut{
UserScopes: []string{feedGroupReadScope, chatReadScope},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "feed-group-id", Desc: "feed group ID (ofg_xxx); path parameter (required)"},
{Name: "page-size", Type: "int", Default: "50", Desc: "page size (1-50)"},
{Name: "page-token", Desc: "pagination token for next page"},
{Name: "page-all", Type: "bool", Desc: "automatically paginate through all pages"},
{Name: "page-limit", Type: "int", Default: "20", Desc: "max pages when auto-pagination is enabled (default 20, max 1000)"},
{Name: "start-time", Desc: "update-time window start (Unix milliseconds as a decimal string)"},
{Name: "end-time", Desc: "update-time window end (Unix milliseconds as a decimal string)"},
}, imPaginationFlags(imReadDefaultPageLimit)...),
Tips: []string{
`Example: lark-cli im +feed-group-list-item --feed-group-id <feed_group_id> --as user`,
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
return validateFeedGroupListOptions(runtime)
@@ -48,7 +48,23 @@ var ImFeedGroupListItem = common.Shortcut{
Desc("will also POST /open-apis/im/v1/chats/batch_query to resolve chat_name from feed_id; requires im:chat:read")
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
return executeFeedGroupListAllPages(runtime)
// When --page-token is explicitly provided, the user wants a specific page —
// no auto-pagination regardless of --page-all.
if runtime.Bool("page-all") && !runtime.Cmd.Flags().Changed("page-token") {
return executeFeedGroupListAllPages(runtime)
}
data, err := runtime.DoAPIJSONTyped("GET", feedGroupListItemPath(runtime), feedGroupListQuery(runtime), nil)
if err != nil {
return err
}
enrichFeedGroupItemsChatName(runtime, data)
hasMore, _ := data["has_more"].(bool)
runtime.OutFormat(data, nil, func(w io.Writer) {
renderFeedGroupItemsTable(w, data, hasMore)
})
return nil
},
}
@@ -59,8 +75,8 @@ func validateFeedGroupListOptions(rt *common.RuntimeContext) error {
if n := rt.Int("page-size"); n < 1 || n > 50 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-size must be an integer between 1 and 50").WithParam("--page-size")
}
if n := rt.Int("page-limit"); n > 1000 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be at most 1000 (0 = unlimited)").WithParam("--page-limit")
if n := rt.Int("page-limit"); n < 1 || n > 1000 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be an integer between 1 and 1000").WithParam("--page-limit")
}
if v := rt.Str("start-time"); v != "" {
if _, err := strconv.ParseInt(v, 10, 64); err != nil {
@@ -72,7 +88,7 @@ func validateFeedGroupListOptions(rt *common.RuntimeContext) error {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--end-time must be Unix milliseconds (a decimal integer string)").WithParam("--end-time")
}
}
return validateIMPagination(rt)
return nil
}
// feedGroupListItemPath builds the list_item endpoint path with the feed_group_id
@@ -118,12 +134,27 @@ func feedGroupListDryRunParams(rt *common.RuntimeContext) map[string]any {
// executeFeedGroupListAllPages fetches all pages and merges items/deleted_items
// into a single response, then enriches the merged result.
func executeFeedGroupListAllPages(rt *common.RuntimeContext) error {
pages, status, pageErr := paginateIM(rt, func(pageToken string) (map[string]any, error) {
maxPages := rt.Int("page-limit")
if maxPages < 1 {
maxPages = 20
}
if maxPages > 1000 {
maxPages = 1000
}
// Use make([]any, 0) so empty arrays serialize as [] not null.
allItems := make([]any, 0)
allDeletedItems := make([]any, 0)
var lastHasMore bool
var lastPageToken string
prevPageToken := "__START__"
for page := 0; page < maxPages; page++ {
params := larkcore.QueryParams{
"page_size": []string{strconv.Itoa(rt.Int("page-size"))},
}
if pageToken != "" {
params["page_token"] = []string{pageToken}
if page > 0 {
params["page_token"] = []string{lastPageToken}
}
if start := rt.Str("start-time"); start != "" {
params["start_time"] = []string{start}
@@ -132,17 +163,43 @@ func executeFeedGroupListAllPages(rt *common.RuntimeContext) error {
params["end_time"] = []string{end}
}
return rt.DoAPIJSONTyped("GET", feedGroupListItemPath(rt), params, nil)
})
if len(pages) == 0 {
return pageErr
data, err := rt.DoAPIJSONTyped("GET", feedGroupListItemPath(rt), params, nil)
if err != nil {
return err
}
if v, ok := data["items"].([]any); ok {
allItems = append(allItems, v...)
}
if v, ok := data["deleted_items"].([]any); ok {
allDeletedItems = append(allDeletedItems, v...)
}
lastHasMore, _ = data["has_more"].(bool)
lastPageToken, _ = data["page_token"].(string)
fmt.Fprintf(rt.IO().ErrOut, "page %d: %d items, %d deleted\n",
page+1, len(allItems), len(allDeletedItems))
if !lastHasMore || lastPageToken == "" {
break
}
if lastPageToken == prevPageToken {
fmt.Fprintf(rt.IO().ErrOut, "warning: page_token did not change, stopping pagination to avoid infinite loop\n")
break
}
prevPageToken = lastPageToken
}
merged := map[string]any{
"items": allItems,
"deleted_items": allDeletedItems,
"has_more": lastHasMore,
"page_token": lastPageToken,
}
rt.RecordPagination(status)
merged := mergeIMPageArrays(pages, "items", "deleted_items")
enrichFeedGroupItemsChatName(rt, merged)
lastHasMore, _ := merged["has_more"].(bool)
rt.OutFormat(merged, nil, func(w io.Writer) {
renderFeedGroupItemsTable(w, merged, lastHasMore)
})

View File

@@ -227,6 +227,10 @@ func TestFeedGroupListPageAllStopsOnRepeatedToken(t *testing.T) {
if got := countFGRequests(reqs, "/groups"); got != 2 {
t.Errorf("expected 2 requests (stop on repeated token), got %d", got)
}
errOut, _ := runtime.Factory.IOStreams.ErrOut.(*bytes.Buffer)
if !strings.Contains(errOut.String(), "page_token did not change") {
t.Errorf("stderr missing loop warning; got:\n%s", errOut.String())
}
})
}
}

View File

@@ -27,9 +27,6 @@ var ImFeedGroupQueryItem = common.Shortcut{
{Name: "feed-group-id", Desc: "feed group ID (ofg_xxx); path parameter (required)"},
{Name: "feed-id", Desc: "comma-separated chat IDs (oc_xxx); feed_type is fixed to chat (required)"},
},
Tips: []string{
`Example: lark-cli im +feed-group-query-item --feed-group-id <feed_group_id> --feed-id <chat_id> --as user`,
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
_, err := buildFeedGroupQueryItemBody(runtime)
return err

View File

@@ -34,10 +34,6 @@ var ImFeedShortcutCreate = common.Shortcut{
{Name: "tail", Type: "bool",
Desc: "append at the bottom of the shortcut list; mutually exclusive with --head"},
},
Tips: []string{
`Example: lark-cli im +feed-shortcut-create --chat-id <chat_id> --as user`,
`Example: lark-cli im +feed-shortcut-create --chat-id <chat_id> --tail --as user`,
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
if _, err := collectChatIDs(runtime); err != nil {
return err
@@ -57,7 +53,7 @@ var ImFeedShortcutCreate = common.Shortcut{
return common.NewDryRunAPI().
POST("/open-apis/im/v2/feed_shortcuts").
Body(map[string]any{
"shortcuts": shortcutItemsBody(buildShortcutItems(ids)),
"shortcuts": buildShortcutItems(ids),
"is_header": isHeader,
})
},
@@ -71,9 +67,9 @@ var ImFeedShortcutCreate = common.Shortcut{
return err
}
items := buildShortcutItems(ids)
data, err := runtime.DoWriteAPIJSONTyped("POST", "/open-apis/im/v2/feed_shortcuts", nil,
data, err := runtime.DoAPIJSONTyped("POST", "/open-apis/im/v2/feed_shortcuts", nil,
map[string]any{
"shortcuts": shortcutItemsBody(items),
"shortcuts": items,
"is_header": isHeader,
})
if err != nil {
@@ -92,9 +88,7 @@ func resolveIsHeader(rt *common.RuntimeContext) (bool, error) {
head := rt.Bool("head")
tail := rt.Bool("tail")
if head && tail {
return false, errs.NewValidationError(errs.SubtypeInvalidArgument,
"--head and --tail are mutually exclusive").
WithHint("pass only one of --head or --tail; omitting both inserts at the head")
return false, errs.NewValidationError(errs.SubtypeInvalidArgument, "--head and --tail are mutually exclusive")
}
if tail {
return false, nil

View File

@@ -6,34 +6,35 @@ package im
import (
"context"
"fmt"
"io"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/shortcuts/common"
larkcore "github.com/larksuite/oapi-sdk-go/v3/core"
)
// ImFeedShortcutList provides the +feed-shortcut-list shortcut for listing
// the user's feed shortcuts. Pagination tokens are version-locked: automatic
// pagination forwards each server-issued token exactly once and reports an
// incomplete read if the list changes or the token cannot advance.
// the user's feed shortcuts. The server-controlled page size covers the full
// list in practice, but pagination is version-locked: when the list changes
// between calls the server rejects the stale token and the caller has to
// restart by omitting --page-token.
//
// The shortcut is a thin one-page wrapper — there is no automatic walking.
// Callers are expected to drive their own loop when they actually need to
// paginate, because the version-lock means each page is a real checkpoint
// that the caller must consciously decide what to do with on failure.
var ImFeedShortcutList = common.Shortcut{
Service: "im",
Command: "+feed-shortcut-list",
Description: "List the user's feed shortcuts; user-only; supports explicit full pagination and auto-enriches each entry with the full per-type info object under `detail` (pass --no-detail to skip)",
Description: "List one page of the user's feed shortcuts; user-only; first call omits --page-token, subsequent calls pass the previous response's page_token; each entry is auto-enriched with the full per-type info object attached as `detail` (pass --no-detail to skip)",
Risk: "read",
UserScopes: []string{feedShortcutReadScope},
ConditionalUserScopes: []string{chatBatchQueryScope},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "page-token",
Desc: "opaque pagination token from the previous response; omit for the first page. If a token is rejected because the list changed, restart by omitting it."},
{Name: "no-detail", Type: "bool",
Desc: "skip fetching the full info object for each shortcut (default: enrichment enabled — CHAT-type entries call im.chats.batch_query, require im:chat:read, and attach the object under the detail field)"},
}, imPaginationFlags(imReadDefaultPageLimit)...),
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
return validateIMPagination(runtime)
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
d := common.NewDryRunAPI().
@@ -47,16 +48,11 @@ var ImFeedShortcutList = common.Shortcut{
return d
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
pages, status, pageErr := paginateIM(runtime, func(pageToken string) (map[string]any, error) {
return runtime.DoAPIJSONTyped("GET", "/open-apis/im/v2/feed_shortcuts",
feedShortcutListQuery(pageToken), nil)
})
if len(pages) == 0 {
return pageErr
data, err := runtime.DoAPIJSONTyped("GET", "/open-apis/im/v2/feed_shortcuts",
feedShortcutListQuery(runtime.Str("page-token")), nil)
if err != nil {
return err
}
runtime.RecordPagination(status)
data := mergeIMPageArrays(pages, "shortcuts")
if !runtime.Bool("no-detail") {
if err := enrichFeedShortcutDetail(runtime, data); err != nil {
fmt.Fprintf(runtime.IO().ErrOut, "warning: detail enrichment failed: %v\n", err)
@@ -68,33 +64,11 @@ var ImFeedShortcutList = common.Shortcut{
}
}
}
presentation := any(data)
if runtime.JqExpr == "" && runtime.Format != "" &&
runtime.Format != "json" && runtime.Format != "pretty" {
presentation = data["shortcuts"]
}
runtime.OutFormat(presentation, nil, func(w io.Writer) {
renderFeedShortcutListPretty(w, data)
})
runtime.Out(data, nil)
return nil
},
}
func renderFeedShortcutListPretty(w io.Writer, data map[string]any) {
items, _ := data["shortcuts"].([]any)
if len(items) == 0 {
fmt.Fprintln(w, "No feed shortcuts found.")
return
}
output.FormatValue(w, items, output.FormatTable)
hasMore, _ := data["has_more"].(bool)
fmt.Fprintf(w, "\n%d feed shortcut(s)", len(items))
if hasMore {
fmt.Fprint(w, " (more available)")
}
fmt.Fprintln(w)
}
// feedShortcutListQuery omits the page_token key entirely when the token is
// empty, so the server treats the call as a first-page request.
func feedShortcutListQuery(token string) larkcore.QueryParams {

View File

@@ -28,9 +28,6 @@ var ImFeedShortcutRemove = common.Shortcut{
{Name: "chat-id", Type: "string_slice",
Desc: "open_chat_id to remove from feed shortcuts (oc_xxx); required; repeat the flag or pass comma-separated; max 10 per call"},
},
Tips: []string{
`Example: lark-cli im +feed-shortcut-remove --chat-id <chat_id1>,<chat_id2> --as user`,
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
_, err := collectChatIDs(runtime)
return err
@@ -42,7 +39,7 @@ var ImFeedShortcutRemove = common.Shortcut{
}
return common.NewDryRunAPI().
POST("/open-apis/im/v2/feed_shortcuts/remove").
Body(map[string]any{"shortcuts": shortcutItemsBody(buildShortcutItems(ids))})
Body(map[string]any{"shortcuts": buildShortcutItems(ids)})
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
ids, err := collectChatIDs(runtime)
@@ -50,8 +47,8 @@ var ImFeedShortcutRemove = common.Shortcut{
return err
}
items := buildShortcutItems(ids)
data, err := runtime.DoWriteAPIJSONTyped("POST", "/open-apis/im/v2/feed_shortcuts/remove", nil,
map[string]any{"shortcuts": shortcutItemsBody(items)})
data, err := runtime.DoAPIJSONTyped("POST", "/open-apis/im/v2/feed_shortcuts/remove", nil,
map[string]any{"shortcuts": items})
if err != nil {
return err
}

View File

@@ -14,10 +14,8 @@ import (
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/cmdutil"
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/shortcuts/common"
"github.com/spf13/cobra"
@@ -52,8 +50,6 @@ func newFeedShortcutListCmd(t *testing.T) *cobra.Command {
t.Helper()
cmd := &cobra.Command{Use: "test"}
cmd.Flags().String("page-token", "", "")
cmd.Flags().Bool("page-all", false, "")
cmd.Flags().Int("page-limit", imReadDefaultPageLimit, "")
// Default true (skip enrichment) in tests so non-enrichment-focused tests
// don't trigger the batch_query path; tests that exercise detail
// enrichment flip this off.
@@ -121,58 +117,6 @@ func TestCollectChatIDs(t *testing.T) {
}
}
// TestCollectChatIDsHint locks that the missing/invalid chat-id errors from
// collectChatIDs carry an actionable recovery hint pointing the user at how to
// discover a real open_chat_id (im +chat-search / im +chat-list), name the
// failing flag via Param, and keep the invalid_argument subtype. The
// over-batch-limit error is intentionally out of scope — it needs no
// ID-source guidance.
func TestCollectChatIDsHint(t *testing.T) {
tests := []struct {
name string
input []string
}{
{name: "missing chat-id", input: nil},
{name: "bad prefix", input: []string{"om_abc"}},
{name: "whitespace only", input: []string{" "}},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
cmd := newFeedShortcutCreateCmd(t)
for _, v := range tt.input {
if err := cmd.Flags().Set("chat-id", v); err != nil {
t.Fatalf("Set chat-id %q error = %v", v, err)
}
}
runtime := &common.RuntimeContext{Cmd: cmd}
_, err := collectChatIDs(runtime)
if err == nil {
t.Fatalf("collectChatIDs() expected error, got nil")
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("collectChatIDs() error is not a typed Problem: %v", err)
}
if problem.Subtype != errs.SubtypeInvalidArgument {
t.Fatalf("collectChatIDs() Subtype = %v, want %v", problem.Subtype, errs.SubtypeInvalidArgument)
}
if !strings.Contains(problem.Hint, "+chat-search") || !strings.Contains(problem.Hint, "+chat-list") {
t.Fatalf("collectChatIDs() Hint = %q, want it to mention both +chat-search and +chat-list", problem.Hint)
}
var verr *errs.ValidationError
if !errors.As(err, &verr) {
t.Fatalf("collectChatIDs() error is not *errs.ValidationError: %v", err)
}
if verr.Param != "--chat-id" {
t.Fatalf("collectChatIDs() Param = %q, want --chat-id", verr.Param)
}
})
}
}
func TestBuildShortcutItems(t *testing.T) {
got := buildShortcutItems([]string{"oc_a", "oc_b"})
if len(got) != 2 {
@@ -366,35 +310,6 @@ func TestResolveIsHeader(t *testing.T) {
}
}
func TestResolveIsHeaderMutualExclusionHint(t *testing.T) {
// Locks the recovery hint on the --head/--tail conflict: an agent reading
// only the stderr envelope must be told which flag to drop, not just that
// the two are incompatible.
cmd := newFeedShortcutCreateCmd(t)
if err := cmd.Flags().Set("head", "true"); err != nil {
t.Fatalf("Set head error = %v", err)
}
if err := cmd.Flags().Set("tail", "true"); err != nil {
t.Fatalf("Set tail error = %v", err)
}
rt := &common.RuntimeContext{Cmd: cmd}
_, err := resolveIsHeader(rt)
if err == nil {
t.Fatal("want error when both --head and --tail are set")
}
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("want typed errs problem, got %T: %v", err, err)
}
if problem.Subtype != errs.SubtypeInvalidArgument {
t.Errorf("subtype = %q, want invalid_argument", problem.Subtype)
}
if !strings.Contains(problem.Hint, "--head") || !strings.Contains(problem.Hint, "--tail") {
t.Errorf("hint = %q, want explicit next action naming --head/--tail", problem.Hint)
}
}
func TestFeedShortcutStaticScopes(t *testing.T) {
if got := ImFeedShortcutCreate.ScopesForIdentity("user"); len(got) != 1 || got[0] != feedShortcutWriteScope {
t.Fatalf("ImFeedShortcutCreate scopes = %v, want only %s", got, feedShortcutWriteScope)
@@ -491,8 +406,6 @@ func TestImFeedShortcutCreateExecuteCallsAPI(t *testing.T) {
t.Fatalf("Set chat-id error = %v", err)
}
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +feed-shortcut-create")
setRuntimeField(t, rt, "contractSession", imcontract.NewSession(contract))
err := ImFeedShortcutCreate.Execute(context.Background(), rt)
var pfErr *output.PartialFailureError
@@ -528,60 +441,6 @@ func TestImFeedShortcutCreateExecuteCallsAPI(t *testing.T) {
t.Fatalf("stdout = %s, want %q", out, want)
}
}
var envelope struct {
Hint string `json:"hint"`
Data struct {
Completion imcontract.Completion `json:"completion"`
} `json:"data"`
}
if err := json.Unmarshal([]byte(out), &envelope); err != nil {
t.Fatalf("stdout is not JSON: %v\n%s", err, out)
}
if envelope.Data.Completion.RetryScope != "whole_request" ||
envelope.Data.Completion.FailedCount != 1 ||
envelope.Hint != "" {
t.Fatalf("completion = %#v, hint = %q", envelope.Data.Completion, envelope.Hint)
}
}
func TestImFeedShortcutCreateMalformedEvidenceStaysNonReplayable(t *testing.T) {
calls := 0
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
calls++
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"failed_shortcuts": []any{
map[string]any{
"reason": float64(2),
"shortcut": map[string]any{"type": float64(1)},
},
},
},
}), nil
}))
parent := &cobra.Command{Use: "im"}
ImFeedShortcutCreate.Mount(parent, rt.Factory)
parent.SetArgs([]string{
"+feed-shortcut-create",
"--chat-id", "oc_abc",
"--as", "user",
})
err := parent.Execute()
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryInternal ||
problem.Subtype != errs.SubtypeInvalidResponse ||
problem.Retryable ||
problem.Hint != "The server response could not be safely mapped to the original request. Do not retry the write based on this response." {
t.Fatalf("error = %T %#v", err, problem)
}
if calls != 1 {
t.Fatalf("API calls = %d, want 1 without replay", calls)
}
if out := rt.Factory.IOStreams.Out.(*bytes.Buffer).String(); out != "" {
t.Fatalf("malformed completion reached stdout: %s", out)
}
}
func TestEmitFeedShortcutWriteResultSuccess(t *testing.T) {
@@ -678,53 +537,6 @@ func TestImFeedShortcutRemoveExecuteCallsRemovePath(t *testing.T) {
}
}
func TestImFeedShortcutRemovePartialFailureUsesWholeRequestRecovery(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"failed_shortcuts": []any{
map[string]any{
"reason": float64(2),
"shortcut": map[string]any{
"feed_card_id": "oc_abc",
"type": float64(1),
},
},
},
},
}), nil
}))
cmd := newFeedShortcutRemoveCmd(t)
if err := cmd.Flags().Set("chat-id", "oc_abc"); err != nil {
t.Fatalf("Set chat-id error = %v", err)
}
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +feed-shortcut-remove")
setRuntimeField(t, rt, "contractSession", imcontract.NewSession(contract))
err := ImFeedShortcutRemove.Execute(context.Background(), rt)
var partialErr *output.PartialFailureError
if !errors.As(err, &partialErr) {
t.Fatalf("Execute() error = %T %v, want partial failure", err, err)
}
var envelope struct {
Hint string `json:"hint"`
Data struct {
Completion imcontract.Completion `json:"completion"`
} `json:"data"`
}
out := rt.Factory.IOStreams.Out.(*bytes.Buffer).Bytes()
if err := json.Unmarshal(out, &envelope); err != nil {
t.Fatalf("stdout is not JSON: %v\n%s", err, out)
}
if envelope.Data.Completion.RetryScope != "whole_request" ||
envelope.Data.Completion.FailedCount != 1 ||
envelope.Hint != "" {
t.Fatalf("completion = %#v, hint = %q", envelope.Data.Completion, envelope.Hint)
}
}
func TestImFeedShortcutListDryRunRendersGet(t *testing.T) {
cmd := newFeedShortcutListCmd(t)
rt := &common.RuntimeContext{Cmd: cmd}
@@ -798,240 +610,16 @@ func TestImFeedShortcutListDryRunMentionsDetailScope(t *testing.T) {
}
}
func TestImFeedShortcutListExposesAutoPaginationWithoutInventingPageSize(t *testing.T) {
found := map[string]bool{}
func TestImFeedShortcutListDoesNotExposeAutoPaginationFlags(t *testing.T) {
// Locks in the design decision: this shortcut is a one-page wrapper.
// If any of these reappear, callers/AI agents will assume auto-walking
// is supported and write code that silently double-fetches.
banned := map[string]bool{"page-all": true, "page-limit": true, "page-size": true}
for _, fl := range ImFeedShortcutList.Flags {
found[fl.Name] = true
}
for _, name := range []string{"page-all", "page-limit"} {
if !found[name] {
t.Fatalf("ImFeedShortcutList must expose --%s", name)
if banned[fl.Name] {
t.Fatalf("ImFeedShortcutList must not expose --%s", fl.Name)
}
}
if found["page-size"] {
t.Fatal("ImFeedShortcutList must not invent --page-size; the server controls page size")
}
}
func TestImFeedShortcutListPageAllCarriesVersionLockedTokenForward(t *testing.T) {
var tokens []string
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
tokens = append(tokens, req.URL.Query().Get("page_token"))
if len(tokens) == 1 {
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"shortcuts": []any{map[string]any{"feed_card_id": "oc_first", "type": float64(1)}},
"has_more": true,
"page_token": "version-locked-next",
},
}), nil
}
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"shortcuts": []any{map[string]any{"feed_card_id": "oc_second", "type": float64(1)}},
"has_more": false,
"page_token": "",
},
}), nil
}))
cmd := newFeedShortcutListCmd(t)
if err := cmd.Flags().Set("page-all", "true"); err != nil {
t.Fatal(err)
}
if err := cmd.Flags().Set("page-limit", "0"); err != nil {
t.Fatal(err)
}
setRuntimeField(t, rt, "Cmd", cmd)
if err := ImFeedShortcutList.Execute(context.Background(), rt); err != nil {
t.Fatalf("Execute() error = %v", err)
}
if got, want := strings.Join(tokens, ","), ",version-locked-next"; got != want {
t.Fatalf("page tokens = %q, want %q", got, want)
}
}
func TestImFeedShortcutListTokenFailureDoesNotRestartFromFirstPage(t *testing.T) {
var tokens []string
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
tokens = append(tokens, req.URL.Query().Get("page_token"))
if len(tokens) == 1 {
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"shortcuts": []any{map[string]any{"feed_card_id": "oc_first", "type": float64(1)}},
"has_more": true,
"page_token": "stale-version-token",
},
}), nil
}
return shortcutJSONResponse(200, map[string]any{
"code": 230001,
"msg": "version changed",
}), nil
}))
cmd := newFeedShortcutListCmd(t)
if err := cmd.Flags().Set("page-all", "true"); err != nil {
t.Fatal(err)
}
if err := cmd.Flags().Set("page-limit", "0"); err != nil {
t.Fatal(err)
}
setRuntimeField(t, rt, "Cmd", cmd)
if err := ImFeedShortcutList.Execute(context.Background(), rt); err != nil {
t.Fatalf("Execute() with a preserved first page error = %v, want deferred read-contract error", err)
}
if got, want := strings.Join(tokens, ","), ",stale-version-token"; got != want {
t.Fatalf("page tokens = %q, want %q; pagination must not restart", got, want)
}
}
func TestImFeedShortcutListFormatsPreserveReadContract(t *testing.T) {
tests := []struct {
name string
format string
jq string
wantOutput []string
wantHint bool
}{
{
name: "pretty",
format: "pretty",
wantOutput: []string{"oc_format", "1 feed shortcut(s)"},
wantHint: true,
},
{
name: "table",
format: "table",
wantOutput: []string{"feed_card_id", "oc_format"},
wantHint: true,
},
{
name: "csv",
format: "csv",
wantOutput: []string{"feed_card_id", "oc_format"},
wantHint: true,
},
{
name: "ndjson",
format: "ndjson",
wantOutput: []string{`"feed_card_id":"oc_format"`},
wantHint: true,
},
{
name: "jq",
format: "json",
jq: ".data.shortcuts[0].feed_card_id",
wantOutput: []string{"oc_format"},
wantHint: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
if !strings.Contains(req.URL.Path, "/open-apis/im/v2/feed_shortcuts") {
return nil, fmt.Errorf("unexpected request: %s", req.URL.Path)
}
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"shortcuts": []any{
map[string]any{"feed_card_id": "oc_format", "type": float64(1)},
},
"has_more": true,
"page_token": "next",
},
}), nil
}))
cmd := newFeedShortcutListCmd(t)
setRuntimeField(t, rt, "Cmd", cmd)
rt.Format = tt.format
rt.JqExpr = tt.jq
contract, ok := imcontract.Lookup("im +feed-shortcut-list")
if !ok {
t.Fatal("read contract not found")
}
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, rt, "readSession", session)
if err := ImFeedShortcutList.Execute(context.Background(), rt); err != nil {
t.Fatalf("Execute() error = %v", err)
}
out := rt.Factory.IOStreams.Out.(*bytes.Buffer).String()
for _, want := range tt.wantOutput {
if !strings.Contains(out, want) {
t.Fatalf("stdout = %q, want %q", out, want)
}
}
errOut := rt.Factory.IOStreams.ErrOut.(*bytes.Buffer).String()
if tt.wantHint && !strings.Contains(errOut, "hint: Result is incomplete.") {
t.Fatalf("stderr = %q, want incomplete-read hint", errOut)
}
})
}
}
func TestImFeedShortcutListJSONIncludesCompletenessEnvelope(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"shortcuts": []any{map[string]any{"feed_card_id": "oc_json", "type": float64(1)}},
"has_more": true,
"page_token": "next",
},
}), nil
}))
cmd := newFeedShortcutListCmd(t)
setRuntimeField(t, rt, "Cmd", cmd)
rt.Format = "json"
contract, ok := imcontract.Lookup("im +feed-shortcut-list")
if !ok {
t.Fatal("read contract not found")
}
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, rt, "readSession", session)
if err := ImFeedShortcutList.Execute(context.Background(), rt); err != nil {
t.Fatalf("Execute() error = %v", err)
}
var envelope struct {
OK bool `json:"ok"`
Data struct {
Shortcuts []map[string]any `json:"shortcuts"`
} `json:"data"`
Meta *output.Meta `json:"meta"`
Hint string `json:"hint"`
}
out := rt.Factory.IOStreams.Out.(*bytes.Buffer).Bytes()
if err := json.Unmarshal(out, &envelope); err != nil {
t.Fatalf("stdout is not JSON: %v\n%s", err, out)
}
if !envelope.OK || len(envelope.Data.Shortcuts) != 1 ||
envelope.Data.Shortcuts[0]["feed_card_id"] != "oc_json" {
t.Fatalf("envelope data = %#v, ok = %v", envelope.Data, envelope.OK)
}
if envelope.Meta == nil || envelope.Meta.Complete == nil || *envelope.Meta.Complete ||
envelope.Meta.PagesFetched != 1 || envelope.Meta.StopReason != "single_page" ||
envelope.Meta.NextPageToken != "next" {
t.Fatalf("meta = %#v, want incomplete single_page", envelope.Meta)
}
if !strings.Contains(envelope.Hint, "Result is incomplete.") {
t.Fatalf("hint = %q, want incomplete-read hint", envelope.Hint)
}
if errOut := rt.Factory.IOStreams.ErrOut.(*bytes.Buffer).String(); errOut != "" {
t.Fatalf("stderr = %q, want JSON hint in envelope only", errOut)
}
}
func TestImFeedShortcutListPageTokenIsOptional(t *testing.T) {

View File

@@ -9,7 +9,6 @@ import (
"strings"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/shortcuts/common"
)
@@ -28,9 +27,6 @@ var ImFlagCancel = common.Shortcut{
{Name: "item-type", Desc: "item type override: default|thread|msg_thread"},
{Name: "flag-type", Desc: "flag type override: message|feed; omit to double-cancel both layers"},
},
Tips: []string{
`Example: lark-cli im +flag-cancel --message-id <message_id> --as user`,
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
_, _, err := buildCancelItemsForPreview(runtime)
return err
@@ -44,7 +40,7 @@ var ImFlagCancel = common.Shortcut{
POST("/open-apis/im/v1/flags/cancel").
Body(map[string]any{"flag_items": items})
if len(items) > 1 {
d.Desc("double-cancel: tries both message and feed layers; an unresolved feed layer is reported as pending")
d.Desc("double-cancel: tries both message and feed layers (best-effort); feed-layer skipped if chat_type undeterminable")
}
return d
},
@@ -56,7 +52,7 @@ var ImFlagCancel = common.Shortcut{
// Make separate API calls for each item so they are independent.
// If one fails, the other can still succeed.
results := make([]any, 0, len(items))
results := make([]map[string]any, 0, len(items))
var lastErr error
for _, item := range items {
itemType := itemTypeString(parseItemTypeFromRaw(item.ItemType))
@@ -66,7 +62,7 @@ var ImFlagCancel = common.Shortcut{
"item_type": itemType,
"flag_type": flagType,
}
data, err := runtime.DoWriteAPIJSONTyped("POST", "/open-apis/im/v1/flags/cancel", nil,
data, err := runtime.DoAPIJSONTyped("POST", "/open-apis/im/v1/flags/cancel", nil,
map[string]any{"flag_items": []flagItem{item}})
if err != nil {
result["status"] = "failed"
@@ -128,7 +124,7 @@ func buildCancelItemsForPreview(rt *common.RuntimeContext) ([]any, bool, error)
// 1. If --flag-type is explicitly provided, do a single targeted delete.
// 2. Otherwise, perform double-cancel: remove both message layer and feed layer.
// - Message layer is always included (uses known message_id with ItemTypeDefault)
// - Feed layer is best-effort: if chat_type cannot be determined, record it as pending
// - Feed layer is best-effort: if chat_type cannot be determined, skip with warning
// - Each layer is independent; failure to cancel one doesn't block the other
func buildCancelItems(rt *common.RuntimeContext) ([]flagItem, error) {
id, err := flagMessageID(rt)
@@ -156,13 +152,15 @@ func buildCancelItems(rt *common.RuntimeContext) ([]flagItem, error) {
// Most messages only have one layer flagged, so this is best-effort cleanup.
chatID, err := getMessageChatID(rt, id)
if err != nil {
rt.RecordContractFact(imcontract.Fact{Kind: imcontract.FactFlagFeedLayerPending})
// Can't get chat_id, warn and skip feed layer
fmt.Fprintf(rt.IO().ErrOut, "warning: cannot determine feed-layer item_type: %v; skipping feed-layer cancel\n", err)
return items, nil
}
feedIT, err := resolveThreadFeedItemType(rt, chatID)
if err != nil {
rt.RecordContractFact(imcontract.Fact{Kind: imcontract.FactFlagFeedLayerPending})
// Can't determine chat_type, warn and skip feed layer
fmt.Fprintf(rt.IO().ErrOut, "warning: cannot determine feed-layer item_type: %v; skipping feed-layer cancel\n", err)
return items, nil
}

View File

@@ -26,10 +26,6 @@ var ImFlagCreate = common.Shortcut{
{Name: "item-type", Desc: "item type override: default|thread|msg_thread (rarely needed)"},
{Name: "flag-type", Desc: "flag type: message (default) or feed"},
},
Tips: []string{
`Example: lark-cli im +flag-create --message-id <message_id> --as user`,
`Example: lark-cli im +flag-create --message-id <message_id> --flag-type feed --as user`,
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
_, err := buildCreateItemForPreview(runtime)
return err
@@ -61,7 +57,7 @@ var ImFlagCreate = common.Shortcut{
errs.InvalidParam{Name: "--item-type", Reason: "unsupported with the given --flag-type"},
errs.InvalidParam{Name: "--flag-type", Reason: "unsupported with the given --item-type"})
}
data, err := runtime.DoWriteAPIJSONTyped("POST", "/open-apis/im/v1/flags", nil,
data, err := runtime.DoAPIJSONTyped("POST", "/open-apis/im/v1/flags", nil,
map[string]any{"flag_items": []flagItem{item}})
if err != nil {
return err

View File

@@ -7,11 +7,9 @@ import (
"context"
"encoding/json"
"fmt"
"io"
"strconv"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/shortcuts/common"
larkcore "github.com/larksuite/oapi-sdk-go/v3/core"
)
@@ -26,11 +24,13 @@ var ImFlagList = common.Shortcut{
UserScopes: []string{flagReadScope},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "page-size", Type: "int", Default: "50", Desc: "page size (1-50)"},
{Name: "page-token", Desc: "pagination token for next page"},
{Name: "page-all", Type: "bool", Desc: "automatically paginate, capped by --page-limit"},
{Name: "page-limit", Type: "int", Default: "20", Desc: "max pages with --page-all (default 20; configurable range 1-1000)"},
{Name: "enrich-feed-thread", Type: "bool", Default: "true", Desc: "fetch message content for feed-type thread entries (default true; may call messages/mget and require im:message.group_msg:get_as_user/im:message.p2p_msg:get_as_user; use --enrich-feed-thread=false to avoid extra scopes)"},
}, imPaginationFlags(imReadDefaultPageLimit)...),
},
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
return validateListOptions(runtime)
},
@@ -50,7 +50,23 @@ var ImFlagList = common.Shortcut{
return d
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
return executeListAllPages(runtime)
// When --page-token is explicitly provided, the user wants a specific page —
// no auto-pagination regardless of --page-all.
if runtime.Bool("page-all") && !runtime.Cmd.Flags().Changed("page-token") {
return executeListAllPages(runtime)
}
data, err := runtime.DoAPIJSONTyped("GET", "/open-apis/im/v1/flags", listQuery(runtime), nil)
if err != nil {
return err
}
if runtime.Bool("enrich-feed-thread") {
if err := enrichFeedThreadItems(runtime, data); err != nil {
fmt.Fprintf(runtime.IO().ErrOut, "warning: feed-thread enrichment failed: %v\n", err)
}
}
runtime.Out(data, nil)
return nil
},
}
@@ -58,10 +74,10 @@ func validateListOptions(rt *common.RuntimeContext) error {
if n := rt.Int("page-size"); n < 1 || n > 50 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-size must be an integer between 1 and 50").WithParam("--page-size")
}
if n := rt.Int("page-limit"); n > 1000 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be at most 1000 (0 = unlimited)").WithParam("--page-limit")
if n := rt.Int("page-limit"); n < 1 || n > 1000 {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be an integer between 1 and 1000").WithParam("--page-limit")
}
return validateIMPagination(rt)
return nil
}
// listQuery builds the query parameters for the flag list API call.
@@ -207,65 +223,82 @@ func asString(v any) string {
// The flag list API returns items sorted by update_time ascending, so the last page
// contains the newest items.
func executeListAllPages(rt *common.RuntimeContext) error {
pages, status, pageErr := paginateIM(rt, func(pageToken string) (map[string]any, error) {
return rt.DoAPIJSONTyped("GET", "/open-apis/im/v1/flags",
larkcore.QueryParams{
"page_size": []string{strconv.Itoa(rt.Int("page-size"))},
"page_token": []string{pageToken},
}, nil)
})
if len(pages) == 0 {
return pageErr
maxPages := rt.Int("page-limit")
if maxPages < 1 {
maxPages = 20
}
if maxPages > 1000 {
maxPages = 1000
}
// Use make([]any, 0) to ensure empty arrays serialize as [] not null
allFlagItems := make([]any, 0)
allDeleteFlagItems := make([]any, 0)
allMessages := make([]any, 0)
var lastHasMore bool
var lastPageToken string
prevPageToken := "__START__" // Sentinel to detect unchanged token
for page := 0; page < maxPages; page++ {
token := ""
if page > 0 {
token = lastPageToken
}
data, err := rt.DoAPIJSONTyped("GET", "/open-apis/im/v1/flags",
larkcore.QueryParams{
"page_size": []string{strconv.Itoa(rt.Int("page-size"))},
"page_token": []string{token},
}, nil)
if err != nil {
return err
}
if v, ok := data["flag_items"].([]any); ok {
allFlagItems = append(allFlagItems, v...)
}
if v, ok := data["delete_flag_items"].([]any); ok {
allDeleteFlagItems = append(allDeleteFlagItems, v...)
}
if v, ok := data["messages"].([]any); ok {
allMessages = append(allMessages, v...)
}
lastHasMore, _ = data["has_more"].(bool)
lastPageToken, _ = data["page_token"].(string)
// Progress output to stderr
fmt.Fprintf(rt.IO().ErrOut, "page %d: %d flags, %d deleted\n",
page+1, len(allFlagItems), len(allDeleteFlagItems))
if !lastHasMore || lastPageToken == "" {
break
}
// Detect server anomaly: same token returned twice means infinite loop
if lastPageToken == prevPageToken {
fmt.Fprintf(rt.IO().ErrOut, "warning: page_token did not change, stopping pagination to avoid infinite loop\n")
break
}
if page+1 >= maxPages {
fmt.Fprintf(rt.IO().ErrOut, "[pagination] reached page limit (%d) while has_more=true; result is incomplete. Increase --page-limit up to 1000 or resume with the page_token returned in stdout.\n", maxPages)
break
}
prevPageToken = lastPageToken
}
merged := map[string]any{
"flag_items": allFlagItems,
"delete_flag_items": allDeleteFlagItems,
"messages": allMessages,
"has_more": lastHasMore,
"page_token": lastPageToken,
}
rt.RecordPagination(status)
merged := mergeIMPageArrays(pages, "flag_items", "delete_flag_items", "messages")
if rt.Bool("enrich-feed-thread") {
if err := enrichFeedThreadItems(rt, merged); err != nil {
fmt.Fprintf(rt.IO().ErrOut, "warning: feed-thread enrichment failed: %v\n", err)
}
}
presentation := any(merged)
if rt.JqExpr == "" && rt.Format != "" && rt.Format != "json" && rt.Format != "pretty" {
presentation = flagListFormatRows(merged)
}
rt.OutFormat(presentation, nil, func(w io.Writer) {
renderFlagListPretty(w, merged)
})
rt.Out(merged, nil)
return nil
}
func flagListFormatRows(data map[string]any) []any {
rows := make([]any, 0)
appendRows := func(raw any, state string) {
items, _ := raw.([]any)
for _, item := range items {
source, _ := item.(map[string]any)
if source == nil {
continue
}
row := make(map[string]any, len(source)+1)
for key, value := range source {
row[key] = value
}
row["list_state"] = state
rows = append(rows, row)
}
}
appendRows(data["flag_items"], "active")
appendRows(data["delete_flag_items"], "deleted")
return rows
}
func renderFlagListPretty(w io.Writer, data map[string]any) {
rows := flagListFormatRows(data)
if len(rows) == 0 {
fmt.Fprintln(w, "No bookmarks found.")
return
}
output.FormatValue(w, rows, output.FormatTable)
active, _ := data["flag_items"].([]any)
deleted, _ := data["delete_flag_items"].([]any)
fmt.Fprintf(w, "\n%d active bookmark(s), %d deleted bookmark(s)\n", len(active), len(deleted))
}

View File

@@ -17,7 +17,6 @@ import (
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/credential"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/shortcuts/common"
"github.com/spf13/cobra"
@@ -271,20 +270,6 @@ func newFlagScopeTestCmd(t *testing.T) *cobra.Command {
return cmd
}
func newFlagListTestCmd(t *testing.T) *cobra.Command {
t.Helper()
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Int("page-size", 50, "")
cmd.Flags().String("page-token", "", "")
cmd.Flags().Bool("enrich-feed-thread", false, "")
cmd.Flags().Bool("page-all", false, "")
cmd.Flags().Int("page-limit", imReadDefaultPageLimit, "")
if err := cmd.ParseFlags(nil); err != nil {
t.Fatalf("ParseFlags() error = %v", err)
}
return cmd
}
type scopedTokenResolver struct {
scopes string
}
@@ -553,153 +538,6 @@ func TestFlagShortcutStaticScopesIncludeLookupRequirements(t *testing.T) {
}
}
func TestImFlagListFormatsPreserveBothBucketsAndReadContract(t *testing.T) {
tests := []struct {
name string
format string
jq string
wantOutput []string
}{
{
name: "pretty",
format: "pretty",
wantOutput: []string{"om_active", "om_deleted", "1 active bookmark(s), 1 deleted bookmark(s)"},
},
{
name: "table",
format: "table",
wantOutput: []string{"list_state", "om_active", "om_deleted", "active", "deleted"},
},
{
name: "csv",
format: "csv",
wantOutput: []string{"list_state", "om_active", "om_deleted", "active", "deleted"},
},
{
name: "ndjson",
format: "ndjson",
wantOutput: []string{`"item_id":"om_active"`, `"item_id":"om_deleted"`, `"list_state":"active"`, `"list_state":"deleted"`},
},
{
name: "jq",
format: "json",
jq: ".data.flag_items[0].item_id",
wantOutput: []string{"om_active"},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
if !strings.Contains(req.URL.Path, "/open-apis/im/v1/flags") {
return nil, fmt.Errorf("unexpected request: %s", req.URL.Path)
}
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"flag_items": []any{
map[string]any{"item_id": "om_active", "item_type": "0", "flag_type": "2"},
},
"delete_flag_items": []any{
map[string]any{"item_id": "om_deleted", "item_type": "0", "flag_type": "2"},
},
"messages": []any{},
"has_more": true,
"page_token": "next",
},
}), nil
}))
cmd := newFlagListTestCmd(t)
setRuntimeField(t, rt, "Cmd", cmd)
rt.Format = tt.format
rt.JqExpr = tt.jq
contract, ok := imcontract.Lookup("im +flag-list")
if !ok {
t.Fatal("read contract not found")
}
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, rt, "readSession", session)
if err := ImFlagList.Execute(context.Background(), rt); err != nil {
t.Fatalf("Execute() error = %v", err)
}
out := rt.Factory.IOStreams.Out.(*bytes.Buffer).String()
for _, want := range tt.wantOutput {
if !strings.Contains(out, want) {
t.Fatalf("stdout = %q, want %q", out, want)
}
}
errOut := rt.Factory.IOStreams.ErrOut.(*bytes.Buffer).String()
if !strings.Contains(errOut, "hint: Result is incomplete.") {
t.Fatalf("stderr = %q, want incomplete-read hint", errOut)
}
})
}
}
func TestImFlagListJSONIncludesCompletenessEnvelopeAndBothBuckets(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"flag_items": []any{map[string]any{"item_id": "om_active"}},
"delete_flag_items": []any{map[string]any{"item_id": "om_deleted"}},
"messages": []any{},
"has_more": true,
"page_token": "next",
},
}), nil
}))
cmd := newFlagListTestCmd(t)
setRuntimeField(t, rt, "Cmd", cmd)
rt.Format = "json"
contract, ok := imcontract.Lookup("im +flag-list")
if !ok {
t.Fatal("read contract not found")
}
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, rt, "readSession", session)
if err := ImFlagList.Execute(context.Background(), rt); err != nil {
t.Fatalf("Execute() error = %v", err)
}
var envelope struct {
OK bool `json:"ok"`
Data struct {
Active []map[string]any `json:"flag_items"`
Deleted []map[string]any `json:"delete_flag_items"`
} `json:"data"`
Meta *output.Meta `json:"meta"`
Hint string `json:"hint"`
}
out := rt.Factory.IOStreams.Out.(*bytes.Buffer).Bytes()
if err := json.Unmarshal(out, &envelope); err != nil {
t.Fatalf("stdout is not JSON: %v\n%s", err, out)
}
if !envelope.OK || len(envelope.Data.Active) != 1 || len(envelope.Data.Deleted) != 1 ||
envelope.Data.Active[0]["item_id"] != "om_active" ||
envelope.Data.Deleted[0]["item_id"] != "om_deleted" {
t.Fatalf("envelope data = %#v, ok = %v", envelope.Data, envelope.OK)
}
if envelope.Meta == nil || envelope.Meta.Complete == nil || *envelope.Meta.Complete ||
envelope.Meta.PagesFetched != 1 || envelope.Meta.StopReason != "single_page" ||
envelope.Meta.NextPageToken != "next" {
t.Fatalf("meta = %#v, want incomplete single_page", envelope.Meta)
}
if !strings.Contains(envelope.Hint, "Result is incomplete.") {
t.Fatalf("hint = %q, want incomplete-read hint", envelope.Hint)
}
if errOut := rt.Factory.IOStreams.ErrOut.(*bytes.Buffer).String(); errOut != "" {
t.Fatalf("stderr = %q, want JSON hint in envelope only", errOut)
}
}
func TestFlagCreateExplicitFeedTypeDoesNotRequireLookupScopes(t *testing.T) {
var calls int
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
@@ -748,68 +586,6 @@ func TestFlagCreateAutoDetectReliesOnDeclaredLookupScopes(t *testing.T) {
}
}
func TestFlagCreateFeedPreflightFailurePreservesRecoveryHint(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
if !strings.Contains(req.URL.Path, "/open-apis/im/v1/messages/om_123") {
t.Fatalf("unexpected request: %s", req.URL.Path)
}
return nil, errors.New("message lookup unavailable")
}))
cmd := newFlagScopeTestCmd(t)
setFlag(t, cmd, "message-id", "om_123")
setFlag(t, cmd, "flag-type", "feed")
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +flag-create")
session := imcontract.NewSession(contract)
setRuntimeField(t, rt, "contractSession", session)
err := ImFlagCreate.Execute(context.Background(), rt)
if err == nil {
t.Fatal("preflight failure was swallowed")
}
err = session.FinalizeError(err)
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("error = %T %v, want typed problem", err, err)
}
if !strings.Contains(problem.Hint, "specify --item-type explicitly") ||
strings.Contains(problem.Hint, "write result is unknown") ||
strings.Contains(strings.ToLower(problem.Hint), "replay") {
t.Fatalf("preflight hint was rewritten: %#v", problem)
}
}
func TestFlagCreateTargetWriteFailureUsesReplayForbidden(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
if req.Method != http.MethodPost || req.URL.Path != "/open-apis/im/v1/flags" {
t.Fatalf("unexpected request: %s %s", req.Method, req.URL.Path)
}
return nil, errors.New("flag write unavailable")
}))
cmd := newFlagScopeTestCmd(t)
setFlag(t, cmd, "message-id", "om_123")
setFlag(t, cmd, "flag-type", "feed")
setFlag(t, cmd, "item-type", "msg_thread")
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +flag-create")
session := imcontract.NewSession(contract)
setRuntimeField(t, rt, "contractSession", session)
err := ImFlagCreate.Execute(context.Background(), rt)
if err == nil {
t.Fatal("target write failure was swallowed")
}
err = session.FinalizeError(err)
problem, ok := errs.ProblemOf(err)
if !ok {
t.Fatalf("error = %T %v, want typed problem", err, err)
}
if problem.Retryable ||
problem.Hint != "The write result is unknown. Do not replay the original request." {
t.Fatalf("target write problem = %#v", problem)
}
}
func TestCheckFlagRequiredScopesReportsTokenResolutionError(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
t.Fatalf("checkFlagRequiredScopes should not call API")
@@ -1164,7 +940,7 @@ func TestListQuery(t *testing.T) {
}
}
func TestFlagListAcceptsUnlimitedPageLimit(t *testing.T) {
func TestFlagListRejectsInvalidPageLimit(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Int("page-size", 50, "")
cmd.Flags().String("page-token", "", "")
@@ -1178,13 +954,16 @@ func TestFlagListAcceptsUnlimitedPageLimit(t *testing.T) {
}
runtime := &common.RuntimeContext{Cmd: cmd}
if err := ImFlagList.Validate(context.Background(), runtime); err != nil {
t.Fatalf("Validate() error = %v, want --page-limit 0 to mean unlimited", err)
if err := ImFlagList.Validate(context.Background(), runtime); err == nil {
t.Fatalf("Validate() expected page-limit error, got nil")
}
got := ImFlagList.DryRun(context.Background(), runtime).Format()
if !strings.Contains(got, "/open-apis/im/v1/flags") {
t.Fatalf("DryRun output = %q, want request preview for valid unlimited input", got)
if !strings.Contains(got, "--page-limit") {
t.Fatalf("DryRun output = %q, want page-limit validation error", got)
}
if strings.Contains(got, "/open-apis/im/v1/flags") {
t.Fatalf("DryRun output = %q, should not include request for invalid input", got)
}
}
@@ -1554,8 +1333,6 @@ func TestFlagCancelExecuteSummarizesPartialFailure(t *testing.T) {
cmd := newFlagScopeTestCmd(t)
setFlag(t, cmd, "message-id", "om_123")
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +flag-cancel")
setRuntimeField(t, rt, "contractSession", imcontract.NewSession(contract))
err := ImFlagCancel.Execute(context.Background(), rt)
if err == nil {
@@ -1574,11 +1351,9 @@ func TestFlagCancelExecuteSummarizesPartialFailure(t *testing.T) {
}
var envelope struct {
OK bool `json:"ok"`
Hint string `json:"hint"`
OK bool `json:"ok"`
Data struct {
Results []map[string]any `json:"results"`
Completion imcontract.Completion `json:"completion"`
Results []map[string]any `json:"results"`
} `json:"data"`
}
if err := json.Unmarshal([]byte(out), &envelope); err != nil {
@@ -1590,62 +1365,11 @@ func TestFlagCancelExecuteSummarizesPartialFailure(t *testing.T) {
if envelope.OK {
t.Fatalf("stdout ok = true, want false for partial failure")
}
if envelope.Data.Completion.RetryScope != "whole_request" ||
envelope.Data.Completion.FailedCount != 1 ||
envelope.Hint != "" {
t.Fatalf("completion = %#v, hint = %q", envelope.Data.Completion, envelope.Hint)
}
if errOut := rt.Factory.IOStreams.ErrOut.(*bytes.Buffer).String(); errOut != "" {
t.Fatalf("stderr = %q, want empty for partial failure result envelope", errOut)
}
}
func TestFlagCancelExecuteSkippedFeedLayerProducesPendingLedger(t *testing.T) {
rt := newUserShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
switch {
case strings.Contains(req.URL.Path, "/open-apis/im/v1/messages/om_pending"):
return nil, fmt.Errorf("message lookup unavailable")
case strings.Contains(req.URL.Path, "/open-apis/im/v1/flags/cancel"):
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{"request_id": "message-ok"},
}), nil
default:
return nil, fmt.Errorf("unexpected request: %s", req.URL.Path)
}
}))
cmd := newFlagScopeTestCmd(t)
setFlag(t, cmd, "message-id", "om_pending")
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +flag-cancel")
setRuntimeField(t, rt, "contractSession", imcontract.NewSession(contract))
if err := ImFlagCancel.Execute(context.Background(), rt); err != nil {
t.Fatalf("Execute() error = %v", err)
}
var envelope struct {
OK bool `json:"ok"`
Hint string `json:"hint"`
Data struct {
Completion imcontract.Completion `json:"completion"`
} `json:"data"`
}
out := rt.Factory.IOStreams.Out.(*bytes.Buffer).Bytes()
if err := json.Unmarshal(out, &envelope); err != nil {
t.Fatalf("stdout is not JSON: %v\n%s", err, out)
}
if envelope.OK || envelope.Data.Completion.PendingCount != 1 ||
len(envelope.Data.Completion.PendingItems) != 1 ||
envelope.Data.Completion.PendingItems[0] != "feed" ||
envelope.Data.Completion.RetryScope != "none" ||
envelope.Hint != "" {
t.Fatalf("pending completion = %#v", envelope.Data.Completion)
}
if errOut := rt.Factory.IOStreams.ErrOut.(*bytes.Buffer).String(); errOut != "" {
t.Fatalf("stderr = %q, want empty", errOut)
}
}
func TestBuildCancelItems_OnlyItemTypeOverride(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.Flags().String("message-id", "", "")
@@ -1799,20 +1523,13 @@ func TestExecuteListAllPages(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Int("page-size", 50, "")
cmd.Flags().Int("page-limit", 10, "")
cmd.Flags().Bool("page-all", true, "")
cmd.Flags().Bool("enrich-feed-thread", false, "")
if err := cmd.ParseFlags(nil); err != nil {
t.Fatalf("ParseFlags() error = %v", err)
}
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +flag-list")
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: true})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, rt, "readSession", session)
err = executeListAllPages(rt)
err := executeListAllPages(rt)
if err != nil {
t.Fatalf("executeListAllPages() error = %v", err)
}
@@ -1863,7 +1580,6 @@ func TestExecuteListAllPages_EnrichFeedThread(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Int("page-size", 50, "")
cmd.Flags().Int("page-limit", 10, "")
cmd.Flags().Bool("page-all", true, "")
cmd.Flags().Bool("enrich-feed-thread", true, "")
if err := cmd.ParseFlags(nil); err != nil {
t.Fatalf("ParseFlags() error = %v", err)
@@ -1898,20 +1614,13 @@ func TestExecuteListAllPages_PageLimit(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Int("page-size", 50, "")
cmd.Flags().Int("page-limit", 3, "") // limit to 3 pages
cmd.Flags().Bool("page-all", true, "")
cmd.Flags().Bool("enrich-feed-thread", false, "")
if err := cmd.ParseFlags(nil); err != nil {
t.Fatalf("ParseFlags() error = %v", err)
}
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +flag-list")
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: true})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, rt, "readSession", session)
err = executeListAllPages(rt)
err := executeListAllPages(rt)
if err != nil {
t.Fatalf("executeListAllPages() error = %v", err)
}
@@ -1919,8 +1628,14 @@ func TestExecuteListAllPages_PageLimit(t *testing.T) {
if callCount != 3 {
t.Fatalf("expected 3 API calls (page limit), got %d", callCount)
}
if stderr := rt.IO().ErrOut.(*bytes.Buffer).String(); stderr != "" {
t.Fatalf("stderr = %q, want structured recovery guidance in stdout", stderr)
stderr := rt.IO().ErrOut.(*bytes.Buffer).String()
for _, want := range []string{"reached page limit (3)", "has_more=true", "result is incomplete", "up to 1000", "page_token returned in stdout"} {
if !strings.Contains(stderr, want) {
t.Fatalf("stderr = %q, want %q", stderr, want)
}
}
if strings.Contains(stderr, "token_3") {
t.Fatalf("stderr must not expose the continuation token, got %q", stderr)
}
var envelope map[string]any
@@ -1937,13 +1652,6 @@ func TestExecuteListAllPages_PageLimit(t *testing.T) {
if _, exists := data["truncated"]; exists {
t.Fatalf("output schema must remain unchanged; unexpected truncated field in %#v", data)
}
meta, _ := envelope["meta"].(map[string]any)
if meta["complete"] != false || meta["stop_reason"] != "page_limit" {
t.Fatalf("meta = %#v, want incomplete page-limit result", meta)
}
if hint, _ := envelope["hint"].(string); !strings.Contains(hint, "--page-limit 0") {
t.Fatalf("hint = %q, want exhaustive-read recovery", hint)
}
}
func TestExecuteListAllPages_RepeatedTokenDoesNotReportPageLimit(t *testing.T) {
@@ -1968,35 +1676,24 @@ func TestExecuteListAllPages_RepeatedTokenDoesNotReportPageLimit(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Int("page-size", 50, "")
cmd.Flags().Int("page-limit", 10, "")
cmd.Flags().Bool("page-all", true, "")
cmd.Flags().Bool("enrich-feed-thread", false, "")
if err := cmd.ParseFlags(nil); err != nil {
t.Fatalf("ParseFlags() error = %v", err)
}
setRuntimeField(t, rt, "Cmd", cmd)
contract, _ := imcontract.Lookup("im +flag-list")
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: true})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, rt, "readSession", session)
if err = executeListAllPages(rt); err != nil {
if err := executeListAllPages(rt); err != nil {
t.Fatalf("executeListAllPages() error = %v", err)
}
if callCount != 2 {
t.Fatalf("API calls = %d, want 2 before repeated-token stop", callCount)
}
if stderr := rt.IO().ErrOut.(*bytes.Buffer).String(); stderr != "" {
t.Fatalf("stderr = %q, want structured repeated-token result in stdout", stderr)
stderr := rt.IO().ErrOut.(*bytes.Buffer).String()
if !strings.Contains(stderr, "page_token did not change") {
t.Fatalf("stderr = %q, want non-advancing token warning", stderr)
}
var envelope map[string]any
if err := json.Unmarshal(rt.IO().Out.(*bytes.Buffer).Bytes(), &envelope); err != nil {
t.Fatalf("decode stdout: %v", err)
}
meta, _ := envelope["meta"].(map[string]any)
if envelope["ok"] != false || meta["stop_reason"] != "repeated_token" {
t.Fatalf("envelope = %#v, want attributed incomplete read", envelope)
if strings.Contains(stderr, "reached page limit") {
t.Fatalf("stderr = %q, repeated token must not be reported as a page-limit stop", stderr)
}
}
@@ -2008,7 +1705,6 @@ func TestExecuteListAllPages_APIError(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Int("page-size", 50, "")
cmd.Flags().Int("page-limit", 10, "")
cmd.Flags().Bool("page-all", true, "")
cmd.Flags().Bool("enrich-feed-thread", false, "")
if err := cmd.ParseFlags(nil); err != nil {
t.Fatalf("ParseFlags() error = %v", err)

View File

@@ -32,9 +32,6 @@ var ImMessagesMGet = common.Shortcut{
{Name: "no-reactions", Type: "bool", Desc: "skip auto-fetching reactions for each message (default: enrichment enabled)"},
downloadResourcesFlag,
},
Tips: []string{
`Example: lark-cli im +messages-mget --message-ids <message_id1>,<message_id2>`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
ids := common.SplitCSV(runtime.Str("message-ids"))
d := common.NewDryRunAPI().GET(buildMGetURL(ids))

View File

@@ -37,10 +37,6 @@ var ImMessagesReply = common.Shortcut{
{Name: "reply-in-thread", Type: "bool", Desc: "reply in thread (message appears in thread stream instead of main chat)"},
{Name: "idempotency-key", Desc: "idempotency key, max 50 characters (prevents duplicate sends)"},
},
Tips: []string{
`Example: lark-cli im +messages-reply --message-id <message_id> --text "reply" --as bot`,
`Example: lark-cli im +messages-reply --message-id <message_id> --text "reply" --reply-in-thread --as bot`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
messageId := runtime.Str("message-id")
msgType := runtime.Str("msg-type")
@@ -155,11 +151,7 @@ var ImMessagesReply = common.Shortcut{
}
if markdown != "" {
post, err := resolveMarkdownAsPost(ctx, runtime, markdown)
if err != nil {
return err
}
msgType, content = "post", post
msgType, content = "post", resolveMarkdownAsPost(ctx, runtime, markdown)
} else if mt, c, err := resolveMediaContent(ctx, runtime, text, imageVal, fileVal, videoVal, videoCoverVal, audioVal); err != nil {
return err
} else if mt != "" {
@@ -182,7 +174,7 @@ var ImMessagesReply = common.Shortcut{
data["uuid"] = idempotencyKey
}
resData, err := runtime.DoWriteAPIJSONTyped(http.MethodPost,
resData, err := runtime.DoAPIJSONTyped(http.MethodPost,
fmt.Sprintf("/open-apis/im/v1/messages/%s/reply", validate.EncodePathSegment(messageId)),
nil, data)
if err != nil {

View File

@@ -34,10 +34,6 @@ var ImMessagesResourcesDownload = common.Shortcut{
{Name: "type", Desc: "resource type (image or file)", Required: true, Enum: []string{"image", "file"}},
{Name: "output", Desc: "local save path (relative only, no .. traversal); when omitted, uses the server's Content-Disposition filename if available, otherwise file_key; extension is inferred from Content-Disposition or Content-Type if not provided"},
},
Tips: []string{
`Example: lark-cli im +messages-resources-download --message-id <message_id> --file-key <file_key> --type file`,
`Example: lark-cli im +messages-resources-download --message-id <message_id> --file-key <image_key> --type image --output ./downloads/pic.png`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
fileKey := runtime.Str("file-key")
outputPath := runtime.Str("output")

View File

@@ -11,7 +11,6 @@ import (
"strconv"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/shortcuts/common"
convertlib "github.com/larksuite/cli/shortcuts/im/convert_lib"
@@ -34,7 +33,7 @@ var ImMessagesSearch = common.Shortcut{
Scopes: []string{"search:message", "im:message.reactions:read"},
AuthTypes: []string{"user"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "query", Desc: "search keyword"},
{Name: "chat-id", Desc: "limit to chat IDs, comma-separated"},
{Name: "sender", Desc: "sender open_ids, comma-separated"},
@@ -48,11 +47,9 @@ var ImMessagesSearch = common.Shortcut{
{Name: "end", Desc: "end time(ISO 8601) with local timezone offset (e.g. 2026-03-25T23:59:59+08:00)"},
{Name: "page-size", Type: "int", Default: "20", Desc: "page size (1-50)"},
{Name: "page-token", Desc: "page token"},
{Name: "page-all", Type: "bool", Desc: "automatically paginate search results"},
{Name: "page-limit", Type: "int", Default: "20", Desc: "max search pages when auto-pagination is enabled (default 20, max 40)"},
{Name: "no-reactions", Type: "bool", Desc: "skip auto-fetching reactions for each message (default: enrichment enabled)"},
}, imPaginationFlags(messagesSearchDefaultPageLimit)...),
Tips: []string{
`Example: lark-cli im +messages-search --query "keyword" --as user`,
`Example: lark-cli im +messages-search --query "keyword" --chat-id <chat_id> --start 2026-07-01 --end 2026-07-08 --as user`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
req, err := buildMessagesSearchRequest(runtime)
@@ -280,8 +277,8 @@ func buildMessagesSearchRequest(runtime *common.RuntimeContext) (*messagesSearch
if runtime.Cmd != nil && runtime.Cmd.Flags().Changed("page-limit") {
pageLimit := runtime.Int("page-limit")
if pageLimit < 0 || pageLimit > messagesSearchMaxPageLimit {
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be between 0 and 40 (0 = unlimited)").WithParam("--page-limit")
if pageLimit < 1 || pageLimit > messagesSearchMaxPageLimit {
return nil, errs.NewValidationError(errs.SubtypeInvalidArgument, "--page-limit must be an integer between 1 and 40").WithParam("--page-limit")
}
}
@@ -391,39 +388,75 @@ func buildMessagesSearchRequest(runtime *common.RuntimeContext) (*messagesSearch
// messagesSearchPaginationConfig derives auto-pagination mode and page limit.
func messagesSearchPaginationConfig(runtime *common.RuntimeContext) (autoPaginate bool, pageLimit int) {
autoPaginate = runtime.Bool("page-all") ||
(runtime.Cmd != nil && runtime.Cmd.Flags().Changed("page-limit"))
pageLimit = runtime.Int("page-limit")
autoPaginate = runtime.Bool("page-all")
if runtime.Cmd != nil && runtime.Cmd.Flags().Changed("page-limit") {
autoPaginate = true
}
pageLimit = messagesSearchDefaultPageLimit
if runtime.Cmd != nil && runtime.Cmd.Flags().Changed("page-limit") {
pageLimit = min(runtime.Int("page-limit"), messagesSearchMaxPageLimit)
} else if runtime.Bool("page-all") {
pageLimit = messagesSearchMaxPageLimit
}
return autoPaginate, pageLimit
}
// searchMessages fetches message search pages and returns the first server notice.
func searchMessages(runtime *common.RuntimeContext, req *messagesSearchRequest) ([]interface{}, bool, string, bool, int, string, error) {
autoPaginate, pageLimit := messagesSearchPaginationConfig(runtime)
pages, status, pageErr := paginateIMWithMode(runtime, autoPaginate, func(pageToken string) (map[string]any, error) {
params := cloneQueryParams(req.params)
pageToken := ""
if tokens := req.params["page_token"]; len(tokens) > 0 {
pageToken = tokens[0]
}
pageSize := strconv.Itoa(messagesSearchDefaultPageSize)
if sizes := req.params["page_size"]; len(sizes) > 0 {
pageSize = sizes[0]
}
var (
allItems []interface{}
lastHasMore bool
lastPageToken string
truncatedByLimit bool
pageCount int
notice string
)
for {
pageCount++
params := larkcore.QueryParams{
"page_size": []string{pageSize},
}
if pageToken != "" {
params["page_token"] = []string{pageToken}
} else {
delete(params, "page_token")
}
return runtime.DoAPIJSONTyped(http.MethodPost, "/open-apis/im/v1/messages/search", params, req.body)
})
if len(pages) == 0 {
return nil, false, "", false, pageLimit, "", pageErr
}
runtime.RecordPagination(status)
merged := mergeIMPageArrays(pages, "items")
allItems, _ := merged["items"].([]interface{})
notice, _ := merged["notice"].(string)
return allItems,
status.HasMore,
status.NextPageToken,
status.StopReason == client.StopReasonPageLimit,
pageLimit,
notice,
nil
searchData, err := runtime.DoAPIJSONTyped(http.MethodPost, "/open-apis/im/v1/messages/search", params, req.body)
if err != nil {
return nil, false, "", false, pageLimit, "", err
}
if notice == "" {
notice, _ = searchData["notice"].(string)
}
items, _ := searchData["items"].([]interface{})
allItems = append(allItems, items...)
lastHasMore, lastPageToken = common.PaginationMeta(searchData)
if !autoPaginate || !lastHasMore || lastPageToken == "" {
break
}
if pageCount >= pageLimit {
truncatedByLimit = true
break
}
pageToken = lastPageToken
}
return allItems, lastHasMore, lastPageToken, truncatedByLimit, pageLimit, notice, nil
}
// batchMGetMessages fetches message details in API-sized batches.

View File

@@ -14,8 +14,6 @@ import (
"strings"
"testing"
"github.com/larksuite/cli/internal/imcontract"
"github.com/larksuite/cli/internal/output"
"github.com/larksuite/cli/shortcuts/common"
"github.com/spf13/cobra"
)
@@ -152,84 +150,13 @@ func TestImMessagesSearchExecuteAutoPaginationBatches(t *testing.T) {
}
}
func TestImMessagesSearchExplicitPageLimitAutoPaginatesAndReportsLimit(t *testing.T) {
var pageTokens []string
runtime := newMessagesSearchRuntime(t, map[string]string{
"query": "incident",
"page-limit": "2",
}, nil, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
if !strings.Contains(req.URL.Path, "/open-apis/im/v1/messages/search") {
return nil, fmt.Errorf("unexpected request: %s", req.URL.Path)
}
token := req.URL.Query().Get("page_token")
pageTokens = append(pageTokens, token)
switch token {
case "":
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"items": []any{},
"has_more": true,
"page_token": "tok_p2",
},
}), nil
case "tok_p2":
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": map[string]any{
"items": []any{},
"has_more": true,
"page_token": "tok_p3",
},
}), nil
default:
return nil, fmt.Errorf("unexpected page token: %q", token)
}
}))
runtime.Format = "json"
contract, ok := imcontract.Lookup("im +messages-search")
if !ok {
t.Fatal("read contract not found")
}
session, err := imcontract.NewReadSession(contract, imcontract.ReadOptions{FullRead: true})
if err != nil {
t.Fatalf("NewReadSession() error = %v", err)
}
setRuntimeField(t, runtime, "readSession", session)
if err := ImMessagesSearch.Execute(context.Background(), runtime); err != nil {
t.Fatalf("Execute() error = %v", err)
}
if !reflect.DeepEqual(pageTokens, []string{"", "tok_p2"}) {
t.Fatalf("page tokens = %#v, want explicit --page-limit to fetch two pages", pageTokens)
}
var envelope struct {
OK bool `json:"ok"`
Meta *output.Meta `json:"meta"`
Hint string `json:"hint"`
}
out := runtime.Factory.IOStreams.Out.(*bytes.Buffer).Bytes()
if err := json.Unmarshal(out, &envelope); err != nil {
t.Fatalf("stdout is not JSON: %v\n%s", err, out)
}
if !envelope.OK || envelope.Meta == nil || envelope.Meta.Complete == nil ||
*envelope.Meta.Complete || envelope.Meta.PagesFetched != 2 ||
envelope.Meta.StopReason != "page_limit" || envelope.Meta.NextPageToken != "tok_p3" {
t.Fatalf("envelope = %#v, want incomplete page_limit result", envelope)
}
const wantHint = "Result is incomplete because --page-limit was reached. Use --page-limit 0 only when exhaustive output is required."
if envelope.Hint != wantHint {
t.Fatalf("hint = %q, want %q", envelope.Hint, wantHint)
}
}
func TestImMessagesSearchExecutePageAllWithExplicitLimit(t *testing.T) {
func TestImMessagesSearchExecuteExplicitPageLimitWithoutPageAll(t *testing.T) {
var searchCalls int
runtime := newMessagesSearchRuntime(t, map[string]string{
"query": "incident",
"page-limit": "2",
}, map[string]bool{"page-all": true}, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
}, nil, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
switch {
case strings.Contains(req.URL.Path, "/open-apis/im/v1/messages/search"):
searchCalls++

View File

@@ -39,11 +39,6 @@ var ImMessagesSend = common.Shortcut{
{Name: "video-cover", Desc: "video cover image key (img_xxx), URL, or cwd-relative local path (absolute paths and .. are rejected); required when using --video"},
{Name: "audio", Desc: audioMessageInputDesc},
},
Tips: []string{
`Example: lark-cli im +messages-send --chat-id <chat_id> --text "hello" --as bot`,
`Example: lark-cli im +messages-send --user-id <open_id> --text "hello" --as bot`,
`Example: lark-cli im +messages-send --chat-id <chat_id> --markdown "## update" --as bot`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
chatFlag := runtime.Str("chat-id")
userFlag := runtime.Str("user-id")
@@ -177,11 +172,7 @@ var ImMessagesSend = common.Shortcut{
}
// Resolve content type
if markdown != "" {
post, err := resolveMarkdownAsPost(ctx, runtime, markdown)
if err != nil {
return err
}
msgType, content = "post", post
msgType, content = "post", resolveMarkdownAsPost(ctx, runtime, markdown)
} else if mt, c, err := resolveMediaContent(ctx, runtime, text, imageVal, fileVal, videoVal, videoCoverVal, audioVal); err != nil {
return err
} else if mt != "" {
@@ -209,7 +200,7 @@ var ImMessagesSend = common.Shortcut{
data["uuid"] = idempotencyKey
}
resData, err := runtime.DoWriteAPIJSONTyped(http.MethodPost, "/open-apis/im/v1/messages",
resData, err := runtime.DoAPIJSONTyped(http.MethodPost, "/open-apis/im/v1/messages",
larkcore.QueryParams{"receive_id_type": []string{receiveIdType}}, data)
if err != nil {
return err

View File

@@ -29,7 +29,7 @@ var ImThreadsMessagesList = common.Shortcut{
BotScopes: []string{"im:message.group_msg", "im:message.p2p_msg:readonly", "im:message.reactions:read"},
AuthTypes: []string{"user", "bot"},
HasFormat: true,
Flags: append([]common.Flag{
Flags: []common.Flag{
{Name: "thread", Desc: "thread ID (om_xxx or omt_xxx)", Required: true},
{Name: "order", Default: "asc", Desc: "sort order: asc | desc", Enum: []string{"asc", "desc"}},
{Name: "sort", Hidden: true, Desc: "alias of --order (hidden)", Enum: []string{"asc", "desc"}},
@@ -37,9 +37,6 @@ var ImThreadsMessagesList = common.Shortcut{
{Name: "page-token", Desc: "page token"},
{Name: "no-reactions", Type: "bool", Desc: "skip auto-fetching reactions for each message (default: enrichment enabled)"},
downloadResourcesFlag,
}, imPaginationFlags(imReadDefaultPageLimit)...),
Tips: []string{
`Example: lark-cli im +threads-messages-list --thread <thread_id>`,
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
threadFlag := runtime.Str("thread")
@@ -79,10 +76,8 @@ var ImThreadsMessagesList = common.Shortcut{
if !strings.HasPrefix(threadId, "om_") && !strings.HasPrefix(threadId, "omt_") {
return errs.NewValidationError(errs.SubtypeInvalidArgument, "invalid --thread %q: must start with om_ or omt_", threadId).WithParam("--thread")
}
if _, err := common.ValidatePageSizeTyped(runtime, "page-size", threadsMessagesMaxPageSize, 1, threadsMessagesMaxPageSize); err != nil {
return err
}
return validateIMPagination(runtime)
_, err := common.ValidatePageSizeTyped(runtime, "page-size", threadsMessagesMaxPageSize, 1, threadsMessagesMaxPageSize)
return err
},
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
threadId, err := resolveThreadID(runtime, runtime.Str("thread"))
@@ -90,19 +85,18 @@ var ImThreadsMessagesList = common.Shortcut{
return err
}
dir := resolveThreadsOrder(runtime)
pageToken := runtime.Str("page-token")
pageSize, _ := common.ValidatePageSizeTyped(runtime, "page-size", threadsMessagesMaxPageSize, 1, threadsMessagesMaxPageSize)
pages, status, pageErr := paginateIM(runtime, func(pageToken string) (map[string]any, error) {
params := buildThreadsMessagesListParams(dir, threadId, pageSize, pageToken)
return runtime.DoAPIJSONTyped(http.MethodGet, "/open-apis/im/v1/messages", params, nil)
})
if len(pages) == 0 {
return pageErr
params := buildThreadsMessagesListParams(dir, threadId, pageSize, pageToken)
data, err := runtime.DoAPIJSONTyped(http.MethodGet, "/open-apis/im/v1/messages", params, nil)
if err != nil {
return err
}
runtime.RecordPagination(status)
data := mergeIMPageArrays(pages, "items")
rawItems, _ := data["items"].([]interface{})
hasMore, nextPageToken := status.HasMore, status.NextPageToken
hasMore, nextPageToken := common.PaginationMeta(data)
nameCache := make(map[string]string)
// Pre-fetch merge_forward sub-messages concurrently before the per-item

View File

@@ -1,197 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package im
import (
"strconv"
"time"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/shortcuts/common"
)
const imReadDefaultPageLimit = 20
type imPageFetcher func(pageToken string) (map[string]any, error)
func imPaginationFlags(defaultLimit int) []common.Flag {
if defaultLimit < 0 {
defaultLimit = imReadDefaultPageLimit
}
return []common.Flag{
{Name: "page-all", Type: "bool", Desc: "automatically paginate through all pages"},
{Name: "page-limit", Type: "int", Default: strconv.Itoa(defaultLimit), Desc: "maximum pages fetched with --page-all (0 = unlimited)"},
}
}
func validateIMPagination(runtime *common.RuntimeContext) error {
if runtime.Int("page-limit") < 0 {
return errs.NewValidationError(
errs.SubtypeInvalidArgument,
"--page-limit must be a non-negative integer",
).WithParam("--page-limit")
}
if runtime.Cmd.Flags().Lookup("page-delay") != nil && runtime.Int("page-delay") < 0 {
return errs.NewValidationError(
errs.SubtypeInvalidArgument,
"--page-delay must be a non-negative integer",
).WithParam("--page-delay")
}
return nil
}
// paginateIM walks an IM shortcut's pages without interpreting whether the
// result is complete. It returns every successful page plus neutral pagination
// facts; the IM contract session owns output, hint, and exit-code semantics.
func paginateIM(runtime *common.RuntimeContext, fetch imPageFetcher) ([]map[string]any, client.PaginationStatus, error) {
return paginateIMWithMode(runtime, runtime.Bool("page-all"), fetch)
}
func paginateIMWithMode(runtime *common.RuntimeContext, autoPaginate bool, fetch imPageFetcher) ([]map[string]any, client.PaginationStatus, error) {
startToken := runtime.Str("page-token")
pageAll := autoPaginate && startToken == ""
pageLimit := runtime.Int("page-limit")
pageDelay := 0
if runtime.Cmd.Flags().Lookup("page-delay") != nil {
pageDelay = runtime.Int("page-delay")
}
pages := make([]map[string]any, 0, 1)
status := client.PaginationStatus{}
requestToken := startToken
seenTokens := make(map[string]struct{})
if startToken != "" {
seenTokens[startToken] = struct{}{}
}
for {
page, err := fetch(requestToken)
if err != nil {
status.Cause = err
status.StopReason = paginationErrorStopReason(err)
return pages, status, err
}
pages = append(pages, page)
status.PagesFetched = len(pages)
status.HasMore, status.NextPageToken = common.PaginationMeta(page)
if explicitlyTruncated(page) {
status.StopReason = client.StopReasonServerTruncation
return pages, status, nil
}
if !status.HasMore {
if startToken != "" {
status.StopReason = client.StopReasonStartPageToken
return pages, status, nil
}
status.StopReason = client.StopReasonExhausted
return pages, status, nil
}
if status.NextPageToken == "" {
err := errs.NewInternalError(
errs.SubtypeInvalidResponse,
"paginated response has_more=true but next page token is missing",
)
status.Cause = err
status.StopReason = client.StopReasonMissingToken
return pages, status, err
}
if _, repeated := seenTokens[status.NextPageToken]; repeated {
err := errs.NewInternalError(
errs.SubtypeInvalidResponse,
"paginated response repeated the same next page token",
)
status.Cause = err
status.StopReason = client.StopReasonRepeatedToken
return pages, status, err
}
if startToken != "" {
status.StopReason = client.StopReasonStartPageToken
return pages, status, nil
}
if !pageAll {
status.StopReason = client.StopReasonSinglePage
return pages, status, nil
}
if pageLimit > 0 && status.PagesFetched >= pageLimit {
status.StopReason = client.StopReasonPageLimit
return pages, status, nil
}
requestToken = status.NextPageToken
seenTokens[requestToken] = struct{}{}
if pageDelay > 0 {
time.Sleep(time.Duration(pageDelay) * time.Millisecond)
}
}
}
func paginationErrorStopReason(err error) client.StopReason {
problem, ok := errs.ProblemOf(err)
if ok && problem.Category == errs.CategoryNetwork {
return client.StopReasonTransportError
}
return client.StopReasonAPIError
}
func explicitlyTruncated(page map[string]any) bool {
if truncated, _ := page["truncated"].(bool); truncated {
return true
}
switch truncations := page["truncations"].(type) {
case []any:
return len(truncations) > 0
case []map[string]any:
return len(truncations) > 0
default:
return false
}
}
// mergeIMPageArrays preserves the first page's non-pagination metadata, merges
// every named array bucket, and carries the final page's cursor state.
func mergeIMPageArrays(pages []map[string]any, arrayFields ...string) map[string]any {
merged := make(map[string]any)
if len(pages) == 0 {
for _, field := range arrayFields {
merged[field] = []any{}
}
return merged
}
for key, value := range pages[0] {
merged[key] = value
}
for _, field := range []string{"has_more", "page_token", "next_page_token"} {
delete(merged, field)
}
for _, field := range arrayFields {
items := make([]any, 0)
for _, page := range pages {
if pageItems, ok := page[field].([]any); ok {
items = append(items, pageItems...)
}
}
merged[field] = items
}
last := pages[len(pages)-1]
if value, ok := last["has_more"]; ok {
merged["has_more"] = value
}
if value, ok := last["page_token"]; ok {
merged["page_token"] = value
}
if value, ok := last["next_page_token"]; ok {
merged["next_page_token"] = value
}
return merged
}
func cloneQueryParams(source map[string][]string) map[string][]string {
cloned := make(map[string][]string, len(source))
for key, values := range source {
cloned[key] = append([]string(nil), values...)
}
return cloned
}

View File

@@ -1,542 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package im
import (
"context"
"errors"
"fmt"
"net/http"
"strconv"
"strings"
"testing"
"github.com/larksuite/cli/errs"
"github.com/larksuite/cli/internal/client"
"github.com/larksuite/cli/internal/core"
"github.com/larksuite/cli/shortcuts/common"
"github.com/spf13/cobra"
)
func TestIMReadShortcutsExposeUniformPaginationFlags(t *testing.T) {
t.Parallel()
shortcuts := []common.Shortcut{
ImChatList,
ImChatMembersList,
ImChatMessageList,
ImChatSearch,
ImFeedGroupList,
ImFeedGroupListItem,
ImFeedShortcutList,
ImFlagList,
ImMessagesSearch,
ImThreadsMessagesList,
}
for _, shortcut := range shortcuts {
shortcut := shortcut
t.Run(shortcut.Command, func(t *testing.T) {
t.Parallel()
flags := make(map[string]common.Flag, len(shortcut.Flags))
for _, flag := range shortcut.Flags {
flags[flag.Name] = flag
}
for _, name := range []string{"page-all", "page-limit"} {
if _, ok := flags[name]; !ok {
t.Fatalf("%s does not expose --%s", shortcut.Command, name)
}
}
if flags["page-limit"].Type != "int" {
t.Fatalf("%s --page-limit type = %q, want int", shortcut.Command, flags["page-limit"].Type)
}
})
}
}
func TestValidateIMPaginationAcceptsUnlimitedAndRejectsNegativeLimit(t *testing.T) {
t.Parallel()
for _, limit := range []int{0, 1, 20} {
rt := newIMPaginationTestRuntime(t, false, limit, "", 0)
if err := validateIMPagination(rt); err != nil {
t.Fatalf("validateIMPagination(page-limit=%d) error = %v", limit, err)
}
}
rt := newIMPaginationTestRuntime(t, false, -1, "", 0)
err := validateIMPagination(rt)
if err == nil || !strings.Contains(err.Error(), "--page-limit") {
t.Fatalf("validateIMPagination(page-limit=-1) error = %v, want --page-limit validation error", err)
}
}
func TestPaginateIMStopReasons(t *testing.T) {
t.Parallel()
tests := []struct {
name string
pageAll bool
pageLimit int
startToken string
pages []map[string]any
wantReason string
wantCount int
wantMore bool
wantToken string
}{
{
name: "default exhausted",
pageLimit: 20,
pages: []map[string]any{{"items": []any{"a"}, "has_more": false}},
wantReason: "exhausted",
wantCount: 1,
},
{
name: "default single page",
pageLimit: 20,
pages: []map[string]any{{"items": []any{"a"}, "has_more": true, "page_token": "next"}},
wantReason: "single_page",
wantCount: 1,
wantMore: true,
wantToken: "next",
},
{
name: "page all exhausted",
pageAll: true,
pageLimit: 0,
pages: []map[string]any{{"has_more": true, "page_token": "p2"}, {"has_more": false}},
wantReason: "exhausted",
wantCount: 2,
},
{
name: "page limit",
pageAll: true,
pageLimit: 1,
pages: []map[string]any{{"has_more": true, "page_token": "p2"}},
wantReason: "page_limit",
wantCount: 1,
wantMore: true,
wantToken: "p2",
},
{
name: "explicit start token",
pageAll: true,
pageLimit: 0,
startToken: "middle",
pages: []map[string]any{{"has_more": false}},
wantReason: "start_page_token",
wantCount: 1,
},
{
name: "server truncation",
pageAll: true,
pageLimit: 0,
pages: []map[string]any{{"has_more": false, "truncations": []any{map[string]any{"type": "user"}}}},
wantReason: "server_truncation",
wantCount: 1,
},
}
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
rt := newIMPaginationTestRuntime(t, tt.pageAll, tt.pageLimit, tt.startToken, 0)
call := 0
gotPages, status, err := paginateIM(rt, func(token string) (map[string]any, error) {
if call >= len(tt.pages) {
t.Fatalf("unexpected page fetch %d with token %q", call+1, token)
}
page := tt.pages[call]
call++
return page, nil
})
if err != nil {
t.Fatalf("paginateIM() error = %v", err)
}
if len(gotPages) != tt.wantCount || status.PagesFetched != tt.wantCount {
t.Fatalf("pages = %d, status.PagesFetched = %d, want %d", len(gotPages), status.PagesFetched, tt.wantCount)
}
if string(status.StopReason) != tt.wantReason {
t.Fatalf("StopReason = %q, want %q", status.StopReason, tt.wantReason)
}
if status.HasMore != tt.wantMore || status.NextPageToken != tt.wantToken {
t.Fatalf("pagination tail = (%v, %q), want (%v, %q)", status.HasMore, status.NextPageToken, tt.wantMore, tt.wantToken)
}
})
}
}
func TestPaginateIMRejectsMissingAndRepeatedTokensWithoutLeakingThem(t *testing.T) {
t.Parallel()
tests := []struct {
name string
pages []map[string]any
wantReason string
}{
{
name: "missing",
pages: []map[string]any{{"has_more": true}},
wantReason: "missing_token",
},
{
name: "repeated",
pages: []map[string]any{
{"has_more": true, "page_token": "secret-token"},
{"has_more": true, "page_token": "secret-token"},
},
wantReason: "repeated_token",
},
}
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
rt := newIMPaginationTestRuntime(t, true, 0, "", 0)
call := 0
gotPages, status, err := paginateIM(rt, func(string) (map[string]any, error) {
page := tt.pages[call]
call++
return page, nil
})
if err == nil {
t.Fatal("paginateIM() error = nil")
}
problem, ok := errs.ProblemOf(err)
if !ok || problem.Subtype != errs.SubtypeInvalidResponse {
t.Fatalf("error = %#v, want typed invalid_response", err)
}
if strings.Contains(err.Error(), "secret-token") {
t.Fatalf("error leaks page token: %v", err)
}
if string(status.StopReason) != tt.wantReason || status.Cause == nil {
t.Fatalf("status = %#v, want reason %q with cause", status, tt.wantReason)
}
if len(gotPages) != call {
t.Fatalf("returned pages = %d, want %d", len(gotPages), call)
}
})
}
}
func TestPaginateIMValidatesTokensBeforeNonFullReadStops(t *testing.T) {
tests := []struct {
name string
startToken string
page map[string]any
wantReason client.StopReason
}{
{
name: "default single page missing token",
page: map[string]any{"has_more": true},
wantReason: client.StopReasonMissingToken,
},
{
name: "explicit start token repeats",
startToken: "opaque-start",
page: map[string]any{"has_more": true, "page_token": "opaque-start"},
wantReason: client.StopReasonRepeatedToken,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
rt := newIMPaginationTestRuntime(t, false, imReadDefaultPageLimit, tt.startToken, 0)
pages, status, err := paginateIM(rt, func(string) (map[string]any, error) {
return tt.page, nil
})
if err == nil {
t.Fatal("paginateIM() error = nil, want invalid_response")
}
problem, ok := errs.ProblemOf(err)
if !ok || problem.Category != errs.CategoryInternal ||
problem.Subtype != errs.SubtypeInvalidResponse {
t.Fatalf("error = %T %v, want internal/invalid_response", err, err)
}
if len(pages) != 1 || status.PagesFetched != 1 || status.StopReason != tt.wantReason {
t.Fatalf("pages/status = %d/%#v, want one page and %q", len(pages), status, tt.wantReason)
}
if strings.Contains(err.Error(), tt.startToken) && tt.startToken != "" {
t.Fatalf("error leaked page token: %v", err)
}
})
}
}
func TestPaginateIMNonFullReadStillReportsNaturalExhaustion(t *testing.T) {
rt := newIMPaginationTestRuntime(t, false, imReadDefaultPageLimit, "", 0)
pages, status, err := paginateIM(rt, func(string) (map[string]any, error) {
return map[string]any{"has_more": false}, nil
})
if err != nil {
t.Fatal(err)
}
if len(pages) != 1 || status.StopReason != client.StopReasonExhausted {
t.Fatalf("pages/status = %d/%#v", len(pages), status)
}
}
func TestPaginateIMPreservesPartialPagesOnTypedFailure(t *testing.T) {
t.Parallel()
wantErr := errs.NewNetworkError(errs.SubtypeNetworkTimeout, "request timed out").WithRetryable()
rt := newIMPaginationTestRuntime(t, true, 0, "", 0)
call := 0
pages, status, err := paginateIM(rt, func(string) (map[string]any, error) {
call++
if call == 1 {
return map[string]any{"items": []any{"a"}, "has_more": true, "page_token": "p2"}, nil
}
return nil, wantErr
})
if !errors.Is(err, wantErr) {
t.Fatalf("error = %v, want %v", err, wantErr)
}
if len(pages) != 1 || status.PagesFetched != 1 {
t.Fatalf("pages/status = %d/%d, want 1/1", len(pages), status.PagesFetched)
}
if string(status.StopReason) != "transport_error" || status.Cause == nil {
t.Fatalf("status = %#v, want transport_error with cause", status)
}
}
func TestMergeIMPageArraysPreservesAllBucketsAndLastPageCursor(t *testing.T) {
t.Parallel()
got := mergeIMPageArrays([]map[string]any{
{
"items": []any{"a"},
"deleted_items": []any{"d1"},
"notice": "first notice",
"has_more": true,
"page_token": "p2",
},
{
"items": []any{"b"},
"deleted_items": []any{"d2"},
"has_more": false,
"page_token": "",
},
}, "items", "deleted_items")
if gotItems, _ := got["items"].([]any); len(gotItems) != 2 {
t.Fatalf("items = %#v, want both pages", got["items"])
}
if gotDeleted, _ := got["deleted_items"].([]any); len(gotDeleted) != 2 {
t.Fatalf("deleted_items = %#v, want both pages", got["deleted_items"])
}
if got["notice"] != "first notice" {
t.Fatalf("notice = %#v, want first-page value", got["notice"])
}
if got["has_more"] != false || got["page_token"] != "" {
t.Fatalf("tail pagination = (%#v, %#v), want (false, empty)", got["has_more"], got["page_token"])
}
}
func TestMergeIMPageArraysDoesNotLeakEarlierPageTokenWhenFinalPageOmitsIt(t *testing.T) {
t.Parallel()
got := mergeIMPageArrays([]map[string]any{
{
"items": []any{"a"},
"has_more": true,
"page_token": "stale-page-token",
"next_page_token": "stale-next-token",
},
{
"items": []any{"b"},
"has_more": false,
},
}, "items")
if got["has_more"] != false {
t.Fatalf("has_more = %#v, want false from final page", got["has_more"])
}
for _, field := range []string{"page_token", "next_page_token"} {
if value, exists := got[field]; exists {
t.Fatalf("%s = %#v, want field omitted with no final-page token", field, value)
}
}
}
func TestIMNewlyPaginatedShortcutsWalkAllPages(t *testing.T) {
tests := []struct {
name string
command func(t *testing.T) *cobra.Command
response func(page int) map[string]any
execute func(*common.RuntimeContext) error
wantMethod string
}{
{
name: "chat list",
command: newPaginatedChatListCommand,
response: func(page int) map[string]any {
return map[string]any{"items": []any{map[string]any{"chat_id": fmt.Sprintf("oc_%d", page)}}, "has_more": page == 1, "page_token": nextTestToken(page)}
},
execute: func(rt *common.RuntimeContext) error {
return ImChatList.Execute(context.Background(), rt)
},
wantMethod: http.MethodGet,
},
{
name: "chat search",
command: newPaginatedChatSearchCommand,
response: func(page int) map[string]any {
return map[string]any{
"items": []any{map[string]any{"meta_data": map[string]any{"chat_id": fmt.Sprintf("oc_%d", page)}}},
"total": float64(2), "has_more": page == 1, "page_token": nextTestToken(page),
}
},
execute: func(rt *common.RuntimeContext) error {
return ImChatSearch.Execute(context.Background(), rt)
},
wantMethod: http.MethodPost,
},
{
name: "chat messages",
command: newPaginatedChatMessagesCommand,
response: func(page int) map[string]any {
return map[string]any{"items": []any{}, "has_more": page == 1, "page_token": nextTestToken(page)}
},
execute: func(rt *common.RuntimeContext) error {
return ImChatMessageList.Execute(context.Background(), rt)
},
wantMethod: http.MethodGet,
},
{
name: "thread messages",
command: newPaginatedThreadMessagesCommand,
response: func(page int) map[string]any {
return map[string]any{"items": []any{}, "has_more": page == 1, "page_token": nextTestToken(page)}
},
execute: func(rt *common.RuntimeContext) error {
return ImThreadsMessagesList.Execute(context.Background(), rt)
},
wantMethod: http.MethodGet,
},
}
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
var tokens []string
rt := newBotShortcutRuntime(t, shortcutRoundTripFunc(func(req *http.Request) (*http.Response, error) {
if req.Method != tt.wantMethod {
t.Fatalf("method = %s, want %s", req.Method, tt.wantMethod)
}
tokens = append(tokens, req.URL.Query().Get("page_token"))
return shortcutJSONResponse(200, map[string]any{
"code": 0,
"data": tt.response(len(tokens)),
}), nil
}))
setRuntimeField(t, rt, "Cmd", tt.command(t))
if err := tt.execute(rt); err != nil {
t.Fatalf("Execute() error = %v", err)
}
if got, want := strings.Join(tokens, ","), ",p2"; got != want {
t.Fatalf("page tokens = %q, want %q", got, want)
}
})
}
}
func nextTestToken(page int) string {
if page == 1 {
return "p2"
}
return ""
}
func addUniformPaginationTestFlags(cmd *cobra.Command) {
cmd.Flags().String("page-token", "", "")
cmd.Flags().Bool("page-all", true, "")
cmd.Flags().Int("page-limit", 0, "")
}
func newPaginatedChatListCommand(t *testing.T) *cobra.Command {
t.Helper()
cmd := &cobra.Command{Use: "test"}
cmd.Flags().String("user-id-type", "open_id", "")
cmd.Flags().String("sort", "create_time", "")
cmd.Flags().String("sort-type", "", "")
cmd.Flags().StringSlice("types", nil, "")
cmd.Flags().Int("page-size", 20, "")
cmd.Flags().Bool("exclude-muted", false, "")
addUniformPaginationTestFlags(cmd)
return cmd
}
func newPaginatedChatSearchCommand(t *testing.T) *cobra.Command {
t.Helper()
cmd := &cobra.Command{Use: "test"}
for _, name := range []string{"query", "search-types", "chat-modes", "member-ids", "sort", "sort-by"} {
cmd.Flags().String(name, "", "")
}
cmd.Flags().Bool("is-manager", false, "")
cmd.Flags().Bool("disable-search-by-user", false, "")
cmd.Flags().Bool("exclude-muted", false, "")
cmd.Flags().Int("page-size", 20, "")
addUniformPaginationTestFlags(cmd)
return cmd
}
func newPaginatedChatMessagesCommand(t *testing.T) *cobra.Command {
t.Helper()
cmd := &cobra.Command{Use: "test"}
for _, name := range []string{"user-id", "start", "end", "sort"} {
cmd.Flags().String(name, "", "")
}
cmd.Flags().String("chat-id", "oc_test", "")
cmd.Flags().String("order", "desc", "")
cmd.Flags().String("page-size", "50", "")
cmd.Flags().Bool("no-reactions", true, "")
cmd.Flags().Bool("download-resources", false, "")
addUniformPaginationTestFlags(cmd)
return cmd
}
func newPaginatedThreadMessagesCommand(t *testing.T) *cobra.Command {
t.Helper()
cmd := &cobra.Command{Use: "test"}
cmd.Flags().String("thread", "omt_test", "")
cmd.Flags().String("order", "asc", "")
cmd.Flags().String("sort", "", "")
cmd.Flags().String("page-size", "50", "")
cmd.Flags().Bool("no-reactions", true, "")
cmd.Flags().Bool("download-resources", false, "")
addUniformPaginationTestFlags(cmd)
return cmd
}
func newIMPaginationTestRuntime(t *testing.T, pageAll bool, pageLimit int, pageToken string, pageDelay int) *common.RuntimeContext {
t.Helper()
cmd := &cobra.Command{Use: "test"}
cmd.Flags().Bool("page-all", false, "")
cmd.Flags().Int("page-limit", 20, "")
cmd.Flags().String("page-token", "", "")
cmd.Flags().Int("page-delay", 0, "")
if pageAll {
if err := cmd.Flags().Set("page-all", "true"); err != nil {
t.Fatal(err)
}
}
if pageLimit != imReadDefaultPageLimit {
if err := cmd.Flags().Set("page-limit", strconv.Itoa(pageLimit)); err != nil {
t.Fatal(err)
}
}
if pageToken != "" {
if err := cmd.Flags().Set("page-token", pageToken); err != nil {
t.Fatal(err)
}
}
if err := cmd.Flags().Set("page-delay", strconv.Itoa(pageDelay)); err != nil {
t.Fatal(err)
}
return &common.RuntimeContext{
Cmd: cmd,
Config: &core.CliConfig{},
}
}

View File

@@ -1,147 +0,0 @@
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
// SPDX-License-Identifier: MIT
package im
import (
"regexp"
"strings"
"testing"
"github.com/larksuite/cli/shortcuts/common"
)
// 12 high-frequency IM shortcuts covered by the original governance closeout,
// plus 6 feed/flag shortcuts that carry a real guessing surface (see the
// inline comment below). Every entry must carry at least one copyable
// "Example:" tip locked by the tests below. The 3 pagination-only feed/flag
// shortcuts (+feed-shortcut-list, +feed-group-list, +flag-list) are
// intentionally exempt — see the inline comment further down.
var tipsExampleTargets = []string{
"+messages-send", "+messages-search", "+chat-messages-list", "+messages-reply",
"+chat-search", "+chat-list", "+messages-mget", "+threads-messages-list",
"+messages-resources-download", "+chat-create", "+chat-update", "+chat-members-list",
// Extension beyond the original high-frequency 12: feed/flag shortcuts with a
// real guessing surface (oc_-only chat ids, --head/--tail exclusivity,
// message- vs feed-layer flag types, ofg_ id sourcing). Pagination-only
// shortcuts (+feed-shortcut-list, +feed-group-list, +flag-list) are
// intentionally exempt — an example there would only restate flag Desc.
"+feed-shortcut-create", "+feed-shortcut-remove",
"+feed-group-list-item", "+feed-group-query-item",
"+flag-create", "+flag-cancel",
}
var exampleFlagTokenRe = regexp.MustCompile(`--[a-z][a-z0-9-]*`)
// Flags injected by the shortcut runner framework rather than declared in
// Shortcut.Flags. --format comes with HasFormat, --json with HasJSON.
var frameworkInjectedFlags = map[string]bool{
"--json": true, "--dry-run": true, "--as": true, "--yes": true, "--format": true,
}
func shortcutByCommand(t *testing.T, command string) common.Shortcut {
t.Helper()
for _, sc := range Shortcuts() {
if sc.Command == command {
return sc
}
}
t.Fatalf("shortcut %s not registered in Shortcuts()", command)
return common.Shortcut{}
}
// exampleCommands returns the command lines of "Example: ..." tips, with the
// "Example: " prefix stripped.
func exampleCommands(sc common.Shortcut) []string {
prefix := "Example: lark-cli im " + sc.Command
var out []string
for _, tip := range sc.Tips {
if strings.HasPrefix(tip, prefix+" ") || tip == prefix {
out = append(out, strings.TrimPrefix(tip, "Example: "))
}
}
return out
}
func TestIMTipsExamplesPresent(t *testing.T) {
for _, cmd := range tipsExampleTargets {
sc := shortcutByCommand(t, cmd)
examples := exampleCommands(sc)
if len(examples) < 1 {
t.Errorf("%s: want >=1 tip starting with %q, got none (tips=%q)",
cmd, "Example: lark-cli im "+cmd, sc.Tips)
}
if len(examples) > 3 {
t.Errorf("%s: want <=3 examples to keep help focused, got %d", cmd, len(examples))
}
}
}
func TestIMTipsExampleFlagsExist(t *testing.T) {
for _, cmd := range tipsExampleTargets {
sc := shortcutByCommand(t, cmd)
declared := map[string]bool{}
for _, f := range sc.Flags {
declared["--"+f.Name] = true
}
for _, example := range exampleCommands(sc) {
for _, tok := range exampleFlagTokenRe.FindAllString(example, -1) {
if !declared[tok] && !frameworkInjectedFlags[tok] {
t.Errorf("%s: example uses %s which is neither a declared flag nor framework-injected\nexample: %s",
cmd, tok, example)
}
}
}
}
}
// TestIMTipsExamplesPinIdentity locks the identity convention on copyable
// examples: user-only shortcuts must pin --as user (a bot-default
// environment would otherwise reject the copied command), and the outbound
// send/reply shortcuts must pin --as bot (governance: never rely on the
// local default identity for deliveries).
func TestIMTipsExamplesPinIdentity(t *testing.T) {
outbound := map[string]bool{"+messages-send": true, "+messages-reply": true}
for _, cmd := range tipsExampleTargets {
sc := shortcutByCommand(t, cmd)
botCapable := false
for _, a := range sc.AuthTypes {
if a == "bot" {
botCapable = true
}
}
for _, example := range exampleCommands(sc) {
if !botCapable && !strings.Contains(example, "--as user") {
t.Errorf("%s: user-only example must pin --as user\nexample: %s", cmd, example)
}
if outbound[cmd] && !strings.Contains(example, "--as bot") {
t.Errorf("%s: outbound example must pin --as bot\nexample: %s", cmd, example)
}
}
}
}
func TestIMTipsFirstExampleCoversRequired(t *testing.T) {
for _, cmd := range tipsExampleTargets {
sc := shortcutByCommand(t, cmd)
examples := exampleCommands(sc)
if len(examples) == 0 {
continue // reported by TestIMTipsExamplesPresent
}
// Compare whole flag tokens, not substrings: a required --user must
// not be satisfied by an example that only carries --user-id.
flagTokens := map[string]bool{}
for _, tok := range exampleFlagTokenRe.FindAllString(examples[0], -1) {
flagTokens[tok] = true
}
for _, f := range sc.Flags {
if !f.Required {
continue
}
if !flagTokens["--"+f.Name] {
t.Errorf("%s: first example must cover required flag --%s\nexample: %s",
cmd, f.Name, examples[0])
}
}
}
}

View File

@@ -32,6 +32,7 @@ const (
markdownUploadPrepareAction = "initialize markdown multipart upload failed"
markdownUploadFinishAction = "finalize markdown multipart upload failed"
markdownFetchNameAction = "fetch existing markdown file name failed"
markdownSourceFilePreviewType = "16"
)
var markdownUploadRetryBackoffs = []time.Duration{
@@ -192,9 +193,14 @@ func resolveMarkdownOverwriteFileName(runtime *common.RuntimeContext, spec markd
}
func openMarkdownDownload(ctx context.Context, runtime *common.RuntimeContext, fileToken string) (*http.Response, error) {
query, err := markdownSourceFilePreviewQuery("", "")
if err != nil {
return nil, err
}
resp, err := runtime.DoAPIStream(ctx, &larkcore.ApiReq{
HttpMethod: http.MethodGet,
ApiPath: fmt.Sprintf("/open-apis/drive/v1/files/%s/download", validate.EncodePathSegment(fileToken)),
HttpMethod: http.MethodGet,
ApiPath: fmt.Sprintf("/open-apis/drive/v1/medias/%s/preview_download", validate.EncodePathSegment(fileToken)),
QueryParams: query,
})
if err != nil {
return nil, wrapMarkdownDownloadError(err)
@@ -230,15 +236,15 @@ func markdownSourceSize(runtime *common.RuntimeContext, spec markdownUploadSpec)
return size, nil
}
func openMarkdownDownloadVersion(ctx context.Context, runtime *common.RuntimeContext, fileToken, version string) (*http.Response, string, error) {
req := &larkcore.ApiReq{
HttpMethod: http.MethodGet,
ApiPath: fmt.Sprintf("/open-apis/drive/v1/files/%s/download", validate.EncodePathSegment(fileToken)),
func openMarkdownDownloadVersion(ctx context.Context, runtime *common.RuntimeContext, fileToken, version, versionParam string) (*http.Response, string, error) {
query, err := markdownSourceFilePreviewQuery(version, versionParam)
if err != nil {
return nil, "", err
}
if strings.TrimSpace(version) != "" {
req.QueryParams = larkcore.QueryParams{
"version": []string{strings.TrimSpace(version)},
}
req := &larkcore.ApiReq{
HttpMethod: http.MethodGet,
ApiPath: fmt.Sprintf("/open-apis/drive/v1/medias/%s/preview_download", validate.EncodePathSegment(fileToken)),
QueryParams: query,
}
resp, err := runtime.DoAPIStream(ctx, req)
@@ -248,6 +254,58 @@ func openMarkdownDownloadVersion(ctx context.Context, runtime *common.RuntimeCon
return resp, fileNameFromDownloadHeader(resp.Header, fileToken+".md"), nil
}
func markdownSourceFilePreviewQuery(version, versionParam string) (larkcore.QueryParams, error) {
if err := validateMarkdownSourceFilePreviewVersion(version, versionParam); err != nil {
return nil, err
}
query := larkcore.QueryParams{
"preview_type": []string{markdownSourceFilePreviewType},
}
if version != "" {
query["version"] = []string{version}
}
return query, nil
}
func markdownSourceFilePreviewDryRunParams(version, versionParam string) (map[string]interface{}, error) {
if err := validateMarkdownSourceFilePreviewVersion(version, versionParam); err != nil {
return nil, err
}
params := map[string]interface{}{
"preview_type": markdownSourceFilePreviewType,
}
if version != "" {
params["version"] = version
}
return params, nil
}
func markdownSourceFilePreviewDryRunParamsForValidatedVersion(version, versionParam string) map[string]interface{} {
params, err := markdownSourceFilePreviewDryRunParams(version, versionParam)
if err != nil {
// Shortcut validation runs before DryRun. If a caller bypasses that
// contract, preserve the supplied value instead of silently dropping it.
params = map[string]interface{}{
"preview_type": markdownSourceFilePreviewType,
"version": version,
}
}
return params
}
func validateMarkdownSourceFilePreviewVersion(version, flagName string) error {
if version == "" {
return nil
}
if strings.TrimSpace(version) != "" {
return nil
}
if flagName == "" {
flagName = "--version"
}
return markdownValidationParamError(flagName, "%s cannot be empty", flagName)
}
func markdownDryRunFileField(spec markdownUploadSpec) string {
if spec.FilePath != "" {
return "@" + spec.FilePath

View File

@@ -112,9 +112,8 @@ func validateMarkdownDiffSpec(runtime *common.RuntimeContext, spec markdownDiffS
}
func validateMarkdownDiffVersionValue(value, flagName string) error {
value = strings.TrimSpace(value)
if value == "" {
return markdownValidationParamError(flagName, "%s cannot be empty", flagName)
if err := validateMarkdownSourceFilePreviewVersion(value, flagName); err != nil {
return err
}
if !markdownDiffVersionRe.MatchString(value) {
return markdownValidationParamError(flagName, "%s must be a numeric version string", flagName)
@@ -134,31 +133,33 @@ func markdownDiffDryRun(spec markdownDiffSpec) *common.DryRunAPI {
switch markdownDiffMode(spec) {
case markdownDiffModeRemoteVsLocal:
if spec.FromVersion != "" {
dry.GET("/open-apis/drive/v1/files/:file_token/download").
Desc("[1] Download the specified remote Markdown version").
dry.GET("/open-apis/drive/v1/medias/:file_token/preview_download").
Desc("[1] Download the specified remote Markdown source file preview artifact").
Set("file_token", spec.FileToken).
Params(map[string]interface{}{"version": spec.FromVersion})
Params(markdownSourceFilePreviewDryRunParamsForValidatedVersion(spec.FromVersion, "--from-version"))
} else {
dry.GET("/open-apis/drive/v1/files/:file_token/download").
Desc("[1] Download the latest remote Markdown version").
Set("file_token", spec.FileToken)
dry.GET("/open-apis/drive/v1/medias/:file_token/preview_download").
Desc("[1] Download the latest remote Markdown source file preview artifact").
Set("file_token", spec.FileToken).
Params(markdownSourceFilePreviewDryRunParamsForValidatedVersion("", ""))
}
dry.Set("local_file", spec.FilePath)
dry.Set("mode", markdownDiffModeRemoteVsLocal)
default:
dry.GET("/open-apis/drive/v1/files/:file_token/download").
Desc("[1] Download the base remote Markdown version").
dry.GET("/open-apis/drive/v1/medias/:file_token/preview_download").
Desc("[1] Download the base remote Markdown source file preview artifact").
Set("file_token", spec.FileToken).
Params(map[string]interface{}{"version": spec.FromVersion})
Params(markdownSourceFilePreviewDryRunParamsForValidatedVersion(spec.FromVersion, "--from-version"))
if spec.ToVersion != "" {
dry.GET("/open-apis/drive/v1/files/:file_token/download").
Desc("[2] Download the target remote Markdown version").
dry.GET("/open-apis/drive/v1/medias/:file_token/preview_download").
Desc("[2] Download the target remote Markdown source file preview artifact").
Set("file_token", spec.FileToken).
Params(map[string]interface{}{"version": spec.ToVersion})
Params(markdownSourceFilePreviewDryRunParamsForValidatedVersion(spec.ToVersion, "--to-version"))
} else {
dry.GET("/open-apis/drive/v1/files/:file_token/download").
Desc("[2] Download the latest remote Markdown version").
Set("file_token", spec.FileToken)
dry.GET("/open-apis/drive/v1/medias/:file_token/preview_download").
Desc("[2] Download the latest remote Markdown source file preview artifact").
Set("file_token", spec.FileToken).
Params(markdownSourceFilePreviewDryRunParamsForValidatedVersion("", ""))
}
dry.Set("mode", markdownDiffModeRemoteVsRemote)
}
@@ -166,8 +167,8 @@ func markdownDiffDryRun(spec markdownDiffSpec) *common.DryRunAPI {
return dry
}
func downloadMarkdownContent(ctx context.Context, runtime *common.RuntimeContext, fileToken, version string) (string, string, error) {
resp, fileName, err := openMarkdownDownloadVersion(ctx, runtime, fileToken, version)
func downloadMarkdownContent(ctx context.Context, runtime *common.RuntimeContext, fileToken, version, versionParam string) (string, string, error) {
resp, fileName, err := openMarkdownDownloadVersion(ctx, runtime, fileToken, version, versionParam)
if err != nil {
return "", "", err
}
@@ -446,8 +447,8 @@ var MarkdownDiff = common.Shortcut{
Validate: func(ctx context.Context, runtime *common.RuntimeContext) error {
return validateMarkdownDiffSpec(runtime, markdownDiffSpec{
FileToken: strings.TrimSpace(runtime.Str("file-token")),
FromVersion: strings.TrimSpace(runtime.Str("from-version")),
ToVersion: strings.TrimSpace(runtime.Str("to-version")),
FromVersion: runtime.Str("from-version"),
ToVersion: runtime.Str("to-version"),
FilePath: strings.TrimSpace(runtime.Str("file")),
ContextLines: runtime.Int("context-lines"),
Format: runtime.Format,
@@ -456,8 +457,8 @@ var MarkdownDiff = common.Shortcut{
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
return markdownDiffDryRun(markdownDiffSpec{
FileToken: strings.TrimSpace(runtime.Str("file-token")),
FromVersion: strings.TrimSpace(runtime.Str("from-version")),
ToVersion: strings.TrimSpace(runtime.Str("to-version")),
FromVersion: runtime.Str("from-version"),
ToVersion: runtime.Str("to-version"),
FilePath: strings.TrimSpace(runtime.Str("file")),
ContextLines: runtime.Int("context-lines"),
})
@@ -465,8 +466,8 @@ var MarkdownDiff = common.Shortcut{
Execute: func(ctx context.Context, runtime *common.RuntimeContext) error {
spec := markdownDiffSpec{
FileToken: strings.TrimSpace(runtime.Str("file-token")),
FromVersion: strings.TrimSpace(runtime.Str("from-version")),
ToVersion: strings.TrimSpace(runtime.Str("to-version")),
FromVersion: runtime.Str("from-version"),
ToVersion: runtime.Str("to-version"),
FilePath: strings.TrimSpace(runtime.Str("file")),
ContextLines: runtime.Int("context-lines"),
}
@@ -487,7 +488,7 @@ var MarkdownDiff = common.Shortcut{
} else {
fromLabel += "@latest"
}
_, fromContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, spec.FromVersion)
_, fromContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, spec.FromVersion, "--from-version")
if err != nil {
return err
}
@@ -499,17 +500,17 @@ var MarkdownDiff = common.Shortcut{
}
default:
fromLabel = "a/" + spec.FileToken + "@version:" + spec.FromVersion
_, fromContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, spec.FromVersion)
_, fromContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, spec.FromVersion, "--from-version")
if err != nil {
return err
}
if spec.ToVersion != "" {
toLabel = "b/" + spec.FileToken + "@version:" + spec.ToVersion
_, toContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, spec.ToVersion)
_, toContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, spec.ToVersion, "--to-version")
} else {
toLabel = "b/" + spec.FileToken + "@latest"
_, toContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, "")
_, toContent, err = downloadMarkdownContent(ctx, runtime, spec.FileToken, "", "")
}
if err != nil {
return err

View File

@@ -48,6 +48,73 @@ func TestMarkdownDiffRejectsToVersionWithoutFromVersion(t *testing.T) {
}
}
func TestMarkdownDiffRejectsBlankVersion(t *testing.T) {
tests := []struct {
name string
args []string
wantParam string
}{
{
name: "from version",
args: []string{
"+diff",
"--file-token", "box_md_diff",
"--from-version", " \t",
"--file", "./local.md",
},
wantParam: "--from-version",
},
{
name: "to version",
args: []string{
"+diff",
"--file-token", "box_md_diff",
"--from-version", "7633658129540910621",
"--to-version", " ",
},
wantParam: "--to-version",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", t.TempDir())
f, stdout, _, _ := cmdutil.TestFactory(t, markdownTestConfig())
err := mountAndRunMarkdown(t, MarkdownDiff, tt.args, f, stdout)
requireMarkdownValidationParam(t, err, tt.wantParam)
if !strings.Contains(err.Error(), "cannot be empty") {
t.Fatalf("expected empty version validation error, got %v", err)
}
})
}
}
func TestMarkdownSourceFilePreviewParamsValidateAndPreserveVersion(t *testing.T) {
version := " 7633658129540910621 "
query, err := markdownSourceFilePreviewQuery(version, "--from-version")
if err != nil {
t.Fatalf("markdownSourceFilePreviewQuery() error: %v", err)
}
if got := query["version"]; len(got) != 1 || got[0] != version {
t.Fatalf("query version = %#v, want original %q", got, version)
}
params, err := markdownSourceFilePreviewDryRunParams(version, "--from-version")
if err != nil {
t.Fatalf("markdownSourceFilePreviewDryRunParams() error: %v", err)
}
if got := params["version"]; got != version {
t.Fatalf("dry-run version = %#v, want original %q", got, version)
}
_, err = markdownSourceFilePreviewQuery(" \n", "--from-version")
requireMarkdownValidationParam(t, err, "--from-version")
_, err = markdownSourceFilePreviewDryRunParams(" \t", "--to-version")
requireMarkdownValidationParam(t, err, "--to-version")
}
func TestMarkdownDiffMissingVersionAndFileNamesCandidateParams(t *testing.T) {
t.Setenv("LARKSUITE_CLI_CONFIG_DIR", t.TempDir())
f, stdout, _, _ := cmdutil.TestFactory(t, markdownTestConfig())
@@ -79,7 +146,7 @@ func TestMarkdownDiffRemoteVsRemoteJSON(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, markdownTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download?version=7633658129540910621",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16&version=7633658129540910621",
Status: 200,
RawBody: []byte("# Title\n\n- alpha\n- beta\n"),
Headers: http.Header{
@@ -88,7 +155,7 @@ func TestMarkdownDiffRemoteVsRemoteJSON(t *testing.T) {
})
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download?version=7633658129540910628",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16&version=7633658129540910628",
Status: 200,
RawBody: []byte("# Title\n\n- alpha\n- beta updated\n- gamma\n"),
Headers: http.Header{
@@ -151,7 +218,7 @@ func TestMarkdownDiffRemoteVsLocalPretty(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, markdownTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16",
Status: 200,
RawBody: []byte("# Title\n\nhello old\n"),
Headers: http.Header{
@@ -191,7 +258,7 @@ func TestMarkdownDiffRejectsOversizedRemoteContent(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, markdownTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16",
Status: 200,
RawBody: bytes.Repeat([]byte("x"), markdownDiffMaxContentBytes+1),
})
@@ -218,7 +285,7 @@ func TestMarkdownDiffRejectsOversizedLocalContent(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, markdownTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16",
Status: 200,
RawBody: []byte("# Title\n"),
})
@@ -337,7 +404,7 @@ func TestMarkdownDiffRemoteVsRemoteJSONMultipleHunks(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, markdownTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download?version=7633658129540910621",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16&version=7633658129540910621",
Status: 200,
RawBody: []byte("line1\nline2\nline3\nline4\nline5\nline6\n"),
Headers: http.Header{
@@ -346,7 +413,7 @@ func TestMarkdownDiffRemoteVsRemoteJSONMultipleHunks(t *testing.T) {
})
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download?version=7633658129540910628",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16&version=7633658129540910628",
Status: 200,
RawBody: []byte("line1\nline2 changed\nline3\nline4\nline5 changed\nline6\n"),
Headers: http.Header{
@@ -398,13 +465,13 @@ func TestMarkdownDiffNoChangesPretty(t *testing.T) {
f, stdout, _, reg := cmdutil.TestFactory(t, markdownTestConfig())
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download?version=7633658129540910621",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16&version=7633658129540910621",
Status: 200,
RawBody: []byte("# Title\n"),
})
reg.Register(&httpmock.Stub{
Method: "GET",
URL: "/open-apis/drive/v1/files/box_md_diff/download",
URL: "/open-apis/drive/v1/medias/box_md_diff/preview_download?preview_type=16",
Status: 200,
RawBody: []byte("# Title\n"),
})
@@ -445,8 +512,11 @@ func TestMarkdownDiffDryRunRemoteVsLocal(t *testing.T) {
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !strings.Contains(stdout.String(), "/open-apis/drive/v1/files/:file_token/download") && !strings.Contains(stdout.String(), "/open-apis/drive/v1/files/box_md_diff/download") {
t.Fatalf("dry-run missing download call: %s", stdout.String())
if !strings.Contains(stdout.String(), "/open-apis/drive/v1/medias/box_md_diff/preview_download") {
t.Fatalf("dry-run missing source preview download call: %s", stdout.String())
}
if !strings.Contains(stdout.String(), `"preview_type": "16"`) {
t.Fatalf("dry-run missing source_file preview_type: %s", stdout.String())
}
if !strings.Contains(stdout.String(), `"local_file": "local.md"`) && !strings.Contains(stdout.String(), `"local_file": "./local.md"`) {
t.Fatalf("dry-run missing local file metadata: %s", stdout.String())

View File

@@ -5,14 +5,10 @@ package markdown
import (
"context"
"fmt"
"io"
"net/http"
"path/filepath"
"strings"
larkcore "github.com/larksuite/oapi-sdk-go/v3/core"
"github.com/larksuite/cli/extension/fileio"
"github.com/larksuite/cli/internal/validate"
"github.com/larksuite/cli/shortcuts/common"
@@ -47,8 +43,9 @@ var MarkdownFetch = common.Shortcut{
},
DryRun: func(ctx context.Context, runtime *common.RuntimeContext) *common.DryRunAPI {
dry := common.NewDryRunAPI().
Desc("download markdown file bytes; when --output is omitted the CLI returns content as UTF-8 text").
GET("/open-apis/drive/v1/files/:file_token/download").
Desc("download markdown source file preview artifact bytes; when --output is omitted the CLI returns content as UTF-8 text").
GET("/open-apis/drive/v1/medias/:file_token/preview_download").
Params(markdownSourceFilePreviewDryRunParamsForValidatedVersion("", "")).
Set("file_token", runtime.Str("file-token"))
if outputPath := strings.TrimSpace(runtime.Str("output")); outputPath != "" {
dry.Set("output", outputPath)
@@ -61,12 +58,9 @@ var MarkdownFetch = common.Shortcut{
fileToken := strings.TrimSpace(runtime.Str("file-token"))
outputPath := strings.TrimSpace(runtime.Str("output"))
resp, err := runtime.DoAPIStream(ctx, &larkcore.ApiReq{
HttpMethod: http.MethodGet,
ApiPath: fmt.Sprintf("/open-apis/drive/v1/files/%s/download", validate.EncodePathSegment(fileToken)),
})
resp, err := openMarkdownDownload(ctx, runtime, fileToken)
if err != nil {
return wrapMarkdownDownloadError(err)
return err
}
defer resp.Body.Close()

Some files were not shown because too many files have changed in this diff Show More