mirror of
https://github.com/larksuite/cli.git
synced 2026-08-03 08:32:46 +08:00
b3fcf55611
Input pre-check failures shared by every shortcut — @file/stdin input resolution, enum validation, and unsupported --dry-run — now leave the CLI as typed validation envelopes naming the offending flag, so scripts and AI agents can branch on `param` instead of parsing prose. Wire type, exit code, and message text are unchanged; the new fields are additive. The shared layer also gains typed replacements for its legacy error-producing helpers, so each business domain can migrate to typed errors without rebuilding common plumbing, and a path-scoped lint guard keeps migrated domains from sliding back. Changes: - Shared pre-check failures (input flags, enum values, dry-run support) return typed validation errors carrying the offending flag as `param`. - Every legacy error-producing helper in shortcuts/common has a typed replacement that preserves the existing message text: validation and flag-group checks, chat/user ID validation (callers name the flag so `param` is ground truth), "me" open-id resolution, safe-path checks, input-stat and save-error wrapping. Legacy helpers stay for not-yet-migrated domains, marked deprecated — including the legacy API-result classifier, whose typed route is runtime.CallAPITyped. - A new errscontract rule rejects legacy common-helper calls on migrated paths, so a migrated domain cannot silently reintroduce legacy envelopes; drive is the first locked path and its last legacy ID-helper calls are replaced.
89 lines
2.5 KiB
Go
89 lines
2.5 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package common
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/larksuite/cli/internal/output"
|
|
)
|
|
|
|
// ValidateChatID checks if a chat ID has valid format (oc_ prefix).
|
|
// Also extracts token from URL if provided.
|
|
//
|
|
// Deprecated: use ValidateChatIDTyped for typed error envelopes.
|
|
func ValidateChatID(input string) (string, error) {
|
|
chatID, msg := normalizeChatID(input)
|
|
if msg != "" {
|
|
return "", output.ErrValidation("%s", msg)
|
|
}
|
|
return chatID, nil
|
|
}
|
|
|
|
// ValidateChatIDTyped checks if a chat ID has valid format (oc_ prefix).
|
|
// Also extracts token from URL if provided. param names the flag being
|
|
// validated (e.g. "--chat-ids") and is recorded on the typed error.
|
|
func ValidateChatIDTyped(param, input string) (string, error) {
|
|
chatID, msg := normalizeChatID(input)
|
|
if msg != "" {
|
|
return "", ValidationErrorf("%s", msg).WithParam(param)
|
|
}
|
|
return chatID, nil
|
|
}
|
|
|
|
func normalizeChatID(input string) (string, string) {
|
|
input = strings.TrimSpace(input)
|
|
if input == "" {
|
|
return "", "chat ID cannot be empty"
|
|
}
|
|
// Extract from URL if present
|
|
if strings.Contains(input, "feishu.cn") || strings.Contains(input, "larksuite.com") {
|
|
// Extract oc_xxx from URL
|
|
parts := strings.Split(input, "/")
|
|
for _, part := range parts {
|
|
if strings.HasPrefix(part, "oc_") {
|
|
input = part
|
|
break
|
|
}
|
|
}
|
|
}
|
|
if !strings.HasPrefix(input, "oc_") {
|
|
return "", "invalid chat ID format, should start with 'oc_' (e.g., oc_abc123)"
|
|
}
|
|
return input, ""
|
|
}
|
|
|
|
// ValidateUserID checks if a user ID has valid format (ou_ prefix).
|
|
//
|
|
// Deprecated: use ValidateUserIDTyped for typed error envelopes.
|
|
func ValidateUserID(input string) (string, error) {
|
|
userID, msg := normalizeUserID(input)
|
|
if msg != "" {
|
|
return "", output.ErrValidation("%s", msg)
|
|
}
|
|
return userID, nil
|
|
}
|
|
|
|
// ValidateUserIDTyped checks if a user ID has valid format (ou_ prefix).
|
|
// param names the flag being validated (e.g. "--creator-ids") and is
|
|
// recorded on the typed error.
|
|
func ValidateUserIDTyped(param, input string) (string, error) {
|
|
userID, msg := normalizeUserID(input)
|
|
if msg != "" {
|
|
return "", ValidationErrorf("%s", msg).WithParam(param)
|
|
}
|
|
return userID, nil
|
|
}
|
|
|
|
func normalizeUserID(input string) (string, string) {
|
|
input = strings.TrimSpace(input)
|
|
if input == "" {
|
|
return "", "user ID cannot be empty"
|
|
}
|
|
if !strings.HasPrefix(input, "ou_") {
|
|
return "", "invalid user ID format, should start with 'ou_' (e.g., ou_abc123)"
|
|
}
|
|
return input, ""
|
|
}
|