mirror of
https://github.com/larksuite/cli.git
synced 2026-07-04 23:15:25 +08:00
Every failure on the authentication, authorization, and configuration
path now surfaces as a typed structured error instead of an ad-hoc
envelope. Users and scripts that consume CLI output get:
- a fixed nine-category taxonomy on the wire, each mapped to a
stable shell exit code (authentication/authorization/config = 3,
network = 4, internal = 5, policy = 6, confirmation = 10)
- identity-aware detail fields (missing_scopes, requested_scopes,
granted_scopes, console_url, log_id, retryable, hint) carried
uniformly on the envelope
- a single canonical policy envelope at exit 6; the legacy
auth_error carve-out is retired
- per-subtype canonical message + hint that preserves Lark's
diagnostic phrasing and routes recovery to the right actor:
app developer (app_scope_not_applied), user (missing_scope,
token_scope_insufficient, user_unauthorized), or tenant admin
(app_unavailable, app_disabled)
- wrong app credentials classify as config/invalid_client whether
surfaced by the Open API endpoint (99991543) or the tenant
access-token mint endpoint (10003 / 10014), instead of
collapsing to a transport error or api/unknown
- local shortcut scope preflight emits the same
authorization/missing_scope envelope (identity + deterministic
missing-scope set) used by the post-call permission path, so AI
consumers read the same structured shape from precheck and from
server-returned permission denial
- streaming download/upload failures keep the same network subtype
split (timeout / TLS / DNS / transport) as the non-stream path
instead of collapsing every cause to a generic transport failure
- console_url is carried only on the bot-perspective
app_scope_not_applied envelope (where the recovery action is
"developer applies the scope at the developer console"); the
user-perspective missing_scope envelope drops the field, since
the only actionable user recovery is `lark-cli auth login --scope`
and pointing an end user at a console they cannot modify is
misleading
- bind workflows (Hermes / OpenClaw / lark-channel) flatten dynamic
Type tags to wire 'config' with the original module name kept
as a metric label
All 10 typed errors are cause-bearing, nil-safe on .Error() and
.Unwrap(), and defensively clone slice setter inputs. Four lint
rules (CheckNilSafeError / CheckBuilderImmutable / CheckUnwrapSymmetry
/ CheckBuildAPIErrorArms) lock these invariants on migrated paths.
251 lines
8.5 KiB
Go
251 lines
8.5 KiB
Go
// Copyright (c) 2026 Lark Technologies Pte. Ltd.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package client
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"mime"
|
|
"strings"
|
|
|
|
larkcore "github.com/larksuite/oapi-sdk-go/v3/core"
|
|
|
|
"github.com/larksuite/cli/errs"
|
|
"github.com/larksuite/cli/extension/fileio"
|
|
"github.com/larksuite/cli/internal/core"
|
|
"github.com/larksuite/cli/internal/output"
|
|
"github.com/larksuite/cli/internal/util"
|
|
)
|
|
|
|
// ── Response routing ──
|
|
|
|
// ResponseOptions configures how HandleResponse routes a raw API response.
|
|
type ResponseOptions struct {
|
|
OutputPath string // --output flag; "" = auto-detect
|
|
Format output.Format // output format for JSON responses
|
|
JqExpr string // if set, apply jq filter instead of Format
|
|
Out io.Writer // stdout
|
|
ErrOut io.Writer // stderr
|
|
FileIO fileio.FileIO // file transfer abstraction; required when saving files (--output or binary response)
|
|
CommandPath string // raw cobra CommandPath() for content safety scanning
|
|
// Identity is forwarded to CheckError (default or caller-supplied) so the
|
|
// classifier can populate identity-aware fields (e.g. PermissionError.Identity).
|
|
// Defaults to core.AsUser when empty.
|
|
Identity core.Identity
|
|
// CheckError is called on parsed JSON results. Nil defaults to (*APIClient).CheckResponse
|
|
// with the Identity field (or AsUser when unset).
|
|
CheckError func(result interface{}, identity core.Identity) error
|
|
}
|
|
|
|
// HandleResponse routes a raw *larkcore.ApiResp to the appropriate output:
|
|
// 1. If Content-Type is JSON, check for business errors first (even with --output).
|
|
// 2. If --output is set and response is not a JSON error, save to file.
|
|
// 3. If Content-Type is non-JSON and no --output, auto-save binary to file.
|
|
func HandleResponse(resp *larkcore.ApiResp, opts ResponseOptions) error {
|
|
ct := resp.Header.Get("Content-Type")
|
|
identity := opts.Identity
|
|
if identity == "" {
|
|
identity = core.AsUser
|
|
}
|
|
check := opts.CheckError
|
|
if check == nil {
|
|
// Default check routes through BuildAPIError, producing typed
|
|
// *errs.PermissionError / AuthenticationError / etc. A zero-value
|
|
// *APIClient is safe here because BuildAPIError gracefully degrades
|
|
// identity-aware fields (ConsoleURL etc.) when AppID is empty.
|
|
check = func(r interface{}, id core.Identity) error {
|
|
return (&APIClient{}).CheckResponse(r, id)
|
|
}
|
|
}
|
|
|
|
// Non-JSON error responses (e.g. 404 text/plain from gateway): return error directly
|
|
// instead of falling through to the binary-save path.
|
|
// 5xx → typed NetworkError (server/transport tier); 4xx → typed APIError (client error).
|
|
if resp.StatusCode >= 400 && !IsJSONContentType(ct) && ct != "" {
|
|
body := util.TruncateStrWithEllipsis(strings.TrimSpace(string(resp.RawBody)), 500)
|
|
if resp.StatusCode >= 500 {
|
|
return errs.NewNetworkError(errs.SubtypeNetworkServer,
|
|
"HTTP %d: %s", resp.StatusCode, body).
|
|
WithCode(resp.StatusCode)
|
|
}
|
|
subtype := errs.SubtypeUnknown
|
|
if resp.StatusCode == 404 {
|
|
subtype = errs.SubtypeNotFound
|
|
}
|
|
return errs.NewAPIError(subtype, "HTTP %d: %s", resp.StatusCode, body).
|
|
WithCode(resp.StatusCode)
|
|
}
|
|
|
|
// JSON responses: always check for business errors before saving.
|
|
if IsJSONContentType(ct) || ct == "" {
|
|
result, err := ParseJSONResponse(resp)
|
|
if err != nil {
|
|
return WrapJSONResponseParseError(err, resp.RawBody)
|
|
}
|
|
if apiErr := check(result, identity); apiErr != nil {
|
|
return apiErr
|
|
}
|
|
// Content safety scanning
|
|
scanResult := output.ScanForSafety(opts.CommandPath, result, opts.ErrOut)
|
|
if scanResult.Blocked {
|
|
return scanResult.BlockErr
|
|
}
|
|
if opts.OutputPath != "" {
|
|
if scanResult.Alert != nil {
|
|
output.WriteAlertWarning(opts.ErrOut, scanResult.Alert)
|
|
}
|
|
return saveAndPrint(opts.FileIO, resp, opts.OutputPath, opts.Out)
|
|
}
|
|
if scanResult.Alert != nil {
|
|
output.WriteAlertWarning(opts.ErrOut, scanResult.Alert)
|
|
}
|
|
if opts.JqExpr != "" {
|
|
return output.JqFilter(opts.Out, result, opts.JqExpr)
|
|
}
|
|
output.FormatValue(opts.Out, result, opts.Format)
|
|
return nil
|
|
}
|
|
|
|
// Non-JSON (binary) responses.
|
|
if opts.JqExpr != "" {
|
|
return errs.NewValidationError(errs.SubtypeInvalidArgument,
|
|
"--jq requires a JSON response (got Content-Type: %s)", ct).
|
|
WithParam("--jq")
|
|
}
|
|
if opts.OutputPath != "" {
|
|
return saveAndPrint(opts.FileIO, resp, opts.OutputPath, opts.Out)
|
|
}
|
|
|
|
// No --output: auto-save with derived filename.
|
|
meta, err := SaveResponse(opts.FileIO, resp, ResolveFilename(resp))
|
|
if err != nil {
|
|
return classifySaveErr(err)
|
|
}
|
|
fmt.Fprintf(opts.ErrOut, "binary response detected (Content-Type: %s), saved to file\n", ct)
|
|
output.PrintJson(opts.Out, meta)
|
|
return nil
|
|
}
|
|
|
|
func saveAndPrint(fio fileio.FileIO, resp *larkcore.ApiResp, path string, w io.Writer) error {
|
|
meta, err := SaveResponse(fio, resp, path)
|
|
if err != nil {
|
|
return classifySaveErr(err)
|
|
}
|
|
output.PrintJson(w, meta)
|
|
return nil
|
|
}
|
|
|
|
// classifySaveErr routes a SaveResponse error to the right typed shape.
|
|
// Path-validation failures are caller-induced (an unsafe --output path),
|
|
// so they surface as ValidationError on --output. Mkdir / write failures
|
|
// are local I/O issues classified as InternalError with SubtypeFileIO.
|
|
func classifySaveErr(err error) error {
|
|
if errors.Is(err, fileio.ErrPathValidation) {
|
|
return errs.NewValidationError(errs.SubtypeInvalidArgument, "%v", err).WithParam("--output")
|
|
}
|
|
return errs.NewInternalError(errs.SubtypeFileIO, "save response: %v", err).WithCause(err)
|
|
}
|
|
|
|
// ── JSON helpers ──
|
|
|
|
// IsJSONContentType reports whether the Content-Type header indicates a JSON response.
|
|
func IsJSONContentType(ct string) bool {
|
|
return strings.Contains(ct, "application/json") || strings.Contains(ct, "text/json")
|
|
}
|
|
|
|
// ParseJSONResponse decodes a raw SDK response body as JSON.
|
|
// CallAPI and HandleResponse both delegate to this function.
|
|
func ParseJSONResponse(resp *larkcore.ApiResp) (interface{}, error) {
|
|
var result interface{}
|
|
dec := json.NewDecoder(bytes.NewReader(resp.RawBody))
|
|
dec.UseNumber()
|
|
if err := dec.Decode(&result); err != nil {
|
|
return nil, fmt.Errorf("response parse error: %w (body: %s)", err, util.TruncateStr(string(resp.RawBody), 500))
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
// ── File saving ──
|
|
|
|
// SaveResponse writes an API response body to the given outputPath and returns metadata.
|
|
// It delegates to FileIO.Save for path validation and atomic write; fio must not be nil.
|
|
func SaveResponse(fio fileio.FileIO, resp *larkcore.ApiResp, outputPath string) (map[string]interface{}, error) {
|
|
result, err := fio.Save(outputPath, fileio.SaveOptions{
|
|
ContentType: resp.Header.Get("Content-Type"),
|
|
ContentLength: int64(len(resp.RawBody)),
|
|
}, bytes.NewReader(resp.RawBody))
|
|
if err != nil {
|
|
var me *fileio.MkdirError
|
|
var we *fileio.WriteError
|
|
switch {
|
|
case errors.Is(err, fileio.ErrPathValidation):
|
|
return nil, fmt.Errorf("unsafe output path: %w", err)
|
|
case errors.As(err, &me):
|
|
return nil, fmt.Errorf("create directory: %w", err)
|
|
case errors.As(err, &we):
|
|
return nil, fmt.Errorf("cannot write file: %w", err)
|
|
default:
|
|
return nil, fmt.Errorf("cannot write file: %w", err)
|
|
}
|
|
}
|
|
|
|
resolvedPath, err := fio.ResolvePath(outputPath)
|
|
if err != nil || resolvedPath == "" {
|
|
resolvedPath = outputPath
|
|
}
|
|
return map[string]interface{}{
|
|
"saved_path": resolvedPath,
|
|
"size_bytes": result.Size(),
|
|
"content_type": resp.Header.Get("Content-Type"),
|
|
}, nil
|
|
}
|
|
|
|
// ResolveFilename picks a filename from the response headers.
|
|
// Priority: Content-Disposition filename > Content-Type extension > "download.bin".
|
|
func ResolveFilename(resp *larkcore.ApiResp) string {
|
|
if name := larkcore.FileNameByHeader(resp.Header); name != "" {
|
|
return name
|
|
}
|
|
return "download" + mimeToExt(resp.Header.Get("Content-Type"))
|
|
}
|
|
|
|
// mimeToExt maps a Content-Type to a file extension (with leading dot).
|
|
func mimeToExt(ct string) string {
|
|
if ct == "" {
|
|
return ".bin"
|
|
}
|
|
mediaType, _, _ := mime.ParseMediaType(ct)
|
|
switch mediaType {
|
|
case "application/pdf":
|
|
return ".pdf"
|
|
case "image/png":
|
|
return ".png"
|
|
case "image/jpeg":
|
|
return ".jpg"
|
|
case "image/gif":
|
|
return ".gif"
|
|
case "text/plain":
|
|
return ".txt"
|
|
case "text/csv":
|
|
return ".csv"
|
|
case "text/html":
|
|
return ".html"
|
|
case "application/zip":
|
|
return ".zip"
|
|
case "application/xml", "text/xml":
|
|
return ".xml"
|
|
case "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet":
|
|
return ".xlsx"
|
|
case "application/vnd.openxmlformats-officedocument.wordprocessingml.document":
|
|
return ".docx"
|
|
case "application/vnd.openxmlformats-officedocument.presentationml.presentation":
|
|
return ".pptx"
|
|
default:
|
|
return ".bin"
|
|
}
|
|
}
|